profile
viewpoint
Tony Arnold tonyarnold Itty Bitty Apps, Bjango & The CocoaBots Newcastle, Australia http://tonyarnold.com/ Lead Developer at Itty Bitty Apps. Cocoa-wielding adventure seeker. Slayer of bugs and misconfiguration.

iwasrobbed/Down 1610

Blazing fast Markdown / CommonMark rendering in Swift, built upon cmark.

kolinkrewinkel/Polychromatic 1069

Semantic highlighting for Xcode.

jessesquires/JSQCoreDataKit 516

A swifter Core Data stack

neilang/NAMapKit 261

Allows you to use custom maps in iphone applications and attempts to mimics some of the behaviour of the MapKit framework

notiflux/OpenCore-Configurator 160

A configurator for the OpenCore Bootloader

tonyarnold/BrightnessMenulet 2

BrightnessMenulet is an Mac OS X app that allows you to control display brightness via DDC/CI protocol

tonyarnold/Accio 0

A dependency manager driven by SwiftPM that works for iOS/tvOS/watchOS/macOS projects.

tonyarnold/ADNKit 0

Objective-C framework for building App.net applications on iOS and OS X

tonyarnold/advancedtomato2 0

AdvancedTomato V2 repository based on Tomato by Shibby builds.

tonyarnold/AFNetworking-RACExtensions 0

A delightful extension to the AFNetworking classes for iOS and Mac OS X.

startedapple/swift-algorithms

started time in 15 days

push eventtonyarnold/jobs

Tony Arnold

commit sha 5e1542f74106921a58901e7ef5e58bb5a8acc022

Remove unnecessary try

view details

push time in 18 days

push eventtonyarnold/jobs

Tony Arnold

commit sha 790743a1f497eebcf3dc98b88118423c3de2fde5

Use the container's event loop

view details

push time in 18 days

create barnchtonyarnold/jobs-postgresql-driver

branch : feature/jobs-api-update-new

created branch time in 18 days

create barnchtonyarnold/jobs

branch : feature/backport-worker-new

created branch time in 18 days

delete branch tonyarnold/docker

delete branch : swift-5.3

delete time in 18 days

pull request commentvapor/docker

Add support for Swift 5.3

No harm done! It was a quick one to throw together, and following the conversation on Discord I understand why this decision was made. Thanks for all of your hard work 👍

tonyarnold

comment created time in 18 days

PR opened vapor/docker

Add support for Swift 5.3

Sorry if this doesn't trip the right switches to make this work - I'm running through updating dependencies on an older app that I can't update from Vapor 3 due to missing functionality in Vapor 4, and I thought it might be useful/nice to have a Swift 5.3 docker image to work from.

+3 -3

0 comment

3 changed files

pr created time in 18 days

push eventtonyarnold/docker

Tony Arnold

commit sha 52fbea45714098fa8dceefca57a86362b5f7babf

Add support for Swift 5.3

view details

push time in 18 days

create barnchtonyarnold/docker

branch : swift-5.3

created branch time in 18 days

issue commentmicrosoft/appcenter

Analytics: More detailed OS version distribution

This has been frustrating me, too:

twitter_EjkMbIIU4AAYiqs

"Other" is completely unhelpful (these are macOS releases here) - it represents a significant number of users, but there's no way to get more information from this other than spending an hour setting up communication with the backend API.

Please consider exposing more detailed information for everything on the overview screen - as it is, it's not really useful for any kind of real decision making.

miklselsoe

comment created time in 18 days

startedapple/swift-system

started time in 25 days

issue commentactions/virtual-environments

Add support for Xcode 12 (iOS 14)

@alexhultman no, Apple Silicon support was removed from Xcode 12.0. It ships with the macOS 10.15 Catalina SDK.

It was moved to Xcode 12.2 beta, which includes the macOS 11 SDK.

zevmo

comment created time in a month

issue openedwzieba/AppCenter-Github-Action

Question: how does this action handle multi-line release notes?

I've been calling the AppCenter CLI tool directly, and attempting to use the contents of ${{github.event.release.body}} to populate my release notes, however it appears that I need to do some pre-processing to convert the newlines/special characters to something more appropriate for use on the command line.

It doesn't look like this action does anything to help here, but I was thinking maybe it should?

Something simple to pre-process the incoming release notes text, or wrap the argument contents in a multiline argument directly would be super helpful.

created time in a month

delete branch tonyarnold/AppCenter-Github-Action

delete branch : feature/missing-macos-arguments

delete time in a month

PR opened wzieba/AppCenter-Github-Action

Add support for the build-version and build-number arguments

This PR proposes adding support for the build-version and build-number arguments to the CLI tool. These are often required for macOS-based projects.

+15 -0

0 comment

2 changed files

pr created time in a month

fork tonyarnold/AppCenter-Github-Action

This action uploads artifacts (.apk or .ipa) to Visual Studio App Center.

fork in a month

fork tonyarnold/Latest

A small utility app for macOS that makes sure you know about all the latest updates to the apps you use.

https://max.codes/latest

fork in a month

startedsoulverteam/SoulverCore

started time in a month

delete branch revealapp/Papr

delete branch : polish-home

delete time in 2 months

delete branch revealapp/Papr

delete branch : papr-tinyNetworking-version

delete time in 2 months

delete branch revealapp/Papr

delete branch : papr-moya-version

delete time in 2 months

delete branch revealapp/Papr

delete branch : new-explore

delete time in 2 months

delete branch revealapp/Papr

delete branch : load-images-with-animation

delete time in 2 months

delete branch revealapp/Papr

delete branch : change-home-layout

delete time in 2 months

delete branch revealapp/Papr

delete branch : update-pods

delete time in 2 months

delete branch revealapp/Papr

delete branch : support-dark-theme

delete time in 2 months

delete branch revealapp/Papr

delete branch : rxdatasources-not-working

delete time in 2 months

delete branch revealapp/Papr

delete branch : minor/redesign-login

delete time in 2 months

delete branch revealapp/Papr

delete branch : remove-package-vanillaConstraints

delete time in 2 months

delete branch revealapp/Papr

delete branch : adding-UI-bugs

delete time in 2 months

delete branch revealapp/Papr

delete branch : feature/mapkit-annotation

delete time in 2 months

delete branch revealapp/Papr

delete branch : feature/voice-over

delete time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentDechengMa/Papr

Feature/Add Mapkit annotation page and bug demo

 SPEC CHECKSUMS:   RxNuke: 7c56f40f26bc3ec715cff5f5355119ca7989b010   RxRelay: 89d54507f4fd4d969e6ec1d4bd7f3673640b4640   RxSwift: e2dc62b366a3adf6a0be44ba9f405efd4c94e0c4-  TinyNetworking: f373ddd43edc5320ff98059ff484591970fbfb17+  TinyNetworking: c0b2cbfe8db8451e42c3371a3eecfc61538b310a

That's fine - something look out for in the future.

Generally, I try to stay on top of updates to dependencies, even without a reason for it, but I do like to sequester them into their own PR when I make the change, just so any breakage can be isolated.

DechengMa

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentDechengMa/Papr

Feature/Add Mapkit annotation page and bug demo

 SPEC CHECKSUMS:   RxNuke: 7c56f40f26bc3ec715cff5f5355119ca7989b010   RxRelay: 89d54507f4fd4d969e6ec1d4bd7f3673640b4640   RxSwift: e2dc62b366a3adf6a0be44ba9f405efd4c94e0c4-  TinyNetworking: f373ddd43edc5320ff98059ff484591970fbfb17+  TinyNetworking: c0b2cbfe8db8451e42c3371a3eecfc61538b310a

Was there a reason that you updated the TinyNetworking dependency?

DechengMa

comment created time in 2 months

Pull request review commentDechengMa/Papr

Feature/Add Mapkit annotation page and bug demo

+//+//  BaseAnnotationView.swift+//  Papr+//+//  Created by Decheng Ma on 4/9/20.+//  Copyright © 2020 Joan Disho. All rights reserved.+//++import UIKit++class BaseAnnotationView: UIView {+    let photoAnnotation: PhotoAnnotation++    var imageView: UIImageView {+        guard+            let url = URL(string: photoAnnotation.photoUrl),+            let data = try? Data(contentsOf: url) else {+                return UIImageView()+        }++        let imageView = UIImageView(frame: CGRect(x: 5, y: 5, width: 50, height: 30))+        imageView.clipsToBounds = true+        imageView.contentMode = .scaleAspectFill+        imageView.image = UIImage(data: data)++        return imageView+    }++    init(_ photoAnnotation: PhotoAnnotation) {+        self.photoAnnotation = photoAnnotation+        super.init(frame: CGRect(x: 0, y: 0, width: 60, height: 60))++        setupUI()+    }++    private func setupUI() {+        let pinIconView = UIImageView(frame: CGRect(x: 0, y: 0, width: 60, height: 60))+        pinIconView.image = UIImage(named: "map-pin-icon")++        self.clipsToBounds = true+        self.addSubview(imageView)+        self.addSubview(pinIconView)+    }++    func photoView() -> UIImageView {+        self.imageView+    }++    func renderSelfAsImage() -> UIImage {+        let renderer = UIGraphicsImageRenderer(bounds: self.bounds)+        return renderer.image { rendererContext in+            self.layer.render(in: rendererContext.cgContext)+        }+    }++    required init?(coder: NSCoder) {+        fatalError("init(coder:) has not been implemented")

FYI, you can more reusably express unimplemented methods like so:

        fatalError("\(#function) has not been implemented")
DechengMa

comment created time in 2 months

Pull request review commentDechengMa/Papr

Feature/Add Mapkit annotation page and bug demo

+{+  "images" : [+    {+      "idiom" : "universal",+      "scale" : "1x"+    },+    {+      "idiom" : "universal",+      "scale" : "2x"+    },+    {+      "filename" : "defualtMarker2.png",

This filename has a typo - defualtdefault

DechengMa

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentDechengMa/Papr

Add voice over example to home page

 class HomeViewCell: UICollectionViewCell, BindableType,  ClassIdentifiable {         stackView.addArrangedSubview(footerView)     } }++extension HomeViewCell {+    private func applyAccessbility(with outputs: HomeViewCellModelOutput) {+        outputs.photoStream+            .map { $0.description }

FYI, you may find that you can express this as .map(\.description) in most locations if you are using Xcode 11 or later. I'm not sure if RxSwift's overloads support this, but certainly in general Swift, and Combine, it's :+1:

DechengMa

comment created time in 2 months

PullRequestReviewEvent

push eventtonyarnold/ClangFormatXcode

Tony Arnold

commit sha 762bffd75b7bdd06cf76741073009873cb2c1d05

Fix version information and app category

view details

push time in 2 months

push eventtonyarnold/ClangFormatXcode

Tony Arnold

commit sha 1f039da6c1ad75da5c048fed3094e01ce75007b3

Update to Clang 10.0.1

view details

Tony Arnold

commit sha 394f771bdfdd96691309471961c5e75fec494867

Apply changes suggested by Xcode 12 beta 6

view details

push time in 2 months

issue commentvapor/fluent-kit

@Enum array

@tanner0101 I'm still seeing quite a similar issue to this in the latest release of FluentKit:

enum Role: Int16, Content, CaseIterable {
  case one = 1
  case two = 2
  case three = 3
}

The field on the model:

@Field(key: "roles")
var roles: [Role]

My migration for this field:

.field("roles", .array(of: .int16))

When I try to save an instance of the model, I get this error:

failed: caught error: "invalid field: roles type: Array<Role> error: Unexpected data type: SMALLINT[]. Expected array."
gperdomor

comment created time in 2 months

pull request commentrevealapp/Revert

Add context menu to ControlsViewController

Excellent sleuthing, and changes. Thanks, Decheng!

DechengMa

comment created time in 2 months

PullRequestReviewEvent

pull request commentrevealapp/Revert

Add context menu to ControlsViewController

My code looks pretty normal

It could be something specific to CI, I'd download the logs and have a look at what's going wrong. I'm happy to help you resolve it once you've found the error.

DechengMa

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapple/swift

Add warning about spaces in the Xcode path.

@davidungar yeah, I'm seeing the same behaviour here, so dataPoint += 1 - I've added some details to the public bug report.

davidungar

comment created time in 2 months

pull request commentapple/swift

Add warning about spaces in the Xcode path.

Have you tried it lately?

No, honestly I haven't for a month or so, so I'm sorry to cause extra work over pedantry, but it's not helpful to non-Apple staff to have radar/feedback links in these PRs.

It's obviously a bit of a struggle for you folk with Swift being Apple's baby, and Swift being an open source project 😄

Thanks for creating a public issue, and for updating the changes - I appreciate it.

davidungar

comment created time in 2 months

pull request commentapple/swift

Add warning about spaces in the Xcode path.

I feel impolite asking this, but can you provide some context or detail that explains why this is necessary? I regularly name my installed Xcode versions with spaces in their names.

davidungar

comment created time in 2 months

Pull request review commentrevealapp/Revert

Convert all model objects to `Decodable` and get rid of legacy codes

-// //  Copyright © 2015 Itty Bitty Apps. All rights reserved.  import UIKit -final class DataSource<Object: Collectable, Cell: UITableViewCell>: NSObject, UITableViewDataSource {-  typealias CellConfigurator = (Cell, _ object: Object) -> Void-  typealias FooterTitleRetriever = ((CollectableGroup<Object>) -> String?)?+final class DataSource<Section: RevertSection, Cell: UITableViewCell>: NSObject, UITableViewDataSource {+  typealias CellConfigurator = (Cell, Section.Item) -> Void+  typealias FooterTitleRetriever = ((Section) -> String?)? -  required init(collection: CollectableCollection<Object>, configureCell: @escaping CellConfigurator, cellIdentifier: String, titleForFooter: FooterTitleRetriever = nil) {-    self.unfilteredCollection = collection-    self.collection = collection-    self.configureCell = configureCell+  // MARK: - Private Properties++  private var sections: [Section]+  private let cellIdentifier: String+  private let configureCell: CellConfigurator+  private let titleForFooter: FooterTitleRetriever+++  // MARK: - Init++  required init(sections: [Section], cellIdentifier: String, configureCell: @escaping CellConfigurator, titleForFooter: FooterTitleRetriever = nil) {+    self.sections = sections     self.cellIdentifier = cellIdentifier+    self.configureCell = configureCell     self.titleForFooter = titleForFooter      super.init()   } -  // MARK: UITableViewDataSource+  // MARK: - Public methods++  subscript(indexPath: IndexPath) -> Section.Item {+    return sections[indexPath.section].rows[indexPath.row]+  }++  // MARK: - UITableViewDataSource    func numberOfSections(in tableView: UITableView) -> Int {-    return self.collection.countOfItems+    return sections.count   }    func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {-    return self.collection[section].countOfItems+    return sections[section].rows.count   }    func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {-    guard let cell = tableView.dequeueReusableCell(withIdentifier: self.cellIdentifier) as? Cell else {+    guard let cell = tableView.dequeueReusableCell(withIdentifier: cellIdentifier) as? Cell else {       fatalError("Expecting to dequeue a `\(Cell.self)` from the tableView")     } -    self.configureCell(cell, self.collection[indexPath])+    self.configureCell(cell, self[indexPath])     return cell   }    func tableView(_ tableView: UITableView, titleForHeaderInSection section: Int) -> String? {-    return self.collection[section].title+    return sections[section].title   }    func tableView(_ tableView: UITableView, titleForFooterInSection section: Int) -> String? {-    return self.titleForFooter?(self.collection[section])+    return self.titleForFooter?(sections[section])   }--  #if os(iOS)--    func sectionIndexTitles(for tableView: UITableView) -> [String]? {-      let items = self.collection.items-        .map { $0.title }-        .compactMap { $0 }--      return items.count > 0 ? items : nil-    }-  #endif--  subscript(indexPath: IndexPath) -> Object {-    return self.collection[indexPath]-  }--  func clearFilter() {-    self.collection = self.unfilteredCollection-  }--  func filter(_ filterClosure: ((Object) -> Bool)) {-    self.collection = self.unfilteredCollection.filteredCollectableCollection(filterClosure)-  }

Was this ever wired up to a search field on the main tableview? Odd that the code was written, but not used.

nabby26

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentrevealapp/Revert

Convert all model objects to `Decodable` and get rid of legacy codes

 enum RevertItems: String {   case view = "ViewItems"   case whatsNew = "NewItems" -  var data: [[String: AnyObject]] {-    guard let data = NSArray(contentsOf: self.URL) as? [[String: AnyObject]] else {-      fatalError(self.invalidContentError)-    }-    return data-  }--  func newData<T: Decodable>() -> T {+  func Data<T: Decodable>() -> T {

Oooh I missed this one. Yeah, no, please follow the Swift naming guidelines unless there's a really good reason not to.

nabby26

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentrevealapp/Revert

Convert all model objects to `Decodable` and get rid of legacy codes

 enum RevertItems: String {   case view = "ViewItems"   case whatsNew = "NewItems" -  var data: [[String: AnyObject]] {-    guard let data = NSArray(contentsOf: self.URL) as? [[String: AnyObject]] else {-      fatalError(self.invalidContentError)-    }-    return data-  }--  func newData<T: Decodable>() -> T {+  func Data<T: Decodable>() -> T {     do {-      let data = try Data(contentsOf: self.URL)+      let data = try Foundation.Data(contentsOf: self.URL)

What's gone wrong that you need to fully qualify Foundation's Data in this way?

nabby26

comment created time in 2 months

PullRequestReviewEvent

issue commentbitrise-steplib/steps-generate-changelog

Step fails when changelog is huge

Thanks, @adamivancza, that did the trick!

adamivancza

comment created time in 2 months

delete branch tonyarnold/Differ

delete branch : xcode-12

delete time in 2 months

push eventtonyarnold/Differ

Tony Arnold

commit sha 4caa876e3cf4dde32d1108b78b50314da5da3181

Update documented build requirements

view details

Tony Arnold

commit sha 976e98e28a5febad583cae4d2eefb3d86df5df0d

Bump the minimum deployment targets to versions supported by Xcode 12

view details

Tony Arnold

commit sha 33e39935d5ce31af079b6d1a28df42fd0817b00a

Merge pull request #75 from tonyarnold/xcode-12 Xcode 12 beta support

view details

push time in 2 months

PR merged tonyarnold/Differ

Xcode 12 beta support

This PR proposes changes to support building with Xcode 12 beta.

One notable change is that I have raised the minimum deployment targets of all supported OSes (excepting tvOS 9, which seems to be present in Xcode 12).

This PR will require a bump to the major version of this library due to the new requirements.

+12 -6

0 comment

4 changed files

tonyarnold

pr closed time in 2 months

issue commentbitrise-steplib/steps-generate-changelog

Step fails when changelog is huge

Can someone from Bitrise provide a bit more detail on how to apply this workaround, please? Do I need to put the workaround in a script in my local repositories workflow?

adamivancza

comment created time in 2 months

push eventtonyarnold/Differ

Tony Arnold

commit sha 4caa876e3cf4dde32d1108b78b50314da5da3181

Update documented build requirements

view details

Tony Arnold

commit sha 976e98e28a5febad583cae4d2eefb3d86df5df0d

Bump the minimum deployment targets to versions supported by Xcode 12

view details

push time in 2 months

push eventtonyarnold/Differ

Tony Arnold

commit sha 4bfcb65238285c1e4d4ac343288312922fcecf19

Update the Xcode versions used by the CI workflow

view details

Tony Arnold

commit sha 4d22c5d24a838dd4ae8d4bd0b23859de06f54bf5

Udpate documented build requirements

view details

Tony Arnold

commit sha 9eb0f27ef44f517d3886f80fcc67313af36b162f

Bump the minimum deployment targets to versions supported by Xcode 12

view details

push time in 2 months

push eventtonyarnold/Differ

Tony Arnold

commit sha 4bfcb65238285c1e4d4ac343288312922fcecf19

Update the Xcode versions used by the CI workflow

view details

push time in 2 months

pull request commentrevealapp/Revert

Use Decodable for `HomeItem` model class

Great work, Nabby! Thanks for the effort and time you put into this.

nabby26

comment created time in 2 months

Pull request review commentrevealapp/Revert

Use Decodable for `HomeItem` model class

+// Copyright © 2020 Itty Bitty Apps. All rights reserved.++import Foundation++protocol SectionItem: Decodable {

I'm not sure why we did that, to be honest. I wonder if it's time to make both modules just plain old Revert?

nabby26

comment created time in 2 months

Pull request review commentrevealapp/Revert

Use Decodable for `HomeItem` model class

+// Copyright © 2020 Itty Bitty Apps. All rights reserved.++import Foundation++protocol SectionItem: Decodable {

I'd go even simpler, to be honest - the fully qualified name of the class will be Module.Type, so it's already formally Revert.Section.

nabby26

comment created time in 2 months

issue commentactions/virtual-environments

Xcode 12 beta 4

@maxim-lobanov is there any way that GitHub could accelerate the release of these betas? Having our CI tooling lag behind our seeded tooling by two weeks is becoming a problem.

SebastianBoldt

comment created time in 2 months

Pull request review commentrevealapp/Revert

Use Decodable for `HomeItem` model class

+// Copyright © 2020 Itty Bitty Apps. All rights reserved.++import Foundation++protocol SectionItem: Decodable {+  associatedtype item

Same as the earlier comment: this type alias should probably start with an uppercase letter.

nabby26

comment created time in 2 months

Pull request review commentrevealapp/Revert

Use Decodable for `HomeItem` model class

+// Copyright © 2020 Itty Bitty Apps. All rights reserved.++import UIKit++/// The purpose of this class is to eventually replace the current custom data source class (`DataSource`).+/// The existing custom class is more complex and incompatible with models that extend `Decodable`.+final class NewDataSource<Model: Decodable, Cell: UITableViewCell>: NSObject, UITableViewDataSource {+  typealias Models = [[Model]]

Is that… is that an array of arrays? 🤢

nabby26

comment created time in 2 months

Pull request review commentrevealapp/Revert

Use Decodable for `HomeItem` model class

+// Copyright © 2020 Itty Bitty Apps. All rights reserved.++import Foundation++struct HomeSectionItem: SectionItem {+  typealias item = HomeItem

Type names should generally always start with an uppercase letter. This includes type aliases 👍

Can you safely remove the explicit type alias declaration here, and let Swift's type inference fill in the holes, or is it still required?

nabby26

comment created time in 2 months

Pull request review commentrevealapp/Revert

Use Decodable for `HomeItem` model class

-//-//  Copyright © 2016 Itty Bitty Apps. All rights reserved.+// Copyright © 2016 Itty Bitty Apps. All rights reserved. -import UIKit+import Foundation -final class CollectionDataSource<Object: Collectable, Cell: UICollectionViewCell>: NSObject, UICollectionViewDataSource {-  typealias CellConfigurator = (HomeCollectionCell, _ item: HomeItem) -> Void-  typealias ItemFilterClosure = (HomeItem) -> Bool-  typealias GroupFilterClosure = (CollectableGroup<HomeItem>) -> Bool+final class CollectionDataSource<Section: SectionItem, Cell: UICollectionViewCell>: NSObject, UICollectionViewDataSource {+  typealias CellConfigurator = (Cell, Section.item) -> Void+  typealias GroupFilterClosure = ((Section) -> Bool)+  typealias ItemFilterClosure = (Section.item) -> Bool -  required init(collection: CollectableCollection<HomeItem>, configureCell: @escaping CellConfigurator, cellIdentifier: String) {-    self.unfilteredCollection = collection-    self.collection = collection+  // MARK: - Private properties++  private let unfilteredSections: [Section]+  private var sections: [Section]+  private let cellIdentifier: String+  private let configureCell: CellConfigurator++  // MARK: - Init++  required init(sections: [Section], configureCell: @escaping CellConfigurator, cellIdentifier: String) {+    self.unfilteredSections = sections+    self.sections = sections     self.configureCell = configureCell     self.cellIdentifier = cellIdentifier      super.init()   } +  // MARK: - UICollectionViewDataSource+   func numberOfSections(in collectionView: UICollectionView) -> Int {-    return self.collection.countOfItems+    sections.count   }    func collectionView(_ collectionView: UICollectionView, numberOfItemsInSection section: Int) -> Int {-    return self.collection[section].countOfItems+    sections[section].rows.count   }    func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell {-    guard let cell = collectionView.dequeueReusableCell(withReuseIdentifier: self.cellIdentifier, for: indexPath) as? HomeCollectionCell else {+    guard let cell = collectionView.dequeueReusableCell(withReuseIdentifier: cellIdentifier, for: indexPath) as? Cell else {       fatalError("Expecting to dequeue a `CollectionViewCell` from the collectionView")     } -    let item = self.collection[indexPath]+    let item = sections[indexPath.section].rows[indexPath.row]

I'd suggest that you use the subscript that you've added below, here. Best to "eat your own dog food" and use the same APIs that you vend for other bits of the codebase unless there's a good reason not to.

nabby26

comment created time in 2 months

Pull request review commentrevealapp/Revert

Use Decodable for `HomeItem` model class

-//-//  Copyright © 2016 Itty Bitty Apps. All rights reserved.+// Copyright © 2020 Itty Bitty Apps. All rights reserved.

Brilliant, ta!

nabby26

comment created time in 2 months

Pull request review commentrevealapp/Revert

Use Decodable for `HomeItem` model class

-//-//  Copyright © 2016 Itty Bitty Apps. All rights reserved.+// Copyright © 2020 Itty Bitty Apps. All rights reserved.

Okey doke — I'm going to point this nit pick out and then go do a full (proper) review, because this ain't it, Chief 😉

You don't every need to update the copyright of a source code file. The year in here is an indication of when the copyright is valid from (ie. the creation date of the file). It's honestly nonsense, and I'd prefer we stop including it, but the "Copyright/All rights reserved" to IBA is the important bit here - the rest can probably be derived from metadata.

I would recommend changing this copyright header (and any others) back to their original state. I'm happy for the white space changes to stay, if they're consistent with the other files.

nabby26

comment created time in 2 months

issue commenttonyarnold/Differ

Revision of UIKit Overlay's API

@jenox if you still have interest in making these changes, #75 is going to require a bump to the major version of the library, so I'd be happy to roll in your proposal.

jenox

comment created time in 3 months

PR opened tonyarnold/Differ

Xcode beta 12 support

This PR proposes changes to support building with Xcode 12 beta.

One notable change is that I have raised the minimum deployment targets of all supported OSes (excepting tvOS 9, which seems to be present in Xcode 12).

+21 -15

0 comment

5 changed files

pr created time in 3 months

create barnchtonyarnold/Differ

branch : xcode-12

created branch time in 3 months

startedbelozierov/SwiftCoroutine

started time in 3 months

create barnchtonyarnold/BinUtils

branch : swift-5.2

created branch time in 3 months

fork tonyarnold/BinUtils

Swift functions to ease working with binary formats

fork in 3 months

push eventtonyarnold/peertalk

Tony Arnold

commit sha 8cfde22dcac2db5da220ec4132099f067edbe7a6

Use the stored error value This resolves a static analysis warning about the value stored to `error` never being read, and following uses seem to indicate this individual case might be a typo.

view details

push time in 3 months

more