profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/tkashem/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Abu Kashem tkashem Red Hat Boston, MA

operator-framework/operator-lifecycle-manager 1050

A management framework for extending Kubernetes with Operators

operator-framework/operator-marketplace 87

Marketplace Operator

operator-framework/go-appr 4

Go client bindings for App Registry

tkashem/dittybopper 1

Deploy Mutable Grafana with Performance Analysis Dashboards to OpenShift

tkashem/api 0

Canonical location of the OpenShift API definition.

tkashem/apiserver-library-go 0

k/k dependent helpers for kube-apiserver and openshift-apiserver

tkashem/arsenal 0

Cache of ElasticSearch templates and Grafana dashboards that can be used to powerup fellow repos viz Ripsaw

tkashem/client-go 0

Go client for Kubernetes.

tkashem/cluster-authentication-operator 0

OpenShift operator for the top level Authentication and OAuth configs.

pull request commentkubernetes/kubernetes

Add doc.go explaining client-go apply support

/lgtm

jpbetz

comment created time in a minute

Pull request review commentopenshift/origin

Fix image API extended test flake

 func (e *hookExecutor) tagImages(hook *appsv1.LifecycleHook, rc *corev1.Replicat 		if len(namespace) == 0 { 			namespace = rc.Namespace 		}-		if _, err := e.tags.ImageStreamTags(namespace).Update(context.Background(), &imageapiv1.ImageStreamTag{-			ObjectMeta: metav1.ObjectMeta{-				Name:      action.To.Name,-				Namespace: namespace,-			},-			Tag: &imageapiv1.TagReference{-				From: &corev1.ObjectReference{-					Kind: "DockerImage",-					Name: value,+		err := retry.RetryOnConflict(retry.DefaultRetry, func() error {+			_, updateErr := e.tags.ImageStreamTags(namespace).Update(context.Background(), &imageapiv1.ImageStreamTag{+				ObjectMeta: metav1.ObjectMeta{+					Name:      action.To.Name,+					Namespace: namespace, 				},-			},-		}, metav1.UpdateOptions{}); err != nil {+				Tag: &imageapiv1.TagReference{+					From: &corev1.ObjectReference{+						Kind: "DockerImage",+						Name: value,+					},+				},+			}, metav1.UpdateOptions{})+			return updateErr+		})+		if err != nil { 			errs = append(errs, err)-			continue

I'd keep it

mfojtik

comment created time in 3 minutes

pull request commentopenshift/origin

Bug 1973667: undisable NetworkPolicy tests [4.8]

@danwinship: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack f7023f3648addbdb50cf9876aa5df2072d767713 link /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-gcp c04064363cc8d5659b8ddc8b6674fcdd45093325 link /test e2e-gcp
ci/prow/e2e-gcp-builds c04064363cc8d5659b8ddc8b6674fcdd45093325 link /test e2e-gcp-builds
ci/prow/e2e-aws-proxy c04064363cc8d5659b8ddc8b6674fcdd45093325 link /test e2e-aws-proxy

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

danwinship

comment created time in 4 minutes

pull request commentopenshift/origin

[release-4.8] Bug 1973995: Add failing tests in OVN-K into skipped list

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-cherrypick-robot

comment created time in 5 minutes

pull request commentopenshift/origin-aggregated-logging

Vendoring in minimist 1.2.5

/retest

Please review the full test history for this PR and help us cut down flakes.

ewolinetz

comment created time in 5 minutes

pull request commentopenshift/installer

BZ 1975475: aws: block creation of bootstrap instance until ignition config is uploaded

This PR is 4 for 4 on successful AWS installs, so I think it is good. /cc @jhixson74

staebler

comment created time in 5 minutes

pull request commentkubernetes/kubernetes

Run ubernetes tests on gke only

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes/kubernetes/pull/103160#" title="Author self-approved">ravisantoshgudimetla</a> To complete the pull request process, please assign xing-yang after the PR has been reviewed. You can assign the PR to them by writing /assign @xing-yang in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["xing-yang"]} -->

ravisantoshgudimetla

comment created time in 7 minutes

pull request commentkubernetes/kubernetes

Run ubernetes tests on gke only

@ravisantoshgudimetla: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

ravisantoshgudimetla

comment created time in 7 minutes

PR opened kubernetes/kubernetes

Run ubernetes tests on gke only

We're running ubernetes tests on gcp&gke. While the test is useful in exercising the scenario of identifying extra zone and creating a node in it, not every Kube distribution uses the same approach to create a node, further if even there is an extra zone, we cannot guarantee the zone to have enough quota. There can also be other GCP specific edge cases all of which cannot be covered within this test. So, it'd be better if we can stop running test in case of GCP but have it run in GKE where the environment is much more controlled.

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide/first-contribution.md#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
  2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here: https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label
  3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md
  4. If you want faster PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews
  5. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests -->

What type of PR is this?

<!-- Add one of the following kinds: /kind bug /kind cleanup /kind documentation /kind feature /kind design

Optionally add one or more of the following kinds if applicable: /kind api-change /kind deprecation /kind failing-test /kind flake /kind regression --> /kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

<!-- Automatically closes linked issue when PR is merged. Usage: Fixes #<issue number>, or Fixes (paste link of issue). If PR is about failing-tests or flakes, please post the related issues/tests in a comment and do not use Fixes --> Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

<!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md -->

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

<!-- This section can be blank if this pull request does not require a release note.

When adding links which point to resources within git repositories, like KEPs or supporting documentation, please reference a specific commit and avoid linking directly to the master branch. This ensures that links reference a specific point in time, rather than a document that may change over time.

See here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files

Please use the following format for linking documentation:

-->

NONE

cc @jsafrane @petr-muller @dmage @stbenjam @deads2k

+1 -1

0 comment

1 changed file

pr created time in 8 minutes

pull request commentopenshift/origin

Skip a NetworkPolicy test with broken timing assumptions

@danwinship: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-csi 2c8ededd8a452642f4f36104def06a8edb9b3bb2 link /test e2e-aws-csi
ci/prow/e2e-gcp 2c8ededd8a452642f4f36104def06a8edb9b3bb2 link /test e2e-gcp
ci/prow/e2e-gcp-upgrade 2c8ededd8a452642f4f36104def06a8edb9b3bb2 link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

danwinship

comment created time in 8 minutes

issue commentkubernetes/kubernetes

Support Oversubscription in kubernetes

wouldn't setting the pod requests to something lower and rely on a higher pod limit practically achieve overcommit semantics?

k82cn

comment created time in 9 minutes

issue commentkubernetes/kubernetes

Why not add metrics about image pulling in Kubelet

/triage needs-information

Nebulazhang

comment created time in 9 minutes

pull request commentkubernetes/kubernetes

Remove MPL-licensed dep from lruexpirecache

I tried

make clean generated_files
./hack/update-vendor.sh

But there was no change.

ahmedtd

comment created time in 10 minutes

pull request commentopenshift/origin

Bug 1973667: undisable NetworkPolicy tests [4.8]

@danwinship: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack f7023f3648addbdb50cf9876aa5df2072d767713 link /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-proxy f7023f3648addbdb50cf9876aa5df2072d767713 link /test e2e-aws-proxy
ci/prow/e2e-gcp c04064363cc8d5659b8ddc8b6674fcdd45093325 link /test e2e-gcp
ci/prow/e2e-gcp-builds c04064363cc8d5659b8ddc8b6674fcdd45093325 link /test e2e-gcp-builds

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

danwinship

comment created time in 10 minutes

issue commentkubernetes/kubernetes

default limit sometimes acts as max limit

@pacoxu why was the PR that fixed this closed?

rohitagarwal003

comment created time in 11 minutes

issue commentkubernetes/kubernetes

[Flaky Test] [sig-storage] PersistentVolumes-local [Volume type: dir-bindmounted] Two pods mounting a local volume one after the other should be able to write from pod1 and read from pod2

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

PriyankaH21

comment created time in 11 minutes

issue commentkubernetes/kubernetes

http2: no cached connection was available

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

anaconda2196

comment created time in 11 minutes

pull request commentkubernetes/kubernetes

Enforce ReadWriteOncePod during scheduling

Will do, thank you for the very thorough review, learned a lot implementing this

chrishenzie

comment created time in 11 minutes

Pull request review commentkubernetes/kubernetes

Recover from volume expansion failure

 const (  // DropDisabledFields removes disabled fields from the pvc spec. // This should be called from PrepareForCreate/PrepareForUpdate for all resources containing a pvc spec.-func DropDisabledFields(pvcSpec, oldPVCSpec *core.PersistentVolumeClaimSpec) {+func DropDisabledFields(pvc, oldPVC *core.PersistentVolumeClaim) {+	pvcSpec := &pvc.Spec+	var oldPVCSpec *core.PersistentVolumeClaimSpec+	if oldPVC != nil {+		oldPVCSpec = &oldPVC.Spec+	} 	if !dataSourceIsEnabled(pvcSpec) && !dataSourceInUse(oldPVCSpec) { 		pvcSpec.DataSource = nil 	}+	if !utilfeature.DefaultFeatureGate.Enabled(features.RecoverVolumeExpansionFailure) && !allocatedResourcesInUse(oldPVC) {

ah. I see what you mean. yeah I could add a new function for status update strategy.

gnufied

comment created time in 12 minutes

pull request commentkubernetes/kubernetes

Enforce ReadWriteOncePod during scheduling

thanks, please ping once the base PRs gets merged.

chrishenzie

comment created time in 12 minutes

pull request commentkubernetes/kubernetes

Add kubelet `SeccompDefault` alpha feature

/test pull-kubernetes-e2e-gce-ubuntu-containerd

saschagrunert

comment created time in 14 minutes

pull request commentkubernetes/kubernetes

Add SOCKS5 proxy support for kubectl exec

/remove-lifecycle rotten

TGPSKI

comment created time in 14 minutes

Pull request review commentkubernetes/kubernetes

Add score func for NodeResourcesFit plugin

 var removedPluginsByVersion = []removedPlugins{ 	}, 	{ 		schemeGroupVersion: v1beta2.SchemeGroupVersion.String(),-		plugins:            []string{"NodeLabel", "ServiceAffinity", "NodePreferAvoidPods"},+		plugins: []string{+			"NodeLabel",+			"ServiceAffinity",+			"NodePreferAvoidPods",+			"NodeResourcesLeastAllocated",+			"NodeResourcesMostAllocated",+			"RequestedToCapacityRatio",+		}, 	}, } +// conflictPluginsByVersion maintains a map of conflict plugins in each version.+// Remember to add an entry to that list when creating a new component config+// version (even if the list of conflict plugins is empty).+var conflictPluginsByVersion = map[string]map[string]sets.String{+	v1beta1.SchemeGroupVersion.String(): {+		"NodeResourcesFit": sets.NewString(

lets just call this function for "profile.Plugins.Score" and rename the function as such: validateScorePluginSetForConflictPlugins

yuzhiquan

comment created time in 14 minutes

pull request commentopenshift/origin

Add new E2E test for [SDN-1364] ACL audit logging

/test e2e-gcp

astoycos

comment created time in 14 minutes

pull request commentkubernetes/kubernetes

Add SOCKS5 proxy support for kubectl exec

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten

TGPSKI

comment created time in 16 minutes

pull request commentopenshift/installer

Updating ose-installer images to be consistent with ART

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot

comment created time in 17 minutes

pull request commentopenshift/origin-aggregated-logging

Bug 1849504: vendoring in minimist 1.2.5

/retest

Please review the full test history for this PR and help us cut down flakes.

ewolinetz

comment created time in 17 minutes

Pull request review commentkubernetes/kubernetes

Enforce ReadWriteOncePod during scheduling

 func haveOverlap(a1, a2 []string) bool { 	return false } +func (pl *VolumeRestrictions) PreFilter(ctx context.Context, cycleState *framework.CycleState, pod *v1.Pod) *framework.Status {+	if pl.enableReadWriteOncePod {+		return pl.isReadWriteOncePodAccessModeConflict(pod)+	}+	return framework.NewStatus(framework.Success)+}++// isReadWriteOncePodAccessModeConflict checks if a pod uses a PVC with the ReadWriteOncePod access mode.+// This access mode restricts volume access to a single pod on a single node. Since only a single pod can+// use a ReadWriteOncePod PVC, mark any other pods attempting to use this PVC as UnschedulableAndUnresolvable.+// TODO(#103132): Mark pod as Unschedulable and add preemption logic.+func (pl *VolumeRestrictions) isReadWriteOncePodAccessModeConflict(pod *v1.Pod) *framework.Status {+	nodeInfos, err := pl.nodeInfoLister.NodeInfos().List()+	if err != nil {+		return framework.NewStatus(framework.Error, "error while getting node info")+	}++	for _, volume := range pod.Spec.Volumes {+		if volume.PersistentVolumeClaim == nil {+			continue+		}++		pvc, err := pl.pvcLister.PersistentVolumeClaims(pod.Namespace).Get(volume.PersistentVolumeClaim.ClaimName)+		if err != nil {+			if apierrors.IsNotFound(err) {+				return framework.NewStatus(framework.UnschedulableAndUnresolvable, ErrReasonPVCNotFound)+			}+			return framework.AsStatus(err)+		}++		if !v1helper.ContainsAccessMode(pvc.Spec.AccessModes, v1.ReadWriteOncePod) {+			continue+		}++		ctx, cancel := context.WithCancel(context.Background())+		key := pod.Namespace + "/" + volume.PersistentVolumeClaim.ClaimName+		found := false++		processNode := func(i int) {+			nodeInfo := nodeInfos[i]+			refCount := nodeInfo.PVCRefCounts[key]+			// Enforce ReadWriteOncePod access mode. This is also enforced during volume mount in kubelet.+			if refCount > 0 {+				found = true

Done, using uint32 to track # of conflicts

chrishenzie

comment created time in 18 minutes

pull request commentkubernetes/kubernetes

Add score func for NodeResourcesFit plugin

@yuzhiquan: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-100-performance 9ac404b4a10ab83f68fba00ad529c81b95911ef4 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-unit 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-unit
pull-kubernetes-integration 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-integration
pull-kubernetes-e2e-gce-ubuntu-containerd 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-kind 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-kind-ipv6 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-conformance-kind-ga-only-parallel 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-conformance-kind-ga-only-parallel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

yuzhiquan

comment created time in 19 minutes

pull request commentkubernetes/kubernetes

Add score func for NodeResourcesFit plugin

@yuzhiquan: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-conformance-kind-ga-only-parallel 9ac404b4a10ab83f68fba00ad529c81b95911ef4 link /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-e2e-gce-100-performance 9ac404b4a10ab83f68fba00ad529c81b95911ef4 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-unit 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-unit
pull-kubernetes-integration 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-integration
pull-kubernetes-e2e-gce-ubuntu-containerd 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-kind 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-kind-ipv6 5c7bc4a6e347414d2428f23864094de046fe614d link /test pull-kubernetes-e2e-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

yuzhiquan

comment created time in 19 minutes