profile
viewpoint
Sascha Grunert saschagrunert @SUSE I’m on earth right now. http://saschagrunert.de The difference between fine and great software is listening to people.

containers/podman 5699

Podman: A tool for managing OCI containers and pods

containers/buildah 3356

A tool that facilitates building OCI images

containers/conmon 146

An OCI container runtime monitor.

containers/common 22

Location for shared common files in github.com/containers repos.

cri-o/cri 18

Kubernetes Container Runtime in Rust

kubernetes-analysis/kubernetes-analysis 9

Kubernetes issue and pull request analysis powered by machine learning

openSUSE/obs-service-cargo_vendor 8

OBS Source Service to vendor Rust dependency sources

openSUSE/cri-o 2

openSUSE CRI-O base fork for upstream contributions

openSUSE/containers-common 1

Location for shared common files in github.com/containers repos.

kubic-project/cri-o-testing 0

Integration and e2e testing of cri-o within kubic

push eventcri-o/cri-o

Anago GCB

commit sha d3e440c4790900c9b1ffd1f539bf114aba510a23

Update dependency report

view details

push time in 14 minutes

push eventcri-o/cri-o

Kir Kolyshkin

commit sha 70f73ab7b1861b7e68b64fd7c56adbdec6a883aa

circle-ci: use go 1.15.3 We were using golang from longsleep/golang-backports PPA. Unfortunately, that repo is apparently no longer updated for Ubuntu Xenial, with the latest golang being 1.13. Since 1.13 is no longer supported, let's switch to binary distribution from google.com, and update to 1.15.3. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

view details

OpenShift Merge Robot

commit sha 288ccd5f8ebe406a0951dee142ec7a2bce7d2e2b

Merge pull request #4305 from kolyshkin/circleci-go-1.15 circle-ci: use go 1.15.3

view details

push time in 22 minutes

push eventcri-o/cri-o

Anago GCB

commit sha 47c6b2987de8494ba472aae1c324c70a900f737d

Update release notes

view details

push time in 23 minutes

push eventcri-o/cri-o

Anago GCB

commit sha 7bbb1abfe8ed802df5edcc3c7c9af200c68c9dc4

Update dependency report

view details

push time in 2 hours

push eventcri-o/cri-o

Anago GCB

commit sha 8e55e748b56289e1fdd0def1ed9d16dca702e092

Update release notes

view details

push time in 2 hours

push eventcri-o/cri-o

Anago GCB

commit sha 19f62e34f2dcb01f3e1aec0345147c8260559406

Update dependency report

view details

push time in 3 hours

push eventcri-o/cri-o

Anago GCB

commit sha 0c4dc70c352c8c20108daa3131173906051c8422

Update release notes

view details

push time in 4 hours

push eventcri-o/cri-o

Sascha Grunert

commit sha 8a2f5f189295a4c128382606fc2f430da145d500

Add SUSE CaaS Platform and openSUSE Kubic to adopters Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

OpenShift Merge Robot

commit sha 83df8875c9b76d633c107590d083bd88783e07b2

Merge pull request #4295 from saschagrunert/adopters Add SUSE CaaS Platform and openSUSE Kubic to adopters

view details

Skyler Clark

commit sha 468d49427f0f75d6eb1503d94430213b01608c72

removes runs Signed-off-by: Skyler Clark <wgahnagl@protonmail.com>

view details

OpenShift Merge Robot

commit sha 0f311846203208c752b19314c3e5456a0e9661c9

Merge pull request #4290 from wgahnagl/remove_run removes excessive runs from bats tests

view details

push time in 4 hours

push eventcri-o/cri

openshift-merge-robot

commit sha a83915ec00646fbd4f8ccf4db4fd873962d61a7d

deploy: b17c56805a28e46058c20d137aae9e0a62864376

view details

push time in 4 hours

pull request commentcri-o/cri-o

Add interface to Rust library

This seems to work now, PTAL @mrunalp @haircommander @giuseppe

saschagrunert

comment created time in 9 hours

pull request commentcri-o/cri-o

Add interface to Rust library

/test integration_crun

saschagrunert

comment created time in 9 hours

push eventcri-o/cri-o

Anago GCB

commit sha ccc7536468fbecaff459a73303bbf71d2855a51b

Update dependency report

view details

push time in 9 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 560a19ec79a684d0ad42cb245e905673d4e6bb7d

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 9 hours

push eventcri-o/cri-o

Anago GCB

commit sha 5c9b6ca53583ada22e0bb87c25213d574d51a1eb

Update release notes

view details

push time in 9 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 317e2816212fca17c9364bef941ecb43f6c03365

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 10 hours

push eventsaschagrunert/kubernix

dependabot-preview[bot]

commit sha f3ca370338502a164db00d8a4ddfb71976762bbc

Bump rustversion from 1.0.3 to 1.0.4 Bumps [rustversion](https://github.com/dtolnay/rustversion) from 1.0.3 to 1.0.4. - [Release notes](https://github.com/dtolnay/rustversion/releases) - [Commits](https://github.com/dtolnay/rustversion/compare/1.0.3...1.0.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 10 hours

delete branch saschagrunert/kubernix

delete branch : dependabot/cargo/rustversion-1.0.4

delete time in 10 hours

PR merged saschagrunert/kubernix

Bump rustversion from 1.0.3 to 1.0.4 dependencies

Bumps rustversion from 1.0.3 to 1.0.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dtolnay/rustversion/releases">rustversion's releases</a>.</em></p> <blockquote> <h2>1.0.4</h2> <ul> <li>Implement parsing using no dependencies</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/dtolnay/rustversion/commit/2449cbc9d927411e8c88802b120a002e2e3507aa"><code>2449cbc</code></a> Release 1.0.4</li> <li><a href="https://github.com/dtolnay/rustversion/commit/3b1e0549f8292a902b8d83ecfdded9c57b15d7b7"><code>3b1e054</code></a> Clean up explicit match for to_compile_error</li> <li><a href="https://github.com/dtolnay/rustversion/commit/212644da47b6183cec9cf2e04fb5b70587791a6f"><code>212644d</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/dtolnay/rustversion/issues/24">#24</a> from dtolnay/parse</li> <li><a href="https://github.com/dtolnay/rustversion/commit/d82ca63c9aadbdec2859caff7829ae786a6b6229"><code>d82ca63</code></a> Drop dependency on syn::parse</li> <li><a href="https://github.com/dtolnay/rustversion/commit/b9db2a2d3120f804e9ecafd5907ef81175386fb1"><code>b9db2a2</code></a> Add ui test of parenthesis parsing after not</li> <li><a href="https://github.com/dtolnay/rustversion/commit/1c42faec15bdf92496732491c1c56103ecc52749"><code>1c42fae</code></a> Add ui tests of nested parse</li> <li><a href="https://github.com/dtolnay/rustversion/commit/933b16055a2cdcb7e31703d145d05dd0c6b06eed"><code>933b160</code></a> Distinct ui tests for Date vs Release vs Bound parse</li> <li><a href="https://github.com/dtolnay/rustversion/commit/fabbb82d61b124d4fcad21601d38b1ecf29603fc"><code>fabbb82</code></a> Move Release type to module</li> <li><a href="https://github.com/dtolnay/rustversion/commit/93d488a7bd8ad4f436a451e6bec91cbf48595503"><code>93d488a</code></a> Factor None-delimited stack handling to iterator</li> <li><a href="https://github.com/dtolnay/rustversion/commit/c609affd859410c786db9b93c38fb45de9f73183"><code>c609aff</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/dtolnay/rustversion/issues/23">#23</a> from dtolnay/noquote</li> <li>Additional commits viewable in <a href="https://github.com/dtolnay/rustversion/compare/1.0.3...1.0.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+2 -7

2 comments

1 changed file

dependabot-preview[bot]

pr closed time in 10 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 31c3f48fe0fa9fa78d368515ee406aa20ebdece1

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 10 hours

PullRequestReviewEvent

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 40d938d069f9f4d4a1ab2b9a238bf083313ca1ff

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 11 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 1fd76fdf27d44525c30b4a62732dbbfa2d063112

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 11 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 14ec60e304de3cecdb076c0f35fc79aa39c241b9

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 11 hours

pull request commentkubernetes/release

Push git objects using new go code

Oooh I see that krel is passing master as the release branch (I thought it was a syntax check only). I think this should be dealt with inside the go code instead of bash, what do you think? I can patch krel and then we can re-run this test.

Technically the master is the release branch right now, because we cut the releases directly from it. So I guess we just have to allow that case.

puerco

comment created time in 11 hours

pull request commentcri-o/cri-o

Add interface to Rust library

/test e2e-aws

saschagrunert

comment created time in 11 hours

pull request commentcri-o/cri-o

Add interface to Rust library

/test e2e_features_fedora /test integration_crun

saschagrunert

comment created time in 11 hours

push eventsaschagrunert/cri

Sascha Grunert

commit sha ead1330fa415cb3a20177ae06f1e76856cb90546

Add port manager ffi Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 11 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha c12d5e61d87bd62a7265af37af24e22d89c9aa30

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 12 hours

delete branch saschagrunert/cri-o

delete branch : adopters

delete time in 13 hours

pull request commentkubernetes/release

Push git objects using new go code

No t yet, I do not have enough permissions to launch builds :\

I have only tested it simulating the bash, but I'd really appreciate it some could give it a test run

Sure thing:

  • :hourglass: Stage: https://console.cloud.google.com/cloud-build/builds/c4bdb671-f48a-4dc0-a46d-1d771fba064b?project=648026197307
puerco

comment created time in 13 hours

push eventsaschagrunert/kubernetes

Sascha Grunert

commit sha f8586c97d349b187cf23e631efc0ffddcc372578

Propose seccomp protobuf type definitions for CRI graduation With the graduation of the Container Runtime Interface (CRI) we will have a unique chance to change the protobuf protocol. We now use native types for seccomp to make the API more clear and concise to be used. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 13 hours

push eventcri-o/cri-o

Anago GCB

commit sha 365712204d2a794326a3f8d1178b20619a63c0fd

Update dependency report

view details

push time in 13 hours

push eventcri-o/cri-o

Anago GCB

commit sha 32540ca614cd5fc334e5e3e6f921b470da58e237

Update release notes

view details

push time in 14 hours

push eventcri-o/cri-o

Sascha Grunert

commit sha 58328a6af5711c13dee2fe94e2a07ca89264482b

Error if GitHub release could not be found If we want to auto-upload the artifacts to GitHub, then we now error if there could be no release found. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

OpenShift Merge Robot

commit sha 702294cc9cf5d7daa2245c3f6076f0513161035b

Merge pull request #4308 from saschagrunert/github-release Error if GitHub release could not be found

view details

push time in 14 hours

push eventsaschagrunert/webapp.rs

CircleCI

commit sha bba75d7e7d05dd8644a9df113f6134fa10397912

Update documentation

view details

push time in 14 hours

push eventsaschagrunert/webapp.rs

CircleCI

commit sha 5b7c8385d208c3fe6aa85c9cebf5f24719b1529b

Update documentation

view details

push time in 14 hours

push eventsaschagrunert/webapp.rs

CircleCI

commit sha 89cfe7465f9bc2a193082412f5d581268a06370a

Update documentation

view details

push time in 14 hours

push eventsaschagrunert/kubernetes

Sascha Grunert

commit sha 1c4b1acc4622a6c6cd5c6c2ce2f7434b44adc3ed

Propose seccomp protobuf type definitions for CRI graduation With the graduation of the Container Runtime Interface (CRI) we will have a unique chance to change the protobuf protocol. We now use native types for seccomp to make the API more clear and concise to be used. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 15 hours

PullRequestReviewEvent
PullRequestReviewEvent

push eventsaschagrunert/kubernetes

Sascha Grunert

commit sha 1203ef197119292acff3c32276c29839e1c8e012

Propose seccomp protobuf type definitions for CRI graduation With the graduation of the Container Runtime Interface (CRI) we will have a unique chance to change the protobuf protocol. We now use native types for seccomp to make the API more clear and concise to be used. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 15 hours

PR opened kubernetes/kubernetes

WIP: Propose seccomp protobuf type definitions for CRI graduation

What type of PR is this?

/kind design

What this PR does / why we need it: With the graduation of the Container Runtime Interface (CRI) we will have a unique chance to change the protobuf protocol. We now use native types for seccomp to make the API more clear. Which issue(s) this PR fixes: None

Special notes for your reviewer: cc @mrunalp @mikebrow @pjbgf Does this PR introduce a user-facing change?: <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required: Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md -->

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

<!-- This section can be blank if this pull request does not require a release note.

When adding links which point to resources within git repositories, like KEPs or supporting documentation, please reference a specific commit and avoid linking directly to the master branch. This ensures that links reference a specific point in time, rather than a document that may change over time.

See here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files

Please use the following format for linking documentation:

-->

None
+27 -14

0 comment

1 changed file

pr created time in 15 hours

push eventsaschagrunert/kubernetes

Tomas Nozicka

commit sha bf52770e413dc6095203cd5ec1716dc3764eee8e

Add context to x509 verify failures

view details

wawa0210

commit sha 995d654167513340ef19f5a0cc77e66d014dc1f6

ingore apparmor on non Linux operating systems.

view details

Ben Moss

commit sha 82ac28cc529c287e0f7e62d44a24ac714e6f42ee

Adds support for building Windows pause image We can use docker buildx in order to build and push Windows images from the same Linux node, as long as the Dockerfile does not have any RUN commands in the Windows step. We also need to create a non-default builder instance in order to be able to build and push Windows images. The Windows images have to be built and pushed directly to the registry. Because of this, the make target "push" has been removed (the target "all" will build and push the images). We need wincat for a few kubectl proxy scenarios. For Windows containers without Hyper-V isolation, the host OS Version and the Container OS Version need to match, which is why we added multiple Windows OS Versions to the building process. Adds support for Windows OS Versions: 1809, 1903, 1909, 2004. Bumps pause image version to 3.4. Co-Authored-By: Claudiu Belu <cbelu@cloudbasesolutions.com> Co-Authored-By: Ben Moss <bmoss@pivotal.io> Signed-off-by: Leah Hanson <lhanson@pivotal.io>

view details

Claudiu Belu

commit sha fd1e1138d6862fe5d4902e31e41a604c296508b4

pause image: moves wincat binary location Co-authored-by: Ben Moss <moss.127@gmail.com>

view details

Antonio Ojea

commit sha a0887285f51c916509947539ad817f33b908cdd2

add ipv6 support to the image issue-74839 Co-authored-by: Dan Winship <danwinship@redhat.com>

view details

Abu Kashem

commit sha fd7bf9a5dc3b4a0ba51b041fc721de719d1b2e69

allocate service-account flowschema to global-default

view details

Sascha Grunert

commit sha b2308f1efea1ac9b697cf09e4ae7eed9c8d28e8a

Make copied `localtime` file write-able Some distributions have no default write-access to this file, which means that it's not possible to update the file and rebuild the project if not write-able. This patch fixes this by adding an additional `chmod`. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

Maciej Szulik

commit sha 788ef39cab4c55b1a1ab27ded571cbf8ac3297ec

Fix --dry-run invocation in kubectl e2e

view details

Shintaro Murakami

commit sha acc970399de1436c1cd50789ca83f664853bd2c3

Remove redundant variable The variable firstUnhealthyOrdinal is redundant because replicas and condemned are already sorted in ascending order.

view details

James DeFelice

commit sha 1a12c8084b2937dc0058eab32f2ce9a88ed31eb1

fix test flakes I've observed this test occasionally failing due to 403 errors. I think there's something racing within apiserver w/ respect to RBAC and that if this test were more patient, then it would not flake this way.

view details

Surya Seetharaman

commit sha 477b14b3c4545d121d68a98e41b1256760f92c82

Kube-proxy: Perf-fix: Shrink INPUT chain In #56164, we had split the reject rules for non-ep existing services into KUBE-EXTERNAL-SERVICES chain in order to avoid calling KUBE-SERVICES from INPUT. However in #74394 KUBE-SERVICES was re-added into INPUT. As noted in #56164, kernel is sensitive to the size of INPUT chain. This patch refrains from calling the KUBE-SERVICES chain from INPUT and FORWARD, instead adds the lb reject rule to the KUBE-EXTERNAL-SERVICES chain which will be called from INPUT and FORWARD.

view details

knight42

commit sha d321ac52a2513d5416053e179c5dcdf5e0378d0e

refactor: migrate node e2e tests off insecure port Signed-off-by: knight42 <anonymousknight96@gmail.com>

view details

Claudiu Belu

commit sha 4dbb55fe85f504de3e28eccf7987944df82ed686

test images: Adds Windows support (part 2) Adds Windows support for most of the images. Adds a README explaining the image building process, including the Windows Container image building process.

view details

Christopher M. Luciano

commit sha 62ac60c4b545115154b35ba77734e22997c84cb8

netpol: Add CRUD tests for NetworkPolicy API CRUD operations are the extent of conformance testing that we can add for NetworkPolicy tests since we require a 3rd party plugin like CNI for enforcement. Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>

view details

cici37

commit sha 95acec5a3b4c07afba17b526e5cb031f8bb88630

Move client_builder to k8s.io/controller-manager

view details

Hippie Hacker

commit sha c383dc7b1fb73bfdc40c3e7aac1b895735e41051

Promote Replication Controller Lifecycle Co-Authored-By: Riaan Kleinhans <riaan@ii.coop>

view details

Stephen Heywood

commit sha 995583938a8ca7c84f907166d8510653d2190ee7

Promote Replication Controller lifecycle e2e test to Conformance

view details

Qi Ni

commit sha 748ae54ec01c8a1588d85cfb0444dcdc9d1b6ae3

Add error detail in log

view details

Michael Gugino

commit sha 717be0cd44e18e49796f559546da8bb8bfd04ed2

Allow deletion of unhealthy pods if enough healthy Currently, if you have a PDB with 0 disruptions available and you attempt to evict a non-healthy pod, the eviction request will always fail. This is because the eviction API does not currently take in to account that the pod you are removing is the unhealthy one. This commit accounts for trying to evict an unhealthy pod as long as there are enough healthy pods to satisfy the PDB's requirements. To protect against race conditions, a ResourceVersion constraint is enforced. This will ensure that the target pod does not go healthy and allow any race condition to occur which might disrupt too many pods at once. This commit also eliminates superfluous class to DeepCopy for the deleteOptions struct.

view details

Ben Hu

commit sha 49afcfa5f2062ebc8cb03c5f57df751a6b8468e2

Use host IP instead of localhost for control plane component kubeconfig files. This is a part of work to allow control plane components to be moved off hostNetwork.

view details

push time in 15 hours

push eventsaschagrunert/kubernetes

Tomas Nozicka

commit sha bf52770e413dc6095203cd5ec1716dc3764eee8e

Add context to x509 verify failures

view details

wawa0210

commit sha 995d654167513340ef19f5a0cc77e66d014dc1f6

ingore apparmor on non Linux operating systems.

view details

Ben Moss

commit sha 82ac28cc529c287e0f7e62d44a24ac714e6f42ee

Adds support for building Windows pause image We can use docker buildx in order to build and push Windows images from the same Linux node, as long as the Dockerfile does not have any RUN commands in the Windows step. We also need to create a non-default builder instance in order to be able to build and push Windows images. The Windows images have to be built and pushed directly to the registry. Because of this, the make target "push" has been removed (the target "all" will build and push the images). We need wincat for a few kubectl proxy scenarios. For Windows containers without Hyper-V isolation, the host OS Version and the Container OS Version need to match, which is why we added multiple Windows OS Versions to the building process. Adds support for Windows OS Versions: 1809, 1903, 1909, 2004. Bumps pause image version to 3.4. Co-Authored-By: Claudiu Belu <cbelu@cloudbasesolutions.com> Co-Authored-By: Ben Moss <bmoss@pivotal.io> Signed-off-by: Leah Hanson <lhanson@pivotal.io>

view details

Claudiu Belu

commit sha fd1e1138d6862fe5d4902e31e41a604c296508b4

pause image: moves wincat binary location Co-authored-by: Ben Moss <moss.127@gmail.com>

view details

Antonio Ojea

commit sha a0887285f51c916509947539ad817f33b908cdd2

add ipv6 support to the image issue-74839 Co-authored-by: Dan Winship <danwinship@redhat.com>

view details

Abu Kashem

commit sha fd7bf9a5dc3b4a0ba51b041fc721de719d1b2e69

allocate service-account flowschema to global-default

view details

Sascha Grunert

commit sha b2308f1efea1ac9b697cf09e4ae7eed9c8d28e8a

Make copied `localtime` file write-able Some distributions have no default write-access to this file, which means that it's not possible to update the file and rebuild the project if not write-able. This patch fixes this by adding an additional `chmod`. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

Maciej Szulik

commit sha 788ef39cab4c55b1a1ab27ded571cbf8ac3297ec

Fix --dry-run invocation in kubectl e2e

view details

Shintaro Murakami

commit sha acc970399de1436c1cd50789ca83f664853bd2c3

Remove redundant variable The variable firstUnhealthyOrdinal is redundant because replicas and condemned are already sorted in ascending order.

view details

James DeFelice

commit sha 1a12c8084b2937dc0058eab32f2ce9a88ed31eb1

fix test flakes I've observed this test occasionally failing due to 403 errors. I think there's something racing within apiserver w/ respect to RBAC and that if this test were more patient, then it would not flake this way.

view details

Surya Seetharaman

commit sha 477b14b3c4545d121d68a98e41b1256760f92c82

Kube-proxy: Perf-fix: Shrink INPUT chain In #56164, we had split the reject rules for non-ep existing services into KUBE-EXTERNAL-SERVICES chain in order to avoid calling KUBE-SERVICES from INPUT. However in #74394 KUBE-SERVICES was re-added into INPUT. As noted in #56164, kernel is sensitive to the size of INPUT chain. This patch refrains from calling the KUBE-SERVICES chain from INPUT and FORWARD, instead adds the lb reject rule to the KUBE-EXTERNAL-SERVICES chain which will be called from INPUT and FORWARD.

view details

knight42

commit sha d321ac52a2513d5416053e179c5dcdf5e0378d0e

refactor: migrate node e2e tests off insecure port Signed-off-by: knight42 <anonymousknight96@gmail.com>

view details

Claudiu Belu

commit sha 4dbb55fe85f504de3e28eccf7987944df82ed686

test images: Adds Windows support (part 2) Adds Windows support for most of the images. Adds a README explaining the image building process, including the Windows Container image building process.

view details

Christopher M. Luciano

commit sha 62ac60c4b545115154b35ba77734e22997c84cb8

netpol: Add CRUD tests for NetworkPolicy API CRUD operations are the extent of conformance testing that we can add for NetworkPolicy tests since we require a 3rd party plugin like CNI for enforcement. Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>

view details

cici37

commit sha 95acec5a3b4c07afba17b526e5cb031f8bb88630

Move client_builder to k8s.io/controller-manager

view details

Hippie Hacker

commit sha c383dc7b1fb73bfdc40c3e7aac1b895735e41051

Promote Replication Controller Lifecycle Co-Authored-By: Riaan Kleinhans <riaan@ii.coop>

view details

Stephen Heywood

commit sha 995583938a8ca7c84f907166d8510653d2190ee7

Promote Replication Controller lifecycle e2e test to Conformance

view details

Qi Ni

commit sha 748ae54ec01c8a1588d85cfb0444dcdc9d1b6ae3

Add error detail in log

view details

Michael Gugino

commit sha 717be0cd44e18e49796f559546da8bb8bfd04ed2

Allow deletion of unhealthy pods if enough healthy Currently, if you have a PDB with 0 disruptions available and you attempt to evict a non-healthy pod, the eviction request will always fail. This is because the eviction API does not currently take in to account that the pod you are removing is the unhealthy one. This commit accounts for trying to evict an unhealthy pod as long as there are enough healthy pods to satisfy the PDB's requirements. To protect against race conditions, a ResourceVersion constraint is enforced. This will ensure that the target pod does not go healthy and allow any race condition to occur which might disrupt too many pods at once. This commit also eliminates superfluous class to DeepCopy for the deleteOptions struct.

view details

Ben Hu

commit sha 49afcfa5f2062ebc8cb03c5f57df751a6b8468e2

Use host IP instead of localhost for control plane component kubeconfig files. This is a part of work to allow control plane components to be moved off hostNetwork.

view details

push time in 15 hours

create barnchsaschagrunert/kubernetes

branch : proto

created branch time in 15 hours

push eventsaschagrunert/webapp.rs

CircleCI

commit sha 0b11e7b2ddb3fcaac98ea15df503329328726f6a

Update documentation

view details

push time in 15 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha d3aec2b56ec68dbcfba71b1d6acf0dfa4317b214

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 15 hours

push eventsaschagrunert/webapp.rs

CircleCI

commit sha 3bab925f728da2dabbe666de7181631b8ba81cdb

Update documentation

view details

push time in 15 hours

push eventsaschagrunert/webapp.rs

CircleCI

commit sha f231886453491ec9267627c3011e3aded49051fb

Update documentation

view details

push time in 15 hours

pull request commentcri-o/cri-o

Add interface to Rust library

/retest

saschagrunert

comment created time in 16 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha e3e164bcb928d60e63b868e91428aa128fed4459

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 16 hours

pull request commentcri-o/cri-o

Add SUSE CaaS Platform and openSUSE Kubic to adopters

/hold cancel /retest

:heavy_check_mark: Rebased

saschagrunert

comment created time in 16 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 8a323b3340705791fbe9f246717a26249de6f4a7

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 16 hours

push eventsaschagrunert/cri-o

Peter Hunt

commit sha f0fab44c4fe18b722d82ba5590f7e80a4dc4b07d

template: move default_runtime closer to runtimes map as it's slightly bothersome needing to search through the file, and they're often changed together Signed-off-by: Peter Hunt <pehunt@redhat.com>

view details

Peter Hunt

commit sha 1d0f68156ba382651c776a44f156614c4fcf981d

update documentation of privileged_without_host_devices add omitempty to the option update the entry in the config template so the option is correctly reflected if set. Signed-off-by: Peter Hunt <pehunt@redhat.com>

view details

Peter Hunt

commit sha 1a5553ebd32510562eb4a33e3bf3fac14c5613b2

add allowed_annotations to runtime handler This allows admins to configure which runtime classes are allowed to interpret which annotations. Right now, the only supported annotation is io.kubernetes.cri-o.userns-mode, which provides further customizability for when usernamespaces are allowed Signed-off-by: Peter Hunt <pehunt@redhat.com>

view details

Peter Hunt

commit sha ba9c0c245fa8b305bc1918a71aa1dd060c5f1db5

drop AllowUsernsAnnotations as it's now redundant with the runtime class level allowed_annotations Signed-off-by: Peter Hunt <pehunt@redhat.com>

view details

Peter Hunt

commit sha 99a21e9195e89b714b65f246902468615735ac9e

use correct mappings when they exist a rebase failure between infra container and userns caused the wrong mappings to be used This could cause a segfault, and causes wrong behavior. Fix it Signed-off-by: Peter Hunt <pehunt@redhat.com>

view details

OpenShift Merge Robot

commit sha ec53db4d7259a8c5e8fe4b0e503272c75663a599

Merge pull request #4294 from haircommander/fix-userns use correct mappings when they exist

view details

Sascha Grunert

commit sha 0de968083330dc29bef850e78b817cf1f93cb359

Add KubeCon EU 2020 talks to awesome list Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

Giuseppe Scrivano

commit sha 4cfde377ed733d5b9c05ba81f5efd4a9ef7c4234

userns: use the same ID if the mapping is missing If the mapping is missing it means it wasn't specified by the user. In this case do not error out but use the unchanged ID. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

view details

OpenShift Merge Robot

commit sha 5e9732c1f287b4e86e54e9dcd8e4887ac9e5dc93

Merge pull request #4299 from saschagrunert/awesome Add KubeCon EU 2020 talks to awesome list

view details

Avi Miller

commit sha 455a1b6b55670c63b5b4c656cb5645fda63cda1d

Adding Oracle Linux Cloud Native Environment to the list of adopters. Signed-off-by: Avi Miller <avi.miller@oracle.com>

view details

Peter Hunt

commit sha 95f2851035810889f57385c43e1e17484c0bdd1b

drop error in finalizeUserMapping as well Signed-off-by: Peter Hunt <pehunt@redhat.com>

view details

Urvashi Mohnani

commit sha ca11353f8c043c0d33a67949a4012309839d2942

Update e2e-aws logic for 4.7 Update the crio.spec to be 1.20 and the machine os content image to the 4.7 version. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>

view details

OpenShift Merge Robot

commit sha c9e45fe8b23be3467bd36b55ba08c38abbf7dda8

Merge pull request #4304 from umohnani8/e2e Update e2e-aws logic for 4.7

view details

OpenShift Merge Robot

commit sha 07ec35e6caf401173f929e1f88e51dc585eb3747

Merge pull request #4281 from haircommander/runtime-allow-userns-annotation add allowed_annotations to runtime handler

view details

OpenShift Merge Robot

commit sha f574aef92b3aad3b463e8333dbf04868c61a5803

Merge pull request #4300 from haircommander/fix-userns-2 userns: use the same ID if the mapping is missing

view details

OpenShift Merge Robot

commit sha 554a379f73c4e0f2adf73e076b2c5c5ba9569231

Merge pull request #4302 from Djelibeybi/oracle-adoption Adding Oracle Linux Cloud Native Environment to the list of adopters.

view details

Sascha Grunert

commit sha 8a2f5f189295a4c128382606fc2f430da145d500

Add SUSE CaaS Platform and openSUSE Kubic to adopters Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 16 hours

PullRequestReviewEvent

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 4e3f206abe9123ed22d2dc6551f062b76f194c9b

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 16 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 081e71e94ae8c528b48e84437339136925661950

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 16 hours

PullRequestReviewEvent

Pull request review commentcri-o/cri-o

Add interface to Rust library

 dependencies: ${GO_MOD_OUTDATED} 	${GO_RUN} ./scripts/dependencies \ 		--output-path ${BUILD_PATH}/dependencies +LIB_COMMIT := 8b01dbb++.PHONY: update-lib+update-lib:+	FILE=lib-$(LIB_COMMIT).tar.gz && \+	curl -sf https://storage.googleapis.com/k8s-conform-cri-o/lib/$$FILE \

I think we have to add the toolchain to our CI, going for this approach now.

saschagrunert

comment created time in 16 hours

Pull request review commentcri-o/cri-o

Add interface to Rust library

 stdenv: &stdenv     GOCACHE: &gocache /tmp/go-build     IMAGE: &image quay.io/crio/crio-build-amd64-go1.15:master-1.5.0     IMAGELEGACY: &imagelegacy quay.io/crio/crio-build-amd64-go1.14:master-1.5.0-    IMAGE386: &image386 quay.io/crio/crio-build-386-go1.15:master-1.5.0

I'll add the toolchain to our CI.

saschagrunert

comment created time in 16 hours

PullRequestReviewEvent

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 833ee6917e00b32b622be60af0eb4a02b721d591

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 16 hours

delete branch saschagrunert/cri-o

delete branch : github-release

delete time in 17 hours

Pull request review commentcri-o/cri-o

Add interface to Rust library

 stdenv: &stdenv     GOCACHE: &gocache /tmp/go-build     IMAGE: &image quay.io/crio/crio-build-amd64-go1.15:master-1.5.0     IMAGELEGACY: &imagelegacy quay.io/crio/crio-build-amd64-go1.14:master-1.5.0-    IMAGE386: &image386 quay.io/crio/crio-build-386-go1.15:master-1.5.0

Okay, what do we wanna do now? Build the library here in this repository? It would cause the biggest changes to our CI but seems the only reason to not put static libraries into this repo…

saschagrunert

comment created time in 17 hours

PullRequestReviewEvent

push eventsaschagrunert/cri

Sascha Grunert

commit sha 0cc80ca564ed6e09d5a25eb1c0f4fb181cb345aa

Add port manager ffi Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 17 hours

push eventcri-o/cri-o

Anago GCB

commit sha 423f1a943644b11e9d58565545f6a48b8d929a6f

Update dependency report

view details

push time in 18 hours

push eventcri-o/cri-o

Anago GCB

commit sha 22dfd7e5cdd838f7c26d2e4e2585f1a8ec35307d

Update release notes

view details

push time in 18 hours

Pull request review commentcri-o/cri-o

Add interface to Rust library

 stdenv: &stdenv     GOCACHE: &gocache /tmp/go-build     IMAGE: &image quay.io/crio/crio-build-amd64-go1.15:master-1.5.0     IMAGELEGACY: &imagelegacy quay.io/crio/crio-build-amd64-go1.14:master-1.5.0-    IMAGE386: &image386 quay.io/crio/crio-build-386-go1.15:master-1.5.0

That's ARM only, right? Phew…we probably have to build the static library for all of those architectures then… :thinking:

saschagrunert

comment created time in 18 hours

PullRequestReviewEvent

push eventsaschagrunert/cri

Sascha Grunert

commit sha ef134937256b8c859478c55cbba532cd129d5e9e

Add port manager ffi Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 18 hours

startedeqrion/cbindgen

started time in 19 hours

PullRequestReviewEvent

push eventsaschagrunert/ccli

dependabot-preview[bot]

commit sha 59375eba98edd30266368fa8911534edbc2d576e

Bump github.com/golangci/golangci-lint from 1.31.0 to 1.32.0 (#47) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.31.0 to 1.32.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](https://github.com/golangci/golangci-lint/compare/v1.31.0...v1.32.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 20 hours

delete branch saschagrunert/ccli

delete branch : dependabot/go_modules/github.com/golangci/golangci-lint-1.32.0

delete time in 20 hours

PR merged saschagrunert/ccli

Bump github.com/golangci/golangci-lint from 1.31.0 to 1.32.0 dependencies

Bumps github.com/golangci/golangci-lint from 1.31.0 to 1.32.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/releases">github.com/golangci/golangci-lint's releases</a>.</em></p> <blockquote> <h2>v1.32.0</h2> <h2>Changelog</h2> <p>25fcad6 Add dummy maintainer to keep <code>dpkg</code> happy (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1406">#1406</a>) c57627b Add exhaustivestruct linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1411">#1411</a>) 796a958 Add go-errorlint (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1420">#1420</a>) 5f93c93 Add support for fish completion (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1201">#1201</a>) 926e76d Add tparallel linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1380">#1380</a>) 247b6c2 Add wrapcheck linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1407">#1407</a>) d20b8f9 Added <code>.golangci.yaml</code> to list of configuration files searched on startup (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1364">#1364</a>) 89e9482 Added func to sort linters (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1451">#1451</a>) 9b3ba43 Added support for only specifying default severity (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1396">#1396</a>) 3e6b01e Mention macports installation procedure on macOS (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1352">#1352</a>) 3368a55 Releasing docker image for arm64 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1383">#1383</a>) 140d51b Trigger the Netlify (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1358">#1358</a>) 7330026 Update assets (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1357">#1357</a>) a8b7b00 Update gochecknoglobals, use source analyzer (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1422">#1422</a>) ad26b68 build(dep): Ignore known dependency failure in nancy (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1378">#1378</a>) fe976ff build(deps): bump @mdx-js/mdx from 1.6.16 to 1.6.18 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1401">#1401</a>) f63ad9e build(deps): bump gatsby from 2.24.52 to 2.24.65 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1400">#1400</a>) 763b998 build(deps): bump gatsby-plugin-canonical-urls in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1390">#1390</a>) 70cd9ba build(deps): bump gatsby-plugin-catch-links in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1415">#1415</a>) 52c8e1c build(deps): bump gatsby-plugin-google-analytics in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1388">#1388</a>) caecdef build(deps): bump gatsby-plugin-mdx from 1.2.35 to 1.2.40 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1386">#1386</a>) ea84543 build(deps): bump gatsby-plugin-mdx from 1.2.40 to 1.2.43 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1419">#1419</a>) cbaa2ae build(deps): bump gatsby-plugin-offline from 3.2.23 to 3.2.27 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1368">#1368</a>) 8569ea2 build(deps): bump gatsby-plugin-sharp from 2.6.31 to 2.6.40 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1423">#1423</a>) 7e39563 build(deps): bump gatsby-plugin-sitemap from 2.4.12 to 2.4.14 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1417">#1417</a>) 2763cc4 build(deps): bump gatsby-remark-autolink-headers in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1387">#1387</a>) 88285dc build(deps): bump gatsby-remark-images from 3.3.28 to 3.3.29 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1365">#1365</a>) 9198323 build(deps): bump gatsby-remark-mermaid from 2.0.0 to 2.1.0 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1369">#1369</a>) 9ea696e build(deps): bump gatsby-source-filesystem in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1366">#1366</a>) 3da7f4c build(deps): bump gatsby-source-filesystem in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1389">#1389</a>) 0ca6265 build(deps): bump gatsby-transformer-sharp in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1402">#1402</a>) 25228eb build(deps): bump gatsby-transformer-yaml from 2.4.10 to 2.4.11 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1367">#1367</a>) 501f00c build(deps): bump github.com/mattn/go-colorable from 0.1.7 to 0.1.8 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1413">#1413</a>) ae3aca7 build(deps): bump github.com/sirupsen/logrus from 1.6.0 to 1.7.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1412">#1412</a>) 3cc77d1 build(deps): bump github.com/sourcegraph/go-diff from 0.6.0 to 0.6.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1414">#1414</a>) 065be62 build(deps): bump github.com/tetafro/godot from 0.4.8 to 0.4.9 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1384">#1384</a>) a0599ca build(deps): bump github.com/valyala/quicktemplate from 1.6.2 to 1.6.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1385">#1385</a>) b2c7c37 build(deps): bump golangci/golangci-lint-action from v2 to v2.2.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1447">#1447</a>) 2f16572 build(deps): bump honnef.co/go/tools (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1448">#1448</a>) 254f0d4 build(deps): bump honnef.co/go/tools (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1459">#1459</a>) 857f744 build(deps): bump node-fetch in /.github/contributors (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1363">#1363</a>) da9f499 build(deps): bump puppeteer from 3.3.0 to 5.3.1 in /docs (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1418">#1418</a>) d4ebf99 build(go): Check if go.mod and go.sum are up to dated (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1377">#1377</a>) e4346a8 build(release): Prepare for release 1.32.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1457">#1457</a>) 5efb842 chore(dep): Update unparam/gofumpt to latest commit hash (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1376">#1376</a>)</p> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golangci/golangci-lint/commit/9d557ed40edcf96b59d7a35c43cd9a6f45f663a2"><code>9d557ed</code></a> chore(dep): Use tag version for cobra (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1458">#1458</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/254f0d4d4d43262168dcec1af464764be5ea6ec3"><code>254f0d4</code></a> build(deps): bump honnef.co/go/tools (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1459">#1459</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/9b3ba431f1bc3579536f608b38cb607d8ddbf882"><code>9b3ba43</code></a> Added support for only specifying default severity (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1396">#1396</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/e4346a8bd6b38d2cdfddb5ecf730bddd5cab922d"><code>e4346a8</code></a> build(release): Prepare for release 1.32.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1457">#1457</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/89e94823d6c43f0b78adfc43356441158def558f"><code>89e9482</code></a> Added func to sort linters (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1451">#1451</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/d20b8f931fb4853290c49fcb3fbde325e8861cfe"><code>d20b8f9</code></a> Added <code>.golangci.yaml</code> to list of configuration files searched on startup (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1">#1</a>...</li> <li><a href="https://github.com/golangci/golangci-lint/commit/3368a556275b4f63ea5000dcbe2c5152b66cecc8"><code>3368a55</code></a> Releasing docker image for arm64 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1383">#1383</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/3e6b01e716c28265b23fd493abf6d3612098f83b"><code>3e6b01e</code></a> Mention macports installation procedure on macOS (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1352">#1352</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/a8b7b0037acbdadc6339112b2adb4128fad16624"><code>a8b7b00</code></a> Update gochecknoglobals, use source analyzer (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1422">#1422</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/58234f055cd8a4ba71ce6dafb95d7fa665bc8d39"><code>58234f0</code></a> update exhaustive to latest; use version in go.mod (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/1449">#1449</a>)</li> <li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint/compare/v1.31.0...v1.32.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+37 -1

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 20 hours

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentcri-o/cri-o

Add interface to Rust library

 dependencies: ${GO_MOD_OUTDATED} 	${GO_RUN} ./scripts/dependencies \ 		--output-path ${BUILD_PATH}/dependencies +LIB_COMMIT := 8b01dbb++.PHONY: update-lib+update-lib:+	FILE=lib-$(LIB_COMMIT).tar.gz && \+	curl -sf https://storage.googleapis.com/k8s-conform-cri-o/lib/$$FILE \

How would that work? Should we build the whole Rust project from this repository?

saschagrunert

comment created time in 20 hours

PullRequestReviewEvent

pull request commentcri-o/cri

Add portmap support

Unit tests are failing because of the nightly toolchain which is broken right now. Not related to this PR.

saschagrunert

comment created time in 20 hours

create barnchsaschagrunert/cri

branch : portmapping-ffi

created branch time in 20 hours

PullRequestReviewEvent

push eventsaschagrunert/cri

Sascha Grunert

commit sha a68df99032929937e9ac9a88472a46f03397e26e

Add portmap support Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 20 hours

push eventsaschagrunert/release

Stephen Augustus

commit sha 1cf08d9454d03e7a2a198583ef42e82df34fd579

Migrate vulnerability dashboard (vulndash) to k/release Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Stephen Augustus

commit sha 3aeac52cbbe0d7db2961c6615be6d389634b2833

OWNERS: Add reviewers/approvers for vulndash Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Stephen Augustus

commit sha 3b74e589ada20719864af826fea7f18ccf68554d

vulndash: Use k8s.io/release import Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Stephen Augustus

commit sha 8c07ed7cfd76f9a8e10b61952858dd4ceaa4b328

vulndash: Use klog v2 (and run go mod tidy) Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Stephen Augustus

commit sha 8f82943e161d1879940eef569238c4d234f06476

vulndash: Convert to cobra Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Stephen Augustus

commit sha 705e069fb2188b6a9470d91267d3550b7ebf1718

pkg/vulndash: Clean up lint warnings Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Adolfo García Veytia (Puerco)

commit sha ac444556d7be15ab10f436f4ccc9b2f80fd296f0

Add sigs.k8s.io/mdtoc to go.mod and update dependencies Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>

view details

Adolfo García Veytia (Puerco)

commit sha 0dcbba48f5a4ee738e76756ea9ead9a1d9ddcaec

Implement sigs.k8s.io/mdtoc in changelog & release-notes. Update testdata. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>

view details

Adolfo García Veytia (Puerco)

commit sha be5ce69af7fd8562283eff5f92b92544d8e3c13e

Delete Sascha's TOC. Thanks for all the fish. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>

view details

Stephen Augustus

commit sha 6d71a186aa39157f507b190647e3e74657051bfd

images: Add dir for k8s-staging-artifact-promoter project Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Stephen Augustus

commit sha 738db982b322fdea8d448c2c7abbbbc524e81e90

vulndash: Enable image building Signed-off-by: Stephen Augustus <saugustus@vmware.com>

view details

Kubernetes Prow Robot

commit sha 330aada353d86f6b167a7cfe6cbd46e34c8de505

Merge pull request #1647 from puerco/mdtoc Change TOC generation module to sigs.k8s.io/mdtoc

view details

Kubernetes Prow Robot

commit sha 85f4f2e80b9548762071e533b84d46f914f93f4c

Merge pull request #1657 from justaugustus/vulndash Migrate vulnerability dashboard (vulndash) to k/release

view details

push time in 21 hours

Pull request review commentcri-o/cri-o

Add interface to Rust library

 stdenv: &stdenv     GOCACHE: &gocache /tmp/go-build     IMAGE: &image quay.io/crio/crio-build-amd64-go1.15:master-1.5.0     IMAGELEGACY: &imagelegacy quay.io/crio/crio-build-amd64-go1.14:master-1.5.0-    IMAGE386: &image386 quay.io/crio/crio-build-386-go1.15:master-1.5.0

I'd say that we drop the 32bit binary, because this will not work with the Rust lib. We could also build a 32bit version of the rust library, but I do not see a strong reason to stick to 32bit binaries.

saschagrunert

comment created time in 21 hours

PullRequestReviewEvent

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 6e4c7837e501692d8c4aeed9663caad02cb88a0b

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 21 hours

pull request commentcri-o/cri-o

Add interface to Rust library

I'd say that we drop the 32bit binary, because this will not work with the Rust lib. We could also build a 32bit version of the rust library, but I do not see a strong reason to stick to 32bit binaries.

saschagrunert

comment created time in 21 hours

push eventsaschagrunert/cri-o

Sascha Grunert

commit sha 70f857b0fc06b520d54b8d61006693d1d81d188b

Add interface to rust library This adds a for now empty interface to the Rust library. The idea is to simply download the (static) library of not existing locally and link against it. The new `ffi` package will be the main entrypoint around wrapping structures later on. Signed-off-by: Sascha Grunert <sgrunert@suse.com>

view details

push time in 21 hours

Pull request review commentkubernetes/test-infra

Allow staging via krel for kubetest

 replace (  require ( 	cloud.google.com/go/pubsub v1.4.0-	cloud.google.com/go/storage v1.10.0+	cloud.google.com/go/storage v1.12.0 	github.com/Azure/azure-sdk-for-go v42.3.0+incompatible 	github.com/Azure/azure-storage-blob-go v0.8.0 	github.com/Azure/go-autorest/autorest v0.10.2 	github.com/Azure/go-autorest/autorest/adal v0.8.3-	github.com/GoogleCloudPlatform/testgrid v0.0.13+	github.com/GoogleCloudPlatform/testgrid v0.0.22

The resultstore package does not build any more when upgrading testgrid:

# k8s.io/test-infra/experiment/resultstore
experiment/resultstore/download.go:48:31: not enough arguments in call to build.Started
        have (context.Context)
        want (context.Context, gcs.Opener)
experiment/resultstore/download.go:64:25: not enough arguments in call to build.Artifacts
        have (context.Context, chan string)
        want (context.Context, gcs.Lister, chan<- string)
experiment/resultstore/download.go:90:22: not enough arguments in call to build.Suites
        have (context.Context, chan string, chan gcs.SuitesMeta)
        want (context.Context, gcs.Opener, <-chan string, chan<- gcs.SuitesMeta)
experiment/resultstore/main.go:377:31: not enough arguments in call to gcs.ListBuilds
        have (context.Context, *"cloud.google.com/go/storage".Client, gcs.Path)
        want (context.Context, gcs.Lister, gcs.Path, *gcs.Path)
experiment/resultstore/main.go:438:126: undefined: gcs.Builds
experiment/resultstore/main.go:457:3: unknown field 'Bucket' in struct literal of type gcs.Build
experiment/resultstore/main.go:458:3: unknown field 'Prefix' in struct literal of type gcs.Build
experiment/resultstore/main.go:459:3: unknown field 'BucketPath' in struct literal of type gcs.Build
saschagrunert

comment created time in 21 hours

more