profile
viewpoint

tinexw/api-blueprint 0

Demo repository for API Blueprint

tinexw/apiary-client 0

Ruby Gem for Apiary API

tinexw/awsu 0

Enhanced account switching for AWS, supports Yubikey as MFA source

tinexw/bitbucket-branch-source-plugin 0

Bitbucket Branch Source Plugin

tinexw/blueocean-plugin 0

Blue Ocean is a reboot of the Jenkins CI/CD User Experience

tinexw/checkstyle 0

Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.

tinexw/community 0

Kubernetes community content

tinexw/container-pipelines 0

Let's get the ball rolling on some Container-driven CI & CD

push eventtinexw/cdc-with-pact

push time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha a12c5fbeed1294d3b031982fce0141553f00ef66

remove field

view details

push time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha 30b99bd7bc4311744deaf92a669297acf6440e3d

publish verification results in main build job

view details

push time in 25 days

push eventtinexw/cdc-with-pact

push time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha ee46cb5ff4124d6cf001bf228f6761643f960435

remove field

view details

push time in 25 days

delete branch tinexw/cdc-with-pact

delete branch : tmp

delete time in 25 days

create barnchtinexw/cdc-with-pact

branch : tmp

created branch time in 25 days

delete branch tinexw/cdc-with-pact

delete branch : tmp

delete time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha 3d7e270ddd583d3a4f86915fe155bf5dac932b23

upgrade default value

view details

push time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha b87e8d6858ba249bff3ac0aadb3b49c39fb3168f

upgrade pact CLI

view details

push time in 25 days

create barnchtinexw/cdc-with-pact

branch : tmp

created branch time in 25 days

delete branch tinexw/cdc-with-pact

delete branch : tmp

delete time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha 4d4c0ddda0e13e7664d013f3b48c05480aa02586

upgrade pact CLI

view details

push time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha 866c3c345a6f4939921e5f9fdf44f428da740afd

rename branch

view details

push time in 25 days

create barnchtinexw/cdc-with-pact

branch : tmp

created branch time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha 37a2f081c4f137a744ee119f3b6a69a5e49b2c69

Update branch check

view details

push time in 25 days

push eventtinexw/example-provider

Kristine Jetzke

commit sha 29c15765666b284b14438eadeac290ed91c36ff7

Remove color field again

view details

push time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha 7e43ecfbac50ac475f9ab1210599930d4f1c71f3

Use a different port

view details

push time in 25 days

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha 410fcd605af22493d2ad163bb7379882bde2a3a8

update jenkins config with current branch name

view details

Kristine Jetzke

commit sha a856c7392b44c1a38fb3902e54568ada22a1acc7

use most recent pact broker

view details

Kristine Jetzke

commit sha 4c6d46c378312e2f4d4f56da107da3e46037562e

Update .gitignore

view details

push time in 25 days

push eventtinexw/cdc-demo

Kristine Jetzke

commit sha ba930b80fa6d5600260c13f53124b5ac02ed216d

Upgrade libraries

view details

push time in a month

PR opened DiUS/pact-jvm

Add dependency info to README
+9 -0

0 comment

1 changed file

pr created time in a month

push eventtinexw/pact-jvm

Kristine Jetzke

commit sha bb86eba38a7e560fd92b2834086c2bc2e6973583

Add dependency info to README

view details

push time in a month

PR opened DiUS/pact-jvm

Add dependency info to README
+8 -0

0 comment

1 changed file

pr created time in a month

push eventtinexw/pact-jvm

Kristine Jetzke

commit sha ba90d1003f05c93f61c708dc9d1323d3172cb307

Add dependency info to README

view details

push time in a month

PR opened DiUS/pact-jvm

Add dependency info to README
+9 -0

0 comment

1 changed file

pr created time in a month

push eventtinexw/pact-jvm

Kristine Jetzke

commit sha e67069b809c9519bb20c69438c1de8f01b4cb6c9

Add dependency info to README

view details

push time in a month

issue openedaws/aws-cdk

[s3] Wrong link on python doc, points to ECR lifecycle policy instead of S3

<!--

  • developer guide? raise issue/pr here: https://github.com/awsdocs/aws-cdk-guide
  • want to help? submit a pull request here: https://github.com/aws/aws-cdk -->

link to reference doc page: https://docs.aws.amazon.com/cdk/api/latest/python/aws_cdk.aws_s3/Bucket.html

The link for Lifecycle Policy points to the ECR lifecycle policy (https://docs.aws.amazon.com/cdk/api/latest/python/aws_cdk.aws_ecr/LifecycleRule.html#aws_cdk.aws_ecr.LifecycleRule), not the S3 one.

If someone points me to the place where I can fix it I'll happily submit a PR myself.


This is a 📕 documentation issue

created time in a month

push eventtinexw/cdc-with-pact

Kristine Jetzke

commit sha 8cddc35b42d844ba2717c46a654b51f14c52fa57

Fix typo

view details

push time in 2 months

pull request commentpactflow/example-provider-java-kafka

Fix import of @PactFolder

Yep, it's the variable

java.lang.RuntimeException: Could not resolve property "PACT_BROKER_TOKEN" in the system properties or environment variables and no default value is supplied

tinexw

comment created time in 3 months

push eventtinexw/example-provider-java-kafka

Kristine Jetzke

commit sha de0d38c5cd810f997dd3c1d19f6581c38fc601ed

Add more info to travis build output

view details

push time in 3 months

pull request commentpactflow/example-provider-java-kafka

Fix import of @PactFolder

Any idea why the test fails @tinexw?

tbh no. I assume it's something with the env variables not being replaced (at least locally I get a Runtime Exception in that case). But I was also not sure if this test was even supposed to be run as part of the travis job... since it has the PactBroker and PactFolder annotation both.

tinexw

comment created time in 3 months

pull request commentDiUS/pact-jvm

fix: Don't publish incomplete verification results #1166

I added the simple test.

tinexw

comment created time in 3 months

push eventtinexw/pact-jvm

Kristine Jetzke

commit sha 0727ff4c1673a6f1a210e472ea882d9553f68fd9

fix: Don't publish incomplete verification results #1166

view details

push time in 3 months

push eventtinexw/pact-jvm

Kristine Jetzke

commit sha f5d01e5a8c9c6516c661c131fc0d3c7e657bb952

fix: Don't publish incomplete verification results #1166

view details

push time in 3 months

pull request commentDiUS/pact-jvm

fix: Don't publish incomplete verification results #1166

I’m not familiar with that area of the code to comment on the implementation, but it would be good to see some tests added, at least to reproduce/cover the fix.

I can add the most basic test to ensure that respective methods are called. I just thought it would be better to also add a test on an integration test level.

tinexw

comment created time in 3 months

PR opened DiUS/pact-jvm

fix: Don't publish incomplete verification results #1166

Fixes https://github.com/DiUS/pact-jvm/issues/1166

+6 -6

0 comment

1 changed file

pr created time in 3 months

create barnchtinexw/pact-jvm

branch : junit5-filtered-pacts-fix

created branch time in 3 months

issue openedDiUS/pact-jvm

Verification results are published even though not all interactions were verified

When using JUnit 5 in combination with @FilteredPact, the verification results are always published even if not all interactions were verified. See also discussion in this PR.

Right now to me it looks like this is just not implemented for JUnit 5. I will look into it.

created time in 3 months

Pull request review commentDiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

 public class PactJUnitTest { } ``` +**NOTE!** You will not be able to publish the verification results when you apply a filter.

Yes, looking into fixing it right now, will either create issue + PR or just the issue if I cannot make any progress.

tinexw

comment created time in 3 months

push eventtinexw/pact-jvm

Ronald Holshausen

commit sha d01bd5f62a7b2778cd22c1135d53dcdf16f94f9d

update changelog for release 3.6.14

view details

Ronald Holshausen

commit sha fe54ed8385b32f8c8417a8a268ea262ae3c88129

bump version to 3.6.15

view details

Kristine Jetzke

commit sha 1f68c5785d32e2dcf446593d85f0b59b86e6aeb3

Add documentation for spring random port

view details

Kristine Jetzke

commit sha 468132ad9343676a73a739abe63ce5870471dcbf

Change comment for default pact version in PactSpecVersion annotation.

view details

Kristine Jetzke

commit sha df7853854bb8482776af361b92efe82d4ccab07f

Fix link to gradle plugin

view details

Kristine Jetzke

commit sha 6e87f3d2e17597902515a26b9fb75fb12f342c50

Support bearer token with JUnit annotations - Fixes gh-925

view details

Ronald Holshausen

commit sha 4086535a335337b06bcfed2febf8ea74731a4d63

chore: update release script for 4.0.0

view details

Ronald Holshausen

commit sha 1b99ec8ae5950c03e866ee5419ae630683de3c7c

feat: allow JUnit 4 tests to have state change methods on additional classes #943

view details

Ronald Holshausen

commit sha 981c86f8afe29012f409d177f68150f49494a0cc

fix: add the server distribution archives to the publishing #945

view details

Ronald Holshausen

commit sha f609f54b65dfb994e892a0138b862ce80bc27d9c

feat: Publish verification results with a version tag #823

view details

Ronald Holshausen

commit sha 75440eefb02ea7e81c5a7d6a4e705ed9e5ff14e3

fix: do not override the default tag handler #823

view details

Ronald Holshausen

commit sha 06ab32464d9aaf663c692dc3dab8cad03036f2de

feat: Update readmes with info on publish verification results with a version tag #823

view details

Ronald Holshausen

commit sha 2febf8086ee922faf8eb75ff9b3cdcb9a1b92c56

Merge pull request #947 from tinexw/update-spring-doc-junit5 Add documentation for spring random port

view details

Ronald Holshausen

commit sha 2e66367f5d77461b5b3552380dda9a24f55f0022

Merge pull request #948 from tinexw/update-PactTestFor-annotation Update default pact version in PactSpecVersion annotation to match docs.

view details

Ronald Holshausen

commit sha ab61458bd8069a4bcd20e3f17141d5d92f27b6a6

Merge pull request #950 from tinexw/patch-1 Fix link to gradle plugin

view details

Ronald Holshausen

commit sha d54923d86f6d5130f152a9b00a89fcc4b8781c20

fix: disable redirect handling in the verifier #952

view details

Ronald Holshausen

commit sha f53bd4c5a92858dee9741613fdd1c6161a38d286

fix: call the statechange teardown if the test fails #834

view details

Ronald Holshausen

commit sha 3a311c8e63b56bf11bc68f272beca41bec14d1d5

Merge remote-tracking branch 'origin/v3.6.x'

view details

Ryan Dens

commit sha dc6a2e91cf608704961aa91ae78bd5084d397169

:recycle: refactor Authentication to be extensible

view details

Ryan Dens

commit sha e58b76b50a99900a71b91bc0a8b656257f9925f5

:white_check_mark: add test for bearer authentication

view details

push time in 3 months

push eventtinexw/pact-jvm

Kristine Jetzke

commit sha ef157cd7b6940d06f35b5e0e565897f57e56a313

Add note about not being able to publishing results to @PactFilter section

view details

push time in 3 months

push eventtinexw/pact-jvm

Kristine Jetzke

commit sha 9f96f6969ffcf895f6e88f5b9d6430feb3a0310a

Fix typo

view details

push time in 3 months

pull request commentDiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

Since the behavior is now clear, I updated the README accordingly and reopened this PR.

tinexw

comment created time in 3 months

Pull request review commentDiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

 public class PactJUnitTest { } ``` +**NOTE!** You will not be able to publish the verification results when you apply a filter.

I extended the description accordingly.

tinexw

comment created time in 3 months

PullRequestEvent

push eventtinexw/pact-jvm

Kristine Jetzke

commit sha b2454b94e2e0e6eedcb3bab98f6d50d88ff24387

Modify description about filters to better reflect actual behavior

view details

push time in 3 months

pull request commentDiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

So I investigated more. I only looked at the most recent Pact version, no longer 3.5.x. It is broken for Junit5. For Junit4 and Maven it works as expected. Should I create a bug?

Artifact One interaction filtered out, other missing all interactions covered
JUnit4 not published :white_check_mark: published :white_check_mark:
JUnit5 published :x: published :white_check_mark:
Maven not published :white_check_mark: published :white_check_mark:
tinexw

comment created time in 3 months

pull request commentDiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

Which should not happen. I think there is a bug that I haven’t been able to create a reproduceable example for.

A verification result should be published only if all interactions have been verified (successfully or not)

Yes, there seems to be a bug. I'm currently checking junit4 in the 4.x version. I have one branch with 3.5.x and junit4 where publishing never works if filters are applied, even if combined they cover all interactions. And then I have another branch with 4.x and junit5 were publishing always works. I will check out the 4.x / junit4 combination next. Also I will check for maven and the combined filters.

tinexw

comment created time in 3 months

pull request commentDiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

Well.. strange. When using maven publishing is not allowed when using a filter.

tinexw

comment created time in 3 months

pull request commentDiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

The behavior actually changed in 4. It is now possible to publish when not all interactions were verified.

tinexw

comment created time in 3 months

pull request commentDiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

Closing until I checked the current version.

tinexw

comment created time in 3 months

Pull request review commentDiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

 public class PactJUnitTest { } ``` +**NOTE!** You will not be able to publish the verification results when you apply a filter.

Hmmm.. I realized I tested this in the 3.5.x branch (because I was investigating another bug). It might no longer be the case in 4, I will check.

tinexw

comment created time in 3 months

PR opened DiUS/pact-jvm

Add note about not being able to publishing results to @PactFilter se…

…ction

+2 -0

0 comment

1 changed file

pr created time in 3 months

push eventtinexw/pact-jvm

Kristine Jetzke

commit sha 3243f6f4c8684c9d92d494ce29423bcbdf19a884

Add note about not being able to publishing results to @PactFilter section

view details

push time in 3 months

push eventtinexw/example-provider-java-kafka

Kristine Jetzke

commit sha f16d8c4cc3cea67bd80faa47088169488d3e8faa

Fix import of @PactFolder

view details

push time in 3 months

issue commentDiUS/pact-jvm

How can I suppress the provider's UserAgent

Hi @DerKnecht,

My provider does react based on the User-Agent sent by the Consumer. What exactly do you mean be react? Does it return a different format? Execute different functionality? Both?

Could you provide more details on the framework/technologies you use? Also, what does the pact file look like that you run the provider against?

Using Spring Boot and Junit5 for example, the following interaction results in an empty User-Agent being passed:

    {
      "description": "A request for an existing user",
      "request": {
        "method": "GET",
        "path": "/users/1",
        "headers": {
          "User-Agent": ""
        }
      },
      "response": {
        "status": 200,
        "body": {}
      }
    }
DerKnecht

comment created time in 3 months

PR opened pact-foundation/docs.pact.io

chore: Add comparison with Spring Cloud Contract

And update comparison with Accurest since it's similar

+21 -11

0 comment

1 changed file

pr created time in 3 months

push eventtinexw/docs.pact.io

Kristine Jetzke

commit sha 2d4f0a249377dfc84b4b41826b34cf2367cc9fb6

chore: Add comparison with Spring Cloud Contract And update comparison with Accurest since it's similar

view details

push time in 3 months

delete branch tinexw/docs.pact.io

delete branch : patch-1

delete time in 3 months

issue closedtinexw/cdc-with-pact

user-service-contract-tests will not pass due to PROD_VERSION

PROD_VERSION returned is

git checkout Pacticipant version not found error: pathspec 'Pacticipant' did not match any file(s) known to git. error: pathspec 'version' did not match any file(s) known to git. error: pathspec 'not' did not match any file(s) known to git. error: pathspec 'found' did not match any file(s) known to git.

closed time in 3 months

devtester-ro

issue commenttinexw/cdc-with-pact

user-service-contract-tests will not pass due to PROD_VERSION

There is an initial dead lock because both services check that they can deploy and neither can because the other wasn't yet. The user-service-contract-tests job requires that there is a prod version available.

The easiest way to fix it is to

  • run messaging-app-build
  • manually tag the consumer with prod: ./pact-broker create-version-tag -a messaging-app -b http://pact_broker -e <version> -t prod
  • manually tag the provider with prod: ./pact-broker create-version-tag -a user-service -b http://pact_broker -e <version> -t prod
devtester-ro

comment created time in 3 months

PullRequestEvent

push eventtinexw/docs.pact.io

Kristine Jetzke

commit sha 593c4339fcfe7c6d7af2f62342c050f00c9ac501

Add links to pact specification

view details

push time in 3 months

fork tinexw/docs.pact.io

Pact documentation website

fork in 3 months

issue closedtinexw/cdc-with-pact

Running job in jenkins error - mvnw: Permission denied

Unable to run build on Jenkins from my git hub account. getting below error :+1: Running in /var/jenkins_home/workspace/user-service-build/user-service [Pipeline] { [Pipeline] sh

  • ../mvnw clean verify /var/jenkins_home/workspace/user-service-build/user-service@tmp/durable-00d2020f/script.sh: 1: /var/jenkins_home/workspace/user-service-build/user-service@tmp/durable-00d2020f/script.sh: ../mvnw: Permission denied

I have no clue why its downloading dependencies in @temp folder. Your help will be appreciated.

closed time in 3 months

arun290636

issue commenttinexw/cdc-with-pact

Running job in jenkins error - mvnw: Permission denied

Closing due to inactivity. Also, not able to reproduce.

arun290636

comment created time in 3 months

issue closedtinexw/cdc-with-pact

New Provider State and coupling between consumer and provider

Thanks for sharing your experience with PACT through your blog post. https://kreuzwerker.de/blog/writing-contract-tests-with-pact-in-spring-boot

I have a query on what you mentioned in "Consumer adds a new interaction (and new provider state)" section. Indeed, provider to have states defined as per consumer expecation is a kind of dependeny probably should be avoided.

  1. How is alternate approach of parameter really solve/improve the problem ? It still requires that particular parameter to be handled in provider test code for correct verification. Falling back to default state, may not work in many cases.
  2. This one may be not so important, but - Why do you think its a drawback of Spring Integration Test ? I think this is more of contraints/limitation enforced by PACT. States are pact construct, not Spring Test Framework.

It would be great if you can provide your view on above queries, Cheers.

closed time in 3 months

kiranpatel11

issue commenttinexw/cdc-with-pact

New Provider State and coupling between consumer and provider

Closing this issue due to inactivity.

kiranpatel11

comment created time in 3 months

issue commenttinexw/cdc-with-pact

Update Jenkins

Merged the PR, thanks again for the contribution.

devtester-ro

comment created time in 3 months

issue closedtinexw/cdc-with-pact

Update Jenkins

Job creation will not be triggered because of old jenkins version.

closed time in 3 months

devtester-ro

pull request commenttinexw/cdc-with-pact

Updated Jenkins version and Git plugin version to fix version issues

Hi @bit-jkraushaar thanks for the fix :-)

bit-jkraushaar

comment created time in 3 months

push eventtinexw/cdc-with-pact

Jochen Kraushaar

commit sha ca5f5e0fb440eb7ba26c30015660b2871b02af99

Updated Jenkins version and Git plugin version to fix version issues

view details

Kristine Jetzke

commit sha 70a9971ded00b7fc08e2292f84c51c4b30eae442

Merge pull request #10 from bit-jkraushaar/master Updated Jenkins version and Git plugin version to fix version issues

view details

push time in 3 months

more