profile
viewpoint

tinexw/api-blueprint 0

Demo repository for API Blueprint

tinexw/apiary-client 0

Ruby Gem for Apiary API

tinexw/awsu 0

Enhanced account switching for AWS, supports Yubikey as MFA source

tinexw/bitbucket-branch-source-plugin 0

Bitbucket Branch Source Plugin

tinexw/blueocean-plugin 0

Blue Ocean is a reboot of the Jenkins CI/CD User Experience

tinexw/checkstyle 0

Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.

tinexw/community 0

Kubernetes community content

tinexw/container-pipelines 0

Let's get the ball rolling on some Container-driven CI & CD

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 9a390642ff404a02b2e5555872d8d533e211e42a

AWS SDK 2 upgrade: Apply formatter - gh-267

view details

push time in 2 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha fce20d207c162ee8ac46dc4fd80f4919a78bfbc7

AWS SDK 2 upgrade: Resolve TODO - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha ca129c699c1df4ae9dfcdf3740bbd8cfffdc1244

AWS SDK 2 upgrade: Resolve TODO - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha d57364a637f0d9f85d346b65d83b00f6f5afa215

AWS SDK 2 upgrade: Extend test - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha b1bf2e3d12f9b2794aa25dec720d0f92a2337f7c

AWS SDK 2 upgrade: Extend test - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 6c43d086ecfa24da9da227eca0d5b642dbd746de

AWS SDK 2 upgrade: Resolve TODO - gh-267 Default task executor was changed

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 59d06cf52d14339df0168fd8e023706a7293ab4b

AWS SDK 2 upgrade: Make test more robust and remove obsolete TODO - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha e49c6ca54a8ab09c8354f8b646b0549aa1dabe68

AWS SDK 2 upgrade: Remove code duplication - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 430ae5c443a38f72a5d42ae8be32b0c221e0ef67

AWS SDK 2 upgrade: Fix bug with wrong message header conversion - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha caee33839482c474aeb5bfe3d026dd9ac598b1eb

AWS SDK 2 upgrade: Improve test - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 07be9c1b849e04c326be0b742f058a8e920048be

AWS SDK 2 upgrade: Remove obsolete TODO - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha b56ad52d6f850432f9f8b5fe7f47002993f1d600

AWS SDK 2 upgrade: Fix that ${profilePath} can be resolved - gh-267

view details

push time in 3 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 65f50ae0f11d09b8a7f3dfa4762eb7b5fbcba84a

AWS SDK 2 upgrade: Fix that ${profilePath} can be resolved - gh-267 Only in annotation, XML parsing needs to be adapted

view details

push time in 6 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 3a72d5d694de56245297f9db897c552884c4626f

AWS SDK 2 upgrade: Fix some unit tests in messaging - gh-267

view details

Kristine Jetzke

commit sha 05286267858ad412c8df137907a14c68d4de3026

AWS SDK 2 upgrade: Use both sync and async client in messaging - gh-267

view details

Kristine Jetzke

commit sha 4df2e19746b8ff8d8aab34d5bcb479836c2c5f71

AWS SDK 2 upgrade: Assert that client is async if executor is set - gh-267

view details

push time in 7 days

PR opened spring-cloud/spring-cloud-aws

Support AWS SDK 2

Upgrade AWS SDK to version 2.

Did the upgrade according to the changelog.

There are some potential blockers where I would like to get some feedback on:

Potential Blockers

1. AmazonSQSBufferedAsyncClient not supported

The AmazonSQSBufferedAsyncClient is no longer supported according to the AWS docs:

The AWS SDK for Java 2.x isn't currently compatible with the AmazonSQSBufferedAsyncClient.

There already is a ticket in the AWS SDK GitHub but it's still open: https://github.com/aws/aws-sdk-java-v2/issues/848 resp. https://github.com/aws/aws-sdk-java-v2/issues/848

Not really sure what to do... I mean as a last resort I could copy all the classes from the old SDK and update them I'd rather not...

2. No common interface for Sync and Async client

The 1.x SDK had a common interface for the sync and async client. This is no longer the case.

Previously, the user could configure either the async or the sync client and pass it to certain framework classes, e.g. NotificationMessagingTemplate. This won't be possible anymore. As a first step I would suggest to only accept one client (either sync or async - depending on which methods are used) in all customizable classes. As a next step, the classes could be duplicated to accept both clients (if needed).

Initially I thought that it was also previously possible to replace the autoconfigured sync client with the async client. But I think that was not possible because of the way the ConditionalOnMissingAmazonClient works. Can you confirm this @alainsahli ?

3. Messaging: Sync and Async client used

The messaging module currently uses the async client and calls sync and async methods on it. This is no longer possible in the new SDK. You need to use the sync client for sync methods and the async client for async methods. I see the following options with the new SDK:

  • Keep functionality the same by adding both clients and using the respective one (preferred by me)
  • Use async methods everywhere
  • Use sync methods everywhere

Please let me know what you think @spencergibb @OlgaMaciaszek

Things to do

  • [x] Upgrade libraries and fix compile errors
  • [ ] Discuss and resolve potential blockers
    • [ ] AmazonSQSBufferedAsyncClient
    • [ ] No common interface
    • [ ] Both clients used in messaging
  • [ ] Resolve remaining TODOs in code (non straightforward compile errors)
  • [ ] Run and fix all unit tests
    • [x] core
    • [x] context
    • [x] jdbc
    • [ ] messaging (waiting for blockers to be discussed)
    • [x] autoconfigure
  • [ ] Integration Tests
    • [x] Upgrade libraries and adapt to new SDK
    • [ ] Run and fix all issues that are found
  • [ ] Manual testing of everything not covered by integration tests
  • [ ] (Optional) Prettify code e.g. rename describeStacksResult variable to describeStacksResponse (all Result class names were changed to Response)
  • [ ] Update documentation
+3798 -3631

0 comment

181 changed files

pr created time in 7 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 774f4b6230109f74028c68c02d234c42330109ff

AWS SDK 2 upgrade: Fix compile errors in messaging - gh-267

view details

Kristine Jetzke

commit sha 064e20715840d878eda74107dac6d159c88a704e

AWS SDK 2 upgrade: Fix compile errors in parameter store config - gh-267

view details

Kristine Jetzke

commit sha 6c849dd6f632e38de16093e75152ba77392dbc16

AWS SDK 2 upgrade: Fix compile errors in actuator - gh-267

view details

Kristine Jetzke

commit sha 2872117a3c4310137b30882583d4a02f0c30c920

AWS SDK 2 upgrade: Fix compile errors in autoconfigure - gh-267

view details

Kristine Jetzke

commit sha fa3390dc83488d493af521fafc08892309b6282a

AWS SDK 2 upgrade: Fix compile errors in secrets manager config - gh-267

view details

Kristine Jetzke

commit sha ad9e8ae7410999503025cf61dd25dae1618bf23c

AWS SDK 2 upgrade: Fix compile errors in starters - gh-267

view details

Kristine Jetzke

commit sha 8f352cf947a557023e5cd1ba6b2f1a2d2576c644

AWS SDK 2 upgrade: Remove obsolete exclusions - gh-267

view details

Kristine Jetzke

commit sha 1f738bf7beae8e23300ddee95a605c7721e56a15

AWS SDK 2 upgrade: Fix unit tests in core - gh-267

view details

Kristine Jetzke

commit sha b80904be1d92d4f43beaf8c0c8067c809dd860ec

AWS SDK 2 upgrade: Re-add custom region property - gh-267 Accidentally removed.

view details

Kristine Jetzke

commit sha d8c8c407d200cd57a5137350b01a7f084dd5f196

AWS SDK 2 upgrade: Fix most unit tests in context - gh-267 Support for ProfileCredentialsProvider still needs to be fixed

view details

Kristine Jetzke

commit sha f4f715a84290502a403a0902f702b69cdd667e1e

AWS SDK 2 upgrade: Fix unit tests in jdbc - gh-267

view details

Kristine Jetzke

commit sha 0a05361adc76f5c59d74e2374932d848eb504886

AWS SDK 2 upgrade: Fix unit tests in autoconfigure - gh-267

view details

Kristine Jetzke

commit sha 2b6e74453932dd5c9da5037f0e5167d7222365cf

AWS SDK 2 upgrade: Fix compile errors in integration tests - gh-267

view details

push time in 8 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 0c1930feb56675620500cff6f3f4b059dfd12e20

AWS SDK 2 upgrade: Fix compile errors in integration tests - gh-267

view details

push time in 8 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 4e78419ccec5e0d93897915095341e01b0472a79

AWS SDK 2 upgrade: Fix most unit tests in context - gh-267 Support for ProfileCredentialsProvider still needs to be fixed

view details

Kristine Jetzke

commit sha 2a663193d22278374137339ecf123485f1dda277

AWS SDK 2 upgrade: Fix unit tests in jdbc - gh-267

view details

Kristine Jetzke

commit sha e5b89abdeda3134e1e79dd165349b5d77af8de70

AWS SDK 2 upgrade: Fix unit tests in autoconfigure - gh-267

view details

push time in 9 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha d85778526c8a1bab0cad106f06bd671c3723e8ec

AWS SDK 2 upgrade: Fix unit tests in autoconfigure - gh-267

view details

push time in 9 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha db2f4150e95eca2b5b2e8e8d733265cdf6627215

AWS SDK 2 upgrade: Fix unit tests in jdbc - gh-267

view details

push time in 9 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 369884120ecb1525326816669ead0550778c7ac7

AWS SDK 2 upgrade: Fix most unit tests in context - gh-267 Support for ProfileCredentialsProvider still needs to be fixed

view details

push time in 9 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha c803cd50612f57c20ef8ca400041fd8901a94164

AWS SDK 2 upgrade: Fix most unit tests in context - gh-267 Support for ProfileCredentialsProvider still needs to be fixed

view details

push time in 9 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha bda5eed50196779eb94270e9565c869cd4c70b3b

AWS SDK 2 upgrade: Re-add custom region property - gh-267 Accidentally removed.

view details

push time in 9 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha cb6592445149ae50c39d9fa580fa0cfc540ba7d0

AWS SDK 2 upgrade: Fix unit tests in core - gh-267

view details

push time in 10 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 96dcd0419b6445676a4aea0e0630f4e117fb35f6

AWS SDK 2 upgrade: Fix unit tests in core - gh-267

view details

push time in 10 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha fd023819ba91e2708c8d40ed321e8539cfcd1e16

AWS SDK 2 upgrade: Fix unit tests in core - gh-267

view details

push time in 10 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 38c73539f23e9bb1b83a70a19e5373388e10a9e2

AWS SDK 2 upgrade: Fix compile errors in core - gh-267

view details

Kristine Jetzke

commit sha 24b523022d9a476f176bee38de58b36318b478a6

AWS SDK 2 upgrade: Fix compile errors in context - gh-267

view details

Kristine Jetzke

commit sha ee65dd5c4c1270f68e0b56c246ffd440d8b3c0ad

AWS SDK 2 upgrade: Fix compile errors in jdbc - gh-267

view details

Kristine Jetzke

commit sha 2d07851f71534b14b1b49420357c1efd47d3e724

AWS SDK 2 upgrade: Fix compile errors in messaging - gh-267

view details

Kristine Jetzke

commit sha fb04240ac2a262d8ea14c32023e0b9c2de2453ae

AWS SDK 2 upgrade: Fix compile errors in parameter store config - gh-267

view details

Kristine Jetzke

commit sha a3d32292abca07494f6dc4cdcd55b97a1e9030c3

AWS SDK 2 upgrade: Fix compile errors in actuator - gh-267

view details

Kristine Jetzke

commit sha 15d2700610cd2df4a86e4c9f21694e458c80a6d3

AWS SDK 2 upgrade: Fix compile errors in autoconfigure - gh-267

view details

Kristine Jetzke

commit sha 7914b3694e6aad944b1bc06c1982fa31a3141f65

AWS SDK 2 upgrade: Fix compile errors in secrets manager config - gh-267

view details

Kristine Jetzke

commit sha ce1114bb12b27a41bff303236ecb9f9e8a1a9d76

AWS SDK 2 upgrade: Fix compile errors in starters - gh-267

view details

Kristine Jetzke

commit sha 642c8768aa5f7b9c4015f252f469cf1e5f1c0af1

AWS SDK 2 upgrade: Remove obsolete exclusions - gh-267

view details

push time in 10 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha d8ddda3f3c59ab22a58e737e3d0095038e2b4933

AWS SDK 2 upgrade: Remove obsolete exclusions - gh-267

view details

push time in 10 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 6fa794c46624f8077f33d25220ba8671b3e2fc92

AWS SDK 2 upgrade: Fix compile errors in jdbc - gh-267

view details

Kristine Jetzke

commit sha 43fa0120ce3d7f5b3c5ceff2023c1e8060ed96cb

AWS SDK 2 upgrade: Fix compile errors in messaging - gh-267

view details

Kristine Jetzke

commit sha 65f03e960d6c5cf3b9c1f90a1260154bb92e9032

AWS SDK 2 upgrade: Fix compile errors in parameter store config - gh-267

view details

Kristine Jetzke

commit sha d06cff6d6965060240d67c3f57b2def762b33734

AWS SDK 2 upgrade: Fix compile errors in actuator - gh-267

view details

Kristine Jetzke

commit sha 7a3ac2e94f5042d396f4e420b97b288ba16e0873

AWS SDK 2 upgrade: Fix compile errors in autoconfigure - gh-267

view details

Kristine Jetzke

commit sha d8e177e94decf1e28dd81b37a9326cc891d15bd1

AWS SDK 2 upgrade: Fix compile errors in secrets manager config - gh-267

view details

Kristine Jetzke

commit sha fc9b6f8f4537eb4b50cca7b9a63f2042d5936c09

AWS SDK 2 upgrade: Fix compile errors in starters - gh-267

view details

push time in 11 days

delete branch tinexw/spring-cloud-aws

delete branch : 267-upgrade-to-aws-sdk2

delete time in 11 days

issue commentaws/aws-sdk-java-v2

Automatic Request Batching

Hi,

I just wanted to know if there are any news regarding the AmazonSQSBufferedAsyncClient? I'm currently working on upgrading Spring Cloud AWS to the new SDK and it relies on this class (s. https://github.com/spring-cloud/spring-cloud-aws/issues/267).

Thanks!

shorea

comment created time in 11 days

issue commentspring-cloud/spring-cloud-aws

Support AWS SDK 2.0

So... quick update. I did the first "stupid" part of upgrading all the libraries and fixing all compile error according to the changelog.

There is still a lot to do (s. list below) but before I continue I would like to discuss some potential blockers:

1. AmazonSQSBufferedAsyncClient not supported The AmazonSQSBufferedAsyncClient is no longer supported according to the AWS docs:

The AWS SDK for Java 2.x isn't currently compatible with the AmazonSQSBufferedAsyncClient.

There already is a ticket in the AWS SDK GitHub but it's still open: https://github.com/aws/aws-sdk-java-v2/issues/848 resp. https://github.com/aws/aws-sdk-java-v2/issues/848

2. No common interface for Sync and Async client The 1.x SDK had a common interface for the sync and async client. This is no longer the case.

Previously, the user could add either the async or the sync client which would prevent a client from being autoconfigured by the framework. Additionally, a custom client could be passed to certain framework classes, e.g. NotificationMessagingTemplate.

I would suggest to

  • Always autoconfigure the sync client and if someone wants to use the async client, they can add it themselves.
  • In the first step, only accept one client (either sync or async - depending on which methods are used) in all customizable classes. As a next step, the classes could be duplicated to accept both clients.

3. Messaging: Sync and Async client used In the 1.x SDK it was possible to call sync and async methods from the async client. The messaging module makes heavy use of this. I see the following options with the new SDK:

  • Keep functionality the same by adding both clients and using the respective one (preferred by me)
  • Use async methods everywhere
  • Use sync methods everywhere

Please let me know what you think @spencergibb @OlgaMaciaszek

Things to do:

  • [x] Upgrade libraries and fix compile errors
  • [ ] Discuss and resolve potential blockers
  • [ ] Resolve remaining TODOs in code (non straightforward compile errors)
  • [ ] Run and fix all unit tests
  • [ ] Integration Tests: Upgrade libraries, fix, run and fix all issues
  • [ ] Manual testing of everything not covered by integration tests
  • [ ] Update documentation
mv78

comment created time in 11 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha a7f1d5fd99b1d8bb047c7859611c6dc5d77222ed

AWS SDK 2 upgrade: Fix compile errors in autoconfigure - gh-267

view details

Kristine Jetzke

commit sha 0901a46b592bbfab65b27423155f11cf06242cdb

AWS SDK 2 upgrade: Fix compile errors in secrets manager config - gh-267

view details

Kristine Jetzke

commit sha f05d9f3610d8140901dcc1792b34c1b01ea0492a

AWS SDK 2 upgrade: Fix compile errors in starters - gh-267

view details

push time in 11 days

create barnchtinexw/spring-cloud-aws

branch : gh-267

created branch time in 11 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 3117d328ed72e401048387b205cd8290049e2d7a

Start migrating to AWS SDK 2 - gh-267

view details

push time in 11 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha ddfbc06ca023cfd150aa05fd4c8bdd771e4f76bb

Start migrating to AWS SDK 2 - gh-267

view details

push time in 11 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha d3ea8650283bbe35b13896f589a12abd9f4b6201

Start migrating to AWS SDK 2 - gh-267

view details

push time in 11 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 3939b1586e75820adc86fc2688c14b0e43fae1ad

Start migrating to AWS SDK 2 - gh-267

view details

push time in 12 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 8932ffe8d97de722072604d4069ecccd05cb2976

Start migrating to AWS SDK 2 - gh-267

view details

push time in 12 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 09998d40e75965e0d65af33f8ac2aef291063f0c

Start migrating to AWS SDK 2 - gh-267

view details

push time in 15 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 8d3caa7a2bd44cbb2d747fa444b749fa08ce9e07

Start migrating to AWS SDK 2 - gh-267

view details

push time in 15 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 6547bd0f2d6c9826bb90c1d72a4956e5b6abbc7e

Start migrating to AWS SDK 2 - gh-267

view details

push time in 15 days

push eventtinexw/spring-cloud-aws

Kristine Jetzke

commit sha 75f644d5671348826eabcebb541a45717b7ac859

Start migrating to AWS SDK 2 - gh-267

view details

push time in 15 days

issue commenttinexw/cdc-with-pact

Running job in jenkins error - mvnw: Permission denied

Hi @arun290636 ,

sorry for not getting back to you, I unfortunately didn't see your issue. Do you still need help?

arun290636

comment created time in 15 days

issue commenttinexw/cdc-with-pact

New Provider State and coupling between consumer and provider

Hi @kiranpatel11 ,

thanks for reading my blog post and for those questions. Here are my answers ;-)

  1. Yes, it's true that it requires the particular parameter to be handled by the provider test code. But hopefully they would not need to be changed or extended very often. I kind of used a very simplified example in the blog post. You could have a more sophisticated state setup where you pass a list of users with attributes. This could then hopefully be used by many different interactions across many different consumers. But I admin that setting up good and maintainable provider states is quite a challenge.
  2. What I meant is that it's a drawback if you're using Spring Boot integration tests instead of running against the "real" system. If you run your tests against the real system, hopefully all relevant states are present. You usually have an existing user id and a non-existing user id already available. So you do not need to make a commit beforehand to the provider code base. Of course, testing against the real systems comes with a bunch of other issues;-)

Sorry for the late reply, I simply didn't see this issue.

kiranpatel11

comment created time in 15 days

push eventtinexw/spring-cloud-aws

buildmaster

commit sha 507d9e8b20cf49390be9ee0dd48fc04bf766d286

Update SNAPSHOT to 2.2.0.M3

view details

buildmaster

commit sha b96db74406c3cb7d22c96045df7e7030db528182

Going back to snapshots

view details

buildmaster

commit sha 5dbc7bf052513f088106ad32f17de7cc40327323

Update SNAPSHOT to 2.2.0.RC1

view details

buildmaster

commit sha 65809ef941dadcf9806dcd9ff7919dee194a4710

Going back to snapshots

view details

buildmaster

commit sha a224fd2fabd28d35868a9351f1d8c5fdb5e551f3

Update SNAPSHOT to 2.2.0.RC2

view details

buildmaster

commit sha b1b1b356194f55b62f10981f2777b0c31b5af38f

Going back to snapshots

view details

Ryan Baxter

commit sha 12c785a52d935d307f7caffe7894b04742229d17

Add proxyBeanMethods = false to configuration. Fixes #499

view details

Ryan Baxter

commit sha e599bfdcbb341a27dc3232c0d9d1c383b4e32b05

Removing resource class from circle config

view details

Ryan Baxter

commit sha 4655b9ae6e8a754e6de415ac9452b6b00ef6146c

Merge remote-tracking branch 'origin/2.1.x'

view details

Ryan Baxter

commit sha 44d6542a88473bf0ab24fcd799f4e5f22a342626

Create SECURITY.md

view details

Ryan Baxter

commit sha 6ad29085337c15534ffaf3529bec7e2407ddd919

Update issue templates

view details

buildmaster

commit sha 4735fb9addc7399424596d4e9c2e36894ea894fa

Bumping versions

view details

buildmaster

commit sha 4e512586886699ab664606f60374cdcfff02d4dd

Update SNAPSHOT to 2.2.0.RELEASE

view details

buildmaster

commit sha ae690440a236321119a12d4f90c958c5d62f7682

Going back to snapshots

view details

buildmaster

commit sha f7ffb78ae782c69a9e45cabfc1d96f53216cace3

Bumping versions to 2.2.1.BUILD-SNAPSHOT after release

view details

Daniel Adams

commit sha 9dcdd535c59127273f208964f04e4441fc5cf1aa

Align default max number of worker threads to default SQS batch size

view details

buildmaster

commit sha bd4fc4ae75ff9eef19dd936c242df73fec0348d6

Bumping versions

view details

Ryan Baxter

commit sha a50c279dc8d88dbd9312cfd64d2efeedd4051340

Merge pull request #382 from danieladams456/master Align default number of worker threads to default SQS batch size

view details

buildmaster

commit sha e36b4fd495203f0c28c07f08fc2954e7a2bbdc05

Bumping versions

view details

buildmaster

commit sha 1cc7f50fdd412d76ac7a368f5dcbf67cec377de1

Update SNAPSHOT to 2.2.1.RELEASE

view details

push time in 16 days

issue commentspring-cloud/spring-cloud-aws

Support AWS SDK 2.0

Good to know :-) I will pick it back up. Would be great to get some support especially in regards to testing later on.

mv78

comment created time in 16 days

issue commentserverless/serverless

Cannot activate API gateway logs for shared API gateway

Hi @medikoo , thanks for supplying this fix so soon. However, it's still not working.

There is still the issue, that updateStage.js is not called unless I remove this line. I can submit a PR that removed the line but I'm not sure of the implications because it was explicitly added by this commit.

Even after removing the line, it does not immediately work. The issue is that initially there is no stage - so the log settings cannot be applied. If I deploy the API gateway, then the first service and then the API gateway again, it works.

Do you prefer if I create a new issue for this or is it fine to track it in here?

tinexw

comment created time in 2 months

issue commentserverless/serverless

Cannot activate API gateway logs for shared API gateway

Note, that for shared APIGW, logs need to be configured in place in which APIGW is configured (and not in services which refer to it)

Yes, that’s what I was trying, see the example above.

tinexw

comment created time in 3 months

push eventtinexw/serverless

Kristine Jetzke

commit sha 781cf79ec87b876a0dd78dddfd6897c00f4b72d8

Add option to change log level for websocket logs

view details

push time in 3 months

push eventtinexw/serverless

Kristine Jetzke

commit sha 30bcb4aa3f589cf5cde37377d804b8c0fa2a6825

Add option to change log level for websocket logs

view details

push time in 3 months

issue openedserverless/serverless

Cannot activate API gateway logs if

Bug Report

Description

The API gateway log settings are not applied when using a shared API gateway as described here.

  1. What did you do?
  • Created serverless.yml my copying the example from the docs and added
logs:
    restApi: true
  • Ran sls deploy
  1. What happened?
  • API Gateway logs are not enabled.
  1. What should've happened?
  • API Gateway logs should have been enabled.
  1. What's the content of your serverless.yml file?
service: my-api
provider:
  name: aws
  runtime: nodejs12.x
  region: eu-central-1
  logs:
    restApi: true
resources:
  Resources:
    MyApiGW:
      Type: 'AWS::ApiGateway::RestApi'
      Properties:
        Name: MyApiGW
  Outputs:
    apiGatewayRestApiId:
      Value:
        Ref: MyApiGW
      Export:
        Name: MyApiGateway-restApiId
    apiGatewayRestApiRootResourceId:
      Value:
        'Fn::GetAtt':
        - MyApiGW
        - RootResourceId
      Export:
        Name: MyApiGateway-rootResourceId
  1. What's the output you get when you use the SLS_DEBUG=* environment variable (e.g. SLS_DEBUG=* serverless deploy) No difference. However, if I add a http function I can see that the AWS CLI is used to set the log settings. If no http function is defined, updateStage.js is not called. I tried to remove this line, but then I get
Serverless: [AWS apigateway 200 0.202s 0 retries] getRestApis({ position: undefined, limit: 500 })
 
  Serverless Error ---------------------------------------
 
  ServerlessError: Rest API id could not be resolved.
  This might be caused by a custom API Gateway configuration.
  
  In given setup stage specific options such as `tracing`, `logs` and `tags` are not supported.

I guess as a workaround I can define my own resources. However, I would gladly submit a PR to allow setting this with the log level properties.

Similar or dependent issues:

  • There are several issues on API gateway logs but I did not find the exact same one.

created time in 3 months

PR opened serverless/serverless

Add option to change log level for websocket logs

<!-- Please fill out THE WHOLE PR TEMPLATE. Otherwise we probably have to close the PR due to missing information -->

What did you implement

Add option to change the log level of websocket logs to ERROR. Note that I did not add an option to disable logs on purpose in order to keep the change small.

How can we verify it

service: serverless-ws-test

provider:
  name: aws
  logs:
    websocket:
      level: ERROR
  runtime: nodejs12.x
  websocketsApiName: custom-websockets-api-name

functions:
  connectionHandler:
    handler: handler.connectionHandler
    events:
      - websocket:
          route: $connect
  defaultHandler:
    handler: handler.defaultHandler
    events:
      - websocket: $default
  1. Run sls deploy
  2. Open the Logs/Tracing settings of the API gateway.
  3. Should look like this: Screen Shot 2019-12-02 at 23 28 21
  4. Change level: ERROR to level: INFO in the serverless.yml
  5. Check that the Log Level in the Logs/Tracing settings was changed to INFO

Todos

<details> <summary>Useful Scripts</summary> <!-- You might want to use the following scripts to streamline your development workflow -->

  • npm run test-ci --> Run all validation checks on proposed changes
  • npm run lint-updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check-updated --> Check if updated files adhere to Prettier config
  • npm run prettify-updated --> Prettify all the updated files

</details>

  • [x] Write and run all tests
  • [x] Write documentation
  • [x] Enable "Allow edits from maintainers" for this PR
  • [x] Update the messages below

Is this ready for review?: YES Is it a breaking change?: NO

+63 -4

0 comment

3 changed files

pr created time in 3 months

create barnchtinexw/serverless

branch : websocket-loglevel

created branch time in 3 months

push eventtinexw/serverless

Clar Charron

commit sha 62b29a1941675d25071597b9c3dfadc14415ff44

(sighs in JavaScript)

view details

Clar Charron

commit sha a74548da331043888ff9080ac246311156051f0e

Treat falsey deploymentPrefix as empty prefix

view details

Joe Atzberger

commit sha 9fc08c449bbe92d261fcf71599fc1e6ffe51826b

#6162: Support multiple schemas, don't overwrite RequestModels for each

view details

Clar Charron

commit sha cebfde19a85e935d47430fe11ea698d43548d66d

Only allow explicit '' deploymentPrefix for empty

view details

Clar Charron

commit sha 334bb810e7363788a591eb1bf2076dc376f69ccc

Allow null/undefined

view details

Clar Charron

commit sha 6aa79fb06f80d35837338631ce9f5997410b8120

Typo

view details

Clar Charron

commit sha 1e6e94283eb679a2c2e2346a0f004df3681037b9

Lints

view details

Maciej Skierkowski

commit sha 0e7aa8db4442d8d5c3a7de36c00f8137fa0fe8b6

rename output variables to outputs

view details

Maciej Skierkowski

commit sha 575083ffa8cab151014016fab06ea45a32fff6d4

Updates to CI/CD settings for the beta

view details

Pravin

commit sha ae7fab3a60cf8f49cc9b6df8353d5adc21616f85

fixed code snippet causing page overflow

view details

Pravin

commit sha fbb4a7f22579c529a8ddbddb1a7e433148bd4640

added links to infra guides to make docs more useful

view details

Pravin

commit sha 4846a795cd898a597ed02b597acdd2f504706b1b

added className for gridDisplay

view details

Pravin

commit sha 77b87ce1953b950dddcf4731b915a78c08048d10

Revert "added className for gridDisplay" This reverts commit 4846a795cd898a597ed02b597acdd2f504706b1b.

view details

Pravin

commit sha b3366e1ddd54debbceb83d0c7a4730a7d138830c

Revert "fixed code snippet causing page overflow" This reverts commit ae7fab3a60cf8f49cc9b6df8353d5adc21616f85.

view details

kdnakt

commit sha 42517daf968507c750e8bb4344b0ef1988cd5d0d

Python3.8 support!

view details

Philipp Beau

commit sha de2954a7d5508de21717af00979a8c654722337e

Provide exponential backoff with 10s jitter

view details

astuyve

commit sha a822e92612f462c32eaee26da7043432b9f60f72

Update documentation to include information about tags

view details

astuyve

commit sha f95e22b64b154f974c3f2c17ee9f6447076c766e

Prettify

view details

Anycodes

commit sha 10ec7ac9bb0844007004b74217ce36d0c7b77fa9

Merge pull request #1 from serverless/master merge

view details

dfounderliu

commit sha 7ce2ac68260e1f0d80e0a6ada6d7c4ed8dd979a7

fix tencent template

view details

push time in 3 months

pull request commentserverless/serverless

Add support for contentHandling - Fixes gh-6949

Still are you sure it fixes #6949, it doesn't look related to me, but maybe I miss something (?)

Yes. See my second comment in the issue. You can also verify this by removing the line contentHandling: CONVERT_TO_TEXT from the serverless.yml I gave above. If you create a new stack without this line and execute the curl command, you will get a 500 error and in the API gateway logs you see

(301daa80-24e8-41b2-a819-fcea915035a9) Execution failed due to configuration error: Unable to transform request
tinexw

comment created time in 3 months

issue commentserverless/serverless

Request with binary media returns 500

Edit

I made changes suggested by Tinexw in cloudformation template but nothing happened. I fixed it with my workaround mentioned above. However on comparing the new cloudformation template with the previous one and I found them to be identical. Really strange.

Could you try to delete the stack and create it from scratch? Because I tested the workaround with a new stack.

tinexw

comment created time in 3 months

push eventtinexw/serverless

Kristine Jetzke

commit sha 08f55eb32355badbd202d95d56129e2243634586

Add support for contentHandling - Fixes gh-6949

view details

push time in 3 months

push eventtinexw/serverless

Kristine Jetzke

commit sha 33792bce9b97dff557e89636f7dad074e4e28aa2

Add support for contentHandling - Fixes gh-6949

view details

push time in 3 months

push eventtinexw/serverless

Clar Charron

commit sha 62b29a1941675d25071597b9c3dfadc14415ff44

(sighs in JavaScript)

view details

Clar Charron

commit sha a74548da331043888ff9080ac246311156051f0e

Treat falsey deploymentPrefix as empty prefix

view details

Joe Atzberger

commit sha 9fc08c449bbe92d261fcf71599fc1e6ffe51826b

#6162: Support multiple schemas, don't overwrite RequestModels for each

view details

Clar Charron

commit sha cebfde19a85e935d47430fe11ea698d43548d66d

Only allow explicit '' deploymentPrefix for empty

view details

Clar Charron

commit sha 334bb810e7363788a591eb1bf2076dc376f69ccc

Allow null/undefined

view details

Clar Charron

commit sha 6aa79fb06f80d35837338631ce9f5997410b8120

Typo

view details

Clar Charron

commit sha 1e6e94283eb679a2c2e2346a0f004df3681037b9

Lints

view details

Maciej Skierkowski

commit sha 0e7aa8db4442d8d5c3a7de36c00f8137fa0fe8b6

rename output variables to outputs

view details

Maciej Skierkowski

commit sha 575083ffa8cab151014016fab06ea45a32fff6d4

Updates to CI/CD settings for the beta

view details

Pravin

commit sha ae7fab3a60cf8f49cc9b6df8353d5adc21616f85

fixed code snippet causing page overflow

view details

Pravin

commit sha fbb4a7f22579c529a8ddbddb1a7e433148bd4640

added links to infra guides to make docs more useful

view details

Pravin

commit sha 4846a795cd898a597ed02b597acdd2f504706b1b

added className for gridDisplay

view details

Pravin

commit sha 77b87ce1953b950dddcf4731b915a78c08048d10

Revert "added className for gridDisplay" This reverts commit 4846a795cd898a597ed02b597acdd2f504706b1b.

view details

Pravin

commit sha b3366e1ddd54debbceb83d0c7a4730a7d138830c

Revert "fixed code snippet causing page overflow" This reverts commit ae7fab3a60cf8f49cc9b6df8353d5adc21616f85.

view details

kdnakt

commit sha 42517daf968507c750e8bb4344b0ef1988cd5d0d

Python3.8 support!

view details

astuyve

commit sha a822e92612f462c32eaee26da7043432b9f60f72

Update documentation to include information about tags

view details

astuyve

commit sha f95e22b64b154f974c3f2c17ee9f6447076c766e

Prettify

view details

Anycodes

commit sha 10ec7ac9bb0844007004b74217ce36d0c7b77fa9

Merge pull request #1 from serverless/master merge

view details

dfounderliu

commit sha 7ce2ac68260e1f0d80e0a6ada6d7c4ed8dd979a7

fix tencent template

view details

tinafang(方坤丁)

commit sha 06482e426b07096f830da661b337750d58bb199c

Update docs and keep the function name same with templates Update docs and keep the function name same with templates

view details

push time in 3 months

PullRequestEvent

PR closed serverless/serverless

Add support for contentHandling - Fixes gh-6949

What did you implement

<!-- Briefly describe the scope of your PR --> Option to set contentHandling property of API gateway method integration and integration response.

Closes #6949

How can we verify it

service: content-handling

provider:
  name: aws
  logs:
    restApi:
      level: INFO
  runtime: nodejs8.10
  region: eu-central-1
  apiGateway:
    binaryMediaTypes:
      - 'image/jpeg'

functions:
  hello:
    handler: handler.hello
    events:
      - http:
          method: POST
          path: hello
          integration: lambda
          request:
            contentHandling: CONVERT_TO_TEXT
            template:
              image/jpeg: '{"method": "$context.httpMethod","bodyLength": $input.body.length(),"body" : "$input.body"}'
          response:
            headers:
              Content-Type: "'image/jpg'"
            contentHandling: CONVERT_TO_BINARY
// handler.js
'use strict';

const fs = require('fs');

module.exports.hello = async (event) => {
  console.log(event)
  return fs.readFileSync('./image.jpg').toString('base64');
};

image.jpg

Steps:

  • sls deploy
  • curl -XPOST -H "Content-Type: image/jpeg" -H "Accept: image/jpeg" https://<id>.execute-api.eu-central-1.amazonaws.com/dev/hello -d @image.jpg --output response.jpg
  • response.jpg should be the same asimage.jpg

Todos

<details> <summary>Useful Scripts</summary> <!-- You might want to use the following scripts to streamline your development workflow -->

  • npm run test-ci --> Run all validation checks on proposed changes
  • npm run lint-updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check-updated --> Check if updated files adhere to Prettier config
  • npm run prettify-updated --> Prettify all the updated files

</details>

  • [x] Write and run all tests
  • [x] Write documentation
  • [x] Enable "Allow edits from maintainers" for this PR
  • [x] Update the messages below

Is this ready for review?: YES Is it a breaking change?: NO

+77 -0

0 comment

3 changed files

tinexw

pr closed time in 3 months

PR opened serverless/serverless

Add support for contentHandling - Fixes gh-6949

What did you implement

<!-- Briefly describe the scope of your PR --> Option to set contentHandling property of API gateway method integration and integration response.

Closes #6949

How can we verify it

service: content-handling

provider:
  name: aws
  logs:
    restApi:
      level: INFO
  runtime: nodejs8.10
  region: eu-central-1
  apiGateway:
    binaryMediaTypes:
      - 'image/jpeg'

functions:
  hello:
    handler: handler.hello
    events:
      - http:
          method: POST
          path: hello
          integration: lambda
          request:
            contentHandling: CONVERT_TO_TEXT
            template:
              image/jpeg: '{"method": "$context.httpMethod","bodyLength": $input.body.length(),"body" : "$input.body"}'
          response:
            headers:
              Content-Type: "'image/jpg'"
            contentHandling: CONVERT_TO_BINARY
// handler.js
'use strict';

const fs = require('fs');

module.exports.hello = async (event) => {
  console.log(event)
  return fs.readFileSync('./image.jpg').toString('base64');
};

image.jpg

Steps:

  • sls deploy
  • curl -XPOST -H "Content-Type: image/jpeg" -H "Accept: image/jpeg" https://<id>.execute-api.eu-central-1.amazonaws.com/dev/hello -d @image.jpg --output response.jpg
  • response.jpg should be the same asimage.jpg

Todos

<details> <summary>Useful Scripts</summary> <!-- You might want to use the following scripts to streamline your development workflow -->

  • npm run test-ci --> Run all validation checks on proposed changes
  • npm run lint-updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check-updated --> Check if updated files adhere to Prettier config
  • npm run prettify-updated --> Prettify all the updated files

</details>

  • [x] Write and run all tests
  • [x] Write documentation
  • [x] Enable "Allow edits from maintainers" for this PR
  • [x] Update the messages below

Is this ready for review?: YES Is it a breaking change?: NO

+77 -0

0 comment

3 changed files

pr created time in 3 months

push eventtinexw/serverless

Kristine Jetzke

commit sha dae07fef0ad26c6690d6bf0ba1f25a61fb18e3a6

Add support for contentHandling - Fixes gh-6949

view details

push time in 3 months

create barnchtinexw/serverless

branch : 6949

created branch time in 3 months

fork tinexw/serverless

Serverless Framework – Build web, mobile and IoT applications with serverless architectures using AWS Lambda, Azure Functions, Google CloudFunctions & more! –

https://serverless.com

fork in 3 months

issue commentspring-cloud/spring-cloud-aws

Support AWS SDK 2.0

Ok, thanks for the update. There is quite a lot left. I will pick it up again once you know for sure if it’s going to be a major release.

mv78

comment created time in 3 months

issue commentserverless/serverless

Request with binary media returns 500

Might not be caused by the missing permission after all. I modified the serverless.yml to include the additional lambda permission. But it still doesn't work.

resources:
  Resources:
    ApiGatewayMethodHelloGet:
     # To ensure that permission is created before deployment  - in the hope that this would somehow fix it...
      DependsOn: HelloLambdaPermission
      Type: AWS::ApiGateway::Method
    HelloLambdaPermission:
      Type: AWS::Lambda::Permission
      Properties:
        FunctionName: !GetAtt HelloLambdaFunction.Arn
        Action: 'lambda:InvokeFunction'
        Principal: apigateway.amazonaws.com
        SourceArn: !Join ["", ["arn:aws:execute-api:", "${self:provider.region}:", "123:", !Ref ApiGatewayRestApi, "/*/GET/hello"]]
tinexw

comment created time in 3 months

issue openedserverless/serverless

Request with binary media returns 500

Bug Report

Description

When using binaryMediaTypes in combination with lambda non-proxy integration, then a 500 error is always returned. When using the lambda proxy integration (as given here: #6063 ) everything works fine.

The only workaround I found is to manually edit the referenced lambda function once and to re-deploy the stage (as described here: #4628). This adds additional permission to the function's policy - which I assume is what "fixes" the issue.

Lambda policy before applying workaround:

aws lambda get-policy --function-name test-dev-hello  
{
    "Policy": "{\"Version\":\"2012-10-17\",\"Id\":\"default\",\"Statement\":[{\"Sid\":\"test-dev-HelloLambdaPermissionApiGateway-T1A01LP3JK5R\",\"Effect\":\"Allow\",\"Principal\":{\"Service\":\"apigateway.amazonaws.com\"},\"Action\":\"lambda:InvokeFunction\",\"Resource\":\"arn:aws:lambda:eu-central-1:010501705700:function:test-dev-hello\",\"Condition\":{\"ArnLike\":{\"AWS:SourceArn\":\"arn:aws:execute-api:eu-central-1:010501705700:z9qb5x6fnb/*/*\"}}}]}",
    "RevisionId": "4d4b049e-f69b-4aad-a14b-76d4fba515ff"
}

Lambda policy after applying workaround:

aws lambda get-policy --function-name test-dev-hello  
{
    "Policy": "{\"Version\":\"2012-10-17\",\"Id\":\"default\",\"Statement\":[{\"Sid\":\"test-dev-HelloLambdaPermissionApiGateway-T1A01LP3JK5R\",\"Effect\":\"Allow\",\"Principal\":{\"Service\":\"apigateway.amazonaws.com\"},\"Action\":\"lambda:InvokeFunction\",\"Resource\":\"arn:aws:lambda:eu-central-1:010501705700:function:test-dev-hello\",\"Condition\":{\"ArnLike\":{\"AWS:SourceArn\":\"arn:aws:execute-api:eu-central-1:010501705700:z9qb5x6fnb/*/*\"}}},{\"Sid\":\"653c0028-bc43-43b0-84d5-f8c3ae45d8f4\",\"Effect\":\"Allow\",\"Principal\":{\"Service\":\"apigateway.amazonaws.com\"},\"Action\":\"lambda:InvokeFunction\",\"Resource\":\"arn:aws:lambda:eu-central-1:010501705700:function:test-dev-hello\",\"Condition\":{\"ArnLike\":{\"AWS:SourceArn\":\"arn:aws:execute-api:eu-central-1:010501705700:z9qb5x6fnb/*/GET/hello\"}}}]}",
    "RevisionId": "79bb00a3-93b9-4fd6-8bf6-95cb49a3818a"
}


  1. What did you do?
  • Created an API gateway with
binaryMediaTypes:
      - '*/*'

and a simple function with integration: lambda.

  1. What happened?
  • Calling the function returns 500.
  1. What should've happened?
  • Calling the function should return 200.
  1. What's the content of your serverless.yml file?
service: test

provider:
  name: aws
  runtime: nodejs8.10
  region: eu-central-1
  apiGateway:
    binaryMediaTypes:
      - '*/*'

functions:
  hello:
    handler: handler.hello
    events:
      - http:
          method: GET
          path: hello
          integration: lambda
// handler.js
'use strict';

module.exports.hello = async (event) => {
  return "hello";
};
  1. What's the output you get when you use the SLS_DEBUG=* environment variable (e.g. SLS_DEBUG=* serverless deploy)

Similar or dependent issues:

  • #2797
  • #4628

created time in 3 months

pull request commentspring-projects/spring-security

Clarify usage of hasAnyRole and hasAnyAuthority

Good suggestion @eleftherias I changed it accordingly.

tinexw

comment created time in 3 months

push eventtinexw/spring-security

Kristine Jetzke

commit sha 681f6dda6f329a97a7b70fff518fa0b4f488b2a2

Clarify usage of hasAnyRole and hasAnyAuthority

view details

push time in 3 months

push eventtinexw/spring-security

Kristine Jetzke

commit sha f36e015dfccfd14788b8feb6dc32495711bafe9d

Clarify usage of hasAnyRole and hasAnyAuthority

view details

push time in 3 months

push eventtinexw/spring-security

Kristine Jetzke

commit sha 522d0809960b520cd0cd515b73381d8a60caa191

Clarify usage of hasAnyRole and hasAnyAuthority

view details

push time in 3 months

push eventtinexw/serverless-issue-6810

Kristine Jetzke

commit sha b245b39a7fa54e16f36c7fefcfcf291b42fbda21

Reference example for related bug in readme

view details

push time in 4 months

issue openedserverless/serverless

API Gateway - Endpoint from different stack gets deleted

Bug Report

When deploying an endpoint to the API Gateway, a different endpoint that belongs to a different stack but is below the same path is deleted. This is related to #6810 but slightly different since it deletes not only itself but other, unrelated resources as well.

Description

  1. What did you do?
  • Deploy API Gateway without any endpoints
  • Deploy HTTP endpoint /bar/baz to the API Gateway - separate serverless.yml
  • Deploy HTTP endpoint /bar/baz2 to the API Gateway - separate serverless.yml.
  • Deploy HTTP endpoint /foo to the API Gateway - separate serverless.yml
  • Deploy the first endpoint /bar/baz again. This is where the bug occurs. The endpoint itself is deleted AND it the endpoint /bar/baz2 from the different stack is also deleted.
  • Deploy the first endpoint /bar/baz yet again. This will create the endpoint again but /bar/baz2 is still missing.

Please find a minimal example in https://github.com/tinexw/serverless-issue-6810/tree/removal-of-unrelated-resource (Note that the example for this bug is in branch removal-of-unrelated-resource. The master branch contains the example for #6810.)

This is the output of the minimal example:

== Deploying bar/baz - 1st run ==
-- apiGateway.restApiResources --
---------------------------------
------ Available resources ------
/           8xrij267j2
/bar/baz    e77dus
/bar        hyalc3
---------------------------------
=================================

== Deploying bar/baz2 - 1st run ==
-- apiGateway.restApiResources --
bar:        hyalc3
bar/baz:    e77dus
---------------------------------
------ Available resources ------
/           8xrij267j2
/bar/baz    e77dus
/bar        hyalc3
/bar/baz2   oeej4z
---------------------------------
=================================

========= Deploying foo =========
-- apiGateway.restApiResources --
bar:        hyalc3
bar/baz:    e77dus
bar/baz2:   oeej4z
---------------------------------
------ Available resources ------
/foo        7m5m17
/           8xrij267j2
/bar/baz    e77dus
/bar        hyalc3
/bar/baz2   oeej4z
---------------------------------
=================================

== Deploying bar/baz - 2nd run ==
-- apiGateway.restApiResources --
bar:        hyalc3
bar/baz2:   oeej4z
foo:        7m5m17
---------------------------------
------ Available resources ------
/foo    7m5m17                  <----- only foo available, bar/baz AND /bar/baz2 were removed!
/       8xrij267j2
---------------------------------
=================================

== Deploying bar/baz - 3rd run ==
-- apiGateway.restApiResources --
foo:    7m5m17
---------------------------------
------ Available resources ------
/bar/baz    3q5lit              <----- bar/baz is back (with a new id) BUT /bar/baz2 is still gone
/foo        7m5m17
/           8xrij267j2
/bar        lrpiix
---------------------------------
=================================
  1. What happened? The endpoint /bar/baz2 was unexpectedly deleted. /bar/baz was also unexpectedly deleted but this is already covered by related issue #6810.

  2. What should've happened? The endpoint /bar/baz2 should remain.

  3. What's the content of your serverless.yml file? Please refer to the minimal example.

  4. What's the output you get when you use the SLS_DEBUG=* environment variable (e.g. SLS_DEBUG=* serverless deploy) No additional information.

Similar or dependent issues:

  • #6810

created time in 4 months

create barnchtinexw/serverless-issue-6810

branch : removal-of-unrelated-resource

created branch time in 4 months

push eventtinexw/serverless-issue-6810

Kristine Jetzke

commit sha 24e827cde2d11ab1dc9c476cd973068d45187adc

Update README.md

view details

push time in 4 months

create barnchtinexw/serverless-issue-6810

branch : fix

created branch time in 4 months

issue commentserverless/serverless

Serverless framework deleting the already existing resource on sls deploy

Hi, I'm having the same issue. I have created a minimal example that reproduces the issue: https://github.com/tinexw/serverless-issue-6810/tree/master

The example performs the following steps:

  • Deploy one HTTP endpoint /bar.
  • Deploy another HTTP endpoint /foo.
  • Deploy the first endpoint /bar again. This is where the bug occurs. The endpoint is deleted.
  • Deploy the first endpoint /bar yet again. This will create the endpoint again.

What might cause the issue is that the apiGateway.restApiResources property always contains all existing resources. Thus, when deploying /bar for the 2nd time, it contains an entry like bar: jg2uja.

I'm not quite sure if that is even the expected format or if it should be /bar: jg2uja. The documentation contains both formats. However, when using the format with the slash, I immediately get the error Error: Can not find API Gateway resource from path bar.

Please find the complete output below:

==== Deploying bar - 1st run ====
-- apiGateway.restApiResources --
---------------------------------
------ Available resources ------
/	4gyxjxwh0m
/bar	e7frq7
---------------------------------
=================================
========= Deploying foo =========
-- apiGateway.restApiResources --
bar: e7frq7
---------------------------------
------ Available resources ------
/	4gyxjxwh0m
/bar	e7frq7
/foo	t8np6h
---------------------------------
=================================
==== Deploying bar - 2nd run ====
-- apiGateway.restApiResources --
bar: e7frq7
foo: t8np6h
---------------------------------
------ Available resources ------
/	4gyxjxwh0m
/foo	t8np6h              <----- only foo available, bar was removed!
---------------------------------
=================================
==== Deploying bar - 3rd run ====
-- apiGateway.restApiResources --
foo: t8np6h           
---------------------------------
------ Available resources ------
/	4gyxjxwh0m
/foo	t8np6h
/bar	xcput9              <----- bar is back (with a new id)
---------------------------------
=================================
jayanthck

comment created time in 4 months

push eventtinexw/serverless-issue-6810

Kristine Jetzke

commit sha 26dd8807767f5c843b806c9ec3e4d64dec953808

Update README.md

view details

push time in 4 months

push eventtinexw/serverless-issue-6810

Kristine Jetzke

commit sha 59beabe03f6d454e4c1513f6a45aa2377bda633d

Nicer output

view details

push time in 4 months

push eventtinexw/serverless-issue-6810

Kristine Jetzke

commit sha 9c9d481102f1fb432e9a2ac109173bbfc5a20d83

Create README.md

view details

push time in 4 months

push eventtinexw/serverless-issue-6810

Kristine Jetzke

commit sha 76c9176b532a2e8395c32cac53fa715a01e79ce7

Create README.md

view details

push time in 4 months

push eventtinexw/serverless-issue-6810

Kristine Jetzke

commit sha 052ae1e76b952e6efcde33a0ff844d50ddbd0702

Initial commit

view details

push time in 4 months

push eventtinexw/serverless-issue-6810

Kristine Jetzke

commit sha ea3d1d5066357052065d1bb8f033a5b8cae0577b

Initial commit

view details

push time in 4 months

create barnchtinexw/serverless-issue-6810

branch : master

created branch time in 4 months

created repositorytinexw/serverless-issue-6810

created time in 4 months

PR opened spring-projects/spring-security

Clarify usage of hasAnyRole and hasAnyAuthority

A valid @PreAuthorize expression with hasAnyRole looks like this: @PreAuthorize("hasAnyRole('USER', 'ADMIN')")

However, this was not quite clear to me from the documentation. It states hasAnyRole([role1,role2]). I initially thought that I had to add brackets around the complete list of roles e.g. @PreAuthorize("hasAnyRole(['USER', 'ADMIN'])").

This leads to an exception though: Caused by: org.springframework.expression.spel.SpelParseException: Expression [hasAnyRole(['USER', 'ADMIN'])] @18: EL1043E: Unexpected token. Expected 'rsquare(])' but was 'comma(,)'

which makes it clear that the brackets are wrong.

I think it would be clearer if the documentation would use this expression: hasAnyRole([role1],[role2]).

+2 -2

0 comment

1 changed file

pr created time in 4 months

create barnchtinexw/spring-security

branch : clarify-docs

created branch time in 4 months

push eventtinexw/spring-security

Kristine Jetzke

commit sha 84980872f5b723faefe5403a0fe98a10fc5b735d

Clarify usage of hasAnyRole and hasAnyAuthority

view details

push time in 4 months

push eventtinexw/spring-security

Kristine Jetzke

commit sha 9684a8599a05bda6cb7ed2959103f2f35d654b66

Clarify usage of hasAnyRole and hadAnyAuthority

view details

push time in 4 months

create barnchtinexw/cdc-demo

branch : access-log

created branch time in 4 months

push eventtinexw/cdc-demo

Kristine Jetzke

commit sha 4db0c10b06e49d591571cd59f47fdae6b6900f42

Update .gitignore

view details

push time in 4 months

push eventtinexw/cdc-demo

Kristine Jetzke

commit sha b953291e47697dd6fac2f832020e0fde90cf02da

Update IT

view details

push time in 4 months

push eventtinexw/cdc-demo

Kristine Jetzke

commit sha 66e7bb1853d9c0139d16acb716e0a6898c68cd2f

Add additional check to IT

view details

push time in 4 months

pull request commentkreuzwerker/awsu

Add option to write credentials to shared credentials file

@yawn Any chance of getting this merged soonish?

tinexw

comment created time in 4 months

push eventkreuzwerker/awsu

Roy Zheng

commit sha 6d0686f1f43d636bb9e16f3ec1d2ee5a56b8720c

Fix typo in README.md

view details

Xiangxuan Liu

commit sha 09aacaca6c5759e75c082faaf081cd26886ebf37

Upgrade ykoath to fix #39

view details

Joern Barthel

commit sha 93bd20fa23d774d6062fea2428aac58ac35075ac

Merge pull request #37 from wontonst/patch-1 Fix typo in README.md

view details

Joern Barthel

commit sha 6d30960d888c2c51773a3be725f374869e3fe5c3

Merge pull request #40 from nauxliu/upgrade-ykoath Upgrade ykoath to fix #39

view details

Joern Barthel

commit sha 7bc93f417851b72b3c7222dd094d5671a78b9391

Added note explaining magic account ID. Fixes #35.

view details

Joern Barthel

commit sha 6ad23c142b31b4b7075a76dd8f72ead795e39997

Release 2.3.2.

view details

Kristine Jetzke

commit sha 4d5bb1cbda5e79aa5928148a094ba8cd377e908b

Merge remote-tracking branch 'origin/master' into write-credentials-to-file

view details

push time in 4 months

pull request commentDiUS/pact-jvm

Support bearer token with JUnit annotations - Fixes gh-925

I changed the implementation so that it is now possible to say

authentication = @PactBrokerAuth(token = "test")

I marked the schema as deprecated. It is now automatically set to

  • Basic if the username is set
  • Bearer if the token is set

I hope marking it as deprecated is ok. It did not see it being used anywhere. Please let me know if it is actually of use somewhere and we should keep it.

tinexw

comment created time in 4 months

more