profile
viewpoint
Jintao Zhang tao12345666333 Youdao, Inc. Beijing https://moelove.info/ Container, Docker, Go, Kubernetes, Python, Vim; he/him; Twitter: @zhangjintao9020

leonchen83/redis-rdb-cli 171

Redis rdb CLI : A CLI tool that can parse, filter, split, merge rdb and analyze memory usage offline. It can also sync 2 redis data and allow user define there own sink service to migrate redis data to somewhere.

tao12345666333/backslide 8

:sweat_drops: CLI tool for making HTML presentations with Remark.js using Markdown

tao12345666333/alpine-distroless 1

"Distroless" images base on Alpine Linux.

MoeLove/sailor 0

The automatic send mail platform.

tao12345666333/2017-slides 0

Slides and talk assets from PyCon 2017

tao12345666333/angular-admin 0

AngularJS admin【DEPRECATED】

tao12345666333/ansible 0

Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.

tao12345666333/app-turbo 0

web 和 rest api 后端快速解决方案

issue openedlukaszlach/commando

Support other/edge Alpine versions

Newly generated images are always (implicitly) based on :latest - the FROM base image specifies just alpine. It would be complementary (well, quite neat) if we could use the tag specified on cmd.cat/[...]:${tag} to change the base.

Perhaps not necessarily fully parameterize it, but at least add support for :edge to use FROM alpine:edge as base. 🌻

created time in 17 minutes

issue commentkubernetes-sigs/kind

TokenRequest feature does not work

I had a brief discussion with @howardjohn about enabling this by default previously, but didn't get to following up with kubeadm upstream about if it makes sense to do there. cc @neolit123

daixiang0

comment created time in 42 minutes

issue commentkubernetes-sigs/kind

TokenRequest feature does not work

https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#service-account-token-volume-projection (upstream docs mention you must set these flags)

regarding kubeadm see e.g.: https://jpweber.io/blog/a-look-at-tokenrequest-api/ https://github.com/linkerd/linkerd2/issues/3260

daixiang0

comment created time in an hour

pull request commentkubernetes-sigs/kind

images/base: disable udev.service

podman CI is indeed broken atm (breaking podman changes...) aojea is on it

fixed by https://github.com/kubernetes-sigs/kind/pull/1790

AkihiroSuda

comment created time in an hour

push eventkubernetes-sigs/kind

Benjamin Elder

commit sha 13e7edbb79567a8a337eaf958f72ab83f83534d1

normalize NOTEs

view details

Benjamin Elder

commit sha c3919120f7f6417548fcd9988af023e259718e14

overhaul contributor getting started guide

view details

Benjamin Elder

commit sha 3b1ea2b6b20e56d121b1ac2b151753b369667c9d

- color footer - reduce max content width - fix timestamp in footer

view details

Benjamin Elder

commit sha 16fd9dd2011d84f207749f1cbe06e7d952bc47a8

re-organize resources page

view details

Benjamin Elder

commit sha ef3d6fc2ddb0b5b0e7060181f9ce84a152259eb7

improve copy button

view details

Benjamin Elder

commit sha 96b05b8209a5e93cf74ec1547e6f8bf0880b8d4d

improve outlines

view details

Benjamin Elder

commit sha 2bf53e88989a7d4d9c845f653f985a0cf2302f23

better getting started description

view details

Benjamin Elder

commit sha 910e04f19b6c701a958f475e5fa6b800d1f84ee1

bring back the map

view details

Benjamin Elder

commit sha 62bcd3037fca5b511eb1d7c4a785b96fb74fe1e7

replace outdated project layout doc with development guide (WIP)

view details

Benjamin Elder

commit sha c07ad32ad48da0bae20bee95f2d28131a09eda0b

use relative font size for header

view details

Benjamin Elder

commit sha 751678318f5dfd2b6eb294e0689576ed88e13ba5

move base image building out of quick-start

view details

Benjamin Elder

commit sha 30070c1b1bc6b6e13cb6e1ba93897c146315e437

add node image and documentation to development guide

view details

Benjamin Elder

commit sha 8759fc6a8a91ac4d2f52169c9258109723f86dd7

Merge pull request #1955 from BenTheElder/moar-docs-please improve site, start overhauling contributor guide

view details

push time in an hour

PR merged kubernetes-sigs/kind

Reviewers
improve site, start overhauling contributor guide approved cncf-cla: yes lgtm size/XL
  • normalize formatting for NOTEs
  • overhaul contributing getting started guide
  • improve ordering of resources page (bump down kubecon talks)
  • cleanup outlines on various outlined things
  • embrace em more
  • start rewriting outdated project layout guide => detailed development guide
+304 -307

3 comments

13 changed files

BenTheElder

pr closed time in an hour

pull request commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

/lgtm

BenTheElder

comment created time in an hour

Pull request review commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

 ----title: "1.0 Roadmap"+title: "1.0 Roadmap 🗺"

nice

BenTheElder

comment created time in an hour

Pull request review commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

 if there is any existing discussion or work related to your interests.  If you do not see anything, please [file a new issue][file an issue]. +> **NOTE**: _Please_ file an enhancement / [feature request issue][fr-issue] to discuss features before filing a PR (ideally even before writing any code), we have a lot to consider with respect to our+> existing users and future support when accepting any new feature.+> To streamline the process, please reach out and discuss the concept and design+> / approach ASAP so the maintainers and community can get involved early.+ Please reach out for bugs, feature requests, and other issues!   The maintainers of this project are reachable via: -- [Kubernetes Slack] in the [#kind] channel-- [filing an issue][file an issue]-- The Kubernetes [SIG-Testing Mailing List]+- [Kubernetes Slack] in the [#kind] channel (most active, along with the community)+- The issue tracker by [filing an issue][file an issue]+- The Kubernetes [SIG-Testing][SIG-Testing] [Mailing List][SIG-Testing Mailing List]

(check the rendered form in the preview)

BenTheElder

comment created time in an hour

Pull request review commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

 if there is any existing discussion or work related to your interests.  If you do not see anything, please [file a new issue][file an issue]. +> **NOTE**: _Please_ file an enhancement / [feature request issue][fr-issue] to discuss features before filing a PR (ideally even before writing any code), we have a lot to consider with respect to our+> existing users and future support when accepting any new feature.+> To streamline the process, please reach out and discuss the concept and design+> / approach ASAP so the maintainers and community can get involved early.+ Please reach out for bugs, feature requests, and other issues!   The maintainers of this project are reachable via: -- [Kubernetes Slack] in the [#kind] channel-- [filing an issue][file an issue]-- The Kubernetes [SIG-Testing Mailing List]+- [Kubernetes Slack] in the [#kind] channel (most active, along with the community)+- The issue tracker by [filing an issue][file an issue]+- The Kubernetes [SIG-Testing][SIG-Testing] [Mailing List][SIG-Testing Mailing List]

this is now two links.

BenTheElder

comment created time in an hour

Pull request review commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

 if there is any existing discussion or work related to your interests.  If you do not see anything, please [file a new issue][file an issue]. +> **NOTE**: _Please_ file an enhancement / [feature request issue][fr-issue] to discuss features before filing a PR (ideally even before writing any code), we have a lot to consider with respect to our+> existing users and future support when accepting any new feature.+> To streamline the process, please reach out and discuss the concept and design+> / approach ASAP so the maintainers and community can get involved early.+ Please reach out for bugs, feature requests, and other issues!   The maintainers of this project are reachable via: -- [Kubernetes Slack] in the [#kind] channel-- [filing an issue][file an issue]-- The Kubernetes [SIG-Testing Mailing List]+- [Kubernetes Slack] in the [#kind] channel (most active, along with the community)+- The issue tracker by [filing an issue][file an issue]+- The Kubernetes [SIG-Testing][SIG-Testing] [Mailing List][SIG-Testing Mailing List]  Current maintainers are [@BenTheElder] and [@munnerz] - feel free to

you can ping us :-) or you want to be on the list? that's coming, we'll talk soon :-)

BenTheElder

comment created time in an hour

Pull request review commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

 if there is any existing discussion or work related to your interests.  If you do not see anything, please [file a new issue][file an issue]. +> **NOTE**: _Please_ file an enhancement / [feature request issue][fr-issue] to discuss features before filing a PR (ideally even before writing any code), we have a lot to consider with respect to our+> existing users and future support when accepting any new feature.+> To streamline the process, please reach out and discuss the concept and design+> / approach ASAP so the maintainers and community can get involved early.+ Please reach out for bugs, feature requests, and other issues!   The maintainers of this project are reachable via: -- [Kubernetes Slack] in the [#kind] channel-- [filing an issue][file an issue]-- The Kubernetes [SIG-Testing Mailing List]+- [Kubernetes Slack] in the [#kind] channel (most active, along with the community)+- The issue tracker by [filing an issue][file an issue]+- The Kubernetes [SIG-Testing][SIG-Testing] [Mailing List][SIG-Testing Mailing List]  Current maintainers are [@BenTheElder] and [@munnerz] - feel free to

should I? :smile:

BenTheElder

comment created time in an hour

Pull request review commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

 if there is any existing discussion or work related to your interests.  If you do not see anything, please [file a new issue][file an issue]. +> **NOTE**: _Please_ file an enhancement / [feature request issue][fr-issue] to discuss features before filing a PR (ideally even before writing any code), we have a lot to consider with respect to our+> existing users and future support when accepting any new feature.+> To streamline the process, please reach out and discuss the concept and design+> / approach ASAP so the maintainers and community can get involved early.+ Please reach out for bugs, feature requests, and other issues!   The maintainers of this project are reachable via: -- [Kubernetes Slack] in the [#kind] channel-- [filing an issue][file an issue]-- The Kubernetes [SIG-Testing Mailing List]+- [Kubernetes Slack] in the [#kind] channel (most active, along with the community)+- The issue tracker by [filing an issue][file an issue]+- The Kubernetes [SIG-Testing][SIG-Testing] [Mailing List][SIG-Testing Mailing List]

is this a copy paste issue or is the correct format? is not [SIG-Testing][SIG-Testing Mailing List]

BenTheElder

comment created time in an hour

issue commentkubernetes-sigs/kind

Docker support is deprecated in k8s 1.20, how does this affect Kind?

@BenTheElder Great news. Thanks!

s3rj1k

comment created time in an hour

Pull request review commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

 docker --version ``` This documentation is written using Docker version 18.09.2. +### Install Go (optional)++KIND is written in [Go][golang], however our makefiles automatically ensure the+correct version of go when building or testing.++You may still wish to install go on your machine to make it easier to integrate

I think we should use it as Go when first talking about it so it's clear that it's a proper noun, but it's usually just written go.

BenTheElder

comment created time in an hour

Pull request review commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

 docker --version ``` This documentation is written using Docker version 18.09.2. +### Install Go (optional)++KIND is written in [Go][golang], however our makefiles automatically ensure the+correct version of go when building or testing.++You may still wish to install go on your machine to make it easier to integrate

go here is inconsisten, you use Go in other places

BenTheElder

comment created time in an hour

issue commentkubernetes-sigs/kind

TokenRequest feature does not work

Why I do not see those configs at Kubeadm or Kubernetes side?

daixiang0

comment created time in an hour

pull request commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

https://deploy-preview-1955--k8s-kind.netlify.app/

BenTheElder

comment created time in an hour

pull request commentkubernetes-sigs/kind

images/base: disable udev.service

podman CI is indeed broken atm (breaking podman changes...) aojea is on it

I took tonight to work on the out of sync contributor guide mostly, I'll get back to PR review in the morning 😅

On Thu, Dec 3, 2020 at 1:20 AM Akihiro Suda notifications@github.com wrote:

@BenTheElder https://github.com/BenTheElder PTAL

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/kind/pull/1948#issuecomment-737774423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHADK4D2PAI4EVUBFHCTETSS5J5PANCNFSM4UIU466A .

AkihiroSuda

comment created time in an hour

pull request commentkubernetes-sigs/kind

improve site, start overhauling contributor guide

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes-sigs/kind/pull/1955#" title="Author self-approved">BenTheElder</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

BenTheElder

comment created time in an hour

PR opened kubernetes-sigs/kind

improve site, start overhauling contributor guide
  • normalize formatting for NOTEs
  • overhaul contributing getting started guide
  • improve ordering of resources page (bump down kubecon talks)
  • cleanup outlines on various outlined things
  • embrace em more
  • start rewriting outdated project layout guide => detailed development guide
+304 -307

0 comment

13 changed files

pr created time in an hour

issue commentkubernetes-sigs/kind

TokenRequest feature does not work

This is due to kubeadm defaults IIRC. We could enable it but we'd be deviating from the defaults which we usually don't do.

https://github.com/istio/istio/blob/e02690fbfb8bda564582b27d22d9e8e6e00422a5/prow/config/trustworthy-jwt.yaml#L1-L13

daixiang0

comment created time in an hour

pull request commentkubernetes-sigs/kind

images/base: disable udev.service

@BenTheElder PTAL

AkihiroSuda

comment created time in an hour

pull request commentkubernetes-sigs/kind

images/base: disable udev.service

Failure of Podman CI seems unrelated

• Waiting ≤ 1m0s for control-plane = Ready ⏳  ...
 ✓ Waiting ≤ 1m0s for control-plane = Ready ⏳
 • Ready after 28s 💚
ERROR: failed to create cluster: network details should only be one line, got 0 lines
AkihiroSuda

comment created time in an hour

issue commentkubernetes-sigs/kind

TokenRequest feature does not work

Easily use this to test:

apiVersion: v1
kind: Pod
metadata:
  name: sa-token-test
spec:
  containers:
  - name: container-test
    image: busybox
    volumeMounts:
    - name: token-vol
      mountPath: "/service-account"
      readOnly: true
  volumes:
  - name: token-vol
    projected:
      sources:
      - serviceAccountToken:
          audience: api
          expirationSeconds: 3600
          path: token
daixiang0

comment created time in 2 hours

pull request commentdocker-library/docker

rootless: replace VPNKit with slirp4netns + support ARM

rebased

AkihiroSuda

comment created time in 2 hours

pull request commentkubernetes/sig-release

cleanup missing hyperlink

I think there should be no conflicts if #1371 goes in first so I'm going to vote that we merge this after #1371

249043822

comment created time in 2 hours

issue openedkubernetes-sigs/kind

TokenRequest feature does not work

<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!-->

What happened:

TokenRequest feature does not work.

root@kind-control-plane:/# grep Token /var/lib/kubelet/config.yaml
  TokenRequest: true
  TokenRequestProjection: true

What you expected to happen:

TokenRequest feature works.

How to reproduce it (as minimally and precisely as possible):

  • enable TokenRequest feature with following config:
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
featureGates:
  # any feature gate can be enabled here with "Name": true
  # or disabled here with "Name": false
  # not all feature gates are tested, however
  TokenRequest: true
  TokenRequestProjection: true
  • refer to https://github.com/kubernetes-sigs/apiserver-network-proxy/blob/master/examples/kubernetes/README.md

  • the agent is failed:

  Warning  FailedMount  14s (x12 over 8m28s)  kubelet, kind-control-plane  MountVolume.SetUp failed for volume "konnectivity-agent-token" : failed to fetch token: the API server does not have TokenRequest endpoints enabled

Anything else we need to know?:

Environment:

  • kind version: (use kind version):
kind v0.9.0 go1.14.4 linux/amd64
  • Kubernetes version: (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:56:40Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.1", GitCommit:"206bcadf021e76c27513500ca24182692aabd17e", GitTreeState:"clean", BuildDate:"2020-09-14T07:30:52Z", GoVersion:"go1.15", Compiler:"gc", Platform:"linux/amd64"}
  • Docker version: (use docker info): 19.03.6
  • OS (e.g. from /etc/os-release): Ubuntu 18.04

created time in 2 hours

pull request commentkubernetes/sig-release

cleanup missing hyperlink

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes/sig-release/pull/1370#" title="Author self-approved">249043822</a>, <a href="https://github.com/kubernetes/sig-release/pull/1370#pullrequestreview-543721432" title="LGTM">saschagrunert</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

249043822

comment created time in 2 hours

pull request commentkubernetes/sig-release

Release notes draft v1.20.0 rc.0

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes/sig-release/pull/1371#pullrequestreview-543713639" title="LGTM">saschagrunert</a>, <a href="https://github.com/kubernetes/sig-release/pull/1371#issuecomment-737750352" title="Approved">soniasingla</a>, <a href="https://github.com/kubernetes/sig-release/pull/1371#" title="Author self-approved">wilsonehusin</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

wilsonehusin

comment created time in 2 hours

more