profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/aojea/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Antonio Ojea aojea Red Hat Spain The network is reliable. Latency is zero, Bandwidth is infinite, ..

aojea/clusterip-webhook 1

validating and mutating webhook to manage the Kubernetes Services Cluster IPs

aojea/aks-engine 0

AKS Engine: Units of Kubernetes on Azure!

aojea/automation 0

Automation scripts for development, testing, and CI

aojea/aws-ami 0

Baking AWS AMIs.

aojea/bats 0

Bash Automated Testing System

aojea/bookkeeper 0

Apache Bookkeeper

aojea/catalystcloud-ansible 0

Catalyst Cloud Ansible templates and examples

Pull request review commentkubernetes/kubernetes

Recover from volume expansion failure

 func (persistentvolumeclaimStrategy) GetResetFields() map[fieldpath.APIVersion]* func (persistentvolumeclaimStrategy) PrepareForCreate(ctx context.Context, obj runtime.Object) { 	pvc := obj.(*api.PersistentVolumeClaim) 	pvc.Status = api.PersistentVolumeClaimStatus{}--	pvcutil.DropDisabledFields(&pvc.Spec, nil)+	pvcutil.SetAllocatedResources(pvc, nil)

actually I think there is a precedence for this in PrepareForCreate function of podStrategy which sets:

	pod := obj.(*api.Pod)
	pod.Status = api.PodStatus{
		Phase:    api.PodPending,
		QOSClass: qos.GetPodQOS(pod),
	}

	podutil.DropDisabledPodFields(pod, nil)
gnufied

comment created time in a minute

Pull request review commentkubernetes/kubernetes

Remove MPL-licensed dep from lruexpirecache

 type LRUExpireCache struct { 	// clock is used to obtain the current time 	clock Clock -	cache *lru.Cache-	lock  sync.Mutex+	lock sync.Mutex++	maxSize      int+	evictionList list.List

According to the docs, the zero value of List is an empty list that's ready to use. It looks like it gets lazily initialized as elements are added.

ahmedtd

comment created time in 2 minutes

pull request commentkubernetes/kubernetes

Automated cherry pick of #102665: Add explicit capability for online volume expansion

@gnufied: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-gce-100-performance 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-typecheck 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-typecheck
pull-kubernetes-e2e-kind 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-kind
pull-kubernetes-bazel-test 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-bazel-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

gnufied

comment created time in 2 minutes

pull request commentkubernetes/kubernetes

Automated cherry pick of #102665: Add explicit capability for online volume expansion

@gnufied: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-gce-100-performance 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-typecheck 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-typecheck
pull-kubernetes-e2e-kind 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-kind

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

gnufied

comment created time in 3 minutes

issue commentkubernetes/kubernetes

New log rotation mechanism required

@SergeyKanzhelev: Closing this issue.

<details>

In response to this:

/close

please re-open if the bug is still relevant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. </details>

crassirostris

comment created time in 3 minutes

issue closedkubernetes/kubernetes

New log rotation mechanism required

For the context: https://github.com/kubernetes/kubernetes/issues/28369 https://github.com/kubernetes/kubernetes/issues/37292 https://github.com/kubernetes/kubernetes/issues/29715

Current mechanism, running logrotate as a cron job hourly in the copytruncate mode poses several problems

  • copytruncate mode doesn't integrate well with external logging agents
    • line broken in the middle can sometimes make fluentd enter infinite crashloop (hard to reproduce, so no issue for that, but happened several times during high load)
    • logging agent store read offsets, but copytruncate makes these offsets invalid, which may result in losing lines between the old offset and the size of file right before the rotation
  • Rotating logs hourly without the ability to reconfigure doesn't scale very well for highly verbose applications

Something should be implemented to replace the current solution, either on the node level or as a DaemonSet.

CC @kubernetes/sig-node @kubernetes/sig-instrumentation

closed time in 3 minutes

crassirostris

issue commentkubernetes/kubernetes

New log rotation mechanism required

/close

please re-open if the bug is still relevant

crassirostris

comment created time in 3 minutes

pull request commentopenshift/ovn-kubernetes

Bug 1961506: Detect if OVS supports check pkt length

@trozet: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 29795578265d63ca8e1147f41972f326b2cc27ef link /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-gcp-ovn 29795578265d63ca8e1147f41972f326b2cc27ef link /test e2e-gcp-ovn
ci/prow/okd-e2e-gcp-ovn 29795578265d63ca8e1147f41972f326b2cc27ef link /test okd-e2e-gcp-ovn
ci/prow/e2e-azure-ovn 29795578265d63ca8e1147f41972f326b2cc27ef link /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

trozet

comment created time in 4 minutes

pull request commentkubernetes/kubernetes

WIP - PodSecurity admission

@liggitt: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-kind b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-e2e-kind
pull-kubernetes-integration b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-integration
pull-kubernetes-e2e-kind-ipv6 b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-e2e-gce-alpha-features b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-dependencies e8845d5841539083829a5777aa02d02bfe77d053 link /test pull-kubernetes-dependencies

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

liggitt

comment created time in 4 minutes

issue commentkubernetes/kubernetes

New log rotation mechanism required

/assign

@dashpole this assignment happened last year. Do you still want to work on this?

as per the issue - log rotation is implemented in CRI now. And Dockershim is deprecated. Is this still an issue?

KEP: https://github.com/kubernetes/enhancements/issues/2411

crassirostris

comment created time in 4 minutes

Pull request review commentkubernetes/kubernetes

CRI: add fields for pod level stats to satisfy the /stats/summary API

 message FilesystemUsage {     // This may not equal InodesCapacity - InodesAvailable because the underlying     // filesystem may also be used for purposes other than storing images.     UInt64Value inodes_used = 4;+    // TODO: Unclear how the remaining fields relate to container stats. Is it filled in cAdvisor?

update: they don't make sense for the CRI to return, as they're stats based on the device themselves

haircommander

comment created time in 6 minutes

Pull request review commentkubernetes/kubernetes

CRI: add fields for pod level stats to satisfy the /stats/summary API

 func (ds *dockerService) ListContainerStats(ctx context.Context, r *runtimeapi.L  	return &runtimeapi.ListContainerStatsResponse{Stats: stats}, nil }++// PodSandboxStats returns stats for a pod stats request based on pod id.+// This function is not implemented for the dockershim.+func (ds *dockerService) PodSandboxStats(_ context.Context, r *runtimeapi.PodSandboxStatsRequest) (*runtimeapi.PodSandboxStatsResponse, error) {+	return nil, errors.New("Not implemented")

good idea

haircommander

comment created time in 6 minutes

Pull request review commentkubernetes/kubernetes

CRI: add fields for pod level stats to satisfy the /stats/summary API

 func (ds *dockerService) ListContainerStats(ctx context.Context, r *runtimeapi.L  	return &runtimeapi.ListContainerStatsResponse{Stats: stats}, nil }++// PodSandboxStats returns stats for a pod stats request based on pod id.+// This function is not implemented for the dockershim.+func (ds *dockerService) PodSandboxStats(_ context.Context, r *runtimeapi.PodSandboxStatsRequest) (*runtimeapi.PodSandboxStatsResponse, error) {+	return nil, errors.New("Not implemented")+}++// ListPodSandboxStats returns stats for a list container stats request based on a filter.

added

haircommander

comment created time in 6 minutes

Pull request review commentkubernetes/kubernetes

CRI: add fields for pod level stats to satisfy the /stats/summary API

 service RuntimeService {     // ListContainerStats returns stats of all running containers.     rpc ListContainerStats(ListContainerStatsRequest) returns (ListContainerStatsResponse) {} +    // PodSandboxStats returns stats of the pod. If the pod does not+    // exist, the call returns an error.+    rpc PodSandboxStats(PodSandboxStatsRequest) returns (PodSandboxStatsResponse) {}+    // ListPodSandboxStats returns stats of all running pods.

updated!

haircommander

comment created time in 7 minutes

issue commentkubernetes/kubernetes

Incorrect/missing SELinux labeling when using ConfigMap subPath

Can you confirm if this is still a bug on more recent kubernetes versions?

/remove-lifecycle frozen

thoraxe

comment created time in 8 minutes

pull request commentkubernetes/kubernetes

Automated cherry pick of #102665: Add explicit capability for online volume expansion

@gnufied: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-gce-100-performance 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-typecheck 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-typecheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

gnufied

comment created time in 9 minutes

issue commentkubernetes/kubernetes

Term `master` still exist in some script files

This is pretty challenging to clean up, these environment variables are sort of an "API", I think we should probably drop it from the docs, as this script is really not suitable for any sort of production use, it's just still widely used in the project's CI.

https://github.com/kubernetes/kubernetes/blob/master/cluster/README.md (see deprecation notice)

jihoon-seo

comment created time in 9 minutes

pull request commentkubernetes/kubernetes

Automated cherry pick of #102665: Add explicit capability for online volume expansion

@gnufied: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-e2e-gce-100-performance 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

gnufied

comment created time in 10 minutes

issue commentkubernetes/kubernetes

Auto-closing issues is harmful and causes friction

Being mostly on the user side I do feel a lot of frustration with these. I think auto-closing specifically in the case of a ticket/PR being in a "waiting for OP to respond" state is okay but when the issue is accepted as real and there's nothing more to say, then auto-closing them is pretty grumble-inducing. Auto-cloing untriaged tickets/PRs feels like a gray area, can see both sides, and probably should be a special case and a sign that our triage process needs improvement.

dims

comment created time in 12 minutes

pull request commentopenshift/kubernetes

Bug 1968520: update to k8s 1.21.2

@soltysh: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp b2a900bcff2294b5af82bad1ba3d8c6e87a9ce19 link /test e2e-gcp
ci/prow/e2e-metal-ipi-ovn-dualstack b2a900bcff2294b5af82bad1ba3d8c6e87a9ce19 link /test e2e-metal-ipi-ovn-dualstack
ci/prow/verify-commits b2a900bcff2294b5af82bad1ba3d8c6e87a9ce19 link /test verify-commits
ci/prow/e2e-aws-single-node b2a900bcff2294b5af82bad1ba3d8c6e87a9ce19 link /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

soltysh

comment created time in 13 minutes

issue commentkubernetes/kubernetes

kubelet process restart leads to oscillation in Cloud LoadBalancer targets

/remove-sig node

from a node perspective this is somewhat expected behavior

zuzzas

comment created time in 14 minutes

pull request commentkubernetes/kubernetes

WIP - PodSecurity admission

@liggitt: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-node-e2e-containerd b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-verify-govet-levee b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-verify-govet-levee
pull-kubernetes-e2e-kind b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-e2e-kind
pull-kubernetes-integration b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-integration
pull-kubernetes-typecheck b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-typecheck
pull-kubernetes-e2e-kind-ipv6 b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-e2e-gce-100-performance b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-verify b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-verify
pull-kubernetes-conformance-kind-ga-only-parallel b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-e2e-gce-alpha-features b25585a175013f4f2f19c3f0eee073bd55a31a56 link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-dependencies 548ea28070602df101edc6b590d42230ce503639 link /test pull-kubernetes-dependencies

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

liggitt

comment created time in 14 minutes

issue commentkubernetes/kubernetes

Only expose nodePorts on some IPs

/remove-lifecycle stale

SimonHeimberg

comment created time in 14 minutes

pull request commentkubernetes/kubernetes

Automated cherry pick of #102665: Add explicit capability for online volume expansion

@gnufied: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 899c909b2779edee9eee196ea1ac19b872c5e29b link /test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

gnufied

comment created time in 14 minutes

pull request commentopenshift/ovn-kubernetes

Bug 1961506: Detect if OVS supports check pkt length

/retest

Please review the full test history for this PR and help us cut down flakes.

trozet

comment created time in 15 minutes

issue commentkubernetes/k8s.io

Increase AWS limits in some regions

@idvoretskyi I'm experiencing this with Kops on 768319786644, but cluster-api-provider-aws runs on different accounts

rifelpet

comment created time in 17 minutes

pull request commentkubernetes/kubernetes

images: Removes OS Version workaround for manifest list images

I think this is reasonable, most developers are not building the test images anyhow, I'm not sure exactly where we should draw the line for the core images which lots of people are building all the time for development in addition to downstream distros, but for test images mostly built by CI this seems fine without getting too into the weeds.

I think there's a discussion to be had somewhere about what docker version is reasonable to require, along with the buildx issue

claudiubelu

comment created time in 17 minutes