profile
viewpoint
Stephen Day stevvooe San Francisco

sirupsen/logrus 14909

Structured, pluggable logging for Go.

docker/distribution 5320

The Docker toolset to pack, ship, store, and deliver content

amacneil/dbmate 750

:rocket: A lightweight, framework-agnostic database migration tool.

cruise-automation/rbacsync 176

Automatically sync groups into Kubernetes RBAC

containerd/ttrpc 174

GRPC for low-memory environments

docker/go-events 97

Composable event distribution for Go

containerd/continuity 77

A transport-agnostic, filesystem metadata manifest system

jbuberel/buildmodeshared 66

How to use Go to build shared libraries

containerd/btrfs 22

Btrfs bindings for Go

gogo/googleapis 22

googleapis generated with gogoprotobuf

pull request commentopencontainers/go-digest

Add release notes for v1.0.0

LGTM

dmcgowan

comment created time in 12 days

issue commentopencontainers/go-digest

Using multihash for digests

The example referenced in the spec is just an example of an unregistered algorithm. Typically, the first part is the algorithm and the second part is some modifier describing the details of the encoding. There's no reason we couldn't store a multihash in a go-digest string. The only constraint is that the encoding has to be URL safe (https://github.com/opencontainers/go-digest/blob/master/digest.go#L63).

Seems like multibase would be sufficient as a prefix, since the rest of the decoding information is embedded in the string.

One thing to consider here: it is not necessarily better to support a whole slew of algorithms, since it makes sets of content mutually incompatible without more intelligent backend support. Ideally, you choose one algorithm that is "canonical" then have conversions to/from that main one. Annotations, as you mentioned earlier, might be sufficient for packing images that were built by docker then pushed into the ipcs context.

One other thing we might consider: the use of Algorithm.Size() assumes a fixed size output encoding. I can't remember why this is there, other than being compatible with Go's crypto package, which assumes fixed size hash outputs, so if that is an issue, we might be able to deprecate it.

hinshun

comment created time in 12 days

pull request commentopencontainers/go-digest

Add digestset subpackage

Looks like I've been removed from @opencontainers/go-digest-maintainers for some reason, so its not tracking my LGTM.

dmcgowan

comment created time in 14 days

issue commentgolang/protobuf

APIv2: generated messages are incompatible with current v1 package

https://github.com/gogo/protobuf/issues/678 for tracking.

neild

comment created time in a month

issue commentgogo/protobuf

gogo/proto marshalling is failing with latest github.com/golang/protobuf v1.4.0-rc.4

I've seen a similar issue:

panic: protobuf tag not enough fields in FileDescriptorSet.state:
goroutine 1 [running]:
github.com/gogo/protobuf/proto.(*unmarshalInfo).computeUnmarshalInfo(0xc000090820)
        /go/src/github.com/gogo/protobuf/proto/table_unmarshal.go:341 +0x17fb
github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0xc000090820, 0xc00008a5c0, 0xc000320000, 0x4752, 0x4952, 0x40c338, 0x20)
        /go/src/github.com/gogo/protobuf/proto/table_unmarshal.go:138 +0xe13
github.com/gogo/protobuf/proto.(*InternalMessageInfo).Unmarshal(0xc000077940, 0x7b0780, 0xc00008a5c0, 0xc000320000, 0x4752, 0x4952, 0xc00008a501, 0x0)
        /go/src/github.com/gogo/protobuf/proto/table_unmarshal.go:63 +0x66
github.com/gogo/protobuf/proto.(*Buffer).Unmarshal(0xc00010b440, 0x7b0780, 0xc00008a5c0, 0x0, 0x0)
        /go/src/github.com/gogo/protobuf/proto/decode.go:424 +0x1ec
github.com/gogo/protobuf/proto.Unmarshal(0xc000320000, 0x4752, 0x4952, 0x7b0780, 0xc00008a5c0, 0x0, 0x0)
        /go/src/github.com/gogo/protobuf/proto/decode.go:342 +0x170
main.readDesc(0xc000083300, 0x1d, 0x0, 0x0, 0x0)
        /go/src/github.com/stevvooe/protobuild/descriptors.go:96 +0x9e
main.main()
        /go/src/github.com/stevvooe/protobuild/main.go:218 +0x1819
make: *** [Makefile:143: protos] Error 2
adithya66

comment created time in a month

issue commentgolang/protobuf

APIv2: generated messages are incompatible with current v1 package

Ok, thanks!

neild

comment created time in a month

push eventstevvooe/protobuild

Phil Estes

commit sha ce0b1c3545d353082fd78b69e283a571a008d52c

Update travis CI to build/DCO validate Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Stephen Day

commit sha 324b1750ca060b814b18f4142b544b292d42968e

Merge pull request #30 from estesp/ci-update Update travis CI to build/DCO validate

view details

push time in a month

PR merged stevvooe/protobuild

Update travis CI to build/DCO validate

This won't fully work until #29 is merged. Ready to go.

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

+10 -3

0 comment

1 changed file

estesp

pr closed time in a month

issue commentgolang/protobuf

APIv2: generated messages are incompatible with current v1 package

We are seeing a similar problem when using protobuild against the new package:

goroutine 1 [running]:
github.com/gogo/protobuf/proto.(*unmarshalInfo).computeUnmarshalInfo(0xc000090820)
        /go/src/github.com/gogo/protobuf/proto/table_unmarshal.go:341 +0x17fb
github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0xc000090820, 0xc00008a5c0, 0xc000320000, 0x4752, 0x4952, 0x40c338, 0x20)
        /go/src/github.com/gogo/protobuf/proto/table_unmarshal.go:138 +0xe13
github.com/gogo/protobuf/proto.(*InternalMessageInfo).Unmarshal(0xc000077940, 0x7b0780, 0xc00008a5c0, 0xc000320000, 0x4752, 0x4952, 0xc00008a501, 0x0)
        /go/src/github.com/gogo/protobuf/proto/table_unmarshal.go:63 +0x66
github.com/gogo/protobuf/proto.(*Buffer).Unmarshal(0xc00010b440, 0x7b0780, 0xc00008a5c0, 0x0, 0x0)
        /go/src/github.com/gogo/protobuf/proto/decode.go:424 +0x1ec
github.com/gogo/protobuf/proto.Unmarshal(0xc000320000, 0x4752, 0x4952, 0x7b0780, 0xc00008a5c0, 0x0, 0x0)
        /go/src/github.com/gogo/protobuf/proto/decode.go:342 +0x170
main.readDesc(0xc000083300, 0x1d, 0x0, 0x0, 0x0)
        /go/src/github.com/stevvooe/protobuild/descriptors.go:96 +0x9e
main.main()
        /go/src/github.com/stevvooe/protobuild/main.go:218 +0x1819
make: *** [Makefile:143: protos] Error 2```

What exactly is the remediation here?
neild

comment created time in a month

IssuesEvent

issue commentstevvooe/protobuild

Support Go modules

#29 only made it compatible with go get using go modules. We still need a solution that works with using only modules.

stevvooe

comment created time in a month

push eventstevvooe/protobuild

Phil Estes

commit sha 12cec7dc4ac557e8388e05208139111d6e409919

Make protobuild go-mod friendly Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com>

view details

Stephen Day

commit sha 0e627391fb3df678f5d9b4f1aac133f159548fa1

Merge pull request #29 from estesp/go-mod-friendly Make protobuild go-mod friendly

view details

push time in a month

issue closedstevvooe/protobuild

Support Go modules

It might be time to start considering support for Go modules. Suggestions and support are welcome.

closed time in a month

stevvooe

PR merged stevvooe/protobuild

Make protobuild go-mod friendly

Fixes: #27

Signed-off-by: Phil Estes estesp@linux.vnet.ibm.com

+73 -0

1 comment

3 changed files

estesp

pr closed time in a month

pull request commentcontainerd/containerd

mount: handle loopback mount

Would it be possible to reconcile this code with the other losetup code in containerd? https://github.com/containerd/containerd/search?q=losetup&unscoped_q=losetup provides some references. I didn't look into how similar they are.

bergwolf

comment created time in a month

delete branch stevvooe/containerd

delete branch : valdiate-digest-before-disk

delete time in a month

push eventstevvooe/containerd

Stephen Day

commit sha 4615111ba2d448d2a0ce7f5881ef3af0d24ba4d7

content/local: validate digest before calculating path Signed-off-by: Stephen Day <stephen.day@getcruise.com>

view details

push time in 2 months

PR opened containerd/containerd

Reviewers
content/local: validate digest before calculating path

Signed-off-by: Stephen Day stephen.day@getcruise.com

+34 -9

0 comment

2 changed files

pr created time in 2 months

create barnchstevvooe/containerd

branch : valdiate-digest-before-disk

created branch time in 2 months

push eventstevvooe/containerd

Stephen Day

commit sha b446306b974c17a8bafaf1e2358f32ec84e50c22

content/local: validate digest before calculating path Signed-off-by: Stephen Day <stephen.day@getcruise.com>

view details

push time in 2 months

pull request commentopencontainers/go-digest

MAINTAINERS: add 2, remove 5

LGTM

Approved with PullApprove

vbatts

comment created time in 2 months

pull request commentopencontainers/go-digest

Update pull approve configuration

Lgtm

dmcgowan

comment created time in 2 months

delete branch stevvooe/protobuild

delete branch : buildkite

delete time in 2 months

PR closed stevvooe/protobuild

build: test the buildkite pipeline setup

Signed-off-by: Stephen Day stephen.day@getcruise.com

+3 -0

0 comment

1 changed file

stevvooe

pr closed time in 2 months

push eventstevvooe/protobuild

Stephen Day

commit sha 805f388bb498d73e70794a898d40a4ec505fc199

build: test the buildkite pipeline setup Signed-off-by: Stephen Day <stephen.day@getcruise.com>

view details

push time in 2 months

PR opened stevvooe/protobuild

build: test the buildkite pipeline setup

Signed-off-by: Stephen Day stephen.day@getcruise.com

+3 -0

0 comment

1 changed file

pr created time in 2 months

push eventstevvooe/protobuild

Stephen Day

commit sha 2976ca21adc37886d16e84638005131fe0fea651

build: test the buildkite pipeline setup Signed-off-by: Stephen Day <stephen.day@getcruise.com>

view details

push time in 2 months

create barnchstevvooe/protobuild

branch : buildkite

created branch time in 2 months

created tagcontainerd/containerd

tag''

An open and reliable container runtime

created time in 3 months

release containerd/containerd

''

released time in 3 months

push eventcruise-automation/rbacsync

David Xia

commit sha f56333017892b0f82a6665e02b7f3aa87221f422

Fix rbac.yaml The "escalate" permission needs to be added to (Cluster)Role not (Cluster)RoleBinding. Users might also need the "bind" permission. See https://v1-13.docs.kubernetes.io/docs/reference/access-authn-authz/rbac/#privilege-escalation-prevention-and-bootstrapping Signed-off-by: David Xia <dxia@spotify.com>

view details

Stephen Day

commit sha 21027c859bb512495da1d75225c3e047308a93fb

Merge pull request #25 from davidxia/fix-rbac Fix rbac.yaml

view details

push time in 3 months

PR merged cruise-automation/rbacsync

Fix rbac.yaml

The "escalate" permission needs to be added to (Cluster)Role not (Cluster)RoleBinding. Users might also need the "bind" permission.

See https://v1-13.docs.kubernetes.io/docs/reference/access-authn-authz/rbac/#privilege-escalation-prevention-and-bootstrapping

+12 -10

4 comments

1 changed file

davidxia

pr closed time in 3 months

create barnchcruise-automation/rbacsync

branch : go-1.13-image

created branch time in 3 months

more