profile
viewpoint
Steven R. Loomis srl295 @srl295 San José, CA, USA https://srl295.github.io me? i18n and @unicode-org stuff

srl295/btest402 7

Basic test of ES402 Intl object in Javascript.

srl295/es-unicode-properties 4

Unicode properties in ES

DTownSMR/kibana-i18n 1

:bar_chart: Kibana analytics and search dashboard for Elasticsearch

srl295/.profile.d 1

*My* configuration files. Also a way to learn about git.

srl295/fa-docker-compose 1

FrontAccounting for Docker Compose

behnam/unicode-idna 0

Unicode IDNA Compatibility Processing Data

srl295/bent 0

Functional HTTP client for Node.js w/ async/await.

srl295/blackbox_exporter 0

Blackbox prober exporter

srl295/blue-messenger 0

i18n of blue-messanger

delete branch srl295/cldr

delete branch : test11585

delete time in 2 hours

push eventunicode-org/cldr

Steven R. Loomis

commit sha 8b6d27416abc7020534ef5463a7bec668fb0829b

CLDR-11585 improve maven tests (#741) - You can run individual tests using testArgs properties. Example to run only one test from the main unit tests: mvn test '-Dorg.unicode.cldr.unittest.testArgs=-f:TestUntimedCounter -n -q' Example to run only one test from web: (could be combined w/ prior example) mvn test '-Dorg.unicode.cldr.unittest.web.testArgs=-f:TestMisc -n -q'

view details

push time in 2 hours

PR merged unicode-org/cldr

Reviewers
CLDR-11585 improve maven tests

you can now run specific subtests with:

mvn test '-Dorg.unicode.cldr.unittest.web.testArgs=-f:TestMisc -n -q' '-Dorg.unicode.cldr.unittest.testArgs=-f:TestUntimedCounter -n -q' 

I was unable to get code coverage to work here, but it's just a config file change away.

+39 -28

1 comment

6 changed files

srl295

pr closed time in 2 hours

pull request commentunicode-org/cldr

CLDR-14175 update JSON converter to handle compoundUnitPattern1

@kipcole9 please give this PR a try

srl295

comment created time in 4 hours

pull request commentunicode-org/cldr

CLDR-14175 update JSON converter to handle compoundUnitPattern1

@macchiati I'll keep this ticket open then. 

srl295

comment created time in 4 hours

delete branch srl295/cldr

delete branch : json14175

delete time in 4 hours

push eventunicode-org/cldr

Steven R. Loomis

commit sha 9400b7439cd24832a5ef3099c451fc11591666f7

CLDR-14175 update JSON converter to handle compoundUnitPattern1 (#736)

view details

push time in 4 hours

PR merged unicode-org/cldr

Reviewers
CLDR-14175 update JSON converter to handle compoundUnitPattern1

CLDR-14175

this was broken for, say, Amharic also. My first fix is this. From:

         "power2": {
           "compoundUnitPattern1": "{0}²",
           "compoundUnitPattern1": "{0}²",
           "compoundUnitPattern1": "{0}²"
         },
         "power2": {
           "compoundUnitPattern1": "{0}²",
           "compoundUnitPattern1-count-one": "{0}²",
           "compoundUnitPattern1-count-other": "{0}²"
         },

Now, for German a similar issue ensued. My fix outputs this:

          "power2": {
            "compoundUnitPattern1": "Quadrat{0}",
            "compoundUnitPattern1-count-one": "Quadrat{0}",
            "compoundUnitPattern1-count-one-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-count-one-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-count-one-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-count-other": "Quadrat{0}",
            "compoundUnitPattern1-count-other-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-count-other-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-count-other-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other-case-genitive": "Quadrat{0}"
          },
+4 -0

4 comments

1 changed file

srl295

pr closed time in 4 hours

push eventsrl295/cldr

Steven R. Loomis

commit sha f7f95379d0ca8b6bebc5959b892714371e552a9a

CLDR-11585 improve maven tests - You can run individual tests using testArgs properties. Example to run only one test from the main unit tests: mvn test '-Dorg.unicode.cldr.unittest.testArgs=-f:TestUntimedCounter -n -q' Example to run only one test from web: (could be combined w/ prior example) mvn test '-Dorg.unicode.cldr.unittest.web.testArgs=-f:TestMisc -n -q'

view details

push time in 5 hours

Pull request review commentunicode-org/cldr

CLDR-11585 improve maven tests

 					<artifactId>maven-surefire-plugin</artifactId> 					<version>${maven-surefire-plugin-version}</version> 					<configuration>-						<argLine>-DCLDR_ENVIRONMENT=UNITTEST -Djava.awt.headless=true  -DCLDR_DIR=../../ -Xmx6g -enableassertions</argLine>+					<systemPropertyVariables>

yes, i've fixed the indentation. It should be the same as Eclipse's now.

Agreed…

srl295

comment created time in 5 hours

PullRequestReviewEvent

Pull request review commentunicode-org/cldr

CLDR-11585 improve maven tests

 			<plugin> 				<artifactId>maven-surefire-plugin</artifactId> 				<configuration>-					<systemPropertyVariables>-						<CLDR_DIR>${project.basedir}/../../</CLDR_DIR>-						<CLDR_ENVIRONMENT>UNITTEST</CLDR_ENVIRONMENT>-						<java.awt.headless>true</java.awt.headless>+					<!-- <systemPropertyVariables>

I expect to need this, but will remove it for now.

I thought iot better to comment it out,. than to leave it in but unused.

srl295

comment created time in 5 hours

PullRequestReviewEvent

Pull request review commentunicode-org/cldr

CLDR-11585 improve maven tests

  import java.io.PrintWriter; +import org.unicode.cldr.util.TestShimUtils;+ import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals;+import static org.junit.jupiter.api.Assertions.assertArrayEquals;  /**  * a JUnit test that calls TestAll.  */ class TestShim {     @Test     public void TestAll() {-        String args[] = { "-n", "-q" }; // TODO: parameterize+        String args[] = TestShimUtils.getArgs(TestShim.class, "-n -q");         // regular main() will System.exit() which is not too friendly.         // call this instead.         int errCount = TestAll.runTests(args);         assertEquals(errCount, 0, "Test had errors");     }++    @Test+    public void TestTestShimUtilTest() {+        // Note: checks the system property corresponding to java.lang,+        // we expect this to be unset!+        String args[] = TestShimUtils.getArgs(java.lang.String.class, "-a -b -c");

Yes, i'll clarify. To test the mechanism, it assumes java.lang.testArgs is unset.

srl295

comment created time in 5 hours

PullRequestReviewEvent

Pull request review commentunicode-org/cldr

CLDR-11585 improve maven tests

 						</includes> 					</configuration> 				</plugin>-				<plugin>+				<!-- <plugin>

thanks for the recommend! I think with source control, the old version's just a click away. We may want some more parameters here someday.

srl295

comment created time in 5 hours

PullRequestReviewEvent

push eventsrl295/srl295.github.io

Steven R. Loomis

commit sha 7ae85b5ab93e839adf61fad6efc051871a2bff79

résumé bump

view details

push time in 6 hours

push eventsrl295/srl295.github.io

Steven R. Loomis

commit sha cc9d420150c630bc215b5717800cf3aa43482e70

résumé bump

view details

push time in 8 hours

push eventsrl295/srl295.github.io

Steven R. Loomis

commit sha 636c4ba60099fe9f042f2d83d446821228be4a31

Site updated: 2020-09-28 10:18:38

view details

push time in 8 hours

push eventsrl295/srl295.github.io

Steven R. Loomis

commit sha eebe15d86e5553e25cde3beafa60cd1bd6b6ae83

résumé bump

view details

push time in 8 hours

delete branch srl295/cldr

delete branch : pcm-13517

delete time in 8 hours

push eventunicode-org/cldr

Steven R. Loomis

commit sha 9ae97a3dd0a55ac02a72f4dba785a02fa27657d7

CLDR-13517 add Organization for Rodakych, LLC (Nigerian Pidgin) (#721)

view details

push time in 8 hours

PR merged unicode-org/cldr

Reviewers
CLDR-13517 add Organization for Rodakych, LLC (Nigerian Pidgin)

CLDR-13517

add org 'Rodakych' for pcm

+4 -0

0 comment

2 changed files

srl295

pr closed time in 8 hours

delete branch srl295/cldr

delete branch : ansibledocs-13771

delete time in 8 hours

push eventunicode-org/cldr

Steven R. Loomis

commit sha 4ec8de795687b4f176214ef5bc218a0395f5660c

CLDR-13771 update README and Vagrantfile (#716) - port forward nginx so we are testing the right server - document using the same deployment method used in production

view details

push time in 8 hours

PR merged unicode-org/cldr

CLDR-13771 update README and Vagrantfile

CLDR-13771

  • port forward nginx so we are testing the right server
  • document using the same deployment method used in production
+24 -12

0 comment

3 changed files

srl295

pr closed time in 8 hours

delete branch srl295/cldr

delete branch : fix-licenses-14143

delete time in 8 hours

push eventunicode-org/cldr

Steven R. Loomis

commit sha 14930e55559c9ece8b595e0d2ec4835959fc6fc2

CLDR-14143 update npm packaging (#684) Ldml2JsonConverter was writing an obsolete 'licenses' field in the package.json for npm. Fix it, and also use the correct SPDX (Unicode-DFS-2016)

view details

push time in 8 hours

PR merged unicode-org/cldr

Reviewers
CLDR-14143 update npm packaging

CLDR-14143

Ldml2JsonConverter was writing an obsolete 'licenses' field in the package.json for npm. Fix it, and also use the correct SPDX (Unicode-DFS-2016)

+1 -6

1 comment

1 changed file

srl295

pr closed time in 8 hours

PullRequestReviewEvent
PullRequestReviewEvent

create barnchsrl295/icu-demos

branch : esmsg

created branch time in 2 days

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha b57433df03bee16034d968a98ebf7b71a205ff60

fix qr

view details

push time in 2 days

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha 9241a1ec561c132f96390117d5cbe85e287ce166

ship it

view details

push time in 2 days

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha b72828c0b7f8dfbb6bee69f847a1177ac95deca7

backlink

view details

push time in 2 days

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha b43417a1b60feb00b5eaed26119343b37af22c33

checkpoint

view details

push time in 2 days

created tagunicode-org/icu-demos

tagiuc44

sample apps for ICU (formerly icuapps)

created time in 2 days

release unicode-org/icu-demos

iuc44

released time in 2 days

push eventunicode-org/icu-docker

Steven R. Loomis

commit sha dd38b2bbff1fa0c5bbb2e6d1af4df49c41e07977

sort out generated binaries into proper names may not work for all versions, etc. But it is a start. Fixes: https://github.com/unicode-org/icu-docker/issues/1

view details

Steven R. Loomis

commit sha 012aeff4d175772ca950b7b0c60afcf04ebfc3be

Merge pull request #17 from unicode-org/sort-out-dist sort out generated binaries into proper names

view details

Steven R. Loomis

commit sha 0eb36e7281dc3f6cb1f38ba434b71839517b53c5

docker: fix ubuntu Dockerfile .. so that it doesn't stall waiting for timezone selection (!) - also add git-lfs

view details

Steven R. Loomis

commit sha 819aa7b25dfbc50b96757ce34b3dd7a5ecc534c6

setup for building under coverity - also ignore tmp directories in VSCode

view details

Steven R. Loomis

commit sha 1d8b466876d538cc6878719ee08064424163926e

add icu4j

view details

Steven R. Loomis

commit sha 51902919e22c9f4feaceda69dc376cc84ac1e031

icu4j + coverity!

view details

Steven R. Loomis

commit sha 9a562f8de59b6c988cc23c0fb48f48dce160369d

fixup! icu4j + coverity!

view details

Steven R. Loomis

commit sha 743bc13c2368d946e4d8750ceedf646418bbe846

add maven and gpg

view details

push time in 3 days

push eventsrl295/srl295-slides

Steven R. Loomis

commit sha 883fecb9020acd3a6f83b47f7eebbe0471d2cc51

upd

view details

push time in 3 days

create barnchsrl295/srl295-slides

branch : 2020-10-14-iuc44-icuwork-s1t3

created branch time in 3 days

pull request commentunicode-org/icu-docker

docker: fix ubuntu Dockerfile

@markusicu thanks. this will simplify some instructions.

srl295

comment created time in 3 days

delete branch unicode-org/icu-docker

delete branch : fix-docker

delete time in 3 days

push eventunicode-org/icu-docker

Steven R. Loomis

commit sha 0eb36e7281dc3f6cb1f38ba434b71839517b53c5

docker: fix ubuntu Dockerfile .. so that it doesn't stall waiting for timezone selection (!) - also add git-lfs

view details

push time in 3 days

PR merged unicode-org/icu-docker

Reviewers
docker: fix ubuntu Dockerfile

.. so that it doesn't stall waiting for timezone selection (!)

need this for iuc44

+4 -0

0 comment

2 changed files

srl295

pr closed time in 3 days

push eventunicode-org/icu-docker

Steven R. Loomis

commit sha 95f2cbd961ece96f57d20da91977212ac298c623

docker: fix ubuntu Dockerfile .. so that it doesn't stall waiting for timezone selection (!) - also add git-lfs

view details

push time in 3 days

PR opened unicode-org/icu-docker

Reviewers
docker: fix ubuntu Dockerfile

.. so that it doesn't stall waiting for timezone selection (!)

need this for iuc44

+2 -0

0 comment

2 changed files

pr created time in 3 days

create barnchunicode-org/icu-docker

branch : fix-docker

created branch time in 3 days

PR opened unicode-org/cldr

Reviewers
CLDR-11585 tests

you can now run specific subtests with:

mvn test '-Dorg.unicode.cldr.unittest.web.testArgs=-f:TestMisc -n -q' '-Dorg.unicode.cldr.unittest.testArgs=-f:TestUntimedCounter -n -q' 

I was unable to get code coverage to work here, but it's just a config file change away.

+44 -15

0 comment

6 changed files

pr created time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 1aadc44eb0ad97502188cb32cd88db538db16822

CLDR-11585 improve maven tests - You can run individual tests using testArgs properties. Example to run only one test from web and utils: mvn test '-Dorg.unicode.cldr.unittest.web.testArgs=-f:TestMisc -n -q' '-Dorg.unicode.cldr.unittest.testArgs=-f:TestUntimedCounter -n -q'

view details

push time in 3 days

create barnchsrl295/cldr

branch : test11585

created branch time in 3 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 private synchronized void init() {         // The git version of the cldr.jar file embedded in cldr-apps.         survprops.put("CLDR_UTILITIES_HASH", getGitHashForSlug("CLDR-Tools"));         // The git version of the CLDR_DIR currently in use.-        survprops.put("CLDR_DATA_HASH", getGitHashForDir(survprops.getProperty("CLDR_DIR", null)));+        survprops.put("CLDR_DATA_HASH", CldrUtility.getGitHashForDir(survprops.getProperty("CLDR_DIR", null)));

There's no comnon init() for CLDRConfig, but if there were, this line could move there.

btangmu

comment created time in 3 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 protected Environment getDefaultEnvironment() {     }      CLDRConfigImpl() {-        // TODO remove this after some time- just warn people about the old message

:+1: "some time" has passed, whatever it was :)

btangmu

comment created time in 3 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 public void TestIsCoverageOrganization() {     }      public void TestGitHash() {-        final String appsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Apps");-        assertNotNull("getting CLDR-Apps version", appsVersion);-        /*-         * TODO: fail if CLDRURLS.UNKNOWN_REVISION.equals(appsVersion))-         * and likewise for toolsVersion-         */-        // if (CLDRURLS.UNKNOWN_REVISION.equals(appsVersion)) {-        //    errln("❌ appsVersion = UNKNOWN_REVISION: " + appsVersion);-        // }--        final String toolsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Tools");-        assertNotNull("getting CLDR-Tools version", toolsVersion);--        /*-         * TODO: add a regression test here for CLDR_DATA_HASH-         * Reference: https://unicode-org.atlassian.net/browse/CLDR-13582-         */-        // final String hash = CLDRConfig.getInstance().getProperty("CLDR_DATA_HASH");-        // assertNotNull("getting CLDR_DATA_HASH", hash);-        // if (hash != null && !hash.matches("[0-9a-f]+")) {-        //    errln("❌ CLDR_DATA_HASH is not hex: " + hash);-        // }+        final String hash = CldrUtility.getCldrBaseDirHash();+        assertNotNull("getCldrBaseDirHash", hash);+        if (hash != null) {+            if (!hash.matches("[0-9a-f]+")) {+                errln("❌ getCldrBaseDirHash is not hex: " + hash);+            } else if (hash.length() < 8) {+                errln("❌ getCldrBaseDirHash is shorter than 8 chars: " + hash);+            }+        }+        final String strings[] = {"CLDR-Apps", "CLDR-Tools"};+        for (String s : strings) {+            final String version = CLDRConfigImpl.getGitHashForSlug(s);+            assertNotNull("getting " + s + " version", version);+            /*+             * TODO: fail if CLDRURLS.UNKNOWN_REVISION.equals(version).+             * Currently they do equal CLDRURLS.UNKNOWN_REVISION, since SurveyMain.init isn't called for TestAll.

So, in a test environment, you definitely don't have cldr-apps.war and thus no manifest to read "CLDR-Apps" from. You also might not have cldr*.jar for its tools manifest, if the tests are run in eclipse let's say. So this might be a warning, but a challenge to get from the test environment.

I don't know if you can use a warfile as if it were a jar on the classpath? If so, we could have a post build step, something like: java -DCLDR_APPS_VERSION_TEST -classpath …:…:cldr*.jar:cldr-apps.war TestAll or something like that?

btangmu

comment created time in 3 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 public void TestIsCoverageOrganization() {     }      public void TestGitHash() {-        final String appsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Apps");-        assertNotNull("getting CLDR-Apps version", appsVersion);-        /*-         * TODO: fail if CLDRURLS.UNKNOWN_REVISION.equals(appsVersion))-         * and likewise for toolsVersion-         */-        // if (CLDRURLS.UNKNOWN_REVISION.equals(appsVersion)) {-        //    errln("❌ appsVersion = UNKNOWN_REVISION: " + appsVersion);-        // }--        final String toolsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Tools");-        assertNotNull("getting CLDR-Tools version", toolsVersion);--        /*-         * TODO: add a regression test here for CLDR_DATA_HASH-         * Reference: https://unicode-org.atlassian.net/browse/CLDR-13582-         */-        // final String hash = CLDRConfig.getInstance().getProperty("CLDR_DATA_HASH");-        // assertNotNull("getting CLDR_DATA_HASH", hash);-        // if (hash != null && !hash.matches("[0-9a-f]+")) {-        //    errln("❌ CLDR_DATA_HASH is not hex: " + hash);-        // }+        final String hash = CldrUtility.getCldrBaseDirHash();+        assertNotNull("getCldrBaseDirHash", hash);+        if (hash != null) {

minor: it's already been asserted as not-null on the prior line, so this is an unnecessary ifdef.

btangmu

comment created time in 3 days

Pull request review commentunicode-org/cldr

CLDR-13582 Make sure browser uses most recent JavaScript files for ST

 public void TestIsCoverageOrganization() {     }      public void TestGitHash() {-        final String appsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Apps");-        assertNotNull("getting CLDR-Apps version", appsVersion);-        /*-         * TODO: fail if CLDRURLS.UNKNOWN_REVISION.equals(appsVersion))-         * and likewise for toolsVersion-         */-        // if (CLDRURLS.UNKNOWN_REVISION.equals(appsVersion)) {-        //    errln("❌ appsVersion = UNKNOWN_REVISION: " + appsVersion);-        // }--        final String toolsVersion = CLDRConfigImpl.getGitHashForSlug("CLDR-Tools");-        assertNotNull("getting CLDR-Tools version", toolsVersion);--        /*-         * TODO: add a regression test here for CLDR_DATA_HASH-         * Reference: https://unicode-org.atlassian.net/browse/CLDR-13582-         */-        // final String hash = CLDRConfig.getInstance().getProperty("CLDR_DATA_HASH");-        // assertNotNull("getting CLDR_DATA_HASH", hash);-        // if (hash != null && !hash.matches("[0-9a-f]+")) {-        //    errln("❌ CLDR_DATA_HASH is not hex: " + hash);-        // }+        final String hash = CldrUtility.getCldrBaseDirHash();+        assertNotNull("getCldrBaseDirHash", hash);+        if (hash != null) {+            if (!hash.matches("[0-9a-f]+")) {+                errln("❌ getCldrBaseDirHash is not hex: " + hash);

it could be 'unknown' if git is missing or if the code was compiled from a source tarball?maybe this should be a warning?

btangmu

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch srl295/cldr

delete branch : cache11585

delete time in 4 days

push eventunicode-org/cldr

Steven R. Loomis

commit sha 880b4957a8b843fb1a36353bc4f7ca362ea6764e

CLDR-11585 cache maven dependencies (#738) - cache maven dependencies for build speedup and reliability - do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (#729) )

view details

push time in 4 days

PR merged unicode-org/cldr

Reviewers
CLDR-11585 cache maven dependencies

the maven build is timing out sometimes… let's see if caching will help.

+12 -10

6 comments

3 changed files

srl295

pr closed time in 4 days

push eventunicode-org/icu-demos

Steven R. Loomis

commit sha a90b5bfd83bfd6dbd4fbcc7a4be9c64c04bbfbed

Iuc43 (#14) * ICU-13668 Rebase of iuc42 branch onto master - the "iuc42" branch b14a81fec744b553294d5d3d93c34d41dbfc19e8 is in this commit from last year. * ICU-13668 iuc43 updates for iuc43 - automated testing of C demos - delete old "icufacts" (from iuc37), add top level instruction * ICU-13668 iuc43 test J iucsamples too! * ICU-13668 iuc43 use travis mvn instead of docker * fixup! ICU-13668 iuc43 use travis mvn instead of docker * fixup! ICU-13668 iuc43 test J iucsamples too! * Update readme.txt * Match https://github.com/srl295/srl295-slides/commit/bc71356b44117386ee1be95e225cc78341cf0fe5 * iuc43 fixes - use '-e utf-8' to not default the genrb build - add an error for ICU4C<62.x API

view details

push time in 4 days

PR merged unicode-org/icu-demos

Iuc43

ICU-13668 - merge demos as presented at iuc43 into master

+757 -958

0 comment

82 changed files

srl295

pr closed time in 4 days

pull request commentunicode-org/icu

ICU-21269 ParagraphLayout complexTable: init & access based on actual values

scriptCodeCount is written by ScriptIDModuleWriter.java which should be run as a BRS task

markusicu

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentunicode-org/cldr

CLDR-11585 cache maven dependencies

 jobs:       with:         lfs: false # not needed for this job, as we don’t currently do a Java build     - name: Lint Ansible Playbook+      # the hash here is a specific version of that repo, since there is not a later commit.

@btangmu from your comment on #729

srl295

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventsrl295/cldr

Steven R. Loomis

commit sha d9f9c0970e8caf7c579ace92fc328c3df3915ce1

CLDR-11585 cache maven dependencies - cache maven dependencies for build speedup and reliability - do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (#729) )

view details

push time in 4 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 5f944ba2a176ba43e2ff4bf3d6ef43d8dcc19d70

CLDR-11585 cache maven dependencies - do not specify the maven central URL but let it default - update some action versions - do not run tests twice! - also, add a comment explaining a line in the ansible-lint.yml (from CLDR-13771 workaround ansible-lint failing (#729) )

view details

push time in 4 days

pull request commentunicode-org/cldr

CLDR-11585 cache maven dependencies

Also:

  • do not specify the maven central URL but let it default
  • update some action versions
srl295

comment created time in 4 days

pull request commentunicode-org/cldr

CLDR-11585 cache maven dependencies

results:

  • maven tests only run once, not once at build and once at test (oops)
  • cache+build = 26 seconds, where the maven build took 43 seconds before tests were added (that was fewer source files being compiled, so the savings are probably even greater)
  • More significantly, those 20 seconds are network traffic, which has been timing out recently.
srl295

comment created time in 4 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 0e5f397ccf2c03f67be8cb5b426b2fd887679607

CLDR-11585 cache maven dependencies - do not specify the maven central URL but let it default - update some action versions - do not run tests twice!

view details

push time in 4 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 8ab08e46a5a0d2a322dbf26c2291412d6ea1addc

CLDR-11585 cache maven dependencies - also, do not specify the maven central URL but let it default - also, update some action versions

view details

push time in 4 days

PR opened unicode-org/cldr

Reviewers
CLDR-11585 cache maven dependencies

the maven build is timing out sometimes… let's see if caching will help.

+7 -0

0 comment

1 changed file

pr created time in 4 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 28b93a774327ca9479b0128117d1be396f6f9cfd

CLDR-11585 cache maven dependencies

view details

push time in 4 days

create barnchsrl295/cldr

branch : cache11585

created branch time in 4 days

startedelixir-cldr/cldr_units

started time in 4 days

pull request commentunicode-org/cldr

CLDR-14175 update JSON converter to handle compoundUnitPattern1

compoundUnitPattern1-gender-feminine-count-other-case-accusative is kind of a mouthful. But, it keeps it consistent with other unit related stuff.

srl295

comment created time in 4 days

pull request commentunicode-org/cldr

CLDR-14175 update JSON converter to handle compoundUnitPattern1

FYI @kipcole9

srl295

comment created time in 4 days

PR opened unicode-org/cldr

Reviewers
CLDR-14175 update JSON converter to handle compoundUnitPattern1

CLDR-14175

this was broken for, say, Amharic also. My first fix is this. From:

         "power2": {
           "compoundUnitPattern1": "{0}²",
           "compoundUnitPattern1": "{0}²",
           "compoundUnitPattern1": "{0}²"
         },
         "power2": {
           "compoundUnitPattern1": "{0}²",
           "compoundUnitPattern1-count-one": "{0}²",
           "compoundUnitPattern1-count-other": "{0}²"
         },

Now, for German a similar issue ensued. My fix outputs this:

          "power2": {
            "compoundUnitPattern1": "Quadrat{0}",
            "compoundUnitPattern1-count-one": "Quadrat{0}",
            "compoundUnitPattern1-count-one-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-count-one-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-count-one-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-one-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-one-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-count-other": "Quadrat{0}",
            "compoundUnitPattern1-count-other-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-count-other-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-count-other-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-feminine-count-other-case-genitive": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other-case-accusative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other-case-dative": "Quadrat{0}",
            "compoundUnitPattern1-gender-masculine-count-other-case-genitive": "Quadrat{0}"
          },
+4 -0

0 comment

1 changed file

pr created time in 4 days

create barnchsrl295/cldr

branch : json14175

created branch time in 4 days

pull request commentunicode-org/cldr

CLDR-14116 Include TestLanguageGroup in TestAll, improve infra

Question, can we change the author in github? That way I'll see it on my plate.

You are now the only owner of the PR. The fix-grouptest branch is in the head fork (unicode-org) and so you can push any commits you want to it.

srl295

comment created time in 4 days

delete branch srl295/cldr

delete branch : fixpom-11585

delete time in 4 days

push eventunicode-org/cldr

Steven R. Loomis

commit sha 6adc82b6b6116bb67e046ec129adb66f4aa6aac4

CLDR-11585 fix pom.xml, add tests (#734) - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 4 days

PR merged unicode-org/cldr

Reviewers
CLDR-11585 Maven: Add tests, simplify pom setup

CLDR-11585

after this, then https://sites.google.com/site/cldr/development/maven instructions should work to use maven (from the command line, at least).


Rescoping this one to also include adding (via a shim) all tests (but not consolecheck).

+106 -19

9 comments

10 changed files

srl295

pr closed time in 4 days

issue openedunicode-org/unicodetools

util: 413 with very long input

I was trying to paste the CLDR zh exemplar set into the UnicodeSet tool, and got a 413. 4k of text expands to >8k of URI content.

The UnicodeSet submit button should detect that the input is above some threshhold, and submit the data as a POST. You won't be able to bookmark the link (as with other use of the tool), but at least the intended operation will actually work.

created time in 4 days

PullRequestReviewEvent

issue commentnodejs/i18n

Translate the main .md files of this repository into other languages.

@JoseJPR

doubts - English

The list in the i18n readme could have the language link in the native language also ("Spanish-español"). But I think the developer can navigate that far if they've already found the i18n repo.

1.- I don't see the need to add the last directory "nodejs/nodejs-es/tree/master/ i18n-guide/es", it would leave it like this "nodejs/nodejs-es/tree/master/i18n-guide". In my opinion it is redundant as it already has "nodejs-es" in the path.

A language group might be responsible for more than one language dialect/orthography. Maybe simplified and traditional Chinese are in the same group? I think the extra /es is worthwhile

JoseJPR

comment created time in 4 days

pull request commentunicode-org/icu

Wasm32 Architeture Port

@devsnek was also interested in this.

+1 for @devsnek

mabels

comment created time in 5 days

issue commenttc39/ecma402

DateTimeFormat: consider adding more timezone display options

perhaps id / locode should be 'getters' rather than format option in this case.

What does this mean (of be a getters)? could you show me some example JS code to express what you wish the API would do for that?

I'm not sure of the right API location. Maybe it would be part of resolvedOptions even, since it's not wall-time specific. Roughly:

const d = new Date(); // date for the zone info
const {locode, id} = fmt.zoneInfoFor(d);
=>  locode: 'uslax', id: 'America/Los_Angeles`

the date is needed because of historcial zones

jungshik

comment created time in 5 days

pull request commentunicode-org/cldr

CLDR-11585 fix pom.xml, also add tests

Oops. Need to exclude TestShim from ant!

fixed

srl295

comment created time in 5 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 03244bdea16aafd6435156c791daf338f750596e

CLDR-11585 fix pom.xml, add tests - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 5 days

pull request commentunicode-org/cldr

CLDR-11585 fix pom.xml, also add tests

Oops. Need to exclude TestShim from ant!

srl295

comment created time in 5 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 2a6245f7dac5015588d10a124ee7198d26277447

CLDR-11585 fix pom.xml, add tests - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 5 days

pull request commentunicode-org/cldr

CLDR-11585 fix pom.xml, also add tests

I'll do a more complete test integration, this simply sublaunches the entire CLDR test suite as a single junit test. It's also not configurable.

But, while 'ant' is still in the picture, i wanted to keep it simple.

srl295

comment created time in 5 days

push eventsrl295/cldr

Mark Davis

commit sha a063e7f15487b638ce2f4b1b7a0ca6126a940141

CLDR-14194 define the skeleton in unitPreferences more precisely (#728)

view details

Steven R. Loomis

commit sha 1fb7d3b36492cde5dd6cd7b740a859470cdb81b8

CLDR-13771 workaround ansible-lint failing (#729) - see https://github.com/ansible-collections/community.kubernetes/issues/135#issuecomment-661189940 - workaround by not setting a version

view details

Steven R. Loomis

commit sha df0c987cea8fc379c32e6ab8288d7b6a724d97bc

CLDR-11585 fix pom.xml, add tests - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 5 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 01ffc642fd40d9e4d71afd8d3570c7166c130b00

CLDR-11585 fix pom.xml, add tests - fix pom.xml repository settings so that settings can be more minimal - basic test runner shim for web / java - build tests where they are - currently test code is included in cldr-apps.war (TODO) - currently, cldr-apps are tested against Derby (regression of CLDR-8383)

view details

push time in 5 days

more