profile
viewpoint
Steven R. Loomis srl295 @IBM San José, CA, USA https://ibm.biz/srloomis @IBM er, work on Globalization Pipeline on @IBM-Cloud and also @unicode-org stuff

srl295/btest402 7

Basic test of ES402 Intl object in Javascript.

srl295/es-unicode-properties 4

Unicode properties in ES

DTownSMR/kibana-i18n 1

:bar_chart: Kibana analytics and search dashboard for Elasticsearch

IBM-Cloud/gp-atom-package 1

Atom plugin for GP

IBM-Cloud/gp-js-flatten 1

Un/Flattener based on jsonpath

IBM-Cloud/gp-vscode-plugin 1

VS Code plugin for Globalization Pipeline

srl295/.profile.d 1

*My* configuration files. Also a way to learn about git.

srl295/fa-docker-compose 1

FrontAccounting for Docker Compose

behnam/unicode-idna 0

Unicode IDNA Compatibility Processing Data

IBM-Cloud/gp-nodejs-perftest 0

Performance test for GP via node sdk

issue commentopenjs-foundation/standards

Joining the Unicode Consortium

Quick update - There has been support for this request expressed from a couple of board members and no objections. There is a request for legal to review the Unicode Consortium bylaws so I will follow up with that and if no issues are raised by the legal team, I imagine this will be approved to move forward soon.

You can use the contact form https://home.unicode.org/connect/getting-involved/contact-unicode/ to connect to Unicode or write me and I can forward a message on.

eemeli

comment created time in 13 hours

pull request commentunicode-org/cldr

CLDR-13212 Torwali(trw)

@Jalaluddin5641 I have approved this and it will be merged as soon as the tree is open for CLDR 38. Thanks! I will contact you offline so you will be all set to contribute the rest of the data when the Survey Tool opens.

Jalaluddin5641

comment created time in a day

pull request commentunicode-org/cldr

CLDR-13212 Torwali(trw)

@Jalaluddin5641 I've identified someone who helped with torwali encoding who will help review this

I have heard back from an expert that your proposed exemplar is correct. Thanks!

Jalaluddin5641

comment created time in a day

pull request commentunicode-org/cldr

CLDR-13596 BRS Task A03 - Change to -z FINAL_TESTING

Probably should fix aspart of this PR (again a good candidate for multiple PRs)

JCEmmons

comment created time in a day

pull request commentunicode-org/cldr

Update lrc.xml

@mogoei hi, please make sure to file a CLDR bug at https://unicode-org.atlassian.net/

mogoei

comment created time in 3 days

pull request commentunicode-org/cldr

CLDR-11438 Move Adlam out of Seed, Add Collation

Thanks.

El El sáb, feb. 15, 2020 a la(s) 10:13 p. m., pedberg-icu < notifications@github.com> escribió:

Merged #327 https://github.com/unicode-org/cldr/pull/327 into master.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/327?email_source=notifications&email_token=AAGQZM5RXP45RWKST3NRICTRDDKO3A5CNFSM4KV6VUZ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWVDUI2I#event-3041346665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGQZM7JUN75BPE2QWC2WNTRDDKO3ANCNFSM4KV6VUZQ .

srl295

comment created time in 3 days

pull request commentunicode-org/cldr

CLDR-13439 Add Il-Kunsill Nazzjonali tal-Ilsien Malti

Thanks for fixing and merging

srl295

comment created time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 1217e0f95a7392270f015224bae5b24563839d14

CLDR-11438 move ff_Adlm into main - Add ff_Adlm-using regions into TestLocalCurrency..regionsWithTwoCurrencySymbols

view details

Steven R. Loomis

commit sha 94654d5f9d6d538ae76aae06aa67578da33c2e68

CLDR-11438 Add collation for ff_Adlm

view details

push time in 3 days

pull request commentunicode-org/cldr

CLDR-11438 Move Adlam out of Seed, Add Collation

fixed the FileId problem, working on currency

srl295

comment created time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha 6c652f0930617876c13f1171de7f2605aab9fb7b

CLDR-11438 Add collation for ff_Adlm

view details

push time in 3 days

push eventsrl295/cldr

Steven R. Loomis

commit sha d1e17eb2e775d1ecf75b957cb50f9344e8561aae

CLDR-11438 move ff_Adlm into main

view details

Steven R. Loomis

commit sha 4a436dba3a658a79667be4f9bc26c577d7664d83

CLDR-11438 Adlam collation draft

view details

push time in 3 days

PR opened unicode-org/cldr

Reviewers
CLDR-11438 Move Adlam out of Seed, Add Collation

[CLDR-11438]

  • [x] Issue filed: https://unicode-org.atlassian.net/browse/CLDR-_____
  • [x] Updated PR title and link in previous line to include Issue number

Allowing 2 commits so that the move-from-seed can be separate from the collation rules.

ALLOW_MANY_COMMITS=true

+193 -0

0 comment

15 changed files

pr created time in 3 days

create barnchsrl295/cldr

branch : adlam11438

created branch time in 3 days

issue commentnodejs/TSC

Sorting out Intl vs I18n labels, teams, and repos

  • Could the Intl team be renamed @nodejs/i18n/api or some such?

can I rename the label to i18n Yes, good idea.

sam-github

comment created time in 4 days

issue commentnodejs/TSC

Sorting out Intl vs I18n labels, teams, and repos

For reference: https://github.com/nodejs/TSC/issues/353

sam-github

comment created time in 4 days

issue commentnodejs/i18n

Update the CONTRIBUTING.md & GETTING_STARTED.md guides

modify https://github.com/nodejs/i18n/issues/210 per today;'s discussion

obensource

comment created time in 4 days

delete branch IBM-Cloud/gp-js-cli

delete branch : dependabot/npm_and_yarn/handlebars-4.5.3

delete time in 6 days

push eventIBM-Cloud/gp-js-cli

dependabot[bot]

commit sha c490aa1dd28c22e705acb3e4a8cf707fdf4998e5

build(deps): bump handlebars from 4.1.2 to 4.5.3 Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

Steven R. Loomis

commit sha 51ea6d933e2a91c30b6b829f2ef725bf4d66ab2e

Merge pull request #7 from IBM-Cloud/dependabot/npm_and_yarn/handlebars-4.5.3 build(deps): bump handlebars from 4.1.2 to 4.5.3

view details

push time in 6 days

PR merged IBM-Cloud/gp-js-cli

build(deps): bump handlebars from 4.1.2 to 4.5.3 dependencies

Bumps handlebars from 4.1.2 to 4.5.3. <details> <summary>Changelog</summary>

Sourced from handlebars's changelog.

v4.5.3 - November 18th, 2019

Bugfixes:

  • fix: add "no-prototype-builtins" eslint-rule and fix all occurences - f7f05d7
  • fix: add more properties required to be enumerable - 1988878

Chores / Build:

  • fix: use !== 0 instead of != 0 - c02b05f
  • add chai and dirty-chai and sinon, for cleaner test-assertions and spies, deprecate old assertion-methods - 93e284e, 886ba86, 0817dad, 93516a0

Security:

  • The properties __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ have been added to the list of "properties that must be enumerable". If a property by that name is found and not enumerable on its parent, it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper. This will prevent new Remote-Code-Execution exploits that have been published recently.

Compatibility notes:

  • Due to the security-fixes. The semantics of the templates using __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ in the respect that those expression now return undefined rather than their actual value from the proto.
  • The semantics have not changed in cases where the properties are enumerable, as in:
{
  __proto__: 'some string'
}
  • The change may be breaking in that respect, but we still only increase the patch-version, because the incompatible use-cases are not intended, undocumented and far less important than fixing Remote-Code-Execution exploits on existing systems.

Commits

v4.5.2 - November 13th, 2019

Bugfixes

  • fix: use String(field) in lookup when checking for "constructor" - d541378
  • test: add fluent API for testing Handlebars - c2ac79c

Compatibility notes:

  • no incompatibility are to be expected </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • c819c8b v4.5.3
  • 827c9d0 Update release notes
  • f7f05d7 fix: add "no-prototype-builtins" eslint-rule and fix all occurences
  • 1988878 fix: add more properties required to be enumerable
  • 886ba86 test/chore: add chai/expect and sinon to "runtime"-environment
  • 0817dad test: add sinon as global variable to eslint in the specs
  • 93516a0 test: add sinon.js for spies, deprecate current assertions
  • 93e284e chore: add chai and dirty-chai for better test assertions
  • c02b05f fix: use !== 0 instead of != 0
  • 8de121d v4.5.2
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 6 days

delete branch IBM-Cloud/gp-js-cli

delete branch : dependabot/npm_and_yarn/eslint-utils-1.4.2

delete time in 6 days

PR merged IBM-Cloud/gp-js-cli

build(deps): bump eslint-utils from 1.3.1 to 1.4.2 dependencies

Bumps eslint-utils from 1.3.1 to 1.4.2. <details> <summary>Commits</summary>

  • 4e1bc07 1.4.2
  • e4cb014 🐛 add null test
  • 230a4e2 1.4.1
  • 08158db 🐛 fix getStaticValue security issue
  • 587cca2 🐛 fix getStringIfConstant to handle literals correctly
  • c119e83 🐛 fix getStaticValue to handle bigint correctly
  • 531b16f 🔖 1.4.0
  • 276303d ⚒ upgrade rollup
  • cb518c7 🐛 fix hasSideEffect false negative
  • aac472e 🐛 fix isParenthesized had false positive on ImportExpression (fixes #1)
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+7 -4

0 comment

1 changed file

dependabot[bot]

pr closed time in 6 days

PR opened IBM-Cloud/gp-js-cli

npm audit fix
+159 -105

0 comment

2 changed files

pr created time in 7 days

create barnchIBM-Cloud/gp-js-cli

branch : audit-update

created branch time in 7 days

issue openedIBM-Cloud/gp-js-client

use iam-token-manager

https://www.npmjs.com/package/@ibm-functions/iam-token-manager instead of homegrown #150

created time in 8 days

Pull request review commentunicode-org/cldr

CLDR-13499 fix remaining same as code bugs; fix related problems in C…

 public static void main(String[] args) {             CLDRFile diffFile = null;              if (checkCldr != null) {+                if (locale.equals("eo")) {

debug code… would be good to clean up in a future PR? (By the way, you should be able to use conditional breakpoints to stop iff locale.equals("eo") ..)

macchiati

comment created time in 11 days

Pull request review commentunicode-org/icu

ICU-20088 userguide: boundaryanalysis

 Starting with an example,     $word_char+;     $word_char $word_joiner $word_char; -These rules will match `"abc"`, `"hello_world"`, `"hi-there"`,-`"a-bunch_of-joiners-here"`.+These rules will match "`abc`", "`hello_world`", `"hi-there"`,+"`a-bunch_of-joiners-here`". -They will not match `"-abc"`, `"multiple__joiners"`, `"tail-"`+They will not match "`-abc`", "`multiple__joiners`", "`tail-`"  A full match is composed of pieces or submatches, possibly from different rules, with adjacent submatches linked by at least one overlapping character. -In the example below, matching "hello_world",+In the example below, matching "`hello_world`", -'^' shows matches of the first rule, word_char++* '`1`' shows matches of the first rule, `word_char+` -'!' shows matches of the second rule, $word_char $word_joiner $word_char+* '`2`' shows matches of the second rule, `$word_char $word_joiner $word_char` -`hello_world`-`^^^^^ ^^^^^`-` !!!`+    hello_world+    11111 11111

I changed it from ^ / ! to 1 / 2

srl295

comment created time in 13 days

push eventsrl295/icu

Steven R. Loomis

commit sha 56bcb65f1f73cd2fe3b4940fd8d2fe5962448258

ICU-20088 userguide: boundary - review notes

view details

push time in 13 days

Pull request review commentunicode-org/icu

ICU-20088 userguide: boundaryanalysis

 boundary rules.  **In C++:** +```c++ void listWordBoundaries(const UnicodeString& s) {-UErrorCode status = U_ZERO_ERROR;-BreakIterator\* bi = BreakIterator::createWordInstance(Locale::getUS(), status);-bi->setText(s);-int32_t p = bi->first();-while (p != BreakIterator::DONE) {-printf("Boundary at position %d\\n", p);-p = bi->next();-}-delete bi;+    UErrorCode status = U_ZERO_ERROR;+    BreakIterator* bi = BreakIterator::createWordInstance(Locale::getUS(), status);+    bi->setText(s);+    int32_t p = bi->first();+    while (p != BreakIterator::DONE) {+        printf("Boundary at position %d\n", p);+        p = bi->next();+    }+    delete bi; }+```  **In C:** -void listWordBoundaries(const UChar\* s,-int32_t len) {-UBreakIterator\* bi;-int32_t p;-UErrorCode err = U_ZERO_ERROR;-bi = ubrk_open(UBRK_WORD, 0, s, len, &err);-if (U_FAILURE(err)) return;-p = ubrk_first(bi);-while (p != UBRK_DONE) {-printf("Boundary at position %d\\n", p);-p = ubrk_next(bi);-}-ubrk_close(bi);+```c+void listWordBoundaries(const UChar* s, int32_t len) {+    UBreakIterator* bi;+    int32_t p;+    UErrorCode err = U_ZERO_ERROR;+    bi = ubrk_open(UBRK_WORD, 0, s, len, &err);+    if (U_FAILURE(err)) return;+    p = ubrk_first(bi);+    while (p != UBRK_DONE) {+        printf("Boundary at position %d\n", p);+        p = ubrk_next(bi);+    }+    ubrk_close(bi); } 

thanks. Fixed in 126bb5d941ce11105dc2068253373409ab0fa9a4

srl295

comment created time in 13 days

push eventsrl295/icu

Steven R. Loomis

commit sha 1e9063505ede81afa92e35e8f15b71a58dde31f0

ICU-20088 userguide: boundary - fix mdlint errors

view details

Steven R. Loomis

commit sha 126bb5d941ce11105dc2068253373409ab0fa9a4

fixup! ICU-20088 userguide: boundary

view details

push time in 13 days

push eventsrl295/icu

Steven R. Loomis

commit sha 70eb74a0f1059fc60d697632bb12f485affa69fa

ICU-20088 boundaryanalysis/break-rules.md * Whew!

view details

push time in 13 days

push eventsrl295/icu

Steven R. Loomis

commit sha 9d469fffc62e1f2c1eba2d86f97a05df80f53f2d

ICU-20088 boundaryanalysis/break-rules.md * Whew!

view details

push time in 13 days

push eventsrl295/icu

Steven R. Loomis

commit sha baccf7923625790a6ff564ac0c054d2d0b4dc771

ICU-20088 boundaryanalysis: initial cut

view details

push time in 13 days

PR opened unicode-org/icu

boundaryanalysis: initial cut

<!-- Thank you for your pull request. Please see http://site.icu-project.org/processes/contribute for general information on contributing to ICU.

You will be automatically asked to sign the contributors license before the PR is accepted.

  • sign: https://cla-assistant.io/unicode-org/icu
  • license: http://www.unicode.org/copyright.html#License -->
Checklist
  • [ ] Issue filed: https://unicode-org.atlassian.net/browse/ICU-_____
  • [ ] Updated PR title and link in previous line to include Issue number
  • [ ] Issue accepted
  • [ ] Tests included
  • [ ] Documentation is changed or added
+248 -219

0 comment

1 changed file

pr created time in 13 days

create barnchsrl295/icu

branch : userguide-migration

created branch time in 13 days

pull request commentunicode-org/cldr

CLDR-13561 XML for version 37

This should not have been merged with failing tests.

btangmu

comment created time in 13 days

pull request commentunicode-org/cldr

CLDR-11312 Valid HTML

Lgtm so far. Drop the r@. Can’t explain showers ==0 off the top of my head.

El El mar, feb. 4, 2020 a la(s) 2:28 p. m., Tom Bishop < notifications@github.com> escribió:

I just noticed that I made LIMITED_SUBMISSION = false in this PR, which I did for testing but didn't really intend to be part of the PR. Will it be false for v38?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/308?email_source=notifications&email_token=AAGQZM4NPRCOB3MKMM54ZZLRBHTXRA5CNFSM4KP62K42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZNWNQ#issuecomment-582146870, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGQZMZLFCR4LD5KPGEGNVDRBHTXRANCNFSM4KP62K4Q .

btangmu

comment created time in 14 days

push eventunicode-org/icu

Andy Heninger

commit sha d6b88d49e3be7096baf3828776c2b482a8ed1780

ICU-20939 Fix problem w regexp \b boundaries & UTF-8 text In regular expressions, when testing for word boundaries with \b, the boundaries were incorrect when in Unicode mode, meaning that an ICU word break iterator is being used to find the boundaries, and the text being matched is UTF-8 encoded. The bug stemmed from a misunderstanding of how string indexes work with UText and break iterators, leading to the inclusion of code to convert from UTF-8 to UTF-16 indexing, when what was wanted was the original UTF-8 index everywhere. Removing the indexing conversion fixes the problem.

view details

push time in 15 days

PR merged unicode-org/icu

ICU-20939 Fix problem w regexp \b boundaries & UTF-8 text

In regular expressions, when testing for word boundaries with \b, the boundaries were incorrect when in Unicode mode, meaning that an ICU word break iterator is being used to find the boundaries, and the text being matched is UTF-8 encoded.

The bug stemmed from a misunderstanding of how string indexes work with UText and break iterators, leading to the inclusion of code to convert from UTF-8 to UTF-16 indexing, when what was wanted was the original UTF-8 index everywhere. Removing the indexing conversion fixes the problem.

<!-- Thank you for your pull request. Please see http://site.icu-project.org/processes/contribute for general information on contributing to ICU.

You will be automatically asked to sign the contributors license before the PR is accepted.

  • sign: https://cla-assistant.io/unicode-org/icu
  • license: http://www.unicode.org/copyright.html#License -->
Checklist
  • [x] Issue filed: https://unicode-org.atlassian.net/browse/ICU-20939
  • [x] Updated PR title and link in previous line to include Issue number
  • [x] Issue accepted
  • [x] Tests included
  • [ ] Documentation is changed or added
+4 -5

0 comment

2 changed files

aheninger

pr closed time in 15 days

pull request commenttc39/proposal-intl-list-format

Normative: Permit conjunctions to be dependent on preceding and following words

I think that should be left entirely to CLDR (which still has not received a concrete design proposal for fixing this).

Is that a concern for you that CLDR has no concrete design proposal for fixing this in context of Stage 4 for Intl.ListFormat? Should we block on CLDR?

@younies can you get a design proposal in for https://unicode-org.atlassian.net/browse/CLDR-13025 and get it on this week's CLDR agenda?

littledan

comment created time in 15 days

issue commentopenjs-foundation/standards

Joining the Unicode Consortium

@MylesBorins you can contact me and i can route w/ any specific questions or contacts.

eemeli

comment created time in 21 days

issue commentopenjs-foundation/standards

Joining the Unicode Consortium

@eemeli who's the right contact on the OpenJSF side?

eemeli

comment created time in 21 days

create barnchsrl295/cldr

branch : mvnize-cldr-apps-icebox

created branch time in a month

push eventsrl295/cldr

btangmu

commit sha d03c67377bb693f2bef3b7c956fd29602aef90c1

CLDR-11585 Change javax.servlet version from 4.0.1 to 3.1.0 (cherry picked from commit 3b9a882208f3842ae5b725321526dc0622a91c8b)

view details

push time in a month

push eventsrl295/cldr

Rick

commit sha a4c68ddc707000ea81e96acfe38e62a3c562b4bd

CLDR-13400 Update boilerplate for proposed update UTS #35 for CLDR 37 release (#207) See #207

view details

Tom Bishop

commit sha 695e43efa3feddbce22638661f12094f52c54c4d

CLDR-13375 getExampleHtml should return same output for same inputs (#211) -Clone cached objects before returning them from ICUServiceBuilder -Call freeze when create UnicodeSet objects beforeCurrencyMatch, etc. -Add new cache for getRuleBasedCollator -Add unit test TestExampleGenerator.TestExampleGeneratorConsistency -Revise TestUnits and TestCompoundUnit to match actual output 1 not 1.00, etc.

view details

pedberg-icu

commit sha 9410efb2d0a6d852440ed5b661eb5d4897afc8fa

CLDR-13415 SBRS 37: update readme.html (#210)

view details

Tom Bishop

commit sha 76c920e6ee5dae2fb0ea583e7562eeb823548247

CLDR-10183 Fix XPathParts (#209) -Remove superfluous or commented-out calls to new XPathParts -Remove unused parameter xpp for getUndistinguishingElementsFor -Replace CLDRFile.nondraftParts with generic Object syncObject -Remove XPathParts.suppressionMap, constructor, and setForWritingWithSuppressionMap -Call CLDRFile.getDefaultSuppressionMap from XPathParts.Element.writeAttributes -In CLDRFile.write call XPathParts.getInstance, simplify usage of last/lastFiltered -In XPathParts.writeDifference treat null lastFullXPath same as empty -New function XPathParts.writeLast to avoid usage of empty XPathParts -Avoid deprecated one-arg DtdData.getInstance in XPathParts.addElement -Comments

view details

pedberg-icu

commit sha 6741b8c4e9ea8f06f54b7d28b0f73c7ffdf561b7

CLDR-13422 Add autonyms for 14 seed locales that lack them (#213)

view details

Diego Plentz

commit sha d1134651c470c3adc4ce8a8363b458417eaeb48c

CLDR-13426 Update Orissa state name to Odisha (#215)

view details

pedberg-icu

commit sha b3a2ac60f33b3ea540039c4a29d4c552449f0485

CLDR-13378 seed locs for hi_Latn,ks_Deva,mni_Mtei,sat,sat_Deva,sd_Deva; update others as req (#212)

view details

Markus Scherer

commit sha dcab652ab7956e837b6045d068d2b8558ec2b6d3

CLDR-13387 Unicode 13 beta (#208) * CLDR-13387 Unicode 13 script metadata * CLDR-13387 Unicode 13 collation root order data from allkeys-13.0.0d8.txt * CLDR-13387 Unicode 13 Chinese collation & translit data * CLDR-13387 new numbering system: sc=Diak has decimal digits * CLDR-13387 UnicodeProperty less work creating & fetching binary properties * CLDR-13387 Unicode 13 GraphemeBreakTest data with CLDR modifications

view details

John Emmons

commit sha 5dc527e26bd18eadf6b4906c0721e3c20a87d2e1

CLDR-13415 SBRS Task S5 Update ICU4J jars to latest (#221)

view details

John Emmons

commit sha 065f5c9f9d251daa06d3ea9020d79713100696c5

CLDR-13415 SBRS Task S9 - Update DTD and CLDRFile to version 37 and Unicode 13 (#220)

view details

John Emmons

commit sha 414d9043310e0e5148b1b7e60bd0a5095bba8500

CLDR-13415 SBRS Task S16 - Use -z build during ST phase (#222)

view details

Mark Davis

commit sha 5d1d472b4e5cf759400123733d8f49006b56bf8a

CLDR-13058 New compound unit patterns (#223) * CLDR-13058 New compound unit patterns * CLDR-13058 fix test (didn't show up locally)

view details

Mark Davis

commit sha 20276a45ebb0c0f57d8b6c8211a7b78c3b9158a8

CLDR-13038 Symbols as new data in CLDR (#226) * CLDR-13038 Symbols as new data in CLDR * CLDR-13038 remove duplicates, adjust test * CLDR-13038 cleaned up path header * CLDR-13038 fixed whitespace in annotation

view details

Mark Davis

commit sha 6837d8c2ff82e93b4c0116bf0a254211a92a7b37

CLDR-13434 Fix some of the exceptions (#224)

view details

Mark Davis

commit sha 159a822b4a5df6ab4f1fff07ac10e44009b4cf82

CLDR-13058 fix names for square, cubic (#227)

view details

Mark Davis

commit sha d4ff934c544c832c8b94925dfec76b428f268b43

CLDR-13057 add the unit prefixes; made small change to compoundUnitPattern1 for consistency also (#228)

view details

Mark Davis

commit sha 53a78d3583da446406d702bd97cec26a4345611d

CLDR-13363 add fa_AF for translation (#225) See #225

view details

Mark Davis

commit sha 52d82903592e6a12016731a225033ada13144dde

CLDR-13360 Add in final changes to emoji for v13.0 (#229) See #229

view details

pedberg-icu

commit sha ee77b59311b87f604435decc699235dd9c7d0114

CLDR-13421 Add some alt=menu/variant names for ars, ckb (#214)

view details

Mark Davis

commit sha 50520324fa826a2ec5541471e463413ea454a7f1

CLDR-13038 symbols as new data in cldr (#233) See #233

view details

push time in a month

push eventsrl295/cldr

Steven R. Loomis

commit sha 1aea2ca60efc1edce42aac08828c3abbd471827c

CLDR-13439 add Il-Kunsill Nazzjonali tal-Ilsien Malti - as kunsill_malti (Maltese Council) - also document the Organization constructor

view details

push time in a month

push eventsrl295/cldr

Steven R. Loomis

commit sha 2a1fa22bf434e4e49ed8add519cf9619b8f7b161

CLDR-13439 add Il-Kunsill Nazzjonali tal-Ilsien Malti - as kunsill_malti (Maltese Council) - also document the Organization constructor

view details

push time in a month

push eventsrl295/cldr

Steven R. Loomis

commit sha a6a32dd888b56c7e373f8e1797987f17953ea24c

CLDR-13439: add Il-Kunsill Nazzjonali tal-Ilsien Malti as kunsill_malti (Maltese Council)

view details

push time in a month

push eventsrl295/cldr

John Emmons

commit sha 853227bbd355d9f1bd53b4562daf9676d3f7a6a6

CLDR-13351 Update JSON utilities for changes in CLDR 36 (#195)

view details

Steven R. Loomis

commit sha 11be5ad0c2ba503f742218f20f03f9cb47897a2b

CLDR-13309 rename specs to docs (#196) - add a specs/README.md for people who land in the old location - add a docs/README.md as a new table of contents deletes many obsolete documents: - Many of these were simple redirects, which URLs have long been broken. - Other files need to be incorporated into some other location, such as the CLDR sites page.

view details

Tom Bishop

commit sha 5c363c68eb1ab0665bf4576d2628545299fc8356

CLDR-13347 DataSection performance (#194) -Avoid re-creating ExampleGenerator with each http request -Get DataSection.nativeExampleGenerator from a cache, on a per-locale basis -Add failureaccess.jar to cldr-apps/.classpath for guava Cache -DataSection.make consistently use session.user not ctx.session.user -New TestCache.getExampleGenerator and exampleGeneratorCache (CacheBuilder) -New ExampleGenerator.updateCache -Implement disableCache methods for several objects for testing/debugging -Test where changing the value of one path changes example-generation for another path -New experimental TestExampleGeneratorDependencies in TestExampleGenerator.java -Remove unused hasExamples, always true -Move some code into subroutines, e.g., updateTestResultCache -Rename cache to testResultCache for clarity -Rename more items for clarity and distinctness, e.g., aliases to aliasCache or aliasMap -Comments

view details

Mark Davis

commit sha e2ab146e6f07fad2b8287d902f1cb7e4b24362a7

CLDR-8462 add alt inheritance (#153)

view details

Tom Bishop

commit sha c04b7b455e678389d1c72fb3b819281fdee71af6

CLDR-13390 Votes for identical inheritance and hard values should be combined (#204) -In getResolverInternal call CLDRFile.getConstructedBaileyValue as DataSection does -New regression test in TestSTFactory.xml -Use getSourceLocaleIdExtended with skip=false to avoid spurious warning in TestSTFactory.xml -Comments

view details

Tom Bishop

commit sha 62aa9660a28005d0d83ef3fafc5fe9810d3c9da7

CLDR-13330 Make ExampleGenerator simpler and faster by removing ExampleType (#202) -Remove third parameter of getExampleHtml -Replace public ExampleType with private boolean typeIsEnglish -Simplify and shorten ExampleGenerator cache key -No loop on ExampleType in checkPathValue -Euro sign instead of USD for Italian currency example in unit test

view details

Rick

commit sha a4c68ddc707000ea81e96acfe38e62a3c562b4bd

CLDR-13400 Update boilerplate for proposed update UTS #35 for CLDR 37 release (#207) See #207

view details

Tom Bishop

commit sha 695e43efa3feddbce22638661f12094f52c54c4d

CLDR-13375 getExampleHtml should return same output for same inputs (#211) -Clone cached objects before returning them from ICUServiceBuilder -Call freeze when create UnicodeSet objects beforeCurrencyMatch, etc. -Add new cache for getRuleBasedCollator -Add unit test TestExampleGenerator.TestExampleGeneratorConsistency -Revise TestUnits and TestCompoundUnit to match actual output 1 not 1.00, etc.

view details

pedberg-icu

commit sha 9410efb2d0a6d852440ed5b661eb5d4897afc8fa

CLDR-13415 SBRS 37: update readme.html (#210)

view details

Tom Bishop

commit sha 76c920e6ee5dae2fb0ea583e7562eeb823548247

CLDR-10183 Fix XPathParts (#209) -Remove superfluous or commented-out calls to new XPathParts -Remove unused parameter xpp for getUndistinguishingElementsFor -Replace CLDRFile.nondraftParts with generic Object syncObject -Remove XPathParts.suppressionMap, constructor, and setForWritingWithSuppressionMap -Call CLDRFile.getDefaultSuppressionMap from XPathParts.Element.writeAttributes -In CLDRFile.write call XPathParts.getInstance, simplify usage of last/lastFiltered -In XPathParts.writeDifference treat null lastFullXPath same as empty -New function XPathParts.writeLast to avoid usage of empty XPathParts -Avoid deprecated one-arg DtdData.getInstance in XPathParts.addElement -Comments

view details

pedberg-icu

commit sha 6741b8c4e9ea8f06f54b7d28b0f73c7ffdf561b7

CLDR-13422 Add autonyms for 14 seed locales that lack them (#213)

view details

Diego Plentz

commit sha d1134651c470c3adc4ce8a8363b458417eaeb48c

CLDR-13426 Update Orissa state name to Odisha (#215)

view details

pedberg-icu

commit sha b3a2ac60f33b3ea540039c4a29d4c552449f0485

CLDR-13378 seed locs for hi_Latn,ks_Deva,mni_Mtei,sat,sat_Deva,sd_Deva; update others as req (#212)

view details

Markus Scherer

commit sha dcab652ab7956e837b6045d068d2b8558ec2b6d3

CLDR-13387 Unicode 13 beta (#208) * CLDR-13387 Unicode 13 script metadata * CLDR-13387 Unicode 13 collation root order data from allkeys-13.0.0d8.txt * CLDR-13387 Unicode 13 Chinese collation & translit data * CLDR-13387 new numbering system: sc=Diak has decimal digits * CLDR-13387 UnicodeProperty less work creating & fetching binary properties * CLDR-13387 Unicode 13 GraphemeBreakTest data with CLDR modifications

view details

John Emmons

commit sha 5dc527e26bd18eadf6b4906c0721e3c20a87d2e1

CLDR-13415 SBRS Task S5 Update ICU4J jars to latest (#221)

view details

John Emmons

commit sha 065f5c9f9d251daa06d3ea9020d79713100696c5

CLDR-13415 SBRS Task S9 - Update DTD and CLDRFile to version 37 and Unicode 13 (#220)

view details

John Emmons

commit sha 414d9043310e0e5148b1b7e60bd0a5095bba8500

CLDR-13415 SBRS Task S16 - Use -z build during ST phase (#222)

view details

Mark Davis

commit sha 5d1d472b4e5cf759400123733d8f49006b56bf8a

CLDR-13058 New compound unit patterns (#223) * CLDR-13058 New compound unit patterns * CLDR-13058 fix test (didn't show up locally)

view details

Mark Davis

commit sha 20276a45ebb0c0f57d8b6c8211a7b78c3b9158a8

CLDR-13038 Symbols as new data in CLDR (#226) * CLDR-13038 Symbols as new data in CLDR * CLDR-13038 remove duplicates, adjust test * CLDR-13038 cleaned up path header * CLDR-13038 fixed whitespace in annotation

view details

Mark Davis

commit sha 6837d8c2ff82e93b4c0116bf0a254211a92a7b37

CLDR-13434 Fix some of the exceptions (#224)

view details

push time in a month

PR opened unicode-org/cldr

Malta

<!-- Thank you for your pull request. Please see http://cldr.unicode.org/index/process for general information on contributing to CLDR.

You will be automatically asked to sign the contributors license before the PR is accepted.

  • sign: https://cla-assistant.io/unicode-org/cldr
  • license: http://www.unicode.org/copyright.html#License -->
Checklist
  • [ ] Issue filed: https://unicode-org.atlassian.net/browse/CLDR-_____
  • [ ] Updated PR title and link in previous line to include Issue number
+35 -13426

0 comment

60 changed files

pr created time in a month

create barnchsrl295/cldr

branch : malta

created branch time in a month

pull request commentunicode-org/icu

ICU-20938 Add --skip-dll-export option to genccode to prevent exporti…

Restarting Travis - unrrelated failure in Java

egorpugin

comment created time in a month

push eventunicode-org/icu

Keita Suzuki

commit sha a4a5c603ac4e06d9d62e1ac35db2a2d9b9b0a51f

ICU-20767 Potential negative index access in one of the sample codes

view details

push time in a month

PR merged unicode-org/icu

ICU-20767 Potential negative index access in one of the sample codes waiting-on-reviewer

<!-- Thank you for your pull request. Please see http://site.icu-project.org/processes/contribute for general information on contributing to ICU.

You will be automatically asked to sign the contributors license before the PR is accepted.

  • sign: https://cla-assistant.io/unicode-org/icu
  • license: http://www.unicode.org/copyright.html#License -->
Checklist
  • [x] Issue filed: https://unicode-org.atlassian.net/browse/ICU-20767
  • [x] Updated PR title and link in previous line to include Issue number
  • [x] Issue accepted
  • [ ] Tests included
  • [ ] Documentation is changed or added
+1 -1

3 comments

1 changed file

quasi-mod

pr closed time in a month

push eventReflectHymn/music

Steven R. Loomis

commit sha a1687214f61d814233d2a8d8be11a1dbef8fd4ae

allow LILYPOND to be a variable

view details

Steven R. Loomis

commit sha 912ce82cb1fb87f212eb6a82ffed49195361134b

mhib: wip

view details

Steven R. Loomis

commit sha fbae61329ecd155a467e0eb8ff36c0c900f5591c

mhib checkpoint

view details

Steven R. Loomis

commit sha 231388763db71924f51bde5820e799c3b3232612

mhib: first draft and words

view details

push time in a month

issue commenti18next/i18next

Why not use CLDR plural categories?

@jamuhl please take a look at http://blog.unicode.org/2020/01/new-unicode-working-group-message.html if you haven't already… thanks!

Shepard

comment created time in a month

startedJames-Yu/LaTeX-Workshop

started time in a month

push eventsrl295/srl295.github.io

Steven R. Loomis

commit sha f214d99e90ab564d992f79e7cd30cd24554650df

Site updated: 2020-01-16 18:10:50

view details

push time in a month

issue commenttc39/ecma402

Decide behavior with gaps in Intl.DateTimeFormat options (replacement pattern)

My concern about this approach is that it has a likelyhood of becoming a papercut giving developers an unexpected behavior.

@zbraniecki I'm going to comment on this on the CLDR issue.

sffc

comment created time in a month

issue commentunicode-org/message-format-wg

Requirements - MF wishlist

This is a use case but has requirement implications in terms of specification:

  • Enable round trip through XLIFF (and possibly other localization formats). In other words, there should be a well-defined way to convert between such a message format and XLIFF.

Example: http://docs.oasis-open.org/xliff/xliff-core/v2.1/os/xliff-core-v2.1-os.html#dataref

This example from the XLIFF spec shows some kind of message format Error in {0}. converted to XLIFF:

<unit id="1">
  <originalData>
    <data id="d1">{0}</data>
  </originalData>
  <segment>
    <source>Error in '<ph id="1" dataRef="d1"/>'.</source>
    <target>Erreur dans '<ph id="1" dataRef="d1"/>'.</target>
  </segment>
</unit>
romulocintra

comment created time in a month

PR opened unicode-org/message-format-wg

Reviewers
Update README.md

Document that this is a CLDR WG

may be other improvements here

+1 -1

0 comment

1 changed file

pr created time in a month

Pull request review commentnodejs/node

util: improve unicode support

 function formatWithOptionsInternal(inspectOptions, ...args) {   return str; } +if (internalBinding('config').hasIntl) {+  const icu = internalBinding('icu');+  // icu.getStringWidth(string, ambiguousAsFullWidth, expandEmojiSequence)+  // Defaults: ambiguousAsFullWidth = false; expandEmojiSequence = true;+  // TODO(BridgeAR): Expose the options to the user. That is probably the+  // best thing possible at the moment, since it's difficult to know what+  // the receiving end supports.+  getStringWidth = function getStringWidth(str, removeControlChars = true) {+    let width = 0;+    if (removeControlChars)+      str = stripVTControlCharacters(str);+    for (let i = 0; i < str.length; i++) {+      // Try to avoid calling into C++ by first handling the ASCII portion of+      // the string. If it is fully ASCII, we skip the C++ part.+      const code = str.charCodeAt(i);+      if (code >= 127) {+        width += icu.getStringWidth(str.slice(i));+        break;+      }+      width += code >= 32 ? 1 : 0;+    }+    return width;+  };+} else {+  /**+   * Returns the number of columns required to display the given string.+   */+  getStringWidth = function getStringWidth(str, removeControlChars = true) {+    let width = 0;++    if (!removeControlChars)+      str = stripVTControlCharacters(str);++    for (const char of str) {+      const code = char.codePointAt(0);+      if (isFullWidthCodePoint(code)) {+        width += 2;+      } else if (!isZeroWidthCodePoint(code)) {+        width++;+      }+    }++    return width;+  };++  /**+   * Returns true if the character represented by a given+   * Unicode code point is full-width. Otherwise returns false.+   */+  const isFullWidthCodePoint = (code) => {+    // Code points are partially derived from:+    // http://www.unicode.org/Public/UNIDATA/EastAsianWidth.txt+    return code >= 0x1100 && (

ICU4C also has API to get the East Asian Width.

BridgeAR

comment created time in a month

create barnchunicode-org/message-format-wg

branch : branding

created branch time in a month

issue commentcoreos/rpm-ostree

[RFE] improve messaging when using `rpm-ostree install` + SELinux disabled

So I can understand (because I've been bit by this)— would you change the messaging to say "SELinux must be enabled to use rpm-ostree"?

miabbott

comment created time in a month

Pull request review commentnodejs/node

util: improve unicode support

 function formatWithOptionsInternal(inspectOptions, ...args) {   return str; } +if (internalBinding('config').hasIntl) {+  const icu = internalBinding('icu');+  // icu.getStringWidth(string, ambiguousAsFullWidth, expandEmojiSequence)+  // Defaults: ambiguousAsFullWidth = false; expandEmojiSequence = true;+  // TODO(BridgeAR): Expose the options to the user. That is probably the+  // best thing possible at the moment, since it's difficult to know what+  // the receiving end supports.+  getStringWidth = function getStringWidth(str, removeControlChars = true) {+    let width = 0;+    if (removeControlChars)+      str = stripVTControlCharacters(str);+    for (let i = 0; i < str.length; i++) {+      // Try to avoid calling into C++ by first handling the ASCII portion of+      // the string. If it is fully ASCII, we skip the C++ part.+      const code = str.charCodeAt(i);+      if (code >= 127) {+        width += icu.getStringWidth(str.slice(i));+        break;+      }+      width += code >= 32 ? 1 : 0;+    }+    return width;+  };+} else {+  /**+   * Returns the number of columns required to display the given string.+   */+  getStringWidth = function getStringWidth(str, removeControlChars = true) {+    let width = 0;++    if (!removeControlChars)+      str = stripVTControlCharacters(str);++    for (const char of str) {+      const code = char.codePointAt(0);+      if (isFullWidthCodePoint(code)) {+        width += 2;+      } else if (!isZeroWidthCodePoint(code)) {+        width++;+      }+    }++    return width;+  };++  /**+   * Returns true if the character represented by a given+   * Unicode code point is full-width. Otherwise returns false.+   */+  const isFullWidthCodePoint = (code) => {+    // Code points are partially derived from:+    // http://www.unicode.org/Public/UNIDATA/EastAsianWidth.txt+    return code >= 0x1100 && (

So this might be doable as a regex… it could be compiled as a regex, i don't think there's an East Asian Width property available in regex.

BridgeAR

comment created time in a month

pull request commentnodejs/node

doc: document ICU time zone data update process

Looks great except drop the reference to “icu-small”

S

El El dom, ene. 12, 2020 a la(s) 12:10 p. m., Andrew Paprocki < notifications@github.com> escribió:

@srl295 https://github.com/srl295 Took a stab at it, let me know if you'd like anything different. I just guessed where it might fit into the flow of the other file.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nodejs/node/pull/30364?email_source=notifications&email_token=AAGQZMZWXS3TRMR5GPSMGNLQ5N2LRA5CNFSM4JL42FLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIXC7GQ#issuecomment-573452186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGQZM66ACWF3SOASVMRFZLQ5N2LRANCNFSM4JL42FLA .

apaprocki

comment created time in a month

pull request commenttc39/proposal-intl-locale

Change the CanonicalizeLanguageTag operation so that it removes duplicate attributes/keywords in Unicode locale extension sequences just as Intl.Locale does

@yumaoka Thanks for the review. It sounds like you're saying that there are editorial cleanups that we should do, but that the semantics are appropriate. Is that accurate?

rename the operation to make it clear that it is not generic to BCP47 but specific to Unicode locale IDs (which are a strict subset of BCP47)?

jswalden

comment created time in a month

issue commentsrl295/es-unicode-properties

Direct code point tests?

Perf-sensitive lexing/parsing in ES

Hi! Can you help me make the case for why this even belongs in ES? (see the other issue)

I’d be curious to know if an API like String.getUnicodePropertyOfCodePoint() has been considered, and whether this seems valuable to others. That is, in addition to the API proposed here currently, not instead of it.

It makes a lot of sense. As you said, in addition, not instead. It could similarly take an array of codepoints (see #1 )

bathos

comment created time in a month

push eventunicode-org/icu

Hugh McMaster

commit sha 5aae52d3ef316b3fd3c43b3f974a8032d279e6fc

ICU-20924 Use pkg-config to generate the path to pkgdata.inc

view details

push time in a month

PR merged unicode-org/icu

ICU-20924 Use pkg-config to generate the path to pkgdata.inc

On systems without icu-config installed, pkgdata will fail because it uses the legacy script to generate the path to pkgdata.inc.

Example command: `pkgdata -p bin_mkltfs -m static -v foo.txt'

pkg-config is always available, so I've created a patch to use it instead of icu-config.

Checklist
  • [x] Issue filed: https://unicode-org.atlassian.net/browse/ICU-20924
  • [x] Updated PR title and link in previous line to include Issue number
  • [x] Issue accepted
  • [ ] Tests included
  • [ ] Documentation is changed or added
+43 -41

5 comments

1 changed file

hughmcmaster

pr closed time in a month

pull request commentunicode-org/cldr

CLDR-13212 Torwali(trw)

@jalaluddin5641 I've identified someone who helped with torwali encoding who will help review this

Jalaluddin5641

comment created time in 2 months

pull request commentunicode-org/cldr

CLDR-13212 Torwali(trw)

@jalaluddin5641 I've identified someone who helped with torwali encoding who will help review this

Jalaluddin5641

comment created time in 2 months

Pull request review commentunicode-org/icu

ICU-20924 Use pkg-config to generate the path to pkgdata.inc

 static void loadLists(UPKGOptions *o, UErrorCode *status)         }     } -    if(buf[strlen(buf)-1]=='\n')-    {-        buf[strlen(buf)-1]=0;-    }--    if(buf[0] == 0)-    {-        fprintf(stderr, "%s: icu-config: invalid response from icu-config (fix PATH or use -O option)\n", progname);+    if (!buf[0]) {+        fprintf(stderr, "%s: invalid response from pkg-config or icu-config\n", progname);

(Ah, i lost my code I was writing… )

Basically, I was suggesting to remember which of pkgconfigCmd or icuconfigCmd was last used .And then print out something like this:

"pkgdata: Could not locate config file. Could not parse the results from 'icu-config --incpkgdatafile'. Check paths or use the -O option to specify a pkgdata.inc file."

hughmcmaster

comment created time in 2 months

Pull request review commentunicode-org/icu

ICU-20924 Use pkg-config to generate the path to pkgdata.inc

 static void loadLists(UPKGOptions *o, UErrorCode *status)     } /* for each file list file */ } -/* Try calling icu-config directly to get the option file. */- static int32_t pkg_getOptionsFromICUConfig(UBool verbose, UOption *option) {+/* Helper for pkg_getPkgDataPath() */ #if U_HAVE_POPEN-    LocalPipeFilePointer p;-    size_t n;-    static char buf[512] = "";+static UBool getPkgDataPath(const char *cmd, UBool verbose, char *buf, size_t items) {     icu::CharString cmdBuf;     UErrorCode status = U_ZERO_ERROR;-    const char cmd[] = "icu-config --incpkgdatafile";-    char dirBuf[1024] = "";-    /* #1 try the same path where pkgdata was called from. */-    findDirname(progname, dirBuf, UPRV_LENGTHOF(dirBuf), &status);-    if(U_SUCCESS(status)) {-      cmdBuf.append(dirBuf, status);-      if (cmdBuf[0] != 0) {-        cmdBuf.append( U_FILE_SEP_STRING, status );-      }-      cmdBuf.append( cmd, status );-      -      if(verbose) {-        fprintf(stdout, "# Calling icu-config: %s\n", cmdBuf.data());-      }-      p.adoptInstead(popen(cmdBuf.data(), "r"));-    }--    if(p.isNull() || (n = fread(buf, 1, UPRV_LENGTHOF(buf)-1, p.getAlias())) <= 0) {-        if(verbose) {-            fprintf(stdout, "# Calling icu-config: %s\n", cmd);-        }+    LocalPipeFilePointer p;+    size_t n; -        p.adoptInstead(popen(cmd, "r"));-        if(p.isNull() || (n = fread(buf, 1, UPRV_LENGTHOF(buf)-1, p.getAlias())) <= 0) {-            fprintf(stderr, "%s: icu-config: No icu-config found. (fix PATH or use -O option)\n", progname);+    cmdBuf.append(cmd, status);+    if (verbose) {+        fprintf(stdout, "# Calling: %s\n", cmdBuf.data());+    }+    p.adoptInstead( popen(cmdBuf.data(), "r") );++    if (p.isNull() || (n = fread(buf, 1, items-1, p.getAlias())) <= 0) {+        fprintf(stderr, "%s: Error calling '%s'\n", progname, cmd);+        *buf = 0;+        return FALSE;+    }++    return TRUE;+}+#endif++/* Get path to pkgdata.inc. Try pkg-config first, falling back to icu-config. */+static int32_t pkg_getPkgDataPath(UBool verbose, UOption *option) {+#if U_HAVE_POPEN+    static char buf[512] = "";+    UBool pkgconfigIsValid = TRUE;+    const char *pkgconfigCmd = "pkg-config --variable=pkglibdir icu-i18n";

I actually didn't know about --variable - I like this. This is OT for this PR perhaps, but: pkgdata.inc is just a bunch of variables. Perhaps the direction we should move is setting those variables directly in the .pc file

hughmcmaster

comment created time in 2 months

Pull request review commentunicode-org/icu

ICU-20924 Use pkg-config to generate the path to pkgdata.inc

 static void loadLists(UPKGOptions *o, UErrorCode *status)     } /* for each file list file */ } -/* Try calling icu-config directly to get the option file. */- static int32_t pkg_getOptionsFromICUConfig(UBool verbose, UOption *option) {+/* Helper for pkg_getPkgDataPath() */ #if U_HAVE_POPEN-    LocalPipeFilePointer p;-    size_t n;-    static char buf[512] = "";+static UBool getPkgDataPath(const char *cmd, UBool verbose, char *buf, size_t items) {     icu::CharString cmdBuf;     UErrorCode status = U_ZERO_ERROR;-    const char cmd[] = "icu-config --incpkgdatafile";-    char dirBuf[1024] = "";-    /* #1 try the same path where pkgdata was called from. */-    findDirname(progname, dirBuf, UPRV_LENGTHOF(dirBuf), &status);-    if(U_SUCCESS(status)) {-      cmdBuf.append(dirBuf, status);-      if (cmdBuf[0] != 0) {-        cmdBuf.append( U_FILE_SEP_STRING, status );-      }-      cmdBuf.append( cmd, status );-      -      if(verbose) {-        fprintf(stdout, "# Calling icu-config: %s\n", cmdBuf.data());-      }-      p.adoptInstead(popen(cmdBuf.data(), "r"));-    }--    if(p.isNull() || (n = fread(buf, 1, UPRV_LENGTHOF(buf)-1, p.getAlias())) <= 0) {-        if(verbose) {-            fprintf(stdout, "# Calling icu-config: %s\n", cmd);-        }+    LocalPipeFilePointer p;+    size_t n; -        p.adoptInstead(popen(cmd, "r"));-        if(p.isNull() || (n = fread(buf, 1, UPRV_LENGTHOF(buf)-1, p.getAlias())) <= 0) {-            fprintf(stderr, "%s: icu-config: No icu-config found. (fix PATH or use -O option)\n", progname);+    cmdBuf.append(cmd, status);+    if (verbose) {+        fprintf(stdout, "# Calling: %s\n", cmdBuf.data());+    }+    p.adoptInstead( popen(cmdBuf.data(), "r") );++    if (p.isNull() || (n = fread(buf, 1, items-1, p.getAlias())) <= 0) {+        fprintf(stderr, "%s: Error calling '%s'\n", progname, cmd);+        *buf = 0;+        return FALSE;+    }++    return TRUE;+}+#endif++/* Get path to pkgdata.inc. Try pkg-config first, falling back to icu-config. */+static int32_t pkg_getPkgDataPath(UBool verbose, UOption *option) {+#if U_HAVE_POPEN+    static char buf[512] = "";+    UBool pkgconfigIsValid = TRUE;+    const char *pkgconfigCmd = "pkg-config --variable=pkglibdir icu-i18n";

And whoops! This actually should be icu-uc (the common library) not icu-i18n. All of this works even if icu-i18n isn't even built or installed.

hughmcmaster

comment created time in 2 months

delete branch unicode-org/icu

delete branch : hagbard-patch-1

delete time in 2 months

push eventunicode-org/icu

David Beaumont

commit sha 2f72a932ac1f401461847eab362bce9809a21e88

ICU-20693 Remember to mention the JAR setup See #900

view details

push time in 2 months

PR merged unicode-org/icu

ICU-20693 Remember to mention the JAR setup

Added a sentence pointing people at the JAR file setup (this should have, obviously, always been there).

Checklist
  • [X] Issue filed: https://unicode-org.atlassian.net/browse/ICU-20693
  • [X] Updated PR title and link in previous line to include Issue number
  • [X] Issue accepted
  • [ ] Tests included
  • [X] Documentation is changed or added
+24 -5

5 comments

1 changed file

hagbard

pr closed time in 2 months

pull request commentunicode-org/icu

ICU-20693 Fix erroneous addition of cldrVersion

lgtm but pending CI

hagbard

comment created time in 2 months

push eventunicode-org/icu

Alhadis

commit sha d895e3f1640ddf5cfa1c193497e16f184212e397

ICU-20892 Highlight `.cpyskip.txt` on GitHub.com

view details

push time in 2 months

PR merged unicode-org/icu

ICU-20892 Highlight `.cpyskip.txt` on GitHub.com

<!-- Thank you for your pull request. Please see http://site.icu-project.org/processes/contribute for general information on contributing to ICU.

You will be automatically asked to sign the contributors license before the PR is accepted.

  • sign: https://cla-assistant.io/unicode-org/icu
  • license: http://www.unicode.org/copyright.html#License -->
Checklist
  • [x] Issue filed: https://unicode-org.atlassian.net/browse/ICU-20892
  • [x] Updated PR title and link in previous line to include Issue number
  • [x] Issue accepted
  • [ ] Tests included
  • [ ] Documentation is changed or added

Note that changes to .gitattributes files won't take effect on GitHub until something else has been modified in a follow-up commit. It's an acknowledged caching issue.

+3 -0

1 comment

1 changed file

Alhadis

pr closed time in 2 months

pull request commentunicode-org/icu

ICU-20892 Highlight `.cpyskip.txt` on GitHub.com

thanks!

Alhadis

comment created time in 2 months

pull request commentunicode-org/icu

ICU-20322 Install dll in $prefix/bin instead of $prefix/lib

icudt needs to be in bin also

vtorri

comment created time in 2 months

pull request commentunicode-org/icu

ICU-20924 Use pkg-config to generate the path to pkgdata.inc

I like the concept, but:

pkg-config is always available

Not quite true. Can you change this to try pkg-config first and fall back to icu-config ? thanks.

hughmcmaster

comment created time in 2 months

pull request commentunicode-org/cldr

CLDR-13468 fix deadlock between STFactory and PerLocaleData

This fix needs more work which I can't give it now.

Yes I think it's mitigated for now bythe setting

Get Outlook for Androidhttps://aka.ms/ghei36


From: Tom Bishop notifications@github.com Sent: Monday, December 9, 2019 6:28:48 PM To: unicode-org/cldr cldr@noreply.github.com Cc: Steven R. Loomis srl295@gmail.com; Assign assign@noreply.github.com Subject: Re: [unicode-org/cldr] CLDR-13468 fix deadlock between STFactory and PerLocaleData (#258)

This particular contention shouldn't happen as long as CLDR_NOUPDATE=TRUE (as it is now) in /home/surveytool/tomcat/cldr/cldr.properties. Maybe there's no urgency to turn off CLDR_NOUPDATE, in which case this ticket isn't very urgent either?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/unicode-org/cldr/pull/258?email_source=notifications&email_token=AAGQZM7ST3NJICFFYGDGPFDQX35GBA5CNFSM4JYUNDD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGL76RI#issuecomment-563609413, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGQZM6TGFSN7BM55ASEWD3QX35GBANCNFSM4JYUNDDQ.

srl295

comment created time in 2 months

pull request commentnodejs/node

build: Auto-load ICU data from --with-icu-default-data-dir

fyi @nodejs/intl

sgallagher

comment created time in 2 months

pull request commentunicode-org/cldr

CLDR-13468 fix deadlock between STFactory and PerLocaleData

Did not test this yet.

Yeah… not working. So this fix is not ready.

srl295

comment created time in 2 months

PR opened unicode-org/cldr

Reviewers
CLDR-13468 fix deadlock between STFactory and PerLocaleData

[CLDR-13468]

  • Contention between makeVettedFile() and voteForValue() makeVettedFile grabs lock on STFactory via get() and then PerLocaleData (for parent locale).getFile() voteForValue is synchronized on PLD and later grabs lock on STFactory via get()

Solution is to, soon after PLD c'tor, initialize the resolved and unresolved CLDRFiles.

  • [X] Issue filed: https://unicode-org.atlassian.net/browse/CLDR-13468
  • [x] Updated PR title and link in previous line to include Issue number
  • [X] This is not a fix that could be done via a survey tool account. Just in case you were wondering.
  • [ ] Did not test this yet.
+13 -12

0 comment

1 changed file

pr created time in 2 months

create barnchsrl295/cldr

branch : deadlock-CLDR-13468

created branch time in 2 months

Pull request review commentnodejs/node

Auto-load ICU data from --with-icu-default-data-dir

 int InitializeNodeWithArgs(std::vector<std::string>* argv,   if (per_process::cli_options->icu_data_dir.empty())     credentials::SafeGetenv("NODE_ICU_DATA",                             &per_process::cli_options->icu_data_dir);++  #ifdef NODE_ICU_DEFAULT_DATA_DIR+  // If neither the CLI option nor the environment variable was specified,+  // fall back to the configured default+  if (per_process::cli_options->icu_data_dir.empty()) {+    // Check whether the NODE_ICU_DEFAULT_DATA_DIR contains the right data+    // file and can be read.+    char full_path[2048];++    strcpy(full_path,+           NODE_ICU_DEFAULT_DATA_DIR U_FILE_SEP_STRING NODE_ICU_DATA_FILE);

use U_ICUDATA_NAME instead of NODE_ICU_DATA_FILE

sgallagher

comment created time in 2 months

Pull request review commentnodejs/node

Auto-load ICU data from --with-icu-default-data-dir

 int InitializeNodeWithArgs(std::vector<std::string>* argv,   if (per_process::cli_options->icu_data_dir.empty())     credentials::SafeGetenv("NODE_ICU_DATA",                             &per_process::cli_options->icu_data_dir);++  #ifdef NODE_ICU_DEFAULT_DATA_DIR+  // If neither the CLI option nor the environment variable was specified,+  // fall back to the configured default+  if (per_process::cli_options->icu_data_dir.empty()) {+    // Check whether the NODE_ICU_DEFAULT_DATA_DIR contains the right data+    // file and can be read.+    char full_path[2048];++    strcpy(full_path,+           NODE_ICU_DEFAULT_DATA_DIR U_FILE_SEP_STRING NODE_ICU_DATA_FILE);+    FILE *f = fopen(full_path, "r");++    if (f) {+      fclose(f);+      per_process::cli_options->icu_data_dir = NODE_ICU_DEFAULT_DATA_DIR;

^ Leverage… nice.

sgallagher

comment created time in 2 months

Pull request review commentnodejs/node

Auto-load ICU data from --with-icu-default-data-dir

       'conditions': [         [ 'icu_small=="true"', {           'defines': [ 'NODE_HAVE_SMALL_ICU=1' ],+          'conditions': [+            [ 'icu_has_default_data_dir=="true"', {+              'defines': [+                'NODE_ICU_DATA_FILE="<(icu_data_file)"',

remove NODE_ICU_DATA_FILE see above

sgallagher

comment created time in 2 months

Pull request review commentnodejs/node

Auto-load ICU data from --with-icu-default-data-dir

 def write_config(data, name):   o['variables']['icu_endianness'] = icu_endianness   icu_data_file_l = 'icudt%s%s.dat' % (icu_ver_major, 'l')   icu_data_file = 'icudt%s%s.dat' % (icu_ver_major, icu_endianness)+  o['variables']['icu_data_file'] = icu_data_file

ICU already calculates this as U_ICUDATA_NAME… i'd rather not pass this in twice

sgallagher

comment created time in 2 months

delete branch srl295/icu

delete branch : userguide-migration

delete time in 2 months

push eventunicode-org/icu

Steven R. Loomis

commit sha 60644fb95e608a8a1915f74673222d77956488e4

usefrom/cobol: copyedit - corrected sample download location

view details

Steven R. Loomis

commit sha cd808041df24c9ecf7c2ca6a985ec7954d5b14d4

layoutengine: updated - while the (line) LayoutEngine is deprecated, I want to include it in the history - we may remove the content and point to the old content in the repo.

view details

Steven R. Loomis

commit sha bc914c43100605e60fa7d92e36565c659a736ece

fixup! layoutengine: updated

view details

push time in 2 months

PR merged unicode-org/icu

Reviewers
Userguide migration: layout and cobol topics
Checklist
  • [ ] Issue filed: https://unicode-org.atlassian.net/browse/ICU-_____
  • [ ] Updated PR title and link in previous line to include Issue number
  • [ ] Issue accepted
  • [ ] Tests included
  • [ ] Documentation is changed or added

This is not a merge onto master.

DISABLE_JIRA_ISSUE_MATCH=true

+78 -55

1 comment

3 changed files

srl295

pr closed time in 2 months

issue openedxpepermint/vue-example

please don't depend on icu4c data

Hi! Please don't depend on the icu4c package directly:

https://github.com/xpepermint/vue-example/blob/18548f250af5105e643f875e7b5b4a6c1b9fa364/package.json#L27

Instead, depend on full-icu.

created time in 2 months

pull request commentnodejs/node

tools: Update icu to 65.1

13.3.0 shipped 3 days ago. This change landed less than one day ago. It will be a later release

Get Outlook for Androidhttps://aka.ms/ghei36


From: Paulo Diovani Gonçalves notifications@github.com Sent: Friday, December 6, 2019 6:48:20 AM To: nodejs/node node@noreply.github.com Cc: Steven R. Loomis srl295@gmail.com; Mention mention@noreply.github.com Subject: Re: [nodejs/node] tools: Update icu to 65.1 (#30232)

Landed in 418dd68https://github.com/nodejs/node/commit/418dd68b611cce7e916dae82c75cb3d63b3c43a6.

But not in v13.3.0https://github.com/nodejs/node/releases/tag/v13.3.0, any idea in which version it ships?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/nodejs/node/pull/30232?email_source=notifications&email_token=AAGQZM5K3S4I6WDEBNPBLQTQXJQ3JA5CNFSM4JIJJ6QKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGEJNWI#issuecomment-562599641, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAGQZM4O6OJVJPT3TK442RDQXJQ3JANCNFSM4JIJJ6QA.

albertyw

comment created time in 2 months

pull request commentnodejs/node

tools: Update icu to 65.1

ICU 66preview announced today - http://site.icu-project.org/download/66 ( it won't ship until March 2020). so, better late than never!

albertyw

comment created time in 2 months

issue commentnodejs/node

ICU 65.1

^ just in time for the ICU4C 66preview announcement ! http://site.icu-project.org/download/66

srl295

comment created time in 2 months

more