profile
viewpoint
罗泽轩 spacewander ChinaTelecom Guangzhou,China http://segmentfault.com/blog/spacewander Core developer of OpenResty / Committer of Apache apisix / Maintainer of git-extras / A bug hunter who is good at writing C/Go/Lua.

seekerlee/SoundPirate 416

Chrome 插件:声海盗,下载在线音乐插件,支持豆瓣,虾米,QQ音乐,网易云音乐等

spacewander/explore-flask-zh 351

Explore Flask中文翻译。关于flask的一些最佳实践。

spacewander/debugger-utils 37

Utils collection for extending gdb with python

spacewander/blogWithMarkdown 23

write blogs in Markdown

spacewander/boltcli 16

boltcli is the redis-cli for boltdb with Lua script support

spacewander/find 14

Wrap find(1) with terminal UI.

spacewander/GSoC 14

[Abandoned] a commandline tool which helps you search/filter projects in Google Summer of Code

spacewander/go-suffix-tree 5

A suffix-tree index implemented in go

spacewander/EasyTable 4

EasyTable 是我的C++大作业。用QT做的简单的制表程序。外表简陋,功能有限。第一次在github上展示自己的程序,请多指教!

pull request commentopenresty/lua-resty-core

feature: shared ngx.ctx among SSL_* phases and the following phases.

The failure of CI isn't caused by this feature.

spacewander

comment created time in a day

pull request commentopenresty/lua-resty-core

feature: shared ngx.ctx among SSL_* phases and the following phases.

Sister PRs: https://github.com/openresty/lua-nginx-module/pull/1514 https://github.com/openresty/meta-lua-nginx-module/pull/81 https://github.com/openresty/stream-lua-nginx-module/pull/208

spacewander

comment created time in a day

pull request commentapache/apisix

feat: allow customizing worker_processes

@membphis Changed.

spacewander

comment created time in a day

push eventspacewander/incubator-apisix

spacewander

commit sha 1655c997c65001b12605fd8c967ec98d0d2e59ff

add test and default value

view details

push time in a day

push eventspacewander/lua-resty-core

spacewander

commit sha 70cab32ef6ec0c7d8b711e0d110d763b557701d7

add stream cases

view details

push time in a day

push eventspacewander/stream-lua-nginx-module

spacewander

commit sha 00bd570f29126096a02d582c438d8cf8e8ea396d

feature: shared ngx.ctx among SSL_* phases and the following phases.

view details

push time in a day

push eventspacewander/lua-resty-core

spacewander

commit sha d0d712e797629c3cdb5d24c0180b1f47f89b0db6

start to port in stream subsystem

view details

push time in a day

push eventspacewander/meta-lua-nginx-module

spacewander

commit sha a0e04e034a0dcf55c82fe4029cb9684ecfa60ebd

feature: shared ngx.ctx among SSL_* phases and the following phases.

view details

push time in a day

push eventspacewander/stream-lua-nginx-module

spacewander

commit sha 3c3197a721017933a651581ada7b873f1055b94d

feature: shared ngx.ctx among SSL_* phases and the following phases.

view details

push time in 2 days

push eventspacewander/stream-lua-nginx-module

spacewander

commit sha a41eeee3a70542a0166a900bb27312d19863717b

feature: shared ngx.ctx among SSL_* phases and the following phases.

view details

push time in 2 days

push eventspacewander/stream-lua-nginx-module

spacewander

commit sha ed4183604a53d96d61118a1904b47edf3d754f1c

feature: shared ngx.ctx among SSL_* phases and the following phases.

view details

push time in 2 days

push eventspacewander/lua-nginx-module

spacewander

commit sha f0bb5364080696a952cbe14702b00f39f31ded6c

feature: shared ngx.ctx among SSL_* phases and the following phases.

view details

push time in 2 days

push eventspacewander/meta-lua-nginx-module

spacewander

commit sha 4d6ec2fb212df4e23d3b1cd64992b84d4e77fa69

feature: shared ngx.ctx among SSL_* phases and the following phases.

view details

push time in 2 days

push eventspacewander/stream-lua-nginx-module

spacewander

commit sha 6960dbe6f57291ce108053a6b13297e9443deeec

feature: shared ngx.ctx among SSL_* phases and the following phases.

view details

push time in 2 days

PR opened openresty/stream-lua-nginx-module

feature: shared ngx.ctx among SSL_* phases and the following phases.

Sister PRs: https://github.com/openresty/lua-nginx-module/pull/1514 https://github.com/openresty/lua-resty-core/pull/243

+61 -10

0 comment

5 changed files

pr created time in 2 days

create barnchspacewander/meta-lua-nginx-module

branch : ssl_shared_ctx

created branch time in 2 days

create barnchspacewander/stream-lua-nginx-module

branch : ssl_shared_ctx

created branch time in 2 days

PR opened apache/apisix

feat: allow customizing worker_processes

Close #2016.

What this PR does / why we need it:

<!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. -->

Pre-submission checklist:

  • [x] Did you explain what problem does this PR solve? Or what new features have been added?
  • [ ] Have you added corresponding test cases?
  • [ ] Have you modified the corresponding document?
  • [x] Is this PR backward compatible?
+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchspacewander/incubator-apisix

branch : customize_processes

created branch time in 2 days

startedxeipuuv/gojsonschema

started time in 2 days

issue commentapache/apisix

request help: How are worker_processes configured

Look like we could not customize worker number yet.

qianglu1989

comment created time in 2 days

Pull request review commenttj/git-extras

Updated the git pull-request command to use personal access token instead of basic auth.

 git-pull-request(1) -- Create pull request for GitHub project  Create pull request for a project on GitHub via command line. -Uses the email from `git config user.email` to open the pull request.+Personal access token is required for making API call to open the pull request in Github. 

s/Github/GitHub

v-y-a-s

comment created time in 2 days

push eventspacewander/lua-resty-core

spacewander

commit sha e6767dae35c26a8a0ee2b4684ee9755cf4b68606

feature: shared ngx.ctx among SSL_* phases and the following phases.

view details

push time in 2 days

push eventspacewander/lua-resty-core

spacewander

commit sha e6e49b5190ef2add5c27f6ab1975fe38b3efcdc0

doc: ngx.pipe: fixed a typo.

view details

Thibault Charbonnier

commit sha 724ef60fce5bbcb27858ec4ab2d74da5aa843f3e

feature: ngx.re: ensured loading the module without PCRE produces a friendly error.

view details

spacewander

commit sha a56adab7af1d93dde6ba03ad174185761b611a1c

feature: added support for specifying environment variables in ngx.pipe spawn(). Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>

view details

Yichun Zhang (agentzh)

commit sha f10d0b3ccc12b3884d8393be6895563eacde870a

doc: ngx.pipe: English grammar fixes.

view details

Thibault Charbonnier

commit sha 05caee4540374f32e72b4d1298b59ee47b3c0480

travis-ci: bumped OpenSSL to 1.0.2s, 1.1.0k, and added 1.1.1c.

view details

Thibault Charbonnier

commit sha 6d99c245229dc2692f78db4f89760e927a16157a

tests: t/re-find.t: hardened a few JIT-related tests.

view details

Thibault Charbonnier

commit sha 262f6283b0c2b52bc0ebc9289c56b97d252198f9

travis-ci: removed OpenSSL 1.1.1c and $OLD_OPENSSL_VER from builds matrix. OpenSSL 1.1.1c support for `ssl_session_(store|fetch)_*` has been reverted from the current master branches of our projects. It will be brought back once the NGINX core has been bumped to 1.17.1. See: https://github.com/openresty/lua-nginx-module/issues/1539 https://github.com/openresty/lua-nginx-module/pull/1540 https://github.com/openresty/lua-nginx-module/pull/1544

view details

Thibault Charbonnier

commit sha 155407974ba932387e361c687d293d28c3bee2e0

travis-ci: bumped the NGINX core version to 1.17.1.

view details

Thibault Charbonnier

commit sha 9d85ce37ceefc8127054c3aef4aa5d2079f1c17b

doc: readme: updated the synopsis section for OpenResty 1.15.8.1.

view details

Thibault Charbonnier

commit sha 3799bbf717fc71933af260552ee9f6632939025d

change: we now require ngx_lua v0.10.16 and ngx_stream_lua v0.0.8.

view details

Thibault Charbonnier

commit sha e624e5159346bf854529db39150248f85be92a3e

travis: added OpenSSL 1.1.1c to the tests matrix.

view details

Thibault Charbonnier

commit sha 63a5f7a0f9f81e9af5a46db098deb8188f748b98

tests: ssl.t: silenced the _G write guard log by declaring a couple of variables as local.

view details

Thibault Charbonnier

commit sha fbafa2a8eecbf820c6602a54ded993dc405b15a1

tests: ssl.t: updated a test to pass with OpenSSL 1.1.1 CLI binaries. This test case invokes the `openssl` binary from a shell to execute a handshake. It is supposed to be for old versions of OpenSSL, but since we can't skip the test with `skip_openssl` (since it isn't about the linked OpenSSL lib), we updated the subject line check to work for OpenSSL 1.1.1 CLI binaries. With older versions of OpenSSL: subject=/C=US/ST=California/L=San Francisco/O=OpenResty/OU=OpenResty/CN=test.com/emailAddress=agentzh@gmail.com With OpenSSL 1.1.1: subject=C = US, ST = California, L = San Francisco, O = OpenResty, OU = OpenResty, CN = test.com, emailAddress = agentzh@gmail.com

view details

Thibault Charbonnier

commit sha 5781dcdc09bace6b6a1370fc08d2104b123110c7

feature: updated 'ssl.get_tls1_version_str()' to recognize TLS 1.3 connections.

view details

Thibault Charbonnier

commit sha cb407efd42ff33fb0838a2683f1373184aae64d4

bugfix: now 'ssl.get_tls1_version_str()' returns the error "unknown version" when the TLS version number is not recognized. In the future, this will avoid bugs in user applications when the `ver` return value is expected to be non-nil, but is `nil` since the TLS version number has not been registered in the Lua module yet. Also includes a few grammatical and styling changes to the ssl.md documentation.

view details

spacewander

commit sha 9937f5d83367e388da4fcc1d7de2141c9e38d7e2

optimize: ngx.resp: made 'add_header()' early exit when 'header_value' is an empty table. Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>

view details

Thibault Charbonnier

commit sha 2921600721bc78e9a1779165ec7f809cd41c70d5

change: updated to support the ngx_http_lua module without old CFunction APIs.

view details

spacewander

commit sha 4393d918ca841789d9bd71bf937b2d2ecedf8c9e

feature: ngx.pipe: allowed for specifying timeouts in 'ngx_pipe.spawn()'. Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>

view details

Thibault Charbonnier

commit sha 5dfc511c8d2feb6b57fee900303214df1e30bf71

bugfix: ensured 'ngx.pipe' APIs with invalid 'self' argument throw an error with the proper stack level.

view details

spacewander

commit sha 4b0dd534b7f8a271bd8757a38a418d3c7eb101f2

feature: allowed 'ngx_pipe.shutdown()' on a sub-process when a light thread is waiting on it. Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>

view details

push time in 2 days

push eventspacewander/lua-nginx-module

Yichun Zhang (agentzh)

commit sha 441c7f626ae934a7d385a020ecce664a26792adf

tests: re-enabled a test case for using ngx.re.match in init_by_lua*.

view details

Thibault Charbonnier

commit sha 30678fd5b9bbe344920278916f73cc0eb946db19

tests: ssl-socket.t: fixed a failing test case due to openresty.org's default cipher.

view details

Luke Gorrie

commit sha 1c756b385dc6812b8e7a90f9a690f16a775792c9

doc: fixed a mistake in tcpsock:receiveany() example in README.md.

view details

spacewander

commit sha a7afd56c66284db64d2dde74e6d9c11d06668e38

feature: added support for specifying environment variables in ngx.pipe spawn() FFI API. Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>

view details

Yichun Zhang (agentzh)

commit sha 1882c30a087168051a8292d0fcd199c0408da814

doc: we now work with nginx 1.14.x and 1.15.x. Thanks Antoine for the reminder in #1534.

view details

Thibault Charbonnier

commit sha 4102b82cd0971c93663fe89eabd75b73741c4213

tests: 161-load-resty-core.t: added a test asserting the directive honors 'lua_package_path'.

view details

Yichun Zhang (agentzh)

commit sha 33a5517c9c4e1a6d1415c2a59a51b0f75e3c8b04

tweak: fixed some warnings from the clang static code analyzer.

view details

Thibault Charbonnier

commit sha 3a5872969cce758eedbd0e750522afb877734195

travis-ci: bumped OpenSSL to 1.0.2s and 1.1.0k.

view details

罗泽轩

commit sha a38d9066787f6fe311135fc512004b1bc19ba1ac

feature: added OpenSSL 1.1.1 support to ssl_session_fetch_by_lua*. See openresty/openresty#456. Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>

view details

spacewander

commit sha 59b6430f7b7c407e15b19035c566a56cfd2eb3e8

bugfix: LuaJIT sets currentline to -1 if it is unavailable.

view details

Thibault Charbonnier

commit sha 32dd6a34a17d6f1f094552a45c204ef614f5fbb5

style: fixed a minor alignment issue in ngx_http_lua_ssl_certby.c.

view details

Thibault Charbonnier

commit sha 81344434aa625878cb33bf0090a8c951a0979a64

doc: fixed a mistake in ngx.location.capture() example in README.md.

view details

Thibault Charbonnier

commit sha b0c7373917c63af3a06474df0ff9f1a65939d3e1

Revert "feature: added OpenSSL 1.1.1 support to ssl_session_fetch_by_lua*." This reverts commit a38d9066787f6fe311135fc512004b1bc19ba1ac. As put by @spacewander: > Previously, we used ClientHello callback to do ssl session fetching non-blockingly. However, this way can not handle an edge case: the ssl session resumption via session ticket might fail, and the client falls back to session ID resumption. The ClientHello callback is run too early to know if the client will fall back to use session ID resumption. Therefore, we have to take back the OpenSSL sess_set_get_cb_yield patch and upgrade it to adapt OpenSSL 1.1.1. --- The `ssl_session_(fetch|store)_by_lua*` handlers will be skipped for TLS 1.3 connections. See: https://github.com/openresty/lua-nginx-module/issues/1539 https://github.com/openresty/lua-nginx-module/pull/1540 https://github.com/openresty/lua-nginx-module/pull/1544

view details

Thibault Charbonnier

commit sha 4e974ba96150d0f5493f7e41c7523f1a3c2e0bef

doc: updated ssl_session_fetch_by_lua_block documentation around OpenSSL and NGINX core patches.

view details

Thibault Charbonnier

commit sha 65bdd4a838a72dc7d9dedc2add58b72aa3a5dfd1

tests: 139-ssl-cert-by.t: downgraded error log level of SSL handshake failures from 'crit' to 'info'. See NGINX commit https://github.com/nginx/nginx/commit/99d7bb690924e60e9e03096ac5e507111f7c182d which landed in 1.15.10.

view details

Thibault Charbonnier

commit sha 2524330e59f0a385a9c77d4d1b957476dce7cb33

travis-ci: bumped the NGINX core version to 1.17.1.

view details

Thibault Charbonnier

commit sha 277d382f51067c0550a8264cb278e1364ba40e9c

api: bumped API version to 0.10.16.

view details

Thibault Charbonnier

commit sha 2014dd80fe4f299ad68c3b60a2c5f846b4286b6f

bugfix: ensured the 'pcre_version' symbol is preserved as undefined when PCRE is statically linked. When using `--with-pcre=...`, NGINX is statically linked against libpcre.a. Since `pcre_version()` is unused, its symbol is stripped by the linker. Because lua-resty-core's `resty.core.regex` module needs it, we here ensure that the symbol is entered as undefined in our final binary. This should not be an issue for win32 builds since `--export-all-symbols` is already set.

view details

spacewander

commit sha d3dbc0c8102a9978d649c99e3261d93aac547378

bugfix: skipped 'ssl_session_store_by_lua*' and 'ssl_session_fetch_by_lua*' when using TLS 1.3. Previously, we used the OpenSSL 1.1.1 ClientHello callback to do ssl session fetching non-blockingly. However, this way cannot handle an edge case: the ssl session resumption via session ticket might fail, and the client fallbacks to session ID resumption. The ClientHello callback is run too early to know if the client will fallback to use session ID resumption. Therefore, we have to take back the OpenSSL sess_set_get_cb_yield patch and upgrade it to adapt OpenSSL 1.1.1, which was done in our openresty/openresty repository. Now, this means that for the time being, we must skip `ssl_session_(fetch|store)_by_lua*` for TLS 1.3. It is possible to support PSK with session ID in TLS 1.3., but we need to modify a number of functions to pass the result up, which will make the patch too complex to maintain. Since PSK with session ticket is supported, supporting PSK with session ID is not so profitable. If someone needs this feature, they can contribute it themselves. Thanks Yongjian Xu and crasyangel for their help. Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>

view details

spacewander

commit sha 467f0134dbf53737a0cf26de7ccb2c35bd490d85

tests: added tests asserting that 'ssl_certificate_by_lua*' and 'ssl_session_fetch_by_lua*' can yield when reading early data. Signed-off-by: Thibault Charbonnier <thibaultcha@me.com>

view details

push time in 2 days

pull request commentapache/apisix

feat: add '**' for alllow_headers and complete docs

Look like we only need to add Access-Control-Allow-Methods and so on in preflight request: https://fetch.spec.whatwg.org/#http-access-control-expose-headers Since it is too late to ask for permission in normal request.

Anyway, useless headers are fine to me...

ShiningRush

comment created time in 2 days

issue closedopenresty/stream-lua-nginx-module

compile error when opening DDEBUG

https://github.com/openresty/stream-lua-nginx-module/blob/a445407723e7e5075a6458c725961358d911fdbf/src/ngx_stream_lua_socket_tcp.c#L2183

closed time in 2 days

like-c

issue commentopenresty/stream-lua-nginx-module

compile error when opening DDEBUG

Solved.

like-c

comment created time in 2 days

push eventopenresty/stream-lua-nginx-module

罗泽轩

commit sha 6eb31d265b1ba3707188709db0a141831dc7fd40

bugfix: the stream subsystem was built incorrectly in debug mode. (#207) Fix #205, #206.

view details

push time in 2 days

issue closedopenresty/stream-lua-nginx-module

use stream macro

https://github.com/openresty/stream-lua-nginx-module/blob/a445407723e7e5075a6458c725961358d911fdbf/src/ngx_stream_lua_contentby.c#L148

closed time in 2 days

like-c

push eventopenresty/meta-lua-nginx-module

罗泽轩

commit sha e8ce116d0770becdb770c4db7af6c7332fe035b7

bugfix: the stream subsystem was built incorrectly in debug mode. (#80)

view details

push time in 2 days

Pull request review commenttj/git-extras

Updated the git pull-request command to use personal access token instead of basic auth.

 fi  test -z "$user" && abort "git config user.email required" +# personal access token+# config name is personal-access-token '_' is not allowed in git config++personal_access_token=$(git config git-extras.personal-access-token)

Please add github in the config name, since the token is only for GitHub.

v-y-a-s

comment created time in 3 days

Pull request review commenttj/git-extras

Updated the git pull-request command to use personal access token instead of basic auth.

 fi  test -z "$user" && abort "git config user.email required"

It seems that we can remove $user and its doc now?

v-y-a-s

comment created time in 3 days

Pull request review commenttj/git-extras

Updated the git pull-request command to use personal access token instead of basic auth.

 Create pull request for a project on GitHub via command line.  Uses the email from `git config user.email` to open the pull request. +Personal access token is required for making API call to open the pull request. ++Makre sure the personal access token has the right `OAuth` scopes for the repo(s)++use `git config --global --add git-extras.personal-access-token <your-personal-access-token>`++if using mutiple accounts, override the global value in the specific repo using `git config git-extras.personal-access-token <other-acc-personal-access-token>`

Ditto

v-y-a-s

comment created time in 3 days

Pull request review commenttj/git-extras

Updated the git pull-request command to use personal access token instead of basic auth.

 Create pull request for a project on GitHub via command line.  Uses the email from `git config user.email` to open the pull request. +Personal access token is required for making API call to open the pull request. ++Makre sure the personal access token has the right `OAuth` scopes for the repo(s)++use `git config --global --add git-extras.personal-access-token <your-personal-access-token>`

Sentence should be started with capital letter.

v-y-a-s

comment created time in 3 days

Pull request review commenttj/git-extras

Updated the git pull-request command to use personal access token instead of basic auth.

 Create pull request for a project on GitHub via command line.  Uses the email from `git config user.email` to open the pull request. +Personal access token is required for making API call to open the pull request. ++Makre sure the personal access token has the right `OAuth` scopes for the repo(s)

'Make sure'

v-y-a-s

comment created time in 3 days

issue commentapache/apisix

bug: cors when the request is a preflight request we shouldn't set the Access-Control-Allow-Headers *

According to the spec, it looks like that Access-Control-Allow-Method and Access-Control-Allow-Headers are only for preflight request. https://fetch.spec.whatwg.org/#http-access-control-allow-methods https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Allow-Headers

So the only thing need to be restricted is Access-Control-Expose-Headers. For example, we can require Access-Control-Expose-Headers not to be * when Access-Control-Allow-Credentials: true.

OnlyPiglet

comment created time in 3 days

issue commentopenresty/stream-lua-nginx-module

use stream macro

@like-c Thanks for your report! I just submitted a fix for it.

like-c

comment created time in 3 days

create barnchspacewander/stream-lua-nginx-module

branch : fix_compilation

created branch time in 3 days

push eventspacewander/stream-lua-nginx-module

spacewander

commit sha f1bf2e3ed878c7f8a90aaed64877056f001f6645

bugfix: the stream subsystem was built incorrectly in debug mode. Fix #205, #206.

view details

push time in 3 days

create barnchspacewander/meta-lua-nginx-module

branch : fix_compilation

created branch time in 3 days

push eventspacewander/meta-lua-nginx-module

spacewander

commit sha cee04239fc4b179129937a7dc6c496cb4d0f2aa4

bugfix: the stream subsystem was built incorrectly in debug mode.

view details

push time in 3 days

Pull request review commentopenresty/lua-resty-core

feat: ngx.ssl.server_port(): get server port

 function _M.raw_server_addr() end  +function _M.server_port()+    local r = get_request()+    if not r then+        error("no request found")+    end++    local rc = ngx_lua_ffi_ssl_server_port(r, uintp, errmsg)+    if rc == FFI_OK then+        return uintp[0]+    end++    if rc == FFI_DECLINED then

The C code doesn't return FFI_DECLINED.

halfcrazy

comment created time in 3 days

Pull request review commentopenresty/lua-nginx-module

feat: ngx.ssl.server_port(): get server port

 my $openssl_version = eval { `$NginxBinary -V 2>&1` }; if ($openssl_version =~ m/built with OpenSSL (0|1\.0\.(?:0|1[^\d]|2[a-d]).*)/) {     plan(skip_all => "too old OpenSSL, need 1.0.2e, was $1"); } else {-    plan tests => repeat_each() * (blocks() * 6 + 4);+    plan tests => repeat_each() * (blocks() * 6 + 4) - 6;

Need to avoid using - num in plan, otherwise the ONLY section will not work anymore.

halfcrazy

comment created time in 3 days

Pull request review commentopenresty/lua-nginx-module

feat: ngx.ssl.server_port(): get server port

 ngx_http_lua_ffi_ssl_server_name(ngx_http_request_t *r, char **name, }  +int+ngx_http_lua_ffi_ssl_server_port(ngx_http_request_t *r, unsigned int *port,+    char **err)+{+    ngx_ssl_conn_t          *ssl_conn;+    ngx_connection_t        *c;+    ngx_uint_t               p;++    if (r->connection == NULL || r->connection->ssl == NULL) {+        *err = "bad request";+        return NGX_ERROR;+    }++    ssl_conn = r->connection->ssl->connection;+    if (ssl_conn == NULL) {+        *err = "bad ssl conn";+        return NGX_ERROR;+    }++    c = ngx_ssl_get_connection(ssl_conn);++    if (ngx_connection_local_sockaddr(c, NULL, 0) != NGX_OK) {+        return 0;

This way is incorrect to handle the error.

halfcrazy

comment created time in 3 days

issue commentopenresty/stream-lua-nginx-module

ngx_stream_lua_module.so failed to load the 'resty.core' module

http {
……
lua_package_path  "/opt/app/luajit2/lib/lua/?.lua;;";

Have you configured the same thing for stream block?

gotnix

comment created time in 3 days

pull request commentspacewander/luafilesystem

feature: add makefile for make install

Merged. Thanks!

rainingmaster

comment created time in 3 days

push eventspacewander/luafilesystem

rainingmaster

commit sha bd8d215680f1aa26094f6c154d61dd36de3bbcf2

feature: add makefile for make install

view details

罗泽轩

commit sha 10831d3de10acaa28ff58e939ed0f7c4f4d2424f

Merge pull request #8 from rainingmaster/makefile feature: add makefile for make install

view details

push time in 3 days

PR merged spacewander/luafilesystem

feature: add makefile for make install

@spacewander Hi, I think we should have a makefile to install this module under command line? Just like other lua module.

+12 -0

0 comment

1 changed file

rainingmaster

pr closed time in 3 days

push eventopenresty/stream-lua-nginx-module

罗泽轩

commit sha a445407723e7e5075a6458c725961358d911fdbf

bugfix: hide get_request API in stream subsystem (#201) As the req_type in stream subsystem is unexported. Fix https://github.com/openresty/stream-lua-nginx-module/issues/180.

view details

push time in 4 days

PR merged openresty/stream-lua-nginx-module

bugfix: hide get_request API in stream subsystem

As the req_type in stream subsystem is unexported. Fix https://github.com/openresty/stream-lua-nginx-module/issues/180.

+0 -6

0 comment

2 changed files

spacewander

pr closed time in 4 days

issue commenttj/git-extras

git pull-request - Github API decprication notice

@v-y-a-s Look like we need to change -u "$user" to -H 'Authorization: token my_access_token'. We can store the token in git config git-extras.github_token. Pull request is welcome!

v-y-a-s

comment created time in 4 days

push eventopenresty/stream-lua-nginx-module

罗泽轩

commit sha 402e861a67c56d52de746a6aa415f90991122c9c

tests: fix ngx.req field count (#202)

view details

push time in 4 days

pull request commentapache/apisix

Fixed discovery weight bug

@frank0417 Please explain why the 'fix' is needed.

frank0417

comment created time in 4 days

push eventspacewander/stream-lua-nginx-module

Meathill

commit sha 5a8bc299acf365f9511537895482cc29c161482a

doc: updated the Version section to reflect the release date

view details

ArchangelSDY

commit sha 5d8f675a6ae448db0cb713829d2a2c9092cf921e

feature: add FFI interface to verify SSL client certificate (#190)

view details

spacewander

commit sha fa3aaa2527df493e7a9e384dfcaf3a38e8d7420d

tests: fix ngx.req field count

view details

push time in 5 days

create barnchspacewander/meta-lua-nginx-module

branch : master

created branch time in 5 days

push eventopenresty/meta-lua-nginx-module

spacewander

commit sha e54203053a09b9d6d0df87ffb79317b76412e616

chore: sync the code style from stream-lug-nginx-module

view details

push time in 5 days

pull request commentopenresty/meta-lua-nginx-module

feature: add FFI interface to verify SSL client certificate

I decided to merge this PR first and fix it myself later, so that the process can continue. Anyway, thank you for your contribution, @ArchangelSDY !

ArchangelSDY

comment created time in 5 days

push eventopenresty/meta-lua-nginx-module

spacewander

commit sha ea574ea31a4f1044c5f9b3dbed3813975d9c2b72

bugfix: correct variable name typo.

view details

push time in 5 days

push eventopenresty/stream-lua-nginx-module

ArchangelSDY

commit sha 5d8f675a6ae448db0cb713829d2a2c9092cf921e

feature: add FFI interface to verify SSL client certificate (#190)

view details

push time in 5 days

PR merged openresty/stream-lua-nginx-module

feature: add FFI interface to verify SSL client certificate

This PR adds a FFI interface that allows users to configure SSL client certificate verification dynamically. For example, Nginx can now read SNI first and then determine whether to request a client certificate during handshake. Optionally, caller can pass in a CA list used for verification.

See https://github.com/openresty/meta-lua-nginx-module/pull/75 .

I hereby granted the copyright of the changes in this pull request to the authors of this lua-nginx-module project.

+327 -0

0 comment

2 changed files

ArchangelSDY

pr closed time in 5 days

push eventopenresty/meta-lua-nginx-module

ArchangelSDY

commit sha b3a3082ad415b595e0e70b89cbac83e7eeae806e

feature: add FFI interface to verify SSL client certificate (#75)

view details

push time in 5 days

PR merged openresty/meta-lua-nginx-module

feature: add FFI interface to verify SSL client certificate

This PR adds a FFI interface that allows users to configure SSL client certificate verification dynamically. For example, Nginx can now read SNI first and then determine whether to request a client certificate during handshake. Optionally, caller can pass in a CA list used for verification.

I hereby granted the copyright of the changes in this pull request to the authors of this lua-nginx-module project.

+149 -0

0 comment

1 changed file

ArchangelSDY

pr closed time in 5 days

Pull request review commentopenresty/meta-lua-nginx-module

feature: add FFI interface to verify SSL client certificate

 failed: }  +static int+ngx_[%s subsys %]_lua_ssl_verify_callback(int ok, X509_STORE_CTX *x509_store)+{+    /*+     * we never terminate handshake here and user can later use+     * $ssl_client_verify to check verification result.+     *+     * this is consistent with Nginx behavior.+     */+    return 1;+}+++int+ngx_[% subsys %]_lua_ffi_ssl_verify_client([% req_type %] *r,+    void *cdata, int depth, char **err)+{+    ngx_[% subsys %]_lua_ctx_t      *ctx;+    ngx_ssl_conn_t                  *ssl_conn;+[% IF http_subsys %]+    ngx_http_ssl_srv_conf_t         *sscf;+[% ELSIF stream_subsys %]+    ngx_stream_ssl_conf_t           *sscf;+[% END %]+    STACK_OF(X509)                  *chain = cdata;+    STACK_OF(X509_NAME)             *name_chain = NULL;+    X509                            *x509 = NULL;+    X509_NAME                       *subject = NULL;+    X509_STORE                      *ca_store = NULL;+#ifdef OPENSSL_IS_BORINGSSL+    size_t                          i;+#else+    int                             i;+#endif++[% IF http_subsys %]+    ctx = ngx_http_get_module_ctx(r, ngx_http_lua_module);+[% ELSIF stream_subsys %]+    ctx = ngx_stream_get_module_ctx(r->session, ngx_stream_lua_module);+[% END %]+    if (ctx == NULL) {+        *err = "no request ctx found";+        return NGX_ERROR;+    }++    if (!(ctx->context & NGX_[% SUBSYS %]_LUA_CONTEXT_SSL_CERT)) {+        *err = "API disabled in the current context";+        return NGX_ERROR;+    }++    if (r->connection == NULL || r->connection->ssl == NULL) {+        *err = "bad request";+        return NGX_ERROR;+    }++    ssl_conn = r->connection->ssl->connection;+    if (ssl_conn == NULL) {+        *err = "bad ssl conn";+        return NGX_ERROR;+    }++    /* enable verify */++    SSL_set_verify(ssl_conn, SSL_VERIFY_PEER,+                   ngx_[%s subsys %]_lua_ssl_verify_callback);

Should be subsys.

ArchangelSDY

comment created time in 5 days

Pull request review commentopenresty/meta-lua-nginx-module

feature: add FFI interface to verify SSL client certificate

 failed: }  +static int+ngx_[%s subsys %]_lua_ssl_verify_callback(int ok, X509_STORE_CTX *x509_store)

Should be subsys.

ArchangelSDY

comment created time in 5 days

pull request commentopenresty/stream-lua-nginx-module

tests: fix ngx.req field count

It seems that https://github.com/openresty/stream-lua-nginx-module/pull/190 and https://github.com/openresty/meta-lua-nginx-module/pull/75 should be merged. @doujiang24 @rainingmaster

spacewander

comment created time in 5 days

create barnchspacewander/stream-lua-nginx-module

branch : correct_req_count

created branch time in 6 days

push eventspacewander/stream-lua-nginx-module

push time in 6 days

push eventspacewander/stream-lua-nginx-module

spacewander

commit sha ef045d9377365afb086930efca19efda0bf6b8db

test CI

view details

push time in 6 days

issue commentopenresty/stream-lua-nginx-module

checking for LuaJIT has FFI .../bin/sh: -c: line 0: unexpected EOF while looking for matching `''

Does https://github.com/openresty/stream-lua-nginx-module/pull/192 fix the problem?

rgonerao

comment created time in 6 days

push eventspacewander/stream-lua-nginx-module

spacewander

commit sha eac2c208c4227143af457c3a0351514e679a4b82

bugfix: hide get_request API in stream subsystem As the req_type in stream subsystem is unexported. Fix https://github.com/openresty/stream-lua-nginx-module/issues/180.

view details

push time in 6 days

PR opened openresty/stream-lua-nginx-module

bugfix: hide get_request API in stream subsystem

As the req_type in stream subsystem is unexported. Fix https://github.com/openresty/stream-lua-nginx-module/issues/180.

+0 -6

0 comment

2 changed files

pr created time in 6 days

create barnchspacewander/stream-lua-nginx-module

branch : lzx

created branch time in 6 days

push eventopenresty/meta-lua-nginx-module

罗泽轩

commit sha 2a43c8046d7faff3efa2e41ba637ae06bd6b1669

bugfix: hide get_request API in stream subsystem (#78) As the req_type in stream subsystem is unexported. Fix https://github.com/openresty/stream-lua-nginx-module/issues/180.

view details

push time in 6 days

PR merged openresty/meta-lua-nginx-module

bugfix: hide get_request API in stream subsystem

As the req_type in stream subsystem is unexported. Fix https://github.com/openresty/stream-lua-nginx-module/issues/180.

+4 -0

0 comment

2 changed files

spacewander

pr closed time in 6 days

issue closedopenresty/stream-lua-nginx-module

api/ngx_stream_lua_api.h should export ngx_stream_lua_request_t

Hi,

I think https://github.com/openresty/stream-lua-nginx-module/blob/master/src/api/ngx_stream_lua_api.h is not usable currently. Since ngx_stream_lua_request_t defined in below, are not exported, including ngx_stream_lua_api.h solely makes compile failed.

https://github.com/openresty/stream-lua-nginx-module/blob/e3eb228c08e5bab30404d5d715bd9b5a545f68a8/src/ngx_stream_lua_request.h#L22-L35

Currently, I added #include "../ngx_stream_lua_request.h" to ngx_stream_lua_api.h for workaround, but only exporting ngx_stream_lua_request_t will be more suitable.

I want to submit pull request. Is moving ngx_stream_lua_request_t to ngx_stream_lua_api.h and include ngx_stream_lua_api.h from ngx_stream_lua_request.h suitable?

closed time in 6 days

kyontan

pull request commentmosn/mosn

remove redundant 'replace' directive in go.mod

@cch123 I see. The version of go-control-plane dependency list in require{} block is equal to max(your requirement, your dependencies' requirement). And the result happens to be 0.9.4 in the latest commit, which is also the version for your requirement.

In the future, one of {mosn, mosn dependencies} may upgrade their required go-control-plane's version, and go-control-plane doesn't keep the backward compatibility, therefore you control to pin the version with replace directive.

spacewander

comment created time in 6 days

pull request commentmosn/mosn

remove redundant 'replace' directive in go.mod

@cch123 It's strange. The version of go-control-plane is already pinned in the build list even without the replace directive. Go mod should not update it.

According to the doc of go.mod's replace:

The same module version must not also appear in the build list.

https://golang.org/ref/mod#tmp_15

spacewander

comment created time in 8 days

startedcodespell-project/codespell

started time in 8 days

PR opened mosn/mosn

remove redundant 'replace' directive in go.mod

Since now we already use go-control-plane v0.9.4, there is no need to apply the replace directive.

Close #1292.

+4 -2

0 comment

2 changed files

pr created time in 9 days

push eventspacewander/mosn

spacewander

commit sha 557dcf7d7c28a74fbc926b3d649db9519b903ff8

remove redundant 'replace' directive in go.mod Since now we already use go-control-plane v0.9.4, there is no need to apply the replace directive. Close #1292.

view details

push time in 9 days

issue openedmosn/mosn

No need to pin github.com/envoyproxy/go-control-plane to v0.9.4 twice

The go-control-plane's version is specified twice in go.mod (but the value is the same): https://github.com/mosn/mosn/blob/5bc5c6551b16aa2e65ae7e2ae559fc7e376aa20d/go.mod#L13 https://github.com/mosn/mosn/blob/5bc5c6551b16aa2e65ae7e2ae559fc7e376aa20d/go.mod#L54

AFAIK, we only need to specify the version once.

created time in 9 days

create barnchspacewander/mosn

branch : lzx

created branch time in 9 days

fork spacewander/mosn

MOSN is a cloud native proxy for edge or service mesh. https://mosn.io

fork in 9 days

issue commentopenresty/lua-nginx-module

PRs that ready to be merged

https://github.com/openresty/lua-nginx-module/pull/1756 https://github.com/openresty/lua-nginx-module/pull/1759 https://github.com/openresty/meta-lua-nginx-module/pull/78

doujiang24

comment created time in 9 days

PR opened openresty/meta-lua-nginx-module

Reviewers
bugfix: hide get_request API in stream subsystem

As the req_type in stream subsystem is unexported. Fix https://github.com/openresty/stream-lua-nginx-module/issues/180.

+4 -0

0 comment

2 changed files

pr created time in 10 days

create barnchspacewander/meta-lua-nginx-module

branch : lzx

created branch time in 10 days

pull request commenttj/git-extras

Implement fish completions file

@soraxas Merged. Thanks!

soraxas

comment created time in 10 days

push eventtj/git-extras

Tin Lai

commit sha 4a7fcb7d1cc52407b3a890e33c7ec9399b580fb0

implement fish completions file Signed-off-by: Tin Lai <oscar@tinyiu.com>

view details

罗泽轩

commit sha 2f3772b09a3eb595e605e9ed652eed2b5479f413

Merge pull request #860 from soraxas/implement-fish-completions Implement fish completions file

view details

push time in 10 days

PR merged tj/git-extras

Implement fish completions file

This PR implements completions file for fish. The basis of the commands and short description follows the zsh completion file.

+187 -1

0 comment

3 changed files

soraxas

pr closed time in 10 days

issue commenttj/git-extras

Add start-point option to `git feature`

I think it would be better to use --xxx yyy style for optional argument.

smeijer

comment created time in 10 days

issue commenttj/git-extras

Add start-point option to `git feature`

You can use git config git-extras.$cmd.$attr to get the global option, like git config git-extras.create-branch.remote. BTW, I suggest to use --from <start-point> instead of using it directly as argument.

smeijer

comment created time in 10 days

pull request commentopenresty/lua-nginx-module

feature: allow ngx.sleep to be used blockingly in non-yieldable phases

@rainingmaster @dndx Updated.

spacewander

comment created time in 10 days

more