Proposed changes

Extends PR #108, setting the nginx_app_protect_manage_repo flag on the RHEL NGINX Plus repository task which was erroneously omitted from that PR.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• [x] I have read the CONTRIBUTING document
• [x] I have added Molecule tests that prove my fix is effective or that my feature works
• [x] I have checked that any relevant Molecule tests pass after adding my changes
• [x] I have updated any relevant documentation (defaults/main.yml, README.md and CHANGELOG.md)

@alessfg dito for nginxinc/ansible-role-nginx#420 ;) , CHANGELOG & NGINX naming updated

@aknot242 just updated the CHANGELOG and properly named NGINX.

As for the test, if we can move forward with this PR as -is that'd be great as it would unblock us, I'm under a bit of a crunch ATM but when I have the time I'll re-visit the proposed approach. Using the prepare.yml is a good suggestion.

Proposed changes

This change adds a nginx_install_epel_release feature flag which allows epel-release to not be installed by this role if so desired.

This feature flag addresses a need where the epel repository config is managed by other means and should not be configured by this role in order to install Nginx or it's modules. The default behavior of the role is unaltered.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• [x] I have read the CONTRIBUTING document
• [x] I have added Molecule tests that prove my fix is effective or that my feature works
• [x] I have checked that any relevant Molecule tests pass after adding my changes
• [x] I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

Sidenote on Molecule tests, as a test for setting nginx_install_epel_release to false would effectively require current tests to be disabled, and as the default behavior is not altered, no additional tests have been added.

Proposed changes

This change adds a nginx_app_protect_manage_repo boolean which can be used to disable Nginx App Protect repo management by this role.

This feature flag addresses edge-cases where Nginx' App Protect repositories are managed by other means and should not be configured by this role in order to install Nginx App Protect. The default behavior of the role is unaltered.

Checklist

• [x] I have read the CONTRIBUTING document
• [x] I have added Molecule tests that prove my fix is effective or that my feature works
• [x] I have checked that any relevant Molecule tests pass after adding my changes
• [x] I have updated any relevant documentation (defaults/main.yml, README.md and CHANGELOG.md)

Sidenote on Molecule tests, as a test for setting nginx_app_protect_manage_repo to false would effectively require current tests to be disabled, and as the default behavior is not altered, no additional tests have been added.

Proposed changes

This change adds a nginx_manage_repo boolean which can be used to disable Nginx repo management by this role.

This feature flag addresses edge-cases where Nginx' repositories are managed by other means and should not be configured by this role in order to install Nginx. The default behavior of the role is unaltered.

Checklist

• [x] I have read the CONTRIBUTING document
• [x] I have added Molecule tests that prove my fix is effective or that my feature works
• [x] I have checked that any relevant Molecule tests pass after adding my changes
• [x] I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

Sidenote on Molecule tests, as a test for setting nginx_manage_repo to false would effectively require current tests to be disabled, and as the default behavior is not altered, no additional tests have been added.

This PR does no longer provide a full path for the libkdu_v75R.so --provides flag as this prevents the dependency to be resolved.

With the full path and kakadu installed, iipsrv is unable to resolve the dependency.

# rpm -i iipsrv-1.0.0-1.0.el7.x86_64.rpm 
error: Failed dependencies:
	libkdu_v75R.so()(64bit) is needed by iipsrv-1.0.0-1.0.el7.x86_64

# rpm -q --whatprovides libkdu_v75R.so
no package provides libkdu_v75R.so

I tested ( on CentOS 7 ) with a couple of iterations but the only solution to have the dependency resolved was to remove the full path. This does not alter the ouput of rpm -q --whatprovides libkdu_v75R.so, so this might actually be an issue with fpm.

In any case this should allow the .rpms to be installed without any adjustments to the Dockerfile.