reactjs/react-transition-group 7771
An easy way to perform animations when a React component enters or leaves the DOM
roylee0704/react-flexbox-grid 2751
A set of React components implementing flexboxgrid with the power of CSS Modules.
shrinerb/shrine 2716
File Attachment toolkit for Ruby applications
cometkim/gatsby-plugin-linaria 49
Gatsby plugin for styling with Linaria
SBoudrias/gulp-exclude-gitignore 26
Gulp plugin to exclude file contained in .gitignore from the stream
jquense/gatsby-plugin-astroturf 11
Gatsby plugin for styling with astroturf
Exposes custom properties, custom media queries and custom selectors to JavaScript
Various techniques of bridging the gap between CSS and JavaScript
JS Weekend frontend site exercise
janko/capybara-vs-webdriverio 5
Battle between Capybara and Webdriver.io for browser testing
push eventkiwicom/orbit
commit sha 9af19037a906fd4c65d9eca1b33f6ed9a4ea0d8c
docs: add missing changelog entry I guess whatever Lerna is using to generate changelogs got confused by the exclamation mark in the commit message.
push time in 4 hours
push eventkiwicom/orbit
commit sha 1e69e745e2701382aa59ddc927b2b34fcaf7ad50
chore: publish - @kiwicom/[email protected] - @kiwicom/[email protected]
push time in 4 hours
created tagkiwicom/orbit
React components of open-source Orbit design system by Kiwi.com
created time in 4 hours
created tagkiwicom/orbit
React components of open-source Orbit design system by Kiwi.com
created time in 4 hours
push eventkiwicom/orbit
commit sha 4aee1e91f9c3d347be53bf793ff30792a6b1ea70
improve: add npm scripts for testing
commit sha ef5e6677dd366314454d3f45dbdd313345788370
chore: remove unnecessary dotenv dependency We replaced it with dotenv-safe, forgot to delete this one.
commit sha 0ff156986ffea4bc02319604f6bc4370602b8f43
test: update Loki version
commit sha b1edc613ffc9853ccda6ba6eabfbabbeae18c4a1
test: update Loki references
commit sha a333b9dcbcb6af4e8b0ae0b33fc62499d91d7fa7
test: add missing Loki references
push time in 5 hours
PR merged kiwicom/orbit
- bump Loki – new version of Loki has a much better output and it appears to be faster (I had serious problems with speed 😬)
- update visual references – I carefully updated them to remove code blocks and check for visual regressions, so now references are fully up-to-date
- add missing references – let's hope this works out now for everyone 🤞
- add npm scripts to make testing easier
- remove unused
dotenvdependency (unrelated)
Closes: #2293
We should probably switch to Git LFS eventually, I've never used it, though.<br/><br/><br/><url>LiveURL: https://orbit-test-update-visual-references.surge.sh</url>
pr closed time in 5 hours
PR closed kiwicom/orbit
Bumps loki from 0.15.1 to 0.25.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/oblador/loki/releases">loki's releases</a>.</em></p> <blockquote> <h2>0.24.0</h2> <h2>New functionality</h2> <ul> <li>Async CSF stories are now supported via the <code>@loki/create-async-callback</code> package.</li> <li><code>chromeSelector</code> option can now be passed on a per story basis via the loki parameter.</li> </ul> <h2>Fixes</h2> <ul> <li>Better support for <code>chromeSelector</code> option not ending with <code>> *</code> .</li> </ul> <h2>0.23.0</h2> <h2>Breaking changes</h2> <ul> <li><strong>Support skip via story parameters</strong>. This deprecates support for SB < 5.</li> <li><strong>Bump default chrome docker version to 85</strong>. This will change how the default font renders, if you want to keep the old version, use <code>--chromeDockerImage yukinying/chrome-headless:63.0.3230.2</code>.</li> </ul> <h2>0.22.1</h2> <h3>Bug fixes</h3> <ul> <li>Fix loki global check for React Native</li> </ul> <h2>0.22.0</h2> <h3>New functionality</h3> <ul> <li><code>isLokiRunning</code> function in the <code>@loki/is-loki-running</code> package that will return <code>true</code> during a test run. This is useful to disable things causing flakiness, such as JavaScript animations or GIFs that aren't automatically disabled by loki.</li> </ul> <h2>0.21.0</h2> <h2>Breaking changes</h2> <ul> <li>Improve getSelectorBoxSize to find fixed & absolute elements. This is a bug fix, but will alter the cropping of some stories, especially those using fixed and absolute elements.</li> </ul> <h2>Bug fixes</h2> <ul> <li>Listen to requests until selector is present, fixes flakiness with fonts for slow components/big bundles</li> <li>Make blinking input carets transparent to avoid flakiness</li> </ul> <h2>0.20.2</h2> <ul> <li>Add compatibility with Storybook 5 in <code>loki init</code> command</li> <li>Pass through third <code>storiesOf</code> param</li> <li>Disable pointer events to combat unintended <code>:hover</code> styles</li> <li>Add loki command alias to entry package for <code>yarn add global</code> support</li> <li>Wait between retries when launching stories tab to combat flakiness in Circle CI</li> </ul> <h2>0.20.1</h2> <h2>Bug fixes</h2> <ul> <li>Fix bug where <code>looks-same</code> differ would not properly detect changes.</li> </ul> <h2>0.20.0</h2> <h2>New features</h2> <ul> <li>New <code>fileNameFormatter</code> config enabling any custom file format of snapshot files.</li> <li>Support separate configuration file, as <code>.lokirc</code> or <code>loki.config.js</code>.</li> </ul> <h2>Bug fixes</h2> <ul> <li>Fix bad file reference in <code>react-native</code> integration</li> </ul> <h2>0.19.1</h2> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/oblador/loki/commit/d3e785830d395319e61d8f824215d86f439c995c"><code>d3e7858</code></a> v0.25.1</li> <li><a href="https://github.com/oblador/loki/commit/6c88b9c3d9f3e9d7faa83ac8681df398994d47b5"><code>6c88b9c</code></a> v0.25.0</li> <li><a href="https://github.com/oblador/loki/commit/ed0d902e2c13a913d28b6c97fb360742385f6073"><code>ed0d902</code></a> Add maintainers section to README (<a href="https://github.com/oblador/loki/tree/HEAD/packages/loki/issues/259">#259</a>)</li> <li><a href="https://github.com/oblador/loki/commit/ae70705a46e834d34f15862faa74dfc35f3a28c0"><code>ae70705</code></a> v0.24.0</li> <li><a href="https://github.com/oblador/loki/commit/77bbcf3ef7aac4b65ef54a270077766ac4274a33"><code>77bbcf3</code></a> Use show test badge from github actions</li> <li><a href="https://github.com/oblador/loki/commit/77b117d9b8d92756a7be6085eaae967ba9c4531c"><code>77b117d</code></a> Remove version in node requirement (<a href="https://github.com/oblador/loki/tree/HEAD/packages/loki/issues/257">#257</a>)</li> <li><a href="https://github.com/oblador/loki/commit/510fd0501e27efde006d906b60a0cf1e41c49015"><code>510fd05</code></a> v0.23.0</li> <li><a href="https://github.com/oblador/loki/commit/69ca523e0c2384b342c1682ac79e0ab4c1699ee1"><code>69ca523</code></a> v0.22.1</li> <li><a href="https://github.com/oblador/loki/commit/0afc976871107720e6eddcf70f5a582a9dc958b0"><code>0afc976</code></a> v0.22.0</li> <li><a href="https://github.com/oblador/loki/commit/c7429d38b5155d825994ca0cde445c1009b1a9f3"><code>c7429d3</code></a> v0.21.1</li> <li>Additional commits viewable in <a href="https://github.com/oblador/loki/commits/v0.25.1/packages/loki">compare view</a></li> </ul> </details> <br />
You can trigger a rebase of this PR by commenting @dependabot rebase.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in the .dependabot/config.yml file in this repo:
- Update frequency
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
</details><br/><br/><br/><url>LiveURL: https://orbit-dependabot-npm-and-yarn-loki-0-25-1.surge.sh</url>
pr closed time in 5 hours
PR opened kiwicom/orbit
- bump Loki – new version of Loki has a much better output and it appears to be faster
- update visual references – I carefully updated them to remove code blocks and check for visual regressions, so now everything is good
- add missing references – let's hope this works out now for everyone 🤞
- add npm scripts to make testing easier
- remove unused
dotenvdependency (unrelated)
We should probably switch to Git LFS or something, I've never used it, though.
pr created time in 6 hours
issue commentkiwicom/orbit
Make the ESLint config more DRY
That's true, it's kinda standalone currently, but try applying to it everything that isn't specifically Flow-related so we see what happens. When we start adding TypeScript files at some point in the future, we want to have the same ESLint support as we did for Flow files.
comment created time in 11 hours
Pull request review commentkiwicom/orbit
feat(Box): Introducing Box component
+// @flow+import theme from "../defaultTheme";++export const DISPLAY = ["none", "flex", "inline-flex", "block", "inline", "inline-block"];++export const WRAP = ["wrap", "nowrap"];++export const DIRECTION = ["row", "column", "row-reverse", "column-reverse"];++export const SHRINK = [0, 1];++export const GROW = [0, 1];++export const WIDTH_AND_HEIGHT = {+ FULL: "full",+ AUTO: "auto",+};++export const POSITION = ["absolute", "relative", "fixed"];++export const ALIGN = ["start", "end", "center", "stretch"];++export const JUSTIFY = ["center", "start", "end", "between", "around"];++export const TEXT_ALIGN = ["left", "right", "center"];++// TODO: "suppressed", "flat"+export const ELEVATION = ["action", "fixed", "raised", "overlay"];++export const BORDER_RADIUS = ["small", "normal", "large", "radiusCircle"];++export const OVERFLOW = ["auto", "hidden", "scroll", "visible"];++export const COLORS = [+ "productLight",+ "productLightHover",+ "productLightActive",+ "productNormal",+ "productNormalHover",+ "productNormalActive",+ "productDark",+ "productDarkHover",+ "productDarkActive",+ "productDarker",+ "white",+ "whiteHover",+ "whiteActive",+ "cloudLight",+ "cloudLightHover",+ "cloudLightActive",+ "cloudNormal",+ "cloudNormalHover",+ "cloudNormalActive",+ "cloudDark",+ "inkLighter",+ "inkLighterHover",+ "inkLighterActive",+ "inkLight",+ "inkLightHover",+ "inkLightActive",+ "inkNormal",+ "inkNormalHover",+ "inkNormalActive",+ "orangeLight",+ "orangeLightHover",+ "orangeLightActive",+ "orangeNormal",+ "orangeNormalHover",+ "orangeNormalActive",+ "orangeDark",+ "orangeDarkHover",+ "orangeDarkActive",+ "orangeDarker",+ "redLight",+ "redLightHover",+ "redLightActive",+ "redNormal",+ "redNormalHover",+ "redNormalActive",+ "redDark",+ "redDarkHover",+ "redDarkActive",+ "redDarker",+ "greenLight",+ "greenLightHover",+ "greenLightActive",+ "greenNormal",+ "greenNormalHover",+ "greenNormalActive",+ "greenDark",+ "greenDarkHover",+ "greenDarkActive",+ "greenDarker",+ "blueLight",+ "blueLightHover",+ "blueLightActive",+ "blueNormal",+ "blueNormalHover",+ "blueNormalActive",+ "blueDark",+ "blueDarkHover",+ "blueDarkActive",+ "blueDarker",+ "socialFacebook",+ "socialFacebookHover",+ "socialFacebookActive",+];++export const SPACINGS = [+ "none",+ "xx-small",+ "x-small",+ "small",+ "medium",+ "large",+ "x-large",+ "xx-large",+ "xxx-large",+];++export const TOKENS = {+ none: null,+ "xx-small": theme.orbit.spaceXXSmall,+ "x-small": theme.orbit.spaceXSmall,+ small: theme.orbit.spaceSmall,+ medium: theme.orbit.spaceMedium,+ large: theme.orbit.spaceLarge,+ "x-large": theme.orbit.spaceXLarge,+ "xx-large": theme.orbit.spaceXLarge,+ "xxx-large": theme.orbit.spaceXLarge,
Same as Inline. Considering that we have larger tokens, maybe we can just use those? Or maybe it will set off some kind of bomb, only Filip knows the reason behind this 😅
comment created time in 12 hours
Pull request review commentkiwicom/orbit
feat(Box): Introducing Box component
+// @flow+import * as React from "react";+import { storiesOf } from "@storybook/react";+import { text, select, object } from "@storybook/addon-knobs";++import RenderInRtl from "../utils/rtl/RenderInRtl";+import {+ DISPLAY,+ WRAP,+ SHRINK,+ GROW,+ OVERFLOW,+ COLORS,+ DIRECTION,+ ALIGN,+ SPACINGS,+ TEXT_ALIGN,+ JUSTIFY,+ WIDTH_AND_HEIGHT,+ ELEVATION,+ BORDER_RADIUS,+ POSITION,+} from "./consts";++import Box from "./index";++const DEFAULT_COLOR = "blueDark";++storiesOf("Box", module)+ .add(+ "Default",+ () => {+ const children = text("Children", "Default box");+ const as = text("As", "span");+ return <Box as={as}>{children}</Box>;+ },+ {+ info:+ "This is the default configuration of this component. Visit Orbit.Kiwi for more detailed guidelines.",+ },+ )+ .add("Overflow", () => {+ const overflow = select("overflow", OVERFLOW, OVERFLOW[0]);++ return (+ <Box+ background={DEFAULT_COLOR}+ overflow={overflow}+ color="cloudLight"+ padding="large"+ maxWidth="300px"+ >+ Text
Best to wrap text content in all of these stories in the Text component, just to get rid of that nasty Times New Roman.
comment created time in 12 hours
Pull request review commentkiwicom/orbit
feat(Box): Introducing Box component
+// @flow+import React from "react";+import { screen, render } from "@testing-library/react";+import convertHexToRgba from "@kiwicom/orbit-design-tokens/lib/convertHexToRgba";++import theme from "../../defaultTheme";+import {+ TOKENS,+ DIRECTION as DIRECTIONS,+ POSITION as POSITIONS,+ JUSTIFY,+ ALIGN,+ TEXT_ALIGN,+ ELEVATION,+} from "../consts";+import Box from "..";++const dataTest = "test";++describe("#Box", () => {+ it("should have basic props", () => {+ render(+ <Box+ dataTest={dataTest}+ color="blueDark"+ padding="medium"+ margin="medium"+ maxWidth="300px"+ maxHeight="100px"+ display="block"+ background="cloudLight"+ >+ kek+ </Box>,+ );++ const el = screen.getByTestId(dataTest);+ const style = getComputedStyle(el);+ const getOmiitedHex = hex =>
Spelling:
const getOmitted = hex =>
comment created time in 12 hours
Pull request review commentkiwicom/orbit
feat(Box): Introducing Box component
+// @flow+import React from "react";+import { screen, render } from "@testing-library/react";+import convertHexToRgba from "@kiwicom/orbit-design-tokens/lib/convertHexToRgba";++import theme from "../../defaultTheme";+import {+ TOKENS,+ DIRECTION as DIRECTIONS,+ POSITION as POSITIONS,+ JUSTIFY,+ ALIGN,+ TEXT_ALIGN,+ ELEVATION,+} from "../consts";+import Box from "..";++const dataTest = "test";++describe("#Box", () => {+ it("should have basic props", () => {+ render(+ <Box+ dataTest={dataTest}+ color="blueDark"+ padding="medium"+ margin="medium"+ maxWidth="300px"+ maxHeight="100px"+ display="block"+ background="cloudLight"+ >+ kek+ </Box>,+ );++ const el = screen.getByTestId(dataTest);+ const style = getComputedStyle(el);+ const getOmiitedHex = hex =>+ convertHexToRgba(hex, NaN).replace(", NaN", "").replace("rgba", "rgb");++ expect(el).toBeInTheDocument();+ expect(style).toHaveProperty("color", getOmiitedHex(theme.orbit.paletteBlueDark));+ expect(style).toHaveProperty("background", getOmiitedHex(theme.orbit.paletteCloudLight));+ expect(style).toHaveProperty("padding", TOKENS.medium);+ expect(style).toHaveProperty("margin", TOKENS.medium);+ expect(style).toHaveProperty("display", "block");+ expect(style).toHaveProperty("max-width", "300px");+ expect(style).toHaveProperty("max-height", "100px");
Instead of fetching getComponentStyle and checking for properties, you can also use toHaveStyle. In this case I recommend the object syntax:
expect(el).toHaveStyle({ color: getOmitted(theme.orbit.paletteBlueDark) })
Same thing, basically, but reads better.
comment created time in 12 hours
Pull request review commentkiwicom/orbit
+// @flow+import { left } from "../utils/rtl";+import type { Theme, ThemeProps } from "../defaultTheme";++import type { SpacingToken, Position } from "./index";++type Prop = "align" | "justify" | "spacing";++export const formatCSS = (key: string, value: string): string => `${key}: ${value};`;++const getAlign = align => {+ if (align === "start") return "flex-start";+ if (align === "end") return "flex-end";++ return "center";+};++export const normalizeSpacing = (el: SpacingToken, theme: Theme): string => {+ const tokens = {+ none: "",+ "xx-small": theme.orbit.spaceXXSmall,+ "x-small": theme.orbit.spaceXSmall,+ small: theme.orbit.spaceSmall,+ medium: theme.orbit.spaceMedium,+ large: theme.orbit.spaceLarge,+ "x-large": theme.orbit.spaceXLarge,+ "xx-large": theme.orbit.spaceXLarge,+ "xxx-large": theme.orbit.spaceXLarge,
Also, just to point out that these three sizes are mapped to the same token.
comment created time in 12 hours
Pull request review commentkiwicom/orbit
+// @flow+import * as React from "react";+import { storiesOf } from "@storybook/react";+import { text, select } from "@storybook/addon-knobs";++import RenderInRtl from "../utils/rtl/RenderInRtl";+import { ALIGN, JUSTIFY, SPACING } from "./consts";++import Inline from "./index";++const PlaceHolder = () => {+ return <div style={{ width: "50px", height: "50px", background: "grey" }} />;+};++const dataTest = "test";++const TestChildren = () => {+ return (+ <>+ <PlaceHolder />+ <PlaceHolder />+ <PlaceHolder />+ <PlaceHolder />+ <PlaceHolder />+ <PlaceHolder />+ </>+ );+};++storiesOf("Inline", module)+ .add(+ "Default",+ () => {+ const spacing = select("spacing", SPACING, SPACING[1]);+ return (+ <Inline spacing={spacing} dataTest={dataTest}>+ <TestChildren />+ </Inline>+ );+ },+ {+ info:+ "This is the default configuration of this component. Visit Orbit.Kiwi for more detailed guidelines.",+ },+ )+ .add(+ "Playground",+ () => {+ const as = text("As", "div");+ const align = select("align", ALIGN, ALIGN[0]);+ const justify = select("justify", JUSTIFY, JUSTIFY[0]);+ const spacing = select("spacing", SPACING, SPACING[1]);++ return (+ <Inline as={as} align={align} justify={justify} dataTest={dataTest} spacing={spacing}>+ <TestChildren />+ </Inline>+ );+ },+ {+ info: "Some description about this type of component. ",
This looks like a placeholder, you can copy the description used by some components:
info: "You can try all possible configurations of this component. However, check Orbit.Kiwi for more detailed design guidelines.",
comment created time in 13 hours
push eventkiwicom/orbit
commit sha 8172f9150ddaf657d13595bbe1bbaf0419619635
improve: add complete script for publishing (#2395)
push time in a day
PR merged kiwicom/orbit
Complete release workflow:
- create
.envfile withGH_TOKEN(only once) - create PR with fixed Loki tests
- run
yarn publish-packages(publishis reserved), this will do everything, includinggit pushI believe<br/><br/><br/><url>LiveURL: https://orbit-improve-release-script.surge.sh</url>
pr closed time in a day
push eventkiwicom/orbit
commit sha 9d4c7d1af63735d652440cf0c9003e834e4b4fc5
feat(Loki): skip code blocks (#2389) closes #2346
commit sha 9d7d8991a331ca588c567c778a196b4994f23b4b
refactor(Storybook): hide Code with yarn dev:test (#2394) closes #2346 related to #2389
commit sha 8724b37bbd1082141a806e15eece92de4607ece3
improve: add complete script for publishing
push time in a day
push eventkiwicom/orbit
commit sha 9d7d8991a331ca588c567c778a196b4994f23b4b
refactor(Storybook): hide Code with yarn dev:test (#2394) closes #2346 related to #2389
push time in a day
PR merged kiwicom/orbit
closes #2346 (again)
related to #2389
This Pull Request meets the following criteria:
- [x] Tests have been added/adjusted for my new feature
- [x] New Components are registered in index.js of my project <br/><br/><br/><url>LiveURL: https://orbit-sampi-fix-2346.surge.sh</url>
pr closed time in a day
pull request commentkiwicom/orbit
chore: switch to native Dependabot
@vepor removed yarn autoclean, it's a good thing you noticed!
comment created time in a day
push eventkiwicom/orbit
commit sha 4fa9617f3595dba99f0d9c6a24ddc569ea8b3f10
chore: remove autoclean
push time in a day
push eventkiwicom/orbit
commit sha 09a00447a47e8191ddf793e3b35f17d74ebbd774
chore: don't log anything if checking icons passed This all happens under the hood, people should only be aware of it if something is wrong.
commit sha a940eaf17d558503a5e1dbe6d68b0b9c8e6a2125
chore: check icons only on pre-commit and CI
commit sha a6542de35755a9e1ae2d8e9a6e40865cc6f4e8b4
chore: fix clashing types in TypeScript A .yarnclean file tells Yarn to make sure to delete `@types/react-native` every time dependencies are installed. https://classic.yarnpkg.com/en/docs/cli/autoclean/ https://github.com/DefinitelyTyped/DefinitelyTyped/issues/33311#issuecomment-494477593
commit sha d7f124176f65b639a4955ff159118517bc4ac643
chore: simplify TypeScript configuration
commit sha e7abe2d2504fe3dd356c9dcc91c46deb3fa73aea
ci: start type checking with TypeScript
commit sha c8c3909b753e64b04589bf5d6cfdd6e82b0cb974
chore: move devDependencies to root (#2385) closes #2384 * ran `lerna link convert` * manually checked that all dependencies are still available * modified `eslintJS.js` to look for `devDependencies` in the root `package.json` as well
commit sha 5ced2edb4ce88256e8294c4a5fbc90444c0f1cec
improve(TextLink): add codemod for `iconRight` (#2380)
commit sha 1f7e1c9783e8facc85067ece5f09bc668af0c50e
Merge branch 'master' into chore/dependabot-v2
push time in a day
push eventkiwicom/orbit
commit sha eb7cb95e0401bce290fc2d28ca487894c7708cba
improve(TextLink): add codemod for `iconRight`
push time in a day
push eventkiwicom/orbit
commit sha b69978a955fe33c2be67e93185fd38def2837054
improve(TextLink): add codemod for `iconRight`
push time in a day
startedelastic/eui
started time in a day
push eventkiwicom/orbit
commit sha a6542de35755a9e1ae2d8e9a6e40865cc6f4e8b4
chore: fix clashing types in TypeScript A .yarnclean file tells Yarn to make sure to delete `@types/react-native` every time dependencies are installed. https://classic.yarnpkg.com/en/docs/cli/autoclean/ https://github.com/DefinitelyTyped/DefinitelyTyped/issues/33311#issuecomment-494477593
commit sha d7f124176f65b639a4955ff159118517bc4ac643
chore: simplify TypeScript configuration
commit sha e7abe2d2504fe3dd356c9dcc91c46deb3fa73aea
ci: start type checking with TypeScript
push time in 2 days
PR merged kiwicom/orbit
- chore: fix clashing types in TypeScript
- chore: simplify TypeScript configuration
- ci: start type checking with TypeScript <br/><br/><br/><url>LiveURL: https://orbit-test-typescript.surge.sh</url>
pr closed time in 2 days
pull request commentkiwicom/orbit
Fix TypeScript checking and include it in CI
Just rebased to fix conflicts.
comment created time in 2 days
Pull request review commentgulpjs/gulp
Docs: Add recipe for static asset revisioning
+# Sass and Nunjucks with static asset revisioning++Static asset revisioning by appending content hash to filenames. Make sure to set the files to [never expire](http://developer.yahoo.com/performance/rules.html#expires) for this to have an effect.++Sass and Nunjucks are here just to demonstrate how to implement static asset revisioning in a more real-world scenario. The content has will be appended in production, so it's recommended to add the following npm scripts to `package.json`:++```json+{+ "scripts": {+ "dev": "gulp-dev",+ "build": "NODE_ENV=production gulp build"+ }+}+```++Now to install the required dependencies:++```sh+npm install --save-dev gulp gulp-rev gulp-rev-rewrite gulp-sass gulp-nunjucks gulp-if del+```++And, finally, `gulpfile.js`:++```js+const gulp = require('gulp')+const sass = require('gulp-sass')+const nunjucks = require('gulp-nunjucks')+const rev = require('gulp-rev')+const revRewrite = require('gulp-rev-rewrite')+const gulpIf = require('gulp-if')+const del = require('del')++const isProd = process.env.NODE_ENV === 'production'++function clean() {+ return del('dist')+}
Oh… I thought that if an old version is being loaded, then static revisioning isn't set up correctly because the cache was supposed to be busted. That's a terrifying idea to me as an author that someone loads an old CSS or JS file, I guess things will break for them either way? 🤔
This clean task was not only for deleting old assets, but deleting old anything. Old pages etc. I want a 404 page to appear when a page has been deleted. But I'll remove this task since we're focusing on revisioning only here.
comment created time in 2 days
Pull request review commentgulpjs/gulp
Docs: Add recipe for static asset revisioning
+# Sass and Nunjucks with static asset revisioning++Static asset revisioning by appending content hash to filenames. Make sure to set the files to [never expire](http://developer.yahoo.com/performance/rules.html#expires) for this to have an effect.++Sass and Nunjucks are here just to demonstrate how to implement static asset revisioning in a more real-world scenario. The content has will be appended in production, so it's recommended to add the following npm scripts to `package.json`:++```json+{+ "scripts": {+ "dev": "gulp-dev",+ "build": "NODE_ENV=production gulp build"+ }+}+```++Now to install the required dependencies:++```sh+npm install --save-dev gulp gulp-rev gulp-rev-rewrite gulp-sass gulp-nunjucks gulp-if del+```++And, finally, `gulpfile.js`:++```js+const gulp = require('gulp')+const sass = require('gulp-sass')+const nunjucks = require('gulp-nunjucks')+const rev = require('gulp-rev')+const revRewrite = require('gulp-rev-rewrite')+const gulpIf = require('gulp-if')+const del = require('del')++const isProd = process.env.NODE_ENV === 'production'++function clean() {+ return del('dist')+}++function styles() {+ return gulp+ .src('styles/style.scss')+ .pipe(sass().on('error', sass.logError))
I would like to avoid this, too, but, as I said, I need help. 🙏
comment created time in 2 days
Pull request review commentgulpjs/gulp
Docs: Add recipe for static asset revisioning
+# Sass and Nunjucks with static asset revisioning++Static asset revisioning by appending content hash to filenames. Make sure to set the files to [never expire](http://developer.yahoo.com/performance/rules.html#expires) for this to have an effect.++Sass and Nunjucks are here just to demonstrate how to implement static asset revisioning in a more real-world scenario. The content has will be appended in production, so it's recommended to add the following npm scripts to `package.json`:++```json+{+ "scripts": {+ "dev": "gulp-dev",+ "build": "NODE_ENV=production gulp build"+ }+}+```++Now to install the required dependencies:++```sh+npm install --save-dev gulp gulp-rev gulp-rev-rewrite gulp-sass gulp-nunjucks gulp-if del+```++And, finally, `gulpfile.js`:++```js+const gulp = require('gulp')+const sass = require('gulp-sass')+const nunjucks = require('gulp-nunjucks')+const rev = require('gulp-rev')+const revRewrite = require('gulp-rev-rewrite')+const gulpIf = require('gulp-if')+const del = require('del')++const isProd = process.env.NODE_ENV === 'production'++function clean() {+ return del('dist')+}++function styles() {+ return gulp+ .src('styles/style.scss')+ .pipe(sass().on('error', sass.logError))+ // appends the content hash+ .pipe(gulpIf(isProd, rev()))+ .pipe(gulp.dest('dist'))+ // output rev-manifest.json+ .pipe(gulpIf(isProd, rev.manifest()))+ .pipe(gulp.dest('dist'))+}++function views() {+ const manifest = gulp.src(+ 'dist/rev-manifest.json',+ // in development the manifest doesn't exist+ { allowEmpty: !isProd }+ )+ return gulp+ .src('views/**/*.njk')+ .pipe(nunjucks.compile({ title: 'Hello world!' }))+ // this updates the reference(s) to revisioned assets+ .pipe(gulpIf(isProd, revRewrite({ manifest })))+ .pipe(gulp.dest('dist'))+}++function watch() {
Also, nothing happens because I forgot to add tasks to them, so they are completely useless 😆
comment created time in 2 days
Pull request review commentgulpjs/gulp
Docs: Add recipe for static asset revisioning
+# Sass and Nunjucks with static asset revisioning++Static asset revisioning by appending content hash to filenames. Make sure to set the files to [never expire](http://developer.yahoo.com/performance/rules.html#expires) for this to have an effect.++Sass and Nunjucks are here just to demonstrate how to implement static asset revisioning in a more real-world scenario. The content has will be appended in production, so it's recommended to add the following npm scripts to `package.json`:++```json+{+ "scripts": {+ "dev": "gulp-dev",+ "build": "NODE_ENV=production gulp build"+ }+}+```++Now to install the required dependencies:++```sh+npm install --save-dev gulp gulp-rev gulp-rev-rewrite gulp-sass gulp-nunjucks gulp-if del+```++And, finally, `gulpfile.js`:++```js+const gulp = require('gulp')+const sass = require('gulp-sass')+const nunjucks = require('gulp-nunjucks')+const rev = require('gulp-rev')+const revRewrite = require('gulp-rev-rewrite')+const gulpIf = require('gulp-if')+const del = require('del')++const isProd = process.env.NODE_ENV === 'production'++function clean() {+ return del('dist')+}++function styles() {+ return gulp+ .src('styles/style.scss')+ .pipe(sass().on('error', sass.logError))+ // appends the content hash+ .pipe(gulpIf(isProd, rev()))+ .pipe(gulp.dest('dist'))+ // output rev-manifest.json+ .pipe(gulpIf(isProd, rev.manifest()))+ .pipe(gulp.dest('dist'))+}++function views() {+ const manifest = gulp.src(+ 'dist/rev-manifest.json',+ // in development the manifest doesn't exist+ { allowEmpty: !isProd }+ )+ return gulp+ .src('views/**/*.njk')+ .pipe(nunjucks.compile({ title: 'Hello world!' }))+ // this updates the reference(s) to revisioned assets+ .pipe(gulpIf(isProd, revRewrite({ manifest })))
Ok, I'll give it a shot.
comment created time in 2 days
Pull request review commentgulpjs/gulp
Docs: Add recipe for static asset revisioning
+# Sass and Nunjucks with static asset revisioning++Static asset revisioning by appending content hash to filenames. Make sure to set the files to [never expire](http://developer.yahoo.com/performance/rules.html#expires) for this to have an effect.++Sass and Nunjucks are here just to demonstrate how to implement static asset revisioning in a more real-world scenario. The content has will be appended in production, so it's recommended to add the following npm scripts to `package.json`:++```json+{+ "scripts": {+ "dev": "gulp-dev",+ "build": "NODE_ENV=production gulp build"+ }+}+```++Now to install the required dependencies:++```sh+npm install --save-dev gulp gulp-rev gulp-rev-rewrite gulp-sass gulp-nunjucks gulp-if del+```++And, finally, `gulpfile.js`:++```js+const gulp = require('gulp')+const sass = require('gulp-sass')+const nunjucks = require('gulp-nunjucks')+const rev = require('gulp-rev')+const revRewrite = require('gulp-rev-rewrite')+const gulpIf = require('gulp-if')+const del = require('del')++const isProd = process.env.NODE_ENV === 'production'++function clean() {+ return del('dist')+}++function styles() {+ return gulp+ .src('styles/style.scss')+ .pipe(sass().on('error', sass.logError))+ // appends the content hash+ .pipe(gulpIf(isProd, rev()))+ .pipe(gulp.dest('dist'))+ // output rev-manifest.json+ .pipe(gulpIf(isProd, rev.manifest()))+ .pipe(gulp.dest('dist'))+}++function views() {+ const manifest = gulp.src(+ 'dist/rev-manifest.json',+ // in development the manifest doesn't exist+ { allowEmpty: !isProd }+ )+ return gulp+ .src('views/**/*.njk')+ .pipe(nunjucks.compile({ title: 'Hello world!' }))+ // this updates the reference(s) to revisioned assets+ .pipe(gulpIf(isProd, revRewrite({ manifest })))+ .pipe(gulp.dest('dist'))+}++function watch() {+ gulp.watch('styles/**/*.scss')+ gulp.watch('views/**/*.njk')+}++// after everything is done, we no longer need the manifest file+function deleteRevManifest() {+ return del('dist/rev-manifest.json')+}++exports.dev = gulp.series(clean, gulp.parallel(styles, views), watch)
If we're removing watching (which I will), then it doesn't.
comment created time in 2 days
Pull request review commentgulpjs/gulp
Docs: Add recipe for static asset revisioning
+# Sass and Nunjucks with static asset revisioning++Static asset revisioning by appending content hash to filenames. Make sure to set the files to [never expire](http://developer.yahoo.com/performance/rules.html#expires) for this to have an effect.++Sass and Nunjucks are here just to demonstrate how to implement static asset revisioning in a more real-world scenario. The content has will be appended in production, so it's recommended to add the following npm scripts to `package.json`:++```json+{+ "scripts": {+ "dev": "gulp-dev",+ "build": "NODE_ENV=production gulp build"+ }+}+```++Now to install the required dependencies:++```sh+npm install --save-dev gulp gulp-rev gulp-rev-rewrite gulp-sass gulp-nunjucks gulp-if del+```++And, finally, `gulpfile.js`:++```js+const gulp = require('gulp')+const sass = require('gulp-sass')+const nunjucks = require('gulp-nunjucks')+const rev = require('gulp-rev')+const revRewrite = require('gulp-rev-rewrite')+const gulpIf = require('gulp-if')+const del = require('del')++const isProd = process.env.NODE_ENV === 'production'++function clean() {+ return del('dist')+}++function styles() {+ return gulp
Could you be more specific? I never used it before.
comment created time in 2 days
push eventkiwicom/orbit
commit sha 09a00447a47e8191ddf793e3b35f17d74ebbd774
chore: don't log anything if checking icons passed This all happens under the hood, people should only be aware of it if something is wrong.
commit sha a940eaf17d558503a5e1dbe6d68b0b9c8e6a2125
chore: check icons only on pre-commit and CI
commit sha 255493ce48b4357f70e16af7b9cd2b56895be4c3
chore: fix clashing types in TypeScript A .yarnclean file tells Yarn to make sure to delete `@types/react-native` every time dependencies are installed. https://classic.yarnpkg.com/en/docs/cli/autoclean/ https://github.com/DefinitelyTyped/DefinitelyTyped/issues/33311#issuecomment-494477593
commit sha a542898440724c4020e03feb51f5a939e21660a8
chore: simplify TypeScript configuration
commit sha af4c3ea33e038d2dca798623f9b268c4c805abf2
ci: start type checking with TypeScript
push time in 2 days
push eventkiwicom/orbit
commit sha 09a00447a47e8191ddf793e3b35f17d74ebbd774
chore: don't log anything if checking icons passed This all happens under the hood, people should only be aware of it if something is wrong.
commit sha a940eaf17d558503a5e1dbe6d68b0b9c8e6a2125
chore: check icons only on pre-commit and CI
push time in 2 days
PR merged kiwicom/orbit
<br/><br/><br/><url>LiveURL: https://orbit-improve-check-icons-cli.surge.sh</url>
pr closed time in 2 days
PR opened kiwicom/orbit
This Pull Request meets the following criteria:
- [ ] Tests have been added/adjusted for my new feature
- [ ] New Components are registered in index.js of my project
pr created time in 2 days
pull request commentkiwicom/orbit
Fix TypeScript checking and include it in CI
I figured it out! 🚀 I needed to add .yarnclean to hash files because CI should rebuild dependencies when contents of .yarnclean change. CI was failing simply because yarn install didn't run, so @types/react-native was still there.
comment created time in 2 days
push eventkiwicom/orbit
commit sha 22eccd0d8cf49143b0d6b4f8d34e67e327c05ed3
chore: fix clashing types in TypeScript A .yarnclean file tells Yarn to make sure to delete `@types/react-native` every time dependencies are installed. https://classic.yarnpkg.com/en/docs/cli/autoclean/ https://github.com/DefinitelyTyped/DefinitelyTyped/issues/33311#issuecomment-494477593
commit sha 85bf8ea437b64125c07f7a6bd72815eaed7793c8
chore: simplify TypeScript configuration
commit sha 212ce0a61252cc17a7c5c9bff42276732282151e
ci: start type checking with TypeScript
push time in 2 days
pull request commentkiwicom/orbit
chore: switch to native Dependabot
If you agree, I the old Dependabot needs to be disabled in the web app.
comment created time in 2 days
push eventkiwicom/orbit
commit sha 238fc92013f12e10b95ab977c848a54ed2b5d705
chore: fix clashing types in TypeScript A .yarnclean file tells Yarn to make sure to delete `@types/react-native` every time dependencies are installed. https://classic.yarnpkg.com/en/docs/cli/autoclean/ https://github.com/DefinitelyTyped/DefinitelyTyped/issues/33311#issuecomment-494477593
commit sha 1d9887f36c3bff4f4c197fcb636062a0569b520e
chore: simplify TypeScript configuration
commit sha 2d5543b371dd3a4a5b1b6d8517e27c3ff0d1192f
ci: start type checking with TypeScript
push time in 2 days
pull request commentkiwicom/orbit
Fix TypeScript checking and include it in CI
Damnit, for some reason .yarnclean doesn't automatically trigger Yarn, I had to run yarn autoclean --force the first time, then it started doing it on its own.
comment created time in 2 days
pull request commentkiwicom/orbit
Fix TypeScript checking and include it in CI
Make sure to rebase, not squash, if you're merging.
comment created time in 2 days
PR opened kiwicom/orbit
- chore: fix clashing types in TypeScript
- chore: simplify TypeScript configuration
- ci: start type checking with TypeScript
pr created time in 2 days
push eventkiwicom/orbit
commit sha d9232794e2f48c7b208b477f23caa1a48bda7c4a
chore: fix clashing types in TypeScript A .yarnclean file tells Yarn to make sure to delete `@types/react-native` every time dependencies are installed. https://classic.yarnpkg.com/en/docs/cli/autoclean/ https://github.com/DefinitelyTyped/DefinitelyTyped/issues/33311#issuecomment-494477593
commit sha fe45c812fc8dfd38aa9f3e01da1de54b35f82747
chore: simplify TypeScript configuration
commit sha e9fb35b1a80c5041e5949166b4ace5aa71bace27
ci: start type checking with TypeScript
push time in 2 days
push eventkiwicom/orbit
commit sha 30fb099f0a5d27d68416d84c1ba5b23a80e9b59a
chore: bump typescript from 3.9.7 to 4.0.3 (#2253) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.9.7 to 4.0.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v3.9.7...v4.0.3) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
push time in 2 days
delete branch kiwicom/orbit
delete branch : dependabot/npm_and_yarn/typescript-4.0.3
delete time in 2 days
PR merged kiwicom/orbit
Bumps typescript from 3.9.7 to 4.0.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Microsoft/TypeScript/releases">typescript's releases</a>.</em></p> <blockquote> <h2>TypeScript 4.0.3</h2> <p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/">release announcement</a>.</p> <p>For the complete list of fixed issues, check out the</p> <ul> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.0.0%22+is%3Aclosed+">fixed issues query for TypeScript v4.0.0 (Beta)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.0.1%22+is%3Aclosed+">fixed issues query for TypeScript v4.0.1 (RC)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.0.2%22+is%3Aclosed+">fixed issues query for TypeScript v4.0.2</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=milestone%3A%22TypeScript+4.0.3%22+is%3Aclosed+">fixed issues query for TypeScript v4.0.3</a>.</li> </ul> <p>Downloads are available on:</p> <ul> <li><a href="https://www.npmjs.com/package/typescript">npm</a></li> <li><a href="https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-40">Visual Studio 2017/2019</a> (<a href="https://github.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017">Select new version in project options</a>)</li> <li><a href="https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild">NuGet package</a></li> </ul> <h2>TypeScript 4.0</h2> <p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/">release announcement</a>.</p> <p>For the complete list of fixed issues, check out the</p> <ul> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.0.0%22+is%3Aclosed+">fixed issues query for TypeScript v4.0.0 (Beta)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.0.1%22+is%3Aclosed+">fixed issues query for TypeScript v4.0.1 (RC)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.0.2%22+is%3Aclosed+">fixed issues query for TypeScript v4.0.2</a>.</li> </ul> <p>Downloads are available on:</p> <ul> <li><a href="https://www.npmjs.com/package/typescript">npm</a></li> <li><a href="https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-40">Visual Studio 2017/2019</a> (<a href="https://github.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017">Select new version in project options</a>)</li> <li><a href="https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild">NuGet package</a></li> </ul> <h2>TypeScript 4.0 Beta</h2> <p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-4-0-beta/">release announcement</a>.</p> <p>For the complete list of fixed issues, check out the</p> <ul> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+4.0%22+is%3Aclosed+">fixed issues query for Typescript v4.0-beta</a>.</li> </ul> <p>Downloads are available on:</p> <ul> <li><a href="https://www.npmjs.com/package/typescript">npm</a></li> <li><a href="https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.TypeScript-40beta">Visual Studio 2017/2019</a> (<a href="https://github.com/Microsoft/TypeScript/wiki/Updating-TypeScript-in-Visual-Studio-2017">Select new version in project options</a>)</li> <li><a href="https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild">NuGet package</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/TypeScript/commit/fee3bfbe91b7582f42e2f49814b87353f67e63f4"><code>fee3bfb</code></a> Bump version to 4.0.3 and LKG</li> <li><a href="https://github.com/microsoft/TypeScript/commit/2eb5deae4bafe169ec1d2ecf66999003574164bb"><code>2eb5dea</code></a> Update LKG</li> <li><a href="https://github.com/microsoft/TypeScript/commit/1dde4bbe4ebc7fb210bf124b9590a82573a49806"><code>1dde4bb</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/40595">#40595</a> from typescript-bot/pick/39924/release-4.0</li> <li><a href="https://github.com/microsoft/TypeScript/commit/23c77c4e329ee3a27c4dfe7d9f6905aca12281b0"><code>23c77c4</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/40444">#40444</a> from amcasey/Cherry40043</li> <li><a href="https://github.com/microsoft/TypeScript/commit/e3301f7294c759be4141f4a49b691fe2614f93ef"><code>e3301f7</code></a> Cherry-pick PR <a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/39924">#39924</a> into release-4.0</li> <li><a href="https://github.com/microsoft/TypeScript/commit/65b84e707e118b802ad41ca164debd15f4915a95"><code>65b84e7</code></a> Cherry-pick PR <a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/40273">#40273</a> into release-4.0 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/40303">#40303</a>)</li> <li><a href="https://github.com/microsoft/TypeScript/commit/657576ae7c9da142bdbbe43e64d425fa292124fe"><code>657576a</code></a> Set stackTraceLimit to 0 in fileSystemEntryExists</li> <li><a href="https://github.com/microsoft/TypeScript/commit/3e7a8e7e45aed722d7955e35e9fbac14ea75958a"><code>3e7a8e7</code></a> Cherry-pick PR <a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/40348">#40348</a> into release-4.0 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/40349">#40349</a>)</li> <li><a href="https://github.com/microsoft/TypeScript/commit/8890dcb7ca81857678b110a1586f3642d1447ee2"><code>8890dcb</code></a> Cherry-pick PR <a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/40118">#40118</a> into release-4.0 (<a href="https://github-redirect.dependabot.com/Microsoft/TypeScript/issues/40134">#40134</a>)</li> <li><a href="https://github.com/microsoft/TypeScript/commit/912cbdfcb6b5ed1b0623390fc350c3c313fc8f1b"><code>912cbdf</code></a> Update LKG</li> <li>Additional commits viewable in <a href="https://github.com/Microsoft/TypeScript/compare/v3.9.7...v4.0.3">compare view</a></li> </ul> </details> <br />
You can trigger a rebase of this PR by commenting @dependabot rebase.
<details> <summary>Dependabot commands and options</summary> <br />
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readme
Additionally, you can set the following in the .dependabot/config.yml file in this repo:
- Update frequency
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)
</details><br/><br/><br/><url>LiveURL: https://orbit-dependabot-npm-and-yarn-typescript-4-0-3.surge.sh</url>
pr closed time in 2 days
push eventkiwicom/orbit
commit sha e2d1953af1a339f42ead0ed4dbe716fc52d52d62
fix(Timeline): IE fixes (#2370) Co-authored-by: Luděk Vepřek <[email protected]>
push time in 2 days
PR merged kiwicom/orbit
<br/><br/><br/><url>LiveURL: https://orbit-fix-timeline.surge.sh</url>
pr closed time in 2 days
Pull request review commentkiwicom/orbit
feat(ButtonLink)!: remove background for compact, delete inline type
import type { spaceAfter } from "../common/getSpacingToken/index"; export type Props = {| ...Globals, +children: React$Node,- +onGoBack?: (ev: SyntheticEvent<HTMLButtonElement>) => void | Promise<any>,+ +onGoBack?: (ev: SyntheticEvent<HTMLElement>) => void | Promise<any>,
Ok!
comment created time in 2 days
push eventkiwicom/orbit
commit sha b4b07c272be3c12162f33bed3413033a2b1d4f3b
chore(BabelPlugin): remove internal dependency (#2383) to avoid releasing a new version of `@kiwicom/babel-plugin-orbit-components`, each time `@kiwicom/orbit-components` is updated
push time in 2 days
PR merged kiwicom/orbit
closes #2368
This Pull Request meets the following criteria:
- [x] Tests have been added/adjusted for my new feature
- [x] New Components are registered in index.js of my project
remove internal dependency (it will use it anyway, but won't affect version bumps)
<br/><br/><br/><url>LiveURL: https://orbit-sampi-fix-2368.surge.sh</url>
pr closed time in 2 days
issue closedkiwicom/orbit
Avoid unnecessary version bumps of @kiwicom/babel-plugin-orbit-components
@kiwicom/babel-plugin-orbit-components always gets a version bump because it has @kiwicom/orbit-components in devDependencies. It will probably be enough to remove it, otherwise we should consider removing all devDependencies from both packages.
Success can be checked by running yarn release, then seeing whether the version is unjustifiably bumped.
lerna/lerna#1737
closed time in 2 days
silvenonissue openedkiwicom/orbit
Move all devDependencies to root package.json
Bumping devDependencies also bumps the version, as we've found out, so it's most likely best to move them all to the root package.json. The added benefit is that way we avoid having to bump the same development dependency in multiple places. I think it will be easier to manage the monorepo this way.
created time in 2 days
pull request commentkiwicom/orbit
feat(ButtonLink)!: remove background for compact, delete inline type
Also, I would recommend to rebase and check for ESLint errors, just in case.
comment created time in 2 days