Description:

When checking for duplicates we have to include the report, otherwise reArchiveReport w/ a custom report name may not work correctly.

@sgiehl this should fix the CustomReports test failure. It's a simple change so merging it now.

Review

• [ ] Functional review done
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done see checklist
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

Description:

When checking for duplicates we have to include the report, otherwise reArchiveReport w/ a custom report name may not work correctly.

@sgiehl this should fix the CustomReports test failure. It's a simple change so merging it now.

Review

• [ ] Functional review done
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done see checklist
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

Mobile app device model version seems to be incorrect for the below and similar app based user agents. iPhone12 reports device as iPhone 11 Pro Max

[ ] Testapp/2.148.2 (com.testapp.omega; build:20210204501; iPhone12,5; iOS 14.2; scale:3.0)

hi @agmorpheus, would you be able to post the visitorid for the visits you're displaying? Are they the same?

And do you have any interesting INI config set, for example, [Tracker] enable_userid_overwrites_visitorid?

@datango did you have the config_client_type and config_browser_name columns in your tables before yodatubg?

hi @MISTAnalytics, sorry you're experiencing this issue. Would you be able to post the definition of the email report? Would you also be able to post the response to the API.getReportMetadata API method (as an attachment as it should be quite large)?

(If any of these have information you wouldn't want to post here, you can also email them to me at [email protected].)

@Littlericket can you run the following SQL:

SELECT * FROM piwik_archive_numeric_2018_01 WHERE idarchive = 836463;

If you'd like to email the data, you can email it to [email protected].

@Pilot001 could you answer my other question and if possible provide core:archive output w/ the -vvv option?

Description:

fixes #17159

Review

• [ ] Functional review done
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done see checklist
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

In the browser developer console I see a warning linking to https://www.chromestatus.com/feature/5629709824032768 anyone seen this before? See https://www.chromium.org/Home/chromium-security/corb-for-developers for more information.

HTTP with 204 seems to work but 200 blocked. send_image=0 is used so it should have sent an HTTP 204 header. Actually... this output happens because of bulk requests. The request with HTTP 200 was sent as a bulk request in this example.

response headers:

The console warning reads Cross-Origin Read Blocking (CORB) blocked cross-origin response XYZ with MIME type application/json. See https://www.chromestatus.com/feature/5629709824032768 for more details.

For a URL where this can be reproduced feel free to ping me privately. I'm not sure if the tracking request will be executed or if just the response is not loaded.

Goal of this issue is to make sure such requests are tracked and the warning is no longer shown.

Actually I misread the PR, it doesn't need an entry in the developer changelog. I'll remove it and merge.

Description:

Currently we check if a segment has been created or updated since the last time we invalidated in core:archive, and if so invalidate in the past. This is more complicated and error prone, it is far easier to just invalidate in the past in the SegmentEditor API.

Refs #16955

Review

• [ ] Functional review done
• [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• [ ] Security review done see checklist
• [ ] Code review done
• [ ] Tests were added if useful/possible
• [ ] Reviewed for breaking changes
• [ ] Developer changelog updated if needed
• [ ] Documentation added if needed
• [ ] Existing documentation updated if needed

@sgiehl as we report the "Days to conversions" in each Goal reports (screenshot below), the metric would be the "Time to conversion" within one visit. it could be clarified in the tooltip and other help that it is the time since the beginning of this visit.

Fixed a bug in the definition of Eluga (.+) AppleWebKit and added a test Renamed model Live to ZenFone Live for ASUS_Z00YD Added tests for 76 devices~

@tsteur the bug here is actually a bug in the website that we had several times in the past. it rewrites the links to the wrong URL. Here is the rendered text: which links to: https://matomo.org/free-tag-manager/#how-can-i-set-up-matomo-tag-manager-on-my-website

While the original is: linking correctly to https://matomo.org/docs/tag-manager/#how-can-i-set-up-matomo-tag-manager-on-my-website

⚠️ Missing/incorrect detections should be reported at https://github.com/matomo-org/device-detector/issues instead of this repo.

Issue:

Detector does not work on IPad 5,3. Though it works fine in other IOs devices , Mac's also doesn't seems to have the same problem, so it only occurs on Ipad 5,3

Expected behaviour:

Print the device data as shown in the example.

Actual behaviour:

The library simply breaks the script and stop the others JS that needs to run after.

Code example:

import DeviceDetector from "device-detector-js";

const deviceDetector = new DeviceDetector();

function printDevice(deviceData) {
  const device = deviceDetector.parse(deviceData);
  return device;
}

window.deviceData = printDevice;

Outputs and Logs:

Unfortunately I have no access to any Mac's, and because of that i cannot see any debug log.

Closing the issue

I fount that @sanchezzzhak was right about the PHP repo, i was using the npm version, that was the issue with the IPad, we're rewriting the code so it works on PHP only. The links @Findus23 pasted helped a lot. Thanks everyone for the help! Technically we solved, so from now on is on us!

Thanks @uglyrobot the problem is less around redis but more about Matomo and how it tracks data etc. There's a related issue in core eg https://github.com/matomo-org/matomo/issues/6415 basically if two workers were to work on the same a queue and one worker was processing the second tracking request of a visit slightly faster than another worker does the first tracking request Matomo could store wrong data in its database and sometimes even additionally create multiple visits.

Looks good to me but be good to indeed change comment around the bug template