profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/sfackler/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

rust-phf/rust-phf 901

Compile time static maps for Rust

estk/log4rs 576

A highly configurable logging framework for Rust

a8m/pb 427

Console progress bar for Rust

env-logger-rs/env_logger 406

A logging implementation for `log` which is configured via an environment variable.

rust-lang/socket2 316

Advanced configuration options for sockets.

pyfisch/cbor 277

CBOR support for serde.

gnzlbg/jemallocator 261

Rust allocator using jemalloc as a backend

carllerche/syncbox 127

Concurrency utilities for Rust

kornelski/rust-security-framework 118

Bindings to the macOS Security.framework

push eventsfackler/rust-postgres

Laurențiu Nicola

commit sha 34d8b77644880dbaef1bcd7e8aa246dc59e90d11

Add feature gates for doctests

view details

Steven Fackler

commit sha 3854aecbb1172de49e3b808ce644f11f4f0974b5

Merge pull request #825 from lnicola/gate-doctests Add feature gates for doctests

view details

push time in 10 hours

Pull request review commentsfackler/rust-postgres

Add feature gates for doctests

 //! //! ```no_run //! use native_tls::{Certificate, TlsConnector};+//! # #[cfg(feature = "runtime")] {
error: expected item after attributes
 --> src/main.rs:1:1
  |
1 | #[cfg(feature = "runtime")] {
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: could not compile `playground` due to previous error

You cannot define bare blocks at module level.

lnicola

comment created time in 10 hours

PullRequestReviewEvent

Pull request review commentsfackler/rust-postgres

Add feature gates for doctests

 //! //! ```no_run //! use native_tls::{Certificate, TlsConnector};+//! # #[cfg(feature = "runtime")] {

This is not valid syntax.

lnicola

comment created time in 10 hours

PullRequestReviewEvent

pull request commentsfackler/rust-postgres

Add support for time 0.3

Thanks!

lnicola

comment created time in 2 days

PR merged sfackler/rust-postgres

Add support for time 0.3
+270 -3

3 comments

9 changed files

lnicola

pr closed time in 2 days

push eventsfackler/rust-postgres

Laurențiu Nicola

commit sha be0d71fad51b9ea070493ed44a2ab15557635b85

Add support for time 0.3

view details

Steven Fackler

commit sha 031e4e3832755d309eb4af635610e87d120089a7

Merge pull request #824 from lnicola/time-0.3 Add support for time 0.3

view details

push time in 2 days

Pull request review commentsfackler/rust-postgres

Add support for time 0.3

+use bytes::BytesMut;+use postgres_protocol::types;+use std::convert::TryFrom;+use std::error::Error;+use time_03::{Date, Duration, OffsetDateTime, PrimitiveDateTime, Time, UtcOffset};++use crate::{FromSql, IsNull, ToSql, Type};++#[rustfmt::skip]+const fn base() -> PrimitiveDateTime {+    PrimitiveDateTime::new(Date::__from_ordinal_date_unchecked(2000, 1), Time::MIDNIGHT)

This does not seem like a public API?

lnicola

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentsfackler/rust-postgres

Add support for time 0.3

+use bytes::BytesMut;+use postgres_protocol::types;+use std::convert::TryFrom;+use std::error::Error;+use time_03::{Date, Duration, OffsetDateTime, PrimitiveDateTime, Time, UtcOffset};++use crate::{FromSql, IsNull, ToSql, Type};++#[rustfmt::skip]

Why?

lnicola

comment created time in 2 days

push eventpalantir/conjure-rust

Steven Fackler

commit sha 2c33f468a10ee45aa3f464a486f8e9f667719742

clippy

view details

push time in 3 days

pull request commentpalantir/conjure-rust

Overhaul the client API

The diff is not actually that huge - most of it is just regenerating a bunch of checked in Conjure code.

sfackler

comment created time in 3 days

push eventpalantir/conjure-rust

Steven Fackler

commit sha 8f700c1966dbba962afae86159cbca1b9473e5e6

clippy

view details

push time in 3 days

PR opened palantir/conjure-rust

Reviewers
Overhaul the client API

Before this PR

The existing client interface is both complex and forced client implementations to handle a bunch of Conjure-specified logic.

After this PR

<!-- User-facing outcomes this PR delivers go below --> ==COMMIT_MSG== Redesigned the Conjure client interface. ==COMMIT_MSG==

The new interface works at a much more general level, by exchanging http::Request and http::Response objects with the client implementation. The generated Conjure code is responsible for setting up the entire request by handling body serialization, path construction, etc.

Additionally, the new interface is more flexible - an HTTP client could use the Conjure client trait as its main interface and still leave consumers the flexibility to interact with non-Conjure clients.

This generally mirrors the approach we use in the Java Dialogue implementation, with the one exception that the body serde logic is not pluggable - we specifically work with only JSON. It would be possible to add the ability to customize that in the future but would require adding a second type parameter to generated client objects.

I'm working on a similar change on the server side, moving to an interface that looks more like our Java Undertow implementation and exchanges http::Request and http::Response objects.

Closes #123

+2301 -2328

0 comment

13 changed files

pr created time in 3 days

create barnchpalantir/conjure-rust

branch : client-trait

created branch time in 3 days

pull request commentsfackler/rust-native-tls

Implement PKCS8 certificate support for all three backends.

PRs welcomed! :D

I think this is (probably?) pretty close to being able to land with a rebase and a couple of bits of feedback resolved.

Goirad

comment created time in 3 days

issue commentsfackler/rust-openssl

Allow openssl-sys to not link to dynamic libraries

The crate minimally needs access to the headers associated with the OpenSSL it's linking to. You can use environment variables to override the library names the crate will link to: https://docs.rs/openssl/0.10.36/openssl/#manual

tomleavy

comment created time in 3 days

release sfackler/rust-openssl

openssl-sys-v0.9.67

released time in 4 days

created tagsfackler/rust-openssl

tagopenssl-sys-v0.9.67

OpenSSL bindings for Rust

created time in 4 days

push eventsfackler/rust-openssl

Steven Fackler

commit sha bf20ebeb3e023eba142da0329825202b1713c0cf

Release openssl-sys v0.9.67

view details

push time in 4 days

push eventpalantir/conjure-rust-runtime

Steven Fackler

commit sha db84a0f937ccc5355e89a6572899198f9720e007

release v1.1.0

view details

push time in 4 days

Pull request review commentpalantir/conjure-rust-runtime

Add missing blocking_handle setter

 readme = "../README.md"  [dependencies] serde = { version = "1.0", features = ["derive"] }-serde-humantime = "0.1.1"+humantime-serde = "1.0"

Drive by dependency bump

sfackler

comment created time in 4 days

PullRequestReviewEvent

PR opened palantir/conjure-rust-runtime

Reviewers
Add missing blocking_handle setter

Forgot this in the previous PR!

+17 -2

0 comment

3 changed files

pr created time in 4 days

create barnchpalantir/conjure-rust-runtime

branch : handle-settter

created branch time in 4 days

delete branch palantir/conjure-rust-runtime

delete branch : blocking-handle

delete time in 4 days

push eventpalantir/conjure-rust-runtime

Steven Fackler

commit sha 6f60be1c1f551bbbb471180d03fbd70aeec41c12

Allow configuration of the blocking client runtime

view details

svc-changelog

commit sha f7ae25fdbe60fa41fbd425cc5abddb654b19ce35

Add generated changelog entries

view details

Steven Fackler

commit sha 3b10c841832a86ec5b3440bcaa9d20aaad6edef6

Release v1.0.0

view details

Steven Fackler

commit sha 18b6f022e5a0a3e693b11e1b7edb37b8de4ee278

bump ci version

view details

Steven Fackler

commit sha 8904f56bd323c7e344cebbc78b6b50c0e78bfc46

clippy

view details

Steven Fackler

commit sha e87a4db144c49ef2827df4591cfdf434a92e1008

clippy

view details

Steven Fackler

commit sha c65a11a4829417f3b476cb3537b93bda18ec8c42

Merge pull request #103 from palantir/blocking-handle Allow configuration of the blocking client runtime

view details

push time in 4 days

PR merged palantir/conjure-rust-runtime

Reviewers
Allow configuration of the blocking client runtime

Before this PR

Blocking clients always used their own multi-threaded tokio Runtime.

After this PR

<!-- User-facing outcomes this PR delivers go below --> ==COMMIT_MSG== The tokio runtime used by blocking clients can now be configured. ==COMMIT_MSG==

We already have a Runtime set up for the server side in our services, so it's just a waste of threads to not use that for the clients as well!

+65 -20

2 comments

13 changed files

sfackler

pr closed time in 4 days