profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/sethvargo/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Seth Vargo sethvargo @Google Pittsburgh, PA https://www.sethvargo.com Engineer @google

googlecodelabs/tools 2797

Codelabs management & hosting tools

google-github-actions/setup-gcloud 1166

A GitHub Action for configuring the Google Cloud SDK. The Google Cloud SDK includes both the gcloud and gsutil binaries.

GoogleCloudPlatform/berglas 1025

A tool for managing secrets on Google Cloud

google/oauth2l 448

oauth2l ("oauth tool") is a simple CLI for interacting with Google API authentication.

kelseyhightower/vault-on-google-kubernetes-engine 381

How to guide on running HashiCorp's Vault on Google Kubernetes Engine

hashicorp/waypoint-examples 268

Example Apps that can be deployed with Waypoint

sethvargo/bootstrap_forms 256

Bootstrap Forms makes Twitter's Bootstrap on Rails easy!

google-github-actions/auth 191

GitHub Action for authenticating to Google Cloud with GitHub Actions OIDC tokens and Workload Identity Federation.

fastly/go-fastly 129

A golang Fastly API client library.

push eventgoogle/exposure-notifications-server

Seth Vargo

commit sha 967e4a95d3600f5f299e8a000be78039742404d7

Update deps (#1569)

view details

push time in 10 hours

delete branch google/exposure-notifications-server

delete branch : sethvargo/deps

delete time in 10 hours

PR merged google/exposure-notifications-server

Reviewers
Update deps cla: yes

Release Note

<!-- Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required". If no release note is required, write "NONE". -->

NONE
+534 -177

0 comment

2 changed files

sethvargo

pr closed time in 10 hours

push eventgoogle/exposure-notifications-verification-server

Seth Vargo

commit sha 892a8d9f3af389d71878d293aa7dfdedd53481be

Move sms stats up a bit (#2239)

view details

push time in 10 hours

delete branch google/exposure-notifications-verification-server

delete branch : sethvargo/moveup

delete time in 10 hours

PR merged google/exposure-notifications-verification-server

Reviewers
Move sms stats up a bit cla: yes

Release Note

<!-- Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required". If no release note is required, write "NONE". -->

NONE
+4 -4

0 comment

1 changed file

sethvargo

pr closed time in 10 hours

PR opened google/exposure-notifications-server

Update deps

Release Note

<!-- Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required". If no release note is required, write "NONE". -->

NONE
+534 -177

0 comment

2 changed files

pr created time in 10 hours

create barnchgoogle/exposure-notifications-server

branch : sethvargo/deps

created branch time in 10 hours

PR opened google/exposure-notifications-verification-server

Move sms stats up a bit

Release Note

<!-- Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required". If no release note is required, write "NONE". -->

NONE
+4 -4

0 comment

1 changed file

pr created time in 10 hours

push eventgoogle/exposure-notifications-verification-server

Seth Vargo

commit sha b27a339cc4b111e84a927463cbd9e3ac7cf59685

Compile full webhook URL from the Twilio request (#2238) Signature validation fails without this, because r.URL doesn't always include the full host.

view details

push time in 10 hours

delete branch google/exposure-notifications-verification-server

delete branch : sethvargo/wat

delete time in 10 hours

PR merged google/exposure-notifications-verification-server

Reviewers
Compile full webhook URL from the Twilio request cla: yes

Signature validation fails without this, because r.URL doesn't always include the full host.

Release Note

<!-- Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required". If no release note is required, write "NONE". -->

NONE
+151 -98

0 comment

8 changed files

sethvargo

pr closed time in 10 hours

PullRequestReviewEvent

Pull request review commentsethvargo/gcr-cleaner

feat: add better loggin and stats for deleted refs

 type Cleaner struct { 	concurrency int } +type deleteStats struct {+	Manifests []string+	Size      uint64

I'm not really convinced returning the number of bytes is a meaningful signal given how varying the size of containers can be.

grumps

comment created time in 10 hours

Pull request review commentsethvargo/gcr-cleaner

feat: add better loggin and stats for deleted refs

 func (s *Server) PubSubHandler(cache Cache) http.HandlerFunc { 		// Start a goroutine to delete the images 		body := ioutil.NopCloser(bytes.NewReader(m.Message.Data)) 		go func() {-			if _, _, err := s.clean(ctx, body); err != nil {+			if _, _, err := s.clean(ctx, body)

This doesnt seem like it will compile correctly.

grumps

comment created time in 10 hours

Pull request review commentsethvargo/gcr-cleaner

feat: add better loggin and stats for deleted refs

 func NewCleaner(auther gcrauthn.Authenticator, c int) (*Cleaner, error) {  // Clean deletes old images from GCR that are (un)tagged and older than "since" and // higher than the "keep" amount.-func (c *Cleaner) Clean(repo string, since time.Time, allowTagged bool, keep int, tagFilterRegexp *regexp.Regexp, dryRun bool) ([]string, error) {+func (c *Cleaner) Clean(repo string, since time.Time, allowTagged bool, keep int, tagFilterRegexp *regexp.Regexp, dryRun bool) (*deleteStats, error) {

This is a public API - we can't change the signature

grumps

comment created time in 10 hours

PullRequestReviewEvent

push eventgoogle/exposure-notifications-verification-server

Seth Vargo

commit sha bfb25da99b9278eaabb5f603dc4bd07d1acd3922

Fix tests

view details

push time in 10 hours

push eventgoogle/exposure-notifications-verification-server

Seth Vargo

commit sha 55172f4f8bf44c229c380b9b9c40ae09a54febd3

Compile full webhook URL from the Twilio request Signature validation fails without this, because r.URL doesn't always include the full host.

view details

push time in 11 hours

push eventgoogle/exposure-notifications-verification-server

Seth Vargo

commit sha 25dea17528106070b0a26445003f222710bb40b0

Add docs for twilio webhooks

view details

push time in 11 hours

Pull request review commentgoogle/exposure-notifications-verification-server

Compile full webhook URL from the Twilio request

+// Copyright 2021 the Exposure Notifications Verification Server authors+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//      http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.++package controller

This is moved from template_test.

sethvargo

comment created time in 11 hours

Pull request review commentgoogle/exposure-notifications-verification-server

Compile full webhook URL from the Twilio request

 func RedirectToChangePassword(w http.ResponseWriter, r *http.Request, h *render. 	return } +// RealHostFromRequest attempts to find the "best" host for the HTTP request.

This is moved from template.

sethvargo

comment created time in 11 hours

PullRequestReviewEvent
PullRequestReviewEvent

PR opened google/exposure-notifications-verification-server

Compile full webhook URL from the Twilio request

Signature validation fails without this, because r.URL doesn't always include the full host.

Release Note

<!-- Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required". If no release note is required, write "NONE". -->

NONE
+113 -96

0 comment

5 changed files

pr created time in 11 hours

create barnchgoogle/exposure-notifications-verification-server

branch : sethvargo/wat

created branch time in 11 hours

Pull request review commentgoogle/exposure-notifications-verification-server

allow specifiction of realm alert SMS numbers

+{{define "notifications/index"}}++{{$currentMembership := .currentMembership}}+{{$canWrite := $currentMembership.Can rbac.SettingsWrite}}++<!doctype html>+<html dir="{{$.textDirection}}" lang="{{$.textLanguage}}">+<head>+  {{template "head" .}}+</head>++<body id="apikeys-index" class="tab-content">+  {{template "navbar" .}}++  <main role="main" class="container">+    {{template "flash" .}}++    {{if not .hasSMS}}+    <div class="container">+        <div class="alert alert-warning" role="alert">+          <div class="d-flex align-items-center">+            <i class="bi bi-exclamation-square-fill me-3"></i>+            <span class="alert-message">+              There is no SMS configuration for this realm, so any enabled+              notifications will not be sent via SMS.+            </span>+          </div>+        </div>+      </div>+    {{end}}++    <div class="card shadow-sm mt-4 mb-3">+      <div class="card-header">+        <i class="bi bi-key me-2"></i>+        Realm notification destination phone numbers+        {{if $canWrite}}+          <a href="/realm/notifications/new" class="float-end link-secondary" data-bs-toggle="tooltip" title="New destination phone number">+            <i class="bi bi-plus-square-fill"></i>+          </a>+        {{end}}+      </div>++      <div class="card-body">+        <form method="GET" action="/realm/notifications" id="search-form">+          <div class="input-group">+            <input type="search" name="q" id="search" value="{{.query}}" placeholder="Search..."+              autocomplete="off" class="form-control" />+            <button type="submit" class="btn btn-secondary">+              <i class="bi bi-search"></i>+              <span class="visually-hidden">Search</span>+            </button>+          </div>+        </form>+      </div>++      {{if .raps}}

His palms are sweaty, knees weak, arms are heavy...

mikehelmick

comment created time in 12 hours

PullRequestReviewEvent

Pull request review commentgoogle/exposure-notifications-verification-server

allow specifiction of realm alert SMS numbers

+{{define "notifications/index"}}++{{$currentMembership := .currentMembership}}+{{$canWrite := $currentMembership.Can rbac.SettingsWrite}}++<!doctype html>+<html dir="{{$.textDirection}}" lang="{{$.textLanguage}}">+<head>+  {{template "head" .}}+</head>++<body id="apikeys-index" class="tab-content">+  {{template "navbar" .}}++  <main role="main" class="container">+    {{template "flash" .}}++    {{if not .hasSMS}}+    <div class="container">+        <div class="alert alert-warning" role="alert">+          <div class="d-flex align-items-center">+            <i class="bi bi-exclamation-square-fill me-3"></i>+            <span class="alert-message">+              There is no SMS configuration for this realm, so any enabled

If you wanted, you could insert this as flash.Error in the controller instead of writing it in the HTML. That way you'll get consistent styles with flash messages. Up to you.

mikehelmick

comment created time in 12 hours