seancribbs ( Sean Cribbs )

It would be awesome if one of your could take a quick look. My Ruby got quite rusty. :sweat_smile: The tests work, so I guess it's fine. I can push a new as-notifications gem release once it has been merged.

rgarner

comment created time in 9 hours

pull request commentwebmachine/webmachine-ruby

Start fixing the build for ruby 3.0.0

@bethesque ah, thanks. I'm quite unfamiliar with the setup of these kinds of matrix builds! I've just cloned the ruby source to try and work out why the constants have gone missing. Current hypothesis is that they're fiddling with the shareable_constant_value pragma in the C and some constants are going missing. I think this might be too big a yak for me to shave today, so I'll just open this for review.

rgarner

comment created time in 9 hours

pull request commentwebmachine/webmachine-ruby

Start fixing the build for ruby 3.0.0

The ruby-head build is already marked as "experimental" in test.yml. There's just nothing that runs after the tests to show that the failure is ignored.

rgarner

comment created time in 9 hours

pull request commentwebmachine/webmachine-ruby

Start fixing the build for ruby 3.0.0

I'm ok with failing ruby-head personally. We can deal with it when it becomes an official release.

rgarner

comment created time in 9 hours

pull request commentwebmachine/webmachine-ruby

Start fixing the build for ruby 3.0.0

Hm. That's a strange one.

irb(main):002:0> require 'time'
=> true
irb(main):003:0> Time::RFC2822_DAY_NAME
=> ["Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat"]

Given the nature of a constant is, well, constant, perhaps just create a Webmachine constant with that value? Maybe they've dropped support for RFC2822_DAY_NAME in ruby-head, but haven't documented it yet. I can't find anything in the googles either.

rgarner

comment created time in 9 hours

pull request commentwebmachine/webmachine-ruby

Start fixing the build for ruby 3.0.0

It looks like our cookie.rb has this in it, and the constants RFC2822_DAY_NAME and RFC2822_MONTH_NAME are, for whatever reason, not in Ruby 3.1.0-dev:

    def rfc2822(time)
      wday = Time::RFC2822_DAY_NAME[time.wday]
      mon = Time::RFC2822_MONTH_NAME[time.mon - 1]
      time.strftime("#{wday}, %d-#{mon}-%Y %H:%M:%S GMT")
    end

Since I don't know the reason for the dropping of these constants, we can either drop down to the RFC822 equivalents in CGI::Util::RFC822_DAYS and CGI::Util::RFC822_MONTHS or we can make failures in ruby-head not an error condition.

rgarner

comment created time in 9 hours

pull request commentwebmachine/webmachine-ruby

Start fixing the build for ruby 3.0.0

@bethesque I've seen other projects allow failures on ruby-head, I wonder if that's acceptable here

rgarner

comment created time in 9 hours

pull request commentwebmachine/webmachine-ruby

Start fixing the build for ruby 3.0.0

@bethesque heh, we tried doing this curiously on a local project and it was kind of a "hey, while this is still fresh in my head". It's still failing on ruby-head – I'm a bit stumped with that one ☹️

rgarner

comment created time in 9 hours

push eventwebmachine/webmachine-ruby

Russell Garner

commit sha 1a91fe8ac1f639c7541d3cb8b7331b5cdd347c0f

Replace Proc.new usage for Ruby 3 Ruby 3 no longer supports Proc.new without a block to mean "the block that was passed to this method". Use an explicit &block instead This commit does not fix as-notifications, on this line: https://github.com/bernd/as-notifications/blob/v1.0.0/lib/as/notifications/fanout.rb#L18

view details

push time in 9 hours

pull request commentwebmachine/webmachine-ruby

Start fixing the build for ruby 3.0.0

🎉 So glad to see someone pick this up!

rgarner

comment created time in 10 hours

PR opened webmachine/webmachine-ruby

Fix build for ruby 3.0.0

Fix:

dev dependency for webrick
keyword arguments are stricter with respect to options hashes (double-splat fixes)
Proc.new requires an empty block where a block is not given

Does not fix:

gem as-notifications will need updating as per point 3. above

+5 -2

3 commit in webmachine/webmachine-ruby/tree/fix-build-for-ruby-3.0.0 webmachine/webmachine-ruby/tree/master

0 comment

3 changed files

pr created time in 10 hours

push eventwebmachine/webmachine-ruby

Russell Garner

commit sha 490b8c0dcc7a384def6c183a870637b8cc285078

Add empty blocks to Proc.new for Ruby 3 Ruby 3 requires empty blocks for new Proc where a block is not given. This commit does not fix as-notifications, on this line: https://github.com/bernd/as-notifications/blob/v1.0.0/lib/as/notifications/fanout.rb#L18

view details

push time in 10 hours

create barnchwebmachine/webmachine-ruby

branch : fix-build-for-ruby-3.0.0

created branch time in 10 hours

pull request commentwebmachine/webmachine-ruby

fix: implement rfc3986 Percent-Encoding decoder

Finally released this!

uglyog