savitharaghunathan ( Savitha Raghunathan )

Hi @howardjohn 👋 , please feel free to re-open this issue when you have one more sponsor satisfying all the guidelines mentioned in https://github.com/kubernetes/community/blob/master/community-membership.md#requirements. Thanks!

/close

howardjohn

comment created time in a day

issue commentkubernetes/sig-release

Improve docs role handbook

Also, commenting on "Leverage Implemented field from enhancements tracking sheet to determine if the corresponding docs PR can be merged/not", I think we actually want to make sure k/k prs are merged in and the enhancement team is one that's responsible for making sure the enhancement is not tracked if it's not in the "implementable" state.

So, I'm not sure what the action item here is. But, during the sig docs quarterly planning meeting, I'm planning on discussing how to automate the k/k pr "look up" for docs in an automated way. Regardless, I think this should be a separate issue as it's not an easy change.

@annajung : Anna, I marked it as done and added a note. Can you open an issue to track it, please? Thanks :)

savitharaghunathan

comment created time in 3 days

PR opened kubernetes/community

Adding sig-security-docs slack channel

New slack channel for discussions for the security docs sub-project in sig-security 🎉

cc: @IanColdwater @tabbysable

+1 -0

1 commit in savitharaghunathan/community/tree/add_sig_security_docs kubernetes/community/tree/master

0 comment

1 changed file

pr created time in 3 days

create barnchsavitharaghunathan/community

branch : add_sig_security_docs

created branch time in 3 days

PullRequestReviewEvent

Pull request review commentkubernetes/sig-release

feat(docs) add rebase method for periodically master sync

 git commit -m "Merge master into dev-[future release] to keep in sync" git push origin merged-master-dev-[future release] ``` -Submit a PR against upstream `dev-[future release]` from your fork's branch `merged-master-dev-[future release]`. e.g., [merge master into future release](https://github.com/kubernetes/website/pull/16225).- You may need to fix conflicts manually. If somebody has improved a page on `master`, and at the same time it has been updated in the dev branch for the next release, we may need to figure out how to make those changes work together. If something comes up which isn't obvious, you can always abort the merge and reach out to SIG Docs for help.  When you have completed resolving the differences manually, run `git merge --continue` to complete the merge. Then carry on from step 5. -⚠️  **Ensure the PR is passing tests on GitHub**.+> Rebase Method

I want to say it has to do with preserving the history of commits. I am not totally sure,so will wait to hear from other folks.

eagleusb

comment created time in 3 days

Pull request review commentkubernetes/sig-release

feat(docs) add rebase method for periodically master sync

 git commit -m "Merge master into dev-[future release] to keep in sync" git push origin merged-master-dev-[future release] ``` -Submit a PR against upstream `dev-[future release]` from your fork's branch `merged-master-dev-[future release]`. e.g., [merge master into future release](https://github.com/kubernetes/website/pull/16225).- You may need to fix conflicts manually. If somebody has improved a page on `master`, and at the same time it has been updated in the dev branch for the next release, we may need to figure out how to make those changes work together. If something comes up which isn't obvious, you can always abort the merge and reach out to SIG Docs for help.  When you have completed resolving the differences manually, run `git merge --continue` to complete the merge. Then carry on from step 5. -⚠️  **Ensure the PR is passing tests on GitHub**.+> Rebase Method

Hi, @eagleusb 👋 Is there a reasoning behind adding the rebase method to the documentation? Merge method is preferred because it can be later reviewed by folks if needed(as it preserves the history). @jimangel @sftim @kbhawkey - I am not sure where k/website stands with rebasing a branch into another. Can you provide some insight into this, please?

/hold

eagleusb

comment created time in 3 days

PullRequestReviewEvent