profile
viewpoint
Roland Weisleder rweisleder data experts gmbh Berlin, Germany http://blog.rweisleder.de/

rweisleder/jfairy-junit-extension 14

Extension for JUnit which provides injection of random data

rweisleder/ArchUnit 0

A Java architecture test library, to specify and assert architecture rules in plain Java

rweisleder/assertj-core 0

AssertJ is a library providing easy to use rich typed assertions

rweisleder/java-client-api 0

A Jenkins API client for Java

rweisleder/jfairy 0

Java fake data generator

rweisleder/jOOQ 0

jOOQ is the best way to write SQL in Java

delete branch rweisleder/ArchUnit

delete branch : gradle-wrapper-version-property

delete time in 13 days

push eventrweisleder/ArchUnit

Peter Gafert

commit sha 5fac4196ba6a803136424f10d27aa8276348e01a

fix JUnit 5 docs Unfortunately there were some leftover docs from the time before ArchUnit released the aggregator Maven dependency for both `archunit-junit5-api` and `archunit-junit5-engine`. The section can now actually be simplified, because meanwhile there is nothing specific as compared to JUnit 4, if the aggregator artifact is used. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 57cff37ff09d48229d2bbfd7e50b312fb67b98be

Merge branch 'release-0.13.0'

view details

Jonathan Leitschuh

commit sha 1f7fb4c1ea0e57ace8f7aa51c712990a4548a3fc

Official Gradle Wrapper Validation GitHub Action See: https://github.com/gradle/wrapper-validation-action Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

view details

Peter Gafert

commit sha bdf86d61d392882e15cfb57d06d1f1c3b179a81f

Merge pull request #299 from JLLeitschuh/patch-1 Official Gradle Wrapper Validation GitHub Action

view details

Peter Gafert

commit sha 27e42513b13d0bd9b2570894ad58a8744fb69b08

adjust version for 0.13.1-SNAPSHOT Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 852c8085ffb04d423623d27a90d2981fe4997d10

fix broken JRT URL handling for JDK >= 13 With JDK 13 some wrongly implemented behavior of JRT path handling was fixed. I.e. by JEP-220 (https://openjdk.java.net/jeps/220) while URIs possess the shape of `jrt:/module.name/some/clazz/Name.class` the respective (virtual) file system path for JRTs supposedly has the shape of `/modules/module.name/some/clazz/Name.class`. Unfortunately ArchUnit was relying on the wrongly implemented version of `JrtFileSystemProvider` which would return a path for JRTs of `/module.name/some/clazz/Name.class`. Thus with JDK >= 13 the URI handling for JRTs was broken. This will now be fixed by relying on pure JRT URI handling without relying on conversion to `java.nio.file.Path`. We simply split the path of a JRT URI on `/` and treat the first segment as module name, the rest of the segments as the resource/class name (e.g. `module.name` and `some/clazz/Name.class`). Note that we unfortunately cannot use `URI.getPath()` within `NormalizedUri` to retrieve the path without the schema, since `URI.getPath()` will return `null` for JAR URIs (i.e. `jar:file:/...`). Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 51087d5f576776f55eae29dc74e01a862bfed0d0

Merge pull request #304 from TNG/bugfix/fix-jdk13-module-name-resolution fix broken JRT URL handling for JDK >= 13

view details

Peter Gafert

commit sha 9bfc075008ac51a6961eff355ac8213c93dc5f77

adjust docs to release version `0.13.1` Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha b928082f82eb2d01ee06f2869ea22f960cb17f1d

create release news for `0.13.1` Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha d39137c2fe234763e98836c01039881b82465e82

Merge branch 'release-0.13.1' Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha ed02bda8a2dfaf05ef2534481a76267c8d2384cf

upgrade Gradle to `5.6.4` Also upgrades * `com.gradle.build-scan`: `1.16` -> `3.1.1` * `com.github.johnrengelman.shadow`: `4.0.1` -> `5.2.0` * `com.github.spotbugs`: `1.6.4` -> `3.0.0` Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 16f3561a17f54735fa92b36e0af8ef351bc91d8a

Upgrade Gradle to `5.6.4` #306 Also upgrades * `com.gradle.build-scan`: `1.16` -> `3.1.1` * `com.github.johnrengelman.shadow`: `4.0.1` -> `5.2.0` * `com.github.spotbugs`: `1.6.4` -> `3.0.0`

view details

push time in 14 days

PR opened TNG/ArchUnit

Add support for records (Java 14 preview feature)

I didn't touch the build environment and first implemented the API only.

For testing purposes, I committed a compiled class file, see ClassFileImporterTest: https://github.com/rweisleder/ArchUnit/blob/d8e79f72f0d93251ed67d98330acfdd31619f095/archunit/src/test/java/com/tngtech/archunit/core/importer/ClassFileImporterTest.java#L310-L320 As suggested in the issue, we should add a specific source set src/jdk14test/java. Then we could move the test to this source set. But therefore we need to make our Gradle build work with JDK 14.

Resolves #295

+213 -1

0 comment

16 changed files

pr created time in 14 days

create barnchrweisleder/ArchUnit

branch : gh-295

created branch time in 14 days

issue commentTNG/ArchUnit

Add support for records (Java 14 preview feature)

Currently, I'm having issues with Gradle and JDK 14 EA. It looks like Gradle is not ready for JDK 14 yet: https://github.com/gradle/gradle/issues/10248

Nevertheless, I try to implement this as far as possible.

rweisleder

comment created time in 16 days

PR opened TNG/ArchUnit

Fix version of Gradle in wrapper task

Belongs to #306 😉

+1 -1

0 comment

1 changed file

pr created time in 16 days

create barnchrweisleder/ArchUnit

branch : gradle-wrapper-version-property

created branch time in 16 days

issue commentTNG/ArchUnit

Please annotate ArchTest annotation with meta-annotation Testable

FYI: I created https://github.com/junit-team/junit5/issues/2168

remal

comment created time in 24 days

issue openedjunit-team/junit5

Allow @Testable on fields

Background

Currently, it's only possible to annotate classes and methods with @Testable to indicate that those are testable.

In ArchUnit we have a custom engine to execute defined architecture rules as tests. The user has to annotate the elements with @ArchTest. The engine executes all rules that are annotated @ArchTest, no matter if they are methods or fields.

Example project: archunit-example/example-junit5 Example test class: CodingRulesTest

When I open the mentioned test class in my IDE, the IDE only recognizes the class itself and the one method as testable. The fields are not recognized as testable.

Suggestion

It should be possible to (meta)-annotate fields with @Testable. With this enhancement, IDEs have the chance to identify testable fields.

Deliverables

  • [ ] ...

created time in 24 days

pull request commentTNG/ArchUnit

Add API methods to JavaPackage to read package-info.java

If we wanna break the user's code we could make the methods of HasAnnotations consistent. 😉 Currently, we have this: https://github.com/TNG/ArchUnit/blob/a15d47a64ef6fff4a7bc5f3d8e0f932c7da85016/archunit/src/main/java/com/tngtech/archunit/core/domain/properties/HasAnnotations.java#L33-L43

Some methods return JavaAnnotation and other methods with the same name return Annotation.

rweisleder

comment created time in a month

pull request commentTNG/ArchUnit

Add API methods to JavaPackage to read package-info.java

As a user of the API, I would expect

JavaAnnotation<JavaPackage> a = javaPackage.getAnnotationOfType(PackageAnnotation.class);
JavaPackage owner = a.getOwner(); // same as javaPackage

And it feels strange to handle package-info as a class because it's not really a class. We should get rid of this: https://github.com/TNG/ArchUnit/blob/f1d7da342558abc769200020350f478d2c35bec2/archunit/src/main/java/com/tngtech/archunit/core/domain/JavaPackage.java#L63

rweisleder

comment created time in a month

issue commentTNG/ArchUnit

Please annotate ArchTest annotation with meta-annotation Testable

@ArchTest is already meta-annotated with @Testable: https://github.com/TNG/ArchUnit/blob/v0.13.0/archunit-junit/junit5/api/src/main/java/com/tngtech/archunit/junit/ArchTest.java#L50-L54

Or is there something I'm missing?

remal

comment created time in a month

push eventrweisleder/ArchUnit

Peter Gafert

commit sha 945ba0e5524b3a9c8c03ea9f75d15592d32af183

update copyright header for new year Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Alen Kosanović

commit sha 568a258bfe5e039db954a1fd208335e244a2fda9

Added new static constructors of Dependency to support annotation and annotation member dependencies Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 447161b143510021bf50e41247806c7856965b79

getDirectDependenciesFromSelf accounts annotation dependencies Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha cd3cda04d6048352ef5948a02889fcc9c29a74e7

Removed overloaded methods for annotation dependency in Dependency and JavaClass Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 99dbcc8af398b2d86a3e1ed2a47c437b884a2fa8

Added owner to annotation Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha a879eb8f1bacdf50758741eddddb8b91975d3e2f

Dependencies to self are supported on class annotations Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha beb7a6ff49f41a9706938d6c65652aa7e069df00

Dependencies to self are supported on members and annotation parameters Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 83c013502e9e353cae6a8672abd1e902c2cf40e7

Merge commit fix Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha cf526bbbe0a3b11404c355500b635948fb2d3c4f

Fixed issues with primitive arrays in annotations Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 3abdc0b4e1ab19b36b4f2b2b64894d0b992f765a

Suppliers are added back to annotations in JavaClasses and JavaMembers Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha d8299a802eef442ba55815067d85653ce4932648

Removed deprecated getType accesses Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha aa4b40c35d30161e1a4235e7fb31a6bce94fbdf4

Member annotations are registered after all class members are completed Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 0222564c77ef6b7d3af29a9981f90661c92a866e

Removed call to getAllMembers. Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha a68659168eaf622c4db70f8ff09567167fb97610

Fixed failing unit tests. Added support for annotation dependencies Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

kosani

commit sha 9673717401c3f54d7b4c24bad566f5cafd0d0c95

Fixed failing integration tests. Added support for annotation dependencies Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Peter Gafert

commit sha a235adc70227332cbd3977e92160287154df1e97

Review: Unify creating member dependency and creating annotation dependency Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 5aa1dfcda10061ebdf29077ad01042df7503b095

Review: Replace duplicated test body by data provider. Add tests for constructor and method to make sure the behavior is the same for each type of member. Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha ee88783e79c0134711432758052119b2bf062512

Review: Unify Javadoc Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 5d15f8429c3b94a78d1436812f329a75581e3a69

Review: Use consistent naming and access Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 4f8964569850f960680d0ebb86fe0537e32bc8d4

Review: To be consistent with other places of ArchUnit, the "owner" of an annotation should be the closest "parent" where the annotation is declared. Like a ThrowsDeclaration on a method having that method as owner, an annotation on a method should as well. Likewise, if an annotation is a parameter of another annotation, it should still have that annotation as "owner". That way it is possible to traverse the declaration tree up and do assertions based on the specific case. Unfortunately for the dependency use case, this is a little less convenient, since we're interested in the origin class of the dependency, which now must be determined by traversal, but still the implementation of HasOwner should not be adjusted to a specific need in one place. Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

push time in a month

Pull request review commentTNG/ArchUnit

Add GeneralCodingRule to discourage use of field injection

 private GeneralCodingRules() {     @PublicAPI(usage = ACCESS)     public static final ArchRule NO_CLASSES_SHOULD_USE_JODATIME =             noClasses().should(USE_JODATIME).because("modern Java projects use the [java.time] API instead");++    /**+     * For information about checking this condition, refer to {@link GeneralCodingRules}.+     */+    @PublicAPI(usage = ACCESS)+    public static final ArchCondition<JavaField> USE_FIELD_INJECTION = useFieldInjection().as("use field injection");++    private static ArchCondition<JavaField> useFieldInjection() {+        ArchCondition<JavaField> annotatedWithAutowired = beAnnotatedWith("org.springframework.beans.factory.annotation.Autowired");

I added com.google.inject.Inject, the more the better 😉

rweisleder

comment created time in a month

issue openedTNG/ArchUnit

Extend Rule API to provide solutions for violations

When implementing #289 I wasn't sure how to write the rule text so that it's helpful and not too long, including

  • that field injection is an anti-pattern
  • links to blog posts why field injection is an anti-pattern
  • provide possible solutions (constructor/setter injection)

The produced AssertionError for violations isn't really nice to read:

java.lang.AssertionError: Architecture Violation [Priority: MEDIUM] - Rule 'do not use field injection, because this is an anti-pattern, see https://example.org/this/is/a/very/long-link-to-the-first-blog-post for detailed explanations and https://example.org/this/is/another/link-to-a-different-blog-post for project guidelines; use constructor injection instead' was violated (2 times):
Field <org.Example.demoService> is annotated with @Autowired in (Example.java:0)
Field <org.Example.userService> is annotated with @Autowired in (Example.java:0)

Maybe we can extend the rule API so that rule authors can provide possible solutions for violations. I have something like Spring Boot's Failure Analyzer in mind. The error message could look like this:

java.lang.AssertionError: Architecture Violation [Priority: MEDIUM]

Rule:
	do not use field injection, because this is an anti-pattern

Violations:
	Field <org.Example.demoService> is annotated with @Autowired in (Example.java:0)
	Field <org.Example.userService> is annotated with @Autowired in (Example.java:0)

Possible solution:
	Use constructor injection instead. See https://example.org/this/is/a/very/long-link-to-the-first-blog-post for detailed explanations and https://example.org/this/is/another/link-to-a-different-blog-post for project guidelines.

created time in a month

Pull request review commentTNG/ArchUnit

Add GeneralCodingRule to discourage use of field injection

 ext {             junit_dataprovider  : 'com.tngtech.java:junit-dataprovider:1.11.0',             mockito             : 'org.mockito:mockito-core:2.27.0',             assertj             : 'org.assertj:assertj-core:2.9.1',-            assertj_guava       : 'org.assertj:assertj-guava:2.0.1'+            assertj_guava       : 'org.assertj:assertj-guava:2.0.1',++            springBeans         : 'org.springframework:spring-beans:5.2.2.RELEASE',+            jakartaInject       : 'jakarta.inject:jakarta.inject-api:1.0',

jakarta.inject:jakarta.inject-api contains javax.inject.Inject, and jakarta.annotation:jakarta.annotation-api contains javax.annotation.Resource. I took Jakarta because they provide the latest version of these annotations.

rweisleder

comment created time in a month

Pull request review commentTNG/ArchUnit

Add GeneralCodingRule to discourage use of field injection

 private GeneralCodingRules() {     @PublicAPI(usage = ACCESS)     public static final ArchRule NO_CLASSES_SHOULD_USE_JODATIME =             noClasses().should(USE_JODATIME).because("modern Java projects use the [java.time] API instead");++    /**+     * For information about checking this condition, refer to {@link GeneralCodingRules}.+     */+    @PublicAPI(usage = ACCESS)+    public static final ArchCondition<JavaField> USE_FIELD_INJECTION = useFieldInjection().as("use field injection");++    private static ArchCondition<JavaField> useFieldInjection() {+        ArchCondition<JavaField> annotatedWithAutowired = beAnnotatedWith("org.springframework.beans.factory.annotation.Autowired");+        ArchCondition<JavaField> annotatedWithValue = beAnnotatedWith("org.springframework.beans.factory.annotation.Value");

@Value can be used on constructor parameters:

public InfoBean(@Value("spring.application.name") String applicationName) {
  // ...
}

So there is no need to use @Value on fields.

rweisleder

comment created time in a month

push eventrweisleder/ArchUnit

Peter Gafert

commit sha a15d47a64ef6fff4a7bc5f3d8e0f932c7da85016

prepare release 0.13.0 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 444306d37241da1ad8628d585b391e82eeb0ca82

adjust release check for changed artifacts The POMs were adjusted to the upgraded dependencies and an expected POM for `archunit-junit5` was added. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 8421a7eb14d48984cb86727be585eb07d8c2cf18

set new SNAPSHOT version for master Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Roland Weisleder

commit sha 8b6d86fced622d35a46c17475f5225c5e117d0ce

Add Roland as developer to published POMs Signed-off-by: Roland Weisleder <roland.weisleder@googlemail.com>

view details

Peter Gafert

commit sha 37020835ca4e09d5ccf6d5d6ac887b6c6a73d77f

Add developer to published POMs #293

view details

push time in a month

issue openedTNG/ArchUnit

Add support for records (Java 14 preview feature)

Java 14 will bring us JEP 359 (preview feature) which introduces records as a new kind of type declaration.

We should support records like we support enums. I suggest to add the following methods:

  • JavaClass.isRecord
  • classes().that().are[Not]Records()
  • classes().should().[not]BeRecords()

ASM supports records since 7.3.1 (released yesterday). The release notes are not available yet, but the code contains the merge request for records. So I guess records should be part of that version.

So that we are able to test the implementation, we need to build ArchUnit against JDK 14. Do we need an additional testing source set in our Gradle build? Or could this be done inside src/test/java?

created time in a month

delete branch rweisleder/ArchUnit

delete branch : add-developer

delete time in a month

pull request commentTNG/ArchUnit

Add developer to published POMs

Thanks for merging this and that I can be part of ArchUnit!

We should have an ArchUnit contributor meetup at some point, that would be awesome!!

Maybe we meet someday at a conference, e.g. JavaLand or WJAX. :wink:

rweisleder

comment created time in a month

push eventrweisleder/ArchUnit

Roland Weisleder

commit sha f16dbdaf783f756ca2c490ea1b38e58e23aa32a0

Extend JavaClass with methods for different kinds of classes This commit adds the methods * isTopLevelClass * isMemberClass * isAnonymousClass (as replacement for isAnonymous) * isLocalClass The JavaClassProcessor determines the kind based on byte code. The naming is based on the Java Language Specification, chapter 8. Signed-off-by: Roland Weisleder <roland.weisleder@googlemail.com>

view details

Roland Weisleder

commit sha 9bd6513ba7cf95ec52add011c7bd2fedbcfceb04

Extend syntax to query different kinds of classes This commit adds classes().that(). and classes().should(). * [are|be]TopLevelClasses * [are|be]NestedClasses * [are|be]MemberClasses * [are|be]InnerClasses * [are|be]AnonymousClasses * [are|be]LocalClasses and their corresponding negations. Signed-off-by: Roland Weisleder <roland.weisleder@googlemail.com>

view details

Roland Weisleder

commit sha 28f399425960f1c508d49a13383851c9b2775f32

Refactor: Remove/Rename redundant condition Signed-off-by: Roland Weisleder <roland.weisleder@googlemail.com>

view details

Peter Gafert

commit sha 72eb5f412eb32e926c8934cde16a3e1341eb8ba7

Review: Add more extensive Javadoc Since the fine details of the definitions of the different types of classes are probably not widely known, I've excluded some more exhaustive explanations and examples into the Javadoc. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 0fd7cd3a07a9d57d5170b0b45310baf20e5310fb

Review: Add test that implicitly static nested interface behaves like static nested class Since we are already testing the case of an explicitly declared static member class, we might as well add a member interface as another test input, since it must behave exactly the same with respect to the class type. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 222ccd2b592efe64102b9ac3771ee02802405e02

Review: Unify use of ANONYMOUS_CLASSES predicate In `PublicAPIRules` we can now also use the predefined `JavaClass.Predicates.ANONYMOUS_CLASSES`. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 6c75e211954e9218b6e344697e982bf83c4d3fe6

Review: Unify `ClassKindCondition` and `IsConditionByPredicate` These conditions actually do almost the same, `IsConditionByPredicate` simply needs to be enhanced to customize the description of a single event instead of always taking the predicate description. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 264220f34a579bcd9b2c1efb03a29f9c6f8cab1f

Review: Minor class renaming I think `InnerMemberClass` is more narrow than `NonStaticNestedClass`, because technically a local or anonymous class also is a non-static nested class. It might not always be relevant in the context, but `InnerMemberClass` at least gives me a quick understanding of exactly what type of class this is. Also `ClassAccessingLocalClass` is AFAIS a `ClassBeingAccessedByLocalClass` (it does not access the local class, but vice versa, and this is also correct for the test). Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 120246ecf04b70d9a8c90ea19c22e305a5791e77

Extend syntax to query different kinds of classes #245 adds the following methods to JavaClass * `isTopLevelClass()` * `isMemberClass()` * `isAnonymousClass()` * `isLocalClass()` also adds `classes().that().` and `classes().should().` * `[are|be]TopLevelClasses()` * `[are|be]NestedClasses()` * `[are|be]MemberClasses()` * `[are|be]InnerClasses()` * `[are|be]AnonymousClasses()` * `[are|be]LocalClasses()` and their corresponding negations. The naming is based on the [Java Language Specification, chapter 8](https://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html).

view details

Peter Gafert

commit sha 4cf0b59e29e229eaa2d30e2c186dc061363f999c

upgrade JUnit dependencies * JUnit 4 `[4.12 -> 4.13]` * JUnit Platform `[1.5.1 -> 1.5.2]` * JUnit Jupiter/Vintage `[5.5.1 -> 5.5.2]` Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 191377b08cb91c4052496676c00e5022a235eed8

upgrade JUnit dependencies #292 * JUnit 4 `[4.12 -> 4.13]` * JUnit Platform `[1.5.1 -> 1.5.2]` * JUnit Jupiter/Vintage `[5.5.1 -> 5.5.2]`

view details

push time in a month

PR opened TNG/ArchUnit

Add developer to published POMs
+5 -0

0 comment

1 changed file

pr created time in a month

create barnchrweisleder/ArchUnit

branch : add-developer

created branch time in a month

pull request commentTNG/ArchUnit

Extend syntax to query different kinds of classes

Thanks for adding the Javadoc! I wasn't sure how much I should write or if the description is enough.

rweisleder

comment created time in a month

delete branch rweisleder/ArchUnit

delete branch : gh-207

delete time in a month

push eventrweisleder/dockerfiles

Roland Weisleder

commit sha f52df12d028938f415b9bed097676086d584dec8

Download postgres-sakila-*.sql from master branch

view details

push time in a month

push eventrweisleder/spring-boot

Andy Wilkinson

commit sha 9e1825ed421f0d0ecd59d9e7b1a4712579fc9f41

Upgrade to Spring Integration 5.2.0.RELEASE Closes gh-18254

view details

Andy Wilkinson

commit sha 6a5f608f30d6d48ebc0dcaa08aedc3d15a36777f

Upgrade to Spring Kafka 2.3.0.RELEASE Closes gh-18255

view details

Vedran Pavic

commit sha 480801656060b5068007edfac14083ef3805625f

Align with Spring Session MongoDB deprecations See gh-18470

view details

Andy Wilkinson

commit sha 5a6e6cc53def298c3beeec0dae17ff2f5c031af1

Merge pull request #18470 from vpavic * gh-18470: Align with Spring Session MongoDB deprecations Closes gh-18470

view details

Andy Wilkinson

commit sha e7e69e2e169b5652c351289c8f150c62db7fa69d

Upgrade to Spring Session Corn-RC1 Closes gh-18257

view details

Andy Wilkinson

commit sha 557d1876072f61fb814fc83d66c4b6ea19e1d54f

Revert "Upgrade to Spring Session Corn-RC1" This reverts commit e7e69e2e169b5652c351289c8f150c62db7fa69d. See gh-18257

view details

Andy Wilkinson

commit sha 1222a73dcc4b651e0b7dbe181d5c581a8423a49c

Polish

view details

Phillip Webb

commit sha ecf751e7eb6cfd791a1e765fecaa3d9670a8fbbc

Polish

view details

Phillip Webb

commit sha e41c5a43273cab9dc2ce0c1c1e86ca7c633634c8

Require annotation signal for constructor binding Update `@ConfigurationProperties` constructor binding support to only apply when a `@ConstructorBinding` annotation is present on either the type or the specific constructor to use. Prior to this commit we didn't have a good way to tell when constructor binding should be used vs regular autowiring. For convenience, an `@ImmutableConfigurationProperties` meta-annotation has also been added which is composed of `@ConfigurationProperties` and `@ConstructorBinding`. Closes gh-18469

view details

kenneth

commit sha e6b45de41e71ff28471f8cd5391a275febbf00bc

Simplify some code See gh-18438

view details

Phillip Webb

commit sha b65ba6098019c5dc0526472f42bd2780471d5113

Polish 'Simplify some code' See gh-18438

view details

Phillip Webb

commit sha e2ae403ed80b4ac142a994daecbdc518333b950d

Merge pull request #18438 from 785172550 * pr/18438: Polish 'Simplify some code' Simplify some code Closes gh-18438

view details

Andy Wilkinson

commit sha e507d47571661f0a665abc878b753eafb3558311

Upgrade to Spring Session Corn-RC1 Closes gh-18257

view details

Andy Wilkinson

commit sha f029fa55da47f20f8c7e2ab08e097cc77d43e140

Upgrade to Spring Batch 4.2.0.RELEASE Closes gh-18252

view details

Andy Wilkinson

commit sha 3d4157ad6d1f210c346dc0706e65b600b2bbf0e6

Correct SCM URLs in published poms Previously, Maven's default behaviour was relied up which resulted in the artifact ID being appended to each URL as it was inherited. This behaviour can only be disabled in Maven 3.6 and later, a version that we cannot use due to an incompatibility with the Flatten Plugin. This commit works around Maven's default behaviour by defining properties for the SCM URL, connection, and developer connection and then explicitly defining the settings in each pom using these properties. The explicit definition of the properties in each pom prevents them being inherited from the parent, thereby disabling the unwanted appending of the artifact ID to the URL. Fixes gh-18328

view details

Andy Wilkinson

commit sha 46c30d6bb0e5d4df1e6d8d6d51363c8c74b378ae

Merge branch '2.1.x' Closes gh-18476

view details

Andy Wilkinson

commit sha b5069a4f8a5afd45c115d58aad2ee00d84954eef

Upgrade to Spring Asciidoctor Extensions 0.3.0.RELEASE Closes gh-18474

view details

Andy Wilkinson

commit sha dab69cfbd23314001bdd62679d1ff114b230c194

Upgrade to Promethus Pushgateway 0.7.0 Closes gh-18418

view details

Andy Wilkinson

commit sha 9e514ab7f9610ef2a86f4cd56d829e0c1e1d30e2

Provide plugin release repository for Asciidoctor Extensions See b5069a4f8a5afd45c115d58aad2ee00d84954eef

view details

Andy Wilkinson

commit sha 5b394c601b97f22eb695241d243cdf8cda696961

Polish repository id

view details

push time in a month

push eventrweisleder/spring-framework

Phillip Webb

commit sha a6021cc96890e6f909fcf9f20d8ff6dabf596359

Rename SearchStrategy.EXHAUSTIVE to TYPE_HIERARCHY Rename `SearchStrategy.EXHAUSTIVE` from `MergedAnnotations` to `SearchStrategy.TYPE_HIERARCHY` See gh-23378

view details

Phillip Webb

commit sha 17518ecbbe222c357a24bf43f38fee1de3170d54

Add TYPE_HIERARCHY_AND_ENCLOSING_CLASSES strategy Add a `TYPE_HIERARCHY_AND_ENCLOSING_CLASSES` annotation search strategy that can be used to search the full type hierarchy as well as any enclosing classes. Closes gh-23378

view details

Sam Brannen

commit sha b03dd475984bd668bf48e3916d5fb0dacbec7dea

Remove duplicate assertion

view details

Sam Brannen

commit sha de3c115614d58782f96953c548f56e650fc97ab2

Fix bug in TYPE_HIERARCHY_AND_ENCLOSING_CLASSES strategy Prior to this commit, the new `TYPE_HIERARCHY_AND_ENCLOSING_CLASSES` annotation search strategy failed to find annotations on enclosing classes if the source class was a nested class that itself had no annotations present. This commit fixes this by adding special logic to AnnotationsScanner's isWithoutHierarchy() method to properly support nested classes. Closes gh-23378

view details

Juergen Hoeller

commit sha 438b40f6d7ef830accdd6f216faec6a18c5f7ca2

Consistent ordering of WebClient.Builder methods

view details

Juergen Hoeller

commit sha ea4f7d365f87d3a8e2d1da239c5c8bf0bdba0f31

Deprecate logger field in HandlerMethodArgumentResolverComposite

view details

Juergen Hoeller

commit sha dea9ad6cb240d41ec4893c3691a4735c704ca8d2

Merge branch '5.1.x'

view details

Juergen Hoeller

commit sha 6eca9e7cc9428e6698c43b54d720d666d701ba0f

Drop logger field in HandlerMethodArgumentResolverComposite

view details

Phillip Webb

commit sha 89d150d3981aaec43bc17f195adfee80786560ab

Resolve factoryBeanClass if necessary Update `AbstractAutowireCapableBeanFactory.getTypeForFactoryBean` to use fallback to `determineTargetType` if the factory bean definition does not have a resolved class. This is required for the case where a `@Configuration` class is picked up via component scanning and has a bean type that has not yet been resolved. Closes gh-23338

view details

Phillip Webb

commit sha 62a3e414734b24d1801b34223df5faaae9e32b5f

Deprecate mutable methods of MethodParameter Deprecate all mutation methods in `MethodParameter` in favor of factory methods that return a new instance. Existing code that previously relied on mutation has been updated to use the replacement methods. Closes gh-23385

view details

Phillip Webb

commit sha 1e830f725c636d9c17c693950c273827d6efe39d

Polish firstRunOf javadoc

view details

liym@com

commit sha fde651a606c13e69284d9cebdcf885ff669700e8

Polish getTypeForFactoryBean comment See gh-23394

view details

Stephane Nicoll

commit sha 223074295d529302150c31ec1bc2e24650ee3ce3

Merge pull request #23394 from ijliym * pr/23394: Polish getTypeForFactoryBean comment Closes gh-23394

view details

Juergen Hoeller

commit sha 4612544505b45d4bb30ca514632265c2e783c57c

Nullability refinements and related polishing

view details

Sergey Galkin

commit sha 59aee923e45e91ae336354f30d20478b8fc3f8ad

Add filter to AbstractCachingViewResolver This commit introduces a filter that specifies whether a View should be cached by the AbstractCachingViewResolver or not. Closes gh-22391

view details

Arjen Poutsma

commit sha 132fa702b75e46a2de01d2dceaf89ef4e25295fd

Polish contribution See gh-22606

view details

Arjen Poutsma

commit sha 8b1a2a70e17b02495387775373dba9175a5f84e5

Merge pull request #22606 from fred84/22391_conditional_view_caching * 22391_conditional_view_caching: Polish contribution Add filter to AbstractCachingViewResolver

view details

Juergen Hoeller

commit sha b67dbe66ef43e6faca7886a36ebc6f9e9a1fd8f4

Revise use of ResolvableType in MethodParameter Includes consistent use of getContainingClass()

view details

Juergen Hoeller

commit sha 49593f5399a8053414bd7a0a11566d74f9eae018

Revise DependencyDescriptor etc to avoid MethodParameter deprecations See gh-23385

view details

Juergen Hoeller

commit sha aebc485edae982c9e4b98f8f2558d515813c2bb6

MethodParameter.equals properly checks overridden containing class Closes gh-23352

view details

push time in a month

delete branch rweisleder/jOOQ

delete branch : sakila-postgres-fix

delete time in a month

push eventrweisleder/jOOQ

Roland Weisleder

commit sha 63588967b9057e8f8a33d446752d2e7475b15044

Sakila/PostgreSQL: Don't fail if language plpgsql already exists When using the Sakila DB with the Docker image postgres:12.1 the initialisation fails with: ERROR: language "plpgsql" already exists With PostgreSQL 8.4 (see [1]) and earlier it was only possible to execute: CREATE [ PROCEDURAL ] LANGUAGE name Starting with PostgreSQL 9.0 (see [2]) it is possible to execute: CREATE [ OR REPLACE ] [ PROCEDURAL ] LANGUAGE name This commit makes the SQL script incompatible with PostgreSQL 8.4 and earlier. [1] https://www.postgresql.org/docs/8.4/sql-createlanguage.html [2] https://www.postgresql.org/docs/9.0/sql-createlanguage.html

view details

Knut Wannheden

commit sha 588bf7036d24d2c03247bc284ef8903c32e5319d

Upgrade to JUnit 4.13 Removes jOOQ's own `assertThrows()` utility in favor of that in JUnit.

view details

Knut Wannheden

commit sha 7c08ea1e56efc978ece028ef3aa095acc299a0bd

Cleanup: Regenerate jOOQ-spark-chart-example without @Generated

view details

Knut Wannheden

commit sha 680cd20d0829f1ec3bb345d3e70e4e1eb3d31705

[jOOQ/jOOQ#5714] Update examples where Date is now LocalDate With [jOOQ/jOOQ#5714] the default value of `<javaTimeTypes>` changed from `false` to `true`. This also requires a few changes in the example code.

view details

Knut Wannheden

commit sha 33c517a1c868ef3771131b04faaed8466784af56

[jOOQ/jOOQ#9708] Fix regex based schema mapping (with backreferences) The way the schema mapping was implemented resulted in the schema mapping always getting applied twice during the rendering. This was problematic for regex based schema mappings using backreferences. This commit changes the schema mapping logic so that `SchemaMapping#map(Schema)` doesn't "recursively" map schemas. I.e. any given schema is only mapped once.

view details

Knut Wannheden

commit sha 8c225c45014e3cbe312a2c8a4096f8896fa553a1

Merge pull request #9700 from rweisleder/sakila-postgres-fix Sakila/PostgreSQL: Don't fail if language plpgsql already exists

view details

Knut Wannheden

commit sha 922b62b444232a0e5357643635a74898dc469aa2

Cleanup: Regenerate some more example code

view details

Knut Wannheden

commit sha aa35783e556863311461f9a05e2ffee4f4579a2f

[jOOQ/jOOQ#9598] Fix race condition caused by Tools#PARSER Since this package private field `Tools#PARSER` isn't used anywhere, it can just be deleted.

view details

Knut Wannheden

commit sha 2778b203757e09c028a697d60cae76a2a3fb29f3

[jOOQ/jOOQ#9719] Support MySQL's single argument ISNULL() in parser

view details

Knut Wannheden

commit sha 93bfffea5c9a24ac9d1c0e74aacbb4de092cea7b

[jOOQ/jOOQ#9718] Fix return type of fields(LoaderFieldMapper) methods The `LoaderCSVStep#fields(LoaderFieldMapper)` and `LoaderJSONStep#fields(LoaderFieldMapper)` methods now have the correct return type.

view details

push time in a month

push eventrweisleder/junit5

Marc Philipp

commit sha fbd90b4d80776d1b57923f84b082c9bb709a2908

Back to snapshots for further development

view details

Marc Philipp

commit sha 7c5659f4cdeedae3fda81b0b213ad763ace92c06

Fix discovery of inherited nested classes The discovery algorithm introduced in 5.5 remembers already the resolution of each discovery selector. Prior to this commit, nested classes were resolved by adding a ClassSelector for the nested class. If that ClassSelector has been resolved before, discovery is assumed to be finished. Similarly, when resolving MethodSelectors for methods within a nested test class that have been resolved before, discovery will stop. This commit introduces dedicated selectors for nested classes and their methods which take into account the actual enclosing classes that will be present at runtime. These selectors are package-private for now but could be made publicly available in a future release. Fixes #1954.

view details

Marc Philipp

commit sha 28cf33919034858cb1ad5273b08994050b2f8db7

Backport NestedTestClassesTests

view details

Marc Philipp

commit sha 657be4abe8874240f9bacc3e0399026734493bd5

Release 5.5.1

view details

Marc Philipp

commit sha edcba1c5f1c510e98139cf76ba8cc937009ba952

Back to snapshots for further development

view details

Marc Philipp

commit sha 42b131c64b801026a1f5d2676b776e9699e6aef0

Upgrade ArchUnit to 0.11.0

view details

Marc Philipp

commit sha 966833c77f326250204f737931f8b52aae12f3f3

Fix Test task config to execute ArchUnitTests

view details

Marc Philipp

commit sha d7f2976c7608f3d8c043467e0aa5162a38661c1b

Use ArchUnit to check for API annotations All public, top-level types are now checked for `API` annotations. Two offending classes are fixed: `DynamicExtensionContext` by making it package-private, `ArgumentsAccessor` by adding an annotation.

view details

Marc Philipp

commit sha 0f2d2a7f7ccce800f867544b2cf1bea112bb9364

Polish ArchUnit rule

view details

Marc Philipp

commit sha 336945b56c79283c0efd2d5ee6c23c9fdc2ea148

Auto-detect enum type from method signature The `value` attribute of the `EnumSource` annotation is now optional. When omitted, the declared type of the first method parameter is used. The test will fail if it does not reference an enum type. Resolves #1973.

view details

Christian Stein

commit sha deff65695215acb8b90aaa4713d51495ae371bb1

Removed superseded comment Thanks @jbduncan

view details

Roland Weisleder

commit sha 0d0624d980ba715168744259ae78cdaf38ed0785

Remove misleading comment

view details

Marc Philipp

commit sha 11352c3ad321cb878f6ac221858b8dec967f86d3

Use new plugin version management syntax This resolves a Gradle deprecation warning for referencing a buildSrc class from settings.gradle.kts.

view details

Marc Philipp

commit sha 128eca058cc2023be905982b00c8029b6deb14f4

Upgrade Gradle plugins

view details

Marc Philipp

commit sha 148a8af71c4010ed4e1aa3d9dc804f367e39edf7

Upgrade dependencies

view details

Marc Philipp

commit sha 24c4098c609e71a6253df15ad46a6c7c13534c78

Upgrade picocli to 4.0.3

view details

Christian Stein

commit sha df2ec3ea31d9a2b2491305a438c498b60e9691eb

Let OpenJDK 13 errors halt the build

view details

Marc Philipp

commit sha ada66c4f698e48ed01d3bd787af2bfd96f5f661b

Upgradle to 5.6.2 and remove workaround

view details

Christian Stein

commit sha bf46ff1074c31265d1f636ad2e9f23bffe3164ef

Correct file type of module descriptors included in JAR files Prior to this commit, all JAR files generated for a published module included their compiled module descriptor within the root directory of the artifact. This commit a) includes the compiled module descriptor only in JAR files that have no classifier specified and b) stores the source of each module descriptor within the matching `*-source.jar` file. Fixes #2003

view details

Marc Philipp

commit sha 3f491f3148d2c745808fc75b0a802b60243e104e

Add tags, a link, and custom values to build scans

view details

push time in a month

push eventrweisleder/assertj-core

Pascal Schumacher

commit sha 89fa4d550c6fdafe07c2e34d8b2db09f859f7ba0

ConstructorInvoker: Do not call #setAccessible on objects returned by Class#getConstructor because Class#getConstutor only returns accessible objects.

view details

Pascal Schumacher

commit sha 392fc22eeb7a06a5e09a2475b049e7e102702b80

Drop unused constant ConstructorInvoker#CONSTRUCTOR_INVOKER.

view details

Stefano Cordio

commit sha ad5fb35519abd3e9aac8af1de9b1adbd1a60d4b2

Enforce banned dependencies in maven-enforcer-plugin

view details

Pascal Schumacher

commit sha 2be3298e0e40f8d8bd31c6c4e9d94ba64162414d

Update ByteBuddy to version 1.10.0.

view details

Stefano Cordio

commit sha 94c9fdec75d1ceb13a2c5eb94639f8ff88f916cd

Fix javadoc typo

view details

Joel Costigliola

commit sha 125e0bdc611acf9a61a95ff3482c7798265f26cc

[maven-release-plugin] prepare release assertj-core-3.13.2

view details

Joel Costigliola

commit sha 7d83b34469966597c0a623558a377d3c4a045542

[maven-release-plugin] prepare for next development iteration

view details

epeee

commit sha faa64b0df00659b12a409b65c5c63e88b51cf08f

fix some typos

view details

epeee

commit sha 3d8877633eec19503bc7557e5e51c90bbc08c9d3

fix typos in Configuration.java

view details

epeee

commit sha e3fc50f70802d4ae69a9b52dad3365065ba14586

Update guava to version 28.0

view details

epeee

commit sha 3a9243e91db40ed34bf92e28c7b48b03cb07d56a

fix typos in RecursiveComparison*.java

view details

epeee

commit sha 39dec047cbd724db4a19f6b63e06bee081fa36c7

fix typos in ThrowableAssertAlternative and TypeComparators

view details

Erhard Pointl

commit sha 44f116e62e161667894d0a236501cc163c9cd940

fix possible MissingFormatArgumentException in ShouldHaveMessage (#1576) fixes #1574

view details

epeee

commit sha 85cf833092e083bb4729dc3d5da98c2632e1c112

fix typo in AbstractStringAssert

view details

epeee

commit sha a58805bbbeb6c5fbbd7b0277d1d66518d7400c65

Update ByteBuddy to version 1.10.1 see https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.10.1 for details

view details

epeee

commit sha ce7be17efbd5ad7fe655c9f6b6578eb4db179937

fix AbstractObjectAssert.hasFieldOrPropertyWithValue documentation example (fixes #1558)

view details

Joel Costigliola

commit sha 9af09105e01168c70662e60fe0ed6ccd129bff98

Fix javadoc search

view details

Joel Costigliola

commit sha 4bfc00b3c3d7dd6b907b1aa5b9a5d6b49a460ef1

Use AssertJ's site code style for javadoc. Fixes #1580

view details

Joel Costigliola

commit sha 5836dec8a27bc34da5cc7abfcdecd726bbc5166c

Add java 13 profile to avoid specifying the non supported javadoc option --no-module-directories https://bugs.openjdk.java.net/browse/JDK-8215582

view details

Stefano Cordio

commit sha 0203433d7b028eab5faa187bdaa084f6613b0885

Add extracting(String, InstanceOfAssertFactory) to AbstractObjectAssert

view details

push time in a month

push eventrweisleder/pdfcompare

Pascal Wittmann

commit sha 8de964adfac0a868f5d52e17f58c9fbf9b478fb8

Update slf4j to version 1.7.27

view details

Pascal Wittmann

commit sha dd3c8c83896bd0b6bd0520c0415be319563d50cd

Update nexus-staging-maven-plugin to version 1.6.8

view details

Pascal Wittmann

commit sha 1b4ccea79d21802a13caae052bda598a2c745c32

Work around travis-ci/travis-ci/issues/6593

view details

Pascal Wittmann

commit sha 2c9f94699f903a01afce75e10d255c7c11c6a619

Set minimum maven version to 3.0.5 as is required from super-pom

view details

Pascal Wittmann

commit sha 83d6149d48cb03816d2ab3086862dfa27f7171a4

Update maven-compiler-plugin to version 3.8.1

view details

Pascal Wittmann

commit sha c296f287260c3563d91c83ee1ccce213bf5578f6

Update maven-javadoc-plugin to version 3.1.1

view details

Pascal Wittmann

commit sha 66142338b4380d118c3c2a9085b179e9c9385226

Update maven-shade-plugin to verson 3.2.1

view details

Pascal Wittmann

commit sha 27f97b9b2084d49e558cfc05e7cdbb4403a37cfb

Update maven-source-plugin to version 3.1.0

view details

Pascal Wittmann

commit sha f61f4caa0f83e212c7e9336dfe867b37ac078275

Redirect test output to file

view details

Pascal Wittmann

commit sha 201f88e30fa3d86780d6b19b12c72313e7fa7bf5

JDK8 and JDK11 agree now on the pixel difference

view details

Pascal Wittmann

commit sha 5f3466b0df4195652b4475c2b5083a410a0e7663

Revert "JDK8 and JDK11 agree now on the pixel difference" Apparently only on my machine… This reverts commit 201f88e30fa3d86780d6b19b12c72313e7fa7bf5.

view details

Pascal Wittmann

commit sha 8616b50cf8e137ba04077b6bddb4cf3adcc7c7e7

Switch from oraclejdk to openjdk

view details

Pascal Wittmann

commit sha f5be2f0e1d051efe6634ddbd68c3a29a01b1913a

Update junit to version 5.5.2

view details

Pascal Wittmann

commit sha dd0c94bc610b02458b41178f7f225044cab9769f

approximateMaxMemoryUsageInMegaBytes should be a long

view details

Pascal Wittmann

commit sha 9ab19487909108029272d23f7a5cd4549539c47f

Make synchronized methods superclass synchronized in subclass as well

view details

Malte Finsterwalder

commit sha b6b52d4d14e4a13d8d4d1ef7c94b56305b157dd2

Add JavaDoch, update README, deprecate PdfComparator.with(PageArea)-method and use PdfComparator.withIgnore(PageArea) instead

view details

Malte Finsterwalder

commit sha fb0bfb5e791abb17e781829434c8e4b68f44cd59

deprecate PdfComparator.with(PageArea)-method and use PdfComparator.withIgnore(PageArea) in tests

view details

Malte Finsterwalder

commit sha 42e023938a03d25c7c014c54cf08e6d23217c837

Prevent null as parameters; Add JavaDoc and logging, when files are not found.

view details

Malte Finsterwalder

commit sha 0b6e754e249e909643ea2fb979d39b533ccdd5aa

remove superfluous {@code ...} from JavaDoc

view details

Malte Finsterwalder

commit sha eebe48bcfe0d467f8b2509f54f93165965537bfd

[maven-release-plugin] prepare for next development iteration

view details

push time in a month

push eventrweisleder/togglz

Matt Spotts

commit sha 0e619caa7f3dfcd4fdab93569d3313c11ff8af8c

Issue 315 (#324) * Updated bootstrap and jquery libraries. #315 * adding jquery-min for #315

view details

Bennet Schulz

commit sha 7b848093a43836de87636b3000e236b77ada5388

remove obsolete jquery.js file (#326) We don't need this jquery file anymore because we are using the minified version instead.

view details

Bennet Schulz

commit sha 8245e01e3b8ad5d018dbf6336920fe5c68620591

Remove GitHub template files (#327) We don't need these templates anymore because we have active maintainers :-)

view details

Bennet Schulz

commit sha e51c7b31cf4762c2564215b8f6dd8ba24d528044

Update README.md

view details

Andreas Danhof

commit sha c36216da3c8dc76cfae77a01a1a42820f27b39e5

Add OWASP dependency check plugin (#329) * add OWASP dependency check plugin (#328) * suppress false positive findings from OWASP dependency check plugin (#328) * don't analyze pom projects for OWASP dependency check * cache OWASP dependency check db to speed up builds

view details

Bennet Schulz

commit sha 53fe67e2ce277e711887eafc14e1dfc982804b67

update hazelcast dependencies (#330)

view details

Bennet Schulz

commit sha 4213a3c0c421f52b3d1094001c8db962f5e6a2a6

update jackson databind dependencies (#331)

view details

Bennet Schulz

commit sha 39d283d5372c725cda9e223383a2382a20b36048

update junit and maven surefire plugin (#334) * update junit and maven surefire plugin * use junit 4.10

view details

Bennet Schulz

commit sha 473a79a3f4da1efdf8686693a86db79476562566

update additional libraries (#336) * update additional libraries * update guava and guice

view details

Guido Steinacker

commit sha bd1b83f617e28640a02f0b2cd41fb69617a2c3ad

Adds ListenableStateRepository delegate to address callback-requirement #178 (#333)

view details

Bennet Schulz

commit sha 8b10ee46697b8f1a0eb1a5f706a6059437fac92b

update togglz console dependencies (#337)

view details

Joshua Bacher

commit sha 5c9d0a40a6aaff43a818c63baf677d751c64823b

Exchanging Forbidden to Bad Request (#319) this makes it easier to distinguish errors caused by wrong request against authentification issues.

view details

Bennet Schulz

commit sha 62bd2b04b2340a57e4efd957e24e55b759b102b4

update junit and corresponding mocking dependencies (#338)

view details

Bennet Schulz

commit sha d9b09aaa4fc38f7e85e2d88bad8bef441089ad8d

update dependencies (#339)

view details

dependabot[bot]

commit sha a6a2adad472aa6f71feb01407edd9fdce58961da

Bump jackson-databind from 2.9.9.3 to 2.9.10.1 in /amazon-s3 (#344) Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.9.3 to 2.9.10.1. - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha 4b5213020d9c5ee96790303a059a560f6780e333

Bump jackson-databind from 2.9.9.3 to 2.9.10.1 in /dynamodb (#343) Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.9.3 to 2.9.10.1. - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha baa18b7e4b1393af6095493ad0ba270f8d9b0f94

Bump jackson-databind from 2.9.9.3 to 2.9.10.1 in /slack (#346) Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.9.3 to 2.9.10.1. - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Signed-off-by: dependabot[bot] <support@github.com>

view details

dependabot[bot]

commit sha 018bad07cab68bac898f2c1a312ad2ee4d719592

Bump jackson-databind from 2.9.9.3 to 2.9.10.1 in /zookeeper (#345) Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.9.9.3 to 2.9.10.1. - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) Signed-off-by: dependabot[bot] <support@github.com>

view details

Bennet Schulz

commit sha fe0fea99391abeb45dfec05591559beeafc7f13f

Create maven.yml

view details

Guido Steinacker

commit sha 005fed93e7f17245e0d1f78fbab86b0f82c57009

Updates to Spring Boot 2.2 (#340) * Updates to Spring Boot 2.2 * Updates Spring Framework to 4.3.25.RELEASE * update to spring boot 2.2.1

view details

push time in a month

push eventrweisleder/spring-security

Brendt Lucas

commit sha 8ebfba3019e337543e954670373916d93496bed7

Support configuration of protocol binding for authentication requests

view details

Roland Weisleder

commit sha f4b9abdbb1c9ede3bc285198f682eab024a7c3d9

Fix typo in Javadoc

view details

Ramon Pires da Silva

commit sha 0387723334d673a69565b973c45590bf4b694f5c

fix webflux samples documentation path The documentation of webflux integration sample projects was pointing to the `javaconfig` instead of `boot` folder.

view details

Isaac Cummings

commit sha 1081066d60017f77c8224d2114b59892d4b68e2e

Polish AuthorityUtils Changed parameter name to authorities Added JavaDoc Fixes gh-4805 Co-authored-by: Everett Irwin <everettirwin77@gmail.com>

view details

Eleftheria Stein

commit sha 264daec6975cacde3553bc06baa7300fe12d4c1b

Test context relative URL with multiple schemes

view details

Everett Irwin

commit sha 6ad328f909525bedabbc9ac4978d7ee7f0e84ced

Add Clock Skew Tests Fixes gh-7511 Co-authored-by: Isaac Cummings <josh.cummings+zac@gmail.com>

view details

Markus Öllinger

commit sha a449d6c316fa3f7f729e28cb3c19e44fad849af7

extract permission mask comparison for subclasses to override

view details

Markus Öllinger

commit sha a4ea989e9c24c85fbcd7c7f9e8f256c8d26431a5

remove trailing whitespace

view details

Markus Öllinger

commit sha 2cc05550fc0456f8444ce90d81cd8c9b6af8fd43

rename comparison method to isGranted and add test

view details

Eleftheria Stein

commit sha 2d26be9446285c84fd33be8447f07a8c7296e125

Remove redundant public modifier

view details

Giovanni Lovato

commit sha 63607ee213c74d84ef52167ac08a2f67eb0b2f89

Add configurable mapping function to map authorities

view details

Tadaya Tsuyukubo

commit sha 62c7de03c33cdea6c8c855079cbb71853facade9

Add RequestMatcher to AbstractPreAuthenticatedProcessingFilter Moved the existing auth check logic to the matcher. Issue: gh-5928

view details

Joe Grandja

commit sha 1c53a7859b33ba181a32a671c82441f41f96adab

Fix access token expiry check with clock skew Fixes gh-7511

view details

Michel Palourdio

commit sha d26f40f0621ec111f11cd28eabb3a135dafb6b6a

DefaultRedirectStrategy should redirect to root if the context-relative URL does not contain the context-path.

view details

Phil Clay

commit sha 8584b12c8da9b73b2579df91b81ff86a49e4daa0

Make saveAuthorizedClient save the authorized client Previously, saveAuthorizedClient never actually saved the authorized client, because it ignored the Mono<Void> returned from authorizedClientRepository.saveAuthorizedClient. Now, it does not ignore the Mono<Void> returned from authorizedClientRepository.saveAuthorizedClient, and includes it in the stream, and therefore it will properly save the authorized client. Fixes gh-7546

view details

Filip Hrisafov

commit sha b9f122230bd8345012445a6bf8b7cfa324a09440

Align javadoc of continueFilterChainOnUnsuccessfulAuthentication with actual behaviour

view details

Eleftheria Stein

commit sha de7cbc82b5af286d3763438ef656d72b1f50e744

Clarify in Javadoc that expressionHandler should not be null Fixes: gh-2665

view details

Rob Winch

commit sha 02aaba37cda770f5eab83947d84ba00fc6295f79

Documentation TOC on the left This better aligns with other documentation Issue gh-2567

view details

Rob Winch

commit sha 55a98b996919fa1a46e93749ca5f41185c5bc217

CSRF Documentation Issue gh-2567

view details

Rob Winch

commit sha 08fb9c960b1fe0ff0353bac81f1090581aeeb1bf

Fix invalid ids Issue gh-2567

view details

push time in a month

push eventrweisleder/ArchUnit

Peter Gafert

commit sha 945ba0e5524b3a9c8c03ea9f75d15592d32af183

update copyright header for new year Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Alen Kosanović

commit sha 568a258bfe5e039db954a1fd208335e244a2fda9

Added new static constructors of Dependency to support annotation and annotation member dependencies Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 447161b143510021bf50e41247806c7856965b79

getDirectDependenciesFromSelf accounts annotation dependencies Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha cd3cda04d6048352ef5948a02889fcc9c29a74e7

Removed overloaded methods for annotation dependency in Dependency and JavaClass Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 99dbcc8af398b2d86a3e1ed2a47c437b884a2fa8

Added owner to annotation Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha a879eb8f1bacdf50758741eddddb8b91975d3e2f

Dependencies to self are supported on class annotations Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha beb7a6ff49f41a9706938d6c65652aa7e069df00

Dependencies to self are supported on members and annotation parameters Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 83c013502e9e353cae6a8672abd1e902c2cf40e7

Merge commit fix Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha cf526bbbe0a3b11404c355500b635948fb2d3c4f

Fixed issues with primitive arrays in annotations Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 3abdc0b4e1ab19b36b4f2b2b64894d0b992f765a

Suppliers are added back to annotations in JavaClasses and JavaMembers Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha d8299a802eef442ba55815067d85653ce4932648

Removed deprecated getType accesses Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha aa4b40c35d30161e1a4235e7fb31a6bce94fbdf4

Member annotations are registered after all class members are completed Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha 0222564c77ef6b7d3af29a9981f90661c92a866e

Removed call to getAllMembers. Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Alen Kosanović

commit sha a68659168eaf622c4db70f8ff09567167fb97610

Fixed failing unit tests. Added support for annotation dependencies Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

kosani

commit sha 9673717401c3f54d7b4c24bad566f5cafd0d0c95

Fixed failing integration tests. Added support for annotation dependencies Issue: #136 Signed-off-by: Alen Kosanović <alen.kosanovic@svgroup.hr>

view details

Peter Gafert

commit sha a235adc70227332cbd3977e92160287154df1e97

Review: Unify creating member dependency and creating annotation dependency Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 5aa1dfcda10061ebdf29077ad01042df7503b095

Review: Replace duplicated test body by data provider. Add tests for constructor and method to make sure the behavior is the same for each type of member. Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha ee88783e79c0134711432758052119b2bf062512

Review: Unify Javadoc Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 5d15f8429c3b94a78d1436812f329a75581e3a69

Review: Use consistent naming and access Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 4f8964569850f960680d0ebb86fe0537e32bc8d4

Review: To be consistent with other places of ArchUnit, the "owner" of an annotation should be the closest "parent" where the annotation is declared. Like a ThrowsDeclaration on a method having that method as owner, an annotation on a method should as well. Likewise, if an annotation is a parameter of another annotation, it should still have that annotation as "owner". That way it is possible to traverse the declaration tree up and do assertions based on the specific case. Unfortunately for the dependency use case, this is a little less convenient, since we're interested in the origin class of the dependency, which now must be determined by traversal, but still the implementation of HasOwner should not be adjusted to a specific need in one place. Issue: #136 Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

push time in a month

startedfridujo/classpath-junit-extension

started time in a month

PR opened TNG/ArchUnit

Add API methods to read package-info.java

Resolves #263

+264 -1

0 comment

4 changed files

pr created time in 2 months

create barnchrweisleder/ArchUnit

branch : gh-263

created branch time in 2 months

push eventrweisleder/ArchUnit

Peter Gafert

commit sha 9d6943e2492a662a5c38248fc97643e5cb08f94c

Drop filtering of self access from JavaAccessCondition -> This turned out to be confusing API (the methods sound too generic to assume self-accesses would be filtered) while not serving its original purpose (to ease scenarios where accessedByPackage(..) had to declare the own package) anyway. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 9d06ecaaf720495ab61d627a2b0ff2b47a6a0987

Merge pull request #233 from TNG/remove-self-filtering-of-callMethodWhere Drop filtering of self access from JavaAccessCondition

view details

Miguel

commit sha 62e202ad7198a855c09fbc964519f63588248aa5

Check that layered architecture does not contain empty layers Closes #177 Signed-off-by: Miguel Ortega <miguel.ortega84@gmail.com>

view details

Peter Gafert

commit sha 676cc3732a69961f332518c954733cd2c38bbe38

Review: Made message more consistent - usually violations just describe the current state ("Method <..> calls method <..> in line ..."), thus it is more consistent to just report "layer x is empty" as an error message instead of "layer x should not be empty". Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 1dd5883a7454047ba3b618d40956e84efbf95d27

Review: resideInAnyPackage is part of the fluent API Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha b02fdc4eccec52c59c7dfcc8b26ebb3950e98296

Review: Minor refactoring, we don't really need to store the class names, since nothing is done with this information afterwards. A simple boolean telling us if the layer is empty is actually sufficient. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 4cad7cc79c4979c182a3ff049d08b42565a5aca4

Merge pull request #237 from mikomatic/issue-177 Check that layered architecture does not contain empty layers - Issue #177

view details

Miguel Ortega

commit sha 7eb5070c5d8c274d43b3237ba1e20653b5ac87a5

Rename function to convey more accurate checking > Signed-off-by: Miguel Ortega <miguel.ortega84@gmail.com>

view details

Miguel Ortega

commit sha 333896e0aa467920ee6b4428d37f468a330f4458

add possibility to define layers of layered architecture by predicate, not just by package Issue: #228 > Signed-off-by: Miguel Ortega <miguel.ortega84@gmail.com>

view details

Peter Gafert

commit sha 736f1ae155e999886fd9d6e0d436015c3a95a9b4

Review: Extracted some logic to new class LayerDefinitions, since it felt that too many low level aspects of converting layers to predicates were covered by LayeredArchitecture, i.e. mixing of different abstraction levels. Also replaced copy & paste test with ignores by DataProvider tests for the two essential aspects, reporting violations and the description. The description of predicates was not covered by any test. Moved the quotes "'%s'" to the description of definedBy(packages), since an arbitrary predicate should have the freedom to decide, if it wants to be quoted or not. Also the description "..foo'. '..bar.." without quotes around made no sense, so you had to look in two separate places to understand the connection.

view details

Peter Gafert

commit sha 45a808b464330bdbe9871df01c5684df71817cd7

Merge pull request #238 from mikomatic/issue-228 Add the possibility to define a layer using a DescribedPredicate Resolves: #228

view details

Alexander Fedorenchik

commit sha 571a26de286a4a7e4849c1b5e9a762fb894795e7

Handling of SYNTHETIC and BRIDGE modifiers was added. Issue: #212 Issue: #87 Signed-off-by: Alexander Fedorenchik <alexander.fedorenchik@gmail.com>

view details

Peter Gafert

commit sha da5b6f4b1d7d6c660ebb88fb7c1773bb5f0a8c9d

Review: Simplify test and add some comments as to why synthetic / bridge members are created in the example class Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 4248da4d104dc2555e51f36ebd460a0877aad59b

Merge pull request #243 from alexfedorenchik/synthetics Handling of SYNTHETIC and BRIDGE modifiers added

view details

Manfred Hanke

commit sha 922f9dcff77aba8144d52c0b794ba8b9bfe83c77

update ASM to 7.2, adding support for Java 14 (resolves #230) Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>

view details

Peter Gafert

commit sha 4a6811fff86e629d7f2e60c582164b343697585a

Merge pull request #247 from hankem/asm-7.2 update ASM to 7.2, adding support for Java 14 (resolves #230)

view details

Peter Gafert

commit sha 695a9ae0a71686e65db3f087d6b7dbff9a5b52d9

Any property of archunit.properties can now be overwritten on the fly by passing the key prefixed with "archunit." as system property "-Darchunit.key.in.props=overwritten" Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha c2e4492e6fab5747f9ab2a4fcc5883ea42c8a3bb

It is now possible to explicitly allow/prevent default store creation and update Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha e946a3f1136ed0e4e26217bc0d23ac8f7be08057

Update docs to include the advanced FreezingArchRule configuration and the possibility to override ArchUnit configuration by system properties. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 989918f8198e929f8e4ecb95e7f48d943c9e6566

Merge pull request #252 from TNG/enhance-freezing-archrule Enhance FreezingArchRule

view details

push time in 2 months

issue commentTNG/ArchUnit

Default condition to avoid field Injection and haveConstructor Injection

@smfaizalkhan, if you want to ensure that your developers use constructor injection when using CDI, I suggest making all fields final. This has two main advantages:

  1. The Java compiler fails if a field is not initialized in the constructors or in the field declaration.
  2. The ArchUnit rule gets much shorter: fields().that().areDeclaredInClassesThat().xyz().should().beFinal().check(javaClasses)

Or is there a reason I'm missing why classes that are created by the CDI container should not contain final fields?

smfaizalkhan

comment created time in 2 months

push eventrweisleder/ArchUnit

Roland Weisleder

commit sha 4ca8363d1e9853fb8ff8da24ec9236a5247ff64a

Add GeneralCodingRule to discourage use of field injection Resolves #288 Signed-off-by: Roland Weisleder <roland.weisleder@googlemail.com>

view details

push time in 2 months

PR opened TNG/ArchUnit

Add GeneralCodingRule to discourage use of field injection

Resolves #288

+110 -1

0 comment

4 changed files

pr created time in 2 months

create barnchrweisleder/ArchUnit

branch : gh-288

created branch time in 2 months

issue commentTNG/ArchUnit

Default condition to avoid field Injection and haveConstructor Injection

In my own library of ArchUnit rules I added a similar rule to prevent field injection:

public static final ArchRule DO_NOT_USE_FIELD_INJECTION = noFields()
		.should(beAnnotatedWith("org.springframework.beans.factory.annotation.Autowired"))
		.orShould(beAnnotatedWith("org.springframework.beans.factory.annotation.Value"))
		.because("field injection is evil, see http://olivergierke.de/2013/11/why-field-injection-is-evil/");

Maybe we could add this to GeneralCodingRules? If so, we could also add javax.inject.Inject and javax.annotation.Resource to this list. (Are there more common annotations for field injection?)

smfaizalkhan

comment created time in 2 months

create barnchrweisleder/dockerfiles

branch : master

created branch time in 2 months

created repositoryrweisleder/dockerfiles

created time in 2 months

PR opened jOOQ/jOOQ

Sakila/PostgreSQL: Don't fail if language plpgsql already exists

When using the Sakila DB with the Docker image postgres:12.1 the initialisation fails with: ERROR: language "plpgsql" already exists

With PostgreSQL 8.4 (see [1]) and earlier it was only possible to execute: CREATE [ PROCEDURAL ] LANGUAGE name

Starting with PostgreSQL 9.0 (see [2]) it is possible to execute: CREATE [ OR REPLACE ] [ PROCEDURAL ] LANGUAGE name

This commit makes the SQL script incompatible with PostgreSQL 8.4 and earlier.

[1] https://www.postgresql.org/docs/8.4/sql-createlanguage.html [2] https://www.postgresql.org/docs/9.0/sql-createlanguage.html

+2 -1

0 comment

2 changed files

pr created time in 2 months

create barnchrweisleder/jOOQ

branch : sakila-postgres-fix

created branch time in 2 months

fork rweisleder/jOOQ

jOOQ is the best way to write SQL in Java

https://www.jooq.org

fork in 2 months

issue commentTNG/ArchUnit

Provde a bill of materials for archunit

We could do the same as JUnit 5 itself. They provide the artifact junit-jupiter which users add as test-scoped dependency. junit-jupiter has a compile-scoped dependency to junit-jupiter-api and a runtime-scoped (test-runtime-scoped) dependency to junit-jupiter-engine.

see junit-jupiter

joshiste

comment created time in 3 months

issue commentspring-projects/spring-boot

Unexpected settings in effective pom when inheriting from spring-boot-starter-parent

Thanks for resolving this, @wilkinsona! But what about <description>, <url> and <scm>, should users override them as well? I think users shouldn't use the defaults.

rweisleder

comment created time in 4 months

delete branch rweisleder/ArchUnit

delete branch : gh-236

delete time in 4 months

issue commentTNG/ArchUnit

fields().should().notHaveRawType(CanBeAnnotated.Predicates.annotatedWith(Object.class)) does not work?

For the recored: The first rule works with

JavaClasses classes = new ClassFileImporter().importClasses(StatelessObject.class, StatefulObject.class);
rule.check(classes);

but fails with

JavaClasses classes = new ClassFileImporter().importClasses(StatelessObject.class);
rule.check(classes);
Jurrie

comment created time in 4 months

issue commentTNG/ArchUnit

fields().should().notHaveRawType(CanBeAnnotated.Predicates.annotatedWith(Object.class)) does not work?

I tried to reproduce your issue with these classes:

@Stateless
class StatelessObject {
    @EJB
    private StatefulObject statefulObject;
}

@Stateful
class StatefulObject {
}

I get the expected error with both rule definitions.

Can you provide an example where the results of those rules differ?

Jurrie

comment created time in 4 months

delete branch rweisleder/spring-security

delete branch : patch-1

delete time in 4 months

PR opened camunda/camunda-docs-manual

CAM-10840: Add property to disable CamundaBpmWebappAutoConfiguration

This is the documentation for the new property introduced with https://github.com/camunda/camunda-bpm-spring-boot-starter/pull/341.

+7 -1

0 comment

1 changed file

pr created time in 4 months

create barnchrweisleder/camunda-docs-manual

branch : CAM-10840

created branch time in 4 months

create barnchrweisleder/camunda-bpm-spring-boot-starter

branch : CAM-10840

created branch time in 4 months

issue commentspring-projects/spring-framework

Add Assert.noNullElements for Collections [SPR-7925]

Commit https://github.com/spring-projects/spring-framework/commit/4000b244ff7b1db1f4eba9c4dbf2fc97162da254 added Assert.noNullElements(...) for collections.

spring-issuemaster

comment created time in 4 months

push eventrweisleder/spring-security

Roland Weisleder

commit sha 7d0201e1c26c77c0f48b0b3c5bb6a56446e14501

Fix typo in Javadoc

view details

push time in 4 months

issue openedspring-projects/spring-boot

Unexpected settings in effective pom when inheriting from spring-boot-starter-parent

The two documented ways to start a Maven project are either inherit from spring-boot-starter-parent or import spring-boot-dependencies. The main differences are of course, that spring-boot-starter-parent provides the version properties and more configured plugins.

However, when inheriting from spring-boot-starter-parent there are more settings made. See this snippet from an effective pom:

  <description>Parent pom providing dependency and plugin management for applications
		built with Maven</description>
  <url>https://projects.spring.io/spring-boot/#/spring-boot-starter-parent/myproject</url>
  <licenses>
    <license>
      <name>Apache License, Version 2.0</name>
      <url>https://www.apache.org/licenses/LICENSE-2.0</url>
    </license>
  </licenses>
  <developers>
    <developer>
      <name>Pivotal</name>
      <email>info@pivotal.io</email>
      <organization>Pivotal Software, Inc.</organization>
      <organizationUrl>https://www.spring.io</organizationUrl>
    </developer>
  </developers>
  <scm>
    <url>https://github.com/spring-projects/spring-boot/spring-boot-starter-parent/myproject</url>
  </scm>

I wouldn't expect these settings in a new project. At least the developers and the scm url are not correct in most cases. This should either be documented or removed.

Steps to reproduce:

  • create new Maven project which inherits from spring-boot-starter-parent (like this)
  • run mvn help:effective-pom

created time in 5 months

PR opened TNG/ArchUnit

Overload JavaClass.getConstructor() and JavaClass.getMethod()

This commit adds the methods

  • JavaClass.getConstructor(String... parameters)
  • JavaClass.getMethod(String name, String... parameters)
  • JavaClass.tryGetMethod(String name, String... parameters)

to retrieve constructors/methods even if a parameter type is not present on the classpath.

The methods

  • JavaClass.getConstructor()
  • JavaClass.getMethod(String name)
  • JavaClass.tryGetMethod(String name)

to retrieve constructors/methods without parameters where added to avoid ambiguous method calls.

Resolves #236

+43 -0

0 comment

2 changed files

pr created time in 5 months

create barnchrweisleder/ArchUnit

branch : gh-236

created branch time in 5 months

push eventrweisleder/assertj

Roland Weisleder

commit sha 931956d1a504b414588102a06d10ed6c363ddb9b

Update version of assertj-core in quick start guide

view details

push time in 5 months

push eventrweisleder/assertj

Roland Weisleder

commit sha 863ed528be3ba64dad7c4e1a91c2096f8b9058b4

Update version of assertj-core in quick start guide

view details

push time in 5 months

fork rweisleder/assertj

AssertJ documentation

fork in 5 months

PR opened TNG/ArchUnit

Extend syntax to query different kinds of classes

This PR adds the following methods to JavaClass

  • isTopLevelClass
  • isMemberClass
  • isAnonymousClass (as replacement for isAnonymous)
  • isLocalClass

This PR also adds classes().that(). and classes().should().

  • [are|be]TopLevelClasses
  • [are|be]NestedClasses
  • [are|be]MemberClasses
  • [are|be]InnerClasses
  • [are|be]AnonymousClasses
  • [are|be]LocalClasses

and their corresponding negations.

The naming is based on the Java Language Specification, chapter 8.

Resolves #207

+1436 -12

0 comment

16 changed files

pr created time in 5 months

create barnchrweisleder/ArchUnit

branch : gh-207

created branch time in 5 months

Pull request review commentTNG/ArchUnit

Add JUnit 4 dependencies

 framework. ## An Example  #### Add the Maven Central dependency to your project+Arch Unit provides separate dependencies for JUnit 4 and JUnit 5.  ###### Gradle +Junit 4+```+testCompile 'com.tngtech.archunit:archunit-junit4:0.11.0'+```++JUnit 5

The artifact com.tngtech.archunit:archunit contains the core of ArchUnit, which is test-framework-agnostic. As the User Guide states: "While ArchUnit can be used with any unit testing framework, it provides extended support for writing tests with JUnit 4 and JUnit 5."

The correct dependencies for JUnit 5 are described here: https://www.archunit.org/userguide/html/000_Index.html#_junit_5

igorwojda

comment created time in 5 months

delete branch rweisleder/spring-boot

delete branch : fix-assert-message-typo

delete time in 5 months

push eventrweisleder/spring-boot

Stephane Nicoll

commit sha f9e809b00ef56b7cd040e7f45ec14b07038deeaa

Upgrade to Undertow 2.0.23.Final Closes gh-17676

view details

Stephane Nicoll

commit sha 7bb0a9769aeed5d08bfb2533fa087d50dc1fb711

Merge branch '2.1.x' Closes gh-17688

view details

Johnny Lim

commit sha 2c2ee92a39745af1f076c0eeebeeb48710872d87

Remove ConditionEvaluationReportLoggingListener in a test See gh-17742

view details

Stephane Nicoll

commit sha 80e2086505ccff3d6c288825a22dfd890fcc3f87

Merge pull request #17742 from izeye * pr/17742: Remove ConditionEvaluationReportLoggingListener in a test Closes gh-17742

view details

Dave Syer

commit sha e7b0450a7fc9f98aa341a851b49ef7e63603caeb

Add missing repositories to snapshot configuration See gh-17736

view details

Stephane Nicoll

commit sha 0c560795fd2a22d884ce11e6aa5b962337c81174

Harmonize settings.gradle documentation in Gradle getting started guide See gh-17736

view details

Stephane Nicoll

commit sha 340a20595e50bc07a11870a8aed130e9c3ab85e9

Merge pull request #17736 from dsyer * pr/17736: Harmonize settings.gradle documentation in Gradle getting started guide Add missing repositories to snapshot configuration Closes gh-17736

view details

Stephane Nicoll

commit sha 59265477674564cfd165e30b4571f5389d9a0d84

Merge branch '2.1.x' Closes gh-17745

view details

Phillip Webb

commit sha da4f436140bf47669442802225d02bb9691a19aa

Change SearchStrategy EXHAUSTIVE to TYPE_HIERARCHY Fixup references following upstream Spring Framework change.

view details

Madhura Bhave

commit sha 96235ea674a474f49272e72bf3dce1bed8f57632

Fix ordering of JSON property source relative to servlet sources Fixes gh-17652

view details

Madhura Bhave

commit sha 02fd0c45e436598d9ed62b76b3830929435b85f8

Merge branch '2.1.x' Closes gh-17748

view details

Stephane Nicoll

commit sha 4d21efcc0a45c303802df82248930652d28cbf0e

Remove outdated comment in smoke tests Closes gh-17741

view details

Phillip Webb

commit sha 34c31ce09957246be792c9bc97b8e4b4ab548433

Remove BeanTypeRegistry Remove `BeanTypeRegistry` and rely entirely on standard calls Spring Framework APIs. Closes gh-17594

view details

Phillip Webb

commit sha e26777c01435e71b6cba5d5c4ef2e22565545ea1

Parameterize and increase CI task timeouts

view details

Phillip Webb

commit sha bd815f6b5a77a382e24c74991d306c3a3b429dfc

Merge branch '2.0.x' into 2.1.x

view details

Phillip Webb

commit sha f8d4d3dd98dc08c28134879628981b4fbecb54b2

Merge branch '2.1.x'

view details

Phillip Webb

commit sha 040712168ec6c9abc5888f4ec84064f80bb7776c

Cache embedmongo on CI

view details

Dmytro Nosan

commit sha 0e87b9c163b239edbc7aa7a5f4b94ce7399670b4

Create RestClient from a RestHighLevelClient if available See gh-17488

view details

Stephane Nicoll

commit sha fb0fccf3c7e1b1290ef64a1d2c388d788a5a965e

Polish "Create RestClient from a RestHighLevelClient if available" This significantly rework the auto-configuration to reflect the order in which things are expected. Rather than keeping a conceptual cycle between the builder and the two inner classes that are processed first, the configuration is now split in three parts: * The builder that is required and common * The configuration when the HighLevelClient is available * The RestClient configuration when that's not the case See gh-17488

view details

Stephane Nicoll

commit sha a76aaabc0773106e73d25574922888a42c9aa5dc

Merge pull request #17488 from nosan * pr/17488: Polish "Create RestClient from a RestHighLevelClient if available" Create RestClient from a RestHighLevelClient if available Closes gh-17488

view details

push time in 5 months

create barnchrweisleder/spring-boot

branch : fix-assert-message-typo

created branch time in 5 months

issue openedspring-projects/spring-boot

Dead link (404) in Spring Boot 2.0 Migration Guide

The section Relaxed Binding links to the reference guide (link "have been tightened" in the first paragraph), but this link results in a 404.

Maybe related to the last change?

created time in 5 months

issue commentTNG/ArchUnit

Extend Classes Syntax for anonymous / inner / outer classes

I started working on this issue.

codecholeric

comment created time in 5 months

PR opened akullpp/awesome-java

Adjust repository url for jFairy

Please read the CONTRIBUTING.md first. The most important parts regarding the actual entry:

  • Write about it's unique selling point compared to other projects.
  • If it's a commercial project, then mark it as such, e.g. [Title ![c]](URL).
  • Ensure that you provide concise and informative descriptions.
  • Do not use a description like "A library/project/tool/framework for JSON processing in Java" since all of this is implied.
  • Finish the description with a dot.
  • Try to order it alphabetically.
+1 -1

0 comment

1 changed file

pr created time in 5 months

push eventrweisleder/awesome-java

Roland Weisleder

commit sha f85d08f13f42a4ad8485b9c3f52b5f6b51a62869

Adjust repository url for jFairy

view details

push time in 5 months

fork rweisleder/awesome-java

A curated list of awesome frameworks, libraries and software for the Java programming language.

fork in 5 months

push eventrweisleder/ArchUnit

Roland Weisleder

commit sha 970743a4507c38bae166c1da5cf897a924004b8d

Clarify difference between nested and inner classes JLS: "A nested class is any class whose declaration occurs within the body of another class or interface." [1] JLS: "An inner class is a nested class that is not explicitly or implicitly declared static." [1] Before this commit, the method JavaClass#isInnerClass returned true for all nested classes. This commit changes JavaClass#isInnerClass that it only returns true for inner classes. This commit also introduces JavaClass#isNestedClass that returns true for all nested classes. [1] https://docs.oracle.com/javase/specs/jls/se8/html/jls-8.html Signed-off-by: Roland Weisleder <roland.weisleder@googlemail.com>

view details

Peter Gafert

commit sha d8b261e8f4edb328d5d39b5f5e414e28342cd609

Review: Moved tests to ClassFileImporterTest, since a) other tests related to various forms of inner classes reside there and b) ClassFileImporterTest is more black-box (even though looking at the code we know that isNestedClass() and isInnerClass() are directly related)

view details

Peter Gafert

commit sha 9bd6e2708fcb97ebbb10baaa06f12e5d689a0ac7

Merge pull request #224 from rweisleder/clarify-nested-inner-classes Clarify difference between nested and inner classes

view details

Roland Weisleder

commit sha 07b3e24d0bda2d03790d3c0567ba617af6152c2b

Add classes().that().areEnums() and .should().beEnums() Signed-off-by: Roland Weisleder <roland.weisleder@googlemail.com>

view details

Peter Gafert

commit sha 072169159a632864acda69fd2d196e1375abb990

Review: Added "classes().should()..." tests Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>

view details

Peter Gafert

commit sha 47367ada6bb538c1c8cb42712443799cc7485623

Merge pull request #225 from rweisleder/gh-172 Add classes().that().areEnums() and .should().beEnums()

view details

push time in 5 months

delete branch rweisleder/ArchUnit

delete branch : gh-172

delete time in 5 months

delete branch rweisleder/ArchUnit

delete branch : clarify-nested-inner-classes

delete time in 6 months

more