profile
viewpoint
Rustam Mamadaminov rustamwin @yiisoft @yiistack Tashkent, Uzbekistan https://t.me/rustamwin Full stack web developer since 2015. #php #javascript #typescript

rustamwin/active-record 0

Active Record database abstraction layer

rustamwin/andia 0

First project

rustamwin/app 0

Yii 3 application template

rustamwin/awesome-php 0

A curated list of amazingly awesome PHP libraries, resources and shiny things.

rustamwin/bigbluebutton-api-php 0

BigBlueButton PHP API

rustamwin/boomerang 0

json-rpc project template

rustamwin/broadcast 0

Broadcast messages over web-sockets: in-memory, redis.

push eventyiisoft/yii-web

Rustam Mamadaminov

commit sha aafaf8a0e462c11e4eebbfa7ea010558f82dcda9

Adjust readme

view details

push time in 8 hours

Pull request review commentyiisoft/event-dispatcher

Replace phan to psalm. Update dev dependencies. Minor fix phpdoc.

 jobs:      env:       extensions: ast
vjik

comment created time in 8 hours

PullRequestReviewEvent

push eventyiisoft/template

Rustam Mamadaminov

commit sha 7d77f1512415e96e008af36f8cf8352a1c039cfd

Remove ast extension, since not required for psalm

view details

push time in 8 hours

PullRequestReviewEvent

Pull request review commentyiisoft/event-dispatcher

Replace phan to psalm. Update dev dependencies. Minor fix phpdoc.

 jobs:      env:       extensions: ast

Not required for psalm

vjik

comment created time in 9 hours

PullRequestReviewEvent

Pull request review commentyiisoft/event-dispatcher

Add DeferredEventsTrait

 The package tests are checked with [Infection](https://infection.github.io/) mut  ### Static analysis -The code is statically analyzed with [Phan](https://github.com/phan/phan/wiki). To run static analysis:+The code is statically analyzed with [Psalm](https://psalm.dev/). To run static analysis:

This package still uses phan static analysis.

vjik

comment created time in 9 hours

PullRequestReviewEvent

pull request commentyiisoft/yii-debug

Group resources by time

I like the idea, but need to check that gc is working properly.

I checked, it works.

xepozz

comment created time in 11 hours

delete branch rustamwin/yii-web

delete branch : adopt-psalm

delete time in 16 hours

pull request commentyiisoft/cache-memcached

Adopt Psalm

Seems to need to fix php version of scrutinizer

Fantom409

comment created time in a day

PR opened yiisoft/yii-gii

Remove resources favor of yiisoft/yii-gii-frontend
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -
+0 -6046

0 comment

68 changed files

pr created time in a day

PullRequestReviewEvent

create barnchrustamwin/yii-gii

branch : remove-resources

created branch time in a day

pull request commentyiisoft/auth-jwt

Remove ast extension

:+1:

Fantom409

comment created time in 2 days

push eventyiisoft/auth-jwt

Anton Samoylenko

commit sha 8765f42728ae9f861d37154e2495b6a4d71c7166

Remove ast extension (#9)

view details

push time in 2 days

PR merged yiisoft/auth-jwt

Remove ast extension
Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues
+0 -3

0 comment

1 changed file

Fantom409

pr closed time in 2 days

push eventyiisoft/cache-wincache

Anton Samoylenko

commit sha f28df65aceea504a09e8ce99d931891c2fc01f49

Delete .gitkeep (#10)

view details

push time in 2 days

PR merged yiisoft/cache-wincache

Delete .gitkeep
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues
+0 -0

0 comment

1 changed file

Fantom409

pr closed time in 2 days

Pull request review commentyiisoft/yii-debug

Group resources by time

 public function getData(): array      public function flush(): void     {+        $basePath = $this->path . '/' . date('Y-m-d H:i:s') . '/' . $this->idGenerator->getId() . '/';

I think, time format is not needed here

        $basePath = $this->path . '/' . date('Y-m-d') . '/' . $this->idGenerator->getId() . '/';
xepozz

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventrustamwin/yii-web

Rustam Mamadaminov

commit sha 97fec5973353623b09ba73cdc5021aa49dedd200

Suppress psalm errors

view details

push time in 3 days

PullRequestReviewEvent

push eventrustamwin/yii-web

Rustam Mamadaminov

commit sha 917d17e79900f1f9f58e16d58c4cfc9455d5c184

Fix psalm issues

view details

push time in 4 days

Pull request review commentyiisoft/yii-web

Replace phan with psalm

+<?xml version="1.0"?>+<psalm+    errorLevel="6"

Documentation says: Level 1 is the most strict, level 8 is the most lenient.

rustamwin

comment created time in 4 days

PullRequestReviewEvent

PR opened yiisoft/yii-web

Replace phan with psalm
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -
+19 -384

0 comment

5 changed files

pr created time in 5 days

create barnchrustamwin/yii-web

branch : adopt-psalm

created branch time in 5 days

Pull request review commentyiisoft/arrays

Improve work with float keys + more tests

 public function testRemoveByFloatKey(): void         $this->assertSame([1 => 'a', 3 => 'c'], $array);     } +    public function testRemoveByFloatKey2(): void

It's better to add tests to the method above than add a new method.

vjik

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

delete branch rustamwin/yii-web

delete branch : adjust-html-renderer

delete time in 7 days

PR opened yiisoft/yii-web

Fix #274: Make methods public
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #274
+7 -8

0 comment

1 changed file

pr created time in 7 days

create barnchrustamwin/yii-web

branch : adjust-html-renderer

created branch time in 7 days

pull request commentyiisoft/view

Phan fixes

It is better to immediately replace phan with psalm. WDYT?

Fantom409

comment created time in 7 days

issue closedyiisoft/yii-web

Rename @web to @baseUrl

@web alias should be renamed to @baseUrl. Needs to be done with search/replace in all other packages i.e. with yii-dev-tool fully deployed.

See https://trello.com/c/YqnPsZ3P/132-rename-web-alias-to-baseurl

closed time in 7 days

samdark

issue commentyiisoft/yii-web

Rename @web to @baseUrl

See https://github.com/yiisoft/yii-web/commit/48861ce00acb6d25b3aa1d7173af3098fc549931

samdark

comment created time in 7 days

PR opened yiisoft/yii-debug

Fix psalm issues
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -
+23 -8

0 comment

7 changed files

pr created time in 7 days

create barnchrustamwin/yii-debug

branch : fix-psalm-issues

created branch time in 7 days

delete branch rustamwin/yii-debug

delete branch : add-missing-dep-psalm

delete time in 7 days

Pull request review commentyiisoft/view

Multi-language View

 public function renderFile(string $viewFile, array $parameters = [], ?ViewContex             $viewFile = $this->theme->applyTo($viewFile);         } -        if (is_file($viewFile)) {-            $viewFile = $this->localize($viewFile);-        } else {+        if (!is_file($viewFile)) {             throw new ViewNotFoundException("The view file does not exist: $viewFile");         }+        $viewFile = $this->localize($viewFile, $parameters['translateLanguage'] ?? null, $parameters['sourceLanguage'] ?? null);
        $viewFile = $this->localize($viewFile, $parameters['language'] ?? null, $parameters['sourceLanguage'] ?? null);
mj4444ru

comment created time in 8 days

Pull request review commentyiisoft/view

Multi-language View

 public function renderFile(string $viewFile, array $parameters = [], ?ViewContex             $this->logger->debug("Rendering view file: $viewFile");             $ext = pathinfo($viewFile, PATHINFO_EXTENSION);             $renderer = $this->renderers[$ext] ?? new PhpTemplateRenderer();++            $saveLanguage = $this->language;
            $language = $this->language;
mj4444ru

comment created time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened yiisoft/yii-debug

Add psalm to composer
Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues Fix composer deps
+3 -2

0 comment

1 changed file

pr created time in 8 days

create barnchrustamwin/yii-debug

branch : add-missing-dep-psalm

created branch time in 8 days

Pull request review commentyiisoft/yii-demo

Setting Post title/content in constructor - #156

 class Post      */     private $comments; -    public function __construct()+    public function __construct(?string $title = null, ?string $content = null)     {+        $this->title = $title ?? '';+        $this->content = $content ?? '';
        $this->title = $title;
        $this->content = $content;
brucealdridge

comment created time in 8 days

Pull request review commentyiisoft/yii-demo

Setting Post title/content in constructor - #156

 class Post      */     private $comments; -    public function __construct()+    public function __construct(?string $title = null, ?string $content = null)
    public function __construct(string $title = '', string $content = '')
brucealdridge

comment created time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventyiisoft/cache

Alexander Makarov

commit sha d7adb462496c7b886002325bf3f0b93dbc1ec04c

Remove cache key normalization and non-string keys support (#54)

view details

Rustam Mamadaminov

commit sha e55beb99b17e65c1dff85d519a911b51266b1bc3

Merge branch 'master' of github.com:yiisoft/cache into switch-to-gha

view details

Rustam Mamadaminov

commit sha 83dac7a9ea8aeb8f3952e746425f3e7b32f6c2b6

Fix tests

view details

push time in 9 days

push eventyiisoft/cache

Rustam Mamadaminov

commit sha 867ea3d4f3ef824768663c7d0d0c5c14d62df39d

Fix psalm issues

view details

push time in 9 days

pull request commentyiisoft/cache

Switch to GHA and psalm

Have you forgot composer.json?

Yes. Fixed.

rustamwin

comment created time in 9 days

push eventyiisoft/cache

Rustam Mamadaminov

commit sha 0bf958cf9c54e9a754beb4675bc464f7b2070d20

Fix composer.json

view details

push time in 9 days

Pull request review commentyiisoft/app

Adopt Psalm

 public function register(Container $container): void             return $fileTarget;         }); +        /**+         * @psalm-suppress InaccessibleMethod+         */

Let's move it to the method level.

Fantom409

comment created time in 9 days

Pull request review commentyiisoft/app

Adopt Psalm

  final class MiddlewareProvider extends ServiceProvider {-    /**-     * @suppress PhanAccessMethodProtected-     */     public function register(Container $container): void     {+        /**+         * @psalm-suppress InaccessibleMethod+         */

Let's move it to the method level.

Fantom409

comment created time in 9 days

Pull request review commentyiisoft/app

Adopt Psalm

 public function __construct(         $this->writeToFilesPath = $writeToFilesPath;     } -    /**-     * @suppress PhanAccessMethodProtected-     */+     public function register(Container $container): void     {+        /**+         * @psalm-suppress InaccessibleMethod+         */

Let's move it to the method level.

Fantom409

comment created time in 9 days

Pull request review commentyiisoft/app

Adopt Psalm

 final class LoggerProvider extends ServiceProvider {     public function register(Container $container): void     {+        /**+         * @psalm-suppress InaccessibleMethod+         */

Let's move it to the method level.

Fantom409

comment created time in 9 days

Pull request review commentyiisoft/app

Adopt Psalm

 public function __construct(array $fieldConfig = [])         $this->fieldConfig = $fieldConfig;     } -    /**-     * @suppress PhanAccessMethodProtected-     */+     public function register(Container $container): void     {+        /**+         * @psalm-suppress InaccessibleMethod+         */

Let's move it to the method level.

Fantom409

comment created time in 9 days

Pull request review commentyiisoft/app

Adopt Psalm

 final class LoggerProvider extends ServiceProvider {     public function register(Container $container): void     {+        /**+         * @psalm-suppress InaccessibleMethod+         */         $container->set(FileRotatorInterface::class, static function () {             return new FileRotator(10);         }); +        /**+         * @psalm-suppress InaccessibleMethod+         */

Let's move it to the method level.

Fantom409

comment created time in 9 days

Pull request review commentyiisoft/app

Adopt Psalm

  final class FlashProvider extends ServiceProvider {-    /**-     * @suppress PhanAccessMethodProtected-     */     public function register(Container $container): void     {+        /**+         * @psalm-suppress InaccessibleMethod+         */

Let's move it to the method level.

Fantom409

comment created time in 9 days

Pull request review commentyiisoft/app

Adopt Psalm

 public function __construct(string $locale, string $translatePath)         $this->translatePath = $translatePath;     } -    /**-     * @suppress PhanAccessMethodProtected-     */     public function register(Container $container): void     {+        /**+         * @psalm-suppress InaccessibleMethod+         */

Let's move it to the method level.

Fantom409

comment created time in 9 days

PullRequestReviewEvent
PullRequestReviewEvent

startedcebe/yii2-psr7-messages

started time in 9 days

PR opened yiisoft/cache

Switch to GHA and psalm
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #46
+250 -474

0 comment

9 changed files

pr created time in 9 days

create barnchyiisoft/cache

branch : switch-to-gha

created branch time in 10 days

Pull request review commentyiisoft/strings

Fix: in PHP 8.0 method NumericHelper::normalize throws error for floa…

 ## 1.1.1 under development  - Enh #40: Use `str_starts_with()` and `str_ends_with()` if available (viktorprogger)+- Fix: in PHP 8.0 method `NumericHelper::normalize` throws error for `float` or `int` values (vjik)
- Bug #43: `NumericHelper::normalize` throws an error for `float` or `int` values in PHP 8 (vjik)
vjik

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentyiisoft/strings

Fix: in PHP 8.0 method NumericHelper::normalize throws error for floa…

 public function testToOrdinalWithIncorrectType(): void     public function normalizeNumberDataProvider(): array     {         return [-             'French' => ['4 294 967 295,000', '4294967295.000'],             'German' => ['4 294 967.295,000', '4294967295.000'],             'Spanish' => ['4.294.967.295,000', '4294967295.000'],             'English' => ['4,294,967,295.000', '4294967295.000'],             'Smaller' => ['10,111', '10.111'],+            [10.0, '10'],
            'Float' => [10.0, '10'],

or something like this

vjik

comment created time in 10 days

PullRequestReviewEvent

delete branch yiisoft/yii-swagger

delete branch : fix-asset-path

delete time in 10 days

delete branch yiisoft/yii-swagger

delete branch : try-fix-gha

delete time in 10 days

push eventyiisoft/yii-swagger

Rustam Mamadaminov

commit sha 88acab8575cb515199986bfd8990be58ec0684ee

Fix GHA workflow (#5)

view details

push time in 10 days

PR merged yiisoft/yii-swagger

Try to fix GHA workflow
Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any
+1 -1

0 comment

1 changed file

rustamwin

pr closed time in 10 days

PR opened yiisoft/yii-swagger

Try to fix GHA workflow
Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any
+1 -1

0 comment

1 changed file

pr created time in 10 days

create barnchyiisoft/yii-swagger

branch : try-fix-gha

created branch time in 10 days

startedyiisoft/yii-swagger

started time in 10 days

push eventyiisoft/yii-swagger

Rustam Mamadaminov

commit sha af0888ccb33f564194de19e93d16c89ae5429728

Fix asset source path (#3)

view details

push time in 10 days

PR merged yiisoft/yii-swagger

Fix asset source path status:code review
Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues fix SwaggerUiAsset
+1 -1

0 comment

1 changed file

rustamwin

pr closed time in 10 days

push eventyiisoft/yii-swagger

Anton Samoylenko

commit sha 4e4553337beab56991d8d85a0cb3f706aa0a931f

Fix tests (#4)

view details

push time in 10 days

PR merged yiisoft/yii-swagger

Fix tests status:code review
Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues
+8 -5

0 comment

2 changed files

Fantom409

pr closed time in 10 days

PullRequestReviewEvent

Pull request review commentyiisoft/yii-swagger

Fix tests

 private function createContainer(): ContainerInterface             CacheInterface::class => new ArrayCache(),             DataResponseFactoryInterface::class => DataResponseFactory::class,             ResponseFactoryInterface::class => Psr17Factory::class,-            ViewRenderer::class => function (Container $container) {+            ViewRenderer::class => function (
            ViewRenderer::class => static function (
Fantom409

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

PR opened yiisoft/yii-swagger

Fix asset source path
Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues fix SwaggerUiAsset
+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnchyiisoft/yii-swagger

branch : fix-asset-path

created branch time in 11 days

PR opened yiisoft/yii-view

Clean up
Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -
+57 -416

0 comment

11 changed files

pr created time in 11 days

create barnchyiisoft/yii-view

branch : cleanup

created branch time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentyiisoft/event-dispatcher

Fix #7: Implement DeferredDispatcher

+<?php+
declare(strict_types=1);

samdark

comment created time in 12 days

PR opened yiisoft/app

Adjust to router changes
Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any
+0 -4

0 comment

1 changed file

pr created time in 12 days

create barnchyiisoft/app

branch : adjust-router-provider

created branch time in 12 days

issue openedyiisoft/yii-view

Increase code coverage

created time in 15 days

Pull request review commentyiisoft/yii-bootstrap5

Enhacements.

         "yiisoft/widget": "^3.0@dev"     },     "require-dev": {-        "yiisoft/composer-config-plugin": "^1.0@dev",+        "infection/infection": "^0.16.3",         "phpunit/phpunit": "^9.3",+        "vimeo/psalm": "^3.15",         "yiisoft/aliases": "^1.0",         "yiisoft/di": "^3.0@dev",         "phan/phan": "^3.0"

Let's remove it since we use psalm

terabytesoftw

comment created time in 15 days

more