I have a schema like this:

interface Error {
   message: String
}

interface SpecializedError implements Error {
   messsage: String
   specializedError: String
}

type ValidationError implements SpecializedError, Error {
   message: String
   specializedError: String
}

type TestPayload {
   errors: [Error!]
   result: ResultType
}

type ResultType {
   success: Boolean!
}

Expected behavior

I want the generated interface SpecializedError to extend Error so that my TestPayload error field can contain both ValidationError and other error types that implement Error directly.

Actual behavior

Interfaces do not extend other interfaces. However, concrete classes implement multiple interfaces.

Steps to reproduce

Generate code from the schema above and view its output. This is using the Java codegen.

Let me know if I can assist with more information.

Discussed in https://github.com/Netflix/dgs-framework/discussions/370

<div type='discussions-op-text'>

^{Originally posted by anderssandven May 28, 2021} I have a schema like this:

type Mutation {
	one: One
}

type One {
	two(three: Three!): Two
}

type Two {
	test: String
}

input Three {
	test3: String
}

When doing code generation I expect to get multiple queries generated. The queries generated are: OneGraphQLQuery.java
OneProjectionRoot.java
OneTwoProjection.java

I expect to get a OneTwoGraphlQuery aswell because I cannot supply any arguments through OneGraphqlQuery.

Am I misunderstanding how this works?</div>

When using the client API, I think it should get the same result in the GraphiQL UI. The serialization and deserialization are dependent on Jackson.

You can try to return a String type of the execution result, and use json path to read the result. The String type result should be a JSON String.

Followed the steps of the discussion posts, I tried to add a simple uppercase directive in mysample project, but it does not work as expected.

The uppercase directive wring class.

public class UppercaseDirectiveWiring implements SchemaDirectiveWiring {
    @Override
    public GraphQLFieldDefinition onField(SchemaDirectiveWiringEnvironment<GraphQLFieldDefinition> env) {

        var field = env.getElement();
        var parentType = env.getFieldsContainer();

        var originalDataFetcher = env.getCodeRegistry().getDataFetcher(parentType, field);
        var dataFetcher = DataFetcherFactories.wrapDataFetcher(originalDataFetcher,
                (dataFetchingEnvironment, value) -> {
                    if (value instanceof String s) {
                        return s.toUpperCase();
                    }
                    return value;
                }
        );

        env.getCodeRegistry().dataFetcher(parentType, field, dataFetcher);
        return field;
    }
}

And I created a bean @DgsRuntimeWiring in the data fetchers.

@DgsComponent
public class PostsDataFetcher {

    @DgsRuntimeWiring
    RuntimeWiring.Builder runtimeWiring(RuntimeWiring.Builder builder) {
        return builder.directive("uppercase", new UppercaseDirectiveWiring());
    }

When running the application, and test it on Graphiql, but it does not work. Not sure where is wrong.

This directive is working with my other Graphql example written in GraphQL Java and Spring Graphql.

Check: https://github.com/hantsy/spring-graphql-sample/tree/master/graphql-java/src/main/java/com/example/demo/gql/directives

Hope add a @DgsDirective and apply on the UppercaseDirectiveWiring to register a directive.

Discovered while running UnecessaryThrows on GeoTools.

import java.io.IOException;
import java.net.URL;
import java.net.URLClassLoader;

class Test {
    public void testLookupWithExtendedClasspath() throws IOException{
        URL url = getClass().getResource("foo.jar");
        assertNotNull(url);
        // URLClassLoader implements Closeable and throws IOException from its close() method
        try (URLClassLoader cl = new URLClassLoader(new URL[] {url})) {
        }
    }
}

I noticed this while looking into why CovariantEqualsTest.replaceWithNonCovariantEqualsWhenNested() was producing a method invocation missing type attributions.

That test turns this before:

class A {
    class B {
        int n;

        public boolean equals(B bee) {
            return n == bee.n;
        }
    }
}

into this after:

class A {
    class B {
        int n;

        @Override
        public boolean equals(Object obj) {
            if (obj == this) return true;
            if (obj == null || getClass() != obj.getClass()) return false;
            B bee = (B) obj;
            return n == bee.n;
        }
    }
}

getClass() and obj.getClass() come out un-type-attributed because the snippet being generated by BlockStatementTemplateGenerator is (reformatted for legibility):

class A {
    class B {
        public boolean equals(B bee) {
            return true;
        }

        int n;
    }

    class B {
        public boolean equals(B bee) {
            return true;
        }

        int n;

        public boolean equals(Object obj) {
            if (true) {
                /*__TEMPLATE__*/
                if (obj == this) return true;
                if (obj == null || getClass() != obj.getClass()) return false;
                B bee = (B) obj;
            }
            return true;
        }
    }
}

Which has two competing definitions for inner class B.

Okay, after messing around inside dgs-framework, I think I have a path forward but would love input from the maintainers.

I modified DataFetcherResultProcessor:

 interface DataFetcherResultProcessor {
     fun supportsType(originalResult: Any): Boolean
     fun process(originalResult: Any, dfe: DataFetchingEnvironment): Any
 }

this is a relatively trivial change, allowing access to the dfe (or potential we should allow access to DgsDataFetchingEnvironment instead) inside of Mono/FluxDataFetcherResultProcessors.

I then had to implement my own custom Mono/Flux implementation converters since spring-security is not included in these modules.

class MonoDataFetcherResultProcessor : DataFetcherResultProcessor {
    override fun supportsType(originalResult: Any): Boolean {
        return originalResult is Mono<*>
    }

    override fun process(originalResult: Any, dfe: DataFetchingEnvironment): Any {
        if (originalResult is Mono<*>) {
            val context = ReactiveSecurityContextHolder.withAuthentication((dfe.getContext<DgsContext>().customContext as SecurityContext).authentication)
            return originalResult.contextWrite(context).toFuture()
        } else {
            throw IllegalArgumentException("Instance passed to ${this::class.qualifiedName} was not a Mono<*>. It was a ${originalResult::class.qualifiedName} instead")
        }
    }
}

noting that my customContext is:

@Component
class SecurityContextDgs : DgsReactiveCustomContextBuilderWithRequest<SecurityContext> {
    override fun build(
        extensions: Map<String, Any>?,
        headers: HttpHeaders?,
        serverRequest: ServerRequest?
    ): Mono<SecurityContext> {
        return ReactiveSecurityContextHolder.getContext()
    }
}

This could probably be improved in some way, but it does work e2e for me on my fork + custom implementations.

What are peoples thoughts and suggestions?

Add a CorsFilter is on conditional, as it was done in the graphql-java-kickstart spring boot starter.

This commit fixes a bug that was introduced by the following commit:

https://github.com/Netflix/spectator-go/commit/375b638ffabe980c39294486dc6e03a9993a2fb3

When the file descriptor metric names were updated from fh.maxOpen and fh.curOpen to fh.allocated and fh.max, the names were swapped. The allocated metric should track the number of file descriptors opened, and the max metric should track the number of file descriptors configured.

This commit fixes a bug that was introduced by the following commit:

https://github.com/Netflix/spectator-go/commit/375b638ffabe980c39294486dc6e03a9993a2fb3

When the file descriptor metric names were updated from fh.maxOpen and fh.curOpen to fh.allocated and fh.max, the names were swapped. The allocated metric should track the number of file descriptors opened, and the max metric should track the number of file descriptors configured.

The test Jonathan provides passes currently. Since that works for you, Alex, I'm closing this issue.

If my code has Response.status(200).build() the pattern isn't matched. However, if the pattern is "javax.ws.rs.core.Response.ResponseBuilder build()" it works. Suspecting "*" for the type not making it in properly into regular expression, i.e. [^.]* is the regular expression for the type... ^ should be not inside [] ?

Because CORS is very specific to each application, and there are some dangers in not knowing it's enabled, I think we should not support this out of the box. @berngp WDYT?

Fix to properply serialize input arguments for fragments as well.

I was wondering: maybe there should be a warning or an error if multiple files matches the expression? Otherwise some files will be lost. E.g. your run the recipe with fileMatcher=*.txt and fileName=foo.csv and you have a directory containing a.txt, b.txt and c.txt : at end you'll have only one file in that directory.

References to items in the static * may have been removed, but the import is never unfolded.