profile
viewpoint

jkschneider/atlas-embedded 18

Atlas embedded into a Spring Boot 2 app

jkschneider/atlas-proxy 1

A proxy for Netflix Atlas adding additional features like an imperative query API and simple UI

jkschneider/eclipse-integration-gradle 1

Gradle Tooling for Eclipse

jkschneider/eureka-load-test 1

Load test that simulates Eureka clients and peers to stress a Eureka server.

decoded4620/HubCap 0

Git Hub Organization Analyzer

jkschneider/antlr4-gradle-plugin 0

Antlr4 plugin for Gradle

jkschneider/asciidoc-loader 0

Webpack loader allowing you to source asciidoc with recursive includes.

jkschneider/astyanax 0

Cassandra Java Client

push eventopenrewrite/rewrite-spring

Jonathan Schneider

commit sha d328dfb5acdca2e0131c052b2e786515d2d57254

Recombine two mockito visitors into ArgumentMatchersAny

view details

push time in 22 minutes

push eventopenrewrite/rewrite-spring

Jonathan Schneider

commit sha c6bd013bb83c0395978d3685cf7450ba494e7ae4

Split mockito visitors into individual rules

view details

push time in 30 minutes

created tagopenrewrite/rewrite-java-8

tagv3.0.0

Java 8 parser for the Rewrite Java language binding.

created time in an hour

release openrewrite/rewrite-java-8

v3.0.0

released time in an hour

delete tag openrewrite/rewrite-java-8

delete tag : v3.0.0

delete time in an hour

push eventopenrewrite/rewrite-java-8

Jonathan Schneider

commit sha e164d811703ce3265df44c1374424c0313d726f9

Set bintray org to 'openrewrite'

view details

push time in an hour

created tagopenrewrite/rewrite-java-8

tagv3.0.0

Java 8 parser for the Rewrite Java language binding.

created time in an hour

release openrewrite/rewrite-java-8

v3.0.0

released time in an hour

push eventopenrewrite/rewrite-java-8

Jonathan Schneider

commit sha 8954d36cae7442bf49b973769f1ff158a8c1c23e

Fix block end

view details

push time in an hour

delete tag openrewrite/rewrite-java-8

delete tag : v3.0.0

delete time in an hour

created tagopenrewrite/rewrite-java-8

tagv3.0.0

Java 8 parser for the Rewrite Java language binding.

created time in an hour

release openrewrite/rewrite-java-8

v3.0.0

released time in an hour

push eventopenrewrite/rewrite-spring

Jonathan Schneider

commit sha 313f60e419bbce41f754c4a3231d3c5a40a531cf

Passing compilation against latest rewrite core

view details

push time in 10 hours

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha f440a71b6ed041be1e1fe4e8b10e86656317351b

Convenience builder for dependencies from classpath

view details

push time in 11 hours

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 80dfc6aa36754da4e6d4d69538ce278c6acd0c79

Extended RefactorVisitorTest harness to support TCK tests as well

view details

push time in a day

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 6b28d8a5404f07b8da4db9eeae92b471ff9e5407

Fix NPE on string reduction in SourceVisitor

view details

Jonathan Schneider

commit sha b19a2f5bbda1d20d6fb69c785108f159402477ac

License headers

view details

push time in a day

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha a86efd54a6c8697db0d804c7593c2a41beb974d1

Temporarily disable ChangeMethodTargetToVariable

view details

push time in a day

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 98c3f6d5c4c5f6a5b6ddcd9a34c4287560fd6afd

Fix Properties tests

view details

push time in a day

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 160eb563b42ebbad6b8c5c3b566409d173cdf9f4

Fix Maven tests

view details

push time in a day

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha d08dd56cc76c5c9280a6ff2d74586d172e7c1157

Fix YAML tests

view details

push time in a day

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 8ff0f8cd3a6b52f042e8579a88f78e992804ff71

Fix ChangeMethodTargetToVariable

view details

push time in a day

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 19dcae87278be21285a94023f271a0ef241ede24

Update license headers, fix GenerateConstructorUsingFields

view details

push time in a day

Pull request review commentmicrometer-metrics/micrometer

Add Neo4j Java driver metrics.

+/**+ * Copyright 2020 VMware, Inc.+ * <p>+ * Licensed under the Apache License, Version 2.0 (the "License");+ * you may not use this file except in compliance with the License.+ * You may obtain a copy of the License at+ * <p>+ * https://www.apache.org/licenses/LICENSE-2.0+ * <p>+ * Unless required by applicable law or agreed to in writing, software+ * distributed under the License is distributed on an "AS IS" BASIS,+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+ * See the License for the specific language governing permissions and+ * limitations under the License.+ */+package io.micrometer.core.instrument.binder.neo4j;++import io.micrometer.core.instrument.FunctionCounter;+import io.micrometer.core.instrument.Gauge;+import io.micrometer.core.instrument.MeterRegistry;+import io.micrometer.core.instrument.Tag;+import io.micrometer.core.instrument.Tags;+import io.micrometer.core.instrument.binder.MeterBinder;+import io.micrometer.core.lang.NonNullApi;+import io.micrometer.core.lang.NonNullFields;++import java.util.function.Consumer;++import org.neo4j.driver.ConnectionPoolMetrics;+import org.neo4j.driver.Driver;+import org.neo4j.driver.Metrics;++/**+ * {@link MeterBinder} that binds all available Neo4j driver metrics.+ *+ * @author Michael J. Simons+ * @author Gerrit Meier+ */+@NonNullApi+@NonNullFields+public class Neo4jMetrics implements MeterBinder {++    /**+     * Prefixed used for driver metrics.+     */+    public static final String PREFIX = "neo4j.driver.connections";++    private static final String BASE_UNIT_CONNECTIONS = "connections";++    private final Driver driver;++    private final Iterable<Tag> tags;++    public Neo4jMetrics(String name, Driver driver, Iterable<Tag> tags) {+        this.driver = driver;+        this.tags = Tags.concat(tags, "name", name);+    }++    @Override+    public void bindTo(MeterRegistry meterRegistry) {+        Metrics metrics = this.driver.metrics();+        metrics.connectionPoolMetrics().forEach(this.getPoolMetricsBinder(meterRegistry));+    }++    Consumer<ConnectionPoolMetrics> getPoolMetricsBinder(MeterRegistry meterRegistry) {+        return (poolMetrics) -> {+            Iterable<Tag> poolTags = Tags.concat(this.tags, "poolId", poolMetrics.id());++            // acquisition attempts+            FunctionCounter.builder(PREFIX + ".acquisition", poolMetrics, ConnectionPoolMetrics::acquired)+                    .tags(Tags.concat(poolTags, "result", "successful"))+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections that have been acquired.")+                    .register(meterRegistry);++            FunctionCounter+                    .builder(PREFIX + ".acquisition", poolMetrics, ConnectionPoolMetrics::timedOutToAcquire)+                    .tags(Tags.concat(poolTags, "result", "timedOutToAcquire"))+                    .baseUnit(BASE_UNIT_CONNECTIONS)+                    .description("The amount of failures to acquire a connection from a pool within maximum connection "+                                    + "acquisition timeout.")+                    .register(meterRegistry);++            // connections successfully created and closed+            FunctionCounter.builder(PREFIX, poolMetrics, ConnectionPoolMetrics::created)

Does using "PREFIX" only break elastic? I think so... We'd need a unique suffix to this. I wonder as well whether it makes sense to combine created and closed. I can see it both ways...

meistermeier

comment created time in 2 days

issue commentopenrewrite/rewrite

Bug: Mistakenly adds the 'new' keyword

Thanks @nimakarimipour. Hadn't ever seen this case!

nimakarimipour

comment created time in 2 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 7ba54a13d978c4cb60e57f1a223031f0ccb98917

Delete SourceGenerator in preparation for changes to Refactor

view details

Jonathan Schneider

commit sha 6ac739f9f89a2b0dffa96f8d0fcdf410092beb0c

[wip] Multi-source refactoring, new test harness

view details

push time in 2 days

starteddocsifyjs/awesome-docsify

started time in 5 days

Pull request review commentmicrometer-metrics/micrometer

Add Neo4j Java driver metrics.

+package io.micrometer.core.instrument.binder.neo4j;++import io.micrometer.core.instrument.FunctionCounter;+import io.micrometer.core.instrument.Gauge;+import io.micrometer.core.instrument.MeterRegistry;+import io.micrometer.core.instrument.Tag;+import io.micrometer.core.instrument.Tags;+import io.micrometer.core.instrument.binder.MeterBinder;+import io.micrometer.core.lang.NonNullApi;+import io.micrometer.core.lang.NonNullFields;++import java.util.function.Consumer;++import org.neo4j.driver.ConnectionPoolMetrics;+import org.neo4j.driver.Driver;+import org.neo4j.driver.Metrics;++/**+ * {@link MeterBinder} that binds all available Neo4j driver metrics.+ *+ * @author Michael J. Simons+ * @author Gerrit Meier+ */+@NonNullApi+@NonNullFields+public class Neo4jMetrics implements MeterBinder {++    /**+     * Prefixed used for driver metrics.+     */+    public static final String PREFIX = "neo4j.driver.connections";++    private static final String BASE_UNIT_CONNECTIONS = "connections";++    private final Driver driver;++    private final Iterable<Tag> tags;++    public Neo4jMetrics(String name, Driver driver, Iterable<Tag> tags) {+        this.driver = driver;+        this.tags = Tags.concat(tags, "name", name);+    }++    @Override+    public void bindTo(MeterRegistry meterRegistry) {+        Metrics metrics = this.driver.metrics();+        metrics.connectionPoolMetrics().forEach(this.getPoolMetricsBinder(meterRegistry));+    }++    Consumer<ConnectionPoolMetrics> getPoolMetricsBinder(MeterRegistry meterRegistry) {+        return (poolMetrics) -> {+            Iterable<Tag> poolTags = Tags.concat(this.tags, "poolId", poolMetrics.id());++            FunctionCounter.builder(PREFIX + ".acquired", poolMetrics, ConnectionPoolMetrics::acquired).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections that have been acquired.")+                    .register(meterRegistry);++            FunctionCounter.builder(PREFIX + ".closed", poolMetrics, ConnectionPoolMetrics::closed).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections have been closed.")+                    .register(meterRegistry);++            FunctionCounter.builder(PREFIX + ".created", poolMetrics, ConnectionPoolMetrics::created).tags(poolTags)

What is the difference between created and acquired? Suggest combining .created and .failedToCreate into one metric, maybe PREFIX + ".creations" with an outcome tag of created or failed. This makes it easy to create an error ratio signal on the division of two tags.

meistermeier

comment created time in 6 days

Pull request review commentmicrometer-metrics/micrometer

Add Neo4j Java driver metrics.

+package io.micrometer.core.instrument.binder.neo4j;++import io.micrometer.core.instrument.FunctionCounter;+import io.micrometer.core.instrument.Gauge;+import io.micrometer.core.instrument.MeterRegistry;+import io.micrometer.core.instrument.Tag;+import io.micrometer.core.instrument.Tags;+import io.micrometer.core.instrument.binder.MeterBinder;+import io.micrometer.core.lang.NonNullApi;+import io.micrometer.core.lang.NonNullFields;++import java.util.function.Consumer;++import org.neo4j.driver.ConnectionPoolMetrics;+import org.neo4j.driver.Driver;+import org.neo4j.driver.Metrics;++/**+ * {@link MeterBinder} that binds all available Neo4j driver metrics.+ *+ * @author Michael J. Simons+ * @author Gerrit Meier+ */+@NonNullApi+@NonNullFields+public class Neo4jMetrics implements MeterBinder {++    /**+     * Prefixed used for driver metrics.+     */+    public static final String PREFIX = "neo4j.driver.connections";++    private static final String BASE_UNIT_CONNECTIONS = "connections";++    private final Driver driver;++    private final Iterable<Tag> tags;++    public Neo4jMetrics(String name, Driver driver, Iterable<Tag> tags) {+        this.driver = driver;+        this.tags = Tags.concat(tags, "name", name);+    }++    @Override+    public void bindTo(MeterRegistry meterRegistry) {+        Metrics metrics = this.driver.metrics();+        metrics.connectionPoolMetrics().forEach(this.getPoolMetricsBinder(meterRegistry));+    }++    Consumer<ConnectionPoolMetrics> getPoolMetricsBinder(MeterRegistry meterRegistry) {+        return (poolMetrics) -> {+            Iterable<Tag> poolTags = Tags.concat(this.tags, "poolId", poolMetrics.id());++            FunctionCounter.builder(PREFIX + ".acquired", poolMetrics, ConnectionPoolMetrics::acquired).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections that have been acquired.")+                    .register(meterRegistry);++            FunctionCounter.builder(PREFIX + ".closed", poolMetrics, ConnectionPoolMetrics::closed).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections have been closed.")+                    .register(meterRegistry);++            FunctionCounter.builder(PREFIX + ".created", poolMetrics, ConnectionPoolMetrics::created).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections have ever been created.")+                    .register(meterRegistry);++            FunctionCounter.builder(PREFIX + ".failedToCreate", poolMetrics, ConnectionPoolMetrics::failedToCreate)+                    .tags(poolTags).baseUnit(BASE_UNIT_CONNECTIONS)+                    .description("The amount of connections have been failed to create.").register(meterRegistry);++            Gauge.builder(PREFIX + ".idle", poolMetrics, ConnectionPoolMetrics::idle).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections that are currently idle.")+                    .register(meterRegistry);++            Gauge.builder(PREFIX + ".inUse", poolMetrics, ConnectionPoolMetrics::inUse).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections that are currently in-use.")+                    .register(meterRegistry);++            FunctionCounter+                    .builder(PREFIX + ".timedOutToAcquire", poolMetrics, ConnectionPoolMetrics::timedOutToAcquire)

Similar, combine acquired and timedOutToAcquire if this is indeed different from creation semantics.

meistermeier

comment created time in 6 days

Pull request review commentmicrometer-metrics/micrometer

Add Neo4j Java driver metrics.

+package io.micrometer.core.instrument.binder.neo4j;++import io.micrometer.core.instrument.FunctionCounter;+import io.micrometer.core.instrument.Gauge;+import io.micrometer.core.instrument.MeterRegistry;+import io.micrometer.core.instrument.Tag;+import io.micrometer.core.instrument.Tags;+import io.micrometer.core.instrument.binder.MeterBinder;+import io.micrometer.core.lang.NonNullApi;+import io.micrometer.core.lang.NonNullFields;++import java.util.function.Consumer;++import org.neo4j.driver.ConnectionPoolMetrics;+import org.neo4j.driver.Driver;+import org.neo4j.driver.Metrics;++/**+ * {@link MeterBinder} that binds all available Neo4j driver metrics.+ *+ * @author Michael J. Simons+ * @author Gerrit Meier+ */+@NonNullApi+@NonNullFields+public class Neo4jMetrics implements MeterBinder {++    /**+     * Prefixed used for driver metrics.+     */+    public static final String PREFIX = "neo4j.driver.connections";++    private static final String BASE_UNIT_CONNECTIONS = "connections";++    private final Driver driver;++    private final Iterable<Tag> tags;++    public Neo4jMetrics(String name, Driver driver, Iterable<Tag> tags) {+        this.driver = driver;+        this.tags = Tags.concat(tags, "name", name);+    }++    @Override+    public void bindTo(MeterRegistry meterRegistry) {+        Metrics metrics = this.driver.metrics();+        metrics.connectionPoolMetrics().forEach(this.getPoolMetricsBinder(meterRegistry));+    }++    Consumer<ConnectionPoolMetrics> getPoolMetricsBinder(MeterRegistry meterRegistry) {+        return (poolMetrics) -> {+            Iterable<Tag> poolTags = Tags.concat(this.tags, "poolId", poolMetrics.id());++            FunctionCounter.builder(PREFIX + ".acquired", poolMetrics, ConnectionPoolMetrics::acquired).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections that have been acquired.")+                    .register(meterRegistry);++            FunctionCounter.builder(PREFIX + ".closed", poolMetrics, ConnectionPoolMetrics::closed).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections have been closed.")+                    .register(meterRegistry);++            FunctionCounter.builder(PREFIX + ".created", poolMetrics, ConnectionPoolMetrics::created).tags(poolTags)+                    .baseUnit(BASE_UNIT_CONNECTIONS).description("The amount of connections have ever been created.")+                    .register(meterRegistry);++            FunctionCounter.builder(PREFIX + ".failedToCreate", poolMetrics, ConnectionPoolMetrics::failedToCreate)+                    .tags(poolTags).baseUnit(BASE_UNIT_CONNECTIONS)+                    .description("The amount of connections have been failed to create.").register(meterRegistry);++            Gauge.builder(PREFIX + ".idle", poolMetrics, ConnectionPoolMetrics::idle).tags(poolTags)

Let's combine .idle and .inUse into one metric: maybe just the PREFIX or PREFIX + ".active". Together they represent the "live" connections, whether they are in use or not. Move idle and inUse to something like a status tag.

meistermeier

comment created time in 6 days

Pull request review commentmicrometer-metrics/micrometer

Add Neo4j Java driver metrics.

 def VERSIONS = [         'org.mockito:mockito-core:latest.release',         'org.mockito:mockito-inline:latest.release',         'org.mongodb:mongo-java-driver:latest.release',+        'org.neo4j.driver:neo4j-java-driver:4.1.+',

Can we keep this to latest.release and allow dependency locking to do it's thing?

meistermeier

comment created time in 6 days

issue closedopenrewrite/rewrite

ChangeMethodName should update static imports by name

  - org.openrewrite.java.ChangeMethodName:
      method: org.mockito.Matchers anyVararg()
      name: any

Should turn import static org.mockito.Matchers.anyVararg; into import static org.mockito.Matchers.any;

closed time in 8 days

sambsnyd

issue commentopenrewrite/rewrite

ChangeMethodName should update static imports by name

Fixed with 1162273ad0bafbe2d01059649735500ef19b5266.

sambsnyd

comment created time in 8 days

push eventopenrewrite/rewrite

sullis

commit sha 711c4598c7e5477e67390c5bc997c49ab06492fc

add Gradle wrapper validation (#4)

view details

push time in 8 days

PR merged openrewrite/rewrite

add Gradle wrapper validation

https://blog.gradle.org/gradle-wrapper-checksum-verification-github-action

+10 -0

1 comment

1 changed file

sullis

pr closed time in 8 days

push eventopenrewrite/rewrite

Sam Snyder

commit sha 4ff0d76cb35d79998e51ee3f943dfa2fdad20135

Change ProfileConfiguration to accept only a single 'extends' clause on profiles. This makes rewrite able to parse the configuration files as we've written them in the rewrite-spring module.

view details

Sam Snyder

commit sha 197609eb41bd6d0f67f9bdeb7b5006c87617d7cc

Make sure rewrite-google-java-format can be parsed by ClasspathResourceLoader

view details

Sam Snyder

commit sha da8790084515b65c515f6be95627603692a34421

Add a TestUtils to make it easy to write tests validating yml-based profiles

view details

Sam Snyder

commit sha b3d2f29f21d24fff98fb9f280d7ae97d58229628

Add missing license comment

view details

Jonathan Schneider

commit sha 992b79554074a33936fe62f18613174b88d88fde

Merge pull request #8 from openrewrite/parse-profiles-with-extends Change ProfileConfiguration to accept only a single 'extends' clause on profiles.

view details

push time in 8 days

PR merged openrewrite/rewrite

Change ProfileConfiguration to accept only a single 'extends' clause on profiles.

This makes rewrite able to parse the configuration files as we've written them in the rewrite-spring module. Also add TestUtils to make it easy to write tests validating yml-based profiles.

+104 -13

0 comment

9 changed files

sambsnyd

pr closed time in 8 days

issue commentopenrewrite/rewrite

J.NewClass doesn't expose the names of a constructor's parameters

@sambsnyd Just FYI, it's not always known what the parameter names are. For the same reason, Jackson etc. have a hard time with constructor injection. They only are determinable if the constructor is defined in the same repository or if the binary in which the constructor is defined was compiled with -parameters, which is unfortunately not the default.

sambsnyd

comment created time in 8 days

created tagopenrewrite/rewrite

tagv2.1.1

Eliminate tech-debt. Automatically.

created time in 13 days

release openrewrite/rewrite

v2.1.1

released time in 13 days

push eventopenrewrite/rewrite-spring

Jonathan Schneider

commit sha 7a6cf735b3ce66db2d79e2f5cda66b3a8d92120f

All but nested use cases of ValueToConfigurationProperties

view details

push time in 14 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha b1797608d8064bc0d1941b50c0af33bb8811ff5d

All but nested use cases of ValueToConfigurationProperties

view details

push time in 14 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 9621931e564655e744797e027c2fb618d9c9c752

Extend ChangeMethodName to method declarations

view details

push time in 14 days

Pull request review commentmicrometer-metrics/micrometer

Adding total JVM heap/non-heap memory usage metrics

 public void bindTo(MeterRegistry registry) {                 .baseUnit(BaseUnits.BYTES)                 .register(registry);         }++        //The used and committed size of the returned memory usage is the sum of those values of all heap/non-heap memory pools+        // whereas the max size of the returned memory usage represents the setting of the non-heap/non-heap memory which may+        // not be the sum of those of all non-heap memory pools. If the setting is missing for heap/non-heap memory pools these values come as -1.++        MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean();++        Iterable<Tag> tagsWithId = Tags.concat(tags,"id", "total", "area", "heap");++        Gauge.builder("jvm.memory.used", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getUsed, "heap"))+                .tags(tagsWithId)+                .description("The amount of used memory")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.max", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getMax, "heap"))+                .tags(tagsWithId)+                .description("The maximum amount of memory in bytes that can be used for memory management")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.committed", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getCommitted, "heap"))+                .tags(tagsWithId)+                .description("The amount of memory in bytes that is committed for the Java virtual machine to use")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.heap_used_percent", memoryMXBean, (mem) -> getHeapUsagePercent(mem))

i.e. is it because they aren't from the same FROM xxx? Is this a limitation of Influx or of Grafana's UI implementation of Influx queries?

veera-chenna

comment created time in 14 days

Pull request review commentmicrometer-metrics/micrometer

Adding total JVM heap/non-heap memory usage metrics

 public void bindTo(MeterRegistry registry) {                 .baseUnit(BaseUnits.BYTES)                 .register(registry);         }++        //The used and committed size of the returned memory usage is the sum of those values of all heap/non-heap memory pools+        // whereas the max size of the returned memory usage represents the setting of the non-heap/non-heap memory which may+        // not be the sum of those of all non-heap memory pools. If the setting is missing for heap/non-heap memory pools these values come as -1.++        MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean();++        Iterable<Tag> tagsWithId = Tags.concat(tags,"id", "total", "area", "heap");++        Gauge.builder("jvm.memory.used", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getUsed, "heap"))+                .tags(tagsWithId)+                .description("The amount of used memory")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.max", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getMax, "heap"))+                .tags(tagsWithId)+                .description("The maximum amount of memory in bytes that can be used for memory management")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.committed", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getCommitted, "heap"))+                .tags(tagsWithId)+                .description("The amount of memory in bytes that is committed for the Java virtual machine to use")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.heap_used_percent", memoryMXBean, (mem) -> getHeapUsagePercent(mem))

I want to try to come up with a solution for this for you. But pre-computing doesn't seem to be the right way, or we'd be adding a ton of this throughout instrumentation everywhere. You're adding pre-computed stats for things you care about now, but there's no logical end to this progression. Can you help me understand why Influx division doesn't work to compute percentiles? https://docs.influxdata.com/influxdb/v1.8/query_language/math_operators/#division

veera-chenna

comment created time in 14 days

Pull request review commentmicrometer-metrics/micrometer

Adding total JVM heap/non-heap memory usage metrics

 public void bindTo(MeterRegistry registry) {                 .baseUnit(BaseUnits.BYTES)                 .register(registry);         }++        //The used and committed size of the returned memory usage is the sum of those values of all heap/non-heap memory pools+        // whereas the max size of the returned memory usage represents the setting of the non-heap/non-heap memory which may+        // not be the sum of those of all non-heap memory pools. If the setting is missing for heap/non-heap memory pools these values come as -1.++        MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean();++        Iterable<Tag> tagsWithId = Tags.concat(tags,"id", "total", "area", "heap");++        Gauge.builder("jvm.memory.used", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getUsed, "heap"))

Can you shed some light on why there are missing points? Telegraf dropping them? What's going on with this?

veera-chenna

comment created time in 14 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha d82907706376842c079c04aeb22ee2bac1360084

Add MultiSourceVisitor

view details

push time in 14 days

issue commenteclipse/microprofile-metrics

New methods to create Gauges in 3.0 are too implementation dependent

If it helps clarity a bit, a FunctionCounter should have a similar API surface area as a Gauge, but the user is responsible for promising to meet the contract that the observable value is monotonically increasing.

ebullient

comment created time in 14 days

Pull request review commentmicrometer-metrics/micrometer

Adding total JVM heap/non-heap memory usage metrics

 public void bindTo(MeterRegistry registry) {                 .baseUnit(BaseUnits.BYTES)                 .register(registry);         }++        //The used and committed size of the returned memory usage is the sum of those values of all heap/non-heap memory pools+        // whereas the max size of the returned memory usage represents the setting of the non-heap/non-heap memory which may+        // not be the sum of those of all non-heap memory pools. If the setting is missing for heap/non-heap memory pools these values come as -1.++        MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean();++        Iterable<Tag> tagsWithId = Tags.concat(tags,"id", "total", "area", "heap");++        Gauge.builder("jvm.memory.used", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getUsed, "heap"))

why sum these up? dimensional monitoring systems will allow you to select all individual heap areas and sum over them as part of the query?

veera-chenna

comment created time in 14 days

Pull request review commentmicrometer-metrics/micrometer

Adding total JVM heap/non-heap memory usage metrics

 public void bindTo(MeterRegistry registry) {                 .baseUnit(BaseUnits.BYTES)                 .register(registry);         }++        //The used and committed size of the returned memory usage is the sum of those values of all heap/non-heap memory pools+        // whereas the max size of the returned memory usage represents the setting of the non-heap/non-heap memory which may+        // not be the sum of those of all non-heap memory pools. If the setting is missing for heap/non-heap memory pools these values come as -1.++        MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean();++        Iterable<Tag> tagsWithId = Tags.concat(tags,"id", "total", "area", "heap");++        Gauge.builder("jvm.memory.used", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getUsed, "heap"))+                .tags(tagsWithId)+                .description("The amount of used memory")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.max", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getMax, "heap"))+                .tags(tagsWithId)+                .description("The maximum amount of memory in bytes that can be used for memory management")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.committed", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getCommitted, "heap"))+                .tags(tagsWithId)+                .description("The amount of memory in bytes that is committed for the Java virtual machine to use")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.heap_used_percent", memoryMXBean, (mem) -> getHeapUsagePercent(mem))

is there a reason we need to precompute the percent when we are shipping its constituent parts?

veera-chenna

comment created time in 14 days

Pull request review commentmicrometer-metrics/micrometer

Adding total JVM heap/non-heap memory usage metrics

 public void bindTo(MeterRegistry registry) {                 .baseUnit(BaseUnits.BYTES)                 .register(registry);         }++        //The used and committed size of the returned memory usage is the sum of those values of all heap/non-heap memory pools+        // whereas the max size of the returned memory usage represents the setting of the non-heap/non-heap memory which may+        // not be the sum of those of all non-heap memory pools. If the setting is missing for heap/non-heap memory pools these values come as -1.++        MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean();++        Iterable<Tag> tagsWithId = Tags.concat(tags,"id", "total", "area", "heap");++        Gauge.builder("jvm.memory.used", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getUsed, "heap"))+                .tags(tagsWithId)+                .description("The amount of used memory")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.max", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getMax, "heap"))+                .tags(tagsWithId)+                .description("The maximum amount of memory in bytes that can be used for memory management")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.committed", memoryMXBean, (mem) -> getTotalAreaUsageValue(mem, MemoryUsage::getCommitted, "heap"))+                .tags(tagsWithId)+                .description("The amount of memory in bytes that is committed for the Java virtual machine to use")+                .baseUnit(BaseUnits.BYTES)+                .register(registry);++        Gauge.builder("jvm.memory.heap_used_percent", memoryMXBean, (mem) -> getHeapUsagePercent(mem))

we should only use . and not _ in meter names and tag keys.

veera-chenna

comment created time in 14 days

push eventopenrewrite/rewrite-spring

Jonathan Schneider

commit sha 62bad421e0652bc6494eaa4d97c4a6345f640d13

Field injectable @Component to @Bean definition

view details

push time in 15 days

push eventopenrewrite/rewrite-spring

Jonathan Schneider

commit sha ee6fff85a3e918732d01929a7196d514bc202c5d

Constructor injectable @Component to @Bean definitions

view details

push time in 15 days

push eventopenrewrite/rewrite-java-8

Jonathan Schneider

commit sha cf78475ae62b76bd98e3d3bd034ff7fda2d51501

Don't attempt to map error types to JavaType.Class

view details

push time in 15 days

created tagopenrewrite/rewrite

tagv2.1.0

Eliminate tech-debt. Automatically.

created time in 16 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha ec71c6339cdd36de64bcf540eb7f307904783a83

Add AutoFormat, add getPrefix()/getSuffix() to Tree

view details

Jonathan Schneider

commit sha 9ee7d974f8607a6532cafaeae0bb70d1f28b34a5

Fix type attribution of newly generated method declarations

view details

push time in 16 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha de05514ec1041a407db7f2bdd1b6b21e22bc07ca

Add TreeBuilder.buildMethodDeclaration(..)

view details

push time in 16 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 96b0b2895aeeb7c007fec515a6995eb50b0e484f

Add lombok.config to maven project

view details

push time in 16 days

push eventopenrewrite/rewrite-checkstyle

Jonathan Schneider

commit sha 06e41d592656e0448b10568b1bd795d86894351c

Gradle 6.5.1, remove lombok, latest.integration builds of rewrite core

view details

push time in 16 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 918b0901c0d230723a82a9f4ea3073f5bea8de7a

Fix ProfileConfigurationTest

view details

push time in 16 days

push eventopenrewrite/rewrite-spring

Jonathan Schneider

commit sha d207e0f39e6425e1587aefa8baae2072f692d5ee

Properties migration visitors extend from each other

view details

push time in 16 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha fc702bbf5cba3a14fdb9caeafd604b4d8a3401be

Fix SourceVisitor javadoc

view details

push time in 16 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha dcda48f39f7ccbea54cf9afd953bba33f8d7a44d

Allow visitors defined in the same YAML to extend from one another

view details

push time in 16 days

push eventopenrewrite/rewrite-java-8

Jonathan Schneider

commit sha 6ebd5c363cea869167208fe048dd7f2b0aa1df9f

Update for latest rewrite-core/rewrite-java

view details

push time in 17 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha d8fedfcfd3116fe1105b90847a439c9020af8ca8

UseStaticImport

view details

push time in 17 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 5d95788631069581e097423e3cec722e1fd9b49e

Fix import ordering definition of google-java-format profile

view details

push time in 17 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 9a2898f4415f8d7725f61b1576961b6730a2d7c5

Fix serialization round-trip across the board, add import layout style

view details

push time in 17 days

startedpravega/pravega

started time in 18 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha d993d249102bcd114b7ad0d645011c177db0f112

Maven UpgradeParentVersion

view details

push time in 20 days

issue closedmicrometer-metrics/micrometer

Adding container tag,for example pod_name

Using Spring Boot Actuator and Prometheus in K8S, the metrics has't any lebel about the container or pod, we usually filter or aggregate there metrics by container or pod. How can i acheive this goal?

closed time in 20 days

CoderLan0668

issue commentmicrometer-metrics/micrometer

Adding container tag,for example pod_name

If you would like to do it programmatically, can accomplish it with the fabric8 K8S client:

image

CoderLan0668

comment created time in 20 days

startedspotify/backstage

started time in 21 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 5fc4dad8735b6d770b2aceca8e1780fcf177f3e0

Start of AddDependency

view details

Jonathan Schneider

commit sha 43dba0aba7bb82623192561a14d9bb6060ff2497

Change dependency scope

view details

push time in 22 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha d6837f32674d4eba0201b42639711e2db3fbb89e

Finished UpgradeVersion for Maven

view details

push time in 22 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 39e3030dd80c92e15e7eea26cd53e276e27af201

Tilde ranges

view details

push time in 23 days

push eventopenrewrite/rewrite-logging

Sean C. Sullivan

commit sha 6b72778a7940db42fd9d887222ed77c10abc39ae

chmod +x gradlew

view details

push time in 23 days

pull request commentopenrewrite/rewrite-logging

chmod +x gradlew

Good catch, thanks!

sullis

comment created time in 23 days

pull request commentmicrometer-metrics/micrometer

enable Dependabot v2

It's a little trickier here I think. In Micrometer, the master branch uses latest.release pretty much everywhere so every build pulls latest. On release branches we use locked dependencies. So if dependabot were to discover a vulnerability in a release branch, it would have to update the lock.

sullis

comment created time in 23 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha c197b4308517b8015933e9524f56e9b7f435ea3e

Gradle 6.5.1, GenerateConstructorUsingFields fix for empty field list

view details

push time in 23 days

push eventopenrewrite/rewrite-spring

Jonathan Schneider

commit sha a7ee7b947a1a6a97b6d651b55efe54e567a16564

Gradle 6.5.1, add ConstructorInjectionTest and RestTemplateBuilderRequestFactory

view details

push time in 23 days

startedreviewdog/reviewdog

started time in 24 days

created tagopenrewrite/rewrite

tagv2.1.0-rc.3

Eliminate tech-debt. Automatically.

created time in 25 days

release openrewrite/rewrite

v2.1.0-rc.3

released time in 25 days

push eventopenrewrite/rewrite

Jonathan Schneider

commit sha 508f38f3a7e186d902278045207cfdd7a0f1812b

Fix test

view details

push time in 25 days

push eventopenrewrite/rewrite-maven-plugin

dependabot[bot]

commit sha 98718d465cef71024a599761d79f2800b53f0dcc

Bump rsocket-transport-netty from 1.0.0 to 1.0.1 Bumps [rsocket-transport-netty](https://github.com/rsocket/rsocket-java) from 1.0.0 to 1.0.1. - [Release notes](https://github.com/rsocket/rsocket-java/releases) - [Commits](https://github.com/rsocket/rsocket-java/compare/1.0.0...1.0.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 25 days

PR merged openrewrite/rewrite-maven-plugin

Bump rsocket-transport-netty from 1.0.0 to 1.0.1 dependencies java

Bumps rsocket-transport-netty from 1.0.0 to 1.0.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rsocket/rsocket-java/releases">rsocket-transport-netty's releases</a>.</em></p> <blockquote> <h2>1.0.1 Release</h2> <h2>:star: New Features</h2> <ul> <li>Exposes API for the full customization of websocket sending / handling <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/835">#835</a></li> </ul> <h2>:beetle: Bug Fixes</h2> <ul> <li>Provides error handling in case Bubbling / NIC exceptions <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/863">#863</a></li> <li>Fixes responder to handle errors according to the spec <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/861">#861</a></li> <li>Fixes ConnectionSetupPayload refcnt management <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/854">#854</a></li> <li>Ensures streams are terminated if racing terminal and new stream <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/848">#848</a></li> <li>Fixes ReconnectMono behaviour when racing invalidate and subscribe <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/issues/847">#847</a> <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/847">#847</a></li> <li>Bugfix <code>RSocketConnector#setupPayload</code> to copy the content <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/843">#843</a></li> </ul> <h2>:notebook_with_decorative_cover: Documentation</h2> <ul> <li>RSocketClient and RSocketConnector Javadoc update <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/856">#856</a></li> <li>Provides well documented lease example <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/840">#840</a></li> <li>Update WebSocketHeadersSample <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/839">#839</a></li> </ul> <h2>:hammer: Other</h2> <ul> <li>Ensures there is no extra logging about a dropped error <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/859">#859</a></li> <li>Ensures lease is used exactly on request frame sending <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/855">#855</a></li> <li>Forward compatibility with Reactor Netty 1.0 <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/851">#851</a></li> <li>Apply FragmentationDuplexConnection from a single place <a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/pull/836">#836</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rsocket/rsocket-java/commit/4708f32cf117fe80564d061eba259a63b6a73ad7"><code>4708f32</code></a> upgrades reactor-bom/netty-bom/gradle; fixes failing test</li> <li><a href="https://github.com/rsocket/rsocket-java/commit/9181ebd7abcba6e6b160719b689a577e1017a747"><code>9181ebd</code></a> provides error handling in case Bubbling / NIC exceptions (<a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/issues/863">#863</a>)</li> <li><a href="https://github.com/rsocket/rsocket-java/commit/1a4cf5fd88a705d9cfe6ef766b98fa2f6e703dca"><code>1a4cf5f</code></a> fixes responder to handle errors according to the spec (<a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/issues/861">#861</a>)</li> <li><a href="https://github.com/rsocket/rsocket-java/commit/05fe717227ddf87b9e7184a7a34e81db23be81f9"><code>05fe717</code></a> fixes responder to convert incoming error appropriately</li> <li><a href="https://github.com/rsocket/rsocket-java/commit/1bfc694f4ebb0eec8126c1d4e6c39f25ad4d0d1f"><code>1bfc694</code></a> ensures there is no extra logging about a dropped error</li> <li><a href="https://github.com/rsocket/rsocket-java/commit/1bc64209a6c7e5c087df9370416c5ea671f356da"><code>1bc6420</code></a> changes version and CI script to 1.0.x</li> <li><a href="https://github.com/rsocket/rsocket-java/commit/3549dd5e58732757b962fba7e98c2ce08fa50963"><code>3549dd5</code></a> Revert "provides RSocketClient interface"</li> <li><a href="https://github.com/rsocket/rsocket-java/commit/f8bb4c8d541f516990151bf6b16999c15f1d2dc3"><code>f8bb4c8</code></a> Revert "RSocketClient and RSocketConnector Javadoc update (<a href="https://github-redirect.dependabot.com/rsocket/rsocket-java/issues/856">#856</a>)"</li> <li><a href="https://github.com/rsocket/rsocket-java/commit/ecc5d02c1a190bda1624497b03191bf8756da78b"><code>ecc5d02</code></a> updates master version to 1.1</li> <li><a href="https://github.com/rsocket/rsocket-java/commit/d663ad28fc953dd37b8ad8f20be15a7a2c286e1c"><code>d663ad2</code></a> removes keepalive from tests to avoid leaks assertion nondeterminism</li> <li>Additional commits viewable in <a href="https://github.com/rsocket/rsocket-java/compare/1.0.0...1.0.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 25 days

push eventopenrewrite/rewrite-maven-plugin

dependabot[bot]

commit sha 03aba032223b5c7160d67db68c32a42662cc84c6

Bump mojo-executor from 2.3.0 to 2.3.1 Bumps [mojo-executor](https://github.com/TimMoore/mojo-executor) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/TimMoore/mojo-executor/releases) - [Commits](https://github.com/TimMoore/mojo-executor/compare/mojo-executor-parent-2.3.0...mojo-executor-parent-2.3.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 25 days

PR merged openrewrite/rewrite-maven-plugin

Bump mojo-executor from 2.3.0 to 2.3.1 dependencies java

Bumps mojo-executor from 2.3.0 to 2.3.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/TimMoore/mojo-executor/commit/33978afd20efa5e9b074636d016084d1a27b5d58"><code>33978af</code></a> [maven-release-plugin] prepare release mojo-executor-parent-2.3.1</li> <li><a href="https://github.com/TimMoore/mojo-executor/commit/552b61fc592ff47035fc2557f5d67ae6168e8646"><code>552b61f</code></a> Define plugin versions</li> <li><a href="https://github.com/TimMoore/mojo-executor/commit/5a397737bec23e8e7a68cb5d4a0e321eecb45b00"><code>5a39773</code></a> Update README with my details</li> <li><a href="https://github.com/TimMoore/mojo-executor/commit/fe39176d2ee6ef7d5d48a2a3151db4fb6620f406"><code>fe39176</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/TimMoore/mojo-executor/issues/49">#49</a> from rnc/master</li> <li><a href="https://github.com/TimMoore/mojo-executor/commit/8c7a3fd8daaff720e2c7944e988cf86fe4447ddd"><code>8c7a3fd</code></a> Code cleanup</li> <li><a href="https://github.com/TimMoore/mojo-executor/commit/3c268751c02ddca98cd7770c04a007b0fb9c9072"><code>3c26875</code></a> Fix plugin groupId</li> <li><a href="https://github.com/TimMoore/mojo-executor/commit/157f0451b5d0197495b0ed45718428599bae17b1"><code>157f045</code></a> Update versions/plugins</li> <li><a href="https://github.com/TimMoore/mojo-executor/commit/c040c73ef9f16be2a2321dba103cbb5f59805e96"><code>c040c73</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/TimMoore/mojo-executor/issues/46">#46</a> from rnc/master</li> <li><a href="https://github.com/TimMoore/mojo-executor/commit/48bf7f5480221356b08c529ceaf5d1026de63de5"><code>48bf7f5</code></a> Update to openjdk8</li> <li><a href="https://github.com/TimMoore/mojo-executor/commit/40d7cb303d6fd53b957f77e36b2f8219fcb46039"><code>40d7cb3</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/TimMoore/mojo-executor/issues/41">#41</a> from carrot-garden/master</li> <li>Additional commits viewable in <a href="https://github.com/TimMoore/mojo-executor/compare/mojo-executor-parent-2.3.0...mojo-executor-parent-2.3.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 25 days

push eventopenrewrite/rewrite-maven-plugin

dependabot[bot]

commit sha 86c891326cdf066f705f6e0840851373f66c1f89

Bump micrometer-core from 1.5.1 to 1.5.2 Bumps [micrometer-core](https://github.com/micrometer-metrics/micrometer) from 1.5.1 to 1.5.2. - [Release notes](https://github.com/micrometer-metrics/micrometer/releases) - [Commits](https://github.com/micrometer-metrics/micrometer/compare/v1.5.1...v1.5.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 25 days

PR merged openrewrite/rewrite-maven-plugin

Bump micrometer-core from 1.5.1 to 1.5.2 dependencies java

Bumps micrometer-core from 1.5.1 to 1.5.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/micrometer-metrics/micrometer/releases">micrometer-core's releases</a>.</em></p> <blockquote> <h2>v1.5.2</h2> <p>This patch release contains the changes from the <a href="https://github.com/micrometer-metrics/micrometer/milestone/76?closed=1">1.5.2 milestone</a>, the <a href="https://github.com/micrometer-metrics/micrometer/releases/tag/v1.1.15">1.1.15 release</a>, and the <a href="https://github.com/micrometer-metrics/micrometer/releases/tag/v1.3.10">1.3.10 release</a>.</p> <hr /> <h3>micrometer-registry-graphite</h3> <p><a href="https://github-redirect.dependabot.com/micrometer-metrics/micrometer/issues/2069">#2069</a> Users wishing to use the Graphite tag support added in but broken since Micrometer 1.4, a workaround is now available. Specifically, you should upgrade your <code>metrics-graphite</code> dependency to 4.1.8 or later and provide a <code>GraphiteReporter</code> to the <code>GraphiteMeterRegistry</code> constructor with the new <code>addMetricAttributesAsTags</code> option set, such as will be done in the default <code>GraphiteReporter</code> in Micrometer 1.6.0:</p> <pre lang="java"><code>GraphiteReporter.forRegistry(metricRegistry) .withClock(new DropwizardClock(clock)) .convertRatesTo(config.rateUnits()) .convertDurationsTo(config.durationUnits()) .addMetricAttributesAsTags(config.graphiteTagsEnabled()) // this fixes #2069 .build(getGraphiteSender(config)); </code></pre> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/c77dd34f839a4971f80b0bf3609502c4105c9f6f"><code>c77dd34</code></a> Upgrade to reactor-core 3.3.7 and reactor-netty 0.9.9</li> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/d96bda2457ad3297e4ba643fc12725d0883d3b8d"><code>d96bda2</code></a> Guard exceptions from refresh logic in KafkaMetrics (<a href="https://github-redirect.dependabot.com/micrometer-metrics/micrometer/issues/2144">#2144</a>)</li> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/8f5773d8e0cd72ed3dd3477e0a7230c6c16f68ce"><code>8f5773d</code></a> Remove duplicated methods and adjust since tags</li> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/57ac9d3417195e00ba3dd39a819be02687b3cd38"><code>57ac9d3</code></a> Merge branch '1.3.x' into 1.5.x</li> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/9ae876be362572b57a79d8a65a06da3eaf5b14c2"><code>9ae876b</code></a> Add since tags to expected min/max Double builder methods</li> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/9e96da9db5368f1c3a62be9096bdb27ee948c9e7"><code>9e96da9</code></a> Add expected min/max Double variants for compatibility (<a href="https://github-redirect.dependabot.com/micrometer-metrics/micrometer/issues/2165">#2165</a>)</li> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/bd21b26463f5ba8ded83638c43fd19572a637ea6"><code>bd21b26</code></a> Merge branch '1.3.x' into 1.5.x</li> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/c29b53fb15bbc72901e3641c5cdb025acc28a8fb"><code>c29b53f</code></a> Merge branch '1.1.x' into 1.3.x</li> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/d4518739fc9887182b8d3fe7a241f3104f736a4d"><code>d451873</code></a> Remove redundant call to stop on close of GraphiteMeterRegistry</li> <li><a href="https://github.com/micrometer-metrics/micrometer/commit/d07375e5782811c99b92ee06b26dacb7f96488fe"><code>d07375e</code></a> Merge branch '1.3.x' into 1.5.x</li> <li>Additional commits viewable in <a href="https://github.com/micrometer-metrics/micrometer/compare/v1.5.1...v1.5.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 25 days

push eventopenrewrite/rewrite-maven-plugin

dependabot[bot]

commit sha e3815be5e88720705b89ca75150a759fd9eb265a

Bump maven-resources-plugin from 3.0.2 to 3.1.0 Bumps [maven-resources-plugin](https://github.com/apache/maven-resources-plugin) from 3.0.2 to 3.1.0. - [Release notes](https://github.com/apache/maven-resources-plugin/releases) - [Commits](https://github.com/apache/maven-resources-plugin/compare/maven-resources-plugin-3.0.2...maven-resources-plugin-3.1.0) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 25 days

PR merged openrewrite/rewrite-maven-plugin

Bump maven-resources-plugin from 3.0.2 to 3.1.0 dependencies java

Bumps maven-resources-plugin from 3.0.2 to 3.1.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/apache/maven-resources-plugin/commit/0e3e280101118aa60adf4c1ef6e4eebb243225f6"><code>0e3e280</code></a> [maven-release-plugin] prepare release maven-resources-plugin-3.1.0</li> <li><a href="https://github.com/apache/maven-resources-plugin/commit/1e3337e0b93b21bbb530e433c62aa513b6140eae"><code>1e3337e</code></a> Revert "[maven-release-plugin] prepare release maven-resources-plugin-3.1.0"</li> <li><a href="https://github.com/apache/maven-resources-plugin/commit/e583ca6cd87ef248e40b3d1ca604a1abdda53131"><code>e583ca6</code></a> [maven-release-plugin] prepare release maven-resources-plugin-3.1.0</li> <li><a href="https://github.com/apache/maven-resources-plugin/commit/5fbdee300020033e130159506b058e3181699082"><code>5fbdee3</code></a> Fixed JavaDoc issues.</li> <li><a href="https://github.com/apache/maven-resources-plugin/commit/6c9db7c81ac899ea7adac15017c61a371694dcef"><code>6c9db7c</code></a> Revert "[maven-release-plugin] prepare release maven-resources-plugin-3.1.0"</li> <li><a href="https://github.com/apache/maven-resources-plugin/commit/d43197f156e6bdab4a51993932b9bdcc052956c4"><code>d43197f</code></a> Revert "[maven-release-plugin] prepare for next development iteration"</li> <li><a href="https://github.com/apache/maven-resources-plugin/commit/930560ac39125fa0ff67390f80f216a58a1c6f28"><code>930560a</code></a> [maven-release-plugin] prepare for next development iteration</li> <li><a href="https://github.com/apache/maven-resources-plugin/commit/899a8ce467bc7381a7b2f8d130f1b2031111124a"><code>899a8ce</code></a> [maven-release-plugin] prepare release maven-resources-plugin-3.1.0</li> <li><a href="https://github.com/apache/maven-resources-plugin/commit/2a1f6f8488414e2c4f493aa01a79faa6a4f366ed"><code>2a1f6f8</code></a> [MRESOURCES-248] - Add documentation information for GitHub</li> <li><a href="https://github.com/apache/maven-resources-plugin/commit/c421c2f78a90392e9f5c49a1a8bf983c3addd52d"><code>c421c2f</code></a> [MRESOURCES-247] - Improve WARNING message about encoding.</li> <li>Additional commits viewable in <a href="https://github.com/apache/maven-resources-plugin/compare/maven-resources-plugin-3.0.2...maven-resources-plugin-3.1.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 25 days

push eventopenrewrite/rewrite-maven-plugin

dependabot[bot]

commit sha 9193479a5144c88fd537000298b75f87989719bf

Bump maven-compat from 3.5.0 to 3.6.3 Bumps [maven-compat](https://github.com/apache/maven) from 3.5.0 to 3.6.3. - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.5.0...maven-3.6.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 25 days

PR merged openrewrite/rewrite-maven-plugin

Bump maven-compat from 3.5.0 to 3.6.3 dependencies java

Bumps maven-compat from 3.5.0 to 3.6.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/apache/maven/commit/cecedd343002696d0abb50b32b541b8a6ba2883f"><code>cecedd3</code></a> [maven-release-plugin] prepare release maven-3.6.3</li> <li><a href="https://github.com/apache/maven/commit/f8bd6d577e43ba0c81f5be240d5282caf780f18d"><code>f8bd6d5</code></a> [MNG-6771] Fix license issues on binary distribution</li> <li><a href="https://github.com/apache/maven/commit/c82409a2d843427ceceb9a42b0a4dc46cc4637bd"><code>c82409a</code></a> [MNG-6759] Maven fails to use <repositories> section from dependency when res...</li> <li><a href="https://github.com/apache/maven/commit/6fa256d8d9ec828a3ababaec6a97c6aa7d7c667d"><code>6fa256d</code></a> update copyright year</li> <li><a href="https://github.com/apache/maven/commit/88591a78b0063992295d2a9904b33002db861de8"><code>88591a7</code></a> [MNG-6584] upgrade Wagon to 3.3.4 to get reason phrase handling back</li> <li><a href="https://github.com/apache/maven/commit/53ccee3486262f2b62f10a90d7d78889b2788707"><code>53ccee3</code></a> [MNG-6778] use https for schema location</li> <li><a href="https://github.com/apache/maven/commit/d657c9c6b467db60c932799485fb4210c0bd1fe0"><code>d657c9c</code></a> [MNG-6778] - Use https for maven schemaLocations</li> <li><a href="https://github.com/apache/maven/commit/0c7c69f78b2d23e693ce81e9172df42da77155d1"><code>0c7c69f</code></a> [MNG-6778] - Use https for maven schemaLocations</li> <li><a href="https://github.com/apache/maven/commit/bd10f00b68eb766cd239275e8504acedc2818d69"><code>bd10f00</code></a> [MNG-6789] upgrade and configure plugins for Reproducible Builds</li> <li><a href="https://github.com/apache/maven/commit/3a80ae08aac785deb61e417f82560cb06209d5bc"><code>3a80ae0</code></a> [MNG-6799] deprecate StringSearchModelInterpolator and remove <a href="https://github.com/Named">@Named</a></li> <li>Additional commits viewable in <a href="https://github.com/apache/maven/compare/maven-3.5.0...maven-3.6.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 25 days

push eventopenrewrite/rewrite-maven-plugin

Sean C. Sullivan

commit sha 8935941d878230e97296984cccfe071e9b9d5278

enable Dependabot v2

view details

push time in 25 days

push eventopenrewrite/rewrite-maven-plugin

Sean C. Sullivan

commit sha a0aca45384fcf2f91a0f0566cd5e1de83eb5da2c

enable GitHub Actions CI

view details

push time in 25 days

pull request commentopenrewrite/rewrite-maven-plugin

enable GitHub Actions CI

First experience with Github Actions CI, let's see what this does! Thanks @sullis .

sullis

comment created time in 25 days

push eventopenrewrite/rewrite-gradle-plugin

Sam

commit sha b3fc56c855a4f5b49c7ac1ecc4850540a3e87607

First pass at refactoring this to have the same semantics as the maven plugin (#1) Co-authored-by: Sam Snyder <sam@gradle.com>

view details

push time in a month

more