@rocky I'll give it a look after I finish solving the zoom problem.

With the improve-polygon-drawing branch the share button stopped working, so this branch fix it by removing old code from createLink function.
(this branch doesn't need improve-polygon-drawing branch to work)

With the improve-polygon-drawing branch the share button stopped working, so this branch fix it by removing old code from createLink function.
(this branch doesn't need improve-polygon-drawing branch to work)

Lastly, I'll mention that there is a big cleanup effort I'd like to see before going off and doing too much additional stuff.

Ok, I'll focus in the bugs.

@rocky do you want I implement the algorithm which checks if the shape has a hole?

I was wondering if it makes sense, as we won't implement polygons with holes, and polygons without holes are being drawn correctly.

@rocky I'm searching by the algorithm that calculate where the holes are, but I didn't find it, do you know where is it? I've searched in Polygon, PolygonBox, _Polyline, GraphicsBox (a big class but it doesn't look to be here) and BoxConstruct

@rocky yes, this is a better routine, I'll implement it. I'll look at the Mathics Core code that do it for 2d then translate to JavaScript.

I wasn't thinking of the holes, but of the overall star shape. I took the 2D 5-sided star and added a z component with 0.

@rocky for me it has a hole in 2d.

You keep pasting traceback (as one line line) which is output. And then want me to figure out what input you gave.

@rocky sorry. This output is the same for the following inputs:

Graphics3D[Cylinder[]]
Graphics3D[Cylinder[{0,0,0},{1,1,1}}]]

@TiagoCavalcanteTrindade Thanks for undertaking this. I just tried

Graphics3D[Polygon[{{150,0, 0},{121,90, 0},{198,35, 0},{102,35, 0},{179,90, 0}}]]

to see if there is a change here. Not yet.

In other news, it looks like I botched PieChart: when pulling out the formatting routines, I missed the formatting routine for ArcBox. (I still have a bit more work to do there as well)

No, to do it we need to calculate the holes.

@rocky I'm wanting to implement the following:

• Arrow
• Cone
• Cylinder
• Dodecahedron
• Octahedron
• Tetrahedron

The arrow can be done with the help of three.js' ArrowHelper.

All the others have a respective geometry in three.js.

Cylinder need to be rotated, and it [probably] can be done by a translate of the subtraction of the center and tip.

The current branch of Mathics Core is giving me the following error when I try to draw a cylinder:

System::exception:
Exception raised:  Traceback (most recent call last):  File "/home/tiago/mathics-django/mathics_django/web/views.py", line 245, in query result = evaluation.evaluate(expr, timeout=settings.TIMEOUT)  File "/usr/lib/python3.9/site-packages/Mathics3-2.2.1.dev0-py3.9.egg/mathics/core/evaluation.py", line 355, in evaluate result = run_with_timeout_and_stack(evaluate, timeout, self)  File "/usr/lib/python3.9/site-packages/Mathics3-2.2.1.dev0-py3.9.egg/mathics/core/evaluation.py", line 112, in run_with_timeout_and_stack return request()  File "/usr/lib/python3.9/site-packages/Mathics3-2.2.1.dev0-py3.9.egg/mathics/core/evaluation.py", line 348, in evaluate return self.format_output(self.last_eval, format)  File "/home/tiago/mathics-django/mathics_django/web/models.py", line 33, in <lambda> evaluation.format_output = lambda expr, format: format_output(evaluation, expr, format)  File "/home/tiago/mathics-django/mathics_django/web/format.py", line 100, in format_output return eval_boxes(result, result.boxes_to_js, obj)  File "/home/tiago/mathics-django/mathics_django/web/format.py", line 28, in eval_boxes boxes = fn(evaluation=obj, **options)  File "/usr/lib/python3.9/site-packages/Mathics3-2.2.1.dev0-py3.9.egg/mathics/builtin/drawing/graphics3d.py", line 464, in boxes_to_js json_repr = self.boxes_to_json(leaves, **options)  File "/usr/lib/python3.9/site-packages/Mathics3-2.2.1.dev0-py3.9.egg/mathics/builtin/drawing/graphics3d.py", line 485, in boxes_to_json ) = self._prepare_elements(leaves, options)  File "/usr/lib/python3.9/site-packages/Mathics3-2.2.1.dev0-py3.9.egg/mathics/builtin/drawing/graphics3d.py", line 351, in _prepare_elements elements = Graphics3DElements(leaves[0], evaluation)  File "/usr/lib/python3.9/site-packages/Mathics3-2.2.1.dev0-py3.9.egg/mathics/builtin/drawing/graphics3d.py", line 851, in __init__ super(Graphics3DElements, self).__init__(content, evaluation)  File "/usr/lib/python3.9/site-packages/Mathics3-2.2.1.dev0-py3.9.egg/mathics/builtin/graphics.py", line 2425, in __init__ self.elements = list(convert(content, self.get_style_class()(self)))  File "/usr/lib/python3.9/site-packages/Mathics3-2.2.1.dev0-py3.9.egg/mathics/builtin/graphics.py", line 2423, in convert raise BoxConstructError mathics.builtin.base.BoxConstructError</lambda>

About the zoom, I'm thinking in it. The problem is the following: when the formula is too long we need a scrollbar (just 1) because of the problem of MathJax doesn't respect the margin, but when we zoom, we want a scrollbar just at the zoomed formula (we want it overflow to be visible). An approach to solve this [maybe] is calculate the breaking formula width and re-calculating it on every resize. I'll try this approach.

This branch implements non triangular 3d polygon drawing.

This branch increase the support for coplanar polygons (aka shapes).

This branch still doesn't implements coplanar polygons with holes.

The byte-code manual lists goto as having a stack effect of -1+0. However looking at the source this doesn't seem to correct. It does not pop at all. Unless I am missing something?

	CASE (Bgoto):
	  op = FETCH2;
	op_branch:
	  op -= pc - bytestr_data;
	op_relative_branch:
	  if (BYTE_CODE_SAFE
	      && ! (bytestr_data - pc <= op
		    && op < bytestr_data + bytestr_length - pc))
	    emacs_abort ();
	  quitcounter += op < 0;
	  if (!quitcounter)
	    {
	      quitcounter = 1;
	      maybe_gc ();
	      maybe_quit ();
	    }
	  pc += op;
	  NEXT;

@rocky the PieChart is working to me:

Unknown type 0 Traceback (most recent call last): File "/usr/local/bin/decompyle3", line 11, in <module> load_entry_point('decompyle3==3.3.2', 'console_scripts', 'decompyle3')() File "/usr/local/lib/python3.8/dist-packages/decompyle3-3.3.2-py3.8.egg/decompyle3/bin/decompile.py", line 189, in main_bin File "/usr/local/lib/python3.8/dist-packages/decompyle3-3.3.2-py3.8.egg/decompyle3/main.py", line 296, in main File "/usr/local/lib/python3.8/dist-packages/decompyle3-3.3.2-py3.8.egg/decompyle3/main.py", line 207, in decompile_file File "/usr/local/lib/python3.8/dist-packages/decompyle3-3.3.2-py3.8.egg/decompyle3/main.py", line 80, in decompile AssertionError

I got this error any idea ?

@rocky last but not least, the following isn't working:

LoadModule["pymathics.hello"]
PyMathics`Hello["World"]

The output:

I'm wanting to create a machine learning module, so I was starting from pymathics-hello...

@rocky yes, was this. A rm -rf solved it.

Also, @rocky another hint: in drawGraphics3D data.axes.ticks_style is undefined.

Input:

Graphics3D[Sphere[]]

Output:

System::exception:
Exception raised: 'Graphics3DBox' object has no attribute 'boxes_to_js' Traceback (most recent call last):  File "/home/tiago/mathics-django/mathics_django/web/views.py", line 245, in query result = evaluation.evaluate(expr, timeout=settings.TIMEOUT)  File "/home/tiago/.local/lib/python3.9/site-packages/mathics/core/evaluation.py", line 355, in evaluate result = run_with_timeout_and_stack(evaluate, timeout, self)  File "/home/tiago/.local/lib/python3.9/site-packages/mathics/core/evaluation.py", line 112, in run_with_timeout_and_stack return request()  File "/home/tiago/.local/lib/python3.9/site-packages/mathics/core/evaluation.py", line 348, in evaluate return self.format_output(self.last_eval, format)  File "/home/tiago/mathics-django/mathics_django/web/models.py", line 33, in <lambda> evaluation.format_output = lambda expr, format: format_output(evaluation, expr, format)  File "/home/tiago/mathics-django/mathics_django/web/format.py", line 100, in format_output return eval_boxes(result, result.boxes_to_js, obj) AttributeError: 'Graphics3DBox' object has no attribute 'boxes_to_js'</lambda>

@rocky it's ready to merge.

Graphics3D isn't working, it returns Exception raised: 'Graphics3DBox' object has no attribute 'boxes_to_js' Traceback (most recent call last). Maybe it be the same error than PieChart.