profile
viewpoint
Robert Holt rjmholt @Microsoft Engineer on the @PowerShell team working on PowerShell and the VSCode PowerShell Extension. Programming language and FP enthusiast.

PowerShell/PowerShell 23859

PowerShell for every system!

PowerShell/PSScriptAnalyzer 1093

Download ScriptAnalyzer from PowerShellGallery

PowerShell/vscode-powershell 1078

Provides PowerShell language and debugging support for Visual Studio Code

PowerShell/PowerShellEditorServices 385

A common platform for PowerShell development support in any editor or application!

PowerShell/PowerShell-Docker 204

Repository for building PowerShell Docker images

PowerShell/WindowsCompatibility 124

Module that allows Windows PowerShell Modules to be used from PSCore6

PowerShell/PowerShell-Blog-Samples 4

Samples for the PowerShell blog

PowerShell/vscode-powershellise-keybindings 3

A Visual Studio Code extension that configures PowerShell ISE keybindings.

delete branch PowerShell/vscode-powershell

delete branch : powershell-notebook-patch-489021037

delete time in 12 hours

push eventPowerShell/vscode-powershell

github-actions[bot]

commit sha 28e6a0f46a8e6001be374200ae8a51fecb37f684

[Ignore] Update Notebook dts (#3134) Co-authored-by: TylerLeonhardt <TylerLeonhardt@users.noreply.github.com>

view details

push time in 12 hours

PR merged PowerShell/vscode-powershell

Reviewers
[Ignore] Update Notebook dts Created_by_Action dependencies

Automated changes by create-pull-request GitHub action

+6 -0

0 comment

1 changed file

github-actions[bot]

pr closed time in 12 hours

create barnchPowerShell/vscode-powershell

branch : powershell-notebook-patch-489021037

created branch time in 12 hours

issue openedPowerShell/vscode-powershell

Bug: PowerShell update fails

Issue Description

After opening a PowerShell file within VSCode, I get a notification saying "You have an old version of PowerShell (7.1.0). The current latest release is v7.1.1. Would you like to update the version? (This will close ALL pwsh terminals running in this Visual Studio Code session)." I click "Yes" and the notification says "Downloading PowerShell installer...", then after a few seconds the terminal reloads and the original notification appears stating "You have an old version of PowerShell (7.1.0)..." implying that the update failed.

For reference, I currently have PowerShell 7.1.0 installed with the VSCode PowerShell extension 2020.6.0 and VSCode installed machine wide (in the "C:\Program Files\Microsoft VS Code" directory).

Expected Behaviour

After clicking "Yes" to allow the update, it should update successfully.

Actual Behaviour

The download or installation fails after clicking "Yes", causing the update prompt to reappear.

created time in 16 hours

issue commentPowerShell/vscode-powershell

Implement HelpMessage in the interactive console

Recently ran across this issue working with MSLearning trying to create an advanced function in vscode and test the HelpMessage with mandatory parameters.

rjmholt

comment created time in 16 hours

PR opened PowerShell/vscode-powershell

Fixing installation behavior of brew for auto updater. Brew has deprecated cask use --cask instead.

PR Summary

https://github.com/PowerShell/vscode-powershell/issues/3131 this issue is resolved by this PR.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • [x] PR has a meaningful title
  • [x] Summarized changes
  • [ ] PR has tests (didn't find any relevant test files for this case)
  • [ ] This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready
+2 -2

0 comment

1 changed file

pr created time in a day

issue openedPowerShell/vscode-powershell

Powershell update button uses old brew install syntax that is deprecated

System Details

System Details Output

PS /Users/philipp> & {"### VSCode version: $(code -v)"; "`n### VSCode extensions:`n$(code --list-extensions --show-versions | Out-String)"; "`n### PSES version: $($pseditor.EditorServicesVersion)"; "`n### PowerShell version:`n$($PSVersionTable | Out-String)"}

### VSCode version: 1.52.1 ea3859d4ba2f3e577a159bc91e3074c5d85c0523 x64

### VSCode extensions:
dbaeumer.vscode-eslint@2.1.14
eamodio.gitlens@11.1.3
esbenp.prettier-vscode@5.8.0
James-Yu.latex-workshop@8.15.0
mechatroner.rainbow-csv@1.8.0
ms-azuretools.vscode-docker@1.9.0
ms-python.python@2020.12.424452561
ms-toolsai.jupyter@2020.12.414227025
ms-vscode-remote.remote-containers@0.154.2
ms-vscode.powershell@2020.6.0
redhat.vscode-yaml@0.14.0
VisualStudioExptTeam.vscodeintellicode@1.2.10
vscode-icons-team.vscode-icons@11.1.0
yzhang.markdown-all-in-one@3.4.0


### PSES version: 2.2.0.0

### PowerShell version:

Name                           Value
----                           -----
PSVersion                      7.1.0
PSEdition                      Core
GitCommitId                    7.1.0
OS                             Darwin 20.2.0 Darwin Kernel Version 20.2.0: Wed Dec  2 20:39:59 PST 2020; root:xnu-7195.60.75~1/RELEASE_X86_64 (MacOS 11)
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Brew version

PS /Users/philipp> brew config

HOMEBREW_VERSION: 2.7.4
ORIGIN: https://github.com/Homebrew/brew
HEAD: 663b972f449b679512a2c0e3303569a2e9bfba7c
Last commit: 2 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 800e4b5fec9e6047fd0a1100500398cf85834247
Core tap last commit: 44 minutes ago
Core tap branch: master
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.FaFo3wfVHI/org.macosforge.xquartz:0
HOMEBREW_MAKE_JOBS: 12
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby

Issue Description

I am experiencing a problem with the auto update toast notification. It uses the old brew upgrade cask powershell which is not supported anymore. Instead, it is brew upgrade --cask powershell.

Expected Behaviour

Use brew upgrade --cask powershell

Actual Behaviour

PS /Users/philipp> brew cask upgrade powershell
Error: Calling brew cask upgrade is disabled! Use brew upgrade [--cask] instead.

Screenshot 2021-01-15 at 13 28 22 Screenshot 2021-01-15 at 13 28 28

created time in a day

issue commentPowerShell/vscode-powershell

Powershell.ShowSessionMenu failed

I have similar thing, Powershell.ShowSessionMenu. I think since September.

15.01.2021 13:00:26 [NORMAL] - Visual Studio Code v1.52.1 64-bit
15.01.2021 13:00:26 [NORMAL] - PowerShell Extension v2020.6.0
15.01.2021 13:00:26 [NORMAL] - Operating System: Windows 64-bit
15.01.2021 13:00:26 [NORMAL] - Language server starting --
15.01.2021 13:00:26 [NORMAL] -     PowerShell executable: C:\Users\galgmapl\.dotnet\tools\pwsh.exe
15.01.2021 13:00:26 [NORMAL] -     PowerShell args: -NoProfile -NonInteractive -ExecutionPolicy Bypass -Command Import-Module 'c:\Users\galgmapl\.vscode\extensions\ms-vscode.powershell-2020.6.0\modules\PowerShellEditorServices\PowerShellEditorServices.psd1'; Start-EditorServices -HostName 'Visual Studio Code Host' -HostProfileId 'Microsoft.VSCode' -HostVersion '2020.6.0' -AdditionalModules @('PowerShellEditorServices.VSCode') -BundledModulesPath 'c:\Users\galgmapl\.vscode\extensions\ms-vscode.powershell-2020.6.0\modules' -EnableConsoleRepl -StartupBanner "=====> PowerShell Integrated Console v2020.6.0 <=====
" -LogLevel 'Normal' -LogPath 'c:\Users\galgmapl\.vscode\extensions\ms-vscode.powershell-2020.6.0\logs\1610712026-8ffd0b64-9f1f-4cae-9096-ab2fbde7336d1610712018782\EditorServices.log' -SessionDetailsPath 'c:\Users\galgmapl\.vscode\extensions\ms-vscode.powershell-2020.6.0\sessions\PSES-VSCode-24020-699868' -FeatureFlags @() 
15.01.2021 13:00:26 [NORMAL] -     PowerShell Editor Services args: Import-Module 'c:\Users\galgmapl\.vscode\extensions\ms-vscode.powershell-2020.6.0\modules\PowerShellEditorServices\PowerShellEditorServices.psd1'; Start-EditorServices -HostName 'Visual Studio Code Host' -HostProfileId 'Microsoft.VSCode' -HostVersion '2020.6.0' -AdditionalModules @('PowerShellEditorServices.VSCode') -BundledModulesPath 'c:\Users\galgmapl\.vscode\extensions\ms-vscode.powershell-2020.6.0\modules' -EnableConsoleRepl -StartupBanner "=====> PowerShell Integrated Console v2020.6.0 <=====
" -LogLevel 'Normal' -LogPath 'c:\Users\galgmapl\.vscode\extensions\ms-vscode.powershell-2020.6.0\logs\1610712026-8ffd0b64-9f1f-4cae-9096-ab2fbde7336d1610712018782\EditorServices.log' -SessionDetailsPath 'c:\Users\galgmapl\.vscode\extensions\ms-vscode.powershell-2020.6.0\sessions\PSES-VSCode-24020-699868' -FeatureFlags @() 
15.01.2021 13:00:26 [NORMAL] - pwsh.exe started.
15.01.2021 13:00:26 [NORMAL] - Waiting for session file
15.01.2021 13:01:26 [NORMAL] - Timed out waiting for session file to appear.
15.01.2021 13:01:26 [NORMAL] - Language server startup failed.
15.01.2021 13:01:26 [ERROR] - The language service could not be started: 
15.01.2021 13:01:26 [ERROR] - Error: Timed out waiting for session file to appear.
chughesvf

comment created time in a day

delete branch PowerShell/vscode-powershell

delete branch : powershell-notebook-patch-483952790

delete time in 2 days

push eventPowerShell/vscode-powershell

github-actions[bot]

commit sha e8c7ca02ea0b62dd07345b1f66d6fe2e30c6381b

[Ignore] Update Notebook dts (#3130) Co-authored-by: TylerLeonhardt <TylerLeonhardt@users.noreply.github.com>

view details

push time in 2 days

PR merged PowerShell/vscode-powershell

Reviewers
[Ignore] Update Notebook dts Created_by_Action dependencies

Automated changes by create-pull-request GitHub action

+5 -0

0 comment

1 changed file

github-actions[bot]

pr closed time in 2 days

issue closedPowerShell/vscode-powershell

Cyrillic letters are misrepresented in the terminal panel at runtime

Issue Description

Only at runtime the Cyrillic letters are misrepresented in the terminal panel. If i select a piece of code in the editor and run selection (F8) - the characters are displayed correctly. The same lines at runtime are misrepresented. The situation repeats itself if i use pwsh.exe in the Windows' command window. At runtime - wrong. If i type the same line manually - right.

Attached Logs

1609930968-7c63cc95-2ff6-4fd9-8e38-c306c09f6640160993095743420210106_1404.zip

Environment Information

Visual Studio Code

Name Version
Operating System Windows_NT x64 10.0.18363
VSCode 1.52.1
PowerShell Extension Version 2020.6.0

PowerShell Information

Name Value
PSVersion 7.1.0
PSEdition Core
GitCommitId 7.1.0
OS Microsoft Windows 10.0.18363
Platform Win32NT
PSCompatibleVersions 1.0 2.0 3.0 4.0 5.0 5.1.10032.0 6.0.0 6.1.0 6.2.0 7.0.0 7.1.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0

Visual Studio Code Extensions

<details><summary>Visual Studio Code Extensions(Click to Expand)</summary>

Extension Author Version
powershell ms-vscode 2020.6.0

closed time in 2 days

Koan-om

pull request commentPowerShell/vscode-powershell

Add braces to PSCustomObject snippet

upstream PR is in. Tomorrow's insiders should have the fix.

TylerLeonhardt

comment created time in 3 days

delete branch PowerShell/vscode-powershell

delete branch : dependabot/npm_and_yarn/sinon-9.2.3

delete time in 3 days

PR opened PowerShell/vscode-powershell

Add braces to PSCustomObject snippet

PR Summary

This will fix an outstanding issue where when you accept the PSCustomObject snippet, there is an extra ] on the right of the snippet. More details here https://github.com/microsoft/vscode/issues/104952

This requires this fix in VS Code to go in: https://github.com/microsoft/vscode/pull/114235

but personally, I don't think it hurts the experience if this PR went in before the next stable release of VS Code with the vscode fix.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • [x] PR has a meaningful title
  • [x] Summarized changes
  • [] PR has tests
  • [x] This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready
+1 -1

0 comment

1 changed file

pr created time in 3 days

PR opened PowerShell/PSScriptAnalyzer

Reviewers
move to new signing process for release build and prep for 1.19.2 Area - Build

PR Summary

The infrastructure at MS has changed with regard to signing, this PR allows us to use it.

PR Checklist

+248 -9

0 comment

8 changed files

pr created time in 3 days

issue openedPowerShell/vscode-powershell

Misinterpret if else brackets

We have written the needed Issue Type: <b>Bug</b>

When I run the attached code in Visual Studio Code with Powershell extension 2020.6.0, it skips over the else portion of the bracket. When I run this in PowerShell ISE or straight powershell, it works fine, but when I run in VSCode, it skips the else statement that should be associated with the first IF statement completely. The if statement is on line 80 and the corresponding else statement is on line 116. Thanks

#Start log file $LogFile = 'C:\programdata\kleinfelder\Logs\Add Remove Temp Local Admin.log' Start-Transcript -path $LogFile

#First Get a token from the app registered in Azure #App name is "SVC Intune - Powershell Graph API"

    # Define AppId, secret and scope, your tenant name and endpoint URL
$AppId = '34a16ac3-0492-44d5-bdd0-2b72818003f7'
$AppSecret = '4v9j0~9Nsen7at.zluPz4E.MA_5M~625A4'
$Scope = "https://graph.microsoft.com/.default"
$TenantName = "kleinfelder.com"

$Url = "https://login.microsoftonline.com/$TenantName/oauth2/v2.0/token"

# Add System.Web for urlencode
Add-Type -AssemblyName System.Web

# Create body
$Body = @{
    client_id = $AppId
    client_secret = $AppSecret
    scope = $Scope
    grant_type = 'client_credentials'
}

# Splat the parameters for Invoke-Restmethod for cleaner code
$PostSplat = @{
    ContentType = 'application/x-www-form-urlencoded'
    Method = 'POST'
    # Create string by joining bodylist with '&'
    Body = $Body
    Uri = $Url
}

Request the token from SVC Intune Azure application

$Request = Invoke-RestMethod @PostSplat

#Using the token - Create header for the API requests $Header = @{ Authorization = "$($Request.token_type) $($Request.access_token)" }

#User ID Graph API Request $UserEmail = $Env:USERNAME+"@kleinfelder.com" $GetUserIDURI = "https://graph.microsoft.com/v1.0/users/$userEmail" $RequestUser = Invoke-RestMethod -Uri $GetUserIDUri -Headers $Header -Method Get -ContentType "application/json" $UserID = $RequestUser.id

#Groups Graph API Request $GetUserGroupsUri = "https://graph.microsoft.com/v1.0/users/$UserID/memberOf" $RequestGroups = Invoke-RestMethod -Uri $GetUserGroupsUri -Headers $Header -Method Get -ContentType "application/json" $ListGroups = $RequestGroups.Value $ListGroupbyName = $Listgroups.displayname

#Write out each group that the user is a member of Write-host ************************************************* Write-Host $Env:USERNAME is a member of the following groups in Azure... foreach ($EachGroupName in $ListGRoupbyName){ Write-Host $EachGroupName } Write-host *************************************************

#Create Boolean variable. Set to True if user is part of the Temporary Local Admins group in Azure $TempLocalAmdins = "Temporary Local Admins" $InAzureGroup = $false foreach ($Group in $ListGroups) { $GroupName = $Group.displayname if($GroupName -eq $TempLocalAmdins){$InAzureGroup = $True} }

#Checking if current logged in user is already a local admin $userToFind = $env:USERNAME $administratorsAccount = Get-WmiObject Win32_Group -filter "LocalAccount=True AND SID='S-1-5-32-544'" $administratorQuery = "GroupComponent = "Win32_Group.Domain='" + $administratorsAccount.Domain + "',NAME='" + $administratorsAccount.Name + "'"" $InLocalGroup = Get-WmiObject Win32_GroupUser -filter $administratorQuery | select-object PartComponent | where-object {$_ -match $userToFind}

if($InAzureGroup){ write-host ********************************************* write-host User is member of $TempLocalAmdins Security Group write-host checking to see if they are a current local admin... write-host *********************************************

#If user is not a membner, then add them if(!$InLocalGroup){ write-host ********************************************* write-host User is not already a local admin write-host Adding user to the local admin group... write-host *********************************************

   #Grab current username and build Azure account name
   $loggedInUser = Gwmi -Class Win32_ComputerSystem | select username -ExpandProperty username
   $username = ($loggedInUser -split "\\")[1]

   #Identifying the correct path to the users profile folder - only selecting the first result in case there is a mess of profiles 
   #(which case you should do a clean up. As this script might not work in that case)
   $userProfile = Get-ChildItem (Join-Path -Path $env:SystemDrive -ChildPath 'Users') | Where-Object Name -Like "$username*" | select -First 1

   #add defined user to local admin group
   add-LocalGroupMember -Group 'Administrators' -Member AzureAD\$userProfile@kleinfelder.com –Verbose
   Stop-Transcript
   exit
}
else{
    write-host *********************************************
    write-host User is already a member of the local administrators and Azure group
    write-host No action taken
    write-host exit script
    write-host *********************************************
    Stop-Transcript
    exit
}

} else { if($inlocalgroup) { write-host ********************************************* write-host User is a local admin but not a member of $TempLocalAmdins write-host Removing user from the local admin group... write-host ********************************************* #Grab current username and build Azure account name $loggedInUser = Gwmi -Class Win32_ComputerSystem | select username -ExpandProperty username $username = ($loggedInUser -split "\")[1]

    #Identifying the correct path to the users profile folder - only selecting the first result in case there is a mess of profiles 
    #(which case you should do a clean up. As this script might not work in that case)
    $userProfile = Get-ChildItem (Join-Path -Path $env:SystemDrive -ChildPath 'Users') | Where-Object Name -Like "$username*" | Select-Object -First 1

    #add defined user to local admin group
    remove-LocalGroupMember -Group 'Administrators' -Member AzureAD\$userProfile@kleinfelder.com –Verbose
    Stop-Transcript
    exit
}
else
{
    write-host *********************************************
    write-host User is not a member of Azure group $TempLocalAmdins
    write-host User is not a mamber of the local admin group
    write-host No action taken
    write-host exit script
    write-host *********************************************
    Stop-Transcript
    exit
}

}

Extension version: 2020.9.0 VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z) OS version: Windows_NT x64 10.0.19042

<details> <summary>System Info</summary>

Item Value
CPUs Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 x 1498)
GPU Status 2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>oop_rasterization: disabled_off<br>opengl: enabled_on<br>protected_video_decode: enabled<br>rasterization: enabled<br>skia_renderer: disabled_off_ok<br>video_decode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled
Load (avg) undefined
Memory (System) 15.60GB (4.52GB free)
Process Argv --crash-reporter-id 5bcf0a44-c31c-41a4-96dc-41c20d51824f
Screen Reader no
VM 0%

</details><details> <summary>A/B Experiments</summary>

vsliv368cf:30146710
vsreu685:30147344
openlogontheside:30221877
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30211402
wsl2prompt:30224612
pythonvsdeb440:30242242
unusedpromptcf:30224611
folderexplorer:30224614
openfilemenu:30224647
pythonvsded773cf:30236630
pythonvspyt600:30241727
vsjup459cf:30237188

</details>

<!-- generated by issue reporter -->

created time in 3 days

Pull request review commentPowerShell/PowerShell-RFC

Updated governance and process: Working Groups (WGs)

 All RFC documents shall follow the [RFC template](RFCNNNN-New-RFC-Template.md).  ## RFC Workflow -RFCs may go through the following stages:+RFCs go through the following stages: -### Draft+### Draft PR  This is the initial draft of an RFC posted for comments and considered a work-in-progress. -* New proposed drafts should be submitted as a Pull Request from the Author's fork into the `Draft-Accepted` folder.-* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee Member can assign the next RFC number.-* If the Pull Request has followed the correct template and process, a Committee Member will assign the label `Review - Open for comments` to the Pull Request to indicate that anyone can comment on the content of the submission.-Typically, one or two months is allowed for comments, though this may be extended if a submission is particularly contentious or hasn't received enough feedback for the Committee to feel comfortable making a decision.-* When the Committee closes the comment period, the Author should update the RFC and Pull Request with a new commit to address the comments.-* The Committee shall vote to merge or reject the RFC.-Note: the Committee may be slower to respond to RFCs where the Author has indicated that they do not plan to implement the RFC.--### Draft-Accepted+* New drafts should not be submitted until the appropriate Working Group has decided that an RFC is+  required in order for an experimental implementation to be accepted.+* Drafts should be submitted as a draft Pull Request from the Author's fork into the+  `Draft-Accepted` folder.+* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee+  Member can assign the next RFC number.+* As a draft PR, contributors are encouraged to comment on the content of the submission. -The PowerShell Committee has reviewed the RFC and comments, and has voted to accept the RFC as a Draft.+### Non-Draft PR -* New comments are not being sought.-* No one has begun implementing the RFC, and there are no current plans to implement the RFC.-In this case, the Committee will create `up-for-grabs` Issues in the [PowerShell](https://github.com/PowerShell/PowerShell) repository.+* After two months, and when the Author feels that they've addressed feedback on the RFC,+  the Author should move the RFC PR out of the draft state.

This seems to be the intention. Might be worth renaming the Draft - Accepted folder at this point to reflect that. Other parts of the RFC here seem pretty clear that the folder workflow wasn't working / is no longer useful and won't be used going forward.

joeyaiello

comment created time in 3 days

Pull request review commentPowerShell/PowerShell-RFC

Updated governance and process: Working Groups (WGs)

 All RFC documents shall follow the [RFC template](RFCNNNN-New-RFC-Template.md).  ## RFC Workflow -RFCs may go through the following stages:+RFCs go through the following stages: -### Draft+### Draft PR  This is the initial draft of an RFC posted for comments and considered a work-in-progress. -* New proposed drafts should be submitted as a Pull Request from the Author's fork into the `Draft-Accepted` folder.-* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee Member can assign the next RFC number.-* If the Pull Request has followed the correct template and process, a Committee Member will assign the label `Review - Open for comments` to the Pull Request to indicate that anyone can comment on the content of the submission.-Typically, one or two months is allowed for comments, though this may be extended if a submission is particularly contentious or hasn't received enough feedback for the Committee to feel comfortable making a decision.-* When the Committee closes the comment period, the Author should update the RFC and Pull Request with a new commit to address the comments.-* The Committee shall vote to merge or reject the RFC.-Note: the Committee may be slower to respond to RFCs where the Author has indicated that they do not plan to implement the RFC.--### Draft-Accepted+* New drafts should not be submitted until the appropriate Working Group has decided that an RFC is+  required in order for an experimental implementation to be accepted.+* Drafts should be submitted as a draft Pull Request from the Author's fork into the+  `Draft-Accepted` folder.+* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee+  Member can assign the next RFC number.

RFC repo maintainer, I think? but yes, would be good to add explicitly

joeyaiello

comment created time in 3 days

Pull request review commentPowerShell/PowerShell-RFC

Updated governance and process: Working Groups (WGs)

 All RFC documents shall follow the [RFC template](RFCNNNN-New-RFC-Template.md).  ## RFC Workflow -RFCs may go through the following stages:+RFCs go through the following stages: -### Draft+### Draft PR  This is the initial draft of an RFC posted for comments and considered a work-in-progress. -* New proposed drafts should be submitted as a Pull Request from the Author's fork into the `Draft-Accepted` folder.-* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee Member can assign the next RFC number.-* If the Pull Request has followed the correct template and process, a Committee Member will assign the label `Review - Open for comments` to the Pull Request to indicate that anyone can comment on the content of the submission.-Typically, one or two months is allowed for comments, though this may be extended if a submission is particularly contentious or hasn't received enough feedback for the Committee to feel comfortable making a decision.-* When the Committee closes the comment period, the Author should update the RFC and Pull Request with a new commit to address the comments.-* The Committee shall vote to merge or reject the RFC.-Note: the Committee may be slower to respond to RFCs where the Author has indicated that they do not plan to implement the RFC.--### Draft-Accepted+* New drafts should not be submitted until the appropriate Working Group has decided that an RFC is+  required in order for an experimental implementation to be accepted.+* Drafts should be submitted as a draft Pull Request from the Author's fork into the+  `Draft-Accepted` folder.+* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee+  Member can assign the next RFC number.+* As a draft PR, contributors are encouraged to comment on the content of the submission. -The PowerShell Committee has reviewed the RFC and comments, and has voted to accept the RFC as a Draft.+### Non-Draft PR -* New comments are not being sought.-* No one has begun implementing the RFC, and there are no current plans to implement the RFC.-In this case, the Committee will create `up-for-grabs` Issues in the [PowerShell](https://github.com/PowerShell/PowerShell) repository.+* After two months, and when the Author feels that they've addressed feedback on the RFC,+  the Author should move the RFC PR out of the draft state.+  This signals to the Committee that the RFC is ready for their formal review.+* At this point, the Committee will add a `Review - Committee` label. -### Experimental+### Experimental Feature

Who and how strong will track timelines so that RFCs to go through all the steps on time?

joeyaiello

comment created time in 3 days

Pull request review commentPowerShell/PowerShell-RFC

Updated governance and process: Working Groups (WGs)

 All RFC documents shall follow the [RFC template](RFCNNNN-New-RFC-Template.md).  ## RFC Workflow -RFCs may go through the following stages:+RFCs go through the following stages: -### Draft+### Draft PR  This is the initial draft of an RFC posted for comments and considered a work-in-progress. -* New proposed drafts should be submitted as a Pull Request from the Author's fork into the `Draft-Accepted` folder.-* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee Member can assign the next RFC number.-* If the Pull Request has followed the correct template and process, a Committee Member will assign the label `Review - Open for comments` to the Pull Request to indicate that anyone can comment on the content of the submission.-Typically, one or two months is allowed for comments, though this may be extended if a submission is particularly contentious or hasn't received enough feedback for the Committee to feel comfortable making a decision.-* When the Committee closes the comment period, the Author should update the RFC and Pull Request with a new commit to address the comments.-* The Committee shall vote to merge or reject the RFC.-Note: the Committee may be slower to respond to RFCs where the Author has indicated that they do not plan to implement the RFC.--### Draft-Accepted+* New drafts should not be submitted until the appropriate Working Group has decided that an RFC is+  required in order for an experimental implementation to be accepted.+* Drafts should be submitted as a draft Pull Request from the Author's fork into the+  `Draft-Accepted` folder.+* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee+  Member can assign the next RFC number.+* As a draft PR, contributors are encouraged to comment on the content of the submission. -The PowerShell Committee has reviewed the RFC and comments, and has voted to accept the RFC as a Draft.+### Non-Draft PR -* New comments are not being sought.-* No one has begun implementing the RFC, and there are no current plans to implement the RFC.-In this case, the Committee will create `up-for-grabs` Issues in the [PowerShell](https://github.com/PowerShell/PowerShell) repository.+* After two months, and when the Author feels that they've addressed feedback on the RFC,+  the Author should move the RFC PR out of the draft state.

GitHub supports PR draft state - why do we need Draft folder at all? It seems we can pull PR as draft and use one folder in work time. Take into account that renaming and moving files break history and references. We should benefits from git.

joeyaiello

comment created time in 3 days

Pull request review commentPowerShell/PowerShell-RFC

Updated governance and process: Working Groups (WGs)

 All RFC documents shall follow the [RFC template](RFCNNNN-New-RFC-Template.md).  ## RFC Workflow -RFCs may go through the following stages:+RFCs go through the following stages: -### Draft+### Draft PR  This is the initial draft of an RFC posted for comments and considered a work-in-progress. -* New proposed drafts should be submitted as a Pull Request from the Author's fork into the `Draft-Accepted` folder.-* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee Member can assign the next RFC number.-* If the Pull Request has followed the correct template and process, a Committee Member will assign the label `Review - Open for comments` to the Pull Request to indicate that anyone can comment on the content of the submission.-Typically, one or two months is allowed for comments, though this may be extended if a submission is particularly contentious or hasn't received enough feedback for the Committee to feel comfortable making a decision.-* When the Committee closes the comment period, the Author should update the RFC and Pull Request with a new commit to address the comments.-* The Committee shall vote to merge or reject the RFC.-Note: the Committee may be slower to respond to RFCs where the Author has indicated that they do not plan to implement the RFC.--### Draft-Accepted+* New drafts should not be submitted until the appropriate Working Group has decided that an RFC is+  required in order for an experimental implementation to be accepted.+* Drafts should be submitted as a draft Pull Request from the Author's fork into the+  `Draft-Accepted` folder.+* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee+  Member can assign the next RFC number.

Who is "Member"? It is not defined in the RFC.

joeyaiello

comment created time in 3 days

Pull request review commentPowerShell/PowerShell-RFC

Updated governance and process: Working Groups (WGs)

 All RFC documents shall follow the [RFC template](RFCNNNN-New-RFC-Template.md).  ## RFC Workflow -RFCs may go through the following stages:+RFCs go through the following stages: -### Draft+### Draft PR  This is the initial draft of an RFC posted for comments and considered a work-in-progress. -* New proposed drafts should be submitted as a Pull Request from the Author's fork into the `Draft-Accepted` folder.-* The Author shall ensure that the `Allow edits from maintainers` box is checked so that a Committee Member can assign the next RFC number.-* If the Pull Request has followed the correct template and process, a Committee Member will assign the label `Review - Open for comments` to the Pull Request to indicate that anyone can comment on the content of the submission.-Typically, one or two months is allowed for comments, though this may be extended if a submission is particularly contentious or hasn't received enough feedback for the Committee to feel comfortable making a decision.-* When the Committee closes the comment period, the Author should update the RFC and Pull Request with a new commit to address the comments.-* The Committee shall vote to merge or reject the RFC.-Note: the Committee may be slower to respond to RFCs where the Author has indicated that they do not plan to implement the RFC.--### Draft-Accepted+* New drafts should not be submitted until the appropriate Working Group has decided that an RFC is+  required in order for an experimental implementation to be accepted.

In which repository is this decision made (and discussed)? I guess PowerShell/PowerShell. It makes sense to set this explicitly.

joeyaiello

comment created time in 3 days

delete branch PowerShell/vscode-powershell

delete branch : powershell-notebook-patch-481359474

delete time in 3 days

push eventPowerShell/vscode-powershell

github-actions[bot]

commit sha 45863c75edf00e6186f3525cfc862acb7da2ca00

[Ignore] Update Notebook dts (#3126) Co-authored-by: TylerLeonhardt <TylerLeonhardt@users.noreply.github.com>

view details

push time in 3 days

more