@karolz-ms

First I find this toggle mechanism annoying and less clean. (attaching before and after)

Second, let's say you have many microservices, and you want to deal with a specific one.

Before that feature, you would just click on one of them to gain focus, start typing part of the microservice name and vs-code would mark any matched microservices (elements) for you.

Now, with this feature, click on one of the elements to gain focus would toggle it and result in an unwanted reveal of its files :( A real pain in the neck.

Edit: I found that you don't have to click on of the elements for "filter-by-type", you could also click the scroll-bar / the dead area beneath the list.

Before

After

Still one of the most helpful and powerful extension by far!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

tryed registering custom language, with simple regex. It is throwing error on tokenizer.root.

    // Register a new language
monaco.languages.register({ id: 'gotemplate' });

// Register a tokens provider for the language
monaco.languages.setMonarchTokensProvider('gotemplate', {
  tokenizer: {
      root: [
          [/\pvm.*/, "custom-error"]
      ]
  }
});

Error:-

Uncaught (in promise) Error: gotemplate: rules must start with a match string or regular expression: tokenizer.root
    createError monarchCommon.ts:134
    setRegex monarchCompile.ts:350
    n monarchCompile.ts:426
    compile monarchCompile.ts:480
    v standaloneLanguages.ts:317

Hey @implausible - had some time so went to test this today, but noticed the alpha isn't published on NPM

Also, Electron 11 has since been released - have there been enough tests to publish 0.28.0? If not, could the alpha be published on NPM?

Thanks

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

When using afterContentClassName for delta decorations, the styles content property is not transformed to the dom tree. See example below, althought both decorations are rendered behind, the first decoration misses the the text 'There is someting behind'.

monaco-editor version: 0.21.1 Browser: Firefox/81.0.1, Chrome/85.0.4183.121 OS: Windows 10 Playground code that reproduces the issue:

javascript:

const editor = monaco.editor.create(document.getElementById("container"), {
    value: "one\ntwo"
});

const actions = editor.deltaDecorations([], [
    { range: new monaco.Range(1, 1, 1, 4), options: { afterContentClassName: 'redActionBox' } },
    { range: new monaco.Range(2, 1, 2, 4), options: { inlineClassName: 'blueActionBox' } },
]);

css:

.redActionBox {
    border: 0.1em solid rgb(0, 0, 0);
    box-sizing: border-box;
    content: "There is something behind";
    background-color: rgb(255, 192, 192);
    margin: 0.1em 0.2em 0px;
    display: inline;
    line-height: 1em;
    cursor: pointer;
}

.blueActionBox::after {
    border: 0.1em solid rgb(0, 0, 0);
    box-sizing: border-box;
    content: "There is something behind";
    background-color: rgb(192, 192, 255);
    margin: 0.1em 0.2em 0px;
    display: inline;
    line-height: 1em;
    cursor: pointer;
}

html:

<div id="container" style="height:100%;"></div>

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

I register a hover provider and a code action provider as follows:

  let da = new DiagnosticsAdapter(LANGUAGE_ID) // where we set markers by monaco.editor.setModelMarkers

  monaco.languages.registerHoverProvider(LANGUAGE_ID, {
    provideHover: (model, position, token) => {
        ... ...
    }
  });

  monaco.languages.registerCodeActionProvider(LANGUAGE_ID, {
    provideCodeActions: (model, _range, context, token) => {
        console.log("_range", _range)
        // use markers to make code actions
       ... ...
    }
  });

The result of this code is that, unlike provideHover, provideCodeActions does not have information like position. Thus, the code actions provided by Quick Fix are always the same no matter where we hover in the editor.

I tried to use _range, but I observed that _range printed in provideCodeActions is always the superset of the area of all the markers, it is not related to the position of the hover.

Coud anyone help?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

I am developing an language which can embed and run SQL inside. I use codelens to execute the SQL. I register codelens to the editor on the left, the codelens also appear on the editor on the right. I click the codelens on the right, it throws an error message.

Can you help me solve this? Thank you very much!

monaco-editor version: 0.20.0 Browser: Chrome OS: Ubuntu

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

Hi there. I need some helps.

I am using monaco editor as an official editor for my new programming language. I publish this as a NPM package. The problem seems to happen when I install and use my editor package (which contains monaco editor) and monaco editor package on my web project (vue) at the same time.

There are two pages where I use monaco editor. I use the editor from my package at page A, and from monaco editor on page B. At page B, I register another language, when I switch to page A, then switch back to page B, my language registered at page B disapear.

Can you help me solve this problem? Thank you very much.

monaco-editor version: 0.20.0 Browser: Chrome OS: Ubuntu

@dbaeumer is the syntax for identifiers language-specific, or is a c-like language assumed? I.e. could a hypothetical CommonLisp server respond with defaultBehavior if the cursor is on a symbol containing hyphens?

Could defaultBehavior be returned if the placeholder and thing being renamed are different? (Specific example: cursor is on a C label, the range is the entire label with colon, but the placeholder is only the identifier without the colon; in lsp-mode, we underline the thing being renamed, as determined from the rename range)

If I understood you correctly, by "client innovation", you are thinking of something like the client implementing some sort of live-rename based on textDocument/documentHighlight if defaultBehavioris returned?

A final thought: for specs like these, coordination between servers and clients is needed, and as such the defaultBehavior must be specified. Clients need to know how they should handle defaultBehavior, and servers need to know when they can send it. If this is left as is, the "do what VSCode does" situation described by @yyoncho will occur. I don't think the issue here is that various clients can do this best in different ways, but that they wouldn't know at all.

Has there been any decision yet on whether to integrate shellcheck? By using shellcheck for diagnostics, you don't have to reinvent the wheel for maintaining a diagnostics system. I would make a pull request myself, but I don't know Typescript.

I am happy to do this in two language servers (erlang-ls and haskell-language-server), but it is not clear to me what changes are needed on the vscode client side to enable it to start sending the tokens in the first place.

My understanding is that if the client supports the feature, it can always send the token. Servers that do not use it can ignore it, those that do, or need to for a particular request, can do that. So it should be a safe default to have on.

The deployment task is done (https://travis-ci.org/github/TypeFox/monaco-languageclient/jobs/746316167) but there is no published version on https://www.npmjs.com/package/monaco-languageclient, what am I missing?

I think this really depends on the server. One case is for example html where the client can't easily determine how words with a - in it should be handled on rename.

So the idea is:

The user is on foo - the server knows that the client can calculate that foo can be calculated by the client and returns defaultBehaviour. The user is on foo-bar - the server knows that the client cannot calculate the proper range and returns it in the response.

@KaKi87 nope, sorry. Wasn't looking too vigorously though :)

I’m having the same issue. I have a toggle able code lens, and when I turn it off the command is disabled, and the text does not disappear. I would expect for a code lens that got disposed to remove the inline text. Does anyone know how to remove the inline code lens text on dispose?

Instead of adjusting this I would rather opt that plugins having problems with this switch to an incremental buffer sync which is supported as well and has a delay of 0.

Would this be an options for you?

Using LSP's incremental feature works great!

Do you think this PR's feature is worth adding regardless? Or should we discourage LSP servers from only supporting full document changes?

I am okay with any of the three proposed options. But I do agree with @puremourning that (1) won't really benefit the ecosystem in general.

If we go with (2), then #1119 seems to become redundant. Perhaps @kdvolder and @mickaelistria want to have a say in this as well.

It is certainly one of the hardest things to implement for a client (in a general way). It's also a chicken-and-egg problem: if no language servers have support for partial results, then what's the point of implementing it? I was hoping that some language servers would start implementing support for especially textDocument/references, but no dice so far. I would be happy to see a language implementing it for textDocument/codeLens though (or even workspace/symbol).

<!-- IMPORTANT: Please be sure to remove any private information before submitting. -->

Does this occur consistently? <!-- TODO: Type Yes or No --> Repro steps: <!-- TODO: Share the steps needed to reliably reproduce the problem. Please include actual and expected results. -->

Action: vscode-docker.registries.azure.runFileAsTask Error type: Error Error Message: To run a task from a .yaml file you must have yaml file in your VS Code workspace.

Version: 1.8.1 OS: win32 OS Release: 10.0.19041 Product: Visual Studio Code Product Version: 1.51.1 Language: en

<details> <summary>Call Stack</summary>

Object.quickPickYamlFileItem extension.bundle.js:46:509845
processTicksAndRejections task_queues.js:94:5
Object.scheduleRunRequest extension.bundle.js:659:261109
runFileAsAzureTask extension.bundle.js:1040:128459

</details>

Bumps node-fetch from 2.6.0 to 2.6.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bitinn/node-fetch/releases">node-fetch's releases</a>.</em></p> <blockquote> <h2>v2.6.1</h2> <p><strong>This is an important security release. It is strongly recommended to update as soon as possible.</strong></p> <p>See <a href="https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md#v261">CHANGELOG</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md">node-fetch's changelog</a>.</em></p> <blockquote> <h2>v2.6.1</h2> <p><strong>This is an important security release. It is strongly recommended to update as soon as possible.</strong></p> <ul> <li>Fix: honor the <code>size</code> option after following a redirect.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/node-fetch/node-fetch/commit/b5e2e41b2b50bf2997720d6125accaf0dd68c0ab"><code>b5e2e41</code></a> update version number</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/2358a6c2563d1730a0cdaccc197c611949f6a334"><code>2358a6c</code></a> Honor the <code>size</code> option after following a redirect and revert data uri support</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/8c197f8982a238b3c345c64b17bfa92e16b4f7c4"><code>8c197f8</code></a> docs: Fix typos and grammatical errors in README.md (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/686">#686</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/1e99050f944ac435fce26a9549eadcc2419a968a"><code>1e99050</code></a> fix: Change error message thrown with redirect mode set to error (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/653">#653</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/244e6f63d42025465796e3ca4ce813bf2c31fc5b"><code>244e6f6</code></a> docs: Show backers in README</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/6a5d192034a0f438551dffb6d2d8df2c00921d16"><code>6a5d192</code></a> fix: Properly parse meta tag when parameters are reversed (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/682">#682</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/47a24a03eb49a49d81b768892aee10074ed54a91"><code>47a24a0</code></a> chore: Add opencollective badge</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/7b136627c537cb24430b0310638c9177a85acee1"><code>7b13662</code></a> chore: Add funding link</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/5535c2ed478d418969ecfd60c16453462de2a53f"><code>5535c2e</code></a> fix: Check for global.fetch before binding it (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/674">#674</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/1d5778ad0d910dbd1584fb407a186f5a0bc1ea22"><code>1d5778a</code></a> docs: Add Discord badge</li> <li>Additional commits viewable in <a href="https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~akepinski">akepinski</a>, a new releaser for node-fetch since your current version.</p> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

Looks like node-fetch is up-to-date now, so this is no longer needed.