42wim/matterbridge 3103
bridge between mattermost, IRC, gitter, xmpp, slack, discord, telegram, rocketchat, steam, twitch, ssh-chat, zulip, whatsapp, keybase, matrix, microsoft teams, nextcloud, mumble and more with REST API (mattermost not required!)
compsoc-edinburgh/betterinformatics 42
Welcome to Better Informatics. The student run website for students in the School of Informatics.
Biliard script for Multi Theft Auto
Little Sticky Destroyer
🗺️📡💃 The Marauders App helps you find rooms with free machines in university labs and helps you find your friends. It does this by SSHing into every machine and dialling home.
Bcrypt module for MTA:SA
compsoc-edinburgh/betterinformatics-flask 2
The unreleased flask rewrite of betterinformatics.com.
compsoc-edinburgh/escape19-api 1
SIGINT Escape Room 2019 API.
issue commentmultitheftauto/mtasa-blue
bitstream.h warning: function converting 'NetBitStreamInterface' to itself will never be used
Okay, I'll assign to ccw then
comment created time in 2 hours
push eventqaisjp/go-discord-irc
commit sha d0ae8eea20ce0b00d0c3b4a6164bca23a57c1582
Update README.md
push time in 2 hours
pull request commentmultitheftauto/mtasa-blue
Refactor LuaCommon to use template magic instead of lua_push`type`
"Change from void* to SArrayId" seems like a distinct workstream. is this something you could do later? if so, it's probably best to try and reduce the scope of changes so that if something goes wrong, we know exactly which change caused it. otherwise we will just have to revert the entire PR and leave it to you to figure out what exactly went wrong
comment created time in 12 hours
pull request commentmultitheftauto/mtasa-blue
Refactor LuaCommon to use template magic instead of lua_push`type`
btw, I'm asking if there's an issue for this because I don't know if converting everything to use templates is actually a good idea. i may be wrong, but i heard it can slow build times?
I'm hoping a more educated reviewer such as @sbx320 could take a look at this instead
comment created time in 18 hours
pull request commentmultitheftauto/mtasa-blue
Refactor LuaCommon to use template magic instead of lua_push`type`
btw great job with the atomic commits 👍 definitely easier to this review this!
comment created time in 18 hours
pull request commentmultitheftauto/mtasa-blue
Refactor LuaCommon to use template magic instead of lua_push`type`
is there an issue about this?
comment created time in 18 hours
startedcompsoc-edinburgh/deployment
started time in 19 hours
pull request commentmultitheftauto/mtasa-blue
Fix #1291: getRotation returns incorrect values for ped when set with createPed
and sets the rotation using SetCurrentRotation
why doesn't SetCurrentRotation update the matrix?
comment created time in a day
issue commentmultitheftauto/mtasa-blue
Refactor CLuaArgument to use std::variant
I always assumed that std::variant used a union. I guess not.
- I think the first task would be to make CLuaArgument shared (so that we don't have copy-pasted code in Client and Server).
- Then, since these fields are private, you could submit a pull request to use a std::variant instead of separate fields https://github.com/multitheftauto/mtasa-blue/blob/ed2abb30b032043a228565e56c974fc41f53e645/Client/mods/deathmatch/logic/lua/CLuaArgument.h#L66-L76
- Then, you could submit a new pull request changing things from
void ReadBool(bool bBool);toT Read<T>()(with an individual commit for each T, so that it's easier to review) https://github.com/multitheftauto/mtasa-blue/blob/ed2abb30b032043a228565e56c974fc41f53e645/Client/mods/deathmatch/logic/lua/CLuaArgument.h#L40-L47
comment created time in 2 days
issue commentmultitheftauto/mtasa-blue
m_pLuaManager used before its defined
Depending on globals are bad though
comment created time in 2 days
issue openedmultitheftauto/mtasa-blue
bitstream.h warning: function converting 'NetBitStreamInterface' to itself will never be used
<!--
|_ | / | _ \ / _ | _ _ |/ \ | \ | | |
| || |/| | |) | | | | |) || | / _ \ | | | | |
| || | | | /| || | _ < | |/ ___ | |\ | | |
||| ||| ___/|| _|// __| _| |_|
IF YOU ARE REPORTING A CHEAT OR A SECURITY VULNERABILITY... STOP!
DO NOT MAKE A PUBLIC POST. GO BACK. CLICK THE 'VIEW POLICY' BUTTON.
IF YOU HAVE TROUBLE FINDING THE RIGHT LINK:
https://github.com/multitheftauto/mtasa-blue/security/policy
-->
Describe the bug <!-- A clear and concise description of what the bug is. -->
build warning
../Shared/sdk/net/bitstream.h:384:13: warning: conversion function converting 'NetBitStreamInterface' to itself will never be used
virtual operator NetBitStreamInterface&() { return *this; }
^
To reproduce <!-- Steps to reproduce the behaviour:
- Go to '...'
- Click on '....'
- Scroll down to '....'
- See error
Please paste reproduction resources (zip files) directly into this section. --> build mta
Expected behaviour <!-- A clear and concise description of what you expected to happen. --> no warning
Additional context <!-- Add any other context about the problem here -->
should be an easy fix, just remove the function?
created time in 2 days
issue comment42wim/matterbridge
disallow @everyone and @here in discord
Nice!!!
comment created time in 2 days
push eventqaisjp/mta
commit sha 0d623ca058109ddfee3aca2b6fdece23258e1589
Update flip-cmanager-relationships.md (#1) Bookcase
push time in 3 days
PR merged qaisjp/mta
Bookcase
pr closed time in 3 days
push eventqaisjp/mta
commit sha 3e356fc4716b1f0214f311000e3ad4722725e344
Add information to README
push time in 3 days
push eventqaisjp/mta
commit sha db26a0455ae4b1a7c0ce0a764f3a1ba81dec66a2
Create flip-cmanager-relationships.md
push time in 3 days
issue comment42wim/matterbridge
disallow @everyone and @here in discord
ReplaceMessages=[ ["", ""], ["@everyone","@-everyone"], ["@here","@-here"], ["@test", "@-test"] ]
comment created time in 3 days
Pull request review commentmultitheftauto/mtasa-blue
Add roll state to getPedMoveState while crouching or crawling
eMovementState CClientPed::GetMovementState() if (cs.LeftStickX == 0 && cs.LeftStickY == 0) return MOVEMENTSTATE_CROUCH; else+ {+ // Is he aiming and rolling while crouching?+ if ((cs.LeftStickX == -128 || cs.LeftStickX == 128) && cs.RightShoulder1)+ return MOVEMENTSTATE_ROLL;
That makes me very happy
comment created time in 3 days
startedbookingcom/shipper
started time in 3 days
Pull request review commentmultitheftauto/mtasa-blue
Function to override the color filtering values
class CLuaWorldDefs : public CLuaDefs LUA_DECLARE(GetFPSLimit); LUA_DECLARE(CreateExplosion);++ static bool ResetColorFilter(lua_State* const luaVM);+ static bool SetColorFilter(lua_State* const luaVM, uchar ucPass0Red, uchar ucPass0Green, uchar ucPass0Blue, uchar ucPass0Alpha,+ uchar ucPass1Red, uchar ucPass1Green, uchar ucPass1Blue, uchar ucPass1Alpha);
Since the implementations aren't using the luaVM argument, there's no need to add it as a parameter
comment created time in 3 days
startedpenelopezone/rubyfmt
started time in 3 days
issue closedmultitheftauto/mtasa-blue
Allow CJ's clothing objects to be replaced to implement my shader system.
Is your feature request related to a problem? Please describe. the only problem is not to allow the changing of clothing objects, as this ends up limiting the use of developmental creativity. --
Describe the solution you'd like
I recently developed a system of clothing for other skins, similar to grozz. but I had an even bolder idea, why not use the GTA system itself and implement my clothing system? therefore, it would be even more optimized and easier to develop within the garments, including for modelers, just like in GTAV, but even if only for CJ my system has an implementation of textures where I could make unlimited models of the DFF, however for this idea I need the MTA to allow the replacement of the objects of the clothes for the realization of this idea..
Describe alternatives you've considered
I noticed that CJ's dff have internal dffs such as DFF: 1 DFF: 2 DFF: 3 one for the lean body another for the muscular body and another for the fat body, I took into consideration that if these parts have the replacement released I will be able to implement my shader, thus making the body part slim for both male and female as well as the other 2 using only the custom clothes system that I developed and posted on my channel..
Additional context you can see the system working on a skin that is not CJ through this link: https://www.youtube.com/watch?v=RhUMWSCJXVg.
closed time in 3 days
BaronScr
issue commentmultitheftauto/mtasa-blue
Allow CJ's clothing objects to be replaced to implement my shader system.
Duplicate of #1017
comment created time in 3 days
pull request commentmultitheftauto/mtasa-blue
Fix game freeze & updated BASS libraries
Do you have download links for the dlls?
comment created time in 4 days
startedcleolibrary/CLEO4
started time in 4 days
issue commentmultitheftauto/mtasa-blue
Jump and climb controls ignore setElementCollidableWith
Nice find. We might need a way to change surface properties per object, or more likely, just patch some jumping code to ignore non-collidable objects.
comment created time in 4 days
issue commentmultitheftauto/mtasa-blue
m_pLuaManager used before its defined
If it's not being used perhaps it should just be removed?
comment created time in 4 days
pull request commentmultitheftauto/mtasa-blue
Implement entering/exiting/jacking for peds
or nil
Is there a use case for being able to enter the closest vehicle via the closest door without caring if it's driver or passenger?
comment created time in 5 days
startedYACReader/yacreader
started time in 5 days
pull request commentmultitheftauto/mtasa-blue
Implement entering/exiting/jacking for peds
This PR needs coordination with the following PR: #620
What in particular do you think should be coordinated? The Lua API?
comment created time in 5 days
pull request commentmultitheftauto/mtasa-blue
Optimize split: Use string_view, and don't buffer if delimiter is a char
Nice! And thank you for including the link to your tests.
Did you measure to see the difference in speed in Lua?
comment created time in 6 days
Pull request review commentmultitheftauto/mtasa-blue
Refactor Lua manager to use std::vector for m_VirtualMachines
CLuaMain* CLuaManager::GetVirtualMachine(lua_State* luaVM) } // Find a matching VM in our map- CLuaMain* pLuaMain = MapFindRef(m_VirtualMachineMap, luaVM);- if (pLuaMain)- return pLuaMain;+ {+ CLuaMain* pLuaMain = MapFindRef(m_VirtualMachineMap, luaVM);+ if (pLuaMain)+ return pLuaMain;+ }
CLuaMain* pLuaMain = MapFindRef(m_VirtualMachineMap, luaVM);
if (pLuaMain)
return pLuaMain;
Is the change in indentation+scoping necessary here?
comment created time in 6 days
Pull request review commentmultitheftauto/mtasa-blue
Refactor Lua manager to use std::vector for m_VirtualMachines
class CLuaManager CRegisteredCommands* m_pRegisteredCommands; CFastHashMap<lua_State*, CLuaMain*> m_VirtualMachineMap;- std::list<CLuaMain*> m_virtualMachines;+ std::vector<CLuaMain*> m_VirtualMachines;
You are changing type from std::list to std::vector.
http://www.cplusplus.com/reference/vector/vector/erase/ says this:
Because vectors use an array as their underlying storage, erasing elements in positions other than the vector end causes the container to relocate all the elements after the segment erased to their new positions. This is generally an inefficient operation compared to the one performed for the same operation by other kinds of sequence containers (such as list or forward_list).
Have you taken this into consideration?
comment created time in 6 days
Pull request review commentmultitheftauto/mtasa-blue
Refactor Lua manager to use std::vector for m_VirtualMachines
void CLuaModule::_RegisterFunctions(lua_State* luaVM) void CLuaModule::_UnregisterFunctions() {- list<CLuaMain*>::const_iterator liter = m_pLuaModuleManager->GetLuaManager()->IterBegin();- for (; liter != m_pLuaModuleManager->GetLuaManager()->IterEnd(); ++liter)+ for (CLuaMain* luaMain : m_pLuaModuleManager->GetLuaManager()->GetLuaMains()) {- lua_State* luaVM = (*liter)->GetVM();- vector<SString>::iterator iter = m_Functions.begin();- for (; iter != m_Functions.end(); ++iter)+ lua_State* luaVM = luaMain->GetVM();+ for (const SString& strFuncName : m_Functions) {- // points function to nill+ // Remove function global variable
// Set function global variable to nil
comment created time in 6 days
Pull request review commentmultitheftauto/mtasa-blue
Refactor Lua manager to use std::vector for m_VirtualMachines
class CLuaManager void OnLuaMainOpenVM(CLuaMain* pLuaMain, lua_State* luaVM); void OnLuaMainCloseVM(CLuaMain* pLuaMain, lua_State* luaVM); - std::list<CLuaMain*>::const_iterator IterBegin() { return m_virtualMachines.begin(); };- std::list<CLuaMain*>::const_iterator IterEnd() { return m_virtualMachines.end(); };+ auto GetLuaMains() const { return m_VirtualMachines; }
Why did you pick a return auto here? Seems like an unusual place to use it, especially since m_VirtualMachines doesn't have a particularly difficult type to write. I'm happy to keep auto if you think we should keep it, though.
comment created time in 6 days
Pull request review commentmultitheftauto/mtasa-blue
Refactor Lua manager to use std::vector for m_VirtualMachines
bool CLuaManager::RemoveVirtualMachine(CLuaMain* pLuaMain) // Delete it unless it is already if (!pLuaMain->BeingDeleted())- { delete pLuaMain;- } // Remove it from our list- m_virtualMachines.remove(pLuaMain);+ const auto iter = std::find(m_VirtualMachines.begin(), m_VirtualMachines.end(), pLuaMain);+ assert(iter != m_VirtualMachines.end()); // Make sure it exists
Format selection, as mentioned above
comment created time in 6 days
Pull request review commentmultitheftauto/mtasa-blue
Refactor Lua manager to use std::vector for m_VirtualMachines
bool CLuaManager::RemoveVirtualMachine(CLuaMain* pLuaMain) m_pRegisteredCommands->CleanUpForVM(pLuaMain); // Remove it from our list- m_virtualMachines.remove(pLuaMain);+ const auto iter = std::find(m_VirtualMachines.begin(), m_VirtualMachines.end(), pLuaMain);+ assert(iter != m_VirtualMachines.end()); // Make sure it exists
Our auto-formatting does unusual things to inline comments, and this comment position is too sane, so I think the code is formatted incorrectly. Try formatting selection.
comment created time in 6 days
pull request commentmultitheftauto/mtasa-blue
oh. Seems, MTA use vehicle extrapolation only for cameraTarget player
You said the above on Discord today.
From my tests, I can confirm that if the old server (i.e. a server without this pull request) is not aware of you focusing a vehicle, the vehicle position goes haywire. A server with this PR lets you focus a vehicle even if its syncer isn't a driver (and is just a passenger), and the vehicle syncs correctly.
comment created time in 6 days
pull request commentmultitheftauto/mtasa-blue
@saml1er and I have found some bugs.
Reproduce using this resource: setCameraTarget.zip
Bug reproduction steps:
- Spawn a vehicle (/cv nrg-500)
- Click "Create and focus client ped"
- Move camera around, works fine!
- Click enter to get in a vehicle.
- Camera freezes (!)
, is no longer focused to the ped, andgetCameraTarget` claims to be focused on the vehicle (but it's focused on nothing, it's frozen) - Get out of the vehicle
- Camera is still frozen from earlier, but
getCameraTargetstill thinks you're focused on the vehicle
Another bug, using same resource
- Get in a vehicle
- Get out of the vehicle
- Click "Focus last vehicle"
- Get in a second vehicle
- Player is now focused to the second vehicle even though they should be focused to the first vehicle
- Get out of the second vehicle
- Player remains focused to the second vehicle. They should not be focused to the second vehicle.
Another bug, using the same resource
- Get in a vehicle
- Get out
- Click "Focus last vehicle"
- Set your position very far away (run
me.position = Vector3(0, 0, 0)) - Keep clicking "Focus last vehicle": the weapon indicator/fist keeps flickering, and there are graphical glitches appear resembling things on screen streaming out / showing lods temporarily. I think this is caused by your addition of
SetFocusToLocalPlayer, because this doesn't happen to players.
Another bug
- Focus another player
- Have that player get in a car
- Server says you're focused on the player, client thinks you're focused on the car
- Blip faces North
Some minor bugs related to the HUD radar, which you can look at in the future:
- Same as above, blip faces North when you deliberately focus a vehicle. It doesn't face north when you are focusing yourself (as passenger or driver).
- If your player is far away, and you are focused on a vehicle, the radar will zoom out slowly because your player is falling. Have not checked if this behaviour is new, I haven't checked if this used to happen or checked if it currently happens when focused on another player.
comment created time in 6 days
issue commentmultitheftauto/mtasa-resources
It's fairly common to bind au 1010 to mouse2 down and ru 1010 to mouse2 up, so that you can get nitro in cars. When punching other players this can inadvertently trigger spam protection. Perhaps spam protection be moved to its own resource or admin or admin2 instead of in freeroam.
comment created time in 6 days
Pull request review commentmultitheftauto/mtasa-blue
Add social buttons to main menu
bool CMainMenu::OnQuitButtonClick(CGUIElement* pElement) return true; } +bool CMainMenu::OnSocialButtonHover(CGUIElement* pElement)+{+ pElement->SetAlpha(0.8f);++ return true;+}++bool CMainMenu::OnSocialButtonUnhover(CGUIElement* pElement)+{+ pElement->SetAlpha(0.35f);++ return true;+}++bool CMainMenu::OnWebsiteButtonClick(CGUIElement* pElement)+{+ // Visit the website url+ ShellExecuteNonBlocking("open", "https://multitheftauto.com/");++ return true;+}++bool CMainMenu::OnDiscordButtonClick(CGUIElement* pElement)+{+ // Visit the discord url+ ShellExecuteNonBlocking("open", "https://multitheftauto.com/discord");++ return true;+}++bool CMainMenu::OnTwitterButtonClick(CGUIElement* pElement)+{+ // Visit the twitter url+ ShellExecuteNonBlocking("open", "https://twitter.com/MTAQA");++ return true;+}++bool CMainMenu::OnFacebookButtonClick(CGUIElement* pElement)+{+ // Visit the facebook url+ ShellExecuteNonBlocking("open", "https://www.facebook.com/multitheftauto");++ return true;+}++bool CMainMenu::OnYoutubeButtonClick(CGUIElement* pElement)+{+ // Visit the youtube url+ ShellExecuteNonBlocking("open", "https://www.youtube.com/user/MTAQA");++ return true;+}++bool CMainMenu::OnGithubButtonClick(CGUIElement* pElement)+{+ // Visit the github url+ ShellExecuteNonBlocking("open", "https://github.com/multitheftauto/mtasa-blue");++ return true;+}
There is probably a nicer solution than having many functions. E.g. setting some data on the element that maps to some index, and then you can grab the link out of socialButtonDatas.
comment created time in 6 days
pull request commentmultitheftauto/mtasa-blue
Add social buttons to main menu
I wonder if it's possible to use a single imageset file instead of multiple
comment created time in 6 days
push eventmultitheftauto/mtasa-blue
commit sha 31812ff93d1dc787dad8c31d66707741691c321b
Make sure BitStream comparisons still work correctly (#1752)
push time in 6 days
PR merged multitheftauto/mtasa-blue
This fixes the following issue:
Currently we have this
enum class eBitStreamVersion : unsigned short
{
Unk = 0x06F,
Latest
};
our bitstream version (Latest) is 0x070
If we add a feature, like so:
enum class eBitStreamVersion : unsigned short
{
Unk = 0x06F,
NewThing,
Latest
};
Latest becomes 0x071. But bitstream checks will compare against NewThing (0x070) which matches old client/servers whose latest is also 0x070
pr closed time in 6 days
PR opened multitheftauto/mtasa-blue
This fixes the following issue:
Currently we have this
enum class eBitStreamVersion : unsigned short
{
Unk = 0x06F,
Latest
};
our bitstream version (Latest) is 0x070
If we add a feature, like so:
enum class eBitStreamVersion : unsigned short
{
Unk = 0x06F,
NewThing,
Latest
};
Latest becomes 0x071. But bitstream checks will compare against NewThing (0x070) which matches old client/servers whose latest is also 0x070
pr created time in 6 days
issue commentmultitheftauto/mtasa-blue
injectBrowserKeyDown injectBrowserKeyUp for Youtube TV
I don't think they are specifically flagging MTA traffic. Their YouTube TV service is not intended to be used this way, and I strongly suspect that contacting them could cause problems.
comment created time in 7 days
push eventTheNormalnij/mtasa-blue
commit sha 5961a62695034ac4ca2e63bdc4bff412d988079c
Standardise os.sha256_file to be lowercase across platforms
commit sha f3b9f7ef4767f925efb2170731affea9d24daa41
Add upgrade param to install_cef currently: - prints new hash and version - unpacks new version
commit sha cb5af3e4dac3d9e73677f65bfd67d2c5bc3735ad
Prompt for updating install_cef.lua
commit sha 9b5dd05df2c75a5d44080270976a27e7644cefa8
Check CEF for consistency after downloading Revert to old method of computing hash (CertUtil) because escaping batch scripts is broken
commit sha e28548286ff1adcd2410df5a41f60e333c1266aa
Merge branch 'master' into feature/cef-upgrade-script
commit sha 3c9649a344e38dd42bbc85cce480aa28fb613ceb
Fix resetting dummies in vehicles with replaced models (#1059) * Fix for dummies being reset after model is unloaded * Update Client/game_sa/CModelInfoSA.cpp Co-Authored-By: Qais Patankar <[email protected]> Co-authored-by: Qais Patankar <[email protected]>
commit sha f99bd3e60fc6d9c3144f98b8e1981d26c11ee044
Remind devs to run win-install-data.bat when core fails to load (#1341)
commit sha ed80d575d213b7b80839b9c1d02527a05661fd51
Merge pull request #1332 from qaisjp/feature/cef-upgrade-script Add cef upgrade script
commit sha f28e00864eacec24457fbc269eb4790afe02a455
Fix a typo in dxSetTexturePixels (#1344)
commit sha a4f447ae8047b6d2d65077f093adff69b16b3246
Fix #1336: Discord Rich Presence not respecting CVars load (#1345)
commit sha 586b869339a171e42e3ebff919ac23d69b7fd035
New style Lua argument parsing (#973) The current argstream argument parsing is rather verbose and repetitive. However all of the information used can be inferred at compile time by the compiler. See https://github.com/multitheftauto/mtasa-blue/pull/973 for details
commit sha 3b95ff48969474c691a8a4f2276f581377111f06
Update colshape and marker hit detection when attaching (#1327) * Update colshape hit detection when attaching * Fix small spacing issue * Include check for markers * Refactor code * Remove unnecessary newline * Implement suggested changes * Fix destructor crash Co-authored-by: Qais Patankar <[email protected]>
commit sha 3d92acdd0027bdb3a0aa378d8d0e6e4144b0f402
Fix #1349 crash introduced in PR #1345 (#1350) * Fix a bug with discord rich presence not respecting CVars load * Fix crash at https://github.com/multitheftauto/mtasa-blue/issues/1349 * Fix coding style
commit sha a03f2a992a324b9341d0a787b64a6119038a5c36
Fix typo in c2dc463 Co-authored-by: Qais Patankar <[email protected]>
commit sha 31e90bb34fd2e4f0a32991029db67beac7cd369c
Fix index off by one in error messages in argument parser (586b869339a171e42e3ebff919ac23d69b7fd035) Explicitly note destroyed elements in error messages Improve documentation for PopUnsafe
commit sha 35ce166edf5dd6a9273512a201b6b8ec3fd1e619
Add support for vectors for argument parser (586b869339a171e42e3ebff919ac23d69b7fd035) Improve error message construction
commit sha 16d249db4e10d84c91f65cbe979e0a85bb431362
Fix #1357: discord crashes from a4f447ae8047b6d2d65077f093adff69 (#1358) * Fix a bug with discord rich presence not respecting CVars load * Fix crash at https://github.com/multitheftauto/mtasa-blue/issues/1349 * Fix coding style * Fix all the bugs which caused crash after a4f447ae8047b6d2d65077f093adff69b16b3246 * Move all the initialization values to class declaration * Addendum ea42a3c1f8c68fe61c21f77d57949486c4ad1b4a
commit sha ec2b11ac1edd9e3d407aeca64b78b1cc1c940ad5
Fix #1360: bump build server from VS 16.4.6 to 16.5.3
commit sha 114c0f69e968b46fa4c7f2af084347086c2912f4
Update CEF to 80.1.15+g7b802c9+chromium-80.0.3987.163
commit sha 2d0c1273d7b665d1c8422eef8baa16da2516295e
Updated BASS libraries
push time in 7 days
PR opened multitheftauto/mtasa-blue
pr created time in 7 days
push eventqaisjp/mtasa-blue
commit sha 94cd71e91e5c4e7edc2b3af18bab0c77746068cb
Add missing CLuaNetworkDefs::LoadFunctions on client-side (#1739)
commit sha 84a30b8fc7a4586eb443e0d9d0e946d0fc95fbf4
Revert "Allow to use peds and vehicles as a camera target (#1398)" (#1741) This reverts commit a92360d157eac84e08aff4770584c5b52c1c522f.
commit sha 12cd08bcaff2ff34f38616f6d439b0b0856225f4
Support for passing macros to a shader (#1573) * Support for passing macros to a shader * Improvements on hashing & minor fixes * Solution for ordered macros
commit sha 2a0d3b9c437c12e08ec81099a54bf88c29ac72ea
Refactor CVector/2D/4D to use constexpr + noexcept everywhere (#1478) * Refactor CVector to use constexpr + noexcept everywhere possible * Refactor CVector4D to use constexpr + noexcept everywhere possible * Refactor CVector2D to use constexpr + noexcept everywhere possible * Apply comment fixing suggestions CVector * Apply comment fixing suggestions CVector4D * Apply comment fixing suggestions CVector2D * Apply suggestions from code review Co-authored-by: Qais Patankar <[email protected]>
commit sha 0dac63bc5993fed5d62b5be7d8d27839dcc43f41
Hide encode function's secret key in debughooks (#1604) * Hide encode function's secret key in debug hooks * Update CDebugHookManager.cpp
commit sha 70e77564ebbc7229b9bfb67761c98e296daaaed8
Move remote functions to CLuaNetworkDefs on server-side (#1738)
commit sha def86d01971d84522803052f68374a92bd68fad4
Remove CEGUI-integrated freetype
commit sha 2b70f96da7e4fb07effc371929e7e8f6297b8105
Add freetype as its own dependency
commit sha ad8dac748b7c31a16630817287bce36548967c32
Use enum classes for BitStream (#1737)
commit sha eb53cf746ed5f12f42a1b445ed8a915e3e64b636
Make Version private
commit sha 59e4b1f611e648347d8422097932cc08b9194d6a
Update 0x06F
commit sha 7aa7f4d4faa97a88973f8e861b3c80d1b3d7eb54
Update 0x06E
commit sha edc00135ec254b98560043eae2830443651a03ac
Update 0x06D
commit sha f3b32b2a514ab69796a6a4ea90dd23c81fe8518c
Update 0x06C
commit sha ab77e979e88507d7efb6002a2bd8a85834aace66
Update 0x06B
commit sha c2fc610e40c2aafd9f036294fcb1588e0e3e90ae
Add release indicators to eBitStreamVersion
commit sha d6b93ec1eebf8f65b120ac625147b196938aa5cf
Update 0x06A
commit sha 8b40c8d4d72673e7c49e6d431c8ce7a25e16335f
Update 0x069 Could not find anything using Ctrl-F. Confirmed that there is no open source code to update as per 9b6187b3c2eaa655624254f8d83acb35b31243e7.
commit sha 53e5386bd19e21aef048c2eb7679a366a1738914
Update 0x068
commit sha c74ec4781ab762b2bd55bcfd1a5b82f2e274c0e9
Update 0x067
push time in 7 days
push eventmultitheftauto/mtasa-blue
commit sha ad8dac748b7c31a16630817287bce36548967c32
Use enum classes for BitStream (#1737)
push time in 7 days
PR merged multitheftauto/mtasa-blue
This pull request allows for querying BitStream compatibility by doing (for example) bitStream.Can(eBitStreamVersion::FakeLagCommand) instead of getting the number and doing comparisons. You just need to add to the enum list.
I propose that all future code uses this system as much as possible, instead of doing GetVersion.
There is a second pull request ready that applies the use of this feature to every change since the release of 1.5. I'll submit that pull request if/once this one merges.
Note: this pull request also increments the BitStream version. This is harmless, right?
pr closed time in 7 days
issue commentmultitheftauto/mtasa-blue
injectBrowserKeyDown injectBrowserKeyUp for Youtube TV
Hacking this to work out of the box seems reasonable to me 👍
comment created time in 7 days
pull request commentmultitheftauto/mtasa-blue
Add engineRestreamWorld function
@TheNormalnij if this is not ready for merging (because it only works with img files), please could you convert it back into a draft pr? Just so that it doesn't show up in open pr filters
comment created time in 8 days
Pull request review commentmultitheftauto/mtasa-blue
Fix #341: Make exhaust fumes vehicle dependent
class CStaticFunctionDefinitions static bool IsVehicleWindowOpen(CClientVehicle& Vehicle, uchar ucWindow); static bool SetVehicleModelExhaustFumesPosition(unsigned short usModel, CVector& vecPosition); static bool GetVehicleModelExhaustFumesPosition(unsigned short usModel, CVector& vecPosition);- static bool SetVehicleModelDummyPosition(unsigned short usModel, eVehicleDummies eDummy, CVector& vecPosition);- static bool GetVehicleModelDummyPosition(unsigned short usModel, eVehicleDummies eDummy, CVector& vecPosition);+ static bool SetVehicleModelDummyPosition(unsigned short usModel, eVehicleDummy::e eDummy, CVector& vecPosition);+ static bool GetVehicleModelDummyPosition(unsigned short usModel, eVehicleDummy::e eDummy, CVector& vecPosition);+ static bool GetVehicleModelDummyPosition(CClientVehicle* pVehicle, unsigned short usModel, eVehicleDummy::e eDummy, CVector& vecPosition);
Can we change this so that "overload selection" only happens in CLuaDefs, and not in CStaticFunctionDefinitions?
Basically, do whatever is required to make this possible:
static bool GetVehicleModelDummyPosition(unsigned short usModel, eVehicleDummy::e eDummy, CVector& vecPosition);
static bool GetVehicleModelDummyPosition(CClientVehicle* pVehicle, eVehicleDummy::e eDummy, CVector& vecPosition);
That way, in the distant future, if we ever migrate this to the new parser, they can just do ArgumentParserWarn<OverloadA, OverloadB> instead of figuring out what's going on here.
If I'm not making sense, I can elaborate.
comment created time in 8 days
Pull request review commentmultitheftauto/mtasa-blue
Fix #341: Make exhaust fumes vehicle dependent
class CAutomobile : public virtual CVehicle virtual void SetRandomDamage(bool bUnknown) = 0; virtual void SetTaxiLight(bool bState) = 0; virtual void SetTotalDamage(bool bUnknown) = 0;- virtual void SetTowLink(CVehicle* pVehicle, bool bRemoveAdd) = 0;+ //virtual void SetTowLink(CVehicle* pVehicle, bool bRemoveAdd) = 0;
I am confused as to why this is commented out, and someone in the future will look at this and feel the same way. Either remove the line or add a code comment explaining why it's commented.
comment created time in 8 days
Pull request review commentmultitheftauto/mtasa-blue
Fix #341: Make exhaust fumes vehicle dependent
enum eVehicleComponent VEHICLE_COMPONENT_MAX, }; -enum eVehicleDummies+namespace eVehicleDummy {- LIGHT_FRONT_MAIN = 0,- LIGHT_REAR_MAIN,- LIGHT_FRONT_SECONDARY,- LIGHT_REAR_SECONDARY,- SEAT_FRONT,- SEAT_REAR,- EXHAUST,- ENGINE,- GAS_CAP,- TRAILER_ATTACH,- HAND_REST,- EXHAUST_SECONDARY,- WING_AIRTRAIL,- VEH_GUN,+ enum e+ {+ LIGHT_FRONT_MAIN = 0,+ LIGHT_REAR_MAIN,+ LIGHT_FRONT_SECONDARY,+ LIGHT_REAR_SECONDARY,+ SEAT_FRONT,+ SEAT_REAR,+ EXHAUST,+ ENGINE,+ GAS_CAP,+ TRAILER_ATTACH,+ HAND_REST,+ EXHAUST_SECONDARY,+ WING_AIRTRAIL,+ VEH_GUN,+ VEH_UNKNOWNDUMMY,+ TOTAL_INTERNAL = 15,++ // custom dummies for MTA, not part of GTA+ EXHAUST_LEFT = 15,+ EXHAUST_RIGHT = 16,+ TOTAL = 17
TOTAL_INTERNAL,
// custom dummies for MTA, not part of GTA
EXHAUST_LEFT = TOTAL_INTERNAL,
EXHAUST_RIGHT,
TOTAL,
Does this work?
comment created time in 8 days
push eventmultitheftauto/amx
commit sha d79ee8194d4de473ce34e32242aed4ce1d340a02
Update intro
push time in 10 days
push eventmultitheftauto/amx
commit sha 7730320099c7e338d87a84a55a84dc109a8620ae
Update intro
push time in 10 days
pull request commentcompsoc-edinburgh/eusa-members-api
Add a dashboard to turn this into a real service
Looks fancy, cool, nice work
comment created time in 10 days
Pull request review commentmultitheftauto/mtasa-blue
Fix isPlayerHudComponentVisible incompatible with command `showhud`
bool CStaticFunctionDefinitions::ShowPlayerHudComponent(eHudComponent component, return true; } -bool CStaticFunctionDefinitions::IsPlayerHudComponentVisible(eHudComponent component, bool& bOutIsVisible)+bool CStaticFunctionDefinitions::IsPlayerHudComponentVisible(eHudComponent component, bool bOutIsEnabled, bool& bOutIsVisible)
This, and elsewhere, should be bCheckEnabled.
comment created time in 3 months
Pull request review commentmultitheftauto/mtasa-blue
Fix isPlayerHudComponentVisible incompatible with command `showhud`
void CHudSA::SetComponentVisible(eHudComponent component, bool bVisible) // // CHudSA::IsComponentVisible //-bool CHudSA::IsComponentVisible(eHudComponent component)+bool CHudSA::IsComponentVisible(eHudComponent component, bool bOutIsEnabled) { SHudComponent* pComponent = MapFind(m_HudComponentMap, component); if (pComponent) {+ if (bOutIsEnabled)+ {+ if (g_pCore->GetGame()->GetHud()->IsDisabled())+ return false;+ }
Why not use if (bIsEnabled && ...->IsDisabled())?
comment created time in 3 months
Pull request review commentmultitheftauto/mtasa-blue
Add roll state to getPedMoveState while crouching or crawling
eMovementState CClientPed::GetMovementState() if (cs.LeftStickX == 0 && cs.LeftStickY == 0) return MOVEMENTSTATE_CROUCH; else+ {+ // Is he aiming and rolling while crouching?+ if ((cs.LeftStickX == -128 || cs.LeftStickX == 128) && cs.RightShoulder1)+ return MOVEMENTSTATE_ROLL;
Btw, how did you figure out this if-check?
comment created time in 10 days
pull request commentmultitheftauto/mtasa-blue
Add isPedReloadingWeapon function on server-side
Converting to draft (until compat checks are added)
comment created time in 10 days
pull request commentmultitheftauto/mtasa-blue
Revert "Allow to use peds and vehicles as a camera target (#1398)"
@TheNormalnij please can you create a PR that reverts 84a30b8 and fixes net compatibility issues? When the server doesn't have your commit, but the client does have your commit, there are desync problems.
Comments of 64f200fe8fd304aa3f01 say:
This appears to possibly be causing some issues with spectating. Not 100% confirmed yet, but using the build which includes this vs the previous build, we are now getting issues with sync.
- Woovie
comment created time in 11 days
push eventmultitheftauto/mtasa-blue
commit sha 84a30b8fc7a4586eb443e0d9d0e946d0fc95fbf4
Revert "Allow to use peds and vehicles as a camera target (#1398)" (#1741) This reverts commit a92360d157eac84e08aff4770584c5b52c1c522f.
push time in 11 days