profile
viewpoint
Simon Brüchner powtac http:///bruechner.de Germany https://twitter.com/powtac

powtac/Autarc_LAN_User_Stats 6

Autarc LAN/Wifi and Network Device Statistics, by an Arduino UNO with Ethernet Shield (Wiznet w5500).

powtac/Clipboard 2

Simple iOS App to show the users Clipboard/Pasteboard

powtac/Dokuwiki-Mellel-Export-Plugin 2

Dokuwiki Mellel Export Plugin - Exports a docuwiki page into a OSX RedleX Mellel File. Just add "~~MELLEL~~" to a wiki page and the download icon appears in the top right of the page.

nathanzacary/Ethernet-Arduino 1

Kommunikation zwischen zwei Arduinos für ROV

powtac/Clipboard2QRCode 1

This Xcode 4 project is put together as a template to create 2D QR codes within your iPhone code.

powtac/aJson 0

aJson is an Arduino library to enable JSON processing with Arduino. It easily enables you to decode, create, manipulate and encode JSON directly from and to data structures.

powtac/Arduino 0

open-source electronics prototyping platform

powtac/arduino-cmake 0

Arduino CMake Build system

issue commentrectorphp/rector

MultipleClassFileToPsr4ClassesRector deletes none class files

Maybe this is the issue: something like and not in global namespace is missing!

https://github.com/rectorphp/rector/blob/f2ecdeb0b1f13093de23a6bb668998c9cdea73e5/rules/psr4/src/Rector/MultipleClassFileToPsr4ClassesRector.php#L178

powtac

comment created time in 3 days

issue commentrectorphp/rector

How is the execution of a rule invoked inside the tests?

I see. It could be the case. I'd like to help you more, but actually, I haven't use this rule for a while, so I have no idea how it works inside.

I will try to do a test with a single file first, that proves the lost code.

powtac

comment created time in 4 days

issue commentrectorphp/rector

How is the execution of a rule invoked inside the tests?

Hm, you also can see here that content is about to be deleted: https://getrector.org/demo/d8044ada-5466-450f-88d5-22138384a324#result Not sure though if it really is related to multiple files on directories.

powtac

comment created time in 5 days

issue commentrectorphp/rector

How is the execution of a rule invoked inside the tests?

I suspect that the rule uses some sort of "collector" to match found file names to found class names. Then the "retification" starts and what was not found will be deleted...

powtac

comment created time in 5 days

issue commentrectorphp/rector

How is the execution of a rule invoked inside the tests?

I try to setup a test case for https://github.com/rectorphp/rector/issues/4190#issuecomment-691249841. Where a folder with muliple files are processed. As mentioned in #4190, the rule seems to delete files ...

powtac

comment created time in 5 days

IssuesEvent

issue commentrectorphp/rector

How is the execution of a rule invoked inside the tests?

Is there a way to run tests on multiple files eg folders ?

powtac

comment created time in 5 days

issue closedrectorphp/rector

How is the execution of a rule invoked inside the tests?

For example: in rules/psr4/tests/Rector/MultipleClassFileToPsr4ClassesRector/MultipleClassFileToPsr4ClassesRectorTest.php, the method test(), as far as I can see, simply prepares test files in line 23 and then just after that does the assertions starting in line 26. But I don't see where the Rule is applied here!?

I did some research up to AbstractKernelTestCase but still I have no clear idea how/where the corresponding Rule from getRectorClass is invoked or executed. Especially in the context of "just" a simple call of doTestFileInfo() in the unit test.

closed time in 5 days

powtac

issue openedrectorphp/rector

How is the execution of a rule invoked inside the tests?

For example: in rules/psr4/tests/Rector/MultipleClassFileToPsr4ClassesRector/MultipleClassFileToPsr4ClassesRectorTest.php, the method test(), as far as I can see, simply prepares test files in line 23 and then just after that does the assertions starting in line 26. But I don't see where the Rule is applied here!?

I did some research up to AbstractKernelTestCase but still I have no clear idea how/where the corresponding Rule from getRectorClass is invoked or executed. Especially in the context of "just" a simple call of doTestFileInfo() in the unit test.

created time in 5 days

startedgnea/grbl

started time in 6 days

issue openedrectorphp/rector

Empty doc block leads to dublication of preceding comments

Bug Report

See https://getrector.org/demo/d8a61030-ec46-4814-ace1-89b71f9b81a5

Code with empty doc block like

/**
 */
class a {}

will have all preceding comments of this doc block be dublicated.

<?php

// First Comment

// Second Comment

/**
 */
class a {}

becomes

<?php

// First Comment
// First Comment
// Second Comment
// Second Comment

/**
 */
class a {}

The rule itself does not matter (tested with SetList::CODE_QUALITY), as soon there is some change in the file, this will happen. Tested with Rector 0.8.x-dev@172653b (prefixed)

Background

This is a very common comment pattern in old PHP source files, see this example: https://getrector.org/demo/b25ea5bc-de7d-43b0-81bc-89fe5f391972#result (similar to my very initial problem.)

Expected Behaviour

PHP source code comments should not be dublicated.

created time in 10 days

issue openedrectorphp/rector

MultipleClassFileToPsr4ClassesRector deletes none class files

Bug Report

"Simple" PHP files that not contain a class/interface/trait/... will be deleted by the MultipleClassFileToPsr4ClassesRector rule.

https://getrector.org/demo/a362d9f8-828d-428b-945a-f6e21df33908#result

Expected Behaviour

"Simple" PHP files should be not touched by this rule.

created time in 10 days

issue commentrectorphp/rector

Debug output with annoying whitespace gap

Ah, I've just understood the comment in https://github.com/rectorphp/rector/blob/7ac228c638949a69289473b7f36670aad80beef0/src/Rector/AbstractRector.php#L365 the other way...

powtac

comment created time in 10 days

push eventpowtac/rector

Simon Brüchner

commit sha 6fab176184fefe6829dd84994a721aec4b5248d5

Align console debug output properly

view details

Simon Brüchner

commit sha 1d88e539cf5cf7722d74653f490716185159f49c

Merge pull request #1 from powtac/powtac-patch-1 Align console debug output properly

view details

push time in 10 days

PR merged powtac/rector

Align console debug output properly
+1 -1

0 comment

1 changed file

powtac

pr closed time in 10 days

PR opened powtac/rector

Align console debug output properly
+1 -1

0 comment

1 changed file

pr created time in 10 days

create barnchpowtac/rector

branch : powtac-patch-1

created branch time in 10 days

issue openedrectorphp/rector

Debug output with annoying whitespace gap

Bug Report

Console output via -vvv does not properly align [refactoring] and [applying].

[refactoring] /thirdparty/Zend/Locale/Math/PhpMath.php
    [applying] Rector\Php70\Rector\FunctionLike\Php4ConstructorRector
[refactoring] /thirdparty/Zend/Log.php
    [applying] Rector\Php70\Rector\FunctionLike\Php4ConstructorRector
[refactoring] /thirdparty/Zend/Log/Exception.php
[refactoring] /thirdparty/Zend/Log/Filter/Interface.php
    [applying] Rector\Php70\Rector\FunctionLike\Php4ConstructorRector
[refactoring] /thirdparty/Zend/Log/Filter/Message.php
Subject Details
Rector version Rector 0.8.x-dev@172653b
Installed as prefixed Rector PHAR

Expected Behaviour

Align console debug output somehow properly.

created time in 10 days

fork powtac/rector

Instant Upgrades and Instant Refactoring of any PHP 5.3+ code

https://getrector.org

fork in 10 days

issue commentrectorphp/rector

Class model does not exist

@staabm to debug such use cases it is useful to use -vvv on the command line. It will at least tell you at which file the parser stoped to work.

staabm

comment created time in 11 days

issue commentrectorphp/rector

`function_exists()` seems not to work in getrector.org/demo

I tested some of the demos while seeing this 500. Back then the demo itself seemed to work. Maybe results were cached when I hit em multiple times ...

powtac

comment created time in 12 days

issue openedrectorphp/rector

`function_exists()` seems not to work in getrector.org/demo

Bug Report

Plain source code with function_exists() seems not to work in getrector.org/demo.

Subject Details
Rector version e.g. v0.7.0 (invoke vendor/bin/rector --version)
Installed as composer dependency / prefixed Rector PHAR

Minimal PHP Code Causing Issue

<?php
function d() {}

if (!function_exists('d')) {
	function d() {}
}

d();

See (not working) getrector.org/demo here:

https://getrector.org/demo/acf76090-c0ab-4e95-83f1-0c7ed7897568#result

Expected Behaviour

Some output

Actual Behaviour

500 Internal Server Error

created time in 12 days

startedaoshiro10/fifa-squad-builder

started time in 3 months

issue commentRoave/BetterReflection

Adapter\ReflectionClass::$name is empty

$name somehow protected?

ondrejmirtes

comment created time in 3 months

fork powtac/OctoPrint

OctoPrint is the snappy web interface for your 3D printer!

https://octoprint.org

fork in 3 months

startedOctoPrint/OctoPrint

started time in 3 months

startedjneilliii/OctoPrint-WebcamIframe

started time in 3 months

more