Maybe this is the issue: something like and not in global namespace is missing!

https://github.com/rectorphp/rector/blob/f2ecdeb0b1f13093de23a6bb668998c9cdea73e5/rules/psr4/src/Rector/MultipleClassFileToPsr4ClassesRector.php#L178

I see. It could be the case. I'd like to help you more, but actually, I haven't use this rule for a while, so I have no idea how it works inside.

I will try to do a test with a single file first, that proves the lost code.

Hm, you also can see here that content is about to be deleted: https://getrector.org/demo/d8044ada-5466-450f-88d5-22138384a324#result Not sure though if it really is related to multiple files on directories.

I suspect that the rule uses some sort of "collector" to match found file names to found class names. Then the "retification" starts and what was not found will be deleted...

I try to setup a test case for https://github.com/rectorphp/rector/issues/4190#issuecomment-691249841. Where a folder with muliple files are processed. As mentioned in #4190, the rule seems to delete files ...

Is there a way to run tests on multiple files eg folders ?

For example: in rules/psr4/tests/Rector/MultipleClassFileToPsr4ClassesRector/MultipleClassFileToPsr4ClassesRectorTest.php, the method test(), as far as I can see, simply prepares test files in line 23 and then just after that does the assertions starting in line 26. But I don't see where the Rule is applied here!?

I did some research up to AbstractKernelTestCase but still I have no clear idea how/where the corresponding Rule from getRectorClass is invoked or executed. Especially in the context of "just" a simple call of doTestFileInfo() in the unit test.

For example: in rules/psr4/tests/Rector/MultipleClassFileToPsr4ClassesRector/MultipleClassFileToPsr4ClassesRectorTest.php, the method test(), as far as I can see, simply prepares test files in line 23 and then just after that does the assertions starting in line 26. But I don't see where the Rule is applied here!?

I did some research up to AbstractKernelTestCase but still I have no clear idea how/where the corresponding Rule from getRectorClass is invoked or executed. Especially in the context of "just" a simple call of doTestFileInfo() in the unit test.

Bug Report

See https://getrector.org/demo/d8a61030-ec46-4814-ace1-89b71f9b81a5

Code with empty doc block like

/**
 */
class a {}

will have all preceding comments of this doc block be dublicated.

<?php

// First Comment

// Second Comment

/**
 */
class a {}

becomes

<?php

// First Comment
// First Comment
// Second Comment
// Second Comment

/**
 */
class a {}

The rule itself does not matter (tested with SetList::CODE_QUALITY), as soon there is some change in the file, this will happen. Tested with Rector 0.8.x-dev@172653b (prefixed)

Background

This is a very common comment pattern in old PHP source files, see this example: https://getrector.org/demo/b25ea5bc-de7d-43b0-81bc-89fe5f391972#result (similar to my very initial problem.)

Expected Behaviour

PHP source code comments should not be dublicated.

Bug Report

"Simple" PHP files that not contain a class/interface/trait/... will be deleted by the MultipleClassFileToPsr4ClassesRector rule.

https://getrector.org/demo/a362d9f8-828d-428b-945a-f6e21df33908#result

Expected Behaviour

"Simple" PHP files should be not touched by this rule.

Ah, I've just understood the comment in https://github.com/rectorphp/rector/blob/7ac228c638949a69289473b7f36670aad80beef0/src/Rector/AbstractRector.php#L365 the other way...

Bug Report

Console output via -vvv does not properly align [refactoring] and [applying].

[refactoring] /thirdparty/Zend/Locale/Math/PhpMath.php
    [applying] Rector\Php70\Rector\FunctionLike\Php4ConstructorRector
[refactoring] /thirdparty/Zend/Log.php
    [applying] Rector\Php70\Rector\FunctionLike\Php4ConstructorRector
[refactoring] /thirdparty/Zend/Log/Exception.php
[refactoring] /thirdparty/Zend/Log/Filter/Interface.php
    [applying] Rector\Php70\Rector\FunctionLike\Php4ConstructorRector
[refactoring] /thirdparty/Zend/Log/Filter/Message.php

Expected Behaviour

Align console debug output somehow properly.

@staabm to debug such use cases it is useful to use -vvv on the command line. It will at least tell you at which file the parser stoped to work.

I tested some of the demos while seeing this 500. Back then the demo itself seemed to work. Maybe results were cached when I hit em multiple times ...

Bug Report

Plain source code with function_exists() seems not to work in getrector.org/demo.

Minimal PHP Code Causing Issue

<?php
function d() {}

if (!function_exists('d')) {
	function d() {}
}

d();

See (not working) getrector.org/demo here:

https://getrector.org/demo/acf76090-c0ab-4e95-83f1-0c7ed7897568#result

Expected Behaviour

Some output

Actual Behaviour

500 Internal Server Error

$name somehow protected?