profile
viewpoint
Brandon Philips philips @RedHatOfficial via @CoreOS San Francisco, CA https://coreos.com Formerly: CTO @CoreOS, SUSE Linux, Rackspace Monitoring, and OSU Open Source Lab.

issue commentkubernetes/release

Add Cryptographic Digests to GitHub Releases Body

This can be closed. rget is going to execute on a design to support arbitrary URLs https://github.com/merklecounty/rget/issues/10#issuecomment-555630002

/close

justaugustus

comment created time in 2 days

issue commentmerklecounty/rget

design: run our own transparency log

Wrote a design doc on this. I think it is clear there is utility for rget but supporting arbitrary URLs is a critical feature and to do that we have to get rid of the SHA256SUMS + Let’s Encrypt cert hack.

philips

comment created time in 2 days

startedvitessio/vitess

started time in 2 days

startedgoodclass/scipy_arm64

started time in 3 days

startedholzschu/Carnets

started time in 3 days

issue commentblinksh/blink

[Feature] Support Toggling "Mirror" vs "Extended" modes for external displays

+1 to mirroring. I tried to do a demo and was so confused by the default behavior.

petermbenjamin

comment created time in 5 days

pull request commentkubernetes/security

Include distributors-announce in public security announcements

Yes, last time I looked into all of this when I set it up @googlegroups.com can't nest.

On Fri, Nov 15, 2019 at 4:08 PM Tim Allclair (St. Clair) < notifications@github.com> wrote:

I was under the impression that groups outside an apps domain couldn't be nested, but I'm no expert on the matter...

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/kubernetes/security/pull/59?email_source=notifications&email_token=AAAIGCERLNUXQRWXACZL7STQT42WLA5CNFSM4JN65PM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEHC6EY#issuecomment-554577683, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIGCHTNY7O7AXWBYPFYB3QT42WLANCNFSM4JN65PMQ .

tallclair

comment created time in 5 days

startedquay/quay

started time in 9 days

startedfogleman/axi

started time in 10 days

startedautomerge/automerge

started time in 14 days

pull request commentkubernetes/security

OWNER_ALIASES: add Luke Hinds

/lgtm

philips

comment created time in 15 days

issue commentetcd-io/maintainers

jepsen correctness audit

The audit is now underway with @mitake @gyuho involved and all etcd maintainers subscribed to updates.

philips

comment created time in 16 days

startedywangd/stash

started time in 17 days

issue commentetcd-io/maintainers

Third-party security audit

I think Mitake should be involved since he worked on some of the auth stuff originally.

On Fri, Nov 1, 2019 at 7:01 AM Sahdev Zala notifications@github.com wrote:

@caniszczyk https://github.com/caniszczyk thanks! Please consider @xiang90 https://github.com/xiang90 @gyuho https://github.com/gyuho and myself for now. Also please keep @philips https://github.com/philips in the loop. I believe we can change one or two individuals here if needed due to schedule conflict/travel etc? /cc @xiang90 https://github.com/xiang90 @gyuho https://github.com/gyuho @philips https://github.com/philips - hope this is fine per earlier discussion. Should we ask Mitake as well? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/etcd-io/maintainers/issues/18?email_source=notifications&email_token=AAAIGCCSMA4XNT4TLYEQUA3QRQZC7A5CNFSM4IYOJE22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC276YY#issuecomment-548798307, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIGCBAHUNIIO3FDCWB4GTQRQZC7ANCNFSM4IYOJE2Q .

philips

comment created time in 20 days

push eventcoreos/flannel

Brandon Philips

commit sha 960b3243b9a7faccdfe7b3c09097105e68030ea7

MAINTAINERS: remove @philips

view details

push time in 21 days

pull request commentetcd-io/discovery.etcd.io

Move discovery server source code to discovery.etcd.io repo

Done.

On Wed, Oct 30, 2019 at 2:56 PM Victor Trac notifications@github.com wrote:

@philips https://github.com/philips I spoke with @idvoretskyi https://github.com/idvoretskyi about this over the weekend, and we both think it may be better to put the go code for discoveryserver into its own repo, leaving the infra/meta stuff in this repo.

I don't have access to do this. Can you make a new discoveryserver repo and add me and @eduartua https://github.com/eduartua as a writer? I'll work with @eduartua https://github.com/eduartua to commit this code there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/etcd-io/discovery.etcd.io/pull/15?email_source=notifications&email_token=AAAIGCHPLR6JRTGVLCALIBDQRH7J5A5CNFSM4JE6V7D2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECV4YRY#issuecomment-548129863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIGCEE3JVWZZQNHYABSN3QRH7J5ANCNFSM4JE6V7DQ .

eduartua

comment created time in 22 days

created repositoryetcd-io/discoveryserver

created time in 22 days

startedbelak/go-gitdir

started time in 23 days

startedEventStore/EventStore

started time in 23 days

pull request commentkubernetes/community

sigs.yaml: Add Luke Hinds to security committee

@cblecker rebased PTAL and approve

philips

comment created time in a month

push eventphilips/community

Devan Carpenter

commit sha 76f7827eda330c06ac09191af7a244d3203e2ff5

Contributor Testing Guide: Add section on smooth PR review process

view details

Devan Carpenter

commit sha af108e4f6e1c819992843e4c8dde06ffb52d5e70

Contributor Testing Guide: Update punctuation and grammar

view details

Tim Pepper

commit sha 454fdf6caa10aefaca6c4b131e498a14d02fc95d

cherry-picks: bump up guidance on criteria, add table of contents We see a relatively high volume of cherry picks that aren't clearly meeting the criteria for cherry-picking, but that criteria has only recently started to be in written, shared form and it is not super discoverable. To make it more clear let's make that its own section (linkable), move it earlier in the document, and add a table of contents to the cherry-picks.md for navigation. Signed-off-by: Tim Pepper <tpepper@vmware.com>

view details

Nikhita Raghunath

commit sha 9cabf2b15a45eb1b5461af58b658aee8f79d11a3

Add public steering-committee slack channel

view details

Omar Mehilba

commit sha b525a1230aef0d633db66542da57f8978b03aa8d

Add meetup-egypt channel

view details

Kubernetes Prow Robot

commit sha c80c4128c64f6e62d5829340bd49dd74721f44ef

Merge pull request #4189 from mehilba/master Add meetup-egypt channel

view details

Walter Fender

commit sha 72406fa286e5bee0533344b9d37616e601c4975f

Adding slack channels and owners for the cloud provider SIG. Fixed restrictions for sig-cloud-provider channels. Remove old ref to channel and set id on new one.

view details

Kubernetes Prow Robot

commit sha e0c2c155d9eb1cb462d458706f1adeb0fdc14bfa

Merge pull request #4186 from tpepper/prt-cherry-pick-review cherry-picks: bump up guidance on criteria, add table of contents

view details

Kubernetes Prow Robot

commit sha 9c204cc22321217f88f88a01d10ecd8f171c2d13

Merge pull request #4187 from nikhita/steering-slack Add public steering-committee slack channel

view details

Nikhita Raghunath

commit sha 761d8209bb97f1514aa9336a002f9a3725bafb51

sigs.yaml: add steering-committee slack channel

view details

Kubernetes Prow Robot

commit sha 529626ec3b3f23bb7ea3f219a73dff548d0db63c

Merge pull request #4191 from nikhita/steering-slack-sigs-yaml sigs.yaml: add steering-committee slack channel

view details

Kubernetes Prow Robot

commit sha 118268546888ec281526bb12e8fa8816c3dc0483

Merge pull request #4170 from ii/testing-guide-pr-update Contributor Testing Guide: Add section on smooth PR review process

view details

Kubernetes Prow Robot

commit sha 9e3689677b59cfcdebd83a9955ba90dda591c9b1

Merge pull request #4178 from cheftako/network-proxy Adding slack channels and owners for the cloud provider SIG.

view details

Christoph Blecker

commit sha 355c906a68b8f719d6ab8834b8579e5ff0f73962

Update Code of Conduct Committee membership

view details

Walter Fender

commit sha 3453e7240b9557df07c717ae2ed45acffcdf5158

Moving all provider slack channels under sig-cloud-provider. Follow up from discussion on pull 4178. alpha sort.

view details

Kubernetes Prow Robot

commit sha b8c516c8500b9f3aca997342c63ba1b0c5affbca

Merge pull request #4195 from cblecker/coc Update Code of Conduct Committee membership

view details

Kubernetes Prow Robot

commit sha d17825d918f725063ec48d53a1b4a57abf3e8d5c

Merge pull request #4193 from cheftako/network-proxy Moving all provider slack channels under sig-cloud-provider.

view details

Brandon Philips

commit sha aab90dc1b3c9f0b2c4a69505a3335e9d756fd9b0

sigs.yaml: Add Luke Hinds to security committee Add via https://github.com/kubernetes/security/pull/51

view details

push time in a month

issue commentetcd-io/discovery.etcd.io

Implement Cloud Build for CI/CD

Cloudbuild is probably fine. Quay was working fine too.

On Tue, Oct 22, 2019 at 8:18 AM Eduar Tua notifications@github.com wrote:

@philips https://github.com/philips I'm going to explore the repository and see how we can isolate the discovery server go code. Do you think this is a good approach to implement the cloudbuild pipeline?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/etcd-io/discovery.etcd.io/issues/12?email_source=notifications&email_token=AAAIGCFMSOGUG5TIGD5UIE3QP4KSNA5CNFSM4IUEU2KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB6D6VQ#issuecomment-545013590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIGCBIDNLRBEQFL4UCM43QP4KSNANCNFSM4IUEU2KA .

victortrac

comment created time in a month

issue commentkubernetes/org

REQUEST: New membership for lukehinds

+1 /lgtm

lukehinds

comment created time in a month

pull request commentetcd-io/discovery.etcd.io

Backport VPC and GKE to terraform

Yes, sounds good.

On Mon, Oct 21, 2019 at 3:58 PM Victor Trac notifications@github.com wrote:

@philips https://github.com/philips You're right about these two issues.

  1. There's a 10 min TTL on the A record for discovery.etcd.io at the moment. We can reduce to to 60s prior to the migration to reduce the likelihood of this happening, but it's not going to completely eliminate the issue. Also, my intuition says that cluster members will be using the same DNS server (since they'll likely be in the same datacenter), so it seems exceedingly unlikely that a member will resolve an IP address prior to TTL expiration (with the old IP) and then another member will grab the new IP after expiration.
  2. I can see this happening for a very slow to bootstrap cluster. If a member starts and resolves the old discovery service and then subsequent members don't bootstrap until after the TTL refreshes to the new discovery service, then this will happen. Again, this seems exceedingly unlikely if end-users are using automated processes to bootstrap the cluster, since the cluster members will likely come up fairly simultaneously.

The traffic is fairly low, and we'll do the DNS swap during low-traffic periods. We'll also notify the dev mailing list. There are (time) expensive technical ways to possibly mitigate these concerns further, but they don't seem worth it to me. Does this address your concerns?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/etcd-io/discovery.etcd.io/pull/14?email_source=notifications&email_token=AAAIGCDUVRYB6OC4WKR2FZ3QPYXY5A5CNFSM4JCMSWUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB4B32I#issuecomment-544742889, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIGCDTILHXBGUDRCGGV2LQPYXY5ANCNFSM4JCMSWUA .

eduartua

comment created time in a month

pull request commentkubernetes/security

OWNER_ALIASES: add Luke Hinds

xref https://github.com/kubernetes/community/pull/4188#issuecomment-544728369

philips

comment created time in a month

pull request commentkubernetes/security

OWNER_ALIASES: add Luke Hinds

@lukehinds you need to file this issue: https://github.com/kubernetes/org/issues/new?assignees=&labels=area%2Fgithub-membership&template=membership.md&title=REQUEST%3A+New+membership+for+<your-GH-handle>

See this doc: https://github.com/kubernetes/community/blob/master/community-membership.md#member

philips

comment created time in a month

PR opened kubernetes/community

sigs.yaml: Add Luke Hinds to security committee

Add via https://github.com/kubernetes/security/pull/51

<!-- Thanks for sending a pull request! Here are some tips for you:

  • If this is your first contribution, read our Getting Started guide https://github.com/kubernetes/community/blob/master/contributors/guide/README.md
  • If you are editing SIG information, please follow these instructions: https://git.k8s.io/community/generator You will need to follow these steps:
    1. Edit sigs.yaml with your change
    2. Generate docs with make generate. To build docs for one sig, run make WHAT=sig-apps generate -->
+6 -1

0 comment

4 changed files

pr created time in a month

create barnchphilips/community

branch : add-luke-hinds

created branch time in a month

pull request commentkubernetes/security

OWNER_ALIASES: add Luke Hinds

/approve

philips

comment created time in a month

PR opened kubernetes/security

OWNER_ALIASES: add Luke Hinds

Via 18e94b8c9a50502a1b4db8aefe98538a9e850d69

+1 -0

0 comment

1 changed file

pr created time in a month

push eventphilips/security

Kubernetes Prow Robot

commit sha 77e26c6794ce8f7dee08722dace13736c16c5213

Merge pull request #51 from philips/add-luke-hinds README: add Luke Hinds to Security Committee

view details

Brandon Philips

commit sha 1b076a10648895f3eb09de754bcbf85d1dbd9db8

OWNER_ALIASES: add Luke Hinds Via 18e94b8c9a50502a1b4db8aefe98538a9e850d69

view details

push time in a month

push eventphilips/community

Brandon Philips

commit sha 4aa59cb3c689dced079cc7ac54df8158a8b79615

sigs.yaml: Add Luke Hinds to security committee Add via https://github.com/kubernetes/security/pull/51

view details

push time in a month

pull request commentetcd-io/discovery.etcd.io

Backport VPC and GKE to terraform

@victortrac How are you going to migrate the data? There are two issues with migrating to a new cluster:

  1. DNS split horizon for the length of the domain TTL will cause boot strapping to fail
  2. All of the data will be lost so any cluster mid-bootstrap will fail

If doing this migration is the only option please do send an email to etcd-dev@googlegroups.com to give everyone a heads up.

I can't review the terraform code however, I don't know it well enough anymore.

eduartua

comment created time in a month

push eventmerklecounty/rget

Brandon Philips

commit sha b52ab3bc93e713353c62fccf89a245ff8d2daccd

README: update to new etcd Certificate renewal doesn't seem to be working... update to a new etcd anyways.

view details

push time in a month

startedaaronpenne/generative_art

started time in a month

pull request commentkubernetes/security

README: add Luke Hinds to Security Committee

/lgtm /approve

philips

comment created time in a month

startedfogleman/primitive

started time in a month

startedfogleman/ln

started time in a month

startednoobaa/noobaa-core

started time in a month

issue commentetcd-io/maintainers

Third-party security audit

thanks xiang. It would be great to get a few dates together that would work for people to start so the CNCF can start the contract drafts.

On Thu, Oct 17, 2019 at 10:59 AM Xiang Li notifications@github.com wrote:

assigned to Guyho and myself.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/etcd-io/maintainers/issues/18?email_source=notifications&email_token=AAAIGCEXXOJURPV3S3AWBELQPCRXPA5CNFSM4IYOJE22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQ7RBY#issuecomment-543291527, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIGCGBEQVMETEMOP4UK63QPCRXPANCNFSM4IYOJE2Q .

philips

comment created time in a month

push eventphilips/pg-go-queue

Brandon Philips

commit sha 419501b4e3683ddcf5b0716865ddbaed8cf89a3f

queue: add docs Write a simple doc package and fill out some of the methods.

view details

push time in a month

push eventphilips/etc

Brandon Philips

commit sha 29645977177844f8be5c968c6fb0fe98be6af825

bashrc: add location of new $GOPATH/bin I used to set GOPATH to home which would put stuff into $HOME/bin but that is no longer reasonable with all of the GOPATH changes. So, just add go/bin to my path.

view details

push time in a month

push eventphilips/pg-go-queue

Brandon Philips

commit sha 10c91261e19d0a3aef3c6ae6c1292cc0968d112e

queue: add tests Cover the major operations in a simple test.

view details

push time in a month

startedpublicsuffix/list

started time in a month

issue commentetcd-io/maintainers

jepsen correctness audit

Pingd @gyuho about this today.

philips

comment created time in a month

startedcretz/bine

started time in a month

startedsharkdp/hyperfine

started time in a month

startedjoeycastillo/The-Open-Book

started time in a month

issue closedkubernetes/security

docs: create on-boarding and off-boarding docs

We need on-boarding and off-boarding docs for committee members. We have some of it documented here:

https://github.com/kubernetes/security/issues/16 https://github.com/kubernetes/security/issues/11

closed time in a month

philips

issue commentkubernetes/security

docs: create on-boarding and off-boarding docs

https://github.com/kubernetes/security/pull/37 fixes this

philips

comment created time in a month

startedschemahero/schemahero

started time in a month

push eventphilips/pg-go-queue

Brandon Philips

commit sha 6648749f02022e67d67ef0d04c4eb62820fe492e

go.mod: updates

view details

push time in a month

PR opened kubernetes/security

README: add Luke Hinds to Security Committee

I want to nominate Luke Hinds to join the Product Security Committee as a full member. He has been an associate member since June 26th 2019 and in that role over the last three months he has helped on a number of tasks including:

  • Coordinating CVE-2019-11251 announcement
  • Writing Kubernetes Security Committee on-boarding guide

Our process for accepting this nomination is lazy consensus and I will close the round of consensus on Oct 18th, 2019 to leave time for any comments or question. If the nomination is accepted Luke will take on the full responsibilities of a Security Committee member and take on a weekly rotation for security@kubernetes.io on-call rotation.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchphilips/security

branch : add-luke-hinds

created branch time in a month

push eventphilips/pg-go-queue

Brandon Philips

commit sha f34838f366a96619831a282b7ccbd338d1fffa8b

queue: add Drain and Insert This completes all of the methods required for a full end to end test case in main. Everything seems to work as expected and it is easy enough to create a number of workers with the API.

view details

push time in a month

pull request commentkubernetes/website

Add documentation about kernel module autoloading security

@zacharysarah Any more information on why this was closed?

danwinship

comment created time in a month

startedPuerkitoBio/purell

started time in a month

push eventphilips/etc

Brandon Philips

commit sha ffaa48d8daa35c6b90a6c02558e0c3f26de6bb30

vimrc: greatly simply vimrc I don't remember what half of this stuff did anymore. Reduce, reduce, reduce

view details

push time in a month

push eventphilips/pg-go-queue

Brandon Philips

commit sha de75bd3f2b6803d5d32f276b5439688ad2e40984

queue: add done

view details

push time in a month

push eventphilips/pg-go-queue

Brandon Philips

commit sha 9c329af1e5c867741f818f0b9f18753f98d322d5

queue: add all of the transaction interfaces

view details

push time in a month

create barnchphilips/pg-go-queue

branch : master

created branch time in 2 months

created repositoryphilips/pg-go-queue

created time in 2 months

startedbloomberg/comdb2

started time in 2 months

pull request commentkubernetes/steering

SC1 transferred from Brandon to Dims

/lgtm /approve

(for old times sake)

dims

comment created time in 2 months

issue commentkubernetes/steering

README: find new sc1 and sc2 @kubernetes.io owners

@dims is now sc1.

@dims please put up a PR to update the README.

philips

comment created time in 2 months

issue openedkubernetes/steering

README: find new sc1 and sc2 @kubernetes.io owners

The SC1 and SC2 accounts are meant for one off maintenance of the kubernetes.io GSuite system. @jbeda and @philips currently own 1 and 2 respectively. We need to hand them off to new steering members.

created time in 2 months

issue openedkubernetes/steering

README: update with new steering members

See https://groups.google.com/forum/#!topic/kubernetes-dev/1kZvBDGhSCU

created time in 2 months

pull request commentetcd-io/etcd

*: create project governance

LGTM

spzala

comment created time in 2 months

startedchrispsn/mesh

started time in 2 months

PR closed philips/ghar

Print paths when non-ghar symlinks encountered

Added extra path information when a non-ghar symlink is found so that user can understand where the problem is.

Before this commit it read: ".bashrc: can't handle non-ghar symlinks." After this commit it reads: "Linking ~/.bashrc to ~/Projects/ghar/ghar/.bashrc: can't handle non-ghar symlinks."

+2 -1

1 comment

1 changed file

Ian2020

pr closed time in 2 months

pull request commentphilips/ghar

Print paths when non-ghar symlinks encountered

merged, thanks for the contribution and sorry for the long delay!

Ian2020

comment created time in 2 months

push eventphilips/ghar

Ian2020

commit sha 6ab4f46201d41480ee9772bb42558f4dfcf15a82

Print paths when non-ghar symlinks encountered Added extra path information when a non-ghar symlink is found so that user can understand where the problem is. Before this commit it read: ".bashrc: can't handle non-ghar symlinks." After this commit it reads: "Linking ~/.bashrc to ~/Projects/ghar/ghar/.bashrc: can't handle non-ghar symlinks."

view details

push time in 2 months

push eventphilips/etc

Brandon Philips

commit sha 8e2efd69da0baaa99554c9c164fc269b48911fe6

*: remove tools that I no longer use

view details

push time in 2 months

PR closed philips/ghar

Regex fix for README

Python 3.6.0 reports an error when running ghar. Removing the \ before the R on the regex line fixes it for me:

Traceback (most recent call last):
  File "/home/jwong/ghar/bin/ghar", line 359, in <module>
    main(args)
  File "/home/jwong/ghar/bin/ghar", line 347, in main
    _init_repos()
  File "/home/jwong/ghar/bin/ghar", line 340, in _init_repos
    repos.append(Repo(os.path.join(root, dir)))
  File "/home/jwong/ghar/bin/ghar", line 229, in __init__
    self.is_collection = self._is_collection()
  File "/home/jwong/ghar/bin/ghar", line 151, in _is_collection
    if re.match("^\.git(ignore|modules)?$", f) or re.match("^\README.*$", f) or re.match("^\.travis.yml", f):
  File "/usr/lib/python3.6/re.py", line 172, in match
    return _compile(pattern, flags).match(string)
  File "/usr/lib/python3.6/re.py", line 301, in _compile
    p = sre_compile.compile(pattern, flags)
  File "/usr/lib/python3.6/sre_compile.py", line 562, in compile
    p = sre_parse.parse(p, flags)
  File "/usr/lib/python3.6/sre_parse.py", line 856, in parse
    p = _parse_sub(source, pattern, flags & SRE_FLAG_VERBOSE, False)
  File "/usr/lib/python3.6/sre_parse.py", line 415, in _parse_sub
    itemsappend(_parse(source, state, verbose))
  File "/usr/lib/python3.6/sre_parse.py", line 501, in _parse
    code = _escape(source, this, state)
  File "/usr/lib/python3.6/sre_parse.py", line 401, in _escape
    raise source.error("bad escape %s" % escape, len(escape))
sre_constants.error: bad escape \R at position 1
+1 -1

3 comments

1 changed file

featheredtoast

pr closed time in 2 months

pull request commentphilips/ghar

Regex fix for README

fixed! Sorry for the long delay! I owe y’all a coffee sometime :-P

featheredtoast

comment created time in 2 months

push eventphilips/ghar

Jeff Wong

commit sha 8193652768f8dc8116cb22c09d005675f46efcfa

regex fix for README

view details

push time in 2 months

startedVagr9K/gatsby-material-starter

started time in 2 months

startedjackc/pgx

started time in 2 months

pull request commentetcd-io/etcd

*: create project governance

In my mind we either:

  1. Remove approvers completely.
  2. Rename maintainers to approvers.

A reviewer is generally someone who is on the ladder towards maintainership but isn't experienced/trusted enough to merge code themselves.

IMHO we should just remove approvers because the language of "maintainers" has been with the project since day 1.

On Thu, Sep 26, 2019 at 9:09 AM Sahdev Zala notifications@github.com wrote:

lgtm.

One discussion: Was there a discussion on the concept of approvers? Have we needed this additional abstraction in the past? And did Fanmin and Anthony agree to be approvers?

@philips https://github.com/philips thanks, and good points for discussion something I also thought myself too but I decided to kept the roles the same way except removing overlapping of members between roles. Now that you mentioned, I will reach out to Fanmin and Anthony for their interest. Also, though current roles provides good distinction, most projects only have two (maintainers/approvers and reviewers). I personally is totally good in keeping only two roles (maintainers and approvers/reviewers) if everyone is fine with it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/etcd-io/etcd/pull/11175?email_source=notifications&email_token=AAAIGCAD4RVHB4S2JOLOLKDQLTNB7A5CNFSM4IZRZ3CKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7WDUIA#issuecomment-535575072, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAIGCEYGE2HWGOM4SZCSVDQLTNB7ANCNFSM4IZRZ3CA .

spzala

comment created time in 2 months

pull request commentetcd-io/etcd

*: create project governance

lgtm.

One discussion: Was there a discussion on the concept of approvers? Have we needed this additional abstraction in the past? And did Fanmin and Anthony agree to be approvers?

spzala

comment created time in 2 months

issue commentetcd-io/maintainers

etcd mailing list changes

sounds good, thanks Sahdev

On Tue, Sep 24, 2019 at 3:28 PM Sahdev Zala notifications@github.com wrote:

Also, as we discussed renaming won't be easy and probably not a good idea. So I will close the issue with this setting change. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/etcd-io/maintainers/issues/14?email_source=notifications&email_token=AAAIGCAKQFMCWM4ANKA7TEDQLKIA7A5CNFSM4IG5RLWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7P74II#issuecomment-534773281, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAIGCBDAH2SHIANLN64EZLQLKIA7ANCNFSM4IG5RLWA .

spzala

comment created time in 2 months

pull request commentkubernetes/security

Update private-distributors-list.md

/lgtm /approve

swamymsft

comment created time in 2 months

pull request commentkubernetes/security

Update private-distributors-list.md

Yes, but can you squash everything down?

swamymsft

comment created time in 2 months

issue commentetcd-io/maintainers

etcd mailing list changes

@spzala you are now an owner.

spzala

comment created time in 2 months

pull request commentkubernetes/security

Update private-distributors-list.md

@swamymsft could you please add the application to the commit message as done with the canonical: https://github.com/kubernetes/security/commit/49b5e06484ebf71ff27f08f2212760e2617ab8ac#diff-49e086cea35a7ca0f86fae6ba77880c9

swamymsft

comment created time in 2 months

issue commentkubernetes/security

private-distributors-list: add Loodse

This looks fine. Approved.

@swamymsft can you format this into a PR against https://github.com/kubernetes/security/blob/master/private-distributors-list.md

scheeles

comment created time in 2 months

push eventetcd-io/website

Gyuho Lee

commit sha bb3c3d0ffe4f8afe2143a1686ccb15dc41249190

content/docs: remove v2 Signed-off-by: Gyuho Lee <leegyuho@amazon.com>

view details

Brandon Philips

commit sha 3490839a0452ce8397f5174211c5c952ab827996

Merge pull request #47 from gyuho/remove-v2 content/docs: remove v2

view details

push time in 2 months

PR merged etcd-io/website

content/docs: remove v2

Fix https://github.com/etcd-io/website/issues/44.

Other versions do not have v2 docs.

+0 -6467

1 comment

44 changed files

gyuho

pr closed time in 2 months

issue closedetcd-io/website

The docs in the website are all leading to etcd version 2, links to version 3 are broken

When I go to the documentation of etcd3 I expect to find the most updated docs, older versions should be easy to find. Currently, the default is documentation of etcd2

image

The links to updated documentation are broken:

image

closed time in 2 months

oz123

pull request commentetcd-io/website

content/docs: remove v2

Makes sense.

Is there automation that caused this to be copied that needs to be updated as well?

gyuho

comment created time in 2 months

pull request commentetcd-io/etcd

build-docker: Added support for s390x

@hexfusion could you clarify what the Jenkins infrastructure changes might be for this?

My memory is that we cross compile the other archs for the docker images. But, @nayana-ibm was thinking that s390 build machines were needed.

chakravarthy392

comment created time in 2 months

issue openedetcd-io/maintainers

Third-party security audit

  • [ ] Identify a lead for the project
  • [ ] Identify 1-3 maintainers to help guide the auditors
  • [ ] Maintainer files a CNCF Service Desk ticket to request a security audit
  • [ ] Wait
  • [ ] Work with security audit team
  • [ ] Work with CNCF to publish results

cc @spzala

created time in 2 months

issue commentIBM-Cloud/go-etcd-rules

switch to go.etcd.io/etcd

releases have been cut with this new import path.

chriskirkland

comment created time in 2 months

issue commenttbodt/ish

gpg-agent fails

Looks like inotify is missing. I don’t know the ioctl code off hand.

saptarshiguha

comment created time in 2 months

issue commenttbodt/ish

gpg-agent fails

dmesg gives me:

# dmesg
unknown ioctl 5413
unknown ioctl 5413
unknown ioctl 5413
unknown ioctl 5413
unknown ioctl 5413
22 missing syscall 332
saptarshiguha

comment created time in 2 months

issue commentkubernetes/community

Track CVEs for kubernetes dependencies...

This should be easier now that there is an API of module versions: https://index.golang.org/

brendandburns

comment created time in 2 months

issue commentkubernetes/website

Umbrella Issue: Remove Third-Party Content

Follow-up question for eventual KEP: "Why do we care whether a project is in the CNCF?". Reading the current policy there are several references to policies that differ whether a project is a CNCF project:

Adding a tutorial that explains how to perform a task using a vendor-specific product or an open source project that is not a CNCF project or a project in the kubernetes or kubnetes-sigs GitHub organizations

Content that describes a non-Kubernetes project Allowed: Adding a brief introductory paragraph about a CNCF project or a project in the kubernetes or kubernetes-sigs GitHub organizations; the paragraph may contain links to the project Not Allowed: Adding content describing an open source project that is not a CNCF project or a project in the kubernetes or kubnetes-sigs GitHub organizations

Content that simply links to information about a non-Kubernetes project Allowed: Linking to active CNCF projects Not Allowed: Adding content describing a vendor-specific product Adding content describing an open source project that is not a CNCF project or a project in the kubernetes or kubnetes-sigs GitHub organizations

This is troubling to me because a non-goal of the CNCF to is to host every piece and part required to make Kubernetes technically successful. It may happen but it shouldn't be a consideration for quality user facing docs.

aimeeu

comment created time in 2 months

push eventcoreos/license-bill-of-materials

Vimal K

commit sha 4b3863629d84c7161face39bff78e269b8b06adb

*: Modified to conform to Module aware 'go list' Go 1.13 is module aware, so the output of 'go list' results in paths pointing to module cache (GOPATH/pkg/mod). Non module aware go versions, the `Root` field in the `go list` output contains `GOPATH`. In module aware Go versions, it points to the root of module in module cache. Earlier versions, the LICENSEs could be read by concatenating the `GOPATH` and `ImportPath` fields. Now the LICENSES need to be read by using `Root` and `Dir` fields which point to the root of the module and imported folder within the module. This change fixes bill-of-materials test fails in etcd CI with Go 1.13. https://github.com/etcd-io/etcd/issues/11132

view details

Vimal K

commit sha 91c3cf9e2149bc89a6f89ae075e9ee7af92a5204

updated .travis.yml for go1.13

view details

Brandon Philips

commit sha 13baff47494e3f89fe1b67818363c3bc2fb12b8a

Merge pull request #17 from vimalk78/master *: Modified to conform to Module aware 'go list'

view details

push time in 2 months

more