profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/peetucket/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Peter Mangiafico peetucket Stanford University Palo Alto, CA http://peter.mangiafico.org Product manager and software engineer at Stanford University Libraries

sul-dlss-deprecated/revs 11

DEPRECATED: Revs Digital Library website

peetucket/ImpactProbe 4

A social network awareness monitoring and reporting system for assessing outreach activities.

sul-dlss/rialto-etl 3

ETL tools for RIALTO, Stanford Libraries' research intelligence project

dcasciotti/second_app 2

rails second app

benjaminner/python-scripts 1

Ben's python scripts

peetucket/evernote 1

A Ruby client for Evernote

peetucket/NAI-ACL-Apps 1

NASA Astrobiology Institute Advent of Complex Life Team applications

peetucket/speedtest 1

Run a speedtest and tweet results and save as a CSV file

camillevilla/release-drafter-test 0

For testing out https://probot.github.io/apps/release-drafter/

push eventsul-dlss-labs/srt

Peter Mangiafico

commit sha a127c8a55cdcb0dc9d699b787f8d6ed0a8c72320

add contact us page with google form embed

view details

push time in 6 days

push eventsul-dlss-labs/srt

Peter Mangiafico

commit sha d36ee8f24c5dca5d8dac82b93abdbafc3b4d7692

add favicon.ico; tweaks to css

view details

push time in 6 days

push eventsul-dlss/happy-heron

Peter Mangiafico

commit sha 1f90ec3a61fb34bf2632b74b553607a6c2ed5f3a

move grouped dates on work edit page into fieldsets

view details

Peter Mangiafico

commit sha a8652bea888cf2939a9e6d444beb337e1e3e3a7a

hide legends for fieldsets

view details

Peter Mangiafico

commit sha 4ca8834a0b4bbac9a156a67fa52231f241343a6a

fix spacing of html tags

view details

Peter Mangiafico

commit sha 26c38492908d3055e6cb6470a9d6d0347823cb87

Merge pull request #1839 from sul-dlss/1827-fieldset-groups move grouped dates on work edit page into fieldsets

view details

push time in 6 days

delete branch sul-dlss/happy-heron

delete branch : 1827-fieldset-groups

delete time in 6 days

PR merged sul-dlss/happy-heron

move grouped dates on work edit page into fieldsets

Why was this change made?

Fixes #1827 - move input controls that are related to the same field into a single fieldset (just wrap the existing div) and ensure they have a legend.

How was this change tested?

Localhost browser

Which documentation and/or configurations were updated?

+127 -118

1 comment

2 changed files

peetucket

pr closed time in 6 days

issue closedsul-dlss/happy-heron

Accessibility: date fields need to be grouped and labeled

When a form contains elements that are logically connected to each other it is necessary to group them.

The form contains check boxes and/or radio buttons that are not grouped and named, using a 'fieldset' with a descriptive 'legend' or the WAI-ARIA attribute role="group" (for check boxes) or role="radiogroup" (for radio buttons) with a descriptive 'aria-labelledby' or 'aria-label'.

On the deposit page, these radio button form elements need to be grouped: Creation date image

Release date image

closed time in 6 days

astridu
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentsul-dlss/happy-heron

move grouped dates on work edit page into fieldsets

                                                  min_year: min_year,                                                  max_year: max_year) %> -  <div class="mb-3 row">-    <div class="col-sm-3 h6">-      Creation date-      <%= render PopoverComponent.new key: 'work.creation_date' %>-    </div>-  </div>+<fieldset>

Done

peetucket

comment created time in 6 days

PullRequestReviewEvent

push eventsul-dlss/happy-heron

Peter Mangiafico

commit sha 4ca8834a0b4bbac9a156a67fa52231f241343a6a

fix spacing of html tags

view details

push time in 6 days

PullRequestReviewEvent

Pull request review commentsul-dlss/happy-heron

move grouped dates on work edit page into fieldsets

-<div data-controller="complex-radio available-date">-  <div class="mb-3 row">-    <div class="col-sm-10 release-option" data-complex-radio-target="selection">-      <%= form.radio_button :release, 'immediate', class: 'form-check-input',-                            data: {-                              action: 'complex-radio#disableUnselectedInputs change->auto-citation#updateDisplay available-date#clearError'-                            } %>-      <%= form.label :release_immediate, 'Immediately once deposit is completed' %>-    </div>-  </div>--  <div class="embargo-date mb-5">-    <div class="row<%= ' is-invalid' if error? %>">+<fieldset>+  <legend class="h5">Release date</legend>

indeed...I just hid both legends using a visually-hidden class and otherwise left the displays as before...so it now looks exactly the same as it did before (just verified against main branch on localhost)

peetucket

comment created time in 6 days

push eventsul-dlss/happy-heron

Peter Mangiafico

commit sha a8652bea888cf2939a9e6d444beb337e1e3e3a7a

hide legends for fieldsets

view details

push time in 6 days

GollumEvent

pull request commentsul-dlss/happy-heron

move grouped dates on work edit page into fieldsets

This diff is really odd, since all I did was wrap the existing divs in a <fieldset> and add a legend.

peetucket

comment created time in 7 days

PR opened sul-dlss/happy-heron

move grouped dates on work edit page into fieldsets

Why was this change made?

Fixes #1827 - move input controls that are related to the same field into a single fieldset (just wrap the existing div) and ensure they have a legend.

How was this change tested?

Localhost browser

Which documentation and/or configurations were updated?

+122 -120

0 comment

2 changed files

pr created time in 7 days

create barnchsul-dlss/happy-heron

branch : 1827-fieldset-groups

created branch time in 7 days

Pull request review commentsul-dlss/happy-heron

store last time terms of agreement for a work were accepted; and use that for default on new works

 def show       work = Work.find(params[:work_id])       work_version = work.head     else-      work = Work.new(collection_id: params[:collection_id])+      work = Work.new(collection_id: params[:collection_id], depositor: User.new)

the new agree_to_terms assumes there is an associated depositor, we need one for a new work

peetucket

comment created time in 7 days

PullRequestReviewEvent

push eventsul-dlss/happy-heron

Peter Mangiafico

commit sha e09299bc76c5ad29fee75efa051b099715637704

update tests to remove some unnecessary guard clauses

view details

push time in 7 days

pull request commentsul-dlss/common-accessioning

[HOLD] pass reading order to gem when generating content metadata from stub

Ok, so will unhold this PR then. Thanks

peetucket

comment created time in 7 days

push eventsul-dlss/happy-heron

Peter Mangiafico

commit sha 78520e08d2ad33d9c97327dc243f432f586318c6

adjust dashboard spec for terms agreement changes

view details

push time in 7 days

push eventsul-dlss/happy-heron

Peter Mangiafico

commit sha 94fbb7d3f1cac60e615b06ef01976f1b332e4194

test

view details

push time in 7 days

pull request commentsul-dlss/happy-heron

store last time terms of agreement for a work were accepted; and use that for default on new works

Note that the create_new_work_spec.rb and edit_draft_work_spec.rb are not as different as they are shown. Basically: (1) All of the existing tests were wrapped in a new context that assumes the terms were already previously accepted and (2) new context blocks were added for the cases where the user had never previously accepted terms and accepted them more than 1 year ago, and then some of the same tests were repeated, but checking the "terms" box this time.

peetucket

comment created time in 7 days

Pull request review commentsul-dlss/happy-heron

store last time terms of agreement for a work were accepted; and use that for default on new works

    context 'when work has everything' do     let(:work_version) do-      build_stubbed(:valid_work_version, agree_to_terms: true, attached_files: [build_stubbed(:attached_file)])+      build_stubbed(:valid_work_version, attached_files: [build_stubbed(:attached_file)])

this column no longer exists in the database for the work_version

peetucket

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentsul-dlss/happy-heron

store last time terms of agreement for a work were accepted; and use that for default on new works

 def sunetid   def to_honeybadger_context     { user_id: id, user_email: email }   end++  sig { returns(T::Boolean) }+  def agreed_to_terms_recently?+    return false unless last_work_terms_agreement++    terms_agreement_renewal_timeframe < last_work_terms_agreement+  end++  sig { returns(T::Boolean) }+  def agreed_to_terms+    update(last_work_terms_agreement: Time.zone.now)+  end end

when the user agrees to the terms, we need to update the current time in the database

peetucket

comment created time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent