pavelgnom ( Pavel Herasimau )

commit sha f47aff1f694b9ea28843bd99a89deab6eb14ffef

Run `mix format`

commit sha 9b203562b57f08edef6b7ba81f29f760ea61ec03

bump version number

branch : revert-25-prune-nil-values-in-json

push time in 10 days

delete branch neilberkman/docusign_elixir

delete branch : revert-25-prune-nil-values-in-json

delete time in 10 days

create barnchneilberkman/docusign_elixir

created branch time in 10 days

Hugo Frappier

commit sha e00eb2817253b7db00b59f2b985c666e30e36a61

Fix: remove nil values from map sent to DocuSign DocuSign does not handle null values in json objects.

push time in 10 days

PR merged neilberkman/docusign_elixir

Fix: remove nil values from map sent to DocuSign

DocuSign does not handle null values in json objects. See https://github.com/neilberkman/docusign_elixir/issues/23 for details. It requires Elixir 1.10 (I don't know if that is a problem. If it is, I can have look at adding a defguard for is_struct or we bump the elixir version in mix.exs to 1.10).

+42 -1

1 commit in frahugo/docusign_elixir/tree/prune-nil-values-in-json neilberkman/docusign_elixir/tree/master

0 comment

2 changed files

frahugo

pr closed time in 10 days

PR opened neilberkman/docusign_elixir

Fix: remove nil values from map sent to DocuSign

DocuSign does not handle null values in json objects. See https://github.com/neilberkman/docusign_elixir/issues/23 for details. It requires Elixir 1.10 (I don't know if that is a problem. If it is, I can have look at adding a defguard for is_struct or we bump the elixir version in mix.exs to 1.10).

+42 -1

1 commit in frahugo/docusign_elixir/tree/prune-nil-values-in-json neilberkman/docusign_elixir/tree/master

0 comment

2 changed files

pr created time in 10 days

issue closedneilberkman/docusign_elixir

Returning timeout

Hi there,

I'm getting {:error, :timeout} very often with DocuSign.Api.Envelopes.envelopes_post_envelopes/3, but the thing is the envelopes were sent and I got them on my e-mails. Is there a way to fix this? A setting maybe?

Thanks in advance.

closed time in 11 days

aramsm

issue commentneilberkman/docusign_elixir

Returning timeout

Fixed in https://github.com/neilberkman/docusign_elixir/commit/c23beafdafccd53f3caa783a971de82a11a77383

aramsm

comment created time in 11 days

commit sha 1a3c4ec584002a05e52f466797a9fdc88db97406

Update elixir version

commit sha a153b535ded9d2212565f71d99a488bcd0cfe1b9

Update github action

commit sha cd2e848cc1ac38dcb9b03e7eb1e4e6106391901e

Update dependencies

Null object cannot be converted to a value type

push time in 11 days

issue commentneilberkman/docusign_elixir

Yes, this would be great. Thanks!

frahugo

comment created time in 11 days

PR merged neilberkman/docusign_elixir

Provide to Tesla the JSON encoder to use

As all the models are annotated for Poison, let's use Poison. Otherwise, Tesla is trying ot use Jason and the models are not annotated for it.

+2 -2

1 commit in frahugo/docusign_elixir/tree/fix-json-encoding neilberkman/docusign_elixir/tree/master

0 comment

1 changed file

frahugo

pr closed time in 11 days

Hugo Frappier

commit sha 26a2ee29ee0255953f035cfa026c1c2386093bfc

Provide JSON encoder to use to Tesla As all the models are annotated for Poison, let's use Poison.

commit sha d93c1b9ad567190588464641130ff77323e8ac3b

Merge pull request #24 from frahugo/fix-json-encoding Provide to Tesla the JSON encoder to use

Null object cannot be converted to a value type

push time in 11 days

delete branch neilberkman/docusign_elixir

delete branch : develop

delete time in 11 days

PR opened neilberkman/docusign_elixir

Provide to Tesla the JSON encoder to use

As all the models are annotated for Poison, let's use Poison. Otherwise, Tesla is trying ot use Jason and the models are not annotated for it.

+2 -2

1 commit in frahugo/docusign_elixir/tree/fix-json-encoding neilberkman/docusign_elixir/tree/master

0 comment

1 changed file

pr created time in 11 days

issue openedneilberkman/docusign_elixir

I want to use the API to assign values to recipient tabs in an envelope. So I use something like this:

DocuSign.Api.EnvelopeRecipientTabs.recipients_put_recipient_tabs(connection, account_id, envelope_id, "1", EnvelopeRecipientTabs: newtabs)

newtabs was built using the values returned from DocuSign.Api.EnvelopeRecipientTabs.recipients_get_recipient_tabs/4. Some fields are nil.

When Poison encodes the model, nil value get serialized to null and the DocuSign API does not like it. It returns this error:

   body: "{\r\n  \"errorCode\": \"INVALID_REQUEST_BODY\",\r\n  \"message\": \"The request body is missing or improperly formatted. Null object cannot be converted to a value type.\"\r\n}",

Since this seems to be specific to DocuSign, I was thinking of adding a transformation in RequestBuilder to prune the nil values in a map. This was taken from a closed Posion issue where someone asked for a way to exclude nil values as a feature in Poison( https://github.com/devinus/poison/issues/55).

  @spec add_optional_params(map(), %{optional(atom) => atom}, keyword()) :: map()
  def add_optional_params(request, definitions, [{key, value}] = values) do
    case definitions do
      %{^key => :body} when map_size(definitions) == 1 ->
        # If there is a single entity to send in the body there is no need to
        # enclose it in a multipart request.
        add_param(request, :body, :body, Map.from_struct(value) |> prune_nils())

      _ ->
        do_add_optional_params(request, definitions, values)
    end
  end

  @spec prune_nils(map) :: map
  def prune_nils(s) when is_struct(s), do: s |> Map.from_struct() |> Enum.reduce(%{}, &reducer/2)
  def prune_nils(m) when is_map(m), do: Enum.reduce(m, %{}, &reducer/2)

  @spec reducer({any, any}, map) :: map
  defp reducer({k, v}, map) when is_map(v), do: Map.put(map, k, prune_nils(v))
  defp reducer({_k, v}, map) when is_nil(v), do: map
  defp reducer({k, v}, map), do: Map.put(map, k, v)

Are you OK with this change? I will create a pull request if you are.

created time in 11 days

issue commentneilberkman/docusign_elixir

Well, things are not better with the OpenAPI generator. I tried the "docker" way of generating code, but it runs out of memory. Tried in "dev-docker" way, and it still runs out of memory (later, but it does). Seems to be an infinite loop. Tried with different versions of the DocuSign 2.1 json specs, all with problems. Tried other version of OpenAPI generator, and still no success. I tried generating the API code for ruby and python: no success. The OpenAPI generator has +2K open issues, that is not a good sign.

DocuSign states that their specification files are "valid". So I guess the issue is with the code generators.

Strangely, if I generate the code for v2.0, it works like a charm. Go figure.

Asked DocuSign for some help: https://github.com/docusign/OpenAPI-Specifications/issues/39

neilberkman

comment created time in 24 days

issue commentneilberkman/docusign_elixir

Some API functions do work. But I ended up trying to get the document tabs from a template and found out that the generated code references the wrong module:

    |> deserialize(:dateTabs, :list, DocuSign.Model.DateTime, options)

dateTabs are not properly deserialized throughout the code. It should be using DocuSign.Model.Date. I looked at the API json, and the definition seems correct.

I cannot test the entire code base. We should be able to rely on the generated code. I wonder if the problem is with the swagger code. Maybe switching to the OpenAPI generator would solve those issues? I'll investigate.

neilberkman

comment created time in 24 days

issue commentneilberkman/docusign_elixir

Alright. After renaming that argument and restore some files that were deleted after the rm -rf lib/docusign/* step in the README, I got the tests green. Will try the API from the command line now.

neilberkman

comment created time in 25 days

issue commentneilberkman/docusign_elixir

@frahugo in my case It complied but the tests failed. I don't remember the specifics and I don't have the code at this point.

neilberkman

comment created time in 25 days

issue commentneilberkman/docusign_elixir

@neilberkman The code gets generated, but it does not compile. Is that the error you are getting?

== Compilation error in file lib/docusign/api/account_brands.ex ==
** (CompileError) lib/docusign/api/account_brands.ex:353: cannot invoke remote function :erlang.//2 inside a match
    lib/docusign/api/account_brands.ex:348: (module)

A function parameter is badly named:

  def brand_resources_put_brand_resources(
        connection,
        account_id,
        brand_id,
        resource_content_type,
        file / xml,
        _opts \\ []
      ) do
    %{}
    |> method(:put)
    |> url("/v2.1/accounts/#{account_id}/brands/#{brand_id}/resources/#{resource_content_type}")
    |> add_param(:file, :"file.xml", file / xml)
    |> Enum.into([])
    |> (&Connection.request(connection, &1)).()
    |> decode(%DocuSignRESTAPI.Model.BrandResources{})
  end

neilberkman

comment created time in 25 days

issue commentneilberkman/docusign_elixir

Thanks @frahugo really appreciate it!

neilberkman

comment created time in 25 days

issue commentneilberkman/docusign_elixir