profile
viewpoint
Paweł Krupa paulfantom Red Hat Berlin, Germany https://pawel.krupa.net.pl from SysOps to Dev

brancz/kube-rbac-proxy 213

Kubernetes RBAC authorizing HTTP proxy for a single upstream.

atosatto/ansible-minio 68

Ansible role to install the minio S3 compatible object storage server (https://minio.io)

mongrelion/ansible-role-docker 60

Ansible role for installing Docker

jffz/ansible-netdata 21

Ansible playbook to install netdata anywhere

paulfantom/ansible-restic 21

Deploy restic backup program

paulfantom/ansible-moodle 6

Install and manage moodle instance via Ansible

openshift/cluster-api-provider-kubemark 5

Cluster API implementation for Kubemark

cloudalchemy/ansible-process_exporter 4

Provision process exporter for prometheus monitoring tool

pull request commentcloudalchemy/ansible-process_exporter

fix user and group creation

Thanks :+1:

tombokombo

comment created time in 15 hours

push eventcloudalchemy/ansible-process_exporter

tombokombo

commit sha 4ff8128e5f37958ece65cab2d3818fc6728b3cd2

fix user and group creation (#29) [minor] release

view details

push time in 15 hours

PR merged cloudalchemy/ansible-process_exporter

fix user and group creation area/tasks

allow to run process as root

+4 -0

0 comment

1 changed file

tombokombo

pr closed time in 15 hours

push eventcloudalchemy/ansible-node-exporter

D'hondt Thomas

commit sha 86375bafa533bb556118d833fddca9eb6b6ff3b4

Updated readme to include passlib dependency

view details

Paweł Krupa

commit sha 80be2db0ffc556cbd57dbd65d382d97662bc6028

Merge pull request #184 from thdhondt/patch-1

view details

push time in 15 hours

issue commentsamber/awesome-prometheus-alerts

KubernetesJobCompletion will always fire while job is running

So the main thing there for the KubeJobCompletion is that it has a 12h wait time on it.

Yes, plus it has a different severity.

djhoese

comment created time in 16 hours

push eventpaulfantom/cluster-monitoring-operator

OpenShift Merge Robot

commit sha f81ad9664b37edfc55d753d3e8db22864cbc4f18

Merge pull request #945 from lilic/bump-client-go-4.5 Bug 1881043: Bump client-go & co.

view details

paulfantom

commit sha 24fb945fab6dbb626c4d29ded327efaaf222ac2a

pkg/client: invert CRB checks

view details

paulfantom

commit sha b9c2d803eaeb381b1d9562dbbff9a9436c6d886f

pkg/client: add tests for checking updates of CRBs

view details

paulfantom

commit sha 6b92bf88c1cce1a6b6d800bfc8b9ab7b154fa751

pkg/client,test/e2e: removing dead code

view details

paulfantom

commit sha b6e75cb93c4005026ba6469e556a3e29c5c74019

pkg/client: preserve labels and annotations during reconciliation; deepCopy objects before modifying them

view details

paulfantom

commit sha 51db8624a523124b68932ed32187a64ce6fe3de7

vendor: revendor

view details

push time in 16 hours

pull request commentopenshift/cluster-monitoring-operator

[release-4.6] Bug 1887338: Preserve labels and annotations during reconciliation

/retitle [release-4.6] Bug 1887339: Preserve labels and annotations during reconciliation

openshift-cherrypick-robot

comment created time in 16 hours

pull request commentopenshift/cluster-monitoring-operator

Bug 1858010: Backport fix for KubePodCrashLooping alert

Rebased to include #945

paulfantom

comment created time in 16 hours

push eventpaulfantom/cluster-monitoring-operator

Lili Cosic

commit sha 1224cf6522d95f3055fc845210d4a64e2ea2818f

go.mod,go.sum: Bump client-go & co.

view details

Lili Cosic

commit sha 2d33fc008fa2777897f9c2bc3b72d03899e36679

vendor: Revendor

view details

Lili Cosic

commit sha 8f83fdc84ddef8fa6dd44a285fe6c0e30afad495

pkg,test: Fix calls by adding context

view details

Lili Cosic

commit sha 1d6c4025b76b61460a256d43bacd0b5188b8cf51

pkg/*: Fix calls and sync to be in line with 4.6

view details

Lili Cosic

commit sha b59e78aded7b4e4a1964d488823d44956f10b206

go.mod,go.sum: Bump k8s.io/metrics

view details

Lili Cosic

commit sha d9dfb83036485ade8dead86ab82966dbe51b0bd7

vendor: Revendor

view details

Lili Cosic

commit sha 3826a18877dfebabaeefd51ba59ca8cedb65391f

test: Adjust calls manually

view details

OpenShift Merge Robot

commit sha f81ad9664b37edfc55d753d3e8db22864cbc4f18

Merge pull request #945 from lilic/bump-client-go-4.5 Bug 1881043: Bump client-go & co.

view details

paulfantom

commit sha af9b099a64e264a4d48aeb72117e6a87f8ca8aee

jsonnet: bump kubernetes-mixins

view details

paulfantom

commit sha cc45fd60be0078a5f13f1c7bb0165a55dbf3a563

assets,pkg/manifests: regenerate

view details

push time in 16 hours

push eventprometheus-operator/kube-prometheus

paulfantom

commit sha 95a4414caf59208be6d1c5a3b097e20228d65d5b

bump node-exporter rules to latest version

view details

Paweł Krupa

commit sha 3b38fcc3509cfb779c09c6d32c6b408b3f284ab2

Merge pull request #729 from paulfantom/node-rules bump node-exporter rules to latest version

view details

push time in 17 hours

delete branch paulfantom/kube-prometheus

delete branch : node-rules

delete time in 17 hours

PR merged prometheus-operator/kube-prometheus

bump node-exporter rules to latest version

Bring in https://github.com/prometheus/node_exporter/pull/1861 and https://github.com/prometheus/node_exporter/pull/1851

/cc @simonpasquier @s-urbaniak

+6 -4

1 comment

2 changed files

paulfantom

pr closed time in 17 hours

PR opened prometheus-operator/kube-prometheus

bump node-exporter rules to latest version

Bring in https://github.com/prometheus/node_exporter/pull/1861 and https://github.com/prometheus/node_exporter/pull/1851

/cc @simonpasquier @s-urbaniak

+6 -4

0 comment

2 changed files

pr created time in 18 hours

create barnchpaulfantom/kube-prometheus

branch : node-rules

created branch time in 18 hours

push eventpaulfantom/kube-prometheus

Jesse Bye

commit sha f0755dcaa83529f69ca0f999f22f883a00709ff4

jb update

view details

paulfantom

commit sha ea21375f1522d99e2f55ac1f954216a0c8ac4263

jsonnet/kube-prometheus/prometheus: ignore timestamps from cadvisor

view details

paulfantom

commit sha 1e8a60ea5754de4174ce551efcc904bd13b6830b

manifests: regenerate

view details

Frederic Branczyk

commit sha 45e2cd1248eb61f9eb3c1ea0206db1e0479b05d8

Merge pull request #693 from jessebye/master Sync up with upstream dependencies

view details

Frederic Branczyk

commit sha 9cbafdb8127667c870192ad790da6f4ba64198cc

Merge pull request #695 from paulfantom/cadvisor ignore timestamps from cadvisor metrics

view details

Frederic Branczyk

commit sha eda75c7c39d0cc8e01840dc1fccb632d8315d5b1

node-exporter: Make host mounts read only and set mount propagation

view details

Frederic Branczyk

commit sha 09239aaa49020b353e2db36d0e062a39cc5a895a

Merge pull request #698 from brancz/ro-mounts node-exporter: Make host mounts read only and set mount propagation

view details

Frederic Branczyk

commit sha 491ecfa65b4d51b9da4637268b64a1c8c4f7066b

node-exporter: Update to v1.0.1

view details

Frederic Branczyk

commit sha 980e95de011319b88a3b9c0787a81dcdf338a898

Merge pull request #699 from brancz/update-ne node-exporter: Update to v1.0.1

view details

Simon Pasquier

commit sha 9a3e6393452ea59488148bf207dba80fd4589dc7

jsonnet/kube-prometheus: update Prometheus dependency to v2.22.0

view details

Simon Pasquier

commit sha 895dcbe1a7c41f112b1de2efd121947337e1ffef

Merge pull request #728 from simonpasquier/udpate-prometheus-2.22 jsonnet/kube-prometheus: update Prometheus dependency to v2.22.0

view details

push time in 18 hours

PullRequestReviewEvent

Pull request review commentprometheus-operator/kube-prometheus

jsonnet/kube-prometheus: update Prometheus dependency to v2.22.0

 In case you want to monitor all namespaces in a cluster, you can add the followi [embedmd]:# (examples/all-namespaces.jsonnet) ```jsonnet local kp = (import 'kube-prometheus/kube-prometheus.libsonnet') +-  (import 'kube-prometheus/kube-prometheus-all-namespaces.libsonnet') + {+           (import 'kube-prometheus/kube-prometheus-all-namespaces.libsonnet') + {

Yes, this is a result of jsonnetfmt.

@simonpasquier Maybe you run make at some point? This includes fmt target :shrug:

simonpasquier

comment created time in 18 hours

PullRequestReviewEvent

delete branch paulfantom/node_exporter

delete branch : network-alerts

delete time in 18 hours

push eventpaulfantom/openshift-state-metrics

paulfantom

commit sha 80f049bcb1bd000a5f661bcd3bb56d7c2524723e

move reaper from origin to here as it was deleted in source repository

view details

paulfantom

commit sha 19fd50cba37d0d29747aaefc0fdbc95c2cc2c5dc

vendor: revendor

view details

push time in 19 hours

PR opened openshift/openshift-state-metrics

WIP: Bug 1885249: Replace klog with klog v2

Follow-up to #62

options.go was using incorrect klog version bumped client-go to remove klog v1 from dependencies

+26588 -17057

0 comment

348 changed files

pr created time in 19 hours

create barnchpaulfantom/openshift-state-metrics

branch : klogv2

created branch time in 19 hours

pull request commentsamber/awesome-prometheus-alerts

Use node_filesystem_avail_bytes

Note: this is a very flaky alert. It will fire every time a lot of data is written to the disk even when such disk can handle it properly. predict_linear should be paired with other metrics to limit flakiness. node_exporter already provides much better alerts to solve this issue at https://github.com/prometheus/node_exporter/blob/master/docs/node-mixin/alerts/alerts.libsonnet#L7-L82

nikclayton-dfinity

comment created time in 20 hours

issue commentsamber/awesome-prometheus-alerts

KubernetesJobCompletion will always fire while job is running

In kubernetes mixin job failure and job completion are decoupled to prevent issues like on you have. You can see an example in https://github.com/kubernetes-monitoring/kubernetes-mixin/blob/master/alerts/apps_alerts.libsonnet#L237-L264 or generated versions in https://monitoring.mixins.dev/kubernetes/ (KubeJobCompletion and KubeJobFailed alerts)

djhoese

comment created time in 20 hours

pull request commentprometheus/node_exporter

docs/node-mixin/alerts: use ratio for network alerts

Any updates on this?

paulfantom

comment created time in 20 hours

pull request commentbrancz/kube-rbac-proxy

*: update client-go and other dependencies

@brancz done

paulfantom

comment created time in 20 hours

issue openedbrancz/kube-rbac-proxy

Replace context.TODO() calls with proper context

New k8s client-go forces passing context in function calls. It would be good to pass proper context instead of TODO.

This should be considered as a follow-up to https://github.com/brancz/kube-rbac-proxy/pull/95

created time in 20 hours

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 878686d104196185e6aaee8b705e96cfb1c5a243

*: retest provisioning

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 3aad97bba62dfb075458ec9f28fb71b0b4dc96dd

ansible/roles: always use latest ssh-hardening

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 0a0f41c55d61262c00c2581f2aa490996ea5c867

ansible: remove node03

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 7727d6d3c248030639c59530247203c863892de0

base/argocd: enable auto heal

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 7babd69ce6f53c433eed9b5aae5a566aedd4b7c6

apps/monitoring: apiserver should be named kube-apiserver

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 952d9438ac7b5fbf4fd97fb54a0e3d6b9a4a529d

base/argocd/argo: update to master to fix issues with Ingress

view details

push time in 5 days

push eventpaulfantom/argo-cd

Chetan Banavikalmutt

commit sha e56997f504ac79b92cfe7ac1e2b7470e7937c015

docs: Fix spelling in contributing guide and FAQ (#4107)

view details

Oleg Sucharevich

commit sha ebb216ff1182c4b5445ebec4f9cadd89f56050dc

fix: log warn when external url is not fully qualified (#4108)

view details

Suraj Biyani

commit sha 01d9b94f6214bb63d4230019d053c5a476e98f85

docs: Add Beat to USERS (#4109)

view details

Nicholas St. Germain

commit sha f2dca0315cf9d2d1540c57b4a28174ad4778c46e

docs: Update traefik gRPC docs (#4112) (#4113)

view details

Jared Welch

commit sha 84e8af79768ac6d63f1fb2e8bacd141f2fd467ac

chore: Add New Relic to USERS.md (#4119) New Relic (https://newrelic.com/) is officially using ArgoCD along with the other Argo projects to deploy to Kubernetes.

view details

Povilas Versockas

commit sha 194d471db4f7510f851532d1bbac9ca477ac3a79

fix: rename redis histogram metric name (#3829)

view details

Povilas Versockas

commit sha 7f86e6b38ce4864f94f8acb4d66f844eb4aefdc3

feat: add git histogram metrics (#3828)

view details

Povilas Versockas

commit sha 263e7a84977d6ba8e9a0318e697cf88d9080d512

feat: add grpc metrics in repo server (#3827)

view details

Yankee

commit sha 0d193cfd575c6b00ee729629801c76e5c1ad25c1

docs: Update broken link for Branch Tracking (#4147) Updated broken internal link for the Branch Tracking section.

view details

Oleg Sucharevich

commit sha c32d5fd5eeeeed65b142e9abc8964f3c4fc57088

docs: Add remote debugging example to contribution docs docs: fix grammar Minor editing empty

view details

Remington Breeze

commit sha 0ee983fc3126fe7ecc21c0e50833c5a45d0395a0

chore(docs): add note about base64 encoding to SSO documentation (#4139)

view details

Marc Boorshtein

commit sha beb2817d6fa443c789dea581d19b8dc8ef78b29f

docs: added docs for openunison integration (#4146) * added docs for openunison integration * fixed formatting * added link to makedocs, fix last header

view details

Marc Boorshtein

commit sha 474301c5ab622a9dae1c53e35eda923ece22ec7a

docs: fixed link for OpenUnison (#4150) * added docs for openunison integration * fixed formatting * added link to makedocs, fix last header * fix link

view details

jannfis

commit sha 372eae0f21aed8c3eb2a3db5f84d6addf4bf7237

fix: Make GnuPG keyring independent of user ID within container (#4136) * fix: Make GnuPG keyring independent of user ID within container * Update unit test

view details

May Zhang

commit sha bc565d384d4c77ab2c35c9045372d74f48ea7b97

fix: UI setting auto sync causes erroneous config (#4118) * fix: UI setting auto sync causes erroneous config * fix: remove log

view details

S.H

commit sha 0b387a454bcad42f17c2d95c1c2b1bc004cadc0f

doc: fix the ci_automation's kustomize source code. (#4144)

view details

Shoubhik Bose

commit sha f508dec107f6864099e371c320e590db737072e9

chore: add nodemodules to gitignore (#4151)

view details

Alexander Matyushentsev

commit sha ee57ded16f7095498ed84b561aa41ef574cd7a2c

refactor: upgrade K8S client to v0.18.8 (#4149)

view details

Josh Soref

commit sha 9ac6bb32486d2810237ac6c135d65ff1512f01f1

fix: clear filters to show (#4142) (#4143)

view details

May Zhang

commit sha 8df8bfff187baed441e786c3de12eed19b743ddf

fix: Badge links are not generating properly when using --rootpath (#4140) * fix: Badge links are not generating properly when using --rootpath * fix: fix lint error * fix: use context.baseHref

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha f7717fe5e0c7d81acf79d93f3bb10d235094f4e9

base/ingress-nginx: decrease alert severity

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 4364b19569b32504e6b4a0444cc06ab273d836dc

base/argocd: split apps from main app

view details

push time in 5 days

delete branch thaum-xyz/ankhmorpork

delete branch : homeassistant

delete time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 1233bfff0d9c000c5ccffbe7c98d09b2e0b11462

apps/homeassistant: upgrade to v0.116.3

view details

paulfantom

commit sha b9ec5409ad300f9cc433c0862505bc97ec045680

hack: improve checkimages script

view details

Paweł Krupa

commit sha 1193fecd6846b52d130484b2a95e67662f29a336

Merge pull request #45 from thaum-xyz/homeassistant

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha b9ec5409ad300f9cc433c0862505bc97ec045680

hack: improve checkimages script

view details

push time in 5 days

PR closed openshift/prometheus-operator

Reviewers
Backport liveness probe lifecycle/stale

Backporting upstream fix https://github.com/coreos/prometheus-operator/pull/2763

+85 -30

4 comments

2 changed files

paulfantom

pr closed time in 5 days

pull request commentopenshift/prometheus-operator

Backport liveness probe

/close

paulfantom

comment created time in 5 days

create barnchthaum-xyz/ankhmorpork

branch : homeassistant

created branch time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 1b4fc7a57400eb9225776fe5b38b75e677803b8b

base/kube-system/sealed-secrets: update to v0.12.6

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 2c9c1a52915b7bb2e547c7210a168836e37907b3

base/cert-manager: update to v1.0.3

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha e12fe13daa5968759631f46bcfc389dc56f31616

base/ingress-nginx: update to v0.40.2

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha e9a6ba09ccff7b837639241de451302f51fbc848

base/argocd: update argocd

view details

push time in 5 days

push eventpaulfantom/argo-cd

Maxime Brunet

commit sha 4816d86acb52b7615e3db74db9387804eb03484e

fix(cli): Fix local diff/sync of apps using cluster name (#4201) This fixes the cluster query when the application uses cluster name as destination: ```shell $ argocd app diff guestbook --local=guestbook/ FATA[0010] rpc error: code = Internal desc = runtime error: invalid memory address or nil pointer dereference ```

view details

May Zhang

commit sha 2fda6d3b8de3ca88fe90b2e73bca97c40b11dd90

Revert "fix: return parsing error (#3942)" This reverts commit 37ef7f43e8520f42f4ffd281624726e28aff6bf4.

view details

Alexander Matyushentsev

commit sha 334e9497a1dea32dc1e12cc8ce011a9cf0756be0

refactor: update gitops engine version (issues #4329, #4298) (#4434)

view details

May Zhang

commit sha f5c72faedbf9e5724439fa0eb9bd443f8efde712

fix: Support transition from a git managed namespace to auto create (#4401) * fix: Support transition from a git managed namespace to auto create * fix: Support transition from a git managed namespace to auto create

view details

argo-bot

commit sha 44871bdd7b66d4257362d79efb132412c15c5620

Bump version to 1.7.7

view details

argo-bot

commit sha 33c93aea0b9ee3d02fb9703cd82cecce3540e954

Bump version to 1.7.7

view details

May Zhang

commit sha 001c2272222aa353df6a80715fea402207f596e7

Revert "feat: autosync protection (#3996)" This reverts commit 382bbdf03162a88de49e632f0c378ac1506371f8.

view details

Alexander Matyushentsev

commit sha f6f96e770960265943c15dc7c371fb46d878ecca

fix: JS error on application list page if app has no namespace (#4499)

view details

Alexander Matyushentsev

commit sha adec0701a2425c689658e67744453f35939a2625

fix: api-server should not try creating default project it is exists already (#4517)

view details

May Zhang

commit sha c277ef8442ff23306a5405de9514f48d9bff3518

fix: login with apiKey capability (#4557) * fix: login with apiKey capability * fix: update based on code review. * fix: update based on code review. * fix: check pws first.

view details

paulfantom

commit sha aab2114e54b9e06af487b015bb1538469c54b1de

CARRY: drone pipeline Signed-off-by: paulfantom <pawel@krupa.net.pl>

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 8cfde21aa3c00c21de3daf01f2f43f3fbbba1639

base/ingress-nginx: add simple alert to notify when ingress is not available

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 62ef4de3fc4a7a9b3e1a942f9a8941b369a89fbc

base/ingress-nginx: add simple alert to notify when ingress is down

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha 012dbaaca4b479df9462142c166f8282ff0cf706

base/ingress-nginx: fix nginx metrics exposition

view details

push time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha f466550e4b92bf641cd57dd7b24b1b7e41d335ad

apps/monitoring: update prometheus-operator and remove blackbox deployment

view details

paulfantom

commit sha a3cd0a8eed7f3a06ed75fd5e2b9b4557258dd7f0

apps: add blackbox monitoring using Probes

view details

push time in 5 days

push eventpaulfantom/prometheus-operator

paulfantom

commit sha 861271ade17a65237418ad7b1319a0fc9d5874e6

jsonnet/prometheus-operator: add RBAC permissions to list ingresses for Probes

view details

paulfantom

commit sha 94a602737a68e3b32a33d1411b9a0391e476454f

regenerate

view details

push time in 5 days

PR opened prometheus/prometheus

documentation/examples: change ingress apiGroup

Signed-off-by: paulfantom pawel@krupa.net.pl

<!-- Don't forget!

- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.

- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.

- No tests are needed for internal implementation changes.

- Performance improvements would need a benchmark test to prove it.

- All exposed objects should have a comment.

- All comments should start with a capital letter and end with a full stop.

-->

Since kubernetes 1.19 ingress object lives in a networking.k8s.io API Group. Source: https://kubernetes.io/docs/concepts/services-networking/ingress/#the-ingress-resource

cc @brancz

+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchpaulfantom/prometheus

branch : rbac-ingress

created branch time in 5 days

PR opened prometheus-operator/prometheus-operator

example/rbac: add prometheus permissions to list ingresses

Specify necessary permissions to use Probes with Ingress selectors.

/cc @prometheus-operator/prometheus-operator-reviewers

+5 -0

0 comment

1 changed file

pr created time in 5 days

create barnchpaulfantom/prometheus-operator

branch : rbac-ingress

created branch time in 5 days

push eventthaum-xyz/ankhmorpork

paulfantom

commit sha eadafb4b36126ba0ff47b53927bd32438d29658b

apps/monitoring/ksm: remove readiness probe

view details

paulfantom

commit sha fcd12d5a857a7932def73e2c4e06878a04800265

apps/monitoring: change apiserver scrape job

view details

paulfantom

commit sha 7cdbeb9d3dd1b061e975b386bc1fb15a24436b27

apps/monitoring/grafana: bump to 7.2.1

view details

push time in 5 days

issue commentcloudalchemy/ansible-node-exporter

Basic Authentication password hashing

Could you add this package requirement to https://github.com/cloudalchemy/ansible-node-exporter#requirements section in README?

It seems like an ansible bug in password_hash jinja function. I would expect it to fail if bcrypt is specified but not installed.

thdhondt

comment created time in 5 days

issue commentcloudalchemy/ansible-node-exporter

Basic Authentication password hashing

What is the ansible output from running the role? Could you run it with higher verbosity and attach output of Copy the node_exporter config file task?

thdhondt

comment created time in 6 days

pull request commentbrancz/kube-rbac-proxy

*: update client-go and other dependencies

I fixed issues reported by CI. This should be ready for review now.

paulfantom

comment created time in 6 days

push eventpaulfantom/kube-rbac-proxy

paulfantom

commit sha b224098f0fd17b2a40b2094632326772dabd8a5e

*: update client-go and other dependencies

view details

push time in 6 days

issue commentprometheus-operator/prometheus-operator

Not able to control Readiness probe & Liveness probe

It seems your prometheus instance is overloaded (WAL replay?).

We recently removed liveness probes in https://github.com/prometheus-operator/prometheus-operator/pull/3502. Next prometheus-operator version will include this and it should fix your issue.

You can read our discussion on why we removed it and why we don't want to make this configurable in https://github.com/prometheus-operator/prometheus-operator/issues/3391

gaurav-ackotech

comment created time in 6 days

Pull request review commentopenshift/cluster-monitoring-operator

jsonnet/jsonnetfile.json: Switch to master

 items:     - get     - list     - watch+  - apiGroups:

Seems like this is a cause of failing e2e tests.

lilic

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentopenshift/cluster-monitoring-operator

jsonnet/jsonnetfile.json: Switch to master

+apiVersion: monitoring.coreos.com/v1

Sorry, I was mistaken. Not enough coffee :smile:

We should deploy it then :+1:

lilic

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentopenshift/cluster-monitoring-operator

jsonnet/jsonnetfile.json: Switch to master

 spec:   podMonitorNamespaceSelector: {}   podMonitorSelector: {}   priorityClassName: system-cluster-critical+  probeNamespaceSelector: {}+  probeSelector: {}

If the option is not specified, then it defaults to nil so our manifests in 4.6 should be fine.

lilic

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentopenshift/cluster-monitoring-operator

jsonnet/jsonnetfile.json: Switch to master

+apiVersion: monitoring.coreos.com/v1

What's the purpose? We don't deploy sidecar, so why deploy ServiceMonitor for it?

lilic

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentopenshift/release

Add openshift/procfs repository to Prow

/lgtm

simonpasquier

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentopenshift/cluster-monitoring-operator

jsonnet/jsonnetfile.json: Switch to master

 spec:   podMonitorNamespaceSelector: {}   podMonitorSelector: {}   priorityClassName: system-cluster-critical+  probeNamespaceSelector: {}+  probeSelector: {}

This would allow probe objects to be added to prometheus. Do we want that?

lilic

comment created time in 6 days

push eventpaulfantom/kube-rbac-proxy

paulfantom

commit sha e332f5b8b7356e6983454dac77509251f17fb9ad

*: update client-go and other dependencies

view details

push time in 6 days

push eventpaulfantom/kube-rbac-proxy

paulfantom

commit sha 09d5191ef7a8ca0851acb08d4a25e54006b297f6

*: update client-go and other dependencies

view details

push time in 6 days

Pull request review commentopenshift/procfs

Add OWNERS file

+component: "Monitoring"++reviewers:+- LiliC+- paulfantom+- s-urbaniak+- simonpasquier

we should add @dgrisonnet too

simonpasquier

comment created time in 6 days

PullRequestReviewEvent

Pull request review commentopenshift/release

Add openshift/procfs repository to Prow

+component: "Monitoring"++reviewers:

we should add @dgrisonnet

simonpasquier

comment created time in 6 days

PullRequestReviewEvent

PR opened openshift/cluster-monitoring-operator

Bug 1887799: Unset memory limits on config reloader container

<!-- Don't forget about CHANGELOG if this affects the end user!

Changelog entry format:
- [#<PR-id>](<PR-URL>) Monitoring <Component> ...

<PR-id> Id of your pull request.
<PR-URL> URL of your PR
<Component> Component affected by your changes such as deps bump, alerts changes and any user facing changes.

Example:
- [#741](https://github.com/openshift/cluster-monitoring-operator/pull/741) Bump thanos components to v0.11.0 release

-->

  • [x] I added CHANGELOG entry for this change.
  • [ ] No user facing changes, so no entry in CHANGELOG was needed.

The policy is not to set any limits on containers.

+8 -2

0 comment

4 changed files

pr created time in 7 days

push eventpaulfantom/cluster-monitoring-operator

paulfantom

commit sha 35ce9f080ac10d0bf54d09c998665db9a9af4b0c

changelog entry

view details

push time in 7 days

create barnchpaulfantom/cluster-monitoring-operator

branch : limits

created branch time in 7 days

Pull request review commentopenshift/cluster-monitoring-operator

cluster-monitoring-config Doc update

 baseImage: <string> prometheusConfigReloaderBaseImage: <string>

I think this was removed some time ago. Right now I don't see this option to have any effect.

garbagego

comment created time in 7 days

Pull request review commentopenshift/cluster-monitoring-operator

cluster-monitoring-config Doc update

 baseImage: <string> prometheusConfigReloaderBaseImage: <string> # configReloaderBaseImage references a base container image. Defaults to "quay.io/coreos/configmap-reload". configReloaderBaseImage: <string>+# logLevel defines the verbosity of PrometheusOperator instance+logLevel: <string>+# nodeSelector defines the nodes on which PrometheusOperator instances will be scheduled.+nodeSelector: +  [ - <labelname>: <labelvalue> ]+# tolerations allow PrometheusOperator instances to be scheduled onto nodes with matching taints+tolerations:+  - [v1.Toleration](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#toleration-v1-core) ```  ### PrometheusK8sConfig  Use PrometheusK8sConfig to customize the Prometheus instance used for cluster monitoring.  ```yaml+# logLevel defines the verbosity of PrometheusK8s instance+logLevel: <string> # retention time for samples. retention: <string> # baseImage references a base container image. Defaults to "quay.io/prometheus/prometheus".

Same as above. This doesn't seem to have any impact.

garbagego

comment created time in 7 days

Pull request review commentopenshift/cluster-monitoring-operator

cluster-monitoring-config Doc update

 Use KubeStateMetricsConfig to configure parameters for deployment of the `kube-s ```yaml # baseImage is the container image repository that will be used to deploy the kube-state-metrics pods baseImage: <string>+# nodeSelector defines the nodes on which KubeStateMetrics instances will be scheduled.+nodeSelector: +  [ - <labelname>: <labelvalue> ]+# tolerations allow KubeStateMetrics instances to be scheduled onto nodes with matching taints+tolerations:+  - [v1.Toleration](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#toleration-v1-core) addonResizerBaseImage: <string> ``` -[quay]: https://quay.io/+### GrafanaConfig++Use GrafanaConfig to configure parameters for deployment of the `grafana` components.+```yaml+# baseImage is the container image repository that will be used to deploy the grafana pods+baseImage: <string>

This option was removed and doesn't have any effect.

garbagego

comment created time in 7 days

Pull request review commentopenshift/cluster-monitoring-operator

cluster-monitoring-config Doc update

 Use KubeStateMetricsConfig to configure parameters for deployment of the `kube-s ```yaml # baseImage is the container image repository that will be used to deploy the kube-state-metrics pods baseImage: <string>+# nodeSelector defines the nodes on which KubeStateMetrics instances will be scheduled.+nodeSelector: +  [ - <labelname>: <labelvalue> ]+# tolerations allow KubeStateMetrics instances to be scheduled onto nodes with matching taints+tolerations:+  - [v1.Toleration](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#toleration-v1-core) addonResizerBaseImage: <string> ``` -[quay]: https://quay.io/+### GrafanaConfig++Use GrafanaConfig to configure parameters for deployment of the `grafana` components.+```yaml+# baseImage is the container image repository that will be used to deploy the grafana pods+baseImage: <string>+# nodeSelector defines the nodes on which Grafana instances will be scheduled.+nodeSelector: +  [ - <labelname>: <labelvalue> ]+# tolerations allow Grafana instances to be scheduled onto nodes with matching taints+tolerations:+  - [v1.Toleration](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#toleration-v1-core)+# resources defines the resource requests and limits for the Grafana instances.+```++### ThanosQuerierConfig++Use ThanosQuerierConfig to configure parameters for deployment of the `thanos-querier` components.++```yaml+# baseImage is the container image repository that will be used to deploy the thanos-querier pods+baseImage: <string>

Same as above. This doesn't have any effect.

garbagego

comment created time in 7 days

Pull request review commentopenshift/cluster-monitoring-operator

cluster-monitoring-config Doc update

 Use KubeStateMetricsConfig to configure parameters for deployment of the `kube-s ```yaml # baseImage is the container image repository that will be used to deploy the kube-state-metrics pods baseImage: <string>+# nodeSelector defines the nodes on which KubeStateMetrics instances will be scheduled.+nodeSelector: +  [ - <labelname>: <labelvalue> ]+# tolerations allow KubeStateMetrics instances to be scheduled onto nodes with matching taints+tolerations:+  - [v1.Toleration](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#toleration-v1-core) addonResizerBaseImage: <string>

I think this was removed some time ago. Right now I don't see this option to have any effect.

garbagego

comment created time in 7 days

Pull request review commentopenshift/cluster-monitoring-operator

cluster-monitoring-config Doc update

 resources: [v1.ResourceRequirements](https://kubernetes.io/docs/api-reference/v1 # specified by users externalLabels:   [ - <labelname>: <labelvalue> ]+# volumeClaimTemplate defines the template to use for persistent storage for Prometheus pods.+volumeClaimTemplate: [v1.PersistentVolumeClaim](https://kubernetes.io/docs/api-reference/v1.6/#persistentvolumeclaim-v1-core)+# remoteWrite defines the `remote_write` configuration for prometheus.+remoteWrite:+  [ - url: <urlvalue>]

This has much more options than just a simple url. Full spec is at https://github.com/prometheus-operator/prometheus-operator/blob/master/Documentation/api.md#remotewritespec

garbagego

comment created time in 7 days

Pull request review commentopenshift/cluster-monitoring-operator

cluster-monitoring-config Doc update

 baseImage: <string> prometheusConfigReloaderBaseImage: <string> # configReloaderBaseImage references a base container image. Defaults to "quay.io/coreos/configmap-reload". configReloaderBaseImage: <string>

Same as above. This doesn't seem to have any impact.

garbagego

comment created time in 7 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentmonitoring-mixins/mixtool

Update jsonnet to 0.16

What do you think about bumping this dependency to an even newer version? There are significant performance improvements in later revisions.

We had a discussion about such bump in kube-prometheus project at https://github.com/prometheus-operator/kube-prometheus/pull/608

tomwilkie

comment created time in 7 days

more