profile
viewpoint
Paul Armstrong paularmstrong Twitter Bend, OR

paularmstrong/build-tracker 408

A set of tools to track the size of your build artifacts over time.

paularmstrong/basejs 60

baseJS is a work-in-progress lightweight JavaScript library for Safari, Firefox, and especially Mobile Safari. Be sure to run 'git submodule init' and 'git submodule update' upon first clone of baseJS to get Sizzle imported.

paularmstrong/dotfiles 20

My setup and config files.

BendJS/website 11

BendJS website - Built with NextJS and open for the community to hack on!

paularmstrong/ImpactJS.tmbundle 10

A Textmate bundle: snippets, language, and templates for ImpactJs

paularmstrong/ImpactTest 8

A wrapper to allow unit testing of Impact.js through Node.js

paularmstrong/build-tracker-heroku 6

Quickly and easily deploy a new Build Tracker application to Heroku

paularmstrong/CSSlider 5

A Slideshow tool built with HTML, JS, and CSS3

paularmstrong/badkitty 2

BadKitty is a bad little PHP framework for getting some small application things done quickly.

paularmstrong/build-tracker-action 2

GitHub Action for adding Build Tracker comparisons to pull requests

pull request commentpaularmstrong/build-tracker

chore(api-client): add child process invocation command to error output

This is available in the v1.0.0-beta.17 releases

paulirish

comment created time in 6 hours

created tagpaularmstrong/build-tracker

tagv1.0.0-beta.17

A set of tools to track the size of your build artifacts over time.

created time in 6 hours

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha 3615b7a5e287bd96da06150c5cdaf1fc148ef14f

v1.0.0-beta.17

view details

push time in 6 hours

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha 71436f2245e0bc9c800ab12e1db9ae3da032e98e

feat(api-client cli): add getBuild and get-build Closes #212 Fixes #210

view details

push time in 6 hours

PR closed paularmstrong/build-tracker

[WIP] Get build

Problem

#210

We need a method to check if a build exists, in order to avoid e.g. re-uploading builds for comparison in CI jobs. If a build has already been uploaded, no need to do so again. This will also avoid issues relating to duplicate primary keys when rebuilding.

Solution

This is totally WIP but here I'm adding a method that should simply call through to the server:read method for checking builds.

TODO

  • [x] 🤓 Add & update tests (always try to increase test coverage)
  • [x] 🔬 Ensure CI is passing (yarn lint:ci, yarn test, yarn tsc:ci)
  • [ ] 📖 Update relevant documentation
  • [x] 🕵️‍♀️ Check relevant internals are being called by method
  • [x] 💻 Update CLI to include get-build method
+152 -0

1 comment

5 changed files

roc

pr closed time in 6 hours

delete branch paularmstrong/build-tracker

delete branch : fix-docs

delete time in a day

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha 7de4843948d5140bc41dd1becdbdeb42c30460cc

docs: fix for node 12, upgrade docusaurus (#211)

view details

push time in a day

PR merged paularmstrong/build-tracker

docs: fix for node 12, upgrade docusaurus

<!-- Thank you so much for contributing to open source and the Build Tracker project! -->

Problem

Docs aren't building on Node 12

Solution

  • Upgrade docusaurus
    • Requires nohoist on html-minifier-terser due to https://github.com/facebook/docusaurus/issues/3515#issuecomment-707145367
  • Fix broken links
  • Change github action to be simpler

TODO

  • [ ] 🤓 Add & update tests (always try to increase test coverage)
  • [x] 🔬 Ensure CI is passing (yarn lint:ci, yarn test, yarn tsc:ci)
  • [x] 📖 Update relevant documentation
+3452 -2332

1 comment

13 changed files

paularmstrong

pr closed time in a day

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha 0b7205d0ceef1c6a79af67a6aa2cb7d81cdd3cbd

docs: fix for node 12, upgrade docusaurus

view details

push time in a day

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha eb2d57ada47769839afe8e51d18b3928136baa47

docs: fix for node 12, upgrade docusaurus

view details

push time in a day

PR opened paularmstrong/build-tracker

docs: fix for node 12, upgrade docusaurus

<!-- Thank you so much for contributing to open source and the Build Tracker project! -->

Problem

Docs aren't building on Node 12

Solution

Upgrade docusaurus, fix actions

TODO

  • [ ] 🤓 Add & update tests (always try to increase test coverage)
  • [ ] 🔬 Ensure CI is passing (yarn lint:ci, yarn test, yarn tsc:ci)
  • [ ] 📖 Update relevant documentation
+3448 -2320

0 comment

8 changed files

pr created time in a day

create barnchpaularmstrong/build-tracker

branch : fix-docs

created branch time in a day

push eventpaularmstrong/build-tracker

push time in a day

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha 8b4a15b9fadbc06c1344f8c29410fdf5999c2458

docs: fix build by upgrading babel

view details

push time in a day

delete branch paularmstrong/build-tracker

delete branch : mismatched-sizekeys

delete time in a day

PR merged paularmstrong/build-tracker

feat(comparator cli): allow comparisons even if size keys do not match 📁 Repo: cli 📁 Repo: comparator

<!-- Thank you so much for contributing to open source and the Build Tracker project! -->

Problem

Switching from Node 10 to Node 12 produces an issue that suddenly brotli will be included in available sizeKeys for builds. This causes various things to throw errors because they're hardcoded to not allow a change in the sizeKeys

Solution

This manual throwing seems unnecessary. By removing these checks, we can allow comparisons with the given keys, the result will just cause the comparison to show 0s for the build missing that size key.

Also updated CI to node 12

TODO

  • [x] 🤓 Add & update tests (always try to increase test coverage)
  • [x] 🔬 Ensure CI is passing (yarn lint:ci, yarn test, yarn tsc:ci)
  • [x] 📖 Update relevant documentation
+57 -61

2 comments

7 changed files

paularmstrong

pr closed time in a day

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha a763fdc4d35ebd2281417df587cdf125684df3d8

feat(comparator): allow comparisons even if size keys do not match (#209)

view details

push time in a day

delete branch paularmstrong/build-tracker

delete branch : increase-branch-name-length

delete time in a day

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha fc2e37e1fd4342fbbf816b67f9fc6f6ee82712b1

fix(plugins): increase branch name length to 256-char (#208) * fix: increase branch name length to 256-char * fix: seed database with fixtures from builds-medium * fix(plugin-with-mysql): ensure client exists when releasing

view details

push time in a day

PR merged paularmstrong/build-tracker

fix: increase branch name length to 256-char 📁 Repo: server 📁 Repo: with-mariadb 📁 Repo: with-mysql 📁 Repo: with-postgres

<!-- Thank you so much for contributing to open source and the Build Tracker project! -->

Problem

Some people use really long git branch names, sometimes automated systems do that. We currently limit branch names in the official database plugins to 64 characters.

Solution

Increase to 256 characters.

Fixes #205

Ideally in a longer term solution, we should include schema versions in the database to know what migrations need to be run. This is something we could investigate as a larger epic.

TODO

  • [x] Manual verification with docker containers: https://buildtracker.dev/docs/guides/contributing#plugins-plugins
  • [x] 🤓 Add & update tests (always try to increase test coverage)
  • [x] 🔬 Ensure CI is passing (yarn lint:ci, yarn test, yarn tsc:ci)
  • [x] 📖 Update relevant documentation
+55 -45

2 comments

7 changed files

paularmstrong

pr closed time in a day

issue closedpaularmstrong/build-tracker

Allow longer branch names

<!--

IMPORTANT! Follow the format of this template or your issue will be automatically closed by a bot. Following this template helps keep the quality of bug reports high, which will help them be addressed sooner.

-->

Problem

<!-- Add a short explanation of your problem or use-case

Example: When I click the drawer link, nothing happens! -->

Steps to Reproduce

<!-- Include a list of steps that anyone can take to reproduce the bug If you have a code sample, this is a great place to include it

Example:

  1. Navigate to the main Build Tracker page
  2. Click the menu button to open the side drawer
  3. Click "Documentation" link -->

New issue because https://github.com/paularmstrong/build-tracker/issues/203 was automatically closed

The database setup defines a branch as max 64 characters. Just today we had a build fail because we actually ran into this limit (not a branch name we defined ourselves, but one created by GitHub's "revert PR" functionality).

Could we increase the max length?

Expected Result

<!-- Write out what you expect to see or have happen when running the previous steps

Example: The link should open a new page to the documentation -->

Actual Result

<!-- Write out what actually happens when running the previous steps

Example: Nothing happens. But I do see an error in the browser's console. It looks like this:

TypeError: cannot read property href of undefined -->

closed time in a day

OliverJAsh

issue closedpaularmstrong/build-tracker

Avoid setting "Revision" as PRIMARY_KEY

<!--

IMPORTANT! Follow the format of this template or your issue will be automatically closed by a bot. Following this template helps keep the quality of feature requests high, which will help them be addressed sooner.

-->

Problem

The database plugins are setup with setting revision key as the PRIMARY_KEY. However if we re-run the build tracker job it ends up in a duplicate key error ( Since the sha is the same).

<!-- Explain the problem you'd like to have Build Tracker solve. When trying to solve more solutions with Build Tracker, please keep in mind some of the following goals of the project:

  • Be lightweight: small project size (single-digit KiBs, gzipped)
  • Be easy: too many options in an API can become confusing
  • Be clear: the intended purpose of every method should be obvious
  • Is it easy to do this in "userland"? Would it be better off done there? -->

Proposed solution

I'm proposing adding a unique ID key to each row which will have the property of Uniq and Primary Key. This way subsequent re-runs will ensure that the job works even the sha is unchanges. <!-- Explain a possible way to solve the problem. Keep in mind that there may be alternate ways to do the same thing. Try to think of those and weight the tradeoffs. -->

closed time in 2 days

PranaytheSingh

issue commentpaularmstrong/build-tracker

Avoid setting "Revision" as PRIMARY_KEY

Discussed in person. We'll be implementing a getBuild() method in the @build-tracker/api-client to allow checking for existing builds to avoid attempting to double-post.

PranaytheSingh

comment created time in 2 days

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha ec345716bd60d2e74a99ac5e6a40d83f7bc243c7

feat(comparator): allow comparisons even if size keys do not match

view details

push time in 2 days

PR opened paularmstrong/build-tracker

feat(comparator): allow comparisons even if size keys do not match

<!-- Thank you so much for contributing to open source and the Build Tracker project! -->

Problem

Switching from Node 10 to Node 12 produces an issue that suddenly brotli will be included in available sizeKeys for builds. This causes various things to throw errors because they're hardcoded to not allow a change in the sizeKeys

Solution

This manual throwing seems unnecessary. By removing these checks, we can allow comparisons with the given keys, the result will just cause the comparison to show 0s for the build missing that size key.

TODO

  • [ ] 🤓 Add & update tests (always try to increase test coverage)
  • [ ] 🔬 Ensure CI is passing (yarn lint:ci, yarn test, yarn tsc:ci)
  • [ ] 📖 Update relevant documentation
+64 -60

0 comment

7 changed files

pr created time in 2 days

create barnchpaularmstrong/build-tracker

branch : mismatched-sizekeys

created branch time in 2 days

delete branch paularmstrong/commandapp

delete branch : dependabot/npm_and_yarn/node-fetch-2.6.1

delete time in 3 days

push eventpaularmstrong/commandapp

dependabot[bot]

commit sha 59ecc9963328d71183cade18d3ace6e0ccdeed69

chore(deps): bump node-fetch from 2.6.0 to 2.6.1 Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Paul Armstrong

commit sha 1b89aeaf7579bf443bdcd4cb258909deae3a8d5a

Merge pull request #1 from paularmstrong/dependabot/npm_and_yarn/node-fetch-2.6.1 chore(deps): bump node-fetch from 2.6.0 to 2.6.1

view details

push time in 3 days

PR merged paularmstrong/commandapp

chore(deps): bump node-fetch from 2.6.0 to 2.6.1 dependencies

Bumps node-fetch from 2.6.0 to 2.6.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bitinn/node-fetch/releases">node-fetch's releases</a>.</em></p> <blockquote> <h2>v2.6.1</h2> <p><strong>This is an important security release. It is strongly recommended to update as soon as possible.</strong></p> <p>See <a href="https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md#v261">CHANGELOG</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md">node-fetch's changelog</a>.</em></p> <blockquote> <h2>v2.6.1</h2> <p><strong>This is an important security release. It is strongly recommended to update as soon as possible.</strong></p> <ul> <li>Fix: honor the <code>size</code> option after following a redirect.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/node-fetch/node-fetch/commit/b5e2e41b2b50bf2997720d6125accaf0dd68c0ab"><code>b5e2e41</code></a> update version number</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/2358a6c2563d1730a0cdaccc197c611949f6a334"><code>2358a6c</code></a> Honor the <code>size</code> option after following a redirect and revert data uri support</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/8c197f8982a238b3c345c64b17bfa92e16b4f7c4"><code>8c197f8</code></a> docs: Fix typos and grammatical errors in README.md (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/686">#686</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/1e99050f944ac435fce26a9549eadcc2419a968a"><code>1e99050</code></a> fix: Change error message thrown with redirect mode set to error (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/653">#653</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/244e6f63d42025465796e3ca4ce813bf2c31fc5b"><code>244e6f6</code></a> docs: Show backers in README</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/6a5d192034a0f438551dffb6d2d8df2c00921d16"><code>6a5d192</code></a> fix: Properly parse meta tag when parameters are reversed (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/682">#682</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/47a24a03eb49a49d81b768892aee10074ed54a91"><code>47a24a0</code></a> chore: Add opencollective badge</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/7b136627c537cb24430b0310638c9177a85acee1"><code>7b13662</code></a> chore: Add funding link</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/5535c2ed478d418969ecfd60c16453462de2a53f"><code>5535c2e</code></a> fix: Check for global.fetch before binding it (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/674">#674</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/1d5778ad0d910dbd1584fb407a186f5a0bc1ea22"><code>1d5778a</code></a> docs: Add Discord badge</li> <li>Additional commits viewable in <a href="https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~akepinski">akepinski</a>, a new releaser for node-fetch since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 3 days

PublicEvent

push eventpaularmstrong/commandapp

Paul Armstrong

commit sha 7911ba8c2890d350de9ad7619d5a09e5e1557cf3

feat(logger): stringify mixed output

view details

push time in 3 days

push eventpaularmstrong/build-tracker

Paul Armstrong

commit sha ca9c778cf942f4e4a58f24100111089090e57211

fix: seed database with fixtures from builds-medium

view details

Paul Armstrong

commit sha ca721d3b503b17290e09514ce2faa8f08696b490

fix(plugin-with-mysql): ensure client exists when releasing

view details

push time in 5 days

PR opened paularmstrong/build-tracker

Reviewers
fix: increase branch name length to 256-char

<!-- Thank you so much for contributing to open source and the Build Tracker project! -->

Problem

Some people use really long git branch names, sometimes automated systems do that. We currently limit branch names in the official database plugins to 64 characters.

Solution

Increase to 256 characters.

Fixes #205

Ideally in a longer term solution, we should include schema versions in the database to know what migrations need to be run. This is something we could investigate as a larger epic.

TODO

  • [ ] Manual verification with docker containers: https://buildtracker.dev/docs/guides/contributing#plugins-plugins
  • [x] 🤓 Add & update tests (always try to increase test coverage)
  • [ ] 🔬 Ensure CI is passing (yarn lint:ci, yarn test, yarn tsc:ci)
  • [x] 📖 Update relevant documentation
+45 -29

0 comment

6 changed files

pr created time in 5 days

create barnchpaularmstrong/build-tracker

branch : increase-branch-name-length

created branch time in 5 days

release paularmstrong/normalizr

v3.6.1

released time in 5 days

created tagpaularmstrong/normalizr

tagv3.6.1

Normalizes nested JSON according to a schema

created time in 5 days

push eventpaularmstrong/normalizr

Paul Armstrong

commit sha 1f6ae6ad6f3155888a41eacab3ed1e12c07a9c8b

v3.6.1

view details

push time in 5 days

delete branch paularmstrong/normalizr

delete branch : remove-example-lock

delete time in 5 days

push eventpaularmstrong/normalizr

Paul Armstrong

commit sha de44009e90275c6d1a9913025751efc03cd5ec76

chore: remove example yarn.lock file (#456)

view details

push time in 5 days

PR merged paularmstrong/normalizr

chore: remove example yarn.lock file

<!-- Thank you so much for contributing to open source and the Normalizr project! -->

Problem

This lock file is a source of dependency/security issues that we don't really need to deal with

Solution

delete. also delete greenkeeper config, since we don't use it

TODO

  • [ ] Add & update tests
  • [ ] Ensure CI is passing (lint, tests, flow)
  • [ ] Update relevant documentation
+0 -1984

1 comment

2 changed files

paularmstrong

pr closed time in 5 days

PR opened paularmstrong/normalizr

chore: remove example yarn.lock file

<!-- Thank you so much for contributing to open source and the Normalizr project! -->

Problem

This lock file is a source of dependency/security issues that we don't really need to deal with

Solution

delete. also delete greenkeeper config, since we don't use it

TODO

  • [ ] Add & update tests
  • [ ] Ensure CI is passing (lint, tests, flow)
  • [ ] Update relevant documentation
+0 -1984

0 comment

2 changed files

pr created time in 5 days

create barnchpaularmstrong/normalizr

branch : remove-example-lock

created branch time in 5 days

delete branch paularmstrong/normalizr

delete branch : update-dependencies

delete time in 5 days

push eventpaularmstrong/normalizr

Paul Armstrong

commit sha b751eca7507d5e7e6c41d898ea9fb775f518eb8c

chore: update eslint/prettier deps

view details

Paul Armstrong

commit sha 9c8e344a7532fc1d57bfc158a0a8fbf3d86b348c

chore: upgrade flow to 0.136.0

view details

Paul Armstrong

commit sha dc16e804832472d06e8b962502af25d1c3ca241e

chore: upgrade coveralls

view details

Paul Armstrong

commit sha 784c44457d5d846fede2477afb209dad80ea80de

chore: upgrade babel/jest

view details

Paul Armstrong

commit sha a46a7a4950b3aec448d420932ac64bef369ea482

chore: upgrade npm-run-all, rimraf

view details

Paul Armstrong

commit sha 239107107f4d39f42779e9f611ecdbe2c4166b02

chore: upgrade rollup

view details

Paul Armstrong

commit sha fc53e5b0c826c7f97dd653aea5f4d2da217c9f54

ci: use node 10, 12, 14

view details

Paul Armstrong

commit sha 5aaa67fd4a648242e83c1690b1ae8390e1cb4b0e

Merge pull request #455 from paularmstrong/update-dependencies chore: Update devDependencies

view details

push time in 5 days

PR merged paularmstrong/normalizr

chore: Update devDependencies

<!-- Thank you so much for contributing to open source and the Normalizr project! -->

Problem

Lots of outdated development dependencies.

Solution

Upgrade them

TODO

  • [x] Add & update tests
  • [x] Ensure CI is passing (lint, tests, flow)
  • [x] Update relevant documentation
+4001 -2868

1 comment

34 changed files

paularmstrong

pr closed time in 5 days

pull request commentpaularmstrong/build-tracker

chore(api-client): add child process invocation command to error output

Thanks @paulirish !

paulirish

comment created time in 5 days

push eventpaularmstrong/build-tracker

Paul Irish

commit sha e00fac7b1e14a7b3a58e826770d4962e68c16a4b

chore(api-client): add child process invocation command to error output (#207)

view details

push time in 5 days

PR merged paularmstrong/build-tracker

chore(api-client): add child process invocation command to error output

Problem

Problem

Sometimes buildtracker fails randomly. Example: https://github.com/GoogleChrome/lighthouse/runs/1130093961?check_suite_focus=true#step:19:25

image

since we have no idea what command triggered a nonzero exit code, it's a bit hard to debug.

Solution

since the error object that spawn() rejects with already has a few things, and is logged out to stderr... i figure why not.

fixes #200

TODO

  • [X] 🤓 Add & update tests (always try to increase test coverage)
  • [x] 🔬 Ensure CI is passing (yarn lint:ci, yarn test, yarn tsc:ci)
  • [X] 📖 Update relevant documentation
+2 -1

1 comment

1 changed file

paulirish

pr closed time in 5 days

issue closedpaularmstrong/build-tracker

verbose mode should log child-process spawns

Problem

Sometimes buildtracker fails randomly. Example: https://github.com/GoogleChrome/lighthouse/runs/1130093961?check_suite_focus=true#step:19:27

image

We saw errors like this before: https://github.com/paularmstrong/build-tracker/issues/195 Although that time there was a more useful stderr to read.

feature request: If -v is on, i'd love to enable something like this at the top of spawn.ts:

console.log('running', `${command} ${args.join(' ')}`);

I obviously considered writing this myself, but am not entirely sure how you want to carry the args that deep.

Steps to Reproduce

The first link above's failure is completely intermittent. No idea how to reproduce.

Expected Result

Of course, no bugs. But I figure some better debug logging would help isolate whatever problem is going on.

Actual Result

An error without any useful info.

closed time in 5 days

paulirish

delete branch paularmstrong/build-tracker

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 5 days

push eventpaularmstrong/build-tracker

dependabot[bot]

commit sha 4573db674e5907c9140043c915c6995bece56d83

chore: bump lodash from 4.17.14 to 4.17.19 (#202) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.14 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.14...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 5 days

PR merged paularmstrong/build-tracker

chore: bump lodash from 4.17.14 to 4.17.19 dependencies

Bumps lodash from 4.17.14 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.14...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+4 -9

2 comments

1 changed file

dependabot[bot]

pr closed time in 5 days

push eventpaularmstrong/normalizr

Paul Armstrong

commit sha fc53e5b0c826c7f97dd653aea5f4d2da217c9f54

ci: use node 10, 12, 14

view details

push time in 5 days

PR opened paularmstrong/normalizr

chore: Update devDependencies

<!-- Thank you so much for contributing to open source and the Normalizr project! -->

Problem

Lots of outdated development dependencies.

Solution

Upgrade them

TODO

  • [x] Add & update tests
  • [x] Ensure CI is passing (lint, tests, flow)
  • [x] Update relevant documentation
+3998 -2867

0 comment

33 changed files

pr created time in 5 days

create barnchpaularmstrong/normalizr

branch : update-dependencies

created branch time in 5 days

PullRequestReviewEvent

PR closed paularmstrong/normalizr

feat(entity) add key naming strategy

<!-- Thank you so much for contributing to open source and the Normalizr project! -->

Problem

It's just confuse to having the same property sometimes to be Id, sometimes to be an object/array. And that problem is particularly annoying when it comes to using TypeScript, as user have to define the type either like user: number|User or user: any.

Found one issue on this one. https://github.com/paularmstrong/normalizr/issues/423

Solution

Add an optional option to suffixed id to the property.

      const user = new schema.Entity('users', {}, { keyNamingStrategy: 'camelCase' });
      const comment = new schema.Entity('comments', {}, { keyNamingStrategy: 'camelCase' });
      const article = new schema.Entity(
        'articles',
        {
          author: user,
          comments: [comment]
        },
        { keyNamingStrategy: 'camelCase' }
      );

      const input = {
        id: '123',
        title: 'A Great Article',
        author: {
          id: '8472',
          name: 'Paul'
        },
        body: 'This article is great.',
        comments: [
          {
            id: 'comment-123-4738',
            comment: 'I like it!'
          }
        ]
      };

result

"entities": Object {
    "articles": Object {
      "123": Object {
        "authorId": "8472",
        "body": "This article is great.",
        "commentsIds": Array [
          "comment-123-4738",
        ],
        "id": "123",
        "title": "A Great Article",
      },
    },
    "comments": Object {
      "comment-123-4738": Object {
        "comment": "I like it!",
        "id": "comment-123-4738",
      },
    },
    "users": Object {
      "8472": Object {
        "id": "8472",
        "name": "Paul",
      },
    },
  },
  "result": "123",

TODO

  • [x] Add & update tests
  • [x] Ensure CI is passing (lint, tests, flow)
  • [ ] Update relevant documentation
+232 -6

3 comments

4 changed files

gogoout

pr closed time in 5 days

pull request commentpaularmstrong/normalizr

feat(entity) add key naming strategy

As noted in the issue that you linked, this is a major change that would be better off in a fork of normalizr.

gogoout

comment created time in 5 days

PR closed paularmstrong/normalizr

WIP: Fix babel configs of examples/redux

fix #427

Problem

Project in examples/redux does not run #427

Babel was updated to 7. Refs #377, #318

I think it's necessary to upgrade babel in examples too.

Solution

This is work in progress right now.

I just upgraded modules and copied babel configs.

But it’s still has an issue with module importing.

➜  redux git:(master) ✗ yarn start
yarn run v1.19.2
$ babel-node ./
/PATH/TO/normalizr/src/index.js:1
import * as ImmutableUtils from './schemas/ImmutableUtils';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at Module._compile (internal/modules/cjs/loader.js:895:18)

TODO

  • [ ] Fix import problem described in above.
  • [ ] Add & update tests
  • [ ] Ensure CI is passing (lint, tests)
  • [ ] Update relevant documentation

Maybe it's nice to check validity of code in examples using CI.

+1017 -1556

0 comment

4 changed files

TETRA2000

pr closed time in 5 days

delete branch paularmstrong/normalizr

delete branch : dependabot/npm_and_yarn/examples/redux/qs-6.3.2

delete time in 5 days

push eventpaularmstrong/normalizr

dependabot[bot]

commit sha 93fc6ad4592ed67f2f86d0d07e8a8d18353cce54

chore: Bump qs from 6.3.0 to 6.3.2 in /examples/redux (#452) Bumps [qs](https://github.com/ljharb/qs) from 6.3.0 to 6.3.2. - [Release notes](https://github.com/ljharb/qs/releases) - [Changelog](https://github.com/ljharb/qs/blob/master/CHANGELOG.md) - [Commits](https://github.com/ljharb/qs/compare/v6.3.0...v6.3.2) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 5 days

PR merged paularmstrong/normalizr

Bump qs from 6.3.0 to 6.3.2 in /examples/redux dependencies

Bumps qs from 6.3.0 to 6.3.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ljharb/qs/blob/master/CHANGELOG.md">qs's changelog</a>.</em></p> <blockquote> <h2><strong>6.3.2</strong></h2> <ul> <li>[Fix] follow <code>allowPrototypes</code> option during merge (<a href="https://github-redirect.dependabot.com/ljharb/qs/issues/201">#201</a>, <a href="https://github-redirect.dependabot.com/ljharb/qs/issues/200">#200</a>)</li> <li>[Dev Deps] update <code>eslint</code></li> <li>[Fix] chmod a-x</li> <li>[Fix] support keys starting with brackets (<a href="https://github-redirect.dependabot.com/ljharb/qs/issues/202">#202</a>, <a href="https://github-redirect.dependabot.com/ljharb/qs/issues/200">#200</a>)</li> <li>[Tests] up to <code>node</code> <code>v7.7</code>, <code>v6.10</code>,<code> v4.8</code>; disable osx builds since they block linux builds</li> </ul> <h2><strong>6.3.1</strong></h2> <ul> <li>[Fix] ensure that <code>allowPrototypes: false</code> does not ever shadow Object.prototype properties (thanks, <a href="https://github.com/snyk">@snyk</a>!)</li> <li>[Dev Deps] update <code>eslint</code>, <code>@ljharb/eslint-config</code>, <code>browserify</code>, <code>iconv-lite</code>, <code>qs-iconv</code>, <code>tape</code></li> <li>[Tests] on all node minors; improve test matrix</li> <li>[Docs] document stringify option <code>allowDots</code> (<a href="https://github-redirect.dependabot.com/ljharb/qs/issues/195">#195</a>)</li> <li>[Docs] add empty object and array values example (<a href="https://github-redirect.dependabot.com/ljharb/qs/issues/195">#195</a>)</li> <li>[Docs] Fix minor inconsistency/typo (<a href="https://github-redirect.dependabot.com/ljharb/qs/issues/192">#192</a>)</li> <li>[Docs] document stringify option <code>sort</code> (<a href="https://github-redirect.dependabot.com/ljharb/qs/issues/191">#191</a>)</li> <li>[Refactor] <code>stringify</code>: throw faster with an invalid encoder</li> <li>[Refactor] remove unnecessary escapes (<a href="https://github-redirect.dependabot.com/ljharb/qs/issues/184">#184</a>)</li> <li>Remove contributing.md, since <code>qs</code> is no longer part of <code>hapi</code> (<a href="https://github-redirect.dependabot.com/ljharb/qs/issues/183">#183</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/ljharb/qs/commit/9ee56121311dac6b6014bfe56b3df0ebbf4ed048"><code>9ee5612</code></a> v6.3.2</li> <li><a href="https://github.com/ljharb/qs/commit/0a63fc8686bcc89d939522913762d1c6b1c4faa5"><code>0a63fc8</code></a> [Tests] up to <code>node</code> <code>v7.7</code>, <code>v6.10</code>,<code> v4.8</code>; disable osx builds since they b...</li> <li><a href="https://github.com/ljharb/qs/commit/8e1f3e743e81df157ccffea20b461ab6e499a795"><code>8e1f3e7</code></a> [Fix] support keys starting with brackets.</li> <li><a href="https://github.com/ljharb/qs/commit/febe81ad7e9120fab8db1897ec98c92297249a7c"><code>febe81a</code></a> [Fix] chmod a-x</li> <li><a href="https://github.com/ljharb/qs/commit/e54c5ec8e20e3beacddff4d775d1a29bcaa47dc1"><code>e54c5ec</code></a> [Dev Deps] update <code>eslint</code></li> <li><a href="https://github.com/ljharb/qs/commit/8e2af085b448eeb0b8068f4c7828e6a68c910058"><code>8e2af08</code></a> [Fix] follow <code>allowPrototypes</code> option during merge</li> <li><a href="https://github.com/ljharb/qs/commit/153ce84948845330d90178cbad982fc7371df538"><code>153ce84</code></a> v6.3.1</li> <li><a href="https://github.com/ljharb/qs/commit/d73b7a6cb2f0b2cfb0e73a6aeefde8cdcb521a98"><code>d73b7a6</code></a> [Dev Deps] update <code>eslint</code>, <code>@ljharb/eslint-config</code>, <code>browserify</code></li> <li><a href="https://github.com/ljharb/qs/commit/beade029171b8cef9cee0d03ebe577e2dd84976d"><code>beade02</code></a> [Fix] ensure that <code>allowPrototypes: false</code> does not ever shadow Object.protot...</li> <li><a href="https://github.com/ljharb/qs/commit/8bd4c6cf12898f469838980317fec92007e5112a"><code>8bd4c6c</code></a> Document allowDots option for stringify</li> <li>Additional commits viewable in <a href="https://github.com/ljharb/qs/compare/v6.3.0...v6.3.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -2

1 comment

1 changed file

dependabot[bot]

pr closed time in 5 days

push eventpaularmstrong/paularmstrong.dev

paularmstrong

commit sha 37ccaf2f570e880aab34491419fc80dc99e0fe79

Updates

view details

push time in 7 days

push eventpaularmstrong/paularmstrong.dev

Paul Armstrong

commit sha eb54683313df952ef66a04e9dec403fdf69c398a

feat: updates from livestream

view details

push time in 7 days

push eventpaularmstrong/paularmstrong.dev

paularmstrong

commit sha 049542a0d83d99214cea8b793fe7a5ce8bf3f12f

Updates

view details

push time in 17 days

push eventpaularmstrong/paularmstrong.dev

Paul Armstrong

commit sha 72b8a1e8d312dcf7502add2d41ee12508e6a0407

fix: typo in cname

view details

push time in 17 days

push eventpaularmstrong/paularmstrong.dev

paularmstrong

commit sha 7d1ce31e2efa26f73d5f33cce0bf4ae020831f8f

Updates

view details

push time in 17 days

push eventpaularmstrong/paularmstrong.dev

Paul Armstrong

commit sha d8e1a02dd871d0214e2b662f7328ab67aac9a581

chore: upgrade docusaurus

view details

push time in 17 days

push eventpaularmstrong/paularmstrong.dev

Paul Armstrong

commit sha 963c98de2e29786f58fc978a69eef4dd1b4d6b02

chore: upgrade docusaurus

view details

push time in 17 days

issue commenthome-assistant/iOS

macOS app becomes unresponsive

Happaned again. Found a sample Sample of Home Assistant.txt

paularmstrong

comment created time in 24 days

issue commenthome-assistant/iOS

macOS app becomes unresponsive

Okay, it's doing it again. I was clicking around between views in the dashboard and after one showed it suddenly froze.

No beachball in the app. Activity monitor looks fine

Screen Shot 2020-09-25 at 10 01 09 AM Screen Shot 2020-09-25 at 10 01 10 AM Screen Shot 2020-09-25 at 10 01 13 AM

I see a lot of this in the Console

Screen Shot 2020-09-25 at 10 02 39 AM

paularmstrong

comment created time in a month

issue commenthome-assistant/iOS

macOS app becomes unresponsive

Of course it cleared up after the app was closed for a few hours then reopened. I'll check when/if it happens again.

paularmstrong

comment created time in a month

issue commentampproject/meta-tsc

Freeze releases for US elections (weeks of Oct 26 & Nov 2)

+1 approval, including clarification of week leading up to and of election @mrjoro Could you amend this as start and end date for clarity?

mrjoro

comment created time in a month

issue openedhome-assistant/iOS

macOS app becomes unresponsive

<!-- Please READ THIS FIRST If your issue relates to something not looking right on Home Assistant within the Companion App, please check if the error is present in Safari on macOS too. If the issue is also seen in Safari, please open an issue on the frontend repo (https://github.com/home-assistant/frontend/issues/new?labels=bug&template=BUG_REPORT.md) instead -->

Device model, version and app version <!-- Please include your mac's model and version as listed in 'About This Mac'. Please also give the app version listed in the Home Assistant>About Home Assistant, please include the number in brackets -->

Model Name: MacBookPro 13-inch 2020 Software Version: OS X 10.15.6 App version: 2020.7 (2)

Home Assistant Core Version 0.115.2

Describe the bug The app does not respond to any click/mouse/keyboard input. System menus work fine, but nothing in the UI will respond. Accessing the same HA installation from a web browser works fine.

To Reproduce Unknown, but mine is stuck in this state, even after quit and re-open.

Expected behavior It does not become unresponsive

Screenshots N/A <!-- If applicable, add screenshots to help explain your problem. -->

Additional context <!--Add any other context about the problem here.-->

created time in a month

issue closedpaularmstrong/normalizr

How do I get the Schema key I define


 const nodeArraySchema = new schema.Array(nodeSchema)

 nodeArraySchema.key ---> 'nodes'

closed time in a month

collides

PR closed paularmstrong/normalizr

user entity updated to author for more clarity

Problem

In blog post, the user entity not used in sample JSON, however used in the normalizr code example

Solution

The user entity is changed to author for more clarity

TODO

  • [ ] Update relevant documentation
+6 -6

2 comments

1 changed file

faizanu94

pr closed time in 2 months

pull request commentpaularmstrong/normalizr

user entity updated to author for more clarity

@luccamordente is right, the original example is correct as both author and commenter are both the same user entity, just attached to different objects

faizanu94

comment created time in 2 months

pull request commentnecolas/react-native-web

Create RN components that relies on different dom elements

unstable_createElement already does what you're asking for. You're just going a hugely roundabout and unnecessary way. Here's an example SVG that I have: https://github.com/paularmstrong/build-tracker/blob/master/src/app/src/icons/ArrowLeft.tsx You don't need to set innerHtml or any of the extra stuff.

MatheusrdSantos

comment created time in 3 months

pull request commentampproject/meta-tsc

Add Kasiana to README

Just saw #44

paularmstrong

comment created time in 3 months

PR closed ampproject/meta-tsc

Reviewers
Add Kasiana to README
+1 -0

3 comments

1 changed file

paularmstrong

pr closed time in 3 months

pull request commentampproject/meta-tsc

Add Kasiana to README

@googlebot I signed it!

paularmstrong

comment created time in 3 months

PR opened ampproject/meta-tsc

Reviewers
Add Kasiana to README
+1 -0

0 comment

1 changed file

pr created time in 3 months

create barnchampproject/meta-tsc

branch : paularmstrong-patch-1

created branch time in 3 months

issue commentnecolas/react-native-web

Exporting types

flow-copy-source or DIY copy every file over to your dist directory and add .flow as the final extension. Probably also need to ensure // @flow is at the top of every file that supports types

necolas

comment created time in 3 months

issue commentnecolas/react-native-web

Exporting types

Ah, they're not exporting types, correct. I believe I had done something with the module.name_mapper to re-map to the src files. It worked out okay, but not everything was fully typed at the time. And the main index.js not having // @flow at the top was problematic as well.

I'm not as connected with that area of our code anymore, so I'm not certain what we have that's more strict. Maybe @comp615 has some thoughts on that.

The one thing that I've noticed that's really nice about the TypeScript types from react-native that I'm using in Build Tracker is that the StyleSheet props are fully typed and throws errors if you use a style that isn't allowed (like color on a View doesn't work, but will on Text). We definitely don't have that same level of strict typing in Flow.

necolas

comment created time in 3 months

issue commentnecolas/react-native-web

Exporting types

In Build Tracker (typescript, web-only), I pulled the react-native types from definitely-typed, then removed all of the iOS/Android specific stuff and added web-specific bits. Ideally I would take the few minutes to contribute this back, but I don't feel comfortable enough with my knowledge on Typescript to really be authoritative that any of it was done correctly.

At Twitter, we have our own flow definitions for react-native-web, but had built this up before this package was exporting most of its types. Ideally, we would love to use the source here, but have found that our type definitions tend to be more strict (which we like).

necolas

comment created time in 3 months

issue commenthassio-addons/addon-jupyterlab-lite

Web UI is not exposed

Maybe instead of closing this so quickly, we could have it added to the setup instructions?

paularmstrong

comment created time in 3 months

more