profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/otargetj2s/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

otargetj2s/PhpSpreadsheet 0

A pure PHP library for reading and writing spreadsheet files

pull request commentPHPOffice/PhpSpreadsheet

Fix for #2149 / Read data validations for drop down list in another sheet.

Thank you for this contribution: it may be reworked a bit as we work with the handling of namespaces in Xlsx files

I'm happy to have been able to contribute to this project. Thank you also to you.

otargetj2s

comment created time in a month

push eventotargetj2s/PhpSpreadsheet

Mark Baker

commit sha 05466e99ce2ec19750ba9373116bfbc07e69ae55

Html import dimension conversions (#2152) Allows basic column width conversion when importing from Html that includes UoM... while not overly-sophisticated in converting units to MS Excel's column width units, it should allow import without errors Also provides a general conversion helper class, and allows column width getters/setters to specify a UoM for easier usage

view details

Mark Baker

commit sha 9c2ce22505d6aea47dda520976d9982bc2b0c028

This should fix png files with transparency in the Xls reader (#2155) * This should fix png files with transparency in the Xls reader

view details

oleibman

commit sha b98b9c761c0a90f70ebdc533620e11b52329012c

Improve Identification of Samples in Coverage Report (#2153) The Phpunit coverage report currently contains bullet items like `PhpOffice\PhpSpreadsheetTests\Helper\SampleTest\testSample with data set "49"`. This extremely simple change takes advantage of Phpunit's ability to accept an array with keys which are either strings or integers, by using the sample filenames as the array keys rather than sequential but otherwise meaningless integers (e.g. `49` in the earlier cited item). The bullet item will now read `PhpOffice\PhpSpreadsheetTests\Helper\SampleTest\testSample with data set "Basic/38_Clone_worksheet.php"`.

view details

Mark Baker

commit sha 74b02fb31c9b3b72f7e1785ccfa19937bc1bea9f

Fix for the BIFF-8 Xls colour mappings in the Reader (#2156) * Fix for the BIFF-8 Xls colour mappings in the Reader * Unit test for reading colours, writing hen rereading and ensuring that the RGB values have not changed

view details

MarkBaker

commit sha 66cd68daeab53e921c65d77db4629a76cc233133

Update Change log

view details

Olivier TARGET

commit sha c2f409e524c0172ed7996ba8881d625c7d85ecb4

Merge branch 'master' into fix/externalDataValidations

view details

push time in a month

pull request commentPHPOffice/PhpSpreadsheet

Fix for #2149 / Read data validations for drop down list in another sheet.

I finished. I don't make any more changes.

otargetj2s

comment created time in 2 months

push eventotargetj2s/PhpSpreadsheet

Mark Baker

commit sha a911e9bb7bf6c83d91bab1035246ab56fd1a310b

Calculation engine empty arguments (#2143) * Initia work on differentiating between empty arguments and null arguments passed to Excel functions Previously we always passed a null value for an empty argument (i.e. where there was an argument separator in the function call without an argument.... PHP doesn't support empty arguments, so we needed to provide some value but then it wasn't possible to differentiate between a genuine null argument (either a literal null, or a null cell value) and the null that we were passing to represent an empty argument value. This change evaluates empty arguments within the calculation engine, and instead of passing a null, it reads the signature of the required Excel function, and passes the default value for that argument; so now a null argument really does mean a null value argument. * If the Excel function implementation doesn't accept any arguments; or once we reach a variadic argument, or try to pass more arguments than the method supports in its signature, then there's no point in checking for defaults, and to do so will lead to PHP errors, so break out of the default replacement loop

view details

Olivier TARGET

commit sha 9817cb2072991fdcf680de9c44eac9c5da5e7cb5

Merge branch 'master' into fix/externalDataValidations

view details

push time in 2 months

push eventotargetj2s/PhpSpreadsheet

Olivier TARGET

commit sha 48f831c7a1c8f203868ac38352d3a54f6cb138be

Modifiy call function isset() for warnings.

view details

push time in 2 months

pull request commentPHPOffice/PhpSpreadsheet

Fix for #2149 / Read data validations for drop down list in another sheet.

Without actually commenting on the substance of your change, it appears that your commit merely adds a block of commented out code. Did you mean to remove the comment marks? Also, is it possible to write a unit test which will show that your change operates as desired?

Sorry, i uncommented the code block. It was for test purpose. I never wrote any unit tests for PHP but i would be thankful to anyone to do it.

Finally, i have created the unit test and validated it successfully.

otargetj2s

comment created time in 2 months

push eventotargetj2s/PhpSpreadsheet

Olivier TARGET

commit sha 1a11128eb7b468beb997b96fa6e7186c9b980ccc

Add sample xlsx for unit tests.

view details

push time in 2 months

push eventotargetj2s/PhpSpreadsheet

Olivier TARGET

commit sha 2571c2fc38dc4991b122f24bbb3b955111b0035f

Add function testLoadXlsxDataValidationOfAnotherSheet() in class tests/PhpSpreadsheetTests/Reader/XlsxTest.php for unit test.

view details

push time in 2 months

pull request commentPHPOffice/PhpSpreadsheet

Fix for #2149 / Read data validations for drop down list in another sheet.

Without actually commenting on the substance of your change, it appears that your commit merely adds a block of commented out code. Did you mean to remove the comment marks? Also, is it possible to write a unit test which will show that your change operates as desired?

Sorry, i uncommented the code block. It was for test purpose. I never wrote any unit tests for PHP but i would be thankful to anyone to do it.

otargetj2s

comment created time in 2 months

push eventotargetj2s/PhpSpreadsheet

Olivier TARGET

commit sha bcb0ffa528c7d6dc791dce8040e25166ea6267a9

Read data validations for drop down list in another sheet.

view details

push time in 2 months

PR opened PHPOffice/PhpSpreadsheet

Read data validations for drop down list in another sheet.

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

  • [x] Changes are covered by unit tests
  • [x] Code style is respected
  • [ ] Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • [ ] CHANGELOG.md contains a short summary of the change
  • [ ] Documentation is updated as necessary

Why this change is needed?

This modification makes it possible to read the drop-down lists linked to other sheets. See issue #2149

+16 -0

0 comment

1 changed file

pr created time in 2 months

push eventotargetj2s/PhpSpreadsheet

Olivier TARGET

commit sha 498495ae77902c7edd32665d03f59fd19b531afb

Read data validations for drop down list in another sheet.

view details

push time in 2 months

create barnchotargetj2s/PhpSpreadsheet

branch : fix/externalDataValidations

created branch time in 2 months

fork otargetj2s/PhpSpreadsheet

A pure PHP library for reading and writing spreadsheet files

https://phpspreadsheet.readthedocs.io

fork in 2 months

issue commentPHPOffice/PhpSpreadsheet

Xlsx reader not recognize data validations that references another sheet - Again

See the following link for code correction : https://github.com/PHPOffice/PhpSpreadsheet/issues/1432#issuecomment-640028401

Can you do what's nessessary? I absolutely need it for my development. Thanks.

otargetj2s

comment created time in 2 months

issue openedPHPOffice/PhpSpreadsheet

Xlsx reader not recognize data validations that references another sheet - Again

This is:

- [x] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

Load the data validations that references lists of another sheet.

What is the current behavior?

return data validations with none type. Data not loaded for external list. This regression was reported in early 2018. Never merged.

See links : sample.xlsx

https://github.com/PHPOffice/PhpSpreadsheet/issues/388 https://github.com/PHPOffice/PhpSpreadsheet/issues/991 https://github.com/PHPOffice/PhpSpreadsheet/issues/1432

What are the steps to reproduce?

Create a xlsx file with a column with data validation that reference a list of another sheet, then load it in your code.

Please provide a Minimal, Complete, and Verifiable example of code that exhibits the issue without relying on an external Excel file or a web server:

<?php

require __DIR__ . '/vendor/autoload.php';

// Create new Reader and Spreadsheet object
$reader   = \PhpOffice\PhpSpreadsheet\IOFactory::createReader('Xlsx');
$spreadsheet = $reader->load('sample.xlsx');

// add code that show the issue here...

$spreadsheet->setActiveSheetIndexByName('Feuil1'); $worksheet = $spreadsheet->getActiveSheet();

// internal drop down list: success echo 'B5:DrowDownListType: ', $worksheet->getCell('B5')->getDataValidation()->getType(), "\n"; // external drop down list: failure, data not loaded echo 'B14:DrowDownListType: ', $worksheet->getCell('B14')->getDataValidation()->getType(), "\n";

Which versions of PhpSpreadsheet and PHP are affected?

phpspreadsheet >= 1.6.0 php >= 7.2

created time in 2 months

issue commentPHPOffice/PhpSpreadsheet

Data validation not working when opening & saving a file

UP !

Hello, This regression was reported in early 2018. The correction code is provided. In the end, this code is still not merged. Can you do what's nessessary? I absolutely need it for my development. Thanks.

See links : https://github.com/PHPOffice/PhpSpreadsheet/issues/388 https://github.com/PHPOffice/PhpSpreadsheet/issues/991 https://github.com/PHPOffice/PhpSpreadsheet/issues/1432

tntsoft

comment created time in 2 months