profile
viewpoint
Wei Wang onevcat LINE Corp. Kawasaki, Japan / China https://onev.cat iOS developer from China. Creator of @objccn and @swifter-tips

onevcat/APNGKit 1621

High performance and delightful way to play with APNG format in iOS.

objcio/core-data 676

Sample code for the objc.io Core Data book

MDCC2016/ProtocolNetwork 378

Sample project to show how to use protocol/extension to build a network layer

onevcat/DebuggableContext 99

Provides an easy to use action sheet for debugging purpose when shaking your iOS device.

onevcat/AddressParser 68

Email address parser.

onevcat/ClockFaceView 32

A demo project for my blog post

line/line-sdk-starter-ios-v2 25

A starter application that demonstrates how to use LINE SDK for iOS.

onevcat/DispatchMemoryLeakDemo 19

A demo that reproduce memory leak in iOS 9.2

onevcat/DateTimePicker 16

A nicer iOS UI component for picking date and time

push eventonevcat/Kingfisher

onevcat

commit sha 8458ae14f9fa129e20d6a4415463dc7f3e418f4e

Move `@objc` mark to function This resolves the library revolution error when building with Swift 5.1.3

view details

push time in 11 hours

release onevcat/Kingfisher

5.13.1

released time in 11 hours

created tagonevcat/Kingfisher

tag5.13.1

A lightweight, pure-Swift library for downloading and caching images from the web.

created time in 11 hours

push eventonevcat/Kingfisher

onevcat

commit sha 46bf251fee8ed426921c647790f08ca8ad0105a9

Bump version to 5.13.1

view details

push time in 11 hours

push eventonevcat/Kingfisher

onevcat

commit sha d2f79d9d2bfa7eb4d2f05f65c2208e09754b23b3

Update gems

view details

push time in 12 hours

PR opened Daltron/NotificationBanner

Mark `customView` as public

We need a way to get the customView back in some event delegate methods. However, it is now an internal property, which limits this possibility.

+1 -1

0 comment

1 changed file

pr created time in 16 hours

push eventonevcat/NotificationBanner

Wei Wang

commit sha 0955e8d166214c95f836d0972a2e949459e58e3e

Mark `customView` as public We need a way to get the `customView` back in some event delegate methods. However, it is now an `internal` property, which limits this possibility.

view details

push time in 16 hours

fork onevcat/NotificationBanner

The easiest way to display highly customizable in app notification banners in iOS

fork in 16 hours

push eventline/line-sdk-ios-swift

CJ Lin

commit sha 66c0361efb26cffc75aa6d24789f69e40ac7b409

Remove OneTimePassword

view details

CJ Lin

commit sha 3341f837a7f52c2415e1e61ba839b50d4e197025

Implement PKCE

view details

CJ Lin

commit sha e8d009622934704e3ac4938ee20bcbb6b616661c

Add PKCE unit test

view details

CJ Lin

commit sha d4c044f11a08941252c5ddd05759860bfd4893dc

Use `base64URLEncoded` directly

view details

CJ Lin

commit sha 69cca8a0e60c3877bb3dfba8000a9e2c03fc8fb8

Throwable PKCE code verifier generation

view details

CJ Lin

commit sha 78c073088ed2f2c493b3f884d096c23e6c0f870e

Revert "Throwable PKCE code verifier generation" This reverts commit 69cca8a0e60c3877bb3dfba8000a9e2c03fc8fb8.

view details

CJ Lin

commit sha ad9586d30456a01b2b3f9d43662af1aa856d8c1d

Make sure the code verifier generated successfully

view details

CJ Lin

commit sha 7ca73f7849847639e024d4c018dabaf540ea2e55

Use data format directly

view details

CJ Lin

commit sha 894ec8e3fd4ea7664f91966198508dec6ea1287b

Swift 4 compatible syntax

view details

CJ Lin

commit sha d08e925ff1d685eafceb4600076e32894a13dd04

Add documentation

view details

CJ Lin

commit sha ff73931fcd773d6aa2bdacb3a596db868712dfae

Fix warnings for Swift 5 compatibility

view details

CJ Lin

commit sha e76e5816d0369fb9df44218c9de7dd0deae025bb

Fix warnings for Swift 5 compatibility

view details

CJ Lin

commit sha 8b06c0e815d25752f9a8f52a0284e31f0ea0bd70

Merge branch 'master' into feature/PKCE

view details

CJ Lin

commit sha 722d3a642f637d88f4293a31ba0b0eca7294faa5

Adopt existing sha256 implementation

view details

CJ Lin

commit sha 23cbc0658b5b37f8dcc0ac45f1dba704726a6dc2

Extract randomData(bytesCount:) for easier reuse

view details

onevcat

commit sha 610b869d3fc7521f84c7d7fec3342deae2294ff1

Use encoded verifier to generate code challenge

view details

onevcat

commit sha 29c240cf59939e51c2f21cd57da41f30e7908518

Use random data for state and default nonce

view details

Wei Wang

commit sha 327680ade6a86a0efa800f3ff7df72e38f962f1e

Merge branch 'master' into feature/PKCE

view details

Wei Wang

commit sha f68e1676ddaae7e7b60d36b02534c7fccdf6d0c0

Merge pull request #133 from line/feature/PKCE Feature PKCE

view details

Wei Wang

commit sha 1ce30fed50d50b8396d5e4b54666dc566b7fbe46

Merge branch 'master' into feature/open-chat

view details

push time in 21 hours

push eventonevcat/Kingfisher

onevcat

commit sha c30c73f175ad7d47e1e03f2a72295dae72315b23

Remove unused variable

view details

Wei Wang

commit sha f8ef38da7edf554f40060d4a363743f270a57612

Merge pull request #1393 from onevcat/fix/issue-1392 Remove unused variable

view details

push time in a day

delete branch onevcat/Kingfisher

delete branch : fix/issue-1392

delete time in a day

PR merged onevcat/Kingfisher

Remove unused variable

This fixes #1392

+0 -1

0 comment

1 changed file

onevcat

pr closed time in a day

issue closedonevcat/Kingfisher

Warning when compiling with Swift 5.2

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

In ImageDrawing.swift let rowBytes = Int(CGFloat(cgImage.bytesPerRow)) the more stringent 5.2. compiler issues a warning:

Initialization of immutable value 'rowBytes' was never used; consider replacing with assignment to '_' or removing it

What

Should not issue warning

Reproduce

[The steps to reproduce this issue. What is the url you were trying to load, where did you put your code, etc.]

Other Comment

COCOAPODS: 1.9.0.beta.2 Kingfisher (5.13.0):

<!-- Love Kingfisher? Please consider supporting our collective: 👉 https://opencollective.com/Kingfisher/donate -->

closed time in a day

timbms

push eventonevcat/UniWebView-Docs

onevcat

commit sha ad9b9ddc88428aff9e9f003ad3839457b452b821

Update API ref

view details

push time in a day

issue commentonevcat/Kingfisher

Warning when compiling with Swift 5.2

This should be fixed in #1393

timbms

comment created time in 4 days

PR opened onevcat/Kingfisher

Remove unused variable

This fixes #1392

+0 -1

0 comment

1 changed file

pr created time in 4 days

create barnchonevcat/Kingfisher

branch : fix/issue-1392

created branch time in 4 days

pull request commentonevcat/Rainbow

I did not check, but maybe this will fix the SPM

After add Rainbow to package.json

Maybe you meant the Package.swift file instead of package.json?

And after adding the Rainbow in the dependency list, you also need to add it to your target. Here is a working Package.swift, can you try it?

// swift-tools-version:5.1
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
    name: "MyApp",
    dependencies: [
        // Dependencies declare other packages that this package depends on.
        // .package(url: /* package url */, from: "1.0.0"),
        .package(url: "https://github.com/onevcat/Rainbow.git", from: "3.0.0")
    ],
    targets: [
        // Targets are the basic building blocks of a package. A target can define a module or a test suite.
        // Targets can depend on other targets in this package, and on products in packages which this package depends on.
        .target(
            name: "MyApp",
            dependencies: ["Rainbow"]),  // <---- You also need to add the `Rainbow` here.
        .testTarget(
            name: "MyAppTests",
            dependencies: ["MyApp"]),
    ]
)
nerzh

comment created time in 5 days

pull request commentonevcat/Rainbow

I did not check, but maybe this will fix the SPM

@nerzh Thanks for the PR. But may I know what is the issue now?

I tried to add Rainbow through SPM in my mac and it seems everything is just working fine for the current released version.

Did you encounter any problem? Are there any reproducible steps for it?

nerzh

comment created time in 5 days

startedtwostraws/ControlRoom

started time in 5 days

delete branch line/line-sdk-ios-swift

delete branch : feature/PKCE

delete time in 6 days

push eventline/line-sdk-ios-swift

CJ Lin

commit sha 66c0361efb26cffc75aa6d24789f69e40ac7b409

Remove OneTimePassword

view details

CJ Lin

commit sha 3341f837a7f52c2415e1e61ba839b50d4e197025

Implement PKCE

view details

CJ Lin

commit sha e8d009622934704e3ac4938ee20bcbb6b616661c

Add PKCE unit test

view details

CJ Lin

commit sha d4c044f11a08941252c5ddd05759860bfd4893dc

Use `base64URLEncoded` directly

view details

CJ Lin

commit sha 69cca8a0e60c3877bb3dfba8000a9e2c03fc8fb8

Throwable PKCE code verifier generation

view details

CJ Lin

commit sha 78c073088ed2f2c493b3f884d096c23e6c0f870e

Revert "Throwable PKCE code verifier generation" This reverts commit 69cca8a0e60c3877bb3dfba8000a9e2c03fc8fb8.

view details

CJ Lin

commit sha ad9586d30456a01b2b3f9d43662af1aa856d8c1d

Make sure the code verifier generated successfully

view details

CJ Lin

commit sha 7ca73f7849847639e024d4c018dabaf540ea2e55

Use data format directly

view details

CJ Lin

commit sha 894ec8e3fd4ea7664f91966198508dec6ea1287b

Swift 4 compatible syntax

view details

CJ Lin

commit sha d08e925ff1d685eafceb4600076e32894a13dd04

Add documentation

view details

CJ Lin

commit sha ff73931fcd773d6aa2bdacb3a596db868712dfae

Fix warnings for Swift 5 compatibility

view details

CJ Lin

commit sha e76e5816d0369fb9df44218c9de7dd0deae025bb

Fix warnings for Swift 5 compatibility

view details

CJ Lin

commit sha 8b06c0e815d25752f9a8f52a0284e31f0ea0bd70

Merge branch 'master' into feature/PKCE

view details

CJ Lin

commit sha 722d3a642f637d88f4293a31ba0b0eca7294faa5

Adopt existing sha256 implementation

view details

CJ Lin

commit sha 23cbc0658b5b37f8dcc0ac45f1dba704726a6dc2

Extract randomData(bytesCount:) for easier reuse

view details

onevcat

commit sha 610b869d3fc7521f84c7d7fec3342deae2294ff1

Use encoded verifier to generate code challenge

view details

onevcat

commit sha 29c240cf59939e51c2f21cd57da41f30e7908518

Use random data for state and default nonce

view details

Wei Wang

commit sha 327680ade6a86a0efa800f3ff7df72e38f962f1e

Merge branch 'master' into feature/PKCE

view details

Wei Wang

commit sha f68e1676ddaae7e7b60d36b02534c7fccdf6d0c0

Merge pull request #133 from line/feature/PKCE Feature PKCE

view details

push time in 6 days

PR merged line/line-sdk-ios-swift

Feature PKCE
+131 -162

2 comments

10 changed files

onevcat

pr closed time in 6 days

push eventline/line-sdk-ios-swift

onevcat

commit sha dba5b2ea6cbf0ad99aa6c090bb5d6154b015c7f3

Update changelog

view details

push time in 6 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 14252bb0d12fe144fc9f880ee2e420ce46ac91d4

Add some missing docs

view details

push time in 6 days

issue commentonevcat/Kingfisher

aws s3 image processing swift

I am not quite familiar with AWS S3 bucket myself. But according to this doc it seems that you may need an Authorization header in the request to get a protected resource.

What are you doing now? Are you using any other SDK or how did you download the images now?

Anil-093

comment created time in 6 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 85350eaefa1cfa0ef532def088a2c03e564e316b

Fix doc format

view details

onevcat

commit sha f49fdbf848cbbb5b5f3092f27e5e9086a33eee47

Add documentation for movdel and request

view details

push time in 8 days

issue closedonevcat/Kingfisher

Encrypted gif put through preprocessor does not animate when retrieved from disk [Possible answer found]

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

What

I am retrieving encrypted image data from a server and need to apply a processor. On first retrieval and memory cache fetches it works perfectly. However, when disk caching is enabled the image does not animate, although the first frame displays just fine.

Reproduce

  1. Create some type of encrypted or garbled gif image data
  2. Apply a custom processor that decrypts/de-garbles the gif image data
  3. Observe gif animates fine on first retrieval and memory cache fetches
  4. Close and reopen app. Observe disk caches fail to return an animated gif

Other Comment

I've been playing with a lot of different settings to no avail. I went into the code in hopes of finding an answer but haven't found anythign that works. I tried telling it to cache the original image and gave my preprocessor a UUID thinking maybe it could store/fetch the original and just keep processing it every time needed, but that led to a fatalError on an assertion because the original wasnt available by the anticipated caching key. I didn't quite understand why that happened.

Thanks for your time and consideration.

<!-- Love Kingfisher? Please consider supporting our collective: 👉 https://opencollective.com/Kingfisher/donate -->

closed time in 10 days

bitwit

issue commentonevcat/Kingfisher

Encrypted gif put through preprocessor does not animate when retrieved from disk [Possible answer found]

The default cache serializer will try to look at the original downloaded data to determine the image format, and respect the original format to store the image on disk. It fails on judging the format because the original data is encrypted but not a GIF. That is why the cacheSerializer(FormatIndicatedCacheSerializer.gif) works for you.

bitwit

comment created time in 10 days

pull request commentonevcat/Kingfisher

Feature / CommonCrypto implementation of MD5

Thanks for the PR! It totally makes sense. But if you check the history of the String+MD5.swift file, you will find that it was using CC_MD5 when calculating MD5 hash. However, Xcode gives us a warning on that:

This function is cryptographically broken and should not be used in security contexts. Clients should migrate to SHA256 (or stronger).

It is the fact that MD5 is not for crypto purposes anymore, but I believe it is still serving well in Kingfisher for a file hashing purpose. However, there is no way (as I know) to ignore this warning.

The result, in turn, makes CocoaPods unhappy since a warning would prevent pushing to pod spec, unless we ignore all warnings. I don't like that.

So a customized implementation of MD5 is used here. Maybe we can migrate to another digest way like SHA256, but it breaks the current cache totally so we can only do it in the next major release.

By the way, it is not that fair to do performance test like that. The compiled CommonCrypto is highly optimized, but the customized MD5 is compiled in Debug mode without optimization (I guess you are just running these tests with -Onone?) It would slower than the pure C implementation, but since the algorithm is the same, I think the gap between them would be smaller.

Any improvement which not triggering a warning is welcome, but I am sorry replacing it with the deprecated CC_MD5 is not an option unless we can find a way to suppress the warning.

Adobels

comment created time in 11 days

push eventonevcat/Kingfisher

onevcat

commit sha 7a76183eb0091a7ae1f77ce5c745cc3b442a8bb3

Add Cartfile.project

view details

onevcat

commit sha b126b06c21274ab9d13f94564f575974b5e4d0fd

Fix doc

view details

push time in 11 days

push eventline/line-sdk-ios-swift

CJ Lin

commit sha 384f7d92bbda0c150ce863fbb473b7aa3d3e56e2

Extract common digest algorithm logic

view details

Wei Wang

commit sha 4a14de85701d32e14f367daaa3d947e3d437b612

Merge pull request #134 from eJamesLin/feature/ExtractDigestAlgorithm Extract common digest algorithm logic

view details

wouter-veeken

commit sha 240d5a0776478152c6df87d01228157ca5da8372

Improve `allowRecreatingLoginProcess` description

view details

Wei Wang

commit sha 8d0e0b4fd53574c84b008d452518899b43d8eb58

Update LineSDKError.swift

view details

Wei Wang

commit sha 6e53ff087287dc5cfd773dc69a5dd79f78ee7981

Merge pull request #135 from wouter-veeken/5.5.0-review-code-comments Improve `allowRecreatingLoginProcess` description

view details

onevcat

commit sha b18bbbcbf2646f36c4657d11067e5ea89def021c

Fix doc exclude path for sharing UI

view details

Wei Wang

commit sha 2b2676f20d17989adb13d891c38f05eaff9c4a66

Merge pull request #136 from line/fix/doc-exclude-path Fix doc exclude path for sharing UI

view details

CJ Lin

commit sha 33d0bb12757560b0c79e53b6ec2121cfda2821a1

Implement `randomData(bytesCount:)` to generate cryptographically random

view details

CJ Lin

commit sha e2398134771ff6320ade82e307679dd2c7b5769b

Cherry Pick - Use random data for state and default nonce

view details

onevcat

commit sha a39a2c13184c42e419328a5253ca3c0c1f9bb906

Fix duplicated generated doc for `allowRecreatingLoginProcess`

view details

onevcat

commit sha a9a3be65457812fc0d05aec02c3c72c601a64b3b

API is now not a struct anymore

view details

onevcat

commit sha 562f961b6ff7589bb32e4ec2ab8dd6916aa3778f

Remove Result from public doc since it is now a part of Swift

view details

onevcat

commit sha bd2dfe7c64ebbfd8826c2fbdc27faab19597cf02

Add deprecate warnings

view details

wouter-veeken

commit sha c23acfee9cf137e713b6a986922df65efc06e41e

Fix code comments Improved some wordings and fixed some formatting.

view details

Wei Wang

commit sha 3fc8bab3e218a5450b93e6a3975a6b0cb590928a

Merge pull request #139 from wouter-veeken/fix/doc-improvement-wouter Fix code comments

view details

Wei Wang

commit sha 395f8d4c89e879b4f7b4039dc78b2b19a896cb0a

Merge pull request #138 from line/fix/doc-improvement Improve documentation

view details

Wei Wang

commit sha d077debe9ab64c8665047e0d2d643955580b3e09

Merge pull request #137 from eJamesLin/feature/RandomDataGenerator Random data generator

view details

onevcat

commit sha e384a08fe203f2be2551862f14e3316e8e892222

Merge branch 'master' into feature/open-chat

view details

push time in 11 days

push eventline/line-sdk-ios-swift

onevcat

commit sha d7523356e1b96898e7adeb807a35e61916fcbe63

Add chat room status and membership state to API helper

view details

push time in 11 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

Yes. After that, you need to run pod install in the folder.

kultie

comment created time in 12 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

Carthage will build the framework when exporting, so you do not have to build it again in Xcode. While CocoaPods only copies the source code to the project instead of building them (the source will be built with the Xcode project).

Our Carthage integration contains build cache in the target folder, so if you are not doing a full clean export in Unity, but do an append, would boost the build a lot.

For your original issue, as I mentioned, LINE SDK only supports with building as dynamic framework, so you may need use_framework! in the Podfile.

LineSDK requires to be built as a dynamic framework instead of a static one now. So maybe you can try to add use_frameworks! to your Podfile.

kultie

comment created time in 12 days

push eventonevcat/UniWebView-Docs

onevcat

commit sha aa7d4027ed4dfe152405d3e047e4bd8858b0e4ad

Update doc

view details

push time in 12 days

issue commentonevcat/vno-jekyll

该博客存在xss跳转漏洞

Markdown 和 HTML 本身就是可以兼容混编的,你可以尝试一下用 “`” 把这行括起来。

MemoryOfSnow

comment created time in 12 days

push eventline/line-sdk-ios-swift

onevcat

commit sha b18bbbcbf2646f36c4657d11067e5ea89def021c

Fix doc exclude path for sharing UI

view details

Wei Wang

commit sha 2b2676f20d17989adb13d891c38f05eaff9c4a66

Merge pull request #136 from line/fix/doc-exclude-path Fix doc exclude path for sharing UI

view details

CJ Lin

commit sha 33d0bb12757560b0c79e53b6ec2121cfda2821a1

Implement `randomData(bytesCount:)` to generate cryptographically random

view details

CJ Lin

commit sha e2398134771ff6320ade82e307679dd2c7b5769b

Cherry Pick - Use random data for state and default nonce

view details

onevcat

commit sha a39a2c13184c42e419328a5253ca3c0c1f9bb906

Fix duplicated generated doc for `allowRecreatingLoginProcess`

view details

onevcat

commit sha a9a3be65457812fc0d05aec02c3c72c601a64b3b

API is now not a struct anymore

view details

onevcat

commit sha 562f961b6ff7589bb32e4ec2ab8dd6916aa3778f

Remove Result from public doc since it is now a part of Swift

view details

onevcat

commit sha bd2dfe7c64ebbfd8826c2fbdc27faab19597cf02

Add deprecate warnings

view details

wouter-veeken

commit sha c23acfee9cf137e713b6a986922df65efc06e41e

Fix code comments Improved some wordings and fixed some formatting.

view details

Wei Wang

commit sha 3fc8bab3e218a5450b93e6a3975a6b0cb590928a

Merge pull request #139 from wouter-veeken/fix/doc-improvement-wouter Fix code comments

view details

Wei Wang

commit sha 395f8d4c89e879b4f7b4039dc78b2b19a896cb0a

Merge pull request #138 from line/fix/doc-improvement Improve documentation

view details

Wei Wang

commit sha d077debe9ab64c8665047e0d2d643955580b3e09

Merge pull request #137 from eJamesLin/feature/RandomDataGenerator Random data generator

view details

Wei Wang

commit sha 327680ade6a86a0efa800f3ff7df72e38f962f1e

Merge branch 'master' into feature/PKCE

view details

push time in 13 days

push eventline/line-sdk-ios-swift

CJ Lin

commit sha 33d0bb12757560b0c79e53b6ec2121cfda2821a1

Implement `randomData(bytesCount:)` to generate cryptographically random

view details

CJ Lin

commit sha e2398134771ff6320ade82e307679dd2c7b5769b

Cherry Pick - Use random data for state and default nonce

view details

Wei Wang

commit sha d077debe9ab64c8665047e0d2d643955580b3e09

Merge pull request #137 from eJamesLin/feature/RandomDataGenerator Random data generator

view details

push time in 13 days

PR merged line/line-sdk-ios-swift

Reviewers
Random data generator

About

  • Extract the randomData(bytesCount:) from PKCE PR https://github.com/line/line-sdk-ios-swift/pull/133
  • Cherry-pick the randomData(bytesCount:) adoption to state and default nonce https://github.com/line/line-sdk-ios-swift/commit/29c240cf59939e51c2f21cd57da41f30e7908518
  • In this way, the PR could focus on single change
+17 -3

0 comment

2 changed files

eJamesLin

pr closed time in 13 days

delete branch line/line-sdk-ios-swift

delete branch : fix/doc-improvement

delete time in 13 days

push eventline/line-sdk-ios-swift

onevcat

commit sha a39a2c13184c42e419328a5253ca3c0c1f9bb906

Fix duplicated generated doc for `allowRecreatingLoginProcess`

view details

onevcat

commit sha a9a3be65457812fc0d05aec02c3c72c601a64b3b

API is now not a struct anymore

view details

onevcat

commit sha 562f961b6ff7589bb32e4ec2ab8dd6916aa3778f

Remove Result from public doc since it is now a part of Swift

view details

onevcat

commit sha bd2dfe7c64ebbfd8826c2fbdc27faab19597cf02

Add deprecate warnings

view details

wouter-veeken

commit sha c23acfee9cf137e713b6a986922df65efc06e41e

Fix code comments Improved some wordings and fixed some formatting.

view details

Wei Wang

commit sha 3fc8bab3e218a5450b93e6a3975a6b0cb590928a

Merge pull request #139 from wouter-veeken/fix/doc-improvement-wouter Fix code comments

view details

Wei Wang

commit sha 395f8d4c89e879b4f7b4039dc78b2b19a896cb0a

Merge pull request #138 from line/fix/doc-improvement Improve documentation

view details

push time in 13 days

push eventline/line-sdk-ios-swift

wouter-veeken

commit sha c23acfee9cf137e713b6a986922df65efc06e41e

Fix code comments Improved some wordings and fixed some formatting.

view details

Wei Wang

commit sha 3fc8bab3e218a5450b93e6a3975a6b0cb590928a

Merge pull request #139 from wouter-veeken/fix/doc-improvement-wouter Fix code comments

view details

push time in 13 days

PR merged line/line-sdk-ios-swift

Fix code comments

Improved some wordings and fixed some formatting.

+6 -7

0 comment

1 changed file

wouter-veeken

pr closed time in 13 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 3b7d4143444ace46fae79498e96313090d70399c

Do not prevent default alert when term not agreed

view details

push time in 13 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

Thanks for the feedback. I will investigate it deeper to see what is going on.

kultie

comment created time in 13 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

Ummm. So there is still something wrong with the Ruby environment but I am not sure what it could be.

Could you navigate to the exported folder and find if there are two files "Gemfile" and "copy_carthage_framework.rb" in that folder?

If there are, you can try to manually execute the command below to make the Xcode project happy. (This is exactly what LINE SDK tries to do after copying the necessary files to the build folder.)

gem install bundler --no-document
bundle install --path vendor/bundle
bundle exec ruby copy_carthage_framework.rb

Please let me know if there are still some errors, and also the log.

kultie

comment created time in 13 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

@kultie Hey, can you try the version 1.1.1 and see whether it works? You can find it on the release page here: https://github.com/line/line-sdk-unity/releases/tag/1.1.1

kultie

comment created time in 13 days

release line/line-sdk-unity

1.1.1

released time in 13 days

created tagline/line-sdk-unity

tag1.1.1

Provides a modern way of implementing LINE APIs in Unity games, for iOS and Android.

created time in 13 days

push eventline/line-sdk-unity

onevcat

commit sha 0840556af307dbbd104820652113ce9e509cfd2f

Update changelog

view details

push time in 13 days

push eventline/line-sdk-unity

onevcat

commit sha 92dd0c711ec5c38d9e739af0576d1dda2a755c7a

Stop using deprecated install flag The `--no-ri` and `--no-rdoc` was removed from Gem version 3 so it caused a failure when building with Carthage

view details

push time in 13 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

Oh.

It seems that --no-rdoc and --no-ri are totally removed from gem version 3.

Let me check what I can do and maybe soon we can release a new version.

kultie

comment created time in 13 days

issue closedtypora/typora-issues

Strange behaviors when Undo for the first time after saving in the Source Mode

What

As title. I also attached a video for this problem. There are two patterns:

  1. The text is hidden when performing "Undo" after saving

https://www.dropbox.com/s/i0l4gxdd4y5ikob/%E5%B1%8F%E5%B9%95%E5%BD%95%E5%88%B62019-12-2823.25.46.mov?dl=0

  1. The file is scrolled to top when performing "Undo" after saving

https://www.dropbox.com/s/in84dj8fso6cz0p/%E5%B1%8F%E5%B9%95%E5%BD%95%E5%88%B62019-12-2823.32.12.mov?dl=0

Steps

  1. Open a file.
  2. Switch to the Source Mode.
  3. Add some text anywhere.
  4. Save the file with Command+S.
  5. Perform an Undo with Command+Z.

Expected

A standard Undo behavior. The added text should be reverted.

Actual

All text is hidden or the file is scrolled to the top, as the videos above show.

Environment

  • MacBook Pro (15-inch, 2018)
  • macOS 10.15.2 (19C57)
  • Typora 0.9.9.31.2 (3946) (But I noticed this issue for quite a while, so it also happens in earlier versions.)

Note

  • The issue does not happen unless I do a save before undo. If I perform Undo directly without saving, everything works fine.
  • It happens at a 100% rate.
  • If I keep doing undo multiple times, it can recover to the normal state.
  • In case you want the content in the video, it is here: https://gist.github.com/onevcat/a7ef0d562d2693b084fc8358bc01f890

closed time in 13 days

onevcat

issue commenttypora/typora-issues

Strange behaviors when Undo for the first time after saving in the Source Mode

Both the original issue and the new save hanging are fixed! Thank you!

onevcat

comment created time in 13 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

And you can also use gem env in that folder to see the gem environment currently in use.

kultie

comment created time in 13 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

Hi, it seems that you are still using the system ruby instead of the one managed by rvm in your folder. Our Carthage integration requires a local version of Ruby environment. Can you check the ruby version and path you are using (ruby -v and which ruby) in the exported project folder?

kultie

comment created time in 13 days

PR opened line/line-sdk-ios-swift

Improve documentation
+35 -74

0 comment

7 changed files

pr created time in 14 days

create barnchline/line-sdk-ios-swift

branch : fix/doc-improvement

created branch time in 14 days

delete branch line/line-sdk-ios-swift

delete branch : fix/doc-exclude-path

delete time in 14 days

push eventline/line-sdk-ios-swift

onevcat

commit sha b18bbbcbf2646f36c4657d11067e5ea89def021c

Fix doc exclude path for sharing UI

view details

Wei Wang

commit sha 2b2676f20d17989adb13d891c38f05eaff9c4a66

Merge pull request #136 from line/fix/doc-exclude-path Fix doc exclude path for sharing UI

view details

push time in 14 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 610b869d3fc7521f84c7d7fec3342deae2294ff1

Use encoded verifier to generate code challenge

view details

onevcat

commit sha 29c240cf59939e51c2f21cd57da41f30e7908518

Use random data for state and default nonce

view details

push time in 14 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

Oh,

I saw your sample project.

It seems that Facebook is using PlayServicesResolver contained in their package to manage the pod dependency.

May I know how did you add the pod 'LineSDKSwift/ObjC', '~> 5.1' to your Podfile? Or is it also managed by the PlayServicesResolver plugin?

LineSDK requires to be built as a dynamic framework instead of a static one now. So maybe you can try to add use_frameworks! to your Podfile. However, I am not sure whether it would break the Facebook integrating or not.

Another easier choice might be using the Carthage instead of CocoaPods when installing LINE SDK. You can find more information from this section: https://developers.line.biz/zh-hant/docs/unity-sdk/project-setup/#installation-on-ios

and change the export method to "Carthage": https://developers.line.biz/zh-hant/docs/unity-sdk/integrate-line-login/#update-player-settings

kultie

comment created time in 14 days

issue commentline/line-sdk-unity

iOS Build: Undefined symbols for architecture armv7 after import facebook sdk 7.18

LINE SDK is using Swift, so you need to make sure the ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES is true in your exported Xcode project.

LINE SDK for Unity contains a script to do it automatically, but in your case, it might be overwritten by some other SDK (such as Facebook). Can you check the ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES in your Xcode project Build Setting tab?

kultie

comment created time in 14 days

pull request commentline/line-sdk-ios-swift

Feature PKCE

LGTM

onevcat

comment created time in 15 days

pull request commentline/line-sdk-ios-swift

Feature PKCE

LGTM! Let's wait for server implementation then we can merge it.

onevcat

comment created time in 15 days

Pull request review commentline/line-sdk-ios-swift

Feature PKCE

+//+//  PKCE.swift+//+//  Copyright (c) 2016-present, LINE Corporation. All rights reserved.+//+//  You are hereby granted a non-exclusive, worldwide, royalty-free license to use,+//  copy and distribute this software in source code or binary form for use+//  in connection with the web services and APIs provided by LINE Corporation.+//+//  As with any software that integrates with the LINE Corporation platform, your use of this software+//  is subject to the LINE Developers Agreement [http://terms2.line.me/LINE_Developers_Agreement].+//  This copyright notice shall be included in all copies or substantial portions of the software.+//+//  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,+//  INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,+//  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.+//  IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,+//  DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,+//  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.+//++import Foundation+import Security+import CommonCrypto++struct PKCE {+    var codeVerifier: String {+        return codeVerifierData.base64URLEncoded+    }++    var codeChallenge: String {+        return PKCE.generateCodeChallenge(codeVerifier: codeVerifierData)+    }++    /// If the client is capable of using "S256", it MUST use "S256", as+    /// "S256" is Mandatory To Implement (MTI) on the server.+    /// Ref: https://tools.ietf.org/html/rfc7636#section-4.2+    var codeChallengeMethod: String {+        return "S256"+    }++    private let codeVerifierData: Data++    init() {+        codeVerifierData = PKCE.generateCodeVerifier()+    }++    /// Code Verifier+    /// The code verifier SHOULD have enough entropy to make it+    /// impractical to guess the value.  It is RECOMMENDED that the output of+    /// a suitable random number generator be used to create a 32-octet+    /// sequence. The octet sequence is then base64url-encoded to produce a+    /// 43-octet URL safe string to use as the code verifier.+    ///+    /// Ref: https://tools.ietf.org/html/rfc7636#section-4.1+    ///+    static func generateCodeVerifier() -> Data {+        var bytes = [UInt8](repeating: 0, count: 32)+        let status = SecRandomCopyBytes(kSecRandomDefault, bytes.count, &bytes)

Yes. I think 32 bytes of random data should be totally fine here!

onevcat

comment created time in 15 days

pull request commentline/line-sdk-ios-swift

Feature open chat

This makes a strong assumption that the server can always return the correct format for these IDs, and does not make a change in future. Otherwise, the client would suffer from a crash.

onevcat

comment created time in 15 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 20b5a8c76868de970e9390cd128205319aad6e86

Fix CI on older Xcode versions

view details

push time in 15 days

pull request commentline/line-sdk-ios-swift

Feature open chat

@stypr Thanks for pointing it out. Should be fixed in the latest commit https://github.com/line/line-sdk-ios-swift/pull/132/commits/b0f6e2d7d8ab6f6fd7b8922c782833ff4f6828ae

onevcat

comment created time in 15 days

push eventline/line-sdk-ios-swift

onevcat

commit sha b0f6e2d7d8ab6f6fd7b8922c782833ff4f6828ae

Check request parameter in path

view details

push time in 15 days

issue commentonevcat/Kingfisher

failed to implement Kingfisher by carthage

50B56DF3-3270-4359-A11B-DEA7534CF6D1

According to this, Xcode 10.1 ships with Swift 4.2.4. But your Carthage is using Swift 5.0.1 when building Kingfisher. I suggest you check and make sure you are using the same Xcode version and command line tool version.

sariminapp

comment created time in 18 days

issue commentonevcat/Kingfisher

failed to implement Kingfisher by carthage

It is normal to skip the prebuilt framework and fallback to a source build. Does the build finishes without problem? Are you still getting the same ABI error when linking?

I am afraid it is not probably a problem in Kingfisher, but the environment of your machine and tool chain issue...

sariminapp

comment created time in 18 days

issue commentonevcat/Kingfisher

failed to implement Kingfisher by carthage

Ummm, I guess it might be something related to the SwiftUI support of Kingfisher. Xcode 10 does not have an idea of how to build the lastest version of Kingfisher. Can you try to restrict the version of Kingfisher like this in your Cartfile, before you have a chance to upgrade to Xcode 11?

github "onevcat/Kingfisher" == 5.7.0
sariminapp

comment created time in 18 days

issue commentonevcat/Kingfisher

failed to implement Kingfisher by carthage

Any chance to try how it can work in a new project with the same steps? BTW, may I know the Xcode version and carthage version you are using?

Thanks!

sariminapp

comment created time in 18 days

issue commentonevcat/Kingfisher

failed to implement Kingfisher by carthage

Do you have multiple Xcode versions installed? Are you using the same version of Xcode command line tool as the Xcode you are opening to add Kingfisher?

sariminapp

comment created time in 18 days

GollumEvent

pull request commentnsoperations/Carthage

Recover from a symbol mapper error

Great to know it. Thanks for your kind suggestion! I will try. :P

onevcat

comment created time in 19 days

create barnchline/line-sdk-ios-swift

branch : fix/doc-exclude-path

created branch time in 19 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 0be9595e346ac24ea5658015c27d7f63b6a81619

Update translated strings

view details

push time in 19 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 3ddf2aa895cfbdf981cbaa96afdfa4399064b798

Make open chat feature compatible with Objective-C

view details

push time in 19 days

push eventline/line-sdk-ios-swift

onevcat

commit sha cb632a44aea237360ba5e803742430d5e66732da

Remove unused request

view details

onevcat

commit sha 3c6e79232df1e2e934fc006f57df4240bbb9b029

Update localization key

view details

push time in 19 days

PR closed nsoperations/Carthage

Recover from a symbol mapper error

I am not sure it is a correct fix for a general case. But it enables ours to build without problem.

Our case

  1. We are using prebuilt-framework of carthage (carthage archive) to boost dependency.
  2. We created the .zip file and put it to a private GitHub repo.
  3. But we do not want to put the source there. All what we want to do is downloading the prebuilt binaries.
  4. The binary-only framework does not work for us, since we do not find a private place to store it. So we choose the carthage prebuilt-framework without source files.

What happens

When doing a carthage bootstrap, it skips binary installing:

Skipped installing OurFramework.framework binary: No matching binary found

After some investigation, the problem is that when copying dSYM to the destination folder, there is a DebugSymbolsMapper phase if the dependencySourceURL is there.

The dependencySourceURL is actually existing since we are hosting a repo on GitHub and it is checked out. However, there is no source code in that folder, the symbol mapper fails and throws an error.

Fix

Maybe it makes sense to treat the mapper as an optional step and recover the error to a happy path. We can also add some warnings to let users know a potential issue happens. But failing the whole process only due to the mapper failure is too strict for our case.

Maybe there is another way to check whether it is a binary-only project, like checking if there is a scheme in the dependencySourceURL to build. But I am not sure how.

+1 -0

2 comments

1 changed file

onevcat

pr closed time in 19 days

pull request commentnsoperations/Carthage

Recover from a symbol mapper error

Thanks for the reply. I got your idea and will have a try!

onevcat

comment created time in 19 days

PR opened nsoperations/Carthage

Recover from a symbol mapper error

I am not sure it is a correct fix for our case. But it enables ours to build without problem

Our case

  1. We are using prebuilt-framework of carthage (carthage archive) to boost dependency.
  2. We created the .zip file and put it to a private GitHub repo.
  3. But we do not want to put the source there. All what we want to do is downloading the prebuilt binaries.
  4. The binary-only framework does not work for us, since we do not find a private place to store it. So we choose the carthage prebuilt-framework without source files.

What happens

When doing a carthage bootstrap, it skips binary installing:

Skipped installing OurFramework.framework binary: No matching binary found

After some investigation, the problem is that when copying dSYM to the destination folder, there is a DebugSymbolsMapper phase if the dependencySourceURL is there.

The dependencySourceURL is actually existing since we are hosting a repo on GitHub and it is checked out. However, there is no source code in that folder, the symbol mapper fails and throws an error.

Fix

Maybe it makes sense to treat the mapper as an optional step and recover the error to a happy path. We can also add some warnings to let users know a potential issue happens. But failing the whole process only due to the mapper failure is too strict for our case.

Maybe there is another way to check whether it is a binary-only project, like checking if there is a scheme in the dependencySourceURL to build. But I am not sure how.

+1 -0

0 comment

1 changed file

pr created time in 21 days

push eventonevcat/Carthage

Wei Wang

commit sha 99c485c829ea9541b8cc6bf74c0435698e494106

Recover from a symbol mapper error

view details

push time in 21 days

push eventonevcat/Carthage

Wei Wang

commit sha 83759707220aa843a93c9ecc2f609bd9ab3e8938

Remove dSYM mapping for binary moving

view details

push time in 21 days

fork onevcat/Carthage

A simple, decentralized dependency manager for Cocoa

fork in 21 days

push eventline/line-sdk-ios-swift

wouter-veeken

commit sha 240d5a0776478152c6df87d01228157ca5da8372

Improve `allowRecreatingLoginProcess` description

view details

Wei Wang

commit sha 8d0e0b4fd53574c84b008d452518899b43d8eb58

Update LineSDKError.swift

view details

Wei Wang

commit sha 6e53ff087287dc5cfd773dc69a5dd79f78ee7981

Merge pull request #135 from wouter-veeken/5.5.0-review-code-comments Improve `allowRecreatingLoginProcess` description

view details

push time in 21 days

push eventwouter-veeken/line-sdk-ios-swift

Wei Wang

commit sha 8d0e0b4fd53574c84b008d452518899b43d8eb58

Update LineSDKError.swift

view details

push time in 21 days

PR opened coteditor/CotEditor

Update zh-Hans translation
+5 -5

0 comment

4 changed files

pr created time in 22 days

push eventonevcat/CotEditor

onevcat

commit sha b0986db15ded27434dbc644f720b93c80c6a68fe

Update zh-Hans translation

view details

push time in 22 days

push eventonevcat/CotEditor

1024jp

commit sha 14bfd6402fd4ea1250c7573d5f682cd2b91d1a25

Highlight regex also in field editor

view details

1024jp

commit sha 95ab140ff61b3f756d72f60562e5abe82c87cceb

Extract highlightAsRegularExpressionPattern(mode:)

view details

1024jp

commit sha 707a0575218f7dfd3a7b706c9bfb0b8b05baf4d8

Remove DynamicRegexField

view details

1024jp

commit sha e95f6642b596f45f3159efe54800f6c5a25ea6e0

Highlight regex in custom sort sheet

view details

1024jp

commit sha ac147cefbc297318c38e6e664531ccd554f05581

Merge pull request #883 from J-rg/develop Update German localization

view details

1024jp

commit sha b9b8452e03f5277e4c6c65b57c3fd5a5d26c1545

Set regex option when validate multi-replacement regex

view details

1024jp

commit sha 972247a397898af7c01345576c1097dfdc377d97

Refactor InvisibleFormatter

view details

1024jp

commit sha 71c4cd5ce2ecf7065c3d83713f2933ce241a04e6

Refactor RegexTextField

view details

1024jp

commit sha 792a48f432aab05725ea6cd347f0f7bd8fbe7e3e

HIghlight regex in multiple replacement editor

view details

1024jp

commit sha 96fa7860b37c5463b7d936644560d46a43ab375d

Update changelog (#883)

view details

1024jp

commit sha 96a06f2ef822bb461a8686b8127058dc985496bc

Update highlight when toggling "unescapes replacement string"

view details

1024jp

commit sha ef5c1d48349a5be16cfe4fce332d0e7b401e74cc

Make multiple repalcement edit undoable

view details

1024jp

commit sha a58df8e8d5f30473701acd541bbe17777362a6b6

Set action names to multiple repalcement's undo

view details

1024jp

commit sha dcc1f4bedc299d9c006e1e1ba2de35e39ce3f312

Update CHANGELOG

view details

1024jp

commit sha 475a04c5e47714783988fd1dba31e3f81bb3dc00

Use standardShareMenuItem() when possible

view details

1024jp

commit sha 135667c91510422bbcc0fc5ef9391aff7cc53629

Remove a needless _

view details

1024jp

commit sha 37908dc9cd1faa3c12f5ad9678f147b8a9b5abfd

Create UserDefaultsObservation

view details

1024jp

commit sha 4d5b9a1deb134e4b1941293dbb205aab6e75d95e

Use UserDefaultsObservation

view details

1024jp

commit sha 67b0c6c34e7a1ac8d3499963d31606c518c76fb1

Merge branch 'feature/defaultsObserver' into develop

view details

1024jp

commit sha 2ca7500561df1ece75241c1473f823d327803e4c

Set qos explicitly to background tasks

view details

push time in 22 days

issue commenttypora/typora-issues

Strange behaviors when Undo for the first time after saving in the Source Mode

I am using RIME (https://rime.im).

I tried again in the current version 0.9.9.31.4 (4005), it seems it now works fine without this problem.

But now, the saving action in Source Mode is extremely slow and make the UI unresponsive for about 2 or 3 seconds. It happens always for any size of the files. This problem only happens in Source Mode, and in Normal Mode everything is fine. Do you have any idea or what can I do for tracking this issue down?

Thanks!

onevcat

comment created time in 23 days

startedmichaeleisel/barber

started time in 24 days

more