profile
viewpoint
Wei Wang onevcat LINE Corp. Yokohama, Japan / China https://onev.cat Developer, creator, father

onevcat/APNGKit 1710

High performance and delightful way to play with APNG format in iOS.

objcio/core-data 709

Sample code for the objc.io Core Data book

MDCC2016/ProtocolNetwork 378

Sample project to show how to use protocol/extension to build a network layer

onevcat/DebuggableContext 100

Provides an easy to use action sheet for debugging purpose when shaking your iOS device.

onevcat/AddressParser 69

Email address parser.

onevcat/ClockFaceView 32

A demo project for my blog post

line/line-sdk-starter-ios-v2 25

A starter application that demonstrates how to use LINE SDK for iOS.

onevcat/DispatchMemoryLeakDemo 19

A demo that reproduce memory leak in iOS 9.2

onevcat/DateTimePicker 16

A nicer iOS UI component for picking date and time

issue closedonevcat/Kingfisher

Jdj

Po

closed time in 4 hours

tripleover

release onevcat/Kingfisher

5.15.4

released time in 15 hours

push eventonevcat/Kingfisher

onevcat

commit sha 2d795b521934b02357fec781b33e2c407655eebb

Bump version to 5.15.4

view details

push time in 15 hours

created tagonevcat/Kingfisher

tag5.15.4

A lightweight, pure-Swift library for downloading and caching images from the web.

created time in 15 hours

push eventonevcat/Kingfisher

onevcat

commit sha 070e2f21bd7298a6d67e9b919ed9e1be4b208d65

Give SessionDelegate an ObjC name

view details

Wei Wang

commit sha bee322556705c0d9f31ba935786aae6b9c54f976

Merge pull request #1532 from onevcat/fix/objc-name-for-sessiondelegate Give SessionDelegate an ObjC name

view details

push time in 16 hours

delete branch onevcat/Kingfisher

delete branch : fix/objc-name-for-sessiondelegate

delete time in 16 hours

PR merged onevcat/Kingfisher

Give SessionDelegate an ObjC name

This should fix #1530

+1 -0

0 comment

1 changed file

onevcat

pr closed time in 16 hours

issue closedonevcat/Kingfisher

Use of Kingfisher with Alamofire - SessionDelegate - Xcode 12

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

Showing All Errors Only 'SessionDelegate' has different definitions in different modules; first difference is definition in module 'Alamofire.Swift' found method

Xcode 12: Add Pods of Alamofire and Kingfisher Build Project

closed time in 16 hours

mrazam110

PR opened onevcat/Kingfisher

Give SessionDelegate an ObjC name

This should fix #1530

+1 -0

0 comment

1 changed file

pr created time in 16 hours

create barnchonevcat/Kingfisher

branch : fix/objc-name-for-sessiondelegate

created branch time in 16 hours

issue commentonevcat/Kingfisher

Use of Kingfisher with Alamofire - SessionDelegate - Xcode 12

I don't have this issue when trying in a sample project installing both the latest versions of Kingfisher (5.15.3) and Alamofire (5.2.2). It might be either a version issue or a local project setting problem. And it is not strange that CocoaPods is generating the ObjC compatible header by default, so it is still triggering #1517.

@christophercotton That fix is nice and I will also add it to this repo so we can solve it in any dependency manager.

mrazam110

comment created time in 16 hours

issue closedonevcat/Kingfisher

Xcode 12 warning: Variable 'retrievingContext' was never mutated; consider changing to 'let' constant

Check List

Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

Issue Description

Xcode 12 reports are warning: Variable 'retrievingContext' was never mutated; consider changing to 'let' constant

What

Warning should not appear

Reproduce

compile

Other Comment

closed time in a day

timbms

issue commentonevcat/Kingfisher

Xcode 12 warning: Variable 'retrievingContext' was never mutated; consider changing to 'let' constant

This should be already fixed long ago in https://github.com/onevcat/Kingfisher/pull/1492/files#diff-3e519cd03a013ef2802179ab0d255ae2R209

timbms

comment created time in a day

issue commentline/line-sdk-unity

Module 'LineSDKObjC' not found on Xcode Build

Hi,

Installing LINE SDK for Unity requires some environment set up to help the project automatically get the latest version of LINE SDK from GitHub. Please be sure to follow up on the installation guide here and here to set the project.

If everything is set, do you have any error when exporting your Unity project? It will help us to track down what exactly happens.

And if you are integrating by CocoaPods (which is the default choice), please remember to open the Unity-iPhone.xcworkspace instead of the original Unity-iPhone.xcodeproj file to build your project. CocoaPods manages the dependencies in the standalone workspace so you will not be able to find the framework in the original project.

Any further information is welcome!

Yukakiri0213

comment created time in 2 days

issue commentline/line-sdk-ios-swift

Error when using LineSDK in OC project

Hi,

It seems that you are passing a nil to the parameters in the login method. https://github.com/hw20101101/H200914_Test_Protocol/blob/master/H200914_Test_Protocol/ViewController.m#L38

You should not do that since this parameters only accept a non-null value:

截屏2020-09-23 11 06 47

Try to remove the parameters:nil from your code, or set a LineSDKLoginManagerParameters value to it if you need any additional parameters. That should solve it.

hw20101101

comment created time in 2 days

issue closedonevcat/Kingfisher

Is there any user data that is either being collected or Tracked by the Kingfisher Framework

App Tracking Transparency Framework Information.

As part of the iOS 14 /AppTracking Transparency framework, would like to know if any kind of the user data is collected or Tracked by the Kingfisher.

[As mentioned in the Apple (Ref: https://developer.apple.com/support/app-privacy-on-the-app-store/), below were some of the examples for Tracking:

  • Sharing device location data or email lists with a data broker.
  • Placing a third-party SDK in our app that combines user data from the app with user data from other developers’ apps to target advertising or measure advertising efficiency, even if we don’t use the SDK for these purposes. For example, using a login SDK that repurposes the data it collects from the app to enable targeted advertising in other developers’ apps.

The following situations are not considered tracking:

  • When the data is linked solely on the end-user’s device and is not sent off the device in a way that can identify the end-user or device.
  • When the data broker uses the data shared with them solely for fraud detection or prevention or security purposes, and solely on our behalf.]

<!-- Love Kingfisher? Please consider supporting our collective: 👉 https://opencollective.com/Kingfisher/donate -->

closed time in 2 days

m-venkata

issue closedonevcat/Kingfisher

SessionDelegate naming conflict between Kingfisher and Alamofire in Xcode 12 GM

Check List

Issue Description

What

There seems to be a naming conflict inside the objc header file with the SessionDelegate class when using both Kingfisher and Alamofire in Xcode 12 GM. (You can see the issue on Alamofire side here, more discussion here)

/Users/sachajln/ios-workspace/MyProject/Carthage/Build/iOS/Kingfisher.framework/Headers/Kingfisher-Swift.h:836:1: error: 'SessionDelegate' has different definitions in different modules; first difference is definition in module 'Kingfisher.Swift' found method with designater initializer
- (nonnull instancetype)init OBJC_DESIGNATED_INITIALIZER;
^
/Users/sachajln/ios-workspace/MyProject/Carthage/Build/iOS/Alamofire.framework/Headers/Alamofire-Swift.h:772:1: note: but in 'Alamofire.Swift' found method with no designater initializer
- (nonnull instancetype)init SWIFT_UNAVAILABLE;
^

Reproduce

Use Alamofire and Kingfisher frameworks inside a project and do a xcodebuild -project YOUR_PROJECT.xcodeproj -sdk iphoneos with Xcode 12 GM command line tools.

Comments

I'm using Carthage to build and copy the frameworks in my project

closed time in 4 days

sachajln

issue commentonevcat/Kingfisher

SessionDelegate naming conflict between Kingfisher and Alamofire in Xcode 12 GM

5.15.3 was released for this.

sachajln

comment created time in 4 days

release onevcat/Kingfisher

5.15.3

released time in 4 days

created tagonevcat/Kingfisher

tag5.15.3

A lightweight, pure-Swift library for downloading and caching images from the web.

created time in 4 days

push eventonevcat/Kingfisher

onevcat

commit sha ffc614446cab6ae106619606698d642c23ed25be

Bump version to 5.15.3

view details

push time in 4 days

push eventonevcat/Kingfisher

onevcat

commit sha 946b4f7857a546e253656303e8caec993c6e6fde

Upgrade gems

view details

push time in 4 days

delete branch onevcat/Kingfisher

delete branch : fix/no-objc

delete time in 4 days

create barnchonevcat/Kingfisher

branch : fix/no-objc

created branch time in 4 days

push eventonevcat/Kingfisher

Android Dev Notes

commit sha 1257ed2cba78ee25a9acb7fd39fd5ec69940c8b0

Fix grammatical errors

view details

Wei Wang

commit sha 21b7e391ccce442162ba68b61c8a159ab2b08d2a

Merge pull request #1526 from androiddevnotesforks/master Fix grammatical errors

view details

push time in 4 days

pull request commentonevcat/Kingfisher

Fix grammatical errors

Thanks for it!

androiddevnotes

comment created time in 4 days

push eventonevcat/Kingfisher

onevcat

commit sha d285512a1c05bb9f0169990bd8ad4f9cb4f93dfe

Allow lower deploy target for dependency managers

view details

Wei Wang

commit sha 4330f3522640c1b46331d2c98b81851b61defc5a

Merge pull request #1524 from onevcat/fix/swift-ui-deploy-target Allow lower deploy target for dependency managers

view details

push time in 4 days

delete branch onevcat/Kingfisher

delete branch : fix/swift-ui-deploy-target

delete time in 4 days

PR merged onevcat/Kingfisher

Allow lower deploy target for dependency managers

This should fix #1522

There is no need to give the KingfisherSwiftUI target a higher deployment target, although no one can use it on a lower platform. The related APIs are already marked with correct @available annotation, so there is no need to limit its lowest version anymore.

+6 -6

0 comment

2 changed files

onevcat

pr closed time in 4 days

issue closedonevcat/Kingfisher

[Multiple commands produce xxxx ] happened while archiving app(target >= iOS11) , with Clips or Widgets in iOS14

I'm working with the project: Main project working with the latest Kingfisher and development target = iOS 11. Clip / Widget extension working with the latest Kingfisher/SwiftUI and development target = iOS 14.

After pod installing, the Kingfisher and Kingfisher-Core-SwiftUI target is added into the Pods project, and their Product Name are both Kingfisher. So when I archive the app , the error occurs due to the same Product Name of them:

Multiple commands produce '/xxx/Kingfisher.framework':
1) Target 'Kingfisher' has create directory command with output '/xxx/Kingfisher.framework'
2) Target 'Kingfisher-Core-SwiftUI' has create directory command with output '/xxx/Kingfisher.framework'

I know that it's not the issue or bug with Kingfisher, but can u provide me some solution in this situation?

Thx

closed time in 4 days

SpiciedCrab

push eventonevcat/Kingfisher

onevcat

commit sha ea6e10a7feef8dbbe1f0016a24ff5c78ca5e20dd

Stop module support

view details

Wei Wang

commit sha 75860a5be20f307e09b95367ae9d7bf83bcca128

Merge pull request #1523 from onevcat/fix/no-objc Stop module support

view details

push time in 4 days

delete branch onevcat/Kingfisher

delete branch : fix/no-objc

delete time in 4 days

PR merged onevcat/Kingfisher

Stop module support

This was a long-ago intended change since version 5.8. But at that time, Carthage fails to create valid cache hash when no ObjC header generated.

https://github.com/onevcat/Kingfisher/issues/1307

Now Carthage has fixed that issue, and it seems that Carthage built frameworks on Xcode 12 is failing at merging the headers from different frameworks when they have conflicting type names (#1517 and https://github.com/Alamofire/Alamofire/issues/3303). So it seems that now it is another good chance to apply this.

It removes support of Objective-C so there would be no header conflicting anymore with another project. (Regardless of it being an Xcode issue or a Carthage issue.)

+0 -6

0 comment

1 changed file

onevcat

pr closed time in 4 days

PR opened onevcat/Kingfisher

Remove deprecated things
+0 -863

0 comment

11 changed files

pr created time in 4 days

create barnchonevcat/Kingfisher

branch : fix/remove-deprecated

created branch time in 4 days

issue commentonevcat/Kingfisher

Backward matching of the unlabeled trailing closure is deprecated

It is a quite annoying change in Swift 5.3, basically only for writing better SwiftUI code. For any other use cases, it is a bit of regression to apply the new trailing closure rule.

For you case, if you have both the progress block and completion block, try to explicitly name the first block to avoid the ambiguous meaning:

imageView.kf.setImage(
    with: LocalFileImageDataProvider(fileURL: URL(string: "")!),
    progressBlock: { (_, _) in

    }
) { _ in

}

Or even write out them all:

imageView.kf.setImage(
    with: LocalFileImageDataProvider(fileURL: URL(string: "")!),
    progressBlock: { (_, _) in

    },
    completionHandler: { _ in

    }
)

The factory pattern is very nice in Alamofire and it definitely a good direction to improve the API. But it requires a major upgrade and I will consider if it is easy enough to migrate. I will try to see it I can implement it soon. Thank you for your suggestion.

lexrus

comment created time in 4 days

issue commentAlamofire/Alamofire

Xcode12 GM 'SessionDelegate' has different definitions in different modules

@jshier

Never mind! :P

was a native Swift framework (used to be Obj-C, right?)

No, it was written in Swift from the first line of code. The ObjC header generating of Kingfisher was removed once, but soon added back due to a Carthage bug which requires to get Swift compiler version information from the "-Swift.h" header file. Carthage fixed that by falling back to dSYM file to get the Swift compiler version. However, they never released a new version until recently.

removing the Obj-C module seems like a good idea anyway. I'll open an issue and see if I can ship an update.

Yes. This issue might not only happens between Alamofire and Kingfisher. Any other frameworks which contains a same type name and generates ObjC headers would lead to this. Kingfisher has quite a few Swift-only APIs, and it is intended to be only used in Swift project, so removing the module support is a plan from long-ago. Not quite sure whether Alamofire supports ObjC or not. If no, I think it should be a good idea to skip ObjC things. It makes compile much faster and maybe some smaller binary file.

KBvsMJ

comment created time in 5 days

issue commentonevcat/Kingfisher

[Multiple commands produce xxxx ] happened while archiving app(target >= iOS11) , with Clips or Widgets in iOS14

  1. Target 'Kingfisher.default-SwiftU'

And the target name in your log is suspicious, if you are not pasting it wrongly.

SpiciedCrab

comment created time in 5 days

issue commentonevcat/Kingfisher

[Multiple commands produce xxxx ] happened while archiving app(target >= iOS11) , with Clips or Widgets in iOS14

platform :ios, '11.0'

target 'SampleProject' do
  use_frameworks!
  pod 'Kingfisher/SwiftUI', :git => 'https://github.com/onevcat/Kingfisher.git', :branch => 'fix/swift-ui-deploy-target'
end

target 'SampleWidgetExtension' do
  use_frameworks!
  pod 'Kingfisher/SwiftUI', :git => 'https://github.com/onevcat/Kingfisher.git', :branch => 'fix/swift-ui-deploy-target'
end

Here is the Podfile I am trying and it works fine. CocoaPods recognized both as a single target in the pod framework.

Maybe check your project setting or Podfile to see if there is another setting causes this issue.

SpiciedCrab

comment created time in 5 days

PR opened onevcat/Kingfisher

Allow lower deploy target for dependency managers

This should fix #1522

There is no need to give the KingfisherSwiftUI target a higher deployment target, although no one can use it on a lower platform. The related APIs are already marked with correct @available annotation, so there is no need to limit its lowest version anymore.

+6 -6

0 comment

2 changed files

pr created time in 5 days

issue commentonevcat/Kingfisher

[Multiple commands produce xxxx ] happened while archiving app(target >= iOS11) , with Clips or Widgets in iOS14

@SpiciedCrab

I got your idea. I pushed some change to the fix/swift-ui-deploy-target branch to make the deploy target requirement of SwiftUI subspec matching to the main target. Can you try it to see if it works for you? You can change both of the dependency declarations in your Podfile to something like this, before we can tag and release it as a new version:

pod 'Kingfisher/SwiftUI', :git => 'https://github.com/onevcat/Kingfisher.git', :branch => 'fix/swift-ui-deploy-target'
SpiciedCrab

comment created time in 5 days

create barnchonevcat/Kingfisher

branch : fix/swift-ui-deploy-target

created branch time in 5 days

issue commentonevcat/Kingfisher

SessionDelegate naming conflict between Kingfisher and Alamofire in Xcode 12 GM

@sachajln @timbms @Senocico @alperkayabasi

Can you confirm whether this branch "fix/no-objc" can solve your issue? If everything goes fine, I will merge it and tag a new version soon.

Thanks!

sachajln

comment created time in 5 days

issue commentonevcat/Kingfisher

[Multiple commands produce xxxx ] happened while archiving app(target >= iOS11) , with Clips or Widgets in iOS14

Kingfisher's SwiftUI support is a part of (or say an additional slice) the core framework.

So if you are using use_frameworks! and linking Kingfisher dynamically (which should be the recommended way when you developing a multiple targets app containing widget or other extensions), you can just add KingfisherSwiftUI to pod file and link it to multiple targets. So only one full-featured of the framework will be added to your project.

SpiciedCrab

comment created time in 5 days

PR closed onevcat/Kingfisher

session delegate name change in order to fix conflicts with alamofire on Xcode 12 GM

fix for this issue: https://github.com/onevcat/Kingfisher/issues/1517

+8 -8

2 comments

3 changed files

bogdanmatasaru

pr closed time in 5 days

pull request commentonevcat/Kingfisher

session delegate name change in order to fix conflicts with alamofire on Xcode 12 GM

@bogdanmatasaru Thank you for this PR. Your fix works perfectly!

But I guess I can fix it in #1523, with a long-ago intended change to make the framework better.

bogdanmatasaru

comment created time in 5 days

PR opened onevcat/Kingfisher

Stop module support

This was a long-ago intended change since version 5.8. But at that time, Carthage fails to create valid cache hash when no ObjC header generated.

https://github.com/onevcat/Kingfisher/issues/1307

Now Carthage has fixed that issue, and it seems that Carthage built frameworks on Xcode 12 is failing at merging the headers from different frameworks when they have conflicting type names (#1517 and https://github.com/Alamofire/Alamofire/issues/3303). So it seems that now it is another good chance to apply this.

It removes support of Objective-C so there would be no header conflicting anymore with another project. (Regardless of it being an Xcode issue or a Carthage issue.)

+0 -6

0 comment

1 changed file

pr created time in 5 days

create barnchonevcat/Kingfisher

branch : fix/no-objc

created branch time in 5 days

issue commentonevcat/Kingfisher

Module Not Found - Unable to load standard library for target 'arm64-apple-ios10.0'

I personally cannot reproduce this issue in my environment. Can anyone help provide some reproducible steps? Or can you prepare a simple sample in which this can happen?

Some more information would be also helpful for tracking it quicker:

  • Are you using an ARM Mac? Or a traditional Intel mac? The official released Xcode 12.0 does not support ARM Mac yet, you need to keep to use beta 6.
  • By which way you are installing Kingfisher? Pods, Carthage or SPM?
  • Does this error happens when you click the Run button in Xcode? Or does it happen when you build with command line?

Thanks for any information.

jasonhr13

comment created time in 5 days

issue commentonevcat/Kingfisher

Swift Compile Error with Xcode 12

@vulgur Cannot reproduce it when building with Kingfisher installed by SPM.

Are you trying to work on an ARM Mac (the Developer Transition Kit)?

vulgur

comment created time in 5 days

issue commentonevcat/Kingfisher

app crashs on iOS 14 when use Kingfisher in List

KFImage uses the same ImageCache under-hood, so it follows everything (maybe you are already familiar) as Kingfisher does. You do not need to do anything to enable cache and it just works by default. If you want to tweak it, follow the cache related section in the Cheat Sheet in Wiki.

hassfers

comment created time in 5 days

issue commentonevcat/Kingfisher

app crashs on iOS 14 when use Kingfisher in List

Fixed and released as 5.15.2 for this issue.

hassfers

comment created time in 5 days

issue closedonevcat/Kingfisher

Error to Build KingfisherSwiftUI 5.15.1 with XCode 11.7

Hi Guys,

I have this error to build KingfisherSwiftUI 5.15.1 with XCode 11.7.+ Can you check it?

J

closed time in 5 days

pjcau

issue commentonevcat/Kingfisher

Error to Build KingfisherSwiftUI 5.15.1 with XCode 11.7

Fixed and released as 5.15.2 for this issue.

pjcau

comment created time in 5 days

release onevcat/Kingfisher

5.15.2

released time in 5 days

created tagonevcat/Kingfisher

tag5.15.2

A lightweight, pure-Swift library for downloading and caching images from the web.

created time in 5 days

push eventonevcat/Kingfisher

onevcat

commit sha 0efb20f022501327f4028aa9bf7cd4a0d390bea0

Bump version to 5.15.2

view details

push time in 5 days

issue commentAlamofire/Alamofire

Xcode12 GM 'SessionDelegate' has different definitions in different modules

Hi,

I am the maintainer of Kingfisher.

Just like Alamofire, Kingfisher is also a Swift framework. Both Kingfisher and Alamofire are trying to generate an Objective-C header ("-Swift.h"). Before Xcode 12 beta 6, it correctly handled them, and Kingfisher lives happily with any other frameworks, including Alamofire, for more than 5 years.

However, I am not sure if it is an intended change of the latest Xcode or not. Anyway, I will try to seek a way (maybe not defining a module for ObjC anymore), to avoid any future conflict like this.

KBvsMJ

comment created time in 5 days

push eventonevcat/Kingfisher

Wei Wang

commit sha 935e0cb9a2052253e25ff67688ddcb7f0c2d1d2a

Fix build for Xcode 11

view details

Wei Wang

commit sha b767c724d71df1b5f0fae09b628d71e6bd58d584

Merge pull request #1515 from onevcat/fix/swiftui-build-xcode11 Fix SwiftUI build for Xcode 11

view details

push time in 5 days

delete branch onevcat/Kingfisher

delete branch : fix/swiftui-build-xcode11

delete time in 5 days

issue commentonevcat/Kingfisher

SessionDelegate naming conflict between Kingfisher and Alamofire in Xcode 12 GM

I'll check what I can do for it.

sachajln

comment created time in 5 days

issue closedonevcat/Kingfisher

SwiftUI Error reference to property 'binder' in closure requires explicit 'self.' to make capture semantics explicit

Issue Description

What

When trying to view a live preview of a SwiftUI file, Xcode failed to build the scheme and reports the error in the title

Reproduce

Open a SwiftUI file and attempt to view a live preview

Other Comment

Version 5.15.1

closed time in 5 days

jscubida

issue commentonevcat/Kingfisher

SwiftUI Error reference to property 'binder' in closure requires explicit 'self.' to make capture semantics explicit

It should be fixed by #1515 and I will tag a new release for it soon.

jscubida

comment created time in 5 days

issue closedonevcat/Kingfisher

Getting a duplicate code error when trying to add Kingfisher 5.15.1 via Xcode 12 GM SPM

Screen Shot 2020-09-16 at 12 14 33 PM

Any ideas what the issue may be here? 'collectors' is my project target and name.

closed time in 5 days

ethanwa

issue commentonevcat/Kingfisher

Module Not Found - Unable to load standard library for target 'arm64-apple-ios10.0'

Not sure what you are using to install Kingfisher. But if you are using the xcframework, I heard that there is a bug in Xcode 12 GM that it is picking the wrong slice so you may have this issue. Reverting back to use Xcode 12 beta 6 or choose another way to install the framework might solve it.

(But I didn't verify it myself.)

jasonhr13

comment created time in 7 days

issue commentonevcat/Kingfisher

app crashs on iOS 14 when use Kingfisher in List

Oh. I guess it is exactly what I have done?

hassfers

comment created time in 7 days

issue commentonevcat/Kingfisher

Module Not Found - Unable to load standard library for target 'arm64-apple-ios10.0'

No idea what can cause it. It is not likely to be what we can solve in Kingfisher, since Xcode should being respecting your project settings when build a project and Kingfisher can just follow the instruction of the build system.

By the way, may I know how did you add Kingfisher to your project? Can it be a problem of the dependency manager like Carthage or so?

jasonhr13

comment created time in 7 days

issue commentonevcat/Kingfisher

Getting a duplicate code error when trying to add Kingfisher 5.15.1 via Xcode 12 GM SPM

Due to a previous bug of Xcode, Kingfisher defined multiple libraries, including automatic (static) and explicit dynamic ones. Currently that bug was already fixed and there should be no need to separate them. But I choose to keep these targets for a while for back compatibility. If there is no good reason, please ensure you just link the standard one “Kingfisher” to your target, and remove any other ones (“KingfisherDynamic” for example) from your link library phase.

ethanwa

comment created time in 7 days

issue commentonevcat/Kingfisher

app crashs on iOS 14 when use Kingfisher in List

@lehelmedves I created a fix in this branch https://github.com/onevcat/Kingfisher/tree/fix/swiftui-build-xcode11

However, I am on my vacation now and do not have a Mac at hand to verify it. Please try if that works and if everything goes fine I will tag it in a few days when I return.

hassfers

comment created time in 7 days

create barnchonevcat/Kingfisher

branch : fix/swiftui-build-xcode11

created branch time in 7 days

issue closedonevcat/Kingfisher

app crashs on iOS 14 when use Kingfisher in List

Hello

yes I know iOS 14 is still in beta but maybe it helps you ;-)

I use kingfisher in a SwiftUI List to load pictures from urls. The initial state is shown as expected, but when I start scrolling the app crashs with a Bad Access- Error.

If I delete the KFImage everything working well.

If I use the same url for every cell it also works fine.

Maybe there is some problem when SwiftUI tries to reuse the Cell and can't load the image somehow.

Does anybody has an idea what to do ?

closed time in 8 days

hassfers

issue commentonevcat/Kingfisher

app crashs on iOS 14 when use Kingfisher in List

5.15.1 was released for this.

hassfers

comment created time in 8 days

release onevcat/Kingfisher

5.15.1

released time in 8 days

created tagonevcat/Kingfisher

tag5.15.1

A lightweight, pure-Swift library for downloading and caching images from the web.

created time in 8 days

push eventonevcat/Kingfisher

onevcat

commit sha 22b795dd57766fa0e86773d8733efb31dc0f31fb

Bump version to 5.15.1

view details

push time in 8 days

push eventonevcat/Kingfisher

onevcat

commit sha de278a1ca0e075bde6669b115bbd1f7ab791eb85

Disable Carthage lint and use Xcode 12 to create binary framework

view details

push time in 8 days

push eventonevcat/Kingfisher

onevcat

commit sha 96642ce52f5dbe297104a0bd1fdb5970c47597dc

Upgrade gem

view details

push time in 8 days

pull request commentonevcat/Kingfisher

Move appear life cycle to placeholder

This is a workaround for #1508. But a real fix is still being waited from Apple.

onevcat

comment created time in 8 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 33f1f51bb9f29a2c538b96e058ab81fe66c86562

Change log section title

view details

push time in 8 days

created tagline/line-sdk-ios-swift

tag5.7.0

Provides a modern way of implementing LINE APIs.

created time in 8 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 692dc7c10a5ee1a1a6d3285b031434ba6cec0e63

Bump version to 5.7.0

view details

push time in 8 days

release line/line-sdk-ios-swift

5.7.0

released time in 8 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 745d0ca19cbfaa61e2951457826d2acbae23414b

Update changelog

view details

push time in 8 days

delete branch line/line-sdk-ios-swift

delete branch : fix/xcode12-ci

delete time in 8 days

push eventline/line-sdk-ios-swift

onevcat

commit sha fdfe4944c909e2169beaa4f89fed29ed9c6b6a2b

Add CI matrix for Xcode 12

view details

onevcat

commit sha 5ceea5f8948d0d6dcfa8e6627eb9f82b2d9c8370

Disable carthage lint temporarily due to https://github.com/Carthage/Carthage/issues/3019

view details

onevcat

commit sha d8bd07c1de02f1f7320a610c87ff97dfc4026f1a

Upgrade project settings

view details

onevcat

commit sha c99015698e1207a7e7303a508ae541b34e2a96a6

Fix warnings

view details

onevcat

commit sha b35865b877e899ddbeec34c2f6cc6cbf43a57325

Upgrade gems

view details

Wei Wang

commit sha 5461e97ba8b9766d9c19ef140d1bb23df3df086e

Merge pull request #161 from line/fix/xcode12-ci Add CI matrix for Xcode 12

view details

push time in 8 days

push eventline/line-sdk-ios-swift

onevcat

commit sha b35865b877e899ddbeec34c2f6cc6cbf43a57325

Upgrade gems

view details

push time in 8 days

push eventline/line-sdk-ios-swift

onevcat

commit sha c99015698e1207a7e7303a508ae541b34e2a96a6

Fix warnings

view details

push time in 8 days

push eventline/line-sdk-ios-swift

onevcat

commit sha d8bd07c1de02f1f7320a610c87ff97dfc4026f1a

Upgrade project settings

view details

onevcat

commit sha affee134ccbe8800b8f232b4d2d4a3800faba77a

Fix warnings

view details

push time in 8 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 5ceea5f8948d0d6dcfa8e6627eb9f82b2d9c8370

Disable carthage lint temporarily due to https://github.com/Carthage/Carthage/issues/3019

view details

push time in 8 days

PR opened line/line-sdk-ios-swift

Add CI matrix for Xcode 12
+27 -1

0 comment

3 changed files

pr created time in 8 days

create barnchline/line-sdk-ios-swift

branch : fix/xcode12-ci

created branch time in 8 days

delete branch line/line-sdk-ios-swift

delete branch : feature/spm-resource

delete time in 8 days

push eventline/line-sdk-ios-swift

onevcat

commit sha 10cc272f36317faeea7bf4be1d120ac692c7cc55

Support bundle resource for SPM

view details

onevcat

commit sha 9ae16f570250fb31fd0b79f158706dc66e7ffea9

Support both Swift 5 and Swift 5.3

view details

onevcat

commit sha 397ce5369eb37c79ab29799134e65c8f6bcfbc1e

Move files for build with SPM old versions

view details

onevcat

commit sha a2fcef5bb83c5949aae32d327a008bdbf2202741

Fix file header

view details

Wei Wang

commit sha 4ea1363598b3dea161424def9e0ab57e19c69a11

Merge pull request #155 from line/feature/spm-resource Support bundle resource for SPM

view details

push time in 8 days

PR merged line/line-sdk-ios-swift

Support bundle resource for SPM

This adds support for the resource bundle of the UI part of LINE SDK. It requires swift-tools-version:5.3 bundled in Xcode 12 and also keep compatibility for integrating of CocoaPods and Carthage.

We can merge it once Xcode 12 gets finally released so users can build LINE SDK with SPM.

+111 -48

0 comment

10 changed files

onevcat

pr closed time in 8 days

issue commentonevcat/Kingfisher

app crashs on iOS 14 when use Kingfisher in List

@hassfers @RosayGaspard

I tried some fix (#1510) inside Kingfisher and hopefully, it can solve this issue. Can you try to switch to the master branch temporarily to check if it works? If everything goes fine, I will give it a tag then.

hassfers

comment created time in 9 days

more