oliviertassinari ( Olivier Tassinari )

commit sha 1a271a926945494216fe5a11442513583f5f90ee

fix ci

[docs] Add Material-UI Builder to in-house ads

push time in 4 hours

Pull request review commentmui-org/material-ui

 const inHouseAds = [   {     name: 'scaffoldhub',     link: 'https://scaffoldhub.io/?partner=1',-    img: '/static/in-house/scaffoldhub.png',+    img: '/static/images/in-house/scaffoldhub.png',

Yeah, I think that images should be renamed components

mbrookes

comment created time in 4 hours

PullRequestReviewEvent

Pull request review commentmui-org/material-ui

[docs] Add Material-UI Builder to in-house ads

 const inHouseAds = [   {     name: 'scaffoldhub',     link: 'https://scaffoldhub.io/?partner=1',-    img: '/static/in-house/scaffoldhub.png',+    img: '/static/images/in-house/scaffoldhub.png',

I don't think that the image prefix adds anything. I think that the flatter, the better. In our case, we group per concern.

    img: '/static/in-house/scaffoldhub.png',

mbrookes

comment created time in 4 hours

PullRequestReviewEvent

pull request commentmui-org/material-ui

[docs] Add Material-UI Builder to in-house ads

Would it be better to target next? (I usually cherry-pick to master and then to latest to deploy the relevant changes)

mbrookes

comment created time in 4 hours

issue commentmui-org/material-ui

[TextField] Wrong disabled color in Safari

@mtr1990 would have priority as it's thanks to him that we would be fixing this bug. If he's not interested, definitely.

mtr1990

comment created time in 7 hours

delete branch mui-org/material-ui

delete branch : v3.x

delete time in 7 hours

PR closed mui-org/material-ui

V3.x

[x] I have followed (at least) the PR section of the contributing guide .

+2423 -1301

45 commit in mui-org/material-ui/tree/v3.x mui-org/material-ui/tree/next

1 comment

303 changed files

ParmGill00

pr closed time in 7 hours

issue commentmui-org/material-ui

[TextField] Wrong disabled color in Safari

Considering it's using the design token from the theme, I think that we can move forward, it should be fine.

mtr1990

comment created time in 9 hours

IssuesEvent

issue openedmui-org/material-ui-x

[DataGrid] Add row menu

Summary 💡

Allow displaying a menu for each row to perform actions. This is the equivalent to having a menu for each column.

Examples 🌈

The row menu can include any action, for instance, calling an API In the backend: "send reminder".

Motivation 🔦

The row action is meant to allow performing actions for a single row. It's complementary to the batch actions that can be performed with row selection.

Benchmark

https://dashboard.stripe.com

Capture d’écran 2020-10-31 à 16 47 55

https://elastic.github.io/eui/#/tabular-content/data-grid

Capture d’écran 2020-10-31 à 17 01 15

https://try.firetable.io/table/mvpResources

Capture d’écran 2020-10-31 à 17 00 51

https://ads.google.com/, problem dodge with the batch actions:

Capture d’écran 2020-10-31 à 17 02 09

https://mail.google.com/

Capture d’écran 2020-10-31 à 17 03 59

created time in 9 hours

issue openedmui-org/material-ui-x

[DataGrid] Add toolbar

Summary 💡

Introduce a toolbar to perform complementary actions.

Examples 🌈

Items the toolbar can include:

Filtering
Grouping
Sorting
Column order
Column visibility
Display density
Export/import records
Quick search
Add new record

Motivation 🔦

The data grid is meant to display records, many operations & manipulator can be performed on these records, a toolbar is a great place to manage it. The Material Design specification quickly mentions it but doesn't provide guidance that we can truly leverage.

Benchmark

https://airtable.com, active items are colored. It works great.

Capture d’écran 2020-10-31 à 16 25 44

https://ag-grid.com, side panel, the UX is horrible, to ignore.

Capture d’écran 2020-10-31 à 16 26 30

https://try.firetable.io/table/mvpResources, works OK-ish

Capture d’écran 2020-10-31 à 16 27 59

https://elastic.github.io/eui/#/tabular-content/data-grid, works well

Capture d’écran 2020-10-31 à 16 29 32

https://baseweb.design/components/unstable-data-table#data-table, displaying the filters directly, doesn't scale, not so great.

Capture d’écran 2020-10-31 à 16 37 58

created time in 10 hours

issue closedmui-org/material-ui

the docs lost flexDirection="column" in flexbox

in the docs https://next--material-ui.netlify.app/system/flexbox/

can't find flexDirection="column"

closed time in 10 hours

stfenjobs

issue commentmui-org/material-ui

the docs lost flexDirection="column" in flexbox

@stfenjobs We can't add a demo for all the possible values. Closing for #15451.

stfenjobs

comment created time in 10 hours

issue commentmui-org/material-ui

[Tab] Leading Icon variant

Related to #15324

numToStr

comment created time in 11 hours

PullRequestReviewEvent

issue commentmui-org/material-ui

the docs lost flexDirection="column" in flexbox

@stfenjobs What do you mean by "can't find"? Is it related to #15451?

stfenjobs

comment created time in 12 hours

commit sha ff8460eca395bb68bbda03853fe0b75e631c537c

Matt's review Co-authored-by: Matt <[email protected]>

Text Field color disabled not correct in safari

push time in 12 hours

issue commentmui-org/material-ui

We would need to apply this diff to fix the opacity on Safari.

diff --git a/packages/material-ui/src/InputBase/InputBase.js b/packages/material-ui/src/InputBase/InputBase.js
index 381f3a53d1..2221a81fb2 100644
--- a/packages/material-ui/src/InputBase/InputBase.js
+++ b/packages/material-ui/src/InputBase/InputBase.js
@@ -50,6 +50,7 @@ export const styles = (theme) => {
       '&$disabled': {
         color: theme.palette.text.disabled,
         cursor: 'default',
+        WebkitTextFillColor: theme.palette.text.disabled, // Fix opacity Safari bug
       },
     },
     /* Styles applied to the root element if the component is a descendant of `FormControl`. */

However, it would also force all the customization to adapt. So the question is, will most developers want to know about this issue and update their styles accordingly?

mtr1990

comment created time in 12 hours

Pull request review commentcarbon-design-system/carbon

fix(text-input): fix disabled text on dark themes in safari

     color: $disabled-02;     background-color: $disabled-01;     border-bottom: 1px solid transparent;-+    // Needed to fix disabled text in Safari #6673+    -webkit-text-fill-color: currentColor;

This the initial value, it's a noop: https://developer.mozilla.org/en-US/docs/Web/CSS/-webkit-text-fill-color.

tw15egan

comment created time in 12 hours

PullRequestReviewEvent

issue commentmui-org/material-ui

ThemeProvider does not toggle theme in React.StrictMode

Solved in v5 with the next @material-ui/styled-engine package: https://codesandbox.io/s/youthful-cherry-smxvp?file=/src/Demo.js.

arjunair86

comment created time in 13 hours

PullRequestReviewEvent

push eventeps1lon/material-ui

commit sha 6c8c0270874c193022dfb1c6845f4325a9d9dfaf

throw if missing element

[CardHeaderProps] Type error assigning JSX.Element to title prop

push time in 13 hours

issue commentmui-org/material-ui

@hughfm It was fixed in v5

hughfm

comment created time in 13 hours

issue closedmui-org/material-ui

[CardHeaderProps] Type error assigning JSX.Element to title prop

Hi there,

We're experiencing a TypeScript issue specifically with the CardHeaderProps type. The problem seems to be assigning JSX.Element values to props that should accept React.ReactNode, but whose name overlaps with HTML attributes coming from the "default component" (e.g., title).

The CardHeader component itself behaves fine, so this works:

const MyComponent: React.FC = () => <CardHeader title={<div>My Element Title</div>} />;

but this does not:

const MyProps: CardHeaderProps = {
  title: <div>My Element Title</div>,
};

producing the following compile error:

src/index.tsx:21:3 - error TS2322: Type 'Element' is not assignable to type 'string | ({} & string) | (ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)> | null) | (new (props: any) => Component<...>)> & string) | (ReactNodeArray & string) | (ReactPortal & string) | undefined'.
  Type 'Element' is not assignable to type 'ReactPortal & string'.
    Property 'children' is missing in type 'Element' but required in type 'ReactPortal'.

21   title: <div>Element Title</div>,
     ~~~~~

  node_modules/@types/react/index.d.ts:192:9
    192         children: ReactNode;
                ~~~~~~~~
    'children' is declared here.
  node_modules/@material-ui/core/CardHeader/CardHeader.d.ts:42:5
    42     title?: React.ReactNode;
           ~~~~~
    The expected type comes from property 'title' which is declared here on type 'OverrideProps<CardHeaderTypeMap<{}, "div", "span", "span">, "div">'

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

TypeScript compile error.

Expected Behavior 🤔

Supported prop types compile without errors.

Steps to Reproduce 🕹

Here's a minimal repo for reproduction https://github.com/hughfm/mui-props-type-bug.

Context 🔦

We are building custom components by wrapping MUI components and providing additional functionality/customizations, and as such the TypeScript types for props, like CardHeaderProps are useful when we want to support the full API of a MUI component, with additions/modifications.

Your Environment 🌎

Tech	Version
Material-UI	v4.11.0
React	v16.8.6
TypeScript	v4.0.5

tsconfig.json

{
  "extends": "@tsconfig/recommended/tsconfig.json",
  "compilerOptions": {
    "outDir": "dist",
    "jsx": "preserve"
  },
  "include": ["src/**/*"]
}

Happy to help work on a solution if necessary. Thanks everyone for all your work on Material UI!

closed time in 13 hours

hughfm

push eventeps1lon/material-ui

commit sha 5144086eefca33aa00135a71e1735249c4cc1062

throw if missing element

push time in 13 hours

push eventmui-org/material-ui-docs

commit sha 72086596671b6904e938b98d922e5faad170b030

[docs] Clear the different between table vs data grid right at the start

push time in 14 hours

push eventmui-org/material-ui

commit sha 9196f1944440151938a8b916d6662b5d0e4d59b2

[docs] Clear the different between table vs data grid right at the start

[Paper] Support dark mode brightening based on elevation

push time in 14 hours

Pull request review commentmui-org/material-ui

 import PropTypes from 'prop-types'; import clsx from 'clsx'; import { chainPropTypes } from '@material-ui/utils'; import withStyles from '../styles/withStyles';+import { fade, useTheme } from '../styles';++// Inspired by https://github.com/material-components/material-components-ios/blob/bca36107405594d5b7b16265a5b0ed698f85a5ee/components/Elevation/src/UIColor%2BMaterialElevation.m#L61

I wonder if 80% of the value wouldn't come from the dark theme palette of grey colors as opposed to the Paper supporting it (which help too). It could be very interesting to integrate it into the system.

joshwooding

comment created time in 15 hours

Pull request review commentmui-org/material-ui

[Paper] Support dark mode brightening based on elevation

 export const dark = {   },   divider: 'rgba(255, 255, 255, 0.12)',   background: {-    paper: grey[800],-    default: '#303030',+    paper: '#121212',+    default: '#121212',

I think that we should explore how to integrate this: https://github.com/mui-org/material-ui/blob/38b259eff17f56d92083058543c29c62ce22d6e3/docs/src/modules/components/ThemeContext.js#L235-L239

Into the library. The fact that we had to extend likely suggest that there is an opportunity.

joshwooding

comment created time in 15 hours

PullRequestReviewEvent

commit sha 3a5cf49ae2f691f24f4ca1bc9ba84366bca3463b

[docs] Fix format of codesnippet

push time in 14 hours

push eventmui-org/material-ui-docs

commit sha 8834c431d95a680cb30bcd93a61f52e550ce7c07

[docs] Update homepage quotes (#23326)

l10nbot

commit sha 30297df0b6b826b4830f7b85a559644cdf4c6a30

[docs] Sync translations (#22887)

[DOC] MuiCssBaseline overrides is depreciated. Not mentionned in doc

push time in 14 hours

issue commentmui-org/material-ui

https://next.material-ui.com/guides/migration-v4/#theme

jeromeSH26

comment created time in 14 hours

commit sha 314d04bada0c82eaae3b019cff12df4ac29790c0

fix build

push time in 14 hours

commit sha 8ac53f4e5398fe0ef51a849a4f6b98ce9552e2df

fix build

push time in 14 hours

Pull request review commentmui-org/material-ui

 describe('<Paper />', () => {    describe('prop: square', () => {     it('can disable the rounded class', () => {-      const { getByTestId } = render(-        <Paper data-testid="root" square>-          Hello World-        </Paper>,-      );--      expect(getByTestId('root')).not.to.have.class(classes.rounded);+      const { container } = render(<Paper square>Hello World</Paper>);+      expect(container.firstChild).not.to.have.class(classes.rounded);

We should be able to add arbitrary wrappers in the client render whose implementation is is irrelevant for the test.

Ok, I guess I can't imagine a case where we would need to add a div wrapper.

Could you explain why this is "healthy"?

I was trying to optimize for avoiding cases like #19613, but I think that you are right, most of the value probably comes from making tests easier to write which, without, makes it harder to have more & better (increase coverage).

What does this tell us?

We have, so far, valued the ease of writing tests.
Being able to add a DOM node in the createClientRender would require quite some refactoring, maybe it will never worth it?

oliviertassinari

comment created time in 14 hours

PullRequestReviewEvent

commit sha 0d892eb0b40db63b9cbe73d5f5658649d6766b47

fix build

push time in 14 hours

Pull request review commentmui-org/material-ui

 describe('<Paper />', () => {    describe('prop: square', () => {     it('can disable the rounded class', () => {-      const { getByTestId } = render(-        <Paper data-testid="root" square>-          Hello World-        </Paper>,-      );--      expect(getByTestId('root')).not.to.have.class(classes.rounded);+      const { container } = render(<Paper square>Hello World</Paper>);+      expect(container.firstChild).not.to.have.class(classes.rounded);

expect(container.firstChild) has 163 macthes in the codebase, getByTestId('root') has 34.

oliviertassinari

comment created time in 14 hours

PullRequestReviewEvent

Pull request review commentmui-org/material-ui

 describe('<Paper />', () => {    describe('prop: square', () => {     it('can disable the rounded class', () => {-      const { getByTestId } = render(-        <Paper data-testid="root" square>-          Hello World-        </Paper>,-      );--      expect(getByTestId('root')).not.to.have.class(classes.rounded);+      const { container } = render(<Paper square>Hello World</Paper>);+      expect(container.firstChild).not.to.have.class(classes.rounded);

I have spotted this opportunity looking at the test changes of #21748.

oliviertassinari

comment created time in 14 hours

PullRequestReviewEvent

Pull request review commentmui-org/material-ui

 describe('<Paper />', () => {    describe('prop: square', () => {     it('can disable the rounded class', () => {-      const { getByTestId } = render(-        <Paper data-testid="root" square>-          Hello World-        </Paper>,-      );--      expect(getByTestId('root')).not.to.have.class(classes.rounded);+      const { container } = render(<Paper square>Hello World</Paper>);+      expect(container.firstChild).not.to.have.class(classes.rounded);

Why do we need a more robust version? Which problem in the future is it meant to edge against?

I think that using container.firstChild puts a healthy constrain in place, as it makes it more painful to have components that host multiple DOM nodes.

oliviertassinari

comment created time in 14 hours

PullRequestReviewEvent

push eventmui-org/material-ui

l10nbot

commit sha d5debd389167a5c522a7da8e4e8adb31837083f4

[docs] Sync translations (#22887)

push time in 14 hours

delete branch mui-org/material-ui

delete branch : l10n_master

delete time in 14 hours

PR merged mui-org/material-ui

[docs] Sync translations On hold docs

+280 -289

199 commit in mui-org/material-ui/tree/l10n_master mui-org/material-ui/tree/master

1 comment

153 changed files

l10nbot

pr closed time in 14 hours

commit sha 349e7fd7a5ec4e74452702c2642e89dce8905671

[test] Prefer container.firstChild

push time in 14 hours

commit sha da3866eef6f672ba3a862c294e3463c212a2de0a

fix build

push time in 14 hours

push eventmui-org/material-ui

commit sha 4a7d42541ff414df163efe9e0879675d09e7c8f2

run ci

[docs] Fix few propTypes in Inputs

push time in 15 hours

pull request commentmui-org/material-ui

@youknowhat Thanks

youknowhat

comment created time in 15 hours

push eventmui-org/material-ui

junghyun park

commit sha 407d2bbf10ac06a4011cbfc78114e342bf1e381c

[docs] Fix few propTypes in Inputs (#23331)

push time in 15 hours

PR merged mui-org/material-ui

[docs] Fix few propTypes in Inputs docs

[ ] I have followed (at least) the PR section of the contributing guide.

+63 -63

4 commit in youknowhat/material-ui/tree/inputs-proptypes mui-org/material-ui/tree/next

1 comment

32 changed files

youknowhat

pr closed time in 15 hours

push eventmui-org/material-ui

commit sha 59fb474349d84de7a5a69682014fbdc0e6d6801c

[docs] Update homepage quotes (#23326)

push time in 15 hours

push eventmui-org/material-ui

commit sha ba55d828f78457a885ebf4339c6bbea51ab774c6

[docs] Update homepage quotes (#23326)

push time in 15 hours

PR merged mui-org/material-ui

[docs] Update homepage quotes docs

+42 -17

3 commit in mbrookes/material-ui/tree/docs-update-quotes mui-org/material-ui/tree/master

5 comments

1 changed file

mbrookes

pr closed time in 15 hours

push eventmui-org/material-ui

Sujin Lee

commit sha e1e3d712bacec6ceba52dac43aa7b390c35a3667

[AppBar] Remove z-index when position="static" (#23325)

[AppBar] Remove z-index when position="static"

push time in 16 hours

issue closedmui-org/material-ui

<AppBar /> has a CSS rule of z-index: 1100, even if the prop position is static. It caused some problems in my program

I extracted the key code on the codepen: https://codepen.io/chocolatl/pen/XWWXrxg

Each .container have a .navbar. .navbar sets position: static and z-index: 1100 to simulate <AppBar />

It is expected that the internal .navbar will be on top but covered by the external .navbar. If you delete z-index: 1100 you can see it as expected.

I searched and found that if the parent element is flex, then the z-index of the child element will take effect, even if the position is static: https://drafts.csswg.org/css-flexbox-1/#painting

So should z-index be removed when postion is static?

closed time in 16 hours

Chocolatl

PR merged mui-org/material-ui

[AppBar] Remove z-index when position="static" breaking change bug 🐛 component: AppBar

Breaking changes

[AppBar] Remove z-index when position static and relative

Closes #17842

[x] I have followed (at least) the PR section of the contributing guide.

+7 -1

4 commit in sujinleeme/material-ui/tree/issue/AppBar mui-org/material-ui/tree/next

1 comment

2 changed files

sujinleeme

pr closed time in 16 hours

push eventmui-org/material-ui

commit sha 0b2ec9a3e94d5bcce9223e30d87606b5be5ac636

[docs] Fix language cookie (#23324)

push time in 16 hours

PR merged mui-org/material-ui

[docs] Fix language cookie docs

This seems to solve the problem of not respecting a visitor's docs language setting on subsequent visits. There's another issue with the browser constantly reloading a 404 page when the browser language is set, but I haven't tried to resolve that here.

+4 -6

3 commit in mbrookes/material-ui/tree/docs-use-userLanguage mui-org/material-ui/tree/next

1 comment

2 changed files

mbrookes

pr closed time in 16 hours

push eventmui-org/material-ui

Sujin Lee

commit sha d690483eb8c9b16780a2d9fcf27b83fd6c94bfff

[Autocomplete] Follow Material Design State spec (#23323)

[docs] Fix typo in `README.md`

push time in 16 hours

PR merged mui-org/material-ui

[Autocomplete] Follow Material Design State spec component: Autocomplete material design

One chunk of #10870.

+36 -10

5 commit in sujinleeme/material-ui/tree/issue/autocomplete mui-org/material-ui/tree/next

1 comment

3 changed files

sujinleeme

pr closed time in 16 hours

pull request commentmui-org/material-ui

Thanks

mtsknn

comment created time in 16 hours

push eventmui-org/material-ui

Matias Kinnunen

commit sha b34bee772e6d3496c599fd809ab3971f2897da98

[docs] Fix typo in `README.md` (#23329)

push time in 16 hours

PR merged mui-org/material-ui

[docs] Fix typo in `README.md`

[x] I have followed (at least) the PR section of the contributing guide.

+1 -1

1 commit in mtsknn/material-ui/tree/patch-1 mui-org/material-ui/tree/next

1 comment

1 changed file

mtsknn

pr closed time in 16 hours

push eventdmtrKovalenko/material-ui

commit sha d13474d05032c07c36599ca97dd15ba525cd6a15

review

[DataGrid] Apply review from #412

push time in a day

pull request commentmui-org/material-ui-x

Fail because of https://github.com/mui-org/material-ui-x/pull/506#issuecomment-719862668.

oliviertassinari

comment created time in a day

pull request commentmui-org/material-ui-x

[DataGrid] Raf Timer stored in apiRef

Browser tests are flaky after the change. Something is wrong with the logic.

dtassone

comment created time in a day

commit sha 451b1e8f6df57874526d9026697b66ebed064339

yarn docs:typescript:formatted

push time in a day

push eventdmtrKovalenko/material-ui

commit sha 279625dd37fd2e5fde34a08a9dc426de8e8ff917

review

push time in a day

commit sha 5125035c11a627597820f5c0f4a69ba1b69b37ab

Apply suggestions from code review

push time in a day

Pull request review commentmui-org/material-ui

 const blacklist = [   'docs-components-skeleton/Facebook.png', // Flaky image loading   'docs-components-skeleton/SkeletonChildren.png', // flaky image loading   'docs-components-skeleton/YouTube.png', // Flaky image loading+  'docs-components-slider-styled/UnstyledSlider.png', // Unstyled

oliviertassinari

comment created time in a day

PullRequestReviewEvent

PR opened mui-org/material-ui

[core] Batch small changer core umbrella

[test] Skip visual regression not needed: Some of the screenshots aren't necessary. Removing them help with making the CI feedback loop faster. Also, we have x3 the number of workers for Argos-CI. Hopefully, it will no longer be the last CI report we wait for https://github.com/argos-ci/argos/pull/430.
[docs] Add missing table badges: I have forgotten it in the initial pull request
[docs] React vs object
[docs] Link the source used in Wikipedia
[TreeView] TypeScript convention
[docs] Typo
[docs] Apply heading convention: convention defined in

+31 -25

8 commit in oliviertassinari/material-ui/tree/batch-small-changer-v44 mui-org/material-ui/tree/next

0 comment

7 changed files

pr created time in a day

commit sha f099bd0001214817a4325969d0d849f7acc1d069

[docs] Clear the different of table vs data grid right in the start

push time in a day

push eventoliviertassinari/material-ui-x

commit sha 727173f93273b08cede4b9f6f741941dd8ed89da

Apply suggestions from code review