profile
viewpoint
Nicholas C. Zakas nzakas Human Who Codes LLC Mountain View, CA https://humanwhocodes.com

humanwhocodes/computer-science-in-javascript 7281

Collection of classic computer science paradigms, algorithms, and approaches written in JavaScript.

nzakas/cssembed 394

A tool for embedding data URIs in CSS files.

nzakas/cssurl 184

A Node.js utility for safely rewriting URLs in CSS code

billtrik/karma-fixture 77

A plugin for the Karma test runner that loads .html and .json fixtures

humanwhocodes/momoa 63

A JSON parser, tokenizer, traverser, and printer.

nzakas/buildr 46

A project to create macros for common web-related utilities

nzakas/combiner 31

A tool for combining JavaScript and CSS files based on embedded comments.

nzakas/debug-errorpage 26

An error page for use while developing Express apps

nzakas/datauri 16

A utility for generating data URIs from existing files.

humanwhocodes/eslint-simple-rule 15

A utility for creating simple ESLint rules

pull request commenteslint/eslint

Fix: --cache ignores file mtime in CI environments

Thanks for attempting this. I’m not comfortable with reading an environment variable for this purpose — that’s just one assumption too many when determining how ESLint should behave.

We did recently merge this RFC that covers this use case: https://github.com/eslint/rfcs/pull/63

wmhilton

comment created time in 17 hours

PR closed eslint/rfcs

Docs: improve prompt for "Documentation" in template meta

(This is not an RFC.)

In a few RFCs so far, it seems like the "Documentation" section has boiled down to "We will describe how this feature works in the documentation." This commit updates the template to ask some broader questions about how the feature will be communicated to users.

+6 -5

1 comment

1 changed file

not-an-aardvark

pr closed time in 17 hours

pull request commenteslint/rfcs

Docs: improve prompt for "Documentation" in template

We decided not to move forward this change, so closing.

not-an-aardvark

comment created time in 17 hours

PullRequestReviewEvent

push eventeslint/eslint-visitor-keys

Michaël De Boey

commit sha 2d7be11e4d13ac702c9fe3c529cadbd75b370146

Chore: No longer test in Node.js 13 (#17) Node.js 13 EOL

view details

push time in 17 hours

pull request commenteslint/eslint-visitor-keys

chore: Update ci.yml

Gotcha, thanks.

MichaelDeBoey

comment created time in 17 hours

PullRequestReviewEvent

pull request commenteslint/rfcs

New: Configurable List Size For Per-Rule Performance Metrics

Status update: we still need to leave this PR open for public comment for another nine days per our RFC process. Then we go into final commenting for seven days. It looks like there’s good alignment on the team, though, so I don’t expect any hiccups along the way.

bmish

comment created time in 17 hours

push eventhumanwhocodes/pledge

Nicholas C. Zakas

commit sha bbb9d7f12cbd8500ce955d25df605597e1300c86

Fix: Remove call() function

view details

push time in a day

push eventhumanwhocodes/pledge

Nicholas C. Zakas

commit sha 7b0d75d31f977d4cb1ecfc2ccb6a5d6cecc99576

Update: Tweaks to implementation

view details

push time in a day

pull request commenteslint/eslint

Chore: remove mistakenly added file

Thanks for catching and fixing this!

mdjermanovic

comment created time in a day

push eventeslint/eslint

Milos Djermanovic

commit sha 7c34a982aaf93a02348f56c9ce887c7dcf51b5bd

Chore: remove mistakenly added file (#13710)

view details

push time in a day

delete branch eslint/eslint

delete branch : delete-eslint780tgz

delete time in a day

PR merged eslint/eslint

Chore: remove mistakenly added file accepted chore

<!-- Thank you for contributing!

ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).

-->

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update [ ] Bug fix (template) [ ] New rule (template) [ ] Changes an existing rule (template) [ ] Add autofixing to a rule [ ] Add a CLI option [ ] Add something to the core [X] Other, please explain:

Removes mistakenly added eslint-7.8.0.tgz from the root dir.

<!-- If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.) -->

<!-- Please ensure your pull request is ready:

- Read the pull request guide (https://eslint.org/docs/developer-guide/contributing/pull-requests)
- Include tests for this change
- Update documentation for this change (if appropriate)

-->

<!-- The following is required for all pull requests: -->

What changes did you make? (Give an overview)

Removed the file.

Is there anything you'd like reviewers to focus on?

+0 -0

0 comment

1 changed file

mdjermanovic

pr closed time in a day

PullRequestReviewEvent

issue commenteslint/tsc-meetings

TSC meeting 24-September-2020

Agenda item: It's like to revisit the discussion around a community manager. My thinking has changed a bit (mostly about the title and also about how many people we'd want), and want to run my latest thinking by the team to see if we want to move forward.

eslint[bot]

comment created time in a day

pull request commenteslint/website

resolving #781

See the original comment: https://github.com/eslint/website/pull/783#issuecomment-690144168

You most likely have a commit that was created using a different email address.

Pratyush-Saxena

comment created time in 2 days

issue closedeslint/eslint

Unexpected token ) for function call

Tell us about your environment Environment Info:

Node version: v10.17.0 npm version: v6.11.3 Local ESLint version: v7.9.0 (Currently used) Global ESLint version: Not found

What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using? ecmaVersion: 6 sourceType: "script"

Please show your full configuration:

<details> <summary>Configuration</summary>

module.exports = {
  env: {
    commonjs: true,
    es6: true,
    node: true
  },
  extends: [
    'eslint:recommended'
  ],
  parserOptions: {
    ecmaVersion: 6,
    sourceType: "script",
  },
  rules: {
    'no-console': 'warn',
    'no-debugger': 'warn',
    'block-scoped-var': "warn",
    'no-multi-spaces': "warn",
    'array-bracket-newline': ["warn", "consistent"],
    'block-spacing': "warn",
    'brace-style': ["warn", "1tbs"],
    'comma-dangle': ["warn", "always-multiline"],
    'comma-spacing': ["warn", {before: false, after: true}],
    'comma-style': ["warn", "last"],
    'eol-last': ["warn", "always"],
    'func-call-spacing': ["warn", "never"],
    'indent': ["error", 4],
    'key-spacing': ["warn", {mode: "minimum", afterColon: true}],
    'keyword-spacing': ["warn", {before: true, after: true}],
    'linebreak-style': ["warn", "unix"],
    'new-parens': ["warn", "always"],
    'newline-per-chained-call': ["warn", {ignoreChainWithDepth: 3}],
    'no-lonely-if': "warn",
    'no-trailing-spaces': "warn",
    'no-unneeded-ternary': "warn",
    'no-whitespace-before-property': "warn",
    'semi-spacing': ["warn", {before: false, after: true}],
    'space-before-blocks': "warn",
    'space-before-function-paren': ["warn", {anonymous: "never", named: "never", asyncArrow: "always"}],
    'space-infix-ops': ["warn", {"int32Hint": true}],
    'space-unary-ops': ["warn", {words: true, nonwords: false}],
    'spaced-comment': ["warn", "always"],
  }
}

</details>

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

<!-- Paste the source code below: -->

exports.updateActions = function(req, res) {
    /* Must have only the changed actions in parameters to be performant TODO IN FRONT*/
    const promises = []
    for (const action of req.body) {
        promises.push(
            models.Action.update(action, {
                where: {
                    actionId: action.actionId,
                },
            }), // Problem is here
        )
    }
    Promise.all(promises).then(() => {
        return res.sendStatus(200);
    }, err => {
        logger.error('%o', err);
        res.sendStatus(500);
    })
}

<!-- Paste the command you used to run ESLint: -->

eslint app/ --ext .js

What did you expect to happen? No error found

What actually happened? Please include the actual, raw output from ESLint.

eslint app/ --ext .js

/home/simonc/projects/sx-projects-back/app/controllers/actionController.js 33:9 error Parsing error: Unexpected token )

✖ 1 problem (1 error, 0 warnings)

If I remove the comma (see line "Problem is here") the error disappear but I would like to keep this comma because node understand it correctly and it give better commits (like comma-dangle rule)

Are you willing to submit a pull request to fix this bug? No

closed time in 2 days

SimonChaumet

issue closedeslint/eslint

Idea: /* eslint-disable-from-kernel */

some eslint rules are so obnoxious that they deserve to be banned on a kernel level.

closed time in 2 days

yishengjiang99

issue closedeslint/eslint

Please help us getting ESLint 7 support landed for testing-library & create-react-app

Hi team! 👋

I would like to ask if you guys could help us out in getting mysticatea/eslint-utils#7 merged. I already tried contacting @mysticatea in a lot of different ways, but I haven't heard from him since July 16th when he said he would have a look at it the weekend after.

I know OSS relies on the maintainer of the packages and I'm super grateful for all the packages @mysticatea's maintaining, but this PR is blocking (at least) 7 other packages to be able to get ESLint 7 support without any problems. The most important ones are eslint-plugin-testing-library & eslint-config-react-app.

Since @mysticatea seems to be the only person who can publish the package, we're thinking about publishing a fork if this isn't resolved within a week or two. If the @eslint team is willing to take over the package and publish it yourself (since it's a generic enough package) that would be awesome, but we're also willing to take ownership of the package if necessary.

Hopefully we can get this sorted out and we can enjoy all the lovely packages.

Thanks for helping us out! 👊

CC all people involved in the depending PRs: @Belco90 @iansu @ianschmitz @kentcdodds @mrmckeb @nickmccurdy

closed time in 2 days

MichaelDeBoey

issue commenteslint/eslint

Please help us getting ESLint 7 support landed for testing-library & create-react-app

Just a reminder that this repo is for issues related directly to ESLint. It’s not appropriate to file issues here about a project we don’t maintain just because the maintainer also happens to maintain ESLint.

MichaelDeBoey

comment created time in 2 days

pull request commenteslint/rfcs

New: Improve debugging for RuleTester

I guess I’m used to the it.only process of getting that test working and then checking to see if any other tests broke, so that doesn’t bother me too much.

I’m not sold on this proposal as of this moment, but let’s see what others think.

CoryDanielson

comment created time in 2 days

push eventeslint/eslint

Nicholas C. Zakas

commit sha de00f0ecd6537a36c65529de83c49f886ab4fc27

A bit of cleanup

view details

push time in 2 days

PR opened eslint/eslint

Chore: Refactor CLIEngine tests (refs #13481) accepted chore core

<!-- Thank you for contributing!

ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).

-->

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update [ ] Bug fix (template) [ ] New rule (template) [ ] Changes an existing rule (template) [ ] Add autofixing to a rule [ ] Add a CLI option [ ] Add something to the core [x] Other, please explain:

Refactored a test

<!-- If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.) -->

<!-- Please ensure your pull request is ready:

- Read the pull request guide (https://eslint.org/docs/developer-guide/contributing/pull-requests)
- Include tests for this change
- Update documentation for this change (if appropriate)

-->

<!-- The following is required for all pull requests: -->

What changes did you make? (Give an overview)

I removed the in-memory file system from the CLIEngine tests and replaced it with an actual filesystem. This is important for working on simple config because the in-memory filesystem does all kinds of complicated things to "fake" a filesystem, and it's impossible to reuse that to test that simple config doesn't break anything.

This change keeps all of the tests working the exact same way they did previously, only with an actual filesystem. That will allow me to eventually start using exports from @eslint/eslintrc inside CLIEngine and tell if I broke anything.

I'll need to do the same for the rest of the places in the tests where in-memory filesystems are used, so this is the first of a few such refactors.

Is there anything you'd like reviewers to focus on?

Anything obvious look out of place?

+1082 -842

0 comment

2 changed files

pr created time in 2 days

create barncheslint/eslint

branch : simple-config-step-2

created branch time in 2 days

Pull request review commenteslint/rfcs

New: Improve debugging for RuleTester

+- Repo: eslint/eslint+- Start Date: 2020-09-21+- RFC PR: (leave this empty, to be filled in later)+- Authors: [CoryDanielson](https://github.com/corydanielson)++# `RuleTester` debugger improvements++## Summary++Add a `before` hook to the valid/invalid code configuration, so that developers can inject a debugger into RuleTester before code is passed into the rule being tested.++## Motivation++Giving developers a mechanism to add a debugger before specific code is passed into their rule, would streamline and improve the developer experience when writing rules. Currently, when a developer wants to debug their rule against specific test code they will most likely do one of the following:+    1. Comment out the other test code blocks - the developer will be unable to see if they have broken an existing test while changing code.+    2. Rearrange the test code blocks so that the one they wish to debug comes first - this discourages or breaks organization+    3. Press the "Play/Resume" button while debugging X times until the debugger is paused at the code block they want to debug - tedious, especially when there are lots of tests or add new ones (X may change)+    4. Some clever conditional debugging - the developer is spending time writing conditional debugger logic instead of the eslint rule.++## Detailed Design++1. Add an optional `before` function property to the config for valid/invalid code.+2. Update RuleTester to call this function (if it exists) just prior to the valid/invalid code being passed into the rule.+3. If the autofix code is tested as well, the before hook should be called before that as well.+4. Because of the potential to call the `before` hook twice - it may make sense to pass in an argument that defines when this code is being called. (ie a string: 'create' | 'fix') This would enable a developer to conditionally debug whichever code they want.

This seems very unexpected. Can you explain why it would be run twice?

CoryDanielson

comment created time in 3 days

Pull request review commenteslint/rfcs

New: Improve debugging for RuleTester

+- Repo: eslint/eslint+- Start Date: 2020-09-21+- RFC PR: (leave this empty, to be filled in later)+- Authors: [CoryDanielson](https://github.com/corydanielson)++# `RuleTester` debugger improvements++## Summary++Add a `before` hook to the valid/invalid code configuration, so that developers can inject a debugger into RuleTester before code is passed into the rule being tested.

I’m a bit worried at how focused this is on the debugger case. Are there any other potential uses?

CoryDanielson

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commenteslint/eslint-visitor-keys

chore: Update ci.yml

Can you please describe the purpose of this change?

MichaelDeBoey

comment created time in 3 days

Pull request review commenteslint/website

resolving #781

+{+    "editor.autoSave": "on"

I think this was included by mistake. Can you delete this file?

Pratyush-Saxena

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventeslint/eslint

Nicholas C. Zakas

commit sha 30b76c9a13fae3dff59f7db406d6c66f11152973

Docs: Clarify package.json requirement in Getting Started (refs #13549) (#13696) * Docs: Clarify package.json requirement in Getting Started (refs #13549) * Update docs/user-guide/getting-started.md

view details

push time in 3 days

delete branch eslint/eslint

delete branch : getting-started-update

delete time in 3 days

PR merged eslint/eslint

Docs: Clarify package.json requirement in Getting Started (refs #13549) documentation evaluating

<!-- Thank you for contributing!

ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).

-->

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update [ ] Bug fix (template) [ ] New rule (template) [ ] Changes an existing rule (template) [ ] Add autofixing to a rule [ ] Add a CLI option [ ] Add something to the core [ ] Other, please explain:

<!-- If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.) -->

<!-- Please ensure your pull request is ready:

- Read the pull request guide (https://eslint.org/docs/developer-guide/contributing/pull-requests)
- Include tests for this change
- Update documentation for this change (if appropriate)

-->

<!-- The following is required for all pull requests: -->

What changes did you make? (Give an overview)

Clarifies that a package.json file is necessary to use --init in the Getting Started guide. (it errors currently when there is no package.json file present)

Is there anything you'd like reviewers to focus on?

Is this clear enough?

+3 -1

0 comment

2 changed files

nzakas

pr closed time in 3 days

issue commenteslint/tsc-meetings

TSC meeting 24-September-2020

Agenda item: Let's discuss the changes we'll be making to how we manage Tidelift payments and ensure everyone is signed up.

eslint[bot]

comment created time in 3 days

push eventhumanwhocodes/pledge

Thomas Plaçais

commit sha 5ba13a1546774a83322eb6be56aa90985a0bf9af

Docs: Update README.md (#1)

view details

push time in 6 days

PR merged humanwhocodes/pledge

Update README.md
+1 -1

0 comment

1 changed file

BlueGone

pr closed time in 6 days

PullRequestReviewEvent

issue commentnzakas/understandinges6

Potential typo in 11 - Promises - Non-Promise Thenables

Yeah, your wording makes sense.

ronen-e

comment created time in 6 days

pull request commenteslint/website

icons added

Much better! The only thing we need now is to replace the “OpenJs Foundation” link with the full URL (as we currently have on the site).

And please don’t forget to address the CLA email issue.

Thanks!

Pratyush-Saxena

comment created time in 6 days

PullRequestReviewEvent

issue commenteslint/eslint

Allow for dynamic import() to be used in eslint config file

I’ll keep an eye out as I go. Node.js ESM support is still considered experimental, so definitely worth following up with them about this issue.

KilianKilmister

comment created time in 6 days

release humanwhocodes/pledge

v0.1.0

released time in 6 days

created taghumanwhocodes/pledge

tagv0.1.0

A custom promise implementation for JavaScript

created time in 6 days

push eventhumanwhocodes/pledge

Nicholas C. Zakas

commit sha 2910c423e13630a4a2408dea8524067ab72aada8

0.1.0

view details

push time in 6 days

push eventeslint/eslint

Nicholas C. Zakas

commit sha 52b45c6b028f80e00fda4db0705ca776cf086320

Update docs/user-guide/getting-started.md

view details

push time in 6 days

Pull request review commenteslint/eslint

Docs: Clarify package.json requirement in Getting Started (refs #13549)

 $ npx eslint --init $ yarn run eslint --init ``` +**Note:** `--init` assumes you have a `package.json` file already. If you don't, make sure to run `npm init` or `yarn create` beforehand.
**Note:** `--init` assumes you have a `package.json` file already. If you don't, make sure to run `npm init` or `yarn init` beforehand.
nzakas

comment created time in 6 days

PullRequestReviewEvent

Pull request review commenteslint/eslint

Docs: Clarify package.json requirement in Getting Started (refs #13549)

 $ npx eslint --init $ yarn run eslint --init ``` +**Note:** `--init` assumes you have a `package.json` file already. If you don't, make sure to run `npm init` or `yarn create` beforehand.

Oops, yes

nzakas

comment created time in 6 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commenteslint/eslint

Allow registering parsers with Node.js API

@molisani the new config system is fairly well defined. You can get more details by visiting the issue I linked to. I really don’t want to add something that will be deprecated once the new config system is complete.

@mdjermanovic we are actually deprecating context.parserPath as part of the config changes. It will be replaced by context.parser.

molisani

comment created time in 8 days

issue closedeslint/eslint

eslint not registered as command after install

<!-- ESLint adheres to the Open JS Foundation Code of Conduct: https://eslint.org/conduct

This template is for bug reports. If you are here for another reason, please see below:

1. To propose a new rule: https://eslint.org/docs/developer-guide/contributing/new-rules
2. To request a rule change: https://eslint.org/docs/developer-guide/contributing/rule-changes
3. To request a change that is not a bug fix, rule change, or new rule: https://eslint.org/docs/developer-guide/contributing/changes
4. If you have any questions, please stop by our chatroom: https://eslint.org/chat

Note that leaving sections blank will make it difficult for us to troubleshoot and we may have to close the issue.

-->

Tell us about your environment

eslint : The term 'eslint' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the 
spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ eslint --env-info
+ ~~~~~~
    + CategoryInfo          : ObjectNotFound: (eslint:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
  • ESLint Version: ?
  • Node Version: v12.18.3
  • npm Version: 6.14.6

What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using? default

Please show your full configuration:

<details> <summary>Configuration</summary>

<!-- Paste your configuration below: -->

?

</details>

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

<!-- Paste the source code below: -->

//

<!-- Paste the command you used to run ESLint: -->

eslint --init 

What did you expect to happen? It to do stuff

What actually happened? Please include the actual, raw output from ESLint.

eslint : The term 'eslint' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the 
spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ eslint --init
+ ~~~~~~
    + CategoryInfo          : ObjectNotFound: (eslint:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Are you willing to submit a pull request to fix this bug? No

closed time in 8 days

MMK21Hub

issue commenteslint/eslint

Allow registering parsers with Node.js API

It's worth noting that this plugin strategy is going to change completely with the new config system in development. As such, we aren't making any further changes to the current config system (it will make achieving backwards compatibility a lot harder). With the new config system, ESLint will no longer be doing any module resolving and you'll be able to slide in any object from anywhere you so choose.

molisani

comment created time in 8 days

PR opened eslint/eslint

Docs: Clarify package.json requirement in Getting Started (refs #13549) documentation evaluating

<!-- Thank you for contributing!

ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).

-->

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update [ ] Bug fix (template) [ ] New rule (template) [ ] Changes an existing rule (template) [ ] Add autofixing to a rule [ ] Add a CLI option [ ] Add something to the core [ ] Other, please explain:

<!-- If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.) -->

<!-- Please ensure your pull request is ready:

- Read the pull request guide (https://eslint.org/docs/developer-guide/contributing/pull-requests)
- Include tests for this change
- Update documentation for this change (if appropriate)

-->

<!-- The following is required for all pull requests: -->

What changes did you make? (Give an overview)

Clarifies that a package.json file is necessary to use --init in the Getting Started guide. (it errors currently when there is no package.json file present)

Is there anything you'd like reviewers to focus on?

Is this clear enough?

+3 -1

0 comment

2 changed files

pr created time in 8 days

create barncheslint/eslint

branch : getting-started-update

created branch time in 8 days

PR closed eslint/eslint

Update README.md with a workaround for #10618 documentation

<!-- Thank you for contributing!

ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).

-->

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update [ ] Bug fix (template) [ ] New rule (template) [ ] Changes an existing rule (template) [ ] Add autofixing to a rule [ ] Add a CLI option [ ] Add something to the core [ ] Other, please explain:

<!-- If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.) -->

<!-- Please ensure your pull request is ready:

- Read the pull request guide (https://eslint.org/docs/developer-guide/contributing/pull-requests)
- Include tests for this change
- Update documentation for this change (if appropriate)

-->

<!-- The following is required for all pull requests: -->

What changes did you make? (Give an overview)

Added a question to the faq answering some of problems in #10618, which I've recently come across myself. I just need a bit of linting for some javascript and don't want a big node.js setup. I figured providing people with a way to make a quick .eslintrc would be a good idea. Even better would be for Eslint to have that thing called defaults and work out of the box.

Is there anything you'd like reviewers to focus on?

Not really. I'm just making this for my own reference and trying my luck at helping others with the same problem I had.

+34 -0

4 comments

1 changed file

joaotavora

pr closed time in 8 days

PR closed eslint/eslint

Breaking: Reduce carbon footprint by calling ESLint only on first CI job breaking core evaluating

<!-- Thank you for contributing!

ESLint adheres to the [JS Foundation Code of Conduct](https://js.foundation/community/code-of-conduct).

-->

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

  • [ ] Documentation update
  • [ ] Bug fix (template)
  • [ ] New rule (template)
  • [ ] Changes an existing rule (template)
  • [ ] Add autofixing to a rule
  • [ ] Add a CLI option
  • [x] Add something to the core
  • [ ] Other, please explain:

<!-- If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.) -->

<!-- Please ensure your pull request is ready:

- Read the pull request guide (https://eslint.org/docs/developer-guide/contributing/pull-requests)
- Include tests for this change
- Update documentation for this change (if appropriate)

-->

<!-- The following is required for all pull requests: -->

What changes did you make? (Give an overview)

Cal ESLint only on first CI job to reduce unnecessary servers work (e.g., reduce carbon footprint by unnecessary work).

I added ci-job-number. It returns the job numbers and supports many different CI services. For the second and rest jobs, I print warning (with a note of how to disable this behavior) and exit.

The context behind these changes

@pwithnall in his recent talk suggested thinking more about how our open source projects affect the environment. I found an interesting problem with ESLint and how people are using ESLint on CI.

20200801193832

node_js:
  - node
  - "12"
  - "10"
  - "8"
  - "6"

Here is a Travis CI of my PostCSS. Like many other projects, we many jobs to run tests on all actual Node.js versions. In every job we call npm test:

    "test": "eslint . && jest"

As a result, we call ESLint for every Node.js version. But since ESLint provides static analysis, ESLint output will be the same for all Node.js versions. As a result, we have 2-4 unnecessary ESLint calls for all commits for all open source projects with multiple Node.js versions in .travis.yml.

Is there anything you'd like reviewers to focus on?

Is it a real problem?
  • For postcss/postcss every ESLint takes 9 seconds of CPU time.
  • For postcss/postcss we have around 250 commits per year.
  • Let’s count that we have 4 Node.js versions on Travis CI (we had five versions before and now only 3).
  • 1 hour of CPU work gives around 1.7 grams of CO2.
  • 9000 seconds of unnecessary CPU time = 42.5 grams of CO2 per year just for one open-source project.
  • ESLint is used in >3 000 000 projects. Let’s assume that 75% of them are dead (of course, it is not fair to use PostCSS’s CPU/jobs/time statistics, so I took a bigger number for dead projects and didn’t count non-GitHub projects).
  • We can expect that adding this commit could prevent 31 875 Kg of CO2 per year. But please double-check my math or even find a better statistics.
Does somebody already do like this?
  • There is eslint-ci by @JLHwung, which already adds ci-job-number to ESLint. I use eslint-ci in all my open-source projects (including PostCSS, Autoprefoxer, and Browserslist). There are also >200 projects, which use eslint-ci too.
  • I use ci-job-number in my size-limit and check-dts.
  • spech, spelling check tool, also uses ci-job-number.
Why do we need this commit if we have eslint-ci?

People think about Travis CI as a free resource (which is not true). It is hard to convince people to avoid spending free resources if they think resources are free for them personally.

GitHub Actions can be tricky, and jobs can be used not only for Node.js version.

Yeap, found that GitHub Actions workflows can be very tricky, and jobs can be used not only to test different Node.js versions.

This is why we removed GitHub Actions support from ci-job-number. On GitHub Actions, ESLint will run on every job.

We are collecting feedback and evolving ci-job-number to have predicted results of every CI service.

+10 -0

12 comments

2 changed files

ai

pr closed time in 8 days

pull request commenteslint/eslint

Breaking: Reduce carbon footprint by calling ESLint only on first CI job

Thanks everyone, we're not moving forward with this pull request. If anyone would like to submit a tutorial on setting up ESLint in a CI environment (as discussed previously) please feel free.

ai

comment created time in 8 days

pull request commenteslint/website

icons added

That's what I'm seeing, too. Removing the OpenJS Foundation logo will help. I'd also like to see "Edit this page" either on a separate line from the icons or have the icons aligned to the right of the page to separate them from "Edit this page" (only on mobile, of course)

Pratyush-Saxena

comment created time in 8 days

Pull request review commenteslint/rfcs

Update: move init command to eslint-cli

 We will make use of tools like `npx` to simply run `npx @eslint/create` or using    used. Be sure to define any new terms in this section. --> -The implementation is mainly migrating the code from main repo to `eslint-cli`. As far as the modules are concerned, all shared modules are being shipped currently with the eslint so we can use those modules through eslint itself. -As far as the `eslint-recommended` rules are concerned, it will be done as a copy paste to the `@eslint/create` repo. +The implementation is mainly migrating the code from main repo to `@eslint/create`. As far as the modules are concerned, all shared modules are being shipped currently with the eslint so we can use those modules through eslint itself. ++The approach would be following these steps++- Move the `eslint/lib/init/*` to the new repo's `src/*` directory+- Add the following `dependencies` in `package.json`+  - `enquirer`+  - `progress`+  - `semver`+  - `espree` (peer)+  - `lodash`+  - `json-stable-stringify-without-jsonify`+  - `cross-spawn`+  - `eslint` (peer)+  - `debug` (peer)+- for all those modules coming inside `../**/*`, it would be replaced using `eslint/**/*`+- For `tests`, move the `tests/lib/init` to new repo's `tests/init`+- Add the following `devDependencies` in `package.json`+  - `chai`+  - `sinon`+  - `js-yaml`+  - `proxyquire`+  - `shelljs`+- create `tests/utils` and add the following functions +  - [`defineInMemoryFs`](https://github.com/eslint/eslint/blob/6677180495e16a02d150d0552e7e5d5f6b77fcc5/tests/_utils/in-memory-fs.js#L250)+- for `conf/*`, it is not a part of the public API and it cant be accessed from `eslint` module, we need a keep these synced with the main repo (`eslint`). We can choose from the following approach to solve this : +  - using the `eslint-github-bot`, whenever there is a PR opened that changes the file for the `conf` directory in `eslint` repo, create an issue in the `@eslint/create` repo to have a look in the PR and if required submit a change in `@eslint/create`.+  - OR, while doing the release for both `eslint` and `@eslint/create` repos, the release script can be configured to copy-parse the `conf` folder from `eslint` to `@eslint/create` before the release just like the `website` repo is being updated currently. +- After completion of this repo, whenever someone uses the `--init` flag, an error will be thrown stating the correct step to do the migration i.e using `npx @eslint/create` or `npm @eslint` or `yarn @eslint`. I am not suggesting to use run the `@eslint/create` module whenever `--init` command is being called because this would require to use the `@eslint/create` module as a dependency in `eslint` and in `@eslint/create` we are already being using `eslint` as a dependency, so there would be circular dependencies.

Okay, sounds like we are on the right track. I'd suggest updating this RFC with the latest agreements. I think we're close!

anikethsaha

comment created time in 8 days

PullRequestReviewEvent

delete branch eslint/website

delete branch : dependabot/npm_and_yarn/node-fetch-2.6.1

delete time in 8 days

push eventeslint/website

dependabot[bot]

commit sha 6be63de3edf78b3557fbb6f8d20e9b5e091aef63

Upgrade: Bump node-fetch from 2.6.0 to 2.6.1 (#784) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 8 days

PR merged eslint/website

Upgrade: Bump node-fetch from 2.6.0 to 2.6.1 dependencies

Bumps node-fetch from 2.6.0 to 2.6.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bitinn/node-fetch/releases">node-fetch's releases</a>.</em></p> <blockquote> <h2>v2.6.1</h2> <p><strong>This is an important security release. It is strongly recommended to update as soon as possible.</strong></p> <p>See <a href="https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md#v261">CHANGELOG</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md">node-fetch's changelog</a>.</em></p> <blockquote> <h2>v2.6.1</h2> <p><strong>This is an important security release. It is strongly recommended to update as soon as possible.</strong></p> <ul> <li>Fix: honor the <code>size</code> option after following a redirect.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/node-fetch/node-fetch/commit/b5e2e41b2b50bf2997720d6125accaf0dd68c0ab"><code>b5e2e41</code></a> update version number</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/2358a6c2563d1730a0cdaccc197c611949f6a334"><code>2358a6c</code></a> Honor the <code>size</code> option after following a redirect and revert data uri support</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/8c197f8982a238b3c345c64b17bfa92e16b4f7c4"><code>8c197f8</code></a> docs: Fix typos and grammatical errors in README.md (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/686">#686</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/1e99050f944ac435fce26a9549eadcc2419a968a"><code>1e99050</code></a> fix: Change error message thrown with redirect mode set to error (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/653">#653</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/244e6f63d42025465796e3ca4ce813bf2c31fc5b"><code>244e6f6</code></a> docs: Show backers in README</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/6a5d192034a0f438551dffb6d2d8df2c00921d16"><code>6a5d192</code></a> fix: Properly parse meta tag when parameters are reversed (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/682">#682</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/47a24a03eb49a49d81b768892aee10074ed54a91"><code>47a24a0</code></a> chore: Add opencollective badge</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/7b136627c537cb24430b0310638c9177a85acee1"><code>7b13662</code></a> chore: Add funding link</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/5535c2ed478d418969ecfd60c16453462de2a53f"><code>5535c2e</code></a> fix: Check for global.fetch before binding it (<a href="https://github-redirect.dependabot.com/bitinn/node-fetch/issues/674">#674</a>)</li> <li><a href="https://github.com/node-fetch/node-fetch/commit/1d5778ad0d910dbd1584fb407a186f5a0bc1ea22"><code>1d5778a</code></a> docs: Add Discord badge</li> <li>Additional commits viewable in <a href="https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~akepinski">akepinski</a>, a new releaser for node-fetch since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+5 -5

2 comments

2 changed files

dependabot[bot]

pr closed time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commenteslint/eslint

Per-rule performance measure and bootstraping costs

Thanks for the followup from Twitter. I wasn't involved with building out this feature, so I'm not sure if this is even possible, but we'll see what the others think.

alexeyraspopov

comment created time in 8 days

push eventeslint/website

Nicholas C. Zakas

commit sha 41e67797681c63501d23bd90eb27a2c9e84726a6

New: Post about supporting our dependencies (#789) * New: Post about supporting our dependencies * Update _posts/2020-09-16-supporting-eslint-dependencies.md Co-authored-by: Ilya Volodin <ivolodin@gmail.com> Co-authored-by: Ilya Volodin <ivolodin@gmail.com>

view details

push time in 8 days

PR merged eslint/website

New: Post about supporting our dependencies blog post

This is the promised post about how we are sponsoring our dependencies. It's set to publish on Wednesday.

+23 -0

1 comment

1 changed file

nzakas

pr closed time in 8 days

push eventestree/estree

Huáng Jùnliàng

commit sha 390a050fd2d6a7b69688f1434e0929d7c7455d05

add class-access-expressions (#237)

view details

push time in 9 days

PR merged estree/estree

add class-access-expressions

View Rendered Text

This PR adds Class Property Access Expressions support. The proposal is seeking stage 2 advancement in September meeting.

+23 -0

0 comment

1 changed file

JLHwung

pr closed time in 9 days

issue commenteslint/website

Remove dead links to "jslinterrors.com" since domain does not exists

I think the best two options here are 1) do nothing, or 2) add a header that says “You are viewing documentation for an older version of ESLint. Click here for the most recent version.”

I don’t want to edit the actual content.

oliverhr

comment created time in 9 days

PullRequestReviewEvent

PR closed eslint/tsc-meetings

Add TSC meeting 10-September-2020 transcript triage

Add TSC meeting 10-September-2020 transcript.

This PR is autogenerated by the "Generate Transcript" GitHub Action.

+3 -0

2 comments

1 changed file

github-actions[bot]

pr closed time in 10 days

pull request commenteslint/tsc-meetings

Add TSC meeting 10-September-2020 transcript

Closing since we did not have a meeting.

github-actions[bot]

comment created time in 10 days

issue commenteslint/eslint

Vscode and atom highlight locations are unexpected when end location is not provided

@fisker I’d suggest opening a separate issue to discuss your idea.

golopot

comment created time in 10 days

pull request commenteslint/eslint-canary

Update: Project commits (except Node) for ESLint 6.x

I think figuring out who knows about how we are using this would be good. :) I don’t feel comfortable merging in my own.

platinumazure

comment created time in 10 days

push eventeslint/website

Nicholas C. Zakas

commit sha 107f832094bf844669eeb532189e24d42fa8ed04

Update _posts/2020-09-16-supporting-eslint-dependencies.md Co-authored-by: Ilya Volodin <ivolodin@gmail.com>

view details

push time in 10 days

Pull request review commenteslint/website

New: Post about supporting our dependencies

+---+title: "Supporting ESLint's dependencies"+tags:+  - Sponsorships+  - Donations+  - Dependencies+---++# Supporting ESLint's dependencies++When ESLint first started accepting donations, it was with the explicit goal of creating a sustainable future for the project. In the short term, that meant ensuring we could compensate those who spent a significant amount of time on the project, but we always intended that to be a starting point and not an end. There is so much more that goes into open source sustainability and we wanted to be mindful of that as we continued to grow. That's why we're excited to announce that we're now supporting several of the projects that ESLint itself is built upon.++Sponsors choose to support ESLint because they have come to depend on ESLint, and as such, want to ensure that the project continues. Similarly, ESLint is built on top of smaller open source projects, and we feel like it is our responsibility to also help those projects thrive. We're grateful to our sponsors for helping us get to 50% of our $20,000/month goal, and we feel that it's time to spread some of that success to our dependencies. As such, we've budgeted part of our donations for our dependencies.++Today we are happy to announce that we've started donating $100/month to each of the following projects (and one person):++* [Ajv](https://npmjs.com/package/ajv) is a JSON schema validator that ESLint uses to validate configuration.+* [Eleventy](https://www.11ty.dev/) is a Node.js-based static site generator that we use to create [eslint.org](http://eslint.org).+* [Sindre Sorhus](https://sindresorhus.com/) is a prolific open source developer, and ESLint uses several of his modules, including [`chalk`](https://npmjs.com/package/chalk), [`globals`](https://npmjs.com/package/globals), [`import-fresh](https://npmjs.com/package/import-fresh), [`strip-ansi`](https://npmjs.com/package/strip-ansi), and [`strip-json-comments`](https://npmjs.com/package/strip-json-comments).

Thanks

nzakas

comment created time in 10 days

PullRequestReviewEvent

issue closedeslint/website

Example for linter.defineParser uses old "parse" API

The code example in the documentation for eslint.defineParser at https://eslint.org/docs/developer-guide/nodejs-api#linterdefineparser

uses the old "parse" API.

Change to "parseForESLint" to reflect latest ESLint API.

Yes, I am happy to provide a PR.

closed time in 10 days

cschuller

issue commenteslint/website

Example for linter.defineParser uses old "parse" API

Thanks. As mentioned in the PR, parse() is still applicable and parseForESLint() is only there for when people want to provide additional functionality that is specific to Eslint.

cschuller

comment created time in 10 days

PR closed eslint/website

Fix: use parseForESLint API (fixes #785) triage
+1 -1

4 comments

1 changed file

cschuller

pr closed time in 10 days

pull request commenteslint/website

Fix: use parseForESLint API (fixes #785)

Thanks for the suggestion. It's not required for parsers to use parseForESLint(), which is why it's not included in this page. We use parse() if parseForESLint() is not present.

cschuller

comment created time in 10 days

PR opened eslint/website

New: Post about supporting our dependencies blog post

This is the promised post about how we are sponsoring our dependencies. It's set to publish on Wednesday.

+23 -0

0 comment

1 changed file

pr created time in 10 days

create barncheslint/website

branch : dependencies-post

created branch time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commenteslint/rfcs

Update: move init command to eslint-cli

 We will make use of tools like `npx` to simply run `npx @eslint/create` or using    used. Be sure to define any new terms in this section. --> -The implementation is mainly migrating the code from main repo to `eslint-cli`. As far as the modules are concerned, all shared modules are being shipped currently with the eslint so we can use those modules through eslint itself. -As far as the `eslint-recommended` rules are concerned, it will be done as a copy paste to the `@eslint/create` repo. +The implementation is mainly migrating the code from main repo to `@eslint/create`. As far as the modules are concerned, all shared modules are being shipped currently with the eslint so we can use those modules through eslint itself. ++The approach would be following these steps++- Move the `eslint/lib/init/*` to the new repo's `src/*` directory+- Add the following `dependencies` in `package.json`+  - `enquirer`+  - `progress`+  - `semver`+  - `espree` (peer)+  - `lodash`+  - `json-stable-stringify-without-jsonify`+  - `cross-spawn`+  - `eslint` (peer)+  - `debug` (peer)+- for all those modules coming inside `../**/*`, it would be replaced using `eslint/**/*`+- For `tests`, move the `tests/lib/init` to new repo's `tests/init`+- Add the following `devDependencies` in `package.json`+  - `chai`+  - `sinon`+  - `js-yaml`+  - `proxyquire`+  - `shelljs`+- create `tests/utils` and add the following functions +  - [`defineInMemoryFs`](https://github.com/eslint/eslint/blob/6677180495e16a02d150d0552e7e5d5f6b77fcc5/tests/_utils/in-memory-fs.js#L250)+- for `conf/*`, it is not a part of the public API and it cant be accessed from `eslint` module, we need a keep these synced with the main repo (`eslint`). We can choose from the following approach to solve this : +  - using the `eslint-github-bot`, whenever there is a PR opened that changes the file for the `conf` directory in `eslint` repo, create an issue in the `@eslint/create` repo to have a look in the PR and if required submit a change in `@eslint/create`.+  - OR, while doing the release for both `eslint` and `@eslint/create` repos, the release script can be configured to copy-parse the `conf` folder from `eslint` to `@eslint/create` before the release just like the `website` repo is being updated currently. +- After completion of this repo, whenever someone uses the `--init` flag, an error will be thrown stating the correct step to do the migration i.e using `npx @eslint/create` or `npm @eslint` or `yarn @eslint`. I am not suggesting to use run the `@eslint/create` module whenever `--init` command is being called because this would require to use the `@eslint/create` module as a dependency in `eslint` and in `@eslint/create` we are already being using `eslint` as a dependency, so there would be circular dependencies.

Are linter and CLIEngine used outside of auto config?

anikethsaha

comment created time in 14 days

PullRequestReviewEvent

pull request commenteslint/website

icons added

This looks like a good first pass. Please take a look at https://deploy-preview-783--eslint.netlify.app/, which previews the site with the change. It looks like the changes are a bit jumbled on mobile. Can you take a look?

Pratyush-Saxena

comment created time in 14 days

pull request commenteslint/website

icons added

Thanks for taking a look at this. If you could please take a look at adding the email you used for this commit, we need to get the CLA signature correct.

Pratyush-Saxena

comment created time in 14 days

Pull request review commenteslint/rfcs

Update: move init command to eslint-cli

 We will make use of tools like `npx` to simply run `npx @eslint/create` or using    used. Be sure to define any new terms in this section. --> -The implementation is mainly migrating the code from main repo to `eslint-cli`. As far as the modules are concerned, all shared modules are being shipped currently with the eslint so we can use those modules through eslint itself. -As far as the `eslint-recommended` rules are concerned, it will be done as a copy paste to the `@eslint/create` repo. +The implementation is mainly migrating the code from main repo to `@eslint/create`. As far as the modules are concerned, all shared modules are being shipped currently with the eslint so we can use those modules through eslint itself. ++The approach would be following these steps++- Move the `eslint/lib/init/*` to the new repo's `src/*` directory+- Add the following `dependencies` in `package.json`+  - `enquirer`+  - `progress`+  - `semver`+  - `espree` (peer)+  - `lodash`+  - `json-stable-stringify-without-jsonify`+  - `cross-spawn`+  - `eslint` (peer)+  - `debug` (peer)+- for all those modules coming inside `../**/*`, it would be replaced using `eslint/**/*`+- For `tests`, move the `tests/lib/init` to new repo's `tests/init`+- Add the following `devDependencies` in `package.json`+  - `chai`+  - `sinon`+  - `js-yaml`+  - `proxyquire`+  - `shelljs`+- create `tests/utils` and add the following functions +  - [`defineInMemoryFs`](https://github.com/eslint/eslint/blob/6677180495e16a02d150d0552e7e5d5f6b77fcc5/tests/_utils/in-memory-fs.js#L250)+- for `conf/*`, it is not a part of the public API and it cant be accessed from `eslint` module, we need a keep these synced with the main repo (`eslint`). We can choose from the following approach to solve this : +  - using the `eslint-github-bot`, whenever there is a PR opened that changes the file for the `conf` directory in `eslint` repo, create an issue in the `@eslint/create` repo to have a look in the PR and if required submit a change in `@eslint/create`.+  - OR, while doing the release for both `eslint` and `@eslint/create` repos, the release script can be configured to copy-parse the `conf` folder from `eslint` to `@eslint/create` before the release just like the `website` repo is being updated currently. +- After completion of this repo, whenever someone uses the `--init` flag, an error will be thrown stating the correct step to do the migration i.e using `npx @eslint/create` or `npm @eslint` or `yarn @eslint`. I am not suggesting to use run the `@eslint/create` module whenever `--init` command is being called because this would require to use the `@eslint/create` module as a dependency in `eslint` and in `@eslint/create` we are already being using `eslint` as a dependency, so there would be circular dependencies.

If you go through --init now, you get to a point where it asks if you want us to examine the source code files to determine the correct config to use. That's called autoconfig. Most of the functionality is in lib/init/autoconfig.js, so it would just be a matter of removing that file and then removing the associated question that triggers it.

anikethsaha

comment created time in 15 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commenteslint/website

Using Icons insted of text-links

Awesome, we are happy to have the help! Hopefully the setup instructions are clear enough, but let us know if you need any help getting started.

Pratyush-Saxena

comment created time in 15 days

more