profile
viewpoint
Nithish Murcherla nithu0115 @aws Dallas https://www.linkedin.com/in/nithish-kumar-murcherla-24931384/ I write code, and words for myself. Those are attributable to and represent my own views unless otherwise noted :)

nithu0115/eks-logs-collector 63

The project is used to collect System Info, Docker logs, CNI logs and Kubelet logs, and OS logs which would be helpful to troubleshoot Kubernetes(EKS) issues.

nithu0115/event-exporter 23

This tool is used to export Kubernetes events to CloudWatch logs

nithu0115/EKS-configMap-customResource 20

EKS-configMap-customResource is a AWS Lambda backed custom resource to create or update config map with Node Instance Role which would automatically allow worker nodes to join the cluster.

nithu0115/kubectl-ssh-plugin-eks 18

This is plugin to SSH into Worker Nodes running on AWS

nithu0115/cni-k8s-tool 1

amazon-vpc-cni-k8s-tool for IP garbage collection

nithu0115/Kubernetes-EKS-Plugins 1

This repository contains a list of small and useful kubectl plugins I use on a daily basis.

nithu0115/amazon-cloudwatch-logs-for-fluent-bit 0

A Fluent Bit output plugin for CloudWatch Logs

nithu0115/amazon-ecs-agent 0

Amazon Elastic Container Service Agent

nithu0115/amazon-ecs-cli 0

A custom Amazon ECS CLI that eases up the cluster setup process, enables users to run their applications locally or on ECS using the same Docker Compose file format and familiar Compose commands.

nithu0115/amazon-eks-ami 0

Packer configuration for building a custom EKS AMI

push eventnithu0115/aws-node-termination-handler

Nithish

commit sha b2fd34b6931be95191ac40f20db951d5fa29b233

updated readme (#51) updated readme

view details

Brandon Wagner

commit sha 5f7a0fb5edbe4178e22faa9cbb264613ef9b8e58

sync-readme-to-dockerhub: fix env variable for dockerhub password (#52)

view details

Brandon Wagner

commit sha 59d8f4d4ad72d5c600a10ffd3444d70f7b60dce3

Revert "sync-readme-to-dockerhub: fix env variable for dockerhub password (#52)" (#55) i enjoy making the same mistake as well, which is why i'll merge this before the tests complete

view details

Jay Pipes

commit sha e875c2c5660ec3fb670de3a04f0d9d84e15353dd

update PR template with APL2.0 language (#57) Issue #56 We should match the language used in other AWS repos, which states that the contribution is made under Apache 2.0 license terms.

view details

Matthew Becker

commit sha 441ee6c658ccd82ea9800c6cdc815ecd2b114e77

implemented webhook functionality, ability to specify message template and custom headers for each provider, includes integration tests (#54)

view details

Gavin Bunney

commit sha e39070b12f1100514b246f80ca18ec0cca1634cd

Added missing namespace references to helm chart (#58)

view details

Brandon Wagner

commit sha 3a05c937177f8117f6b98f6220364a6d7b7e275f

implement scheduled maintenance events (#60)

view details

Brandon Wagner

commit sha f80b3651373327640dd9b8ea16f181b0b5c95a99

implement cancellation of drain events (#61)

view details

Jillian Montalvo

commit sha 54c5c9091aaf635d5631ff89a1aaf0c3a4b28e15

Adding unit tests for ec2metadata package (#62) stable genius tests

view details

Jillian Montalvo

commit sha 52a1a8055b88fa27c7b8700ced9ec91897d1f3b2

Add drain-event unit test (#64)

view details

Jillian Montalvo

commit sha 9d30b75551bd5a4141406d67c11edb2f0672bcb2

Adding webhook unit tests (#63)

view details

Jillian Montalvo

commit sha 22bbd485e66e6cf858125b5798e5874f1deddff5

Adding drain-event-store tests (#66)

view details

Brandon Wagner

commit sha 3595cf8a7d9dda17d988866e728c45c937bbf230

fix test stability issues (#67)

view details

Brandon Wagner

commit sha 10edd43c914df70c8a59be0dddb2a26a66aaf08b

fix webhook test on push (#68) thanks for nothing stackoverflow

view details

Brandon Wagner

commit sha 2ac9ef49cfc1958f7afbf1e70b863a0a289893fc

helm-sync-test: look at PRs too (#69)

view details

Brandon Wagner

commit sha 9cb71e96d32079cd68eef79cd5d9a7d33c0d6122

remove extra line

view details

Brandon Wagner

commit sha 5807282e116ed0d6ee3c018d9db991bc5f5b642a

implement label action handling for uncordon after reboot (#65)

view details

Brandon Wagner

commit sha 08df41b4d85839161b660819d22521daa499d95b

feature flags for scheduled events and spot interuption added to cli and helm (#71)

view details

Brandon Wagner

commit sha a6d7e6cc567906868f2567ee12fb469da3e537ba

fix supporting build scripts wrt make args (#72)

view details

Brandon Wagner

commit sha af689abbdf945388100d40f688cfac94f8e80ba8

monitor functions return errs and loop in main (#73)

view details

push time in 2 days

push eventnithu0115/aws-controllers-k8s

Ricardo La Rosa

commit sha 5d899c3f9c9ac966fcdf301fa07e430efc68699c

Update controller-tools to v0.4.0

view details

Ricardo La Rosa

commit sha 70c14754073055a9763aac28059212ce576ddbac

Update crd, types and auto-generated code

view details

Prateek gogia

commit sha a5e3cb7da40f295feca6e0f117ed11da3339ebd6

Service names arguments are accepted as case insensitive for make commands

view details

Ricardo La Rosa

commit sha 6bc0fc76a7cfa15ff889d0eb1eb4efc3d85afff7

Merge branch 'main' into update-types

view details

Ricardo La Rosa

commit sha d0ac10fb1ef75ca9c3af7f9df03a0e3f7f1bbcf7

Update crd, rbac for S3

view details

Ricardo La Rosa

commit sha fca149df8cacbd67a5a98acad338c1e6c80f484b

Update types for S3BucketDestination and gen code

view details

Jay Pipes

commit sha 68cf1dcb29e7f87f32f1031559d53cc3cc0e6dbb

Merge pull request #306 from prateekgogia/bug/302 Service names arguments are accepted as case insensitive for make commands

view details

Jay Pipes

commit sha b6f81ac7a08d333885ad5c78a5c3dd9766f38046

Merge pull request #295 from ricardo-larosa/update-types Update crd, types and auto-generated code for S3

view details

Murcherla

commit sha 3812a37777c3b7d111427d2f4da4c9542312f932

sts regional flag

view details

push time in 4 days

pull request commentaws/aws-controllers-k8s

Rely on aws-region cfg or region annotation instead of AWS_REGION variable

Note to reviewers: When I re-generated API Gatewayv2 controller code, because of latest changes to API Gatewayv2 SDK, those new fields are introduced in apigatewayv2 struct.

nithu0115

comment created time in 5 days

push eventnithu0115/aws-controllers-k8s

dependabot[bot]

commit sha eb32268ceb35db34028b0f45b9aa7e14bb54cbc3

Bump github.com/aws/aws-sdk-go from 1.33.21 to 1.34.18 Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.33.21 to 1.34.18. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.33.21...v1.34.18) Signed-off-by: dependabot[bot] <support@github.com>

view details

vijtrip2

commit sha 843c78f38ecf09cbaf85836ff5c2cc8045621d3a

Handling ValidationException in HTTP API creation & status patching. (#271) Generates Go code that checks for required fields in ReadOne Input shapes in the sdkFind method. The generate content now looks like func (rm *resourceManager) sdkFind( r *resource, ) (*resource, error) { // If all the required fields in the input shape are missing, AWS // resource is not created yet. Return NotFound here to indicate // to callers that the resource isn't yet created. if rm.requiredFieldsMissingFromReadOneInput(r) { return nil, ackerr.NotFound } ... } ... func (rm *resourceManager) requiredFieldsMissingFromReadOneInput( r *resource, ) bool { {{ GoCodeRequiredFieldsFromReadOneInput "r" }} } Issue #127

view details

Vijay Tripathi

commit sha 326427aa062cc1c856544a0c53682adebc4b4e61

Changes for successful apigatewayv2 status patching.

view details

Jay Pipes

commit sha 9762f92daac9335a11659b04ac8d5f377c49eb58

Merge pull request #284 from vijtrip2/statuspatch Changes for successful k8s object status patching.

view details

Jay Pipes

commit sha 175bd83677d5002823ecc3309261d17691de6bff

Merge pull request #279 from aws/dependabot/go_modules/github.com/aws/aws-sdk-go-1.34.18 Bump github.com/aws/aws-sdk-go from 1.33.21 to 1.34.18

view details

Kumar Gaurav Sharma

commit sha 468873a49b7535cdbe4a5bbf3b61515e0c1a72b4

ElastiCache generator config for developer preview APIs#289

view details

Kumar Gaurav Sharma

commit sha d837bcc567a9ffbdc955f0ab90e4f02f2b412b7f

Auto generated ACK code for ElastiCache #289

view details

Jay Pipes

commit sha d4924a9722dcf0bbe063c4301b7badc59c3413fb

Merge pull request #290 from kumargauravsharma/main-ec-init Auto generated code for ElastiCache scoped to developer preview APIs

view details

Jay Pipes

commit sha 75692029795b0867ccdae97a199d1d61019b34ac

Add e2e tests for SQS Queues Copies the SNS Topic e2e smoke test and modified it to use the SQS `aws sqs get-queue-url` call instead of `aws sqs get-queue-attributes` since the latter requires the QueueUrl and not the ARN like get-topic-attributes does... Issue #205

view details

Jay Pipes

commit sha 09923136c4e8616ed30062085d7fed82664dc2f8

NotFound when any required field missing in shape In #271, @vijtrip2 added methods that output Go code that checked if the Input shape for ReadOne operations for a resource had required fields and if so, checked that the CR's `Status.{Field}` had a non-nil value, otherwise the `resourceManager.sdkFind()` method would return `NotFound`, indicating to callers (in particular when trying to determine if a newly-created resource already existed) that the backend AWS resource had not been created yet. This patch makes that work generic in two ways: * adds support for when required fields in an Input shape are in the CR's `Spec` struct in addition to the `Status` struct. * adds support for any Input shape, not just the ReadOne operation's Input shape. For SQS, the GetQueueAttributes' Input shape has required fields (QueueUrl) that, if not present in the CR's `Status` struct, indicate the resource has not been created yet. Issue #287

view details

Jay Pipes

commit sha 29360d667ddb3d898623ccb052e6179a0cbc25c9

improve documentation for authorization (#286) This patch adds a diagram and a number of improvements to the documentation describing authorization and permissions concepts in ACK. In addition, it adds recommended IAM Policy ARNs into a `services/$SERVICE/config/iam/recommended-policy-arn` file for our three checked-in ACK service controllers.

view details

vijtrip2

commit sha 3a3a504137fdc1874a8d54c645dcb21156cc0286

apigatewayv2 service controller and smoke test files. (#293) * apigatewayv2 service controller and smoke test files.

view details

kumargauravsharma

commit sha 28eabf6df523210024f7fdcd520e5a576b88d91b

Enable multiple update operations support on single resource (#245) Issue #210 Description of changes: The changes in this PR are to enable custom resource update scenario where Update operation on given resource does not support fields that are supported by its Create method, and there exist specialized methods to update such fields. These specialized method response provides the Resource object indicating the Update on the resource. For example: create-replication-group API arguments include: num-node-groups replicas-per-node-group however, modify-replication-group API arguments does not, instead modify-replication-group-shard-configuration and increase-replica-count, decrease-replica-count APIs corresponds to the related Update. The approach taken in this PR is to add the details of such fields and corresponding custom update methods in the generator.yaml. For example: resources: ReplicationGroup: custom_update_operations: UpdateShardConfiguration: fields: - NumNodeGroups UpdateReplicaCount: fields: - ReplicasPerNodeGroup And custom update methods' (UpdateShardConfiguration and UpdateReplicaCount) implementation is provided in a separate code file: aws-controllers-k8s/services/elasticache/pkg/resource/replication_group/custom_update_api.go These methods are supplied with DiffReporter which helps the code in this file determine the specific Update API to invoke based on the difference in desired, current resource details. Co-authored-by: Kumar Gaurav Sharma <kumargsh@amazon.com>

view details

Jay Pipes

commit sha 1b2910dcee44802f6c9fc1a9baeb2fe6598e7230

update apigwv2 service controller for Diff Recent PR changed the AWSDescriptor interface signature and this PR simply updates the API Gateway V2 service controller to abide by that new interface.

view details

Amine Hilaly

commit sha be5f830c4e69ff7eda22c3a2040273f4e3709188

`ack-generate` calls `git pull` if aws-sdk-go repository already exists

view details

Jay Pipes

commit sha aaffb681058597dd265c9117dcc2a1513fb28ab7

Merge pull request #304 from A-Hilaly/refresh-cache `ack-generate` call `git pull` if aws-sdk-go repository already exist in the cache

view details

Amine Hilaly

commit sha 21627a478beb45e815e8cbab299ab1bd41aa650f

remove petstore and bookstore services

view details

Amine Hilaly

commit sha 5b3f2e73790e5cdc5ea678aca9e7dbed02d3adb3

Add a fake Book runtime.Object implementation for `service_controller_test.go` Use `mocks` for runtime util testing

view details

Jay Pipes

commit sha 4546ae0cf06e81c2557b30c1fc7ff08422ecf544

Merge pull request #305 from A-Hilaly/cleanup Remove petstore and bookstore services

view details

Amine Hilaly

commit sha 34ed5dae3dcd8ed01d12e0a60f3d40141d6a2429

Remove petstore and bookstore integration tests

view details

push time in 5 days

PR opened aws/aws-controllers-k8s

Rely on aws-region cfg or region annotation instead of AWS_REGION variable

Issue #, if available: N/A

Description of changes: This change will help us generate session for ackv1alpha1.AWSRegion passed via annotation instead of rely on user to pass AWS_REGION environment variable to generate session.

Along with this, 2 more changes are introduced:

  1. Regional endpoint parameter instead of global endpoint.
  2. Use session.must instead of session.Newsession() and handle errors which is suggested as best practice as suggested in this GitHub issue

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+27 -24

0 comment

11 changed files

pr created time in 12 days

create barnchnithu0115/aws-controllers-k8s

branch : iam-sts

created branch time in 12 days

push eventaws-samples/voteapp

dependabot[bot]

commit sha ce0b9d20aea39578397009987cbcae719b1e6459

Bump bl from 2.2.0 to 2.2.1 in /src/reports Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Nithish Murcherla

commit sha 56260d626a4853dd877eb3acb4afd6e51497f000

Merge pull request #97 from aws-samples/dependabot/npm_and_yarn/src/reports/bl-2.2.1 Bump bl from 2.2.0 to 2.2.1 in /src/reports

view details

push time in 12 days

PR merged aws-samples/voteapp

Bump bl from 2.2.0 to 2.2.1 in /src/reports dependencies

Bumps bl from 2.2.0 to 2.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rvagg/bl/releases">bl's releases</a>.</em></p> <blockquote> <h2>v2.2.1</h2> <p>Fix unintialized memory access</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rvagg/bl/commit/8cb93f455f0b44fe0ffaee75a3c74c84579dc8c1"><code>8cb93f4</code></a> Bumped v2.2.1</li> <li><a href="https://github.com/rvagg/bl/commit/dacc4ac7d5fcd6201bcf26fbd886951be9537466"><code>dacc4ac</code></a> Fix unintialized memory access</li> <li>See full diff in <a href="https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 12 days

PullRequestReviewEvent

push eventaws-samples/voteapp

dependabot[bot]

commit sha 1fdb1d51ebfd4678e968d52c7b783a80ea055210

Bump bl from 2.2.0 to 2.2.1 in /src/database Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Nithish Murcherla

commit sha f92ba77741520994646555837b17e92d65646349

Merge pull request #98 from aws-samples/dependabot/npm_and_yarn/src/database/bl-2.2.1 Bump bl from 2.2.0 to 2.2.1 in /src/database

view details

push time in 12 days

PR merged aws-samples/voteapp

Bump bl from 2.2.0 to 2.2.1 in /src/database dependencies

Bumps bl from 2.2.0 to 2.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rvagg/bl/releases">bl's releases</a>.</em></p> <blockquote> <h2>v2.2.1</h2> <p>Fix unintialized memory access</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rvagg/bl/commit/8cb93f455f0b44fe0ffaee75a3c74c84579dc8c1"><code>8cb93f4</code></a> Bumped v2.2.1</li> <li><a href="https://github.com/rvagg/bl/commit/dacc4ac7d5fcd6201bcf26fbd886951be9537466"><code>dacc4ac</code></a> Fix unintialized memory access</li> <li>See full diff in <a href="https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 12 days

PullRequestReviewEvent

push eventaws-samples/voteapp

dependabot[bot]

commit sha 39670f05bbb40dea25abe870371dd64146aebae5

Bump bl from 2.2.0 to 2.2.1 in /src/database-proxy Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Nithish Murcherla

commit sha ffbf4b4b0548fc7b579d431cbabe40613118c085

Merge pull request #99 from aws-samples/dependabot/npm_and_yarn/src/database-proxy/bl-2.2.1 Bump bl from 2.2.0 to 2.2.1 in /src/database-proxy

view details

push time in 12 days

PR merged aws-samples/voteapp

Bump bl from 2.2.0 to 2.2.1 in /src/database-proxy dependencies

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps bl from 2.2.0 to 2.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rvagg/bl/releases">bl's releases</a>.</em></p> <blockquote> <h2>v2.2.1</h2> <p>Fix unintialized memory access</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rvagg/bl/commit/8cb93f455f0b44fe0ffaee75a3c74c84579dc8c1"><code>8cb93f4</code></a> Bumped v2.2.1</li> <li><a href="https://github.com/rvagg/bl/commit/dacc4ac7d5fcd6201bcf26fbd886951be9537466"><code>dacc4ac</code></a> Fix unintialized memory access</li> <li>See full diff in <a href="https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 12 days

PullRequestReviewEvent

push eventaws-samples/voteapp

dependabot[bot]

commit sha 1f336e5b7c181661f3bbc62255720c324bf72d91

Bump bl from 2.2.0 to 2.2.1 in /src/web Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Nithish Murcherla

commit sha f99ff15b2a34993f9e8c5693f6aa3fa723ebdb2e

Merge pull request #100 from aws-samples/dependabot/npm_and_yarn/src/web/bl-2.2.1 Bump bl from 2.2.0 to 2.2.1 in /src/web

view details

push time in 12 days

PR merged aws-samples/voteapp

Bump bl from 2.2.0 to 2.2.1 in /src/web dependencies

Bumps bl from 2.2.0 to 2.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rvagg/bl/releases">bl's releases</a>.</em></p> <blockquote> <h2>v2.2.1</h2> <p>Fix unintialized memory access</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rvagg/bl/commit/8cb93f455f0b44fe0ffaee75a3c74c84579dc8c1"><code>8cb93f4</code></a> Bumped v2.2.1</li> <li><a href="https://github.com/rvagg/bl/commit/dacc4ac7d5fcd6201bcf26fbd886951be9537466"><code>dacc4ac</code></a> Fix unintialized memory access</li> <li>See full diff in <a href="https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 12 days

PullRequestReviewEvent

push eventaws-samples/voteapp

dependabot[bot]

commit sha 52cb91f85932c4a514468b477bc83bddadfbad8e

Bump bl from 2.2.0 to 2.2.1 in /src/worker Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Nithish Murcherla

commit sha 4c1c6c0d840046f575ceadc6f85d3ee142d36c10

Merge pull request #101 from aws-samples/dependabot/npm_and_yarn/src/worker/bl-2.2.1 Bump bl from 2.2.0 to 2.2.1 in /src/worker

view details

push time in 12 days

PR merged aws-samples/voteapp

Bump bl from 2.2.0 to 2.2.1 in /src/worker dependencies

⚠️ Dependabot is rebasing this PR ⚠️

If you make any changes to it yourself then they will take precedence over the rebase.


Bumps bl from 2.2.0 to 2.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rvagg/bl/releases">bl's releases</a>.</em></p> <blockquote> <h2>v2.2.1</h2> <p>Fix unintialized memory access</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rvagg/bl/commit/8cb93f455f0b44fe0ffaee75a3c74c84579dc8c1"><code>8cb93f4</code></a> Bumped v2.2.1</li> <li><a href="https://github.com/rvagg/bl/commit/dacc4ac7d5fcd6201bcf26fbd886951be9537466"><code>dacc4ac</code></a> Fix unintialized memory access</li> <li>See full diff in <a href="https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 12 days

PullRequestReviewEvent

push eventaws-samples/voteapp

dependabot[bot]

commit sha 48be9a37eb12ec5d82ae42e1a69e16a60decd8ff

Bump bl from 2.2.0 to 2.2.1 in /src/votes Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Nithish Murcherla

commit sha f3b8ee71574e33c20130d1c219ccc40153b7dbee

Merge pull request #102 from aws-samples/dependabot/npm_and_yarn/src/votes/bl-2.2.1 Bump bl from 2.2.0 to 2.2.1 in /src/votes

view details

push time in 12 days

PR merged aws-samples/voteapp

Bump bl from 2.2.0 to 2.2.1 in /src/votes dependencies

Bumps bl from 2.2.0 to 2.2.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rvagg/bl/releases">bl's releases</a>.</em></p> <blockquote> <h2>v2.2.1</h2> <p>Fix unintialized memory access</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rvagg/bl/commit/8cb93f455f0b44fe0ffaee75a3c74c84579dc8c1"><code>8cb93f4</code></a> Bumped v2.2.1</li> <li><a href="https://github.com/rvagg/bl/commit/dacc4ac7d5fcd6201bcf26fbd886951be9537466"><code>dacc4ac</code></a> Fix unintialized memory access</li> <li>See full diff in <a href="https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 12 days

PullRequestReviewEvent

pull request commentaws/aws-controllers-k8s

changing to zap log

@nithu0115 this needs to be redone. I support the changes for logging, but the remaining changes either belong in a separate PR (NewSession(region)) or are incorrect (the curly braces instead of parens)

Addressed your comments.

nithu0115

comment created time in 16 days

Pull request review commentaws/aws-controllers-k8s

changing to zap log

 spec:         - ./bin/controller         args:         - --aws-account-id-        - "$(AWS_ACCOUNT_ID)"+        - "${AWS_ACCOUNT_ID}"         - --aws-region-        - "$(AWS_REGION)"+        - "${AWS_REGION}"         - --enable-development-logging-        - "$(ACK_ENABLE_DEVELOPMENT_LOGGING)"+        - "${ACK_ENABLE_DEVELOPMENT_LOGGING}"

I wanted to keep this consistent with what we currently have - https://github.com/aws/aws-controllers-k8s/blob/main/services/ecr/config/controller/deployment.yaml#L34. Thus, I made this change.

nithu0115

comment created time in 16 days

PullRequestReviewEvent

Pull request review commentaws/aws-controllers-k8s

changing to zap log

 func (r *reconciler) reconcile(req ctrlrt.Request) error { 	acctID := r.getOwnerAccountID(res) 	region := r.getRegion(res) -	r.log.WithValues(+	log := r.log.WithValues( 		"account_id", acctID, 		"region", region, 		"kind", r.rd.GroupKind().String(), 	)+	log.Info("starting reconcilation")

Done :)

nithu0115

comment created time in 16 days

PullRequestReviewEvent

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 35a57a34ac9ec9f65404a68b6b53ca80cf5f8a04

zap changes

view details

push time in 16 days

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 98bf786c95162f1b7633841b4cc589ba0d84eaad

zap changes

view details

push time in 17 days

push eventnithu0115/aws-controllers-k8s

Michael Hausenblas

commit sha c35f34b1cd387fc4a60597b72e021588a0f21f49

addresses

view details

Jay Pipes

commit sha 5578f0d76f091702128cee7533c2ea024501be7d

Merge pull request #259 from mhausenblas/mh9-234 improves dev preview docs concerning `controller-gen`

view details

Jay Pipes

commit sha 4164023ac2096a062702ece858e8056869247540

handle NotFound from kube API The `pkg/runtime.reconciler.getAWSResource()` method was ignoring NotFound errors, which was resulting in returning (nil, nil) from that function, but functions like `getOwnerAccountID()` were counting on a non-nil AWSResource. We modify the code to simply return nil from `reconcile()` when a resource with a supplied NamespacedName isn't found. Adds a simple `assert_pod_not_restarted` check to each e2e test that verifies the controller pod hasn't been restarted. Issue #257 Issue #166

view details

Murcherla

commit sha d98afa5aa9b0dd4d836f84cf3b73d89be9600611

zap changes

view details

push time in 17 days

pull request commentaws/aws-controllers-k8s

changing to zap log

Shall we regenerate the service controllers in this PR ?

I am happy to re-generate but wanted to check in with @jaypipes to see if we want to introduce any process around this. Fwiw, we should maintain 2 branches (main and dev/staging). This way, whenever we make such breaking changes, we can push to dev and cherry pick to merge into main once we cut new releases.

Spoke to @jaypipes offline and come to a consensus to re-generate service controllers as this is a minimal change. If the change is breaking one or a big one, we will go ahead and merge the PR first without re-generating service controller(s) and then open new PRs for each controller.

nithu0115

comment created time in 17 days

issue commentaws/aws-controllers-k8s

Integration tests fail on Amazon Linux 2

Mockery was installed with Homebrew and it was on the path. I have moved it to $GOPATH/bin using go get github.com/vektra/mockery/v2/.../ but the error is there.

I tried replicating the same steps on AL2 and had no issues. I used ./scripts/install_mockery.sh and manually coped the mockery binary under $GOPATH/bin but haven't tried using Homebrew. Try doing it this way and see if that helps!

smuralee

comment created time in 17 days

issue commentaws/aws-controllers-k8s

Integration tests fail on Amazon Linux 2

@smuralee This seems there is no system headers installed. Either install them sudo yum install make glibc-devel gcc patch or try setting CGO_ENABLED=0 and see if that helps!

smuralee

comment created time in 18 days

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha aaa78553d1b44e49110da4a697a0455069e5e469

changing to zap log

view details

push time in 19 days

PullRequestReviewEvent

Pull request review commentaws/aws-controllers-k8s

Enhance cross resource account management design document

 The proposed solution will solve the problem of cross account management within  Controllers will store AccountIDs and their associated IAM Role ARNs in a `ConfigMap` Kubernetes object. Cluster administrators will be responsible for administrating and updating the `ConfigMap`, and creating the target roles using the AWS Console/CLI. Controllers can reuse and existing IAM Role ARN if it matches the scope they need. -To prevent unauthorized users from making any CRUD operations on resources in different AWS accounts, ACK will associate a unique Namespace to each AccountID, which will help administrators limit access to namespaces using K8s RBAC model, hence limit access to AccountIDs.+To prevent unauthorized users from making any CRUD operations on resources in different AWS accounts, cluster administrators will be able to set an AWS Owner Account ID as an annotation on each namespaces, which will be used by ACK Controllers to override the AWS Account ID that is used the create the resources in that namespace. This will help administrators limit access to namespaces using K8s RBAC model, hence limit access to AccountIDs.

AWS Owner Account ID as an annotation on each namespaces -> namespace override the AWS Account ID that is used the create -> that is used to create

A-Hilaly

comment created time in 20 days

Pull request review commentaws/aws-controllers-k8s

Enhance cross resource account management design document

 metadata:   name: ack-carm-config-map   namespace: default data:-  accounts: |-    123456789012=arn:aws:iam::123456789012:root-    454545454545=arn:aws:iam::454545454545:role/S3Access+  accounts:+    "123456789012": arn:aws:iam::123456789012:root+    "454545454545": arn:aws:iam::454545454545:role/S3Access ``` +In ACK runtime, the reconciler will need to lookup the `ack-carm-config-map` data content to query the value of a particular key. To realise that, the controllers will need keep a cached version of the ConfigMap and frequently update it when changes are made by cluster admins.

s/realise/realize/g will need keep a -> will keep a cached

A-Hilaly

comment created time in 20 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentaws/aws-controllers-k8s

changing to zap log

Shall we regenerate the service controllers in this PR ?

I am happy to re-generate but wanted to check in with @jaypipes to see if we want to introduce any process around this. Fwiw, we should maintain 2 branches (main and dev/staging). This way, whenever we make such breaking changes, we can push to dev and cherry pick to merge into main once we cut new branches.

nithu0115

comment created time in 20 days

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha e36647c9c6ec5a6440b1e52d05ada2e7d1e4dbdc

changing to zap log

view details

push time in 20 days

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha a5aa6294914d0c759a8725b6590807752953968a

changing to zap log

view details

push time in 20 days

pull request commentaws/aws-controllers-k8s

changing to zap log

(Note to reviewer: Change to templates/pkg/crd_manager.go.tpl will require us to re-generate Service controllers)

nithu0115

comment created time in 20 days

PR opened aws/aws-controllers-k8s

changing to zap log

Issue #, if available: N/A

Description of changes:

Switching to zap core logging instead of klog. Part of the motivation for logr was the idea that V level is a bad idea - log lines are all INFO or ERROR. But there are real world scenario when we want know more on what is happening and it is required. We should limit to V(1) (Debug logging) and should not go over that level.

Changes:

  1. Added log-level arg which will either take debug or info log levels
  2. Modified manager.go template to pass in region value to generate create temp credentials to be consistent with config region flag

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+33 -612

0 comment

6 changed files

pr created time in 20 days

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha d5caf9f2d6b4ade34a1d1568427a172e5967d6d4

fixing kind-build-test script when no ROLE_ARN is passed

view details

Michael Hausenblas

commit sha ceebe0cf09c338893caf6e4b94407c5133d58157

Merge pull request #194 from nithu0115/docs1 Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>

view details

Jay Pipes

commit sha 914f5dac5f48976095e0de315ceb78dc6b7af346

Merge pull request #195 from nithu0115/docs2 update testing docs

view details

Jay Pipes

commit sha 048b61ebdae7794fb2051af0ea3bf99dce1ce36e

Revert "fixing kind-build-test script when no ROLE_ARN is passed" This reverts commit d5caf9f2d6b4ade34a1d1568427a172e5967d6d4.

view details

Michael Hausenblas

commit sha ec452ed041fc278fc43028315674d5651d5db208

Merge pull request #196 from jaypipes/undo-194 Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>

view details

Michael Hausenblas

commit sha 47119fe36ee24004a6e53aa47fbb5357a0ed1adc

Merge pull request #198 from nithu0115/docs2 Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>

view details

Michael Hausenblas

commit sha 10d9d5ffb0d9e0359cbc38c19723b87c193fec6d

improves testing instructions for dev preview

view details

Michael Hausenblas

commit sha bda76aa2c2df13236b9423e134a7dbdf0caedb66

addresses @jaypipes review comments

view details

Jay Pipes

commit sha 42f75ca3c88ad0921fc030900c0445f5e09ca0e3

Merge pull request #200 from mhausenblas/mh9-docs improves testing instructions for dev preview

view details

malkie

commit sha 47bfc6f9e3578ba0dee7c8e44819b2f3d221ec97

Add initial go badges

view details

Michael Hausenblas

commit sha 2ca5483a48dacec650a4bb52689f2d49b60bd6dc

Fixes up testing for dev preview (#201) * moves Dockerfile up * cleans up testing targets

view details

Michael Hausenblas

commit sha c981c9b581902d6e7d0ea6ac8bb219d5c102e78e

synces up docs with #201

view details

Nate Taber

commit sha ee156c043f380ca9df37dfb361e09d5f820736db

Add new service

view details

Jay Pipes

commit sha 1309e2fb0313034234536590f9fd2cd9b37755de

Merge pull request #203 from mhausenblas/mh9-docs sync up docs with #201

view details

Nate Taber

commit sha 59dee4a575c86d891282a237957249b753359147

Update issue templates added dev preview checklist to new service controller template

view details

Nate Taber

commit sha 4d4bca441fb563a204906f94932c61a9fa3c0876

Update issue templates added default label

view details

Jay Pipes

commit sha 4a4aae282ba8ebecf25fc8214bd4d58e82de4907

ensure ECR DescribeRepositories properly generated (#214) There were two issues with the generated ECR service controller code. The first issue had to do with the generated code not properly understanding the NotFound exception code for repositories. The solution to this was adding something to the generatorConfig for ECR to instruct the generator which exception code to identity NotFound errors. The second issue had to do with another generatorConfig instruction: tell the code generator to output Go code to filter out Repository results in the `DescribeRepositoriesOutput.Repositories` struct field that did not have a match `RepositoryName` value as the CR's `Spec.RepositoryName` field. Adding the `services/ecr/generator.yaml` file and configuring it like so fixed the above two problems: ```yaml resources: Repository: exceptions: codes: 404: RepositoryNotFoundException list_operation: match_fields: - RepositoryName ``` Finally, I updated both the unit test for ECR repository code generation as well as modified the ECR smoke test to include creation of 3 separate repositories and then delete those 3 repositories. Doing this triggers the issue with DescribeRepositories returning multiple results and the generated Go code not properly filtering out results by matching RepositoryName.

view details

Jay Pipes

commit sha f894e7685cb5dd9f4b2dfaa88d7ccf61b78abf91

update templates to correct gofmt issues When generating the ECR service controller and getting ready to check it into source control, I noticed a couple changes when I ran gofmt against the generated code. Some of those changes were due to things like spaces instead of TAB characters in the templates. This fixes those up and runs `gofmt` against the generated code for a service controller when we build it. Issue #213

view details

Jay Pipes

commit sha 7bda429f4d9270ab97116819f185feae9c270ace

checking in ECR service controller Generated code for the ECR service controller. Issue #208

view details

Michael Hausenblas

commit sha 76bcc8789eded0c10bcd2781a5e96d163c194541

Merge pull request #217 from jaypipes/ecr Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>

view details

push time in 20 days

issue commentaws/amazon-vpc-cni-k8s

Metrics to cloudwatch without VPC endpoint

@SimplySeth, the easiest way that I can think of here would be to create a ConfigMap and patch the CNI metric helper deployment pod with that configMap. This way, all the traffic leaving the pod(CNI metric helper pod) would use these proxy variable to reach CloudWatch endpoints.

For similar setup, please refer to - https://aws.amazon.com/premiumsupport/knowledge-center/eks-http-proxy-configuration-automation/

SimplySeth

comment created time in 23 days

PullRequestReviewEvent

push eventaws/aws-controllers-k8s

Gábor Lipták

commit sha 077f576820008227b3177aa039345f13fc8db5c1

Correct typo

view details

push time in 24 days

PR merged aws/aws-controllers-k8s

Correct typo

Issue #, if available:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+1 -1

0 comment

1 changed file

gliptak

pr closed time in 24 days

PullRequestReviewEvent

issue commentaws/aws-controllers-k8s

S3 bucket names to generated unique or randomly to avoid causing failures

Thanks for your Interest ACK @phanimullapudi . I think this issue is solved in #236

phanimullapudi

comment created time in 25 days

push eventaws/aws-controllers-k8s

Robin Golden

commit sha 2b0356b21467f114dec0e91f4456052c30c0f277

Smoke test S3 bucket creation using per account bucket names Bucket names in S3 are globally unique. Currently, the smoke test for the s3 controller uses a fixed bucket name. This leads to failures if more than one user is running the smoke test at the same time. This change suffixes the smoke test bucket name with the running users AWS_ACCOUNT_ID, ensuring that the bucket name is unique per account. Using a relatively fixed (per user) value ensures that the test will still detect undeleted buckets/resources for that user, while preventing interference from others tests. Testing: ``` make kind-test SERVICE=s3 ... ... ... ====================================================================================================== To poke around your test manually: export KUBECONFIG=/workspace/aws-controllers-k8s/scripts/../build/tmp-test-7e1deba0/kubeconfig kubectl get pods -A ====================================================================================================== bucket.s3.services.k8s.aws/ack-test-smoke-s3-xxxxxxxxxxxx created { "Name": "ack-test-smoke-s3-xxxxxxxxxxxx", "CreationDate": "2020-08-24T21:47:19+00:00" } bucket.s3.services.k8s.aws "ack-test-smoke-s3-xxxxxxxxxxxx" deleted smoke took 40 second(s) ```

view details

push time in a month

PR merged aws/aws-controllers-k8s

Smoke test S3 bucket creation using per account bucket names

Bucket names in S3 are globally unique. Currently, the smoke test for the s3 controller uses a fixed bucket name. This leads to failures if more than one user is running the smoke test at the same time.

Issue #, if available:

Description of changes:

This change suffixes the smoke test bucket name with the running users AWS_ACCOUNT_ID, ensuring that the bucket name is unique per account.

Using a relatively fixed (per user) value ensures that the test will still detect undeleted buckets/resources for that user, while preventing interference from others tests.

Testing:

make kind-test SERVICE=s3
...
...
...
======================================================================================================
To poke around your test manually:
export KUBECONFIG=/workspace/aws-controllers-k8s/scripts/../build/tmp-test-7e1deba0/kubeconfig
kubectl get pods -A
======================================================================================================
bucket.s3.services.k8s.aws/ack-test-smoke-s3-xxxxxxxxxxxx created
{
  "Name": "ack-test-smoke-s3-xxxxxxxxxxxx",
  "CreationDate": "2020-08-24T21:47:19+00:00"
}
bucket.s3.services.k8s.aws "ack-test-smoke-s3-xxxxxxxxxxxx" deleted
smoke took 40 second(s)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+1 -1

0 comment

1 changed file

RobinGolden

pr closed time in a month

PullRequestReviewEvent

push eventaws/aws-controllers-k8s

Jay Pipes

commit sha 009cd74239e1c24ef03629cc4506789445204948

fix SNS service controller issues There were a couple issues that were manifesting as failures when running the SNS e2e test. The first issue was a cryptic message appearing in the SNS service controller's logs that looked like this: ``` A ${AWS_REGION} ARN must begin with arn:null, not arn:aws:sns:... ``` The root cause of this error was actually a problem in the deployment.yaml template: it was using the string `${AWS_REGION}` instead of `$(AWS_REGION)`. In other words, curly brackets do not trigger environment replacement in the Deployment YAML file. Only parentheses... The second issue was being encountered because the code that generates the Input shape for the SNS DeleteTopic (and similar) API calls was not properly generating a block of code that would read the CR's Status.ACKResourceMetadata.ARN field. With this patch, the SNS controller builds and passes the e2e test: ``` jaypipes@thelio:~/go/src/github.com/aws/aws-controllers-k8s$ make build-controller SERVICE=sns go build -tags codegen -o bin/ack-generate cmd/ack-generate/main.go ./scripts/build-controller.sh sns Building Kubernetes API objects for sns Generating deepcopy code for sns Generating custom resource definitions for sns Building service controller for sns Generating RBAC manifests for sns Running gofmt against generated code for sns jaypipes@thelio:~/go/src/github.com/aws/aws-controllers-k8s$ make kind-test SERVICE=sns AWS_ROLE_ARN=$ROLE_ARN /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/errors/ --dir=pkg/errors/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/model/ --dir=pkg/model/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/model/testdata/ --dir=pkg/model/testdata/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/names/ --dir=pkg/names/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/requeue/ --dir=pkg/requeue/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/runtime/ --dir=pkg/runtime/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/ --dir=pkg/template/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/apis/ --dir=pkg/template/apis/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/cmd/ --dir=pkg/template/cmd/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/config/ --dir=pkg/template/config/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/pkg/ --dir=pkg/template/pkg/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/testutil/ --dir=pkg/testutil/ --all /home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/types/ --dir=pkg/types/ --all Generating mock for: AWSResource in file: mocks/pkg/types/aws_resource.go Generating mock for: AWSResourceDescriptor in file: mocks/pkg/types/aws_resource_descriptor.go Generating mock for: AWSResourceIdentifiers in file: mocks/pkg/types/aws_resource_identifiers.go Generating mock for: AWSResourceManager in file: mocks/pkg/types/aws_resource_manager.go Generating mock for: AWSResourceManagerFactory in file: mocks/pkg/types/aws_resource_manager_factory.go Generating mock for: AWSResourceReconciler in file: mocks/pkg/types/aws_resource_reconciler.go Generating mock for: RuntimeMetaObject in file: mocks/pkg/types/runtime_meta_object.go go test -tags codegen ./... ? github.com/aws/aws-controllers-k8s/apis/core/v1alpha1 [no test files] ? github.com/aws/aws-controllers-k8s/cmd/ack-generate [no test files] ? github.com/aws/aws-controllers-k8s/cmd/ack-generate/command [no test files] ? github.com/aws/aws-controllers-k8s/mocks/pkg/types [no test files] ? github.com/aws/aws-controllers-k8s/pkg/errors [no test files] ok github.com/aws/aws-controllers-k8s/pkg/model 4.218s ok github.com/aws/aws-controllers-k8s/pkg/names (cached) ok github.com/aws/aws-controllers-k8s/pkg/requeue (cached) ok github.com/aws/aws-controllers-k8s/pkg/runtime (cached) ? github.com/aws/aws-controllers-k8s/pkg/template [no test files] ? github.com/aws/aws-controllers-k8s/pkg/template/apis [no test files] ? github.com/aws/aws-controllers-k8s/pkg/template/cmd [no test files] ? github.com/aws/aws-controllers-k8s/pkg/template/config/controller [no test files] ? github.com/aws/aws-controllers-k8s/pkg/template/config/default [no test files] ? github.com/aws/aws-controllers-k8s/pkg/template/config/rbac [no test files] ? github.com/aws/aws-controllers-k8s/pkg/template/pkg [no test files] ? github.com/aws/aws-controllers-k8s/pkg/testutil [no test files] ? github.com/aws/aws-controllers-k8s/pkg/types [no test files] ? github.com/aws/aws-controllers-k8s/services/bookstore/apis/v1alpha1 [no test files] ? github.com/aws/aws-controllers-k8s/services/bookstore/cmd/controller [no test files] ok github.com/aws/aws-controllers-k8s/services/bookstore/pkg/resource (cached) ok github.com/aws/aws-controllers-k8s/services/bookstore/pkg/resource/book (cached) ? github.com/aws/aws-controllers-k8s/services/bookstore/sdk/service/bookstore [no test files] ? github.com/aws/aws-controllers-k8s/services/bookstore/sdk/service/bookstore/bookstoreiface [no test files] ? github.com/aws/aws-controllers-k8s/services/ecr/apis/v1alpha1 [no test files] ? github.com/aws/aws-controllers-k8s/services/ecr/cmd/controller [no test files] ? github.com/aws/aws-controllers-k8s/services/ecr/pkg/resource [no test files] ? github.com/aws/aws-controllers-k8s/services/ecr/pkg/resource/repository [no test files] ? github.com/aws/aws-controllers-k8s/services/petstore/apis/v1alpha1 [no test files] ? github.com/aws/aws-controllers-k8s/services/petstore/cmd/controller [no test files] ok github.com/aws/aws-controllers-k8s/services/petstore/pkg/resource (cached) ok github.com/aws/aws-controllers-k8s/services/petstore/pkg/resource/pet (cached) ? github.com/aws/aws-controllers-k8s/services/petstore/sdk/service/petstore [no test files] ? github.com/aws/aws-controllers-k8s/services/petstore/sdk/service/petstore/petstoreiface [no test files] ? github.com/aws/aws-controllers-k8s/services/s3/apis/v1alpha1 [no test files] ? github.com/aws/aws-controllers-k8s/services/s3/cmd/controller [no test files] ? github.com/aws/aws-controllers-k8s/services/s3/pkg/resource [no test files] ? github.com/aws/aws-controllers-k8s/services/s3/pkg/resource/bucket [no test files] ? github.com/aws/aws-controllers-k8s/services/sns/apis/v1alpha1 [no test files] ? github.com/aws/aws-controllers-k8s/services/sns/cmd/controller [no test files] ? github.com/aws/aws-controllers-k8s/services/sns/pkg/resource [no test files] ? github.com/aws/aws-controllers-k8s/services/sns/pkg/resource/platform_application [no test files] ? github.com/aws/aws-controllers-k8s/services/sns/pkg/resource/platform_endpoint [no test files] ? github.com/aws/aws-controllers-k8s/services/sns/pkg/resource/topic [no test files] ./scripts/kind-build-test.sh -s sns -p -r arn:aws:iam::750630568209:role/elasticache.services.k8s.aws.full Using Kubernetes kindest/node:v1.16.9@sha256:7175872357bc85847ec4b1aba46ed1d12fa054c83ac7a8a11f5c268957fd5765 Creating k8s cluster using "kind" ... No kind clusters found. Created k8s cluster using "kind" Building sns docker image Building 'sns' controller docker image with tag: ack-sns-controller:026f005-dirty sha256:efdcc36674b047ae9fd8775255312107002f807d144ee49d54b688eb2d1ae898 Loading the images into the cluster Image: "ack-sns-controller:026f005-dirty" with ID "sha256:efdcc36674b047ae9fd8775255312107002f807d144ee49d54b688eb2d1ae898" not yet present on node "test-02d8d897-worker", loading... Image: "ack-sns-controller:026f005-dirty" with ID "sha256:efdcc36674b047ae9fd8775255312107002f807d144ee49d54b688eb2d1ae898" not yet present on node "test-02d8d897-control-plane", loading... Loading CRD manifests for sns into the cluster customresourcedefinition.apiextensions.k8s.io/platformapplications.sns.services.k8s.aws created customresourcedefinition.apiextensions.k8s.io/platformendpoints.sns.services.k8s.aws created customresourcedefinition.apiextensions.k8s.io/topics.sns.services.k8s.aws created Loading RBAC manifests for sns into the cluster clusterrole.rbac.authorization.k8s.io/ack-controller-role created clusterrolebinding.rbac.authorization.k8s.io/ack-controller-rolebinding created Loading service controller Deployment for sns into the cluster namespace/ack-system created deployment.apps/ack-sns-controller created Running aws sts assume-role --role-arn arn:aws:iam::750630568209:role/elasticache.services.k8s.aws.full, --role-session-name tmp-role-e3a1cf9d --duration-seconds 900, Temporary credentials generated deployment.apps/ack-sns-controller env updated Added AWS Credentials to env vars map ====================================================================================================== To poke around your test manually: export KUBECONFIG=/home/jaypipes/go/src/github.com/aws/aws-controllers-k8s/scripts/../build/tmp-test-02d8d897/kubeconfig kubectl get pods -A ====================================================================================================== topic.sns.services.k8s.aws/ack-test-smoke-sns created topic.sns.services.k8s.aws "ack-test-smoke-sns" deleted smoke took 23 second(s) To resume test with the same cluster use: "-c /home/jaypipes/go/src/github.com/aws/aws-controllers-k8s/scripts/../build/tmp-test-02d8d897" ``` Issue #202

view details

push time in a month

PR merged aws/aws-controllers-k8s

Reviewers
fix SNS service controller issues

There were a couple issues that were manifesting as failures when running the SNS e2e test. The first issue was a cryptic message appearing in the SNS service controller's logs that looked like this:

A ${AWS_REGION} ARN must begin with arn:null, not arn:aws:sns:...

The root cause of this error was actually a problem in the deployment.yaml template: it was using the string ${AWS_REGION} instead of $(AWS_REGION). In other words, curly brackets do not trigger environment replacement in the Deployment YAML file. Only parentheses...

The second issue was being encountered because the code that generates the Input shape for the SNS DeleteTopic (and similar) API calls was not properly generating a block of code that would read the CR's Status.ACKResourceMetadata.ARN field.

With this patch, the SNS controller builds and passes the e2e test:

jaypipes@thelio:~/go/src/github.com/aws/aws-controllers-k8s$ make build-controller SERVICE=sns
go build -tags codegen -o bin/ack-generate cmd/ack-generate/main.go
./scripts/build-controller.sh sns
Building Kubernetes API objects for sns
Generating deepcopy code for sns
Generating custom resource definitions for sns
Building service controller for sns
Generating RBAC manifests for sns
Running gofmt against generated code for sns
jaypipes@thelio:~/go/src/github.com/aws/aws-controllers-k8s$ make kind-test SERVICE=sns AWS_ROLE_ARN=$ROLE_ARN
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/errors/ --dir=pkg/errors/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/model/ --dir=pkg/model/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/model/testdata/ --dir=pkg/model/testdata/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/names/ --dir=pkg/names/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/requeue/ --dir=pkg/requeue/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/runtime/ --dir=pkg/runtime/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/ --dir=pkg/template/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/apis/ --dir=pkg/template/apis/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/cmd/ --dir=pkg/template/cmd/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/config/ --dir=pkg/template/config/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/template/pkg/ --dir=pkg/template/pkg/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/testutil/ --dir=pkg/testutil/ --all
/home/jaypipes/go/bin/mockery --tags=codegen --case=underscore --output=mocks/pkg/types/ --dir=pkg/types/ --all
Generating mock for: AWSResource in file: mocks/pkg/types/aws_resource.go
Generating mock for: AWSResourceDescriptor in file: mocks/pkg/types/aws_resource_descriptor.go
Generating mock for: AWSResourceIdentifiers in file: mocks/pkg/types/aws_resource_identifiers.go
Generating mock for: AWSResourceManager in file: mocks/pkg/types/aws_resource_manager.go
Generating mock for: AWSResourceManagerFactory in file: mocks/pkg/types/aws_resource_manager_factory.go
Generating mock for: AWSResourceReconciler in file: mocks/pkg/types/aws_resource_reconciler.go
Generating mock for: RuntimeMetaObject in file: mocks/pkg/types/runtime_meta_object.go
go test -tags codegen ./...
?       github.com/aws/aws-controllers-k8s/apis/core/v1alpha1   [no test files]
?       github.com/aws/aws-controllers-k8s/cmd/ack-generate [no test files]
?       github.com/aws/aws-controllers-k8s/cmd/ack-generate/command [no test files]
?       github.com/aws/aws-controllers-k8s/mocks/pkg/types  [no test files]
?       github.com/aws/aws-controllers-k8s/pkg/errors   [no test files]
ok      github.com/aws/aws-controllers-k8s/pkg/model    4.218s
ok      github.com/aws/aws-controllers-k8s/pkg/names    (cached)
ok      github.com/aws/aws-controllers-k8s/pkg/requeue  (cached)
ok      github.com/aws/aws-controllers-k8s/pkg/runtime  (cached)
?       github.com/aws/aws-controllers-k8s/pkg/template [no test files]
?       github.com/aws/aws-controllers-k8s/pkg/template/apis    [no test files]
?       github.com/aws/aws-controllers-k8s/pkg/template/cmd [no test files]
?       github.com/aws/aws-controllers-k8s/pkg/template/config/controller   [no test files]
?       github.com/aws/aws-controllers-k8s/pkg/template/config/default  [no test files]
?       github.com/aws/aws-controllers-k8s/pkg/template/config/rbac [no test files]
?       github.com/aws/aws-controllers-k8s/pkg/template/pkg [no test files]
?       github.com/aws/aws-controllers-k8s/pkg/testutil [no test files]
?       github.com/aws/aws-controllers-k8s/pkg/types    [no test files]
?       github.com/aws/aws-controllers-k8s/services/bookstore/apis/v1alpha1 [no test files]
?       github.com/aws/aws-controllers-k8s/services/bookstore/cmd/controller    [no test files]
ok      github.com/aws/aws-controllers-k8s/services/bookstore/pkg/resource  (cached)
ok      github.com/aws/aws-controllers-k8s/services/bookstore/pkg/resource/book (cached)
?       github.com/aws/aws-controllers-k8s/services/bookstore/sdk/service/bookstore [no test files]
?       github.com/aws/aws-controllers-k8s/services/bookstore/sdk/service/bookstore/bookstoreiface  [no test files]
?       github.com/aws/aws-controllers-k8s/services/ecr/apis/v1alpha1   [no test files]
?       github.com/aws/aws-controllers-k8s/services/ecr/cmd/controller  [no test files]
?       github.com/aws/aws-controllers-k8s/services/ecr/pkg/resource    [no test files]
?       github.com/aws/aws-controllers-k8s/services/ecr/pkg/resource/repository [no test files]
?       github.com/aws/aws-controllers-k8s/services/petstore/apis/v1alpha1  [no test files]
?       github.com/aws/aws-controllers-k8s/services/petstore/cmd/controller [no test files]
ok      github.com/aws/aws-controllers-k8s/services/petstore/pkg/resource   (cached)
ok      github.com/aws/aws-controllers-k8s/services/petstore/pkg/resource/pet   (cached)
?       github.com/aws/aws-controllers-k8s/services/petstore/sdk/service/petstore   [no test files]
?       github.com/aws/aws-controllers-k8s/services/petstore/sdk/service/petstore/petstoreiface [no test files]
?       github.com/aws/aws-controllers-k8s/services/s3/apis/v1alpha1    [no test files]
?       github.com/aws/aws-controllers-k8s/services/s3/cmd/controller   [no test files]
?       github.com/aws/aws-controllers-k8s/services/s3/pkg/resource [no test files]
?       github.com/aws/aws-controllers-k8s/services/s3/pkg/resource/bucket  [no test files]
?       github.com/aws/aws-controllers-k8s/services/sns/apis/v1alpha1   [no test files]
?       github.com/aws/aws-controllers-k8s/services/sns/cmd/controller  [no test files]
?       github.com/aws/aws-controllers-k8s/services/sns/pkg/resource    [no test files]
?       github.com/aws/aws-controllers-k8s/services/sns/pkg/resource/platform_application   [no test files]
?       github.com/aws/aws-controllers-k8s/services/sns/pkg/resource/platform_endpoint  [no test files]
?       github.com/aws/aws-controllers-k8s/services/sns/pkg/resource/topic  [no test files]
./scripts/kind-build-test.sh -s sns -p -r arn:aws:iam::750630568209:role/elasticache.services.k8s.aws.full
Using Kubernetes kindest/node:v1.16.9@sha256:7175872357bc85847ec4b1aba46ed1d12fa054c83ac7a8a11f5c268957fd5765
Creating k8s cluster using "kind" ...
No kind clusters found.
Created k8s cluster using "kind"
Building sns docker image
Building 'sns' controller docker image with tag: ack-sns-controller:026f005-dirty
sha256:efdcc36674b047ae9fd8775255312107002f807d144ee49d54b688eb2d1ae898
Loading the images into the cluster
Image: "ack-sns-controller:026f005-dirty" with ID "sha256:efdcc36674b047ae9fd8775255312107002f807d144ee49d54b688eb2d1ae898" not yet present on node "test-02d8d897-worker", loading...
Image: "ack-sns-controller:026f005-dirty" with ID "sha256:efdcc36674b047ae9fd8775255312107002f807d144ee49d54b688eb2d1ae898" not yet present on node "test-02d8d897-control-plane", loading...
Loading CRD manifests for sns into the cluster
customresourcedefinition.apiextensions.k8s.io/platformapplications.sns.services.k8s.aws created
customresourcedefinition.apiextensions.k8s.io/platformendpoints.sns.services.k8s.aws created
customresourcedefinition.apiextensions.k8s.io/topics.sns.services.k8s.aws created
Loading RBAC manifests for sns into the cluster
clusterrole.rbac.authorization.k8s.io/ack-controller-role created
clusterrolebinding.rbac.authorization.k8s.io/ack-controller-rolebinding created
Loading service controller Deployment for sns into the cluster
namespace/ack-system created
deployment.apps/ack-sns-controller created
Running aws sts assume-role --role-arn arn:aws:iam::750630568209:role/elasticache.services.k8s.aws.full, --role-session-name tmp-role-e3a1cf9d  --duration-seconds 900,
Temporary credentials generated
deployment.apps/ack-sns-controller env updated
Added AWS Credentials to env vars map
======================================================================================================
To poke around your test manually:
export KUBECONFIG=/home/jaypipes/go/src/github.com/aws/aws-controllers-k8s/scripts/../build/tmp-test-02d8d897/kubeconfig
kubectl get pods -A
======================================================================================================
topic.sns.services.k8s.aws/ack-test-smoke-sns created
topic.sns.services.k8s.aws "ack-test-smoke-sns" deleted
smoke took 23 second(s)
To resume test with the same cluster use: "-c /home/jaypipes/go/src/github.com/aws/aws-controllers-k8s/scripts/../build/tmp-test-02d8d897"

Issue #202

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+38 -6

1 comment

5 changed files

jaypipes

pr closed time in a month

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentaws/aws-controllers-k8s

fix SNS service controller issues

 func (cfg *Config) Validate() error { 	if cfg.AccountID == "" { 		return errors.New("unable to start service controller as account ID is nil. Please pass --aws-account-id flag") 	}+	if cfg.Region == "" {+		return errors.New("unable to start service controller as AWS region is nil. Please pass --aws-region flag")+	}

Initially, I added this for future work to support cross region and had to abandon it in lieu of CARM. That said, adding region argument does not change the current before. The SDK will still fetch region details from the environment variable.

jaypipes

comment created time in a month

PullRequestReviewEvent

PR opened aws/amazon-vpc-cni-k8s

return only on error for tryAssignIPs method

Issue #, if available: N/A

Description of changes: When testing #903, for an edge case scenario where the EC2 instance cannot assign IP addresse when we call tryAssignIPs during node init, which increasedPool == false and error == nil. Even though there was no error, we prematurely think this is returning error which was blocking spawning of go-routine which never updated ip rule table.

With this change, we are explicitly checking if the error is not nil and then return error.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+2 -2

0 comment

2 changed files

pr created time in a month

push eventnithu0115/amazon-vpc-cni-k8s

Murcherla

commit sha add36b1584cfcb5d9376a1597b849adef1c6222e

return only on error for tryAssignIPs method

view details

push time in a month

create barnchnithu0115/amazon-vpc-cni-k8s

branch : uptodate

created branch time in a month

Pull request review commentaws/aws-controllers-k8s

Updated testing docs

 If you already set this environment variable above during build stage, ignore th SERVICE=ecr ``` -To generate temporary credentials for functional testing, pass in a role ARN. This will create a resource in your account in us-west-2 region-for the respective AWS Service:+To generate temporary credentials for functional testing, pass in a role ARN.   ```-AWS_ROLE_ARN=arn:aws:iam::12345678980:role/Admin-k8+AWS_ROLE_ARN=arn:aws:iam::<account-id>:role/<role-name> ``` +!!! warning+    The role ARN passed should exist in your AWS account, and has necessary permissions to create/describe/delete the resource. 

Good point. Role must exist and have necessary permissions. I will go ahead and add some examples roles. We cannot have a read only role unfortunately as we are create a resource and describe it to make sure it is successfully created as part of E2E tests.

nithu0115

comment created time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 8080000b5cb17d9c7a07e7e51054996ccd8ef326

Updated testing docs

view details

push time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 798b5d8511c9e9075d9c56aaa487f1f5c02a2d85

Updated testing docs

view details

push time in a month

PR opened aws/aws-controllers-k8s

Updated testing docs

Issue #, if available: N/A

Description of changes: Updated testing docs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+11 -8

0 comment

1 changed file

pr created time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 426fb410dfa576be81b28370f4a2bb0a88395178

Updated testing docs

view details

push time in a month

PR opened aws/aws-controllers-k8s

update testing docs

Issue #, if available: N/A

Description of changes: testing documentation updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+18 -5

0 comment

1 changed file

pr created time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha adaf468beb232ae449e5dd5ec59f46d07da80cea

update testing docs

view details

push time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha a5e246f491dc7cd04a495b69187d6519f4fedb15

update testing docs

view details

push time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 1e66622b956abebd4190e80da851dcb6a67a8ad9

update testing docs

view details

push time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 895cd952f7143f631af14e88c3383a7d6b6bbb94

update testing docs

view details

push time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 3d77f8d8e38f9d32e4730baf3696fa269e5bd554

update testing docs

view details

push time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha ea9d1e5b6be0a567f72e013a85d1e3b953677a0b

update testing docs

view details

push time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 6f5e7d5a6d6ef5a5475f0d66fa7a6db3a97a3c45

update testing docs

view details

push time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha f028e64a5027c23fd2ed96398768960a23119fed

update testing docs

view details

push time in a month

create barnchnithu0115/aws-controllers-k8s

branch : docs2

created branch time in a month

pull request commentaws/aws-controllers-k8s

fixing kind-build-test script when no ROLE_ARN is passed

@nithu0115 I had already placed a guard in the kind-build-test script to prevent running without ROLE_ARN.

ah ok. I will go ahead and update the docs to run using make kind-cluster-functional SERVICE=s3 ROLE_ARN=arn:aws:iam::123112545544544:role/Admin-k8s or leave it as is

nithu0115

comment created time in a month

PR opened aws/aws-controllers-k8s

fixing kind-build-test script when no ROLE_ARN is passed

Issue #, if available: N/A

Description of changes: Fixing kind build script if no ROLE_ARN is passed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+14 -17

0 comment

1 changed file

pr created time in a month

push eventnithu0115/aws-controllers-k8s

Michael Hausenblas

commit sha a40e28589b72919aea10e169eaee0877109d5e3e

Merge pull request #192 from nithu0115/docs1 Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>

view details

Murcherla

commit sha d5caf9f2d6b4ade34a1d1568427a172e5967d6d4

fixing kind-build-test script when no ROLE_ARN is passed

view details

push time in a month

PR opened aws/aws-controllers-k8s

minor update testing docs

Issue #, if available: N/A

Description of changes: updated testing docs

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+1 -1

0 comment

1 changed file

pr created time in a month

create barnchnithu0115/aws-controllers-k8s

branch : docs1

created branch time in a month

push eventaws/aws-controllers-k8s

Tori

commit sha 60e43a9769ec939657a5687678b8152015809c5c

Add note about mockery as a dependency

view details

push time in a month

PR merged aws/aws-controllers-k8s

Add note about mockery as a dependency

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+3 -0

0 comment

1 changed file

toricls

pr closed time in a month

push eventaws/aws-controllers-k8s

Jay Pipes

commit sha 6f9e81612e747f482f6c2ef31ba252b62825c478

check for NotFound using 255 or 254 for ECR The `aws` CLI tool apparently changed from using return code 255 to using return code 254 between v1 and v2 of the CLI tool. So, this modifies the ECR smoke test to simply check for either of those return codes when determining if a repository already exists.

view details

push time in a month

PR merged aws/aws-controllers-k8s

check for NotFound using 255 or 254 for ECR

The aws CLI tool apparently changed from using return code 255 to using return code 254 between v1 and v2 of the CLI tool. So, this modifies the ECR smoke test to simply check for either of those return codes when determining if a repository already exists.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

+6 -6

0 comment

2 changed files

jaypipes

pr closed time in a month

issue closedaws/aws-controllers-k8s

ECR controller is not creating ECR repository. Readone method bug

Describe the bug A concise description of what the bug is.

Bug 1

While testing ACK-ECR-controller, I am using the below sample manifest file to create my ECR repository. However, the reconciler sync method never makes a create repository API call. Here are log traces from my test run:

2020-08-11T15:51:43.503-0500    INFO    controller-runtime.controller   Starting workers        {"controller": "repository", "worker count": 1}
desired state is &{TypeMeta:{Kind:Repository APIVersion:ecr.services.k8s.aws/v1alpha1} ObjectMeta:{Name:testg GenerateName: Namespace:default SelfLink:/apis/ecr.services.k8s.aws/v1alpha1/namespaces/default/repositories/testg UID:891de6f5-7281-4edd-9367-e152f7061869 ResourceVersion:24428545 Generation:1 CreationTimestamp:2020-08-11 15:07:55 -0500 CDT DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[kubectl.kubernetes.io/last-applied-configuration:{"apiVersion":"ecr.services.k8s.aws/v1alpha1","kind":"Repository","metadata":{"annotations":{},"name":"testg","namespace":"default"},"spec":{"repositoryName":"nithish"}}
] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[]} Spec:{EncryptionConfiguration:<nil> ImageScanningConfiguration:<nil> ImageTagMutability:<nil> RepositoryName:0xc000300680 Tags:[]} Status:{ACKResourceMetadata:<nil> Conditions:[] CreatedAt:<nil> RegistryID:<nil> RepositoryURI:<nil>}} 
is adopted false 
Repository name passed in the spec is: nithish 
input describe repositories {

} 
{
  Repositories: [{
      CreatedAt: 2017-06-01 18:45:54 +0000 UTC,
      EncryptionConfiguration: {
        EncryptionType: "AES256"
      },
      ImageScanningConfiguration: {
        ScanOnPush: false
      },
      ImageTagMutability: "MUTABLE",
      RegistryId: "<Account ID>",
      RepositoryArn: "arn:aws:ecr:us-west-2:<Account ID>:repository/testing",
      RepositoryName: "testing",
      RepositoryUri: "<acount ID>.dkr.ecr.us-west-2.amazonaws.com/testing"
    }]
}Observed event is arn:aws:ecr:us-west-2:<account ID>:repository/testing 

Adding more print statements, in reconciler sync method under runtime,

 latest, err := rm.ReadOne(ctx, desired)
	fmt.Printf("printing latest %+v \n", *latest.Identifiers().ARN())
	//r.log.Error(err, "printing error if there is one")
	if err != nil {
		if err != ackerr.NotFound {
			return err
		}

ReadOne method is always returning a resource(in my case, it did a describe repositories and found testing repo) and returned that to above latest variable which skips creation of resource

sample manifest file:

apiVersion: "ecr.services.k8s.aws/v1alpha1"
kind: Repository
metadata:
  name: "testg"
spec:
  repositoryName: nithish

Steps to reproduce -> build ecr controller -> deploy ECR controller on to a k8s cluster -> Enable debug logging and for testing I added additional logging using fmt.Printf("%+v") statements for Readone method under manager.go, and skdFind method under sdk.go

Expected outcome Controller should create ECR repository with repository name "nithish" in my account in us-west-2 region

Environment

  • Kubernetes version 1.14
  • Using EKS (yes/no), if so version? Yes
  • AWS service targeted (S3, RDS, etc.) ECR

closed time in a month

nithu0115

Pull request review commentaws/aws-controllers-k8s

S3 service controller enhancements and fixes

 func (h *Helper) GetCRDs() ([]*CRD, error) { 			if h.IsIgnoredShape(memberShapeRef.Shape.ShapeName) { 				continue 			}-			memberNames := names.New(memberName)+			renamedName, _ := crd.InputFieldRename(

Question: under what conditions does InputFieldRename return false ?

jaypipes

comment created time in a month

pull request commentaws/aws-controllers-k8s

update dev docs to include ROLE ARN setup

Thanks a lot @nithu0115 and that looks very good, content-wise. One last thing before we merge: can you share what mkdocs version you tested with, since we upgraded to 5.x and I'm seeing some issue. For example, I have:

$ mkdocs  --version
mkdocs, version 1.1.2 from /usr/local/lib/python3.8/site-packages/mkdocs (Python 3.8)
a483e7384446:aws-controllers-k8s nithmu$ sudo mkdocs --version
mkdocs, version 1.1.2 from /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages/mkdocs (Python 3.8)
nithu0115

comment created time in a month

push eventnithu0115/aws-controllers-k8s

Jay Pipes

commit sha 54259e258881aad24ff1cfa21b454dbbeab7911b

Remove CircleCI configuration

view details

Jay Pipes

commit sha c44d984f2f59fb0757fb3fd06f4ea3aa172116db

include go.mod and go.sum in files triggering test

view details

Michael Hausenblas

commit sha 601a57228485458e970589b6ffeafcafcfc368d7

Merge pull request #179 from jaypipes/ci-fixes minor CI cleanups

view details

Jay Pipes

commit sha a932a8a892cd429e49965e8561455d6c1bd97060

Add S3 models to test data

view details

Jay Pipes

commit sha a200f5df19f7355108a9c7e807bea31e2a8378ef

only consider types for shapes in CRDs Changes the way we process TypeDef objects in the code generator so that we are only considering Shapes that appear in a payload (or the payload's composite member shapes) for any operation for any CRD. This means that if a resource is marked in the generator config as being ignored, then all Shapes that are *only* found as members of payload Shapes for those ignored resources are also ignored. This fixes the code generation problems with the S3 service controller, which has some problematic Shape definitions, but those definitions are only in the S3 Object's payloads, which is a data-plane API and not something we care about in ACK-land. Also fixed was a naming standardization problem I found with the MultipartUpload shape, which `pkg/names` package was helpfully transforming to `MultIPartUpload` because of the non-regex simple replacement rule for the "Ip" initialism. Issue #180

view details

Justin Garrison

commit sha 8004400c023e386f79600f211a1331c3a9928834

Add make help and build-controller-image targets (#173) Add make help and build-controller-image targets

view details

Michael Hausenblas

commit sha f1201687edd3a3e7c32c8f092cd0731f04b21525

Merge pull request #182 from jaypipes/s3 Signed-off-by: Michael Hausenblas <hausenbl@amazon.com>

view details

Murcherla

commit sha 95a5d4181d55b572c8d73bfeb06f5229a58f4901

update dev docs to include ROLE ARN setup

view details

push time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha 8e690761ec242e7a31d47eea2b560a714e925541

update dev docs to include ROLE ARN setup

view details

push time in a month

pull request commentaws/aws-controllers-k8s

update dev docs to include ROLE ARN setup

Thanks @mhausenblas for the review and pointers :) I forgot about mkdocs and was under the impression of markdown docs. I updated the PR and ran them locally.

nithu0115

comment created time in a month

push eventnithu0115/aws-controllers-k8s

Murcherla

commit sha fc99cf85449cda6a244f14c2af6ee843b130f64c

update dev docs to include ROLE ARN setup

view details

push time in a month

more