profile
viewpoint
Nathan Alderson nathanalderson @ADTRAN Huntsville, AL, USA https://nathanalderson.com Software Design Engineer; Computer Hobbyist; Person

nathanalderson/yang.vim 15

YANG syntax highlighting for VIM

nathanalderson/enneagram-for-engineers 4

My "Enneagram for Engineers" conference talk

ADTRAN/gradle-betablocker-plugin 3

Gradle plugin to prevent non-stable versions of dependencies from being inadvertently consumed by a project

ADTRAN/netconf_client 2

A NETCONF client for Python 2.7 and 3+

nathanalderson/advent-of-code-2018 2

https://adventofcode.com/2018

nathanalderson/advent-of-code-2017 0

http://adventofcode.com/2017

nathanalderson/base16-shell 0

Base16 for Shells

nathanalderson/cinnamon-spices-applets 0

Applets for the Cinnamon desktop

nathanalderson/dotfiles 0

My dotfiles

push eventwhitesburg-pool/whitesburg-pool.github.io

Nathan Alderson

commit sha 91453ec62f69b3bd72637394575f5c94bbb6eccd

Closed for winter 2020

view details

push time in 12 days

push eventnathanalderson/yang.vim

Leonard Crestez

commit sha 5ef14c8407a70dc524c801adf80bff1ff609e9fe

ftplugin/yang.vim: Always add `-` to iskeyword This makes it easy to navigate yang files using # and * Signed-off-by: Leonard Crestez <cdleonard@gmail.com>

view details

Nathan Alderson

commit sha 0edaeb616be8f66caed2c888095446006fd4a6fa

Merge pull request #12 from cdleonard/master ftplugin/yang.vim: Always add `-` to iskeyword

view details

push time in a month

PR merged nathanalderson/yang.vim

ftplugin/yang.vim: Always add `-` to iskeyword

This makes it easy to navigate yang files using # and *

Signed-off-by: Leonard Crestez cdleonard@gmail.com

+2 -4

2 comments

1 changed file

cdleonard

pr closed time in a month

PullRequestReviewEvent

pull request commentnathanalderson/yang.vim

ftplugin/yang.vim: Always add `-` to iskeyword

Seems reasonable to me. @dimbleby put this code in, though. Maybe he can offer a review/explanation?

cdleonard

comment created time in a month

pull request commentADTRAN/gradle-scala-multiversion-plugin

set buildName on dynamic GradleBuild when using gradle 6.x or higher

Despite the fact that the last two builds failed, it seems like it actually did publish. Not sure what's going on there. Let me know if you're not able to pull the updated version.

tomnis

comment created time in 2 months

delete branch ADTRAN/gradle-scala-multiversion-plugin

delete branch : update-publishing

delete time in 2 months

push eventADTRAN/gradle-scala-multiversion-plugin

Nathan Alderson

commit sha 150bb09a96cace9671c88061ba2e68949926bab5

fix: Apply required update to publishing plugin (#29)

view details

push time in 2 months

create barnchADTRAN/gradle-scala-multiversion-plugin

branch : update-publishing

created branch time in 2 months

push eventADTRAN/gradle-scala-multiversion-plugin

tomas

commit sha d0cbf453d81b974936578724785d91a8ecb0fe63

fix: set buildName on dynamic GradleBuild when using gradle 6.x or higher (#28) fixes #27 Co-authored-by: Nathan Alderson <nathan@nathanalderson.com> Co-authored-by: tomas.mccandless <tomas.mccandless@workday.com>

view details

push time in 2 months

issue closedADTRAN/gradle-scala-multiversion-plugin

[Edge case] Included build has same name as a project of the main build

Hi folks,

Thanks for this plugin, we have found it really useful.

Recently we refactored one of our gradle projects to split into 2 subprojects. When we run tasks with -PallScalaVersions, we get an error like:

$ gw clean compileScala -PallScalaVersions
...
Execution failed for task ':recurseWithScalaVersion_2.12.10'.
> Included build in /Users/tomnis/foo has name 'foo' which is the same as a project of the main build.

We are not using composite builds, and my understanding is this plugin does not use composite builds either, but GradleBuild uses a similar mechanism.

One of our subprojects has the same name as our repository, but we override rootProject.name in settings.gradle. We are using gradle 6.5.1 and multiversion 1.0.35.

Based on some further reading I believe the root cause is a regression in gradle 6.x. I think we are running into a combination of these 2 issues:

https://github.com/gradle/gradle/issues/12872 https://github.com/gradle/gradle/issues/3828 (we set rootProject.name in our settings.gradle, but that appears to not take effect for dynamic recursion tasks)

In issue 12872, @/ark100 suggested a workaround of setting buildName on dynamic GradleBuild tasks:

task task1(type: GradleBuild) {
    buildFile = file('gen/build.gradle')
    // ...
    if(6 <= gradle.gradleVersion.split(Pattern.quote('.'))[0].toInteger() ){
        buildName = "t1"
    }
}

I modified ScalaMultiVersionPlugin.groovy and published a local snapshot, this workaround seems to work for us. https://github.com/tomnis/gradle-scala-multiversion-plugin/commit/a21ba5ac0c8c350485561608927094ff967f9096

I am unclear whether this repo is still being maintained, but just wanted y'all to be aware of this edge case and put this out there for anyone else running into the same issue. Thanks again for this plugin, it has been really handy for us.

closed time in 2 months

tomnis
PullRequestReviewEvent

Pull request review commentADTRAN/gradle-scala-multiversion-plugin

set buildName on dynamic GradleBuild when using gradle 6.x or higher

 class ScalaMultiVersionPlugin implements Plugin<Project> {                         startParameter.projectProperties["recursed"] = true                         startParameter.excludedTaskNames += getRunOnceTasks()                         tasks = project.gradle.startParameter.taskNames+                        if (6 <= project.gradle.gradleVersion.split(Pattern.quote('.'))[0].toInteger() ){
                        // workaround name clash issue in Gradle 6+. See #27.
                        if (6 <= project.gradle.gradleVersion.split(Pattern.quote('.'))[0].toInteger() ){
tomnis

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentADTRAN/gradle-scala-multiversion-plugin

set buildName on dynamic GradleBuild when using gradle 6.x or higher

 class ScalaMultiVersionPlugin implements Plugin<Project> {                         startParameter.projectProperties["recursed"] = true                         startParameter.excludedTaskNames += getRunOnceTasks()                         tasks = project.gradle.startParameter.taskNames+                        if (6 <= project.gradle.gradleVersion.split(Pattern.quote('.'))[0].toInteger() ){

I think this deserves a comment, please. At least a reference to the issue number.

tomnis

comment created time in 2 months

PullRequestReviewEvent
PullRequestReviewEvent

issue commentADTRAN/gradle-scala-multiversion-plugin

[Edge case] Included build has same name as a project of the main build

I don't have much time for development, but I'm happy to accept a pull request. What you describe seems reasonable.

tomnis

comment created time in 2 months

push eventwhitesburg-pool/whitesburg-pool.github.io

Nathan Alderson

commit sha 0eed9eeb2aaa224b27a172866d8d23479e769245

Minor style/grammar/spelling corrections

view details

push time in 3 months

push eventwhitesburg-pool/whitesburg-pool.github.io

Nathan Alderson

commit sha c20fe85c6243da244f6e22c530263523ad7e8882

Correct thunder/lighting response

view details

push time in 3 months

more