profile
viewpoint
Myles Scolnick mscolnick Palantir Technologies New York, NY http://mscolnick.github.io/

mscolnick/export-typescript 4

VSCode extension to export typescript in index.ts files

gseyffert/Ball-Tracking 3

Group project for CS194 Engineering Parallel Software, Fall 2014

mscolnick/react-window-portal 1

React portal to a window

sbarratt/radius-collider 1

Radius Collider Project - http://cet.berkeley.edu/radius-fall-2015/

mscolnick/awesome-nyc 0

A collection of awesome things to do in New York City

mscolnick/blueprint 0

A React-based UI toolkit for the web

startedReactiveX/rxjs

started time in 6 days

startedcloverhearts/observeable-object-js

started time in 6 days

startedBeTomorrow/micro-observables

started time in 6 days

issue openedantfu/i18n-ally

Custom rewriteKeys when adding adding new keys to json file

Is your feature related to a specific framework or general for this extension Custom framework

Describe the solution you'd like It would be great to have custom rewriteKeys. Currently when adding a new key foo.bar, it'll add it like so:

{
 ...
 "foo.bar": "{count} car"
}

It would be nice to have the option to write this to:

{
 ...
 "foo.bar": {
     "singular": "{count} car",
     "plural": "",
     "description": "",
  }
}

created time in 9 days

startedthesayyn/protoc-gen-ts

started time in 11 days

issue commentstephenh/ts-proto

google.type.Date generates an output that conflicts with builtin Date

I would be fine to do the alias import, but the errors are in the generated code. It happens when google.type.Date and a Timestamp is in a protobuf file. The generate code wants to depend on both Date from google.type.Date (i.e. ./date.ts) and from built-in Date that comes from the timestamp.

mscolnick

comment created time in 24 days

issue openedstephenh/ts-proto

google.type.Date generates an output that conflicts with builtin Date

Not sure what an appropriate solution is but importing google.type.Date will conflict with the built-in global.Date.

Possible solution could be to special-case the naming of google.type.Date to GoogleTypeDate.

The generated code looks something like:

export interface Date {
  /**
   *  Year of date. Must be from 1 to 9999, or 0 if specifying a date without
   *  a year.
   */
  year: number;
  /**
   *  Month of year. Must be from 1 to 12, or 0 if specifying a year without a
   *  month and day.
   */
  month: number;
  /**
   *  Day of month. Must be from 1 to 31 and valid for the year and month, or 0
   *  if specifying a year by itself or a year and month where the day is not
   *  significant.
   */
  day: number;
}

created time in a month

issue openedstephenh/ts-proto

map<string, google.protobuf.Timestamp> produces invalid fromJson and fromPartial code

If this was added to SimpleWithMap

message SimpleWithMap {
  map<int32, Entity> entitiesById = 1;
  map<string, string> nameLookup = 2;
  map<int32, int32> intLookup = 3;
+ map<string, google.protobuf.Timestamp> mapOfTimestamps = 4;
}

The output will generate the map entry to be Date.fromJSON and Date.fromPartial:

export const SimpleWithMap = {
fromJSON(object: any): SimpleWithMap {
  ...
  if (object.mapOfTimestamps !== undefined && object.mapOfTimestamps !== null) {
    Object.entries(object.mapOfTimestamps).forEach(([key, value]) => {
      message.mapOfTimestamps[key] = Date.fromJSON(value); // Property 'fromJSON' does not exist on type 'DateConstructor'
    })
  }
  return message;
},

fromPartial(object: DeepPartial<SimpleWithMap>): SimpleWithMap {
  ...
  if (object.mapOfTimestamps !== undefined && object.mapOfTimestamps !== null) {
    Object.entries(object.mapOfTimestamps).forEach(([key, value]) => {
      if (value !== undefined) {
        message.mapOfTimestamps[key] = Date.fromPartial(value); // Property 'fromPartial' does not exist on type 'DateConstructor'
      }
    })
  }
  return message;
},
}

created time in a month

startedthemadcreator/circle-github-bot

started time in a month

startedstorybookjs/addon-smart-knobs

started time in a month

startedpocka/storybook-addon-designs

started time in a month

startedMichalLytek/type-graphql

started time in 2 months

starteddotansimha/graphql-code-generator

started time in 2 months

issue commentenvoyproxy/ratelimit

New tagged release

+1 please

ADanilychevJr

comment created time in 2 months

startedreact-ga/react-ga

started time in 2 months

startedksindi/managers-playbook

started time in 2 months

more