profile
viewpoint
Miguel migue1s Dominican Republic

migue1s/SafeArrays 1

Swift arrays with bounds checking

migue1s/SpaceCompanyNative 1

SpaceCompany is now on on mobile!

migue1s/SpaceCompanyNativeOld 1

An incremental game about Space Mining

migue1s/CRToast 0

A modern iOS toast view that can fit your notification needs

migue1s/QBImagePicker 0

A clone of UIImagePickerController with multiple selection support.

migue1s/react-native-image-crop-picker 0

iOS/Android image picker with support for camera, video, configurable compression, multiple images and cropping

migue1s/sentry-docs 0

The new place for the sentry documentation (and tools to build it)

migue1s/XLPagerTabStrip 0

Android PagerTabStrip for iOS.

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha f8b51725d16a5277796934c1eac4c4cc6b3e63a4

Update README.md

view details

push time in 4 hours

delete branch migue1s/SpaceCompanyNative

delete branch : task/theme

delete time in 4 hours

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha e86365c7cb4e378543e6c989646eeece6c24cc05

Adds initial implementation of theme support

view details

Miguel Saiz

commit sha 262ae7af04bd193ae3aef240681d038d183a596d

Adds the toggle theme button to storybooks

view details

Miguel Saiz

commit sha 7c95470b327937f79c08e40a380a2b8b63d17813

Adds proof of concept theme support to resource row

view details

Miguel

commit sha fb6cf954b2253b214f92dcd7bd3606d16d490f06

Merge pull request #9 from migue1s/task/theme Task/theme

view details

push time in 4 hours

PR merged migue1s/SpaceCompanyNative

Task/theme

Adds basic theme switching

theme

Related to: #4

+163 -22

1 comment

9 changed files

migue1s

pr closed time in 4 hours

pull request commentmigue1s/SpaceCompanyNative

Task/theme

Thanks for the feedback! I'm currently trying out a flatter approach. O've noticed that trying to nest too early can impair component discoverability. It's also one of the recommendation from the docs (kinda):

If you feel completely stuck, start by keeping all files in a single folder. Eventually it will grow large enough that you will want to separate some files from the rest https://reactjs.org/docs/faq-structure.html#dont-overthink-it

migue1s

comment created time in 4 hours

PullRequestEvent

issue closedmigue1s/SpaceCompanyNative

Add themes

  • dark/light mode
  • automatic changes based on mobile settings

closed time in 4 hours

migue1s

issue closedmigue1s/SpaceCompanyNative

Add main "tab" navigation

Research + implement basic browsing through the different tabs.

Some options are either an accordion on the main screen or a standard tab bar in the bottom

closed time in 14 hours

migue1s

issue closedmigue1s/SpaceCompanyNative

Add stub research screen

Add a stub screen which will hold the research later on. Should use the navigation implemented in #6

closed time in 14 hours

migue1s

delete branch migue1s/SpaceCompanyNative

delete branch : task/main-navigation

delete time in 14 hours

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 430e3e3864ff4a2e42ee577f8a6b8439c3f37561

Adds the drawer dependency

view details

Miguel Saiz

commit sha beddc7143af2e3bd5aad33e964c65071dd597413

Adds drawer based navigation

view details

Miguel

commit sha e2a33097966b63dcfc460184fff4d888fc579b9d

Merge pull request #10 from migue1s/task/main-navigation Task/main navigation

view details

push time in 14 hours

PR merged migue1s/SpaceCompanyNative

Task/main navigation

Added the main navigation via a drawer. This is due to there being a maximum limit of around 5 tabs on iOS whereas the game has 7+

nav

Issues: #6 #7

+40 -23

0 comment

4 changed files

migue1s

pr closed time in 14 hours

PR opened migue1s/SpaceCompanyNative

Task/main navigation

Added the main navigation via a drawer. This is due to there being a maximum limit of around 5 tabs on iOS whereas the game has 7+

nav

Issues: #6 #7

+40 -23

0 comment

4 changed files

pr created time in 14 hours

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha beddc7143af2e3bd5aad33e964c65071dd597413

Adds drawer based navigation

view details

push time in 14 hours

create barnchmigue1s/SpaceCompanyNative

branch : task/main-navigation

created branch time in 15 hours

PR opened migue1s/SpaceCompanyNative

Task/theme

Adds basic theme switching

theme

+163 -22

0 comment

9 changed files

pr created time in 15 hours

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 262ae7af04bd193ae3aef240681d038d183a596d

Adds the toggle theme button to storybooks

view details

Miguel Saiz

commit sha 7c95470b327937f79c08e40a380a2b8b63d17813

Adds proof of concept theme support to resource row

view details

push time in 15 hours

create barnchmigue1s/SpaceCompanyNative

branch : task/theme

created branch time in 16 hours

Pull request review commentmigue1s/SpaceCompanyNative

ResourceMachineCard

+import {StyleSheet} from 'react-native';++const GlobalStyles = StyleSheet.create({

Yes, what you're saying is definitely a thing. Part of my work will be adding a reusable View/Text which preconfigured options. That's the only way I've seen to manage things consistently in RN

LMandtler

comment created time in a day

Pull request review commentmigue1s/SpaceCompanyNative

ResourceMachineCard

+import {StyleSheet} from 'react-native';++const ResourceStyles = StyleSheet.create({

Same over here, for simple styles I generally tend to contain them in the file itself

LMandtler

comment created time in a day

Pull request review commentmigue1s/SpaceCompanyNative

ResourceMachineCard

+import {StyleSheet} from 'react-native';++const GlobalStyles = StyleSheet.create({+  container: {+    marginTop: 50,+  },+  header: {+    color: '#337AB7',

I generally prefer having a single file with all the color declarations as constants, that way it's easier to reuse in various places. I don't really mind this here though since I'm going to be working on theming later ;)

LMandtler

comment created time in a day

Pull request review commentmigue1s/SpaceCompanyNative

ResourceMachineCard

 import React from 'react'; import {Text, View, TouchableOpacity} from 'react-native';+import {Machine, ResourceType} from '../types';+import GlobalStyles from '../styles/GlobalStyles';+import ResourceStyles from '../styles/ResourceStyles'; -const ResourceMachine = () => {+const getCosts = (costs: {[x in ResourceType]?: number}) => {   return (-    <View>-      <Text>Miner: 2</Text>-      <Text>Build a pickaxe for your miner.</Text>-      <Text>Cost:</Text>-      <Text>Input:</Text>-      <Text>Output:</Text>-      <TouchableOpacity>-        <Text>Get 1</Text>-      </TouchableOpacity>+    <View style={ResourceStyles.machineBox}>+      <Text style={GlobalStyles.property}>Cost:</Text>+    </View>+  );+};++const ResourceMachine = ({machine}: {machine: Machine}) => {+  return (+    <View style={ResourceStyles.machineCard}>+      <View>+        <Text style={GlobalStyles.header}>{machine.name}</Text>+        <Text>{machine.desc}</Text>+      </View>+      <View style={ResourceStyles.machineContainer}>+        {getCosts(machine.cost)}

I haven't really thought about this yet but I was thinking of doing something like:

{
    Object.keys(machine.cost).map(resourceCost => <ResourceCost {SOME_PROPS}/>)
}

The main advantage being that there's some logic on how to actually display this which gets reused like this for anything with a cost :) I'm even wondering if it might be best to create a new ConnectedResourceCost component which takes a ResourceType (e.g. 'metal') and currentCost as a parameter and gets connected with redux if that makes sense. Sort of a HOC for this to simplify logic everywhere

LMandtler

comment created time in a day

Pull request review commentmigue1s/SpaceCompanyNative

ResourceMachineCard

+import {StyleSheet} from 'react-native';++const GlobalStyles = StyleSheet.create({

I'd actually prefer having the styles be inside the component. The reason being that it's easier to reason about styling when it's in close proximity.

Also, there's a small quirk in react-native where StyleSheet.create only accepts static values. The reason behind this is that the react-native bridge sense declared stylesheets over the bridge to avoid recomputing these styles at runtime, so it might be messier in the long run (or I haven't had a good experience yet at least 😅 )

LMandtler

comment created time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha d6f5fa84ae928e7b1843a0a462e3cf72474866bd

Fixes compilation issue

view details

Miguel Saiz

commit sha cee6b36a606dd5c974e6d22e4dab1fb59bf0b057

Enforce lf as line-ending via prettier

view details

Miguel Saiz

commit sha f0c5729f1a5906fcdd1ece3fde6ddcbf8858d583

Merge branch 'master' of github.com:migue1s/SpaceCompanyNative

view details

push time in a day

MemberEvent

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 2353710c11147408cf5e1a3e62ec30e7f31c9408

Update README.md

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 05a8c5505585294292c2d31efd279f02ba5f8e32

Update README.md

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 77fdbd5084a3430b06efbfccee4d4af95bc8c066

Update README.md

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 24152df0fd2376b7bc9008044392535d69f5e0b4

Update README.md

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 8f71f85a0ca77c5bbfb8897ba8f8fd171291471a

Update README.md

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 88daf753fe0d5303e7f9861da41459bce2b74c6b

Update README.md

view details

push time in a day

MemberEvent

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 3d4ad4458371226dcfe368281f2d0d746493c378

Update README.md

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 6868883eed1296e1ff072111c6b7242d79aad866

Removes inline style

view details

push time in a day

issue openedmigue1s/SpaceCompanyNative

Add stub research screen

Add a stub screen which will hold the research later on. Should use the navigation implemented in #6

created time in a day

issue openedmigue1s/SpaceCompanyNative

Add main "tab" navigation

Research + implement basic browsing through the different tabs.

Some options are either an accordion on the main screen or a standard tab bar in the bottom

created time in a day

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 537dd295bebda5b3d5430eac5538dbe3034645da

Update README.md

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 33d930e0a638799e7aff8759b411d925cf1dfaf2

Update README.md

view details

push time in a day

issue openedmigue1s/SpaceCompanyNative

Add styling to Resources

Should be largely equivalent the existing web version Screen Shot 2020-05-27 at 6 03 47 PM

Initial placeholder created at src/components/ResourceRow.tsx

Tasks:

Add to storybooks Add the UI Hook to redux

created time in a day

issue openedmigue1s/SpaceCompanyNative

Add themes

created time in a day

issue openedmigue1s/SpaceCompanyNative

Add Table Heading

created time in a day

issue openedmigue1s/SpaceCompanyNative

Create the Machine Card

created time in a day

push eventmigue1s/SpaceCompanyNativeOld

Miguel

commit sha da93ec98b70d1411716c5cbc1afff50a35cb8f68

Update README.md

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 12fd8a6d297f2b5e519d9f8cae3c6a289ba9c982

Removes codeclimate file in favor of web config

view details

Miguel Saiz

commit sha 8b2d2e3e44d9b4d1cfdb8e7860176936936193c9

Merge branch 'master' of github.com:migue1s/SpaceCompanyNative

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 4fecea5fd031ee5bcf71088bac229f505bfbbfa0

Update README.md

view details

push time in a day

delete branch migue1s/SpaceCompanyNative

delete branch : code-climate

delete time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha ea795ec09510250df614f9535f7a47c80ae48c92

Adds the code-climate config

view details

Miguel

commit sha 821d17678dd6c6efaedc312770d5eef8be48c704

Merge pull request #1 from migue1s/code-climate Adds the code-climate config

view details

push time in a day

create barnchmigue1s/SpaceCompanyMobile

branch : v1test

created branch time in a day

create barnchmigue1s/SpaceCompanyMobile

branch : master

created branch time in a day

create barnchmigue1s/SpaceCompanyMobile

branch : code-climate

created branch time in a day

created repositorymigue1s/SpaceCompanyMobile

created time in a day

delete branch migue1s/SpaceCompanyNative

delete branch : code-climate

delete time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha ea795ec09510250df614f9535f7a47c80ae48c92

Adds the code-climate config

view details

Miguel

commit sha b4702ac967d871de7411cd84e31641c59a190352

Merge pull request #5 from migue1s/code-climate Adds the code-climate config

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha ea795ec09510250df614f9535f7a47c80ae48c92

Adds the code-climate config

view details

push time in a day

create barnchmigue1s/SpaceCompanyNative

branch : code-climate

created branch time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha d67f3a855fc072bc38f09661695cad09f9cce418

Fixes linter

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 665d03c8c03a725998650ddbc3edbf90cb12a1a4

Fixes linter

view details

push time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 1d0a3910ef685bfce28260c6249bc2eedba7a5b1

Adds the basic resource row

view details

Miguel Saiz

commit sha 48f50fff3ab2b620873acecd5a4fc38aca5d456f

Adds the basic components

view details

push time in a day

issue openedmigue1s/SpaceCompanyNative

Create the resource heading

Style the heading to match v1's style

created time in a day

issue openedmigue1s/SpaceCompanyNative

Add support for templates:

  • [ ] dark/light mode
  • [ ] automatic changes based on mobile settings

created time in a day

issue openedmigue1s/SpaceCompanyNative

Create the machine card:

  • [ ] match UI to v1 web
  • [ ] add to storybooks
  • [ ] hook to redux store
  • [ ] create redux action to buy + update dps

created time in a day

issue openedmigue1s/SpaceCompanyNative

Create the resource row:

  • [ ] Add to storybooks
  • [ ] Add the UI
  • [ ] Hook to redux

created time in a day

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 1a7308e1f31f621f11e663bda50e812ca276891a

Display dummy resources

view details

push time in 5 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha b17616dd87f557aa5ddb915f555e5e71c19fa7d0

Adds the hook to get the resources

view details

Miguel Saiz

commit sha 1054309eca975ed7d6f5c205980a2d93ee7092ba

Adds hook to get resources

view details

push time in 5 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha ca55cc0b19cebebddf99dc8b462386af35aecfd5

Makes tests stateful

view details

push time in 5 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha e8be77be2ec69922f637d88536a2a53904da6224

Moves the web implementation to the legacy folder

view details

push time in 5 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 4d026c07eda8306aa9f0c0e408706b6edf24a277

Adds game tests

view details

push time in 5 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha a7fd9d50709edb8e9108dcffd37ddeda037c7ce3

Extracts magic numbers from calculations

view details

push time in 5 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha ad16fd8e7054771912ab7fe672aa7fa0f0b114ac

Converts data to typescript + adds the update and upgradeStorage functions

view details

push time in 5 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha b409b8b32077fbb3a87e16e5202dcf1fb41ccf39

Adds the resources data

view details

push time in 5 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 7a69bbd270252ac91fb07cfac3b4a3dfaeae3750

Adds storybooks as a button

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 3a0b27fb10be5c9e4678aed0aca86a349400bb41

Adds the navigation library + Resources screen skeleton

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 06ae14941bd8bd0175bc59d8cf6ffa595018deb8

Caches the yarn dependencies

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 7fd149e67f71e2aba2152335fcd07d597d6df52c

Removes unneccesary mock

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha a4897b088e1c075988b7034f47336836a85f8114

Starts adding the basic gameloop

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 91d62d751312d325167192e2c2eb7337caf3a609

Adds initial typing for data

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 7c58b28698b679dfa3d5f25d6bae1f73cd169f50

Adds the duration formatter to the resource bullet

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha c37b06be5a0d060d8d98cf93d9857d487801e64f

Validates against possible crash

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha c7096ebf1e43c6087249ad26f2bf29676dcc884f

Adds the time formatter

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 8f578d5bbe62bfce18731a02288ef106c38f1273

Implements the ResourceBullet

view details

Miguel Saiz

commit sha 452ffada7f26c8b0fc5d6c853612d5e367bee061

Merge branch 'master' of github.com:migue1s/SpaceCompanyNative

view details

push time in 7 days

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha 0d1c990bd668c43619cba02ab33f1a923fb14a3c

Delete App-test.js

view details

push time in 9 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 45a8df876981de09d07832b199949eb3b0f67a63

Adds the resource storybooks

view details

push time in 14 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 9a2b0d5edad853773ef1533ad704841a2ab4b2ee

Adds prettier

view details

push time in 14 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 8f2f0788bb242bf5a59d7af70bc5bad45bf95050

Adds skeleton for resource story

view details

push time in 14 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha ce54776394ce69a0c6fe59336c0c9b2b632e4ea2

Adds skeletons for initial resource components

view details

push time in 14 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha de766434357148e8ddaa79435ee5ffa8d8a84db4

Adds storybooks

view details

push time in 14 days

push eventmigue1s/SpaceCompanyNative

Miguel

commit sha ad0c5b9cdf10f5529fcb2ffee1bae42718dbb701

Update README.md

view details

push time in 14 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 1681087f868471822c7f709ac23ae0ff27f748b9

Adds test coverage + codeclimate reporting

view details

push time in 14 days

push eventmigue1s/SpaceCompanyNative

Miguel Saiz

commit sha 42d77ac947afe7e544b40f836af6e68e21f53f55

Adds a typescript react-native template

view details

push time in 14 days

create barnchmigue1s/SpaceCompanyNative

branch : master

created branch time in 14 days

issue openedsparticle999/SpaceCompany

V1.0 Out of sync buys

On v1, there is currently a UI delay when buying metal storage. I have the resources up to oil and have not seen this happening for the others (I speculate this will also happen to lunarite).

space

The root cause is probably the fact that metal is doing a lot of updates elsewhere on the DOM, I think it's likely that removing the hidden pages from the DOM will actually fix this issue.

created time in 14 days

fork migue1s/sentry-docs

The new place for the sentry documentation (and tools to build it)

https://docs.sentry.io

fork in 15 days

more