profile
viewpoint
Grachev Mikhail mgrachev @evrone Moscow https://www.mgrachev.com 🚀 Backend Developer (Rust, Go, Ruby), DevOps Engineer 🐳

dotenv-linter/dotenv-linter 565

⚡️Lightning-fast linter for .env files. Written in Rust 🦀

mgrachev/gastly 83

👻 Create screenshots or previews of web pages

mgrachev/mina-hanami 13

🌸 Mina plugin for Hanami

mgrachev/capistrano-hanami 11

🌸 Hanami tasks for Capistrano

mgrachev/brevity 6

😜 Another useless service for shortening links in Go

dotenv-linter/action-dotenv-linter 5

⚡️Run dotenv-linter with reviewdog 🐶

Antiarchitect/kubeboot 4

Development environment bootstrapping on MiniKube and Helm.

mgrachev/mgrachev.github.io 3

Blog and homepage

mgrachev/pivotal_tracker_telegram_bot 2

💬 Track your Pivotal Tracker projects in Telegram

mgrachev/capybara-rspec-remote-template 1

Template for remote acceptance testing with RSpec and Capybara

issue commentdotenv-linter/dotenv-linter

Automatic changelog adding of new commits on merge in master

In fact, this can be done even at the stage of the release build, in order to avoid unnecessary bot commits(per each PR) and line conflicts, writing the entire block of changes at once.

I would think more how to implement this one, because I wouldn't like to have a lot of bot commits 😅

mstruebing

comment created time in a day

issue commentdotenv-linter/dotenv-linter

Automatic changelog adding of new commits on merge in master

That would be really very helpful! 👍 I already thought about this, the only thing is not always clear how to automatically classify PR (Added / Changed) 🤔

In fact, this can be done even at the stage of the release build, in order to avoid unnecessary bot commits(per each PR) and line conflicts, writing the entire block of changes at once.

There are two options to do that:

  1. Follows Conventional Commits rules and uses prefixes: feat and fix. To ensure that contributors follow these rules we can add the commitlint;
  2. Uses labels like feature and changes.

I like more the first option.

mstruebing

comment created time in a day

push eventdotenv-linter/dotenv-linter

Artem Medvedev

commit sha 3089cb3d4808f3ae12e9fd406a8f32fafe8f646d

Add .gitattributes to improve git diff (#329) (#330) * Add .gitattributes to improve git diff (#329) * Update CHANGELOG.md * Remove extra idents Co-authored-by: Grachev Mikhail <work@mgrachev.com> Co-authored-by: Grachev Mikhail <work@mgrachev.com>

view details

push time in a day

delete branch dotenv-linter/dotenv-linter

delete branch : gitattributes

delete time in a day

PR merged dotenv-linter/dotenv-linter

Add .gitattributes to improve git diff (#329)

Closes #329

<!-- Please make sure to review and check all of these items: -->

✔ Checklist:

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] This PR has been added to CHANGELOG.md (at the top of the list);

<!-- NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. -->

+3 -0

1 comment

2 changed files

DDtKey

pr closed time in a day

issue closeddotenv-linter/dotenv-linter

Add .gitattributes for Rust

https://tekin.co.uk/2020/10/better-git-diff-output-for-ruby-python-elixir-and-more

closed time in a day

mgrachev
PullRequestReviewEvent

Pull request review commentdotenv-linter/dotenv-linter

Add .gitattributes to improve git diff (#329)

+*.rs    diff=rust+*.md    diff=markdown
*.rs diff=rust
*.md diff=markdown

Are these indents necessary?

DDtKey

comment created time in a day

PullRequestReviewEvent
PullRequestReviewEvent

startedrubocop-hq/rubocop-md

started time in a day

delete branch mgrachev/this-week-in-rust

delete branch : patch-1

delete time in 2 days

pull request commentdotenv-linter/dotenv-linter

Shows files that were linted

But in general, it is not necessary that in the future the structure of the output does not change much with the appearance of the output "on the fly" 🙂

@DDtKey Maybe you would like to implement on-the-fly output? 😉

Anthuang

comment created time in 2 days

pull request commentdotenv-linter/dotenv-linter

Shows files that were linted

It seems to me that it was about interactive mode. When we see the progress of checking files on the fly (many CLI utilities do just that)

You are absolutely right. This is just the first iteration. We can add the progress of checking files on the fly later.

Perhaps the dotenv-linter works very quickly and even with a large number of files it is not necessary, but in this case, it generally does not make much sense, except for displaying the files that have been checked(which is also important) 🤔

Right now dotenv-linter does not output anything if it did not find problems in the .env files. In such situation, it is not obvious to the user whether dotenv-linter has checked all the files or not. So, this PR fixes that case.

Anthuang

comment created time in 2 days

issue openeddotenv-linter/dotenv-linter

Add .gitattributes for Rust

https://tekin.co.uk/2020/10/better-git-diff-output-for-ruby-python-elixir-and-more

created time in 2 days

startedkoalaman/shellcheck

started time in 2 days

pull request commentdotenv-linter/dotenv-linter

Shows files that were linted

@Anthuang Thank you! I'm going to merge this PR after v2.2.1 release.

Anthuang

comment created time in 3 days

pull request commentdotenv-linter/dotenv-linter

Color output and --no-color option

@Nikhil0487 Thank you! I'm going to merge this PR after v2.2.1 release.

Nikhil0487

comment created time in 3 days

pull request commentdotenv-linter/dotenv-linter

Color output and --no-color option

@mgrachev @DDtKey

I have analyzed (including going through colored repo) and I couldn't figure out how to test colored/--no-color output. All the output with/without -no-color flag gives output without any color.

Any clues/hints would help me to come up with something.

Nothing comes to mind right now. Let's delete this test because it's useless.

Nikhil0487

comment created time in 3 days

pull request commentdotenv-linter/dotenv-linter

Shows files that were linted

@Anthuang Please fix conflicts.

Anthuang

comment created time in 3 days

push eventdotenv-linter/dotenv-linter

Christopher Morton

commit sha 01110fa5415e650670275fcaf96e3f6f87ca4fd8

Fix cyclic symbolic link recursion (#328) When in recursive mode: do not follow symbolic links within target directories. See #326. - Add check in crate::get_file_paths to only get subdirectories if they are not symlinks. - Add test with a cyclic symlink. - Add symlink creation function for unix and windows to use in test.

view details

push time in 3 days

PR merged dotenv-linter/dotenv-linter

Fix cyclic symbolic link recursion

When in recursive mode: do not follow symbolic links within target directories. See #326.

  • Add check in crate::get_file_paths to only get subdirectories if they are not symlinks.

  • Add test with a cyclic symlink.

  • Add symlink creation function for unix and windows to use in test.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests. -->

<!-- Please make sure to review and check all of these items: -->

✔ Checklist:

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] This PR has been added to CHANGELOG.md (at the top of the list);
  • [x] Tests for the changes have been added (for bug fixes / features);
  • [x] Docs have been added / updated (for bug fixes / features).

<!-- NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. -->

+46 -1

1 comment

6 changed files

sonro

pr closed time in 3 days

issue closeddotenv-linter/dotenv-linter

Long recursion possible with cyclic links in dir tree

Create a single file and a symbolic link to its containing dir:

$ mkdir -p /tmp/project
$ echo 'ohno' > /tmp/project/.env
$ ln -s /tmp/project/ /tmp/project/back_to_root
$ tree -a /tmp/project
/tmp/project
├── back_to_root -> /tmp/project/
└── .env

Run linter with recursive search:

$ cargo run -- -r /tmp/project/
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/dotenv-linter -r /tmp/project/`
../../../../tmp/project/.env:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/back_to_root/.env:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/back_to_root/back_to_root/.env:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
[snipped]

Found 41 problems

It follows the link and rechecks the same file again and again.

Possible solutions:

  1. Don't follow links
  2. Keep track of already visited dirs in canonicalized form

closed time in 3 days

ametalon
PullRequestReviewEvent

startedVenoox/gnu-rust-utils

started time in 3 days

pull request commentdotenv-linter/dotenv-linter

Add default exclude list

@ametalon Thank you for your help! 🚀

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

ametalon

comment created time in 3 days

push eventdotenv-linter/dotenv-linter

Andrey Ikonnikov

commit sha f48e402c8c4628979db10c913baf074a37ea1ac8

Add default exclude list (#324) * first stab at #323 This implementation hard-excludes files and there is no way to run checks on them. Even running the linter with these files listed explicitly will still skip them. * update changelog * Update CHANGELOG.md Co-authored-by: Andrey Ikonnikov <1897517+metalon@users.noreply.github.com> Co-authored-by: Grachev Mikhail <work@mgrachev.com>

view details

push time in 3 days

PR merged dotenv-linter/dotenv-linter

Add default exclude list

First stab at #323 This implementation hard-excludes files and there is no way to run checks on them. Even running the linter with these files listed explicitly will still skip them.

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests. -->

<!-- Please make sure to review and check all of these items: -->

✔ Checklist:

<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

  • [x] This PR has been added to CHANGELOG.md (at the top of the list);
  • [x] Tests for the changes have been added (for bug fixes / features);
  • [x] Docs have been added / updated (for bug fixes / features).

<!-- NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. -->

+7 -1

4 comments

2 changed files

ametalon

pr closed time in 3 days

issue closeddotenv-linter/dotenv-linter

Invalid linting on .envrc (direnv) files

direnv uses .envrc files which are bash scripts, and dotenv-linter is attempting to parse those. When I ran dotenv-linter, I got the following as errors:

.envrc:2 KeyWithoutValue: The source_up key should be with a value or have an equal sign
.envrc:4 KeyWithoutValue: The use kerl --auto key should be with a value or have an equal sign
.envrc:5 KeyWithoutValue: The use kiex --auto key should be with a value or have an equal sign
.envrc:6 KeyWithoutValue: The use nvm --auto key should be with a value or have an equal sign
.envrc:7 KeyWithoutValue: The use chruby --auto key should be with a value or have an equal sign
.envrc:10 KeyWithoutValue: The dotenv key should be with a value or have an equal sign

All of these are correct, because they are functions in either the direnv standard library or in an extension that I have on my computer.

As direnv-based .envrc files are not merely .env files but full bash scripts, it is probably less than ideal that .envrc files are included in the default scanning pattern, and I would suggest that a warning be printed if scanning .envrc files manually.

The auto-fix for shell functions &c with direnv scripts breaks things badly:

--- .envrc	2020-10-15 11:48:53.000000000 -0400
+++ .envrc.backup	2020-07-16 22:11:45.000000000 -0400
@@ -1,13 +1,13 @@
 # shellcheck disable=SC2148
-source_up=
+source_up
 
-use chruby --auto=
-use kerl --auto=
-use kiex --auto=
-use nvm --auto=
+use kerl --auto
+use kiex --auto
+use nvm --auto
+use chruby --auto
 
 # use dotenv for compatibility with Docker and Docker Compose
-dotenv=
+dotenv

closed time in 3 days

halostatue
PullRequestReviewEvent

push eventametalon/dotenv-linter

Grachev Mikhail

commit sha 8dec02101869aa5bcedca033204ef90e75aba632

Update CHANGELOG.md

view details

push time in 3 days

pull request commentdotenv-linter/dotenv-linter

#325 Linter rechecks files if they were listed more than once

@Aashu23 Thank you! 👍

🙏 If it’s not difficult for you, please support the project - click on the star on GitHub ⭐️

Aashu23

comment created time in 3 days

push eventdotenv-linter/dotenv-linter

Aashu Rani

commit sha fdc67d77a96cd29983c8d0a8f65657f2686f55a5

#325 Linter rechecks files if they were listed more than once (#327) * #325 Linter rechecks files if they were listed more than once * #325 Update changelog.md * #325 Update changelog.md to put change at the top of list * Add test to ensure each file is checked only once and update changelog comment (#325) * Fix tests and changelog userid comment

view details

push time in 3 days

PR merged dotenv-linter/dotenv-linter

#325 Linter rechecks files if they were listed more than once

@mgrachev Fixed the issue Updated tests accordingly

Fixes #325

✔ Checklist:

  • [x] This PR has been added to CHANGELOG.md (at the top of the list);
  • [x] Tests for the changes have been added (for bug fixes / features);
+53 -8

1 comment

4 changed files

Aashu23

pr closed time in 3 days

issue closeddotenv-linter/dotenv-linter

Linter rechecks files if they were listed more than once

Create 3 files in one dir:

$ mkdir -p /tmp/project
$ for f in a b c; do echo "ohno" > /tmp/project/.env.$f; done
$ tree -a /tmp/project
/tmp/project
├── .env.a
├── .env.b
└── .env.c

Listing whole dir twice leads to each file being checked twice:

$ cargo run -- /tmp/project/ /tmp/project/
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/dotenv-linter /tmp/project/ /tmp/project/`
../../../../tmp/project/.env.a:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.b:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.c:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.a:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.b:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.c:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign

Found 6 problems

Listing file .env.a and whole dir works as expected:

$ cargo run -- /tmp/project/ /tmp/project/.env.a
    Finished dev [unoptimized + debuginfo] target(s) in 0.03s
     Running `target/debug/dotenv-linter /tmp/project/ /tmp/project/.env.a`
../../../../tmp/project/.env.a:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.b:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.c:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign

Found 3 problems

Hovewer, listing file .env.b and whole dir leads to the file being checked twice:

$ cargo run -- /tmp/project/ /tmp/project/.env.b
    Finished dev [unoptimized + debuginfo] target(s) in 0.02s
     Running `target/debug/dotenv-linter /tmp/project/ /tmp/project/.env.b`
../../../../tmp/project/.env.b:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.a:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.b:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign
../../../../tmp/project/.env.c:1 KeyWithoutValue: The ohno key should be with a value or have an equal sign

Found 4 problems

I guess the issue is here https://github.com/dotenv-linter/dotenv-linter/blob/281a2030aa66bd3d3dcbbabb1636659548e96a98/src/lib.rs#L101-L103 Sorted file names extended with file names from dirs and then consecutive duplicates removed.

In case with file .env.a:

# file names
/tmp/project/.env.a
# file names from dirs
/tmp/project/.env.a <- removed by deduplication
/tmp/project/.env.b
/tmp/project/.env.c

In case with file .env.b:

# file names
/tmp/project/.env.b
# file names from dirs
/tmp/project/.env.a
/tmp/project/.env.b <- isn't removed because there are no consecutive duplicates here
/tmp/project/.env.c

Switching order of sorting and extending should fix the issue. Yay, 100 line long babbling for 2 line change in code!

closed time in 3 days

ametalon
PullRequestReviewEvent

Pull request review commentdotenv-linter/dotenv-linter

Add default exclude list

 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### 🚀 Added - Add action-yamllint [#317](https://github.com/dotenv-linter/dotenv-linter/pull/317) ([@vk26](https://github.com/vk26))+- Add exclude list [#324](https://github.com/dotenv-linter/dotenv-linter/pull/324) ([@ametalon](https://github.com/ametalon))
- Add default exclude list [#324](https://github.com/dotenv-linter/dotenv-linter/pull/324) ([@ametalon](https://github.com/ametalon))
ametalon

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentdotenv-linter/dotenv-linter

Add default exclude list

 use std::path::PathBuf;  use crate::common::*; +const EXCLUDED_FILES: &[&str] = &[".envrc"];

Okay, let it be 🙂

ametalon

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentdotenv-linter/dotenv-linter.github.io

Mention default exclusion list

 $ dotenv-linter -f --no-backup  All warnings are fixed. Total: 2 ```++Some tools use `.env` file names but content of these files is not what `dotenv-linter` expects.+Currently `dotenv-linter` doesn't check `.envrc` files because `direnv` uses them as bash scripts.
Currently `dotenv-linter` doesn't check `.envrc` files because [direnv](https://direnv.net) uses them as bash scripts.
ametalon

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentdotenv-linter/dotenv-linter

#325 Linter rechecks files if they were listed more than once

 fn checks_two_specific_files() {     testdir.test_command_fail_with_args(args, expected_output); } +#[test]+fn checks_each_file_only_once_when_listing_same_path_twice() {+    let testdir = TestDir::new();+    testdir.create_testfile(".env", "foo=\n");++    let subdir = testdir.subdir();+    let testfile_1 = subdir.create_testfile(".env", " FOO=\n");+    let testfile_2 = subdir.create_testfile(".env", " FOO=val\nBAR=foo\n");++    let args = &[subdir.as_str(), subdir.as_str()];+    let expected_output = format!(+        "{}:1 LeadingCharacter: Invalid leading character detected\n{}:2 UnorderedKey: The BAR key should go before the FOO key\n\nFound 2 problems\n",+        Path::new(&testdir.relative_path(&subdir))+            .join(testfile_1.shortname_as_str())+            .to_str().expect("multi-platform path to test .env file"),+        Path::new(&testdir.relative_path(&subdir))+            .join(testfile_2.shortname_as_str())+            .to_str().expect("multi-platform path to test .env file")+    );++    testdir.test_command_fail_with_args(args, expected_output);+}++#[test]+fn checks_each_file_only_once_when_listing_one_path_and_one_file() {+    let testdir = TestDir::new();+    testdir.create_testfile(".env", "foo=\n");

Why this file is needed? You don't use it in the test case.

Aashu23

comment created time in 4 days

Pull request review commentdotenv-linter/dotenv-linter

#325 Linter rechecks files if they were listed more than once

 fn checks_two_specific_files() {     testdir.test_command_fail_with_args(args, expected_output); } +#[test]+fn checks_each_file_only_once_when_listing_same_path_twice() {+    let testdir = TestDir::new();+    testdir.create_testfile(".env", "foo=\n");

Why this file is needed? You don't use it in the test case.

Aashu23

comment created time in 4 days

Pull request review commentdotenv-linter/dotenv-linter

#325 Linter rechecks files if they were listed more than once

 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add action-yamllint [#317](https://github.com/dotenv-linter/dotenv-linter/pull/317) ([@vk26](https://github.com/vk26))  ### 🔧 Changed+- Fix linter rechecking files if they were listed more than once [#327](https://github.com/dotenv-linter/dotenv-linter/pull/327) ([@aashu23](https://github.com/Aashu23))
- Fix linter rechecking files if they were listed more than once [#327](https://github.com/dotenv-linter/dotenv-linter/pull/327) ([@Aashu23](https://github.com/Aashu23))
Aashu23

comment created time in 4 days

Pull request review commentdotenv-linter/dotenv-linter

#325 Linter rechecks files if they were listed more than once

 fn checks_two_specific_files() {     testdir.test_command_fail_with_args(args, expected_output); } +#[test]+fn checks_each_file_only_once_when_listing_same_path_twice() {+    let testdir = TestDir::new();+    testdir.create_testfile(".env", "foo=\n");++    let subdir = testdir.subdir();+    let testfile_1 = subdir.create_testfile(".env", " FOO=\n");+    let testfile_2 = subdir.create_testfile(".env", " FOO=val\nBAR=foo\n");

You can't create files with the same name in the same directory.

Aashu23

comment created time in 4 days

Pull request review commentdotenv-linter/dotenv-linter

#325 Linter rechecks files if they were listed more than once

 fn checks_two_specific_files() {     testdir.test_command_fail_with_args(args, expected_output); } +#[test]+fn checks_each_file_only_once_when_listing_same_path_twice() {+    let testdir = TestDir::new();+    testdir.create_testfile(".env", "foo=\n");++    let subdir = testdir.subdir();+    let testfile_1 = subdir.create_testfile(".env", " FOO=\n");+    let testfile_2 = subdir.create_testfile(".env", " FOO=val\nBAR=foo\n");++    let args = &[subdir.as_str(), subdir.as_str()];+    let expected_output = format!(+        "{}:1 LeadingCharacter: Invalid leading character detected\n{}:2 UnorderedKey: The BAR key should go before the FOO key\n\nFound 2 problems\n",+        Path::new(&testdir.relative_path(&subdir))+            .join(testfile_1.shortname_as_str())+            .to_str().expect("multi-platform path to test .env file"),+        Path::new(&testdir.relative_path(&subdir))+            .join(testfile_2.shortname_as_str())+            .to_str().expect("multi-platform path to test .env file")+    );++    testdir.test_command_fail_with_args(args, expected_output);+}++#[test]+fn checks_each_file_only_once_when_listing_one_path_and_one_file() {+    let testdir = TestDir::new();+    testdir.create_testfile(".env", "foo=\n");++    let subdir = testdir.subdir();+    let testfile_1 = subdir.create_testfile(".env", " FOO=\n");+    let testfile_2 = subdir.create_testfile(".env", " FOO=val\nBAR=foo\n");

You can't create files with the same name in the same directory.

Aashu23

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventmgrachev/this-week-in-rust

Grachev Mikhail

commit sha c93f4781ad6928dcdca30c03720ee281e4363d05

Add article about dotenv-linter v2.2.0

view details

push time in 4 days

fork mgrachev/this-week-in-rust

Data for this-week-in-rust.org

fork in 4 days

delete branch reviewdog/action-hadolint

delete branch : depup/hadolint

delete time in 4 days

push eventreviewdog/action-hadolint

github-actions[bot]

commit sha 1313ccf30fe2d408f9ec087ccd6f2d6ba89ebfdc

chore(deps): update hadolint to 1.18.2 (#28) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

view details

push time in 4 days

PR merged reviewdog/action-hadolint

chore(deps): update hadolint to 1.18.2 bump:minor

Update hadolint to v1.18.2 Compare v1.18.0...v1.18.2

This PR is auto generated by depup workflow.

+1 -1

0 comment

1 changed file

github-actions[bot]

pr closed time in 4 days

PullRequestReviewEvent

Pull request review commentdotenv-linter/dotenv-linter

#325 Linter rechecks files if they were listed more than once

 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add action-yamllint [#317](https://github.com/dotenv-linter/dotenv-linter/pull/317) ([@vk26](https://github.com/vk26))  ### 🔧 Changed+- Fix Linter rechecking files if they were listed more than once [#327](https://github.com/dotenv-linter/dotenv-linter/pull/327) ([@aashu23](https://github.com/Aashu23))
- Fix linter rechecking files if they were listed more than once [#327](https://github.com/dotenv-linter/dotenv-linter/pull/327) ([@aashu23](https://github.com/Aashu23))
Aashu23

comment created time in 4 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentdotenv-linter/dotenv-linter

Long recursion possible with cyclic links in dir tree

@ametalon Thank you! I like more the first option.

@dotenv-linter/core What do you think?

ametalon

comment created time in 5 days

issue commentdotenv-linter/dotenv-linter

Linter rechecks files if they were listed more than once

@ametalon Thank you for your help! We are planning to fix this bug in the next release.

ametalon

comment created time in 5 days

pull request commentdotenv-linter/dotenv-linter

Add default exclude list

Sure, just wanted to make sure that you ok with the approach I took. Readme doesn't mention exclusion option at all and redirects to the docs for more info. Should I copy paragraph from the docs or leave readme as is? I'm failing to see how I can add stuff to the docs, could you give me directions?

All documentation lives here: https://github.com/dotenv-linter/dotenv-linter.github.io

Please add information about these changes to this page https://dotenv-linter.github.io/#/usage (at the bottom of the page)

ametalon

comment created time in 5 days

Pull request review commentdotenv-linter/dotenv-linter

Add default exclude list

 use std::path::PathBuf;  use crate::common::*; +const EXCLUDED_FILES: &[&str] = &[".envrc"];
const IGNORE_LIST: &[&str] = &[".envrc"]; // https://direnv.net

I like the name IGNORE_LIST better. What do you think about it? Also, it would be great if you added a comment why we ignore this file name.

ametalon

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventdotenv-linter/dotenv-linter.github.io

Grachev Mikhail

commit sha 1d0b2ea7cc7bd1453ba605ea82a3170be118921b

Update --no-backup example (#8)

view details

push time in 6 days

delete branch dotenv-linter/dotenv-linter.github.io

delete branch : mgrachev-patch-1

delete time in 6 days

create barnchdotenv-linter/dotenv-linter.github.io

branch : mgrachev-patch-1

created branch time in 6 days

pull request commentreviewdog/action-brakeman

Enhancement: Add action-yamllint

@vk26 Thank you for your contribution! 🙂

vk26

comment created time in 7 days

push eventreviewdog/action-brakeman

Dmitry Belyavtsev

commit sha ed730a5f1c17c4314333b4ba7857caf520e4a6d5

Add action-yamllint

view details

Grachev Mikhail

commit sha 8696937ee58c57270a3cc7909695e5ed40c289c1

Merge pull request #13 from vk26/add-action-yamllint Enhancement: Add action-yamllint

view details

push time in 7 days

PR merged reviewdog/action-brakeman

Enhancement: Add action-yamllint

Add action-yamllint to .github/workflows

+17 -0

0 comment

1 changed file

vk26

pr closed time in 7 days

issue closedreviewdog/action-brakeman

Add action-yamllint

Add action-yamllint to lint yaml files.

Link: https://github.com/reviewdog/action-yamllint

closed time in 7 days

mgrachev
PullRequestReviewEvent

pull request commentdotenv-linter/action-dotenv-linter

Enhancement: Add action-yamllint

@vk26 Thank you for your contribution! 🚀

vk26

comment created time in 7 days

push eventdotenv-linter/action-dotenv-linter

Dmitry Belyavtsev

commit sha 8799d89d3c0d94f4814a128cfe1a477cdaf7f374

Add action-yamllint (#18)

view details

push time in 7 days

PR merged dotenv-linter/action-dotenv-linter

Enhancement: Add action-yamllint

Add action-yamllint to .github/workflows/

+17 -0

0 comment

1 changed file

vk26

pr closed time in 7 days

issue closeddotenv-linter/action-dotenv-linter

Add action-yamllint

Add action-yamllint to lint yaml files.

Link: https://github.com/reviewdog/action-yamllint

closed time in 7 days

mgrachev
PullRequestReviewEvent

pull request commentdotenv-linter/dotenv-linter.github.io

Fix broken checks links

@dem23step Good catch! Thanks a lot! 🙏

dem23step

comment created time in 7 days

push eventdotenv-linter/dotenv-linter.github.io

Dmitry Stepanenko

commit sha 693c83ea949ded7f7272c891101b70c4c0257c87

Fix broken checks links (#7)

view details

push time in 7 days

PullRequestReviewEvent

pull request commentreviewdog/action-reek

Enhancement: Add action-yamllint

@vk26 Thank you for your contribution! ❤️

vk26

comment created time in 8 days

push eventreviewdog/action-reek

Dmitry Belyavtsev

commit sha 4e0e10abaaa2edd7c2e28f6319cd7bfbac64c7d1

Add action-yamllint

view details

Grachev Mikhail

commit sha bf391c0dbfa6fb116f96e9697389a070105992a1

Merge pull request #12 from vk26/add-action-yamllint Enhancement: Add action-yamllint

view details

push time in 8 days

PR merged reviewdog/action-reek

Enhancement: Add action-yamllint

Add action-yamllint to .github/workflows/

+17 -0

0 comment

1 changed file

vk26

pr closed time in 8 days

issue closedreviewdog/action-reek

Add action-yamllint

Add action-yamllint to lint yaml files.

Link: https://github.com/reviewdog/action-yamllint

closed time in 8 days

mgrachev

pull request commentreviewdog/action-rubocop

Enhancement: Add action-yamllint

@vk26 Thank you for your contribution! 💪

vk26

comment created time in 8 days

push eventreviewdog/action-rubocop

Dmitry Belyavtsev

commit sha 5c0ce7369b237cea1d344c386f2231b2ba02a744

Add action-yamllint

view details

Grachev Mikhail

commit sha dc0b95cb78a6a1120a4a88ff75ed321caa3af06f

Merge pull request #23 from vk26/add-action-yamllint Enhancement: Add action-yamllint

view details

push time in 8 days

PR merged reviewdog/action-rubocop

Enhancement: Add action-yamllint

Add action-yamllint to .github/workflows/

+17 -0

0 comment

1 changed file

vk26

pr closed time in 8 days

issue closedreviewdog/action-rubocop

Add action-yamllint

Add action-yamllint to lint yaml files.

Link: https://github.com/reviewdog/action-yamllint

closed time in 8 days

mgrachev

pull request commentreviewdog/action-hadolint

Enhancement: Add action-yamllint

@vk26 Thank you for your contribution! 🚀

vk26

comment created time in 8 days

push eventreviewdog/action-hadolint

Dmitry Belyavtsev

commit sha 1969472b33e90fc4ae584d3a4afe4997c91abf89

Add action-yamllint (#27)

view details

push time in 8 days

PR merged reviewdog/action-hadolint

Enhancement: Add action-yamllint

Add action-yamllint to .github/workflows/

+17 -0

0 comment

1 changed file

vk26

pr closed time in 8 days

issue closedreviewdog/action-hadolint

Add action-yamllint

Add action-yamllint to lint yaml files.

Link: https://github.com/reviewdog/action-yamllint

closed time in 8 days

mgrachev
PullRequestReviewEvent
more