mbostock ( Mike Bostock )

Right now, the only way to add use the the topojson-client is to import it like this:

import * as topojson from "topojson-client";

What if we export it in a way that we can use it like:

import topojson from "topojson-client";

closed time in 4 hours

pedroapfilho

issue commenttopojson/topojson-client

Add default export

No. If you want to import everything, use * to import the namespace. Otherwise, import specific symbols, e.g., import {feature} from "topojson-client";. I don’t think it’s appropriate to make the namespace itself a symbol.

pedroapfilho

comment created time in 4 hours

issue closedd3/d3-selection

Event management and arrow function (v6)

d3 version 6 has made significant changes to event management. It is no longer possible to use arrow function like this:

selection.on("mouseenter", (d, i, nodes) => {
    d3.select(nodes[i]);
});

This technique was used to replicate this:

selection.on("mouseenter", function() {
    d3.select(this);
});

D3 6.0 migration guide made no mention of how to use arrow function for event management when this is required.

closed time in 2 days

peterith

issue commentd3/d3-selection

Event management and arrow function (v6)

Try

selection.on("mouseenter", (event) => {
    d3.select(event.currentTarget);
});

peterith

comment created time in 2 days

issue commentvega/vega

Should the maximal bin produced by the Bin transform be inclusive or exclusive?

FWIW d3.bin will still have an inclusive upper bound for the last bin, too; it’s just that we’re increasing the default niced domain’s upper bound to make an extra bin when there are input values that equal the (initially) niced domain’s upper bound. This avoids the confusing edge case of these maximal values going into the last bin as shown above, but only when no domain is explicitly specified and when nice ticks are requested.

mbostock

comment created time in 2 days

issue openedvega/vega

When the maximum data value is coincident with the niced domain’s upper bound, these maximum values are placed in the wrong bin.

This is a bug inherited from d3-array, which I’m fixing here: https://github.com/d3/d3-array/pull/177

Consider this histogram:

{
  "$schema": "https://vega.github.io/schema/vega-lite/v4.json",
  "data": {
    "values": [
      {"a": 0},
      {"a": 10},
      {"a": 20},
      {"a": 20},
      {"a": 210},
      {"a": 220},
      {"a": 230},
      {"a": 230},
      {"a": 240},
      {"a": 240},
      {"a": 240},
      {"a": 240},
      {"a": 240},
      {"a": 240}
    ]
  },
  "mark": {"type": "bar", "tooltip": true},
  "width": 400,
  "encoding": {
    "x": {"bin": {"maxbins": 100}, "field": "a"},
    "y": {"aggregate": "count"}
  }
}

visualization

The 240 values are included in the last bin, [235-240]. This is surprising because for all other bins, the upper bound is exclusive. And, with a small change to the data to increase one value, this inconsistency is more apparent:

{
  "$schema": "https://vega.github.io/schema/vega-lite/v4.json",
  "data": {
    "values": [
      {"a": 0},
      {"a": 10},
      {"a": 20},
      {"a": 20},
      {"a": 210},
      {"a": 220},
      {"a": 230},
      {"a": 230},
      {"a": 240},
      {"a": 240},
      {"a": 240},
      {"a": 240},
      {"a": 240},
      {"a": 241}
    ]
  },
  "mark": {"type": "bar", "tooltip": true},
  "width": 400,
  "encoding": {
    "x": {"bin": {"maxbins": 100}, "field": "a"},
    "y": {"aggregate": "count"}
  }
}

visualization (1)

The proposed fix in d3-array is to extend the niced domain’s upper bound by one tick, so that in both of these examples, the domain will be [0, 245], and the last bin will be [240, 245] rather than [235, 240].

created time in 2 days

PR opened d3/d3-array

Reviewers

Fix zero-width last bin.

This follows #174 to fix an edge case where the input data’s maximum value is coincident with the niced upper bound of the domain. When this occurs, we extend the niced upper bound by one additional tick step to again ensure uniform bin widths.

Ref. https://observablehq.com/d/a9da34f2bbf326b0

+41 -17

1 commit in d3/d3-array/tree/fix-exclusive-upper-bound d3/d3-array/tree/master

0 comment

2 changed files

pr created time in 2 days

push eventd3/d3-array

Mike Bostock

commit sha 1a23ff0c8673654075bc896d0c1a7bf24637642d

Fix zero-width last bin.

Steps to replicate:

Expected Behaviour

Actual Behaviour

Remove Google Analytics