profile
viewpoint
Matt Stauffer mattstauffer Tighten (@tightenco) Gainesville, FL http://mattstauffer.com/

push eventlaravel/valet

Chris Brown

commit sha 02ad7f44ff7c3341af9f8b6c2a8544cd2e900370

Dnsmasq allows use of a common config folder, much like nginx and php do. This PR changes Valet's default config process to empower this feature, which makes installation less intrusive, and easier to identify and remove valet-specific customizations. This will make for easier troubleshooting ... and easier customizing (such as dropping in a custom logging config, additional TLDs, alternate DNS resolvers, etc) Also removes old dnsmasq configs used by prior Valet versions

view details

Matt Stauffer

commit sha d301e4ac11129bccd3161fe88d28f42a87db18c7

Merge pull request #856 from drbyte/dnsmasq-customconfig Use custom dnsmasq.d folder for easier config and support

view details

push time in 3 hours

PR merged laravel/valet

Use custom dnsmasq.d folder for easier config and support

Dnsmasq allows use of a common config folder, much like nginx and php do.

This PR changes Valet's default config to empower this feature.

This will make for easier troubleshooting ... and easier customizing (such as dropping in a custom logging config, additional TLDs, alternate DNS resolvers, etc)

+54 -59

1 comment

3 changed files

drbyte

pr closed time in 3 hours

push eventlaravel/valet

Chris Brown

commit sha 139a916013249ba97f1e2fcb5364c6c227351724

Move PHP-FPM config to separate valet-specific file This allows the valet configuration to stand separately from the default PHP config. This benefits troubleshooting, makes customization of FPM workers and other settings easer and allows for easier uninstallation. Also renames any previously-existing `www.conf` pool config so it doesn't conflict with Valet nor run unnecessary additional processes.

view details

Matt Stauffer

commit sha fea8208eb0db08aed7eb2a1808fee6fa4f115dd0

Merge pull request #858 from drbyte/phpfpm-simplify Move PHP-FPM pool config to separate valet-specific file

view details

push time in 3 hours

PR merged laravel/valet

Move PHP-FPM pool config to separate valet-specific file

This allows the valet FPM pool configuration to stand separately from the default config.

This benefits troubleshooting, makes customization of FPM workers and other settings easer and allows for easier uninstallation.

(Note: existing Valet installs will have had their PHP /usr/local/etc/php/7.4/php-fpm.d/www.conf files already altered by Valet. It will be best to restore this file to the default version installed by PHP to prevent duplicate FPM pool instances that conflict with each other. Or, simply delete the www.conf file.)

+50 -10

9 comments

2 changed files

drbyte

pr closed time in 3 hours

pull request commentlaravel/valet

Move PHP-FPM pool config to separate valet-specific file

@drbyte <3

drbyte

comment created time in 3 hours

pull request commentlaravel/valet

Fix auto-detection amongst multiple ngrok processes

You are the best

drbyte

comment created time in 3 hours

push eventlaravel/valet

Chris Brown

commit sha 710fa276514820078540e191d9f9982d9a2827e7

Fix auto-detection amongst multiple ngrok processes Ngrok Pro plans allow multiple processes, which means you could be serving several sites simultaneously. This PR allows Valet to correctly identify amongst the active ngrok process URLs. Fixes #145

view details

Matt Stauffer

commit sha 5042b9affe12800048ff97cced4c82c6e6b970a2

Merge pull request #864 from drbyte/ngrok-multiple Fix auto-detection amongst multiple ngrok processes

view details

push time in 3 hours

PR merged laravel/valet

Fix auto-detection amongst multiple ngrok processes

Ngrok Pro plans allow multiple processes, which means you could be serving several sites simultaneously. This PR allows Valet to correctly identify amongst the active ngrok process URLs.

Fixes #145

+7 -7

0 comment

2 changed files

drbyte

pr closed time in 3 hours

issue closedlaravel/valet

Valet Share does not copy or show the latest ngrok url, but only the first one

If you use it more than once, it'll open up multiple ngrok instances (which is fine), but it will keep displaying and copying to the clipboard only the first one.

closed time in 3 hours

vitr

Pull request review commentlaravel/valet

Fix auto-detection amongst multiple ngrok processes

     /**      * Echo the currently tunneled URL.      */-    $app->command('fetch-share-url', function () {-        output(Ngrok::currentTunnelUrl());+    $app->command('fetch-share-url [domain]', function ($domain = null) {+        output(Ngrok::currentTunnelUrl($domain ?: Site::host(getcwd()).'.'.Configuration::read()['tld']));

brilliant

drbyte

comment created time in 3 hours

pull request commentlaravel/laravel

[6.x] Implement integration test and in-memory DB

Renaming feature to integration makes sense. Adding a third doesn't, to me.

driesvints

comment created time in 7 hours

delete branch tightenco/onramp

delete branch : clm/add-track-to-preferences

delete time in a day

push eventtightenco/onramp

Cenitoria Melton

commit sha 710ea48457cd61897a3cb6632634659fa964a3eb

Set up track preferences.

view details

Cenitoria Melton

commit sha a75e38967bac36fb25487baa473c23485f8eb992

Merge branch 'master' into clm/add-track-to-preferences

view details

Cenitoria Melton

commit sha ab5dcf9d9835adbf830a675b5c0e0d53a8a2855a

Remove track from preferences.

view details

Cenitoria Melton

commit sha e3fc83d29e54637dfa22b5aedc2807c06d3b8977

Fill track based on ‘track_id’ rather than preference key.

view details

Cenitoria Melton

commit sha 195bb6ab38d47ebc2ce9b7fc3c57024a511032bb

Add spacing in preferences blade file.

view details

Cenitoria Melton

commit sha e64b81ed92c667df1ef63a42dfab7656e2f4a514

Check for user before saving track.

view details

Matt Stauffer

commit sha c62bc616d0f027769910643cc07ee99885914334

Merge pull request #152 from tightenco/clm/add-track-to-preferences Add "track" to user preferences page

view details

push time in a day

PR merged tightenco/onramp

Reviewers
Add "track" to user preferences page

This PR adds the Track option to the preferences page; enabling a user to view and/or change their track.

Note: The track option is not contained in the Preferences object. It is controlled by the `track_id' column of the Users table.

GIF of change:

update-track

+32 -0

0 comment

2 changed files

sariyana

pr closed time in a day

issue commentlaravel/valet

Valet not working properly after upgrade php version 7.4

@Faisal50x Please share any diagnostic information you have. What is the result of php -v? valet on-latest-version? which php? brew services list? Did you get any errors? Basically, give us as much information as you can. Thanks!

Also, you can try unlinking old versions of PHP: https://github.com/laravel/valet/issues/237#issuecomment-359350235

Faisal50x

comment created time in a day

Pull request review commentlaravel/valet

Fix auto-detection amongst multiple ngrok processes

     /**      * Echo the currently tunneled URL.      */-    $app->command('fetch-share-url', function () {-        output(Ngrok::currentTunnelUrl());+    $app->command('fetch-share-url [domain]', function ($domain = null) {+        output(Ngrok::currentTunnelUrl($domain ?: Site::host(getcwd()).'.'.Configuration::read()['tld']));

Would this struggle if someone's parked it as something else?

drbyte

comment created time in 2 days

pull request commentlaravel/valet

Cater for filepaths with spaces

Thanks @cdavid138 and thanks as always @drbyte for your work helping this be figured out in the original issue. <3

cdavid138

comment created time in 2 days

push eventlaravel/valet

David Connolly

commit sha 5cf4aea612547e7f0553788e61935b7d2c9b15db

Cater for filepaths with spaces Fixes issue where certificates fail to be generated due to a space in the filepath

view details

Matt Stauffer

commit sha 52b3b47db8ea0f77dee00af3a6c78a7c810cc597

Merge pull request #863 from cdavid138/master Cater for filepaths with spaces

view details

push time in 2 days

PR merged laravel/valet

Cater for filepaths with spaces

Fixes issue where certificates fail to be generated when there is a space in the certificate file path

Closes #862

+3 -3

1 comment

1 changed file

cdavid138

pr closed time in 2 days

issue closedlaravel/valet

Certificate not generating when spaces in filepath

Hi there,

I've been battling with this for a couple of days and looking for some assistance.

It seems to be since moving my user folder onto a different internal HD, i'm unable to generate SSLs for sites getting the error:

nginx: [emerg] cannot load certificate "/Volumes/Storage HD/Users/david/.config/valet/Certificates/healthkit.test.crt": BIO_new_file() failed (SSL: error:02001002:system library:fopen:No such file or directory:fopen('/Volumes/Storage HD/Users/david/.config/valet/Certificates/healthkit.test.crt','r') error:2006D080:BIO routines:BIO_new_file:no such file)
nginx: configuration file /usr/local/etc/nginx/nginx.conf test failed

I've read through #807 #329

Unfortunatley those errors have not helped.

Running Mac OS: 10.15.1 Valet: 2.5.4

~ brew services list
Name      Status  User  Plist
dnsmasq   started root  /Library/LaunchDaemons/homebrew.mxcl.dnsmasq.plist
mysql@5.7 started david /Volumes/Storage HD/Users/david/Library/LaunchAgents/homebrew.mxcl.mysql@5.7.plist
nginx     started root  /Library/LaunchDaemons/homebrew.mxcl.nginx.plist
php@7.3   started root  /Library/LaunchDaemons/homebrew.mxcl.php@7.3.plist

Certificates not successfully being generated but no errors when using valet secure

~ ls -ltr ~/.config/valet/Certificates
total 24
-rwxrwxrwx  1 david  staff  1675  3 Dec 09:45 healthkit.test.key
-rwxrwxrwx  1 david  staff  1074  3 Dec 09:45 healthkit.test.csr
-rwxrwxrwx  1 david  staff   744  3 Dec 09:45 healthkit.test.conf

Completely fresh install as of yesterday evening, all help appreciated thanks!

closed time in 2 days

cdavid138

delete branch tightenco/giscus

delete branch : dependabot/npm_and_yarn/fstream-1.0.12

delete time in 2 days

push eventtightenco/giscus

dependabot[bot]

commit sha 42663645a3be7ee6a2a6f6b21e2121aaea109419

Bump fstream from 1.0.11 to 1.0.12 Bumps [fstream](https://github.com/npm/fstream) from 1.0.11 to 1.0.12. - [Release notes](https://github.com/npm/fstream/releases) - [Commits](https://github.com/npm/fstream/compare/v1.0.11...v1.0.12) Signed-off-by: dependabot[bot] <support@github.com>

view details

Matt Stauffer

commit sha 5c8c26ca2870dfa777d4a637ba647819c8fdb015

Merge pull request #76 from tightenco/dependabot/npm_and_yarn/fstream-1.0.12 Bump fstream from 1.0.11 to 1.0.12

view details

push time in 2 days

PR merged tightenco/giscus

Bump fstream from 1.0.11 to 1.0.12 dependencies javascript

Bumps fstream from 1.0.11 to 1.0.12. <details> <summary>Commits</summary>

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+166 -130

0 comment

2 changed files

dependabot[bot]

pr closed time in 2 days

issue closedlaravel/valet

cert issue / refused to connect

I am getting the refused to connect screen. I can ping the sites no problem and get response. I believe it may have to do with the cert issued by valet secure.

When I run sudo /usr/local/opt/nginx/bin/nginx -g 'daemon off;' I receive the following response:

nginx: [emerg] PEM_read_bio_X509_AUX("/Users/<user>/.config/valet/Certificates/site.app.crt") failed (SSL: error:0906D06C:PEM routines:PEM_read_bio:no start line:Expecting: TRUSTED CERTIFICATE)

Recently due to company requirements I had to change my user folder name and path in Mac OS Mojave. Prior to change had no issues with valet. I have followed every error issue to try and resolve with no luck.

closed time in 2 days

drewfitz10

created tagtightenco/lambo

tagv0.5.5

Quick new application creation with Laravel and Valet

created time in 2 days

release tightenco/lambo

v0.5.5

released time in 2 days

pull request commenttightenco/lambo

Authscaff

Thanks @filkrav!

filkrav

comment created time in 2 days

push eventtightenco/lambo

Filipe Craveiro

commit sha 2a5d8bc176be96a65467e603e9d6ffbd73912dd3

Re-work to use new flag on the installer. Updated laravel/installer to 3.5.1 #80

view details

Filipe Craveiro

commit sha 4b6ed858e62eeefc96b4d95b98abfe1719fe141c

Re-work to use new flag on the installer. Updated laravel/installer to 3.5.1 #80

view details

Matt Stauffer

commit sha df03adefbb0386c635a7fb2107fd1f89fa1b17f3

Merge pull request #81 from filkrav/authscaff Authscaff

view details

push time in 2 days

PR merged tightenco/lambo

Authscaff

Re-work to use new auth flag on the installer. Updated laravel/installer dependency to 3.5.1.

Did a basic test and apparently it's ok.

+319 -138

0 comment

3 changed files

filkrav

pr closed time in 2 days

delete branch tightenco/giscus

delete branch : dependabot/composer/symfony/http-foundation-4.4.1

delete time in 2 days

push eventtightenco/giscus

dependabot[bot]

commit sha 5226bce77fdf03eb92b9778ea965325004d10774

Bump symfony/http-foundation from 4.2.3 to 4.4.1 Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 4.2.3 to 4.4.1. - [Release notes](https://github.com/symfony/http-foundation/releases) - [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md) - [Commits](https://github.com/symfony/http-foundation/compare/v4.2.3...v4.4.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

Matt Stauffer

commit sha 697c100c211a56875c38ea2cbea514b014632105

Merge pull request #74 from tightenco/dependabot/composer/symfony/http-foundation-4.4.1 Bump symfony/http-foundation from 4.2.3 to 4.4.1

view details

push time in 2 days

PR merged tightenco/giscus

Bump symfony/http-foundation from 4.2.3 to 4.4.1 dependencies php

Bumps symfony/http-foundation from 4.2.3 to 4.4.1. <details> <summary>Changelog</summary>

Sourced from symfony/http-foundation's changelog.

CHANGELOG

5.0.0

  • made Cookie auto-secure and lax by default
  • removed classes in the MimeType namespace, use the Symfony Mime component instead
  • removed method UploadedFile::getClientSize() and the related constructor argument
  • made Request::getSession() throw if the session has not been set before
  • removed Response::HTTP_RESERVED_FOR_WEBDAV_ADVANCED_COLLECTIONS_EXPIRED_PROPOSAL
  • passing a null url when instantiating a RedirectResponse is not allowed

4.4.0

  • passing arguments to Request::isMethodSafe() is deprecated.
  • ApacheRequest is deprecated, use the Request class instead.
  • passing a third argument to HeaderBag::get() is deprecated, use method all() instead
  • [BC BREAK] PdoSessionHandler with MySQL changed the type of the lifetime column, make sure to run ALTER TABLE sessions MODIFY sess_lifetime INTEGER UNSIGNED NOT NULL to update your database.
  • PdoSessionHandler now precalculates the expiry timestamp in the lifetime column, make sure to run CREATE INDEX EXPIRY ON sessions (sess_lifetime) to update your database to speed up garbage collection of expired sessions.
  • added SessionHandlerFactory to create session handlers with a DSN
  • added IpUtils::anonymize() to help with GDPR compliance.

4.3.0

  • added PHPUnit constraints: RequestAttributeValueSame, ResponseCookieValueSame, ResponseHasCookie, ResponseHasHeader, ResponseHeaderSame, ResponseIsRedirected, ResponseIsSuccessful, and ResponseStatusCodeSame
  • deprecated MimeTypeGuesserInterface and ExtensionGuesserInterface in favor of Symfony\Component\Mime\MimeTypesInterface.
  • deprecated MimeType and MimeTypeExtensionGuesser in favor of Symfony\Component\Mime\MimeTypes.
  • deprecated FileBinaryMimeTypeGuesser in favor of Symfony\Component\Mime\FileBinaryMimeTypeGuesser.
  • deprecated FileinfoMimeTypeGuesser in favor of Symfony\Component\Mime\FileinfoMimeTypeGuesser.
  • added UrlHelper that allows to get an absolute URL and a relative path for a given path

4.2.0

  • the default value of the "$secure" and "$samesite" arguments of Cookie's constructor will respectively change from "false" to "null" and from "null" to "lax" in Symfony 5.0, you should define their values explicitly or use "Cookie::create()" instead.
  • added matchPort() in RequestMatcher

4.1.3

</tr></table> ... (truncated) </details> <details> <summary>Commits</summary>

  • 8bccc59 Merge branch '4.3' into 4.4
  • fcafc7c Merge branch '3.4' into 4.3
  • d2d0cfe [HttpFoundation] Fixed typo
  • cc09809 [HttpFoundation] Update CHANGELOG for PdoSessionHandler BC BREAK in 4.4
  • c2480b7 Merge branch '3.4' into 4.3
  • f7efd0b Simpler example for Apache basic auth workaround
  • 502040d Merge branch '4.3' into 4.4
  • 0ac9ebf Merge branch '3.4' into 4.3
  • a558b18 feature #34405 [HttpFoundation] Added possibility to configure expiration tim...
  • 0c5217a [HttpFoundation] Added possibility to configure expiration time in redis sess...
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+141 -16

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 days

push eventzuzana-kunckova/family-tree

Matt Stauffer

commit sha ba789e547af23653d7c96a99bc8926f441a9e829

Add some relationship seeds; pull relationships in people.show

view details

push time in 3 days

delete branch zuzana-kunckova/family-tree

delete branch : zk/neovis

delete time in 3 days

push eventzuzana-kunckova/family-tree

Zuzana K

commit sha 0b0adcad31932078bfac8ac21b9f4cef91d5cde5

create graph view, add neovis.js

view details

Matt Stauffer

commit sha f3503fb49db59c7ec3075dfaca05f24fb0127c4b

Remove the need for extra layout file

view details

Matt Stauffer

commit sha 223c391b5489e8758a70aa51abcb3a1c6e1635c7

Move NeoVis draw into Webpack-built app.js; adjust it to use env vars

view details

Matt Stauffer

commit sha 62b82dabf8c78ea62f18c669c66c9cd7306a677f

Only load neoviz script if viz div exists

view details

Matt Stauffer

commit sha 3a7cc077a98e5be40c334e68f3ac8af24d5b06f0

Re-work route definitions to use Route::view

view details

Matt Stauffer

commit sha 19f207e97c1e33a115eed1a9ae154eeb8a61058f

Merge pull request #1 from zuzana-kunckova/zk/neovis Create graph view; add neovis.js

view details

push time in 3 days

push eventzuzana-kunckova/family-tree

Matt Stauffer

commit sha 3a7cc077a98e5be40c334e68f3ac8af24d5b06f0

Re-work route definitions to use Route::view

view details

push time in 3 days

push eventzuzana-kunckova/family-tree

Matt Stauffer

commit sha f3503fb49db59c7ec3075dfaca05f24fb0127c4b

Remove the need for extra layout file

view details

Matt Stauffer

commit sha 223c391b5489e8758a70aa51abcb3a1c6e1635c7

Move NeoVis draw into Webpack-built app.js; adjust it to use env vars

view details

Matt Stauffer

commit sha 62b82dabf8c78ea62f18c669c66c9cd7306a677f

Only load neoviz script if viz div exists

view details

push time in 3 days

pull request commentlaravel/valet

Move PHP-FPM pool config to separate valet-specific file

@drbyte YES. Why not? If someone needs it, they're already in an advanced-enough situation that they can go look it up.

drbyte

comment created time in 3 days

pull request commentlaravel/valet

Move PHP-FPM pool config to separate valet-specific file

@drbyte I 100% agree with you on all points. I don't want the junk upgrade code but not sure what else to do. I prefer the nuclear option, and I love the idea of renaming it on new ones.

drbyte

comment created time in 3 days

pull request commentlaravel/valet

Move PHP-FPM pool config to separate valet-specific file

@drbyte I love this. Only question is, how should we handle restoring existing PHP 7+ installs' www.conf files?

drbyte

comment created time in 3 days

issue commenttightenco/onramp

If user has resource language preference set in a cookie, save it as a preference in the wizard store method

I'm confused now. I went through the registration process on both Onramp prod and my local env (currently mes/install-nova ). In both cases the Prefered Language dropdown is pre-populated according to the locale part of the URL slug.

Yep. But that's because of your URL slug, not because of anything saved to your user.

It adds in this additional user status (registered but not wizarded) that has to be handled in the user flow and tested. It seems, to me, to add some complexity.

Yep.. like I believe I've mentioned elsewhere, that was introduced when we added a wizard after users had already signed up, and can be solved by addressing this issue: https://github.com/tightenco/onramp/issues/137 , which is separate from the issue we're on right now.

But the Wizard has a language selector?! We should store the value from that.

Oh... that wasn't a part of the original plans. HA. So this whole thing isn't super enecessary anyway. Cool. Done.

mattstauffer

comment created time in 3 days

push eventtightenco/lambo

Matt Stauffer

commit sha 51585b64f6b97a8e41272da3ad841e11ff2cd3a1

Simplify MakeSpaces

view details

push time in 4 days

push eventtightenco/lambo

Matt Stauffer

commit sha 4178174399947395771319f3cd67b3426941f9b2

Simplify MakeSpaces

view details

push time in 4 days

push eventtightenco/lambo

Matt Stauffer

commit sha 07331a338335ad5c76bd27a7635204ce77520029

Move options definition into their own class

view details

push time in 4 days

pull request commentlaravel/valet

Set robots nofollow for all valet share traffic

OOh yah i like this way much better

drbyte

comment created time in 4 days

push eventlaravel/valet

Chris Brown

commit sha 36de050d328abe9c7ac8d0b1cbe836e0167dd163

Set robots nofollow for all valet share traffic Replaces and closes #575 ... for reasons described there.

view details

Matt Stauffer

commit sha 3d877ef803732f8e7388cea4beeb525703ce16cc

Merge pull request #855 from drbyte/patch-5 Set robots nofollow for all valet share traffic

view details

push time in 4 days

PR merged laravel/valet

Set robots nofollow for all valet share traffic

Replaces and closes #575 ... for reasons described there.

I've been using this for a couple months without issue. (Granted, I don't leave valet share running for extended periods.)

+2 -0

0 comment

1 changed file

drbyte

pr closed time in 4 days

PR closed laravel/valet

Hard-code Nginx to return robots.txt with disallow all

Not sure if others will find this useful or not but it helps me out as I tend to leave ngrok running for long periods of time and sometimes get hit by a webcrawler (or 2).

This will add location entries for /robots.txt to have it always return:

User-Agent: *
Disallow: /

without needing to remember to add a default robots.txt

+10 -0

2 comments

2 changed files

lazyguru

pr closed time in 4 days

push eventlaravel/valet

Chris Brown

commit sha cfa8c216fab2f0e0f26c53d9a529206d7c2ee83d

Include dnsmasq in valet start/restart command While it's rare that the dnsmasq won't be started, it feels incomplete to not include the service when starting/restarting valet, since valet depends on it.

view details

Matt Stauffer

commit sha 30b0684736678d3b60ead928ae494e5c8ee86a8a

Merge pull request #853 from drbyte/dnsmasq-restart Include dnsmasq in valet start/restart command

view details

push time in 4 days

PR merged laravel/valet

Include dnsmasq in valet start/restart command

While it's rare that the dnsmasq won't be started, it feels incomplete to not include the service when starting/restarting valet, since valet depends on it.

+9 -0

0 comment

2 changed files

drbyte

pr closed time in 4 days

push eventlaravel/valet

Matt Stauffer

commit sha 35a5f95abf54c9e68492b3fd9c61089ff19e36d8

Convert comma to semicolon

view details

push time in 4 days

pull request commentlaravel/valet

Display nginx config errors on start

You are the best

drbyte

comment created time in 4 days

push eventlaravel/valet

Chris Brown

commit sha e046fff6f6ac61e01db03192dd46d6da396024e0

Display nginx config errors on start While since #268 valet has been checking nginx configs for errors when starting/restarting, the captured errors are never displayed if there is a failure because it's being run using `quietly()`. This PR causes the errors to pass through to the console so we can more readily understand why nginx may not be starting or not serving properly.

view details

Matt Stauffer

commit sha f0a8fb9bb677a55a9c8d282a1e981e20265724c3

Merge pull request #852 from drbyte/patch-4 Display nginx config errors on start

view details

push time in 4 days

PR merged laravel/valet

Display nginx config errors on start

While since #268 valet has been checking nginx configs for errors when starting/restarting, the captured errors are never displayed if there is a failure because it's being run using quietly(). This PR causes the errors to pass through to the console so we can more readily understand why nginx may not be starting or not serving properly.

+1 -1

0 comment

1 changed file

drbyte

pr closed time in 4 days

push eventlaravel/valet

Chris Brown

commit sha b8cd17ed9803b301b50ea9f80913f0b664d16d6f

Drop unnecessary symfony/process 2.x support Since we require PHP > 5.6 there's no need to support symfony/process 2.x However, symfony/process 4.x requires minimum PHP 7.1 so have to retain 3.x for now if we wish to support PHP 7.0 or older without complications.

view details

Matt Stauffer

commit sha 9372003cd625ee76a95056fdca8ecf5f32ad1e9d

Merge pull request #850 from drbyte/patch-2 Drop unnecessary symfony/process 2.x support

view details

push time in 4 days

PR merged laravel/valet

Drop unnecessary symfony/process 2.x support

Since we require PHP > 5.6 there's no need to support symfony/process 2.x

However, symfony/process 4.x requires minimum PHP 7.1 so have to retain 3.x for now if we wish to support PHP 7.0 or older without complications.

As referenced in #845 comments.

+1 -1

0 comment

1 changed file

drbyte

pr closed time in 4 days

push eventlaravel/valet

Matt Stauffer

commit sha 0380987fdf20ced3134909e8f35925fd3087f876

Capitalize c in Composer

view details

push time in 4 days

push eventlaravel/valet

Chris Brown

commit sha e71906616c09c459eb3cfd1b7656d73beea77686

Add comment to consider running composer global update When switching to older PHP versions there may be a composer package dependency conflict. This PR adds a note to consider running `composer global update` to update those dependencies. It's only a comment since not all changes in PHP version will require running the update. Fixes #822

view details

Matt Stauffer

commit sha 454ed43f006af77ec6a6bfdda11e1540bf5cd447

Merge pull request #849 from drbyte/patch-1 Add comment to consider running composer global update after switching php version

view details

push time in 4 days

PR merged laravel/valet

Add comment to consider running composer global update after switching php version

When switching to older PHP versions there may be a composer package dependency conflict. This PR adds a note to consider running composer global update to update those dependencies. It's only a comment since not all changes in PHP version will require running the update.

Fixes #822

+1 -0

0 comment

1 changed file

drbyte

pr closed time in 4 days

issue closedlaravel/valet

Valet still support PHP 7.0?

Hi guys.

I tried switching to php 7.0 for an older project with valet use php@7.0. Added brew tap exolnet/deprecated for installing php 7.0. That works fine, but after all, valet cannot run anymore (for switching back):

PHP Parse error: syntax error, unexpected '=' in ~/.composer/vendor/illuminate/support/Arr.php on line 384

Parse error: syntax error, unexpected '=' in ~/.composer/vendor/illuminate/support/Arr.php on line 384

So, I believe that php 7.0 is not supported anymore? In that case, should we remove it in the SUPPORTED_PHP_VERSIONS array?

Thanks! Joey

closed time in 4 days

ReckeDJ

pull request commentlaravel/valet

Add detailed valet uninstall instructions

@drbye 👌

drbyte

comment created time in 4 days

push eventtightenco/lambo

Matt Stauffer

commit sha f137175b124ffb2ac659a33f0b140b1b3d4166b5

Tweak help display

view details

Matt Stauffer

commit sha 78b812e6ffd85552ec35c58be15ea05c190b9bfb

Tweak help screen, composer update

view details

push time in 4 days

push eventtightenco/lambo

Matt Stauffer

commit sha 498458ea61c11673c6410a6e2caf35235526110b

Tweak help display

view details

push time in 4 days

pull request commentlaravel/valet

Add --all parameter to valet unsecure command

Love it

drbyte

comment created time in 4 days

push eventlaravel/valet

Chris Brown

commit sha d6f06045fc7c237b0c47d91bc523563fa7dae784

Add --all parameter to valet unsecure command This PR allows passing `--all` to `valet unsecure` to have it remove all certificates from all Valet configs AND from the MacOS Keychain. This effectively cleans up certificate fragments or broken configs, and can help with troubleshooting.

view details

Matt Stauffer

commit sha 068143721948823c39b6a9eae6ca77063289a14b

Merge pull request #854 from drbyte/valet-unsecure-all Add --all parameter to valet unsecure command

view details

push time in 4 days

PR merged laravel/valet

Add --all parameter to valet unsecure command

This PR allows passing --all to valet unsecure to have it remove all certificates from all Valet configs AND from the MacOS Keychain. This effectively cleans up certificate fragments or broken configs, and can help with troubleshooting.

+38 -1

0 comment

2 changed files

drbyte

pr closed time in 4 days

push eventtightenco/lambo

Matt Stauffer

commit sha edb9bb87b5622f1204ebc26ba88beb4ec13e7344

Clean up code

view details

push time in 4 days

push eventtightenco/lambo

Matt Stauffer

commit sha 67822a4eadf858a82a4849e16a728555e73423a8

Start building out help text

view details

Matt Stauffer

commit sha f8e21edd4caf495be81a9cdadab2e547e388a204

Fix up help screen

view details

push time in 4 days

push eventlaravel/valet

Chris Brown

commit sha 65b0c6aae6c7702c1546936949e9fbe375317d43

Add detailed uninstall instructions Previously `valet uninstall` would just shutdown the `nginx` service. This PR also stops `PHP` and gives a number of instructions on how to do a (nearly) clean uninstall of most Valet dependencies. And also some troubleshooting tips.

view details

Matt Stauffer

commit sha 93d1632b375c02eb979166a9ffca39b5a9ec0dd9

Merge pull request #851 from drbyte/patch-3 Add detailed valet uninstall instructions

view details

push time in 4 days

PR merged laravel/valet

Add detailed valet uninstall instructions

Previously valet uninstall would just shutdown the nginx service.

This PR also stops PHP and gives a bunch of instructions on how to do a (nearly) clean uninstall of most Valet dependencies. And also some troubleshooting tips.

+39 -2

0 comment

1 changed file

drbyte

pr closed time in 4 days

pull request commentlaravel/valet

Do not show sites in parked if they would not be served

Thanks @jrbarnard and thanks as always @drbyte for reviewing!

jrbarnard

comment created time in 4 days

push eventlaravel/valet

James Barnard

commit sha afedf5be577d0490553fb0d690f06ef5c3874913

Do not show sites in parked if they would not be served (parked after a site with the same name, or an existing linked site)

view details

Matt Stauffer

commit sha 8eea03f6a2d52fff804a4a9abeb203fc412e83df

Merge pull request #835 from jrbarnard/bugfix/parked-merge-overwrite Do not show sites in parked if they would not be served

view details

push time in 4 days

PR merged laravel/valet

Do not show sites in parked if they would not be served

Another issue I saw, this with duplicate site names. Currently a linked site takes precedence over a parked site so it shouldn't be shown under 'parked' as it will never be served. This also fixes an issue if you have multiple parked directories, the later parked ones would overwrite the previous if they share a site name, I've reversed this.

+9 -2

1 comment

1 changed file

jrbarnard

pr closed time in 4 days

push eventtightenco/lambo

Matt Stauffer

commit sha 753e7558bc8c8dfb4e3e0a7767610953066f744e

Fix tld-finding with mac/linux-only hack Co-Authored-By: ijpatricio <ijpatricio@users.noreply.github.com>

view details

push time in 4 days

pull request commentlaravel/valet

Fix misnamed test

❤️

drbyte

comment created time in 4 days

push eventlaravel/valet

Chris Brown

commit sha 949e5d58e302c643bbe041a7c2647fb1db5c181d

Update NginxTest.php Fix misnamed test

view details

Matt Stauffer

commit sha 30d168b2b89871611205b6da7250c5a8f36c2ef0

Merge pull request #859 from drbyte/patch-7 Fix misnamed test

view details

push time in 4 days

PR merged laravel/valet

Fix misnamed test

Fix misnamed test

+1 -1

0 comment

1 changed file

drbyte

pr closed time in 4 days

push eventtightenco/lambo

Matt Stauffer

commit sha 4237929aefb0937e97973189c6e2e9e3c668ad6f

Open in browser, valet secure, display Lambo logo, prep help screen action Co-Authored-By: ijpatricio <ijpatricio@users.noreply.github.com>

view details

push time in 5 days

push eventtightenco/lambo

Matt Stauffer

commit sha dedcc4461f0c080c80dd91e78906eb33ba3eb21c

Use Shell

view details

push time in 5 days

push eventtightenco/lambo

Matt Stauffer

commit sha 5ec1be26c57d3d09f83960fc837d070d002c1b37

Generate app key; init git repo; cp .env.example changes to .env Co-Authored-By: ijpatricio <ijpatricio@users.noreply.github.com>

view details

push time in 5 days

push eventtightenco/lambo

Matt Stauffer

commit sha 497c7b66f81917c78c3b11732632e0fd4da545f7

Open editor, npm install, start customize dotenv Re-written from scratch with inspiration from @ijpatricio Co-Authored-By: ijpatricio <ijpatricio@users.noreply.github.com>

view details

Matt Stauffer

commit sha bf42efad4c574bbf0dc51249b08bc340bd38d673

Finish customize dot env action Co-Authored-By: ijpatricio <ijpatricio@users.noreply.github.com>

view details

push time in 5 days

created taglaravel/valet

tagv2.5.4

created time in 5 days

release laravel/valet

v2.5.4

released time in 5 days

push eventlaravel/valet

Matt Stauffer

commit sha fb562977f061335e64c0298abcdd6ead3a9c4c0a

Fix 7.7 typo in brew test

view details

push time in 5 days

push eventlaravel/valet

Matt Stauffer

commit sha 7785fc870ed7278e52373141dff8fe5e08e05d69

Bump version

view details

push time in 5 days

push eventlaravel/valet

Chris Brown

commit sha d80d599ba59ce2be6891ecd3c9b3cdf36af34692

Allow support for symfony/process 5.0

view details

Matt Stauffer

commit sha fa8c8ae6e2b308943c68d4a197bce7f6a47f78c6

Merge pull request #845 from drbyte/patch-2 Allow support for symfony/process 5.0

view details

push time in 5 days

PR merged laravel/valet

Allow support for symfony/process 5.0

For compatibility with current symfony release updates

+1 -1

0 comment

1 changed file

drbyte

pr closed time in 5 days

push eventlaravel/valet

lee

commit sha bfd2f3ea5dcd6d487cf5c1636b1b3cf9b7b81c8d

Updated SUPPORTED_PHP_VERSIONS and LATEST_PHP_VERSION constants to 7.4

view details

lee

commit sha b2faf6cc5ae5ee50728462cc643e790e2579a472

added assertions to fix test

view details

lee

commit sha b0fa39c21bff377187148801ffb72945ca2bbd79

removed 7.4 from 'allowed failures' list in travis.yml

view details

Matt Stauffer

commit sha 0c0d26c92088df0c5e79f7ed4b3781dcf09f2b10

Merge pull request #847 from ravenberg/master PHP 7.4 support

view details

push time in 5 days

PR merged laravel/valet

PHP 7.4 support

I added php@7.4 in the SUPPORTED_PHP_VERSIONS and LATEST_PHP_VERSION constants to allow for php 7.4 support, as discussed in issue https://github.com/laravel/valet/issues/846. So we can all enjoy the new version with Valet. 🎉

+11 -6

4 comments

3 changed files

ravenberg

pr closed time in 5 days

push eventtightenco/lambo

Matt Stauffer

commit sha 212af3777fec95f3758ee58b6b7a3ea905762bfe

Leave a bunch of to-do's and prep for help screen

view details

push time in 6 days

push eventtightenco/lambo

Matt Stauffer

commit sha 7deddae552a78da1b49b31cb5cfc5332cdd9b531

Add Laravel isntaller

view details

push time in 6 days

push eventtightenco/lambo

Matt Stauffer

commit sha 4c236986109eb9345c813a7435865a4eb3fe9633

Create basic new command with executable verification

view details

push time in 8 days

create barnchtightenco/lambo

branch : mes/lambo-zero

created branch time in 9 days

PR closed tightenco/lambo

Lampho branch - Php version on Laravel-Zero - Initial, progressive upgrade to 5.8

hey @andrewmile

So I was able to start the porting, and left out the recurring runtime option config change in a starting point.

All the rest is working, and left a file, ROADMAP.md that you should go about, left many thought and indications there!

Im at 12% now, will use the rest to scaffold a little more, the interactive options, and if all is found agreed, just small tweaks and tests missing.

Can't wait to hear your thoughts!

+5803 -840

14 comments

56 changed files

ijpatricio

pr closed time in 9 days

pull request commenttightenco/lambo

Lampho branch - Php version on Laravel-Zero - Initial, progressive upgrade to 5.8

So.... this has grown out of control. I say this with love and care but it's so heavy I just can't get a handle on it.

I'm going to start a brand-new install from scratch. I'm going to build it out simply, bit by bit, and I welcome pull requests into it--even if the PRs are direct copies from this branch. I would love that! But I need to get this back to a place where I have a handle on it.

Sorry if this feels like any time was wasted. I hope not!

ijpatricio

comment created time in 9 days

issue commenttightenco/onramp

When a user changes the language in the dropdown, also change it in their user preferences

I think we definitely want the cookie.

So, let's talk about the costs if we remove the user preference:

  • We can't consider language in emails
  • We can't log them automatically into their preferred language once they log in (assuming someone would ever log in through the UI in not-their-preferred-language, which seems a bit unlikely but it's possible)
  • If we generate links in emails, they wont' be linked to the correct language; they'll have to follow the link to the /en/whatever/link URL, then that will set the cookie as english, then they'll have to change the translation as well

So the biggest one is emails. Thoughts?

mattstauffer

comment created time in 10 days

push eventzuzana-kunckova/family-tree

Matt Stauffer

commit sha ab8046542998b95acf112b72decf1ebede0d6824

Start building out People CRUD and pairing them with lookups to both databases

view details

push time in 10 days

more