profile
viewpoint

jspahrsummers/library-oriented-programming 57

Talk about the how/why of separating concerns into libraries

mattjgalloway/ios-library-with-resources 45

Sample project showing how to ship resources with a static library for iOS.

emoncms/emoncms-ios 12

iOS app for Emoncms

mattjgalloway/auto-itc-auto-ingest 8

Python script which wraps iTunes Connect auto-ingest tool.

mattjgalloway/CocoaBugs 7

Bugs found in Apple's Cocoa / Cocoa Touch frameworks

mattjgalloway/homebridge-tivo 4

Homebridge plugin for TiVo

mattjgalloway/calendar 3

Calendar API for iPhone

mattjgalloway/GrowingTextView 3

An UITextView which grows/shrinks with the text and starts scrolling when the content reaches a certain number of lines. Similar to the one Apple uses in the SMS-app. See blog-post for a small screencast.

mattjgalloway/cgtcalc 1

A UK capital gains tax calculator written in Swift

push eventmattjgalloway/emoncms

Matt Galloway

commit sha 1def4718f2a992068bb72b0083b93514b73c4b3d

Add feed endpoint for fetching feed list with added values for start of day, month, year

view details

Matt Galloway

commit sha 33f115a8a256e202407779733c0ed269bb11fda8

Add option to 'fetch' and 'value' to get the value for feed(s) at a certain time

view details

push time in 7 days

push eventmattjgalloway/emoncms-app

Emrys

commit sha 96b43b670bc983972917c25d23b6808f675edbba

altered the validation regex to allow for all currency characters

view details

Glyn Hudson

commit sha 0692abeb1b187e9fcb80c1613c0b68f37e2f8245

tweak currency wording

view details

Andy Madge

commit sha 82fc5df5e9e429f5b3ae2b4a8c0c9526bb3a1649

Added Bulb Energy standard and smart tariffs (https://bulb.co.uk/)

view details

Andy Madge

commit sha cdf1aa3affff38d69198a5ab5aa359aa8451b1ae

Added EDF standard tariff

view details

Glyn Hudson

commit sha 4e95b9a922c224d4654f6f1008605f42d884b1af

Merge pull request #61 from andymadge/master Added Bulb and EDF tariffs to Cost Comparison app

view details

Trystan Lea

commit sha aab5548286efde2713871d3941afdc034e3aa372

Merge pull request #55 from emrysr/feature/issue-52-currency-symbol-validation altered the validation regex to allow for all currency characters

view details

Matt Galloway

commit sha 67ee22c46354610b7282a5b62484570638bfc805

Fix errors when internet is disconnected / flakey If the internet is disconnected, flakey or something just goes wrong, then apps show an error (see #60). This fixes it by returning `null` from the list APIs and then catching that case and just returning from the update function. Fixes #60.

view details

Matt Galloway

commit sha 55abdfef0d8843cb65910d1a747525c81acdc8c9

Fix not working when feed is <24 hours old This fixes the long-standing bug where MyElectric and MyElectric2 don't work properly if the feed you use for kwh values is <24 hours old. It simply adds in the relevant data for today midnight and tomorrow midnight to make the calculations work. Fixes #15.

view details

Emrys

commit sha 753c645942523d4df3178e17ecaac15fb0623827

added blank tooltip used plothover event to position and fill the tooltip commented out console messages added tooltip css

view details

Trystan Lea

commit sha 9bad3f9a458fac21d274fa84b00559923af1f9f7

Merge pull request #66 from emrysr/feature/issue-63-tooltip-value-mysolarpv added blank tooltip

view details

TrystanLea

commit sha 684a0653856a59dd963e33500725ec939fecc909

fix unit to watts

view details

TrystanLea

commit sha 4a0da5cdd5f9c2f2c66dab7a0c1105155002284f

remove unit for now - balance is in kWh, power graph in watts

view details

Emrys

commit sha a77e9ce12b54bf73c80c75a53520450157132036

used "use" when "use_kwhd" not available

view details

Emrys

commit sha 2b10d5e9f2c63eedb6aec38a7ad08cc2e9a8e16b

added W for running total view

view details

Trystan Lea

commit sha a367a6e158ff3474fb63b25794c003147f2141dc

Merge pull request #67 from emrysr/fix/issue-62-myelectric2-tooltip-error used "use" when "use_kwhd" not available

view details

Trystan Lea

commit sha 67d97b9e4a9fd6467b9eb0c4b0b9d3fdbccb5cad

Merge pull request #65 from mattjgalloway/fix_issue_15 Fix not working when feed is <24 hours old

view details

Trystan Lea

commit sha 1a60d20301361dc30afa0ec834adad46da9a99fd

Merge pull request #64 from mattjgalloway/fix_issue_60 Fix errors when internet is disconnected / flakey

view details

Emrys

commit sha 425a0f2939430d3c30c860c9f3c34e3c7984cb7b

loaded sidebar into new 'global' sidebar hidden existing sidebar

view details

Trystan Lea

commit sha a94d903d7ccece4c427036313c6ba9a1a119a601

Update module.json

view details

Trystan Lea

commit sha 8edcc3041df0525710f082e44875b1699732b6d3

Merge pull request #68 from emoncms/master V1.2.1

view details

push time in 7 days

push eventmattjgalloway/emoncms-app

Glyn Hudson

commit sha 9502ebd269356369e3e6e920ec6e9de8b18b8c2a

Merge pull request #50 from emoncms/master Stable merge v1.1.1

view details

Glyn Hudson

commit sha 3fbdf0709d7f4d427da7c5531987db50db16d79b

Merge pull request #57 from emoncms/master stable merge V1.2.0

view details

Matt Galloway

commit sha 67ee22c46354610b7282a5b62484570638bfc805

Fix errors when internet is disconnected / flakey If the internet is disconnected, flakey or something just goes wrong, then apps show an error (see #60). This fixes it by returning `null` from the list APIs and then catching that case and just returning from the update function. Fixes #60.

view details

Matt Galloway

commit sha 55abdfef0d8843cb65910d1a747525c81acdc8c9

Fix not working when feed is <24 hours old This fixes the long-standing bug where MyElectric and MyElectric2 don't work properly if the feed you use for kwh values is <24 hours old. It simply adds in the relevant data for today midnight and tomorrow midnight to make the calculations work. Fixes #15.

view details

Emrys

commit sha 753c645942523d4df3178e17ecaac15fb0623827

added blank tooltip used plothover event to position and fill the tooltip commented out console messages added tooltip css

view details

Trystan Lea

commit sha 9bad3f9a458fac21d274fa84b00559923af1f9f7

Merge pull request #66 from emrysr/feature/issue-63-tooltip-value-mysolarpv added blank tooltip

view details

TrystanLea

commit sha 684a0653856a59dd963e33500725ec939fecc909

fix unit to watts

view details

TrystanLea

commit sha 4a0da5cdd5f9c2f2c66dab7a0c1105155002284f

remove unit for now - balance is in kWh, power graph in watts

view details

Emrys

commit sha a77e9ce12b54bf73c80c75a53520450157132036

used "use" when "use_kwhd" not available

view details

Emrys

commit sha 2b10d5e9f2c63eedb6aec38a7ad08cc2e9a8e16b

added W for running total view

view details

Trystan Lea

commit sha a367a6e158ff3474fb63b25794c003147f2141dc

Merge pull request #67 from emrysr/fix/issue-62-myelectric2-tooltip-error used "use" when "use_kwhd" not available

view details

Trystan Lea

commit sha 67d97b9e4a9fd6467b9eb0c4b0b9d3fdbccb5cad

Merge pull request #65 from mattjgalloway/fix_issue_15 Fix not working when feed is <24 hours old

view details

Trystan Lea

commit sha 1a60d20301361dc30afa0ec834adad46da9a99fd

Merge pull request #64 from mattjgalloway/fix_issue_60 Fix errors when internet is disconnected / flakey

view details

Emrys

commit sha 425a0f2939430d3c30c860c9f3c34e3c7984cb7b

loaded sidebar into new 'global' sidebar hidden existing sidebar

view details

Trystan Lea

commit sha a94d903d7ccece4c427036313c6ba9a1a119a601

Update module.json

view details

Trystan Lea

commit sha 8edcc3041df0525710f082e44875b1699732b6d3

Merge pull request #68 from emoncms/master V1.2.1

view details

Emrys

commit sha 0ff7f69e2ea3bde3e1423ad2b8e9d3698e8cc071

added app names to new sidebar

view details

Emrys

commit sha 43ee8f63b90629f856229a7c6dd8f673796e417d

re-ordered the menu file to allow sidebar and tabs to be accociated decoded app name in controller before searching db for match

view details

Emrys

commit sha 914f13657dcd9e5caf3adb510455e1cae5071b55

Merge branch 'master' of github.com:emoncms/app into dark-sidebar

view details

Steve R

commit sha c9d2bbe6e9a0c00fb306793eeb2a322a7159e15a

mysolarpv.php number format USE and SOLAR at low power

view details

push time in 7 days

push eventmattjgalloway/emoncms-dashboard

Emrys

commit sha 33d4fd01d362eac43461694f445a4e7a96de85be

renamed english locale folder to en_GB

view details

Emrys

commit sha b39557f52e69c8069bb046ee0f1e546d256c96cc

Merge branch 'master' of github.com:emoncms/dashboard

view details

Emrys

commit sha e6630ead38834a2fe6bcd2e91f0e7e9db475de8d

Merge branch 'master' of github.com:emoncms/dashboard

view details

Emrys

commit sha d733ec97587686c3a37a6ccbec2afb98d08ee399

Merge branch 'master' of github.com:emoncms/dashboard

view details

Glyn Hudson

commit sha c1ae9f6225972c606b72d3328c9e7e8912562ce0

Install php7.0-mbstring fix #172

view details

Paul

commit sha 01bdf6bd457936ff0b597c6e5f431b9e48541abd

Widget and French lang updates (#179) * French Localization update 01 11 2018 (#174) * Update messages.po * Add files via upload * Update dashboard_langjs.php * improvement of bar widget (#175) add customized error message. fix bug when input has been updated with the same value. before fix, error message was displayed * dial improvement (#176) Add customized error message Fix bug when input is updated with the same value Before the fix, error message was displayed now the needle is not displayed when timeout is reached * feedvalue improvement (#177) Add customized error message * thermometer improvement (#178) Add customized error message Fix bug when input is updated with the same value Before the fix, error message was displayed now the height of mercury for the value is not displayed when timeout is reached

view details

Aymeric THIBAUT

commit sha 617af6e3572bfe300f6d2995b72dfe86a3bfc76d

Js redundancy (#180) * deletion of bar_widget.php * deletion of dial_widget.php * deletion of feedtime_widget.php * deletion of feedvalue_widget.php * deletion of isactivefeed_widget.php * Add javascript

view details

TrystanLea

commit sha 87372ef8ca899ff9cd37aba1babda0caa1aeb3bf

fix button widget

view details

TrystanLea

commit sha ed1db54a06c179466bd2c34698fbb76e35b2568b

fix thresholds widget, check for undefined feed

view details

Emrys

commit sha 5509858eaa0859bb45ada08d688acb26372f7ab1

Merge branch 'master' of github.com:emoncms/dashboard

view details

Emrys

commit sha 337b291324b1c70c460b978c2966fba2ecfae442

loaded common units form Lib created combobox that loads common units added other for custom units

view details

Emrys

commit sha 48065ff36b2f61e0546d41422f855f228f965947

remember 'other' value when switching

view details

Emrys

commit sha 3d5c463acec5a75ab41a1680aedf9bf22c32053b

fix automated test fail

view details

Emrys

commit sha dabd3109e25acf177baa2fd7ed6a68bf4c035ad6

moved code to central include dashboard.js

view details

Emrys

commit sha b3107ed919090ff9cf1434d009181cf83351864c

added unit dropdown to other widget added empty <option> as first

view details

Emrys

commit sha 56f3af8c5295aaf520d197a67ddbfa23ad1c271a

updated dial widget updated feedtime widget updated sun widget updated themometer widget

view details

Matt Galloway

commit sha 013c0de93cb4d15ae131d522d7b27feb863a48cd

Only require read key for listing dashboards in the JSON API

view details

Paul

commit sha 83c2164cec53e8bf91c3092707a81b4c57351d58

Merge pull request #184 from mattjgalloway/list_with_readkey Only require read key for listing dashboards in the JSON API

view details

Trystan Lea

commit sha e7cca124659435d7844b6ed998bcf7f273a1618a

Merge pull request #182 from emrysr/feature/testing-generic-units Feature/testing generic units

view details

TrystanLea

commit sha 9f39f4ebdcdd153dd43bfb84c35c2a63a517f289

fix api access permissions

view details

push time in 7 days

push eventmattjgalloway/emoncms-dashboard

Emrys

commit sha 33d4fd01d362eac43461694f445a4e7a96de85be

renamed english locale folder to en_GB

view details

Emrys

commit sha b39557f52e69c8069bb046ee0f1e546d256c96cc

Merge branch 'master' of github.com:emoncms/dashboard

view details

Emrys

commit sha e6630ead38834a2fe6bcd2e91f0e7e9db475de8d

Merge branch 'master' of github.com:emoncms/dashboard

view details

Emrys

commit sha d733ec97587686c3a37a6ccbec2afb98d08ee399

Merge branch 'master' of github.com:emoncms/dashboard

view details

Glyn Hudson

commit sha c1ae9f6225972c606b72d3328c9e7e8912562ce0

Install php7.0-mbstring fix #172

view details

Paul

commit sha 01bdf6bd457936ff0b597c6e5f431b9e48541abd

Widget and French lang updates (#179) * French Localization update 01 11 2018 (#174) * Update messages.po * Add files via upload * Update dashboard_langjs.php * improvement of bar widget (#175) add customized error message. fix bug when input has been updated with the same value. before fix, error message was displayed * dial improvement (#176) Add customized error message Fix bug when input is updated with the same value Before the fix, error message was displayed now the needle is not displayed when timeout is reached * feedvalue improvement (#177) Add customized error message * thermometer improvement (#178) Add customized error message Fix bug when input is updated with the same value Before the fix, error message was displayed now the height of mercury for the value is not displayed when timeout is reached

view details

Aymeric THIBAUT

commit sha 617af6e3572bfe300f6d2995b72dfe86a3bfc76d

Js redundancy (#180) * deletion of bar_widget.php * deletion of dial_widget.php * deletion of feedtime_widget.php * deletion of feedvalue_widget.php * deletion of isactivefeed_widget.php * Add javascript

view details

TrystanLea

commit sha 87372ef8ca899ff9cd37aba1babda0caa1aeb3bf

fix button widget

view details

TrystanLea

commit sha ed1db54a06c179466bd2c34698fbb76e35b2568b

fix thresholds widget, check for undefined feed

view details

Emrys

commit sha 5509858eaa0859bb45ada08d688acb26372f7ab1

Merge branch 'master' of github.com:emoncms/dashboard

view details

Emrys

commit sha 337b291324b1c70c460b978c2966fba2ecfae442

loaded common units form Lib created combobox that loads common units added other for custom units

view details

Emrys

commit sha 48065ff36b2f61e0546d41422f855f228f965947

remember 'other' value when switching

view details

Emrys

commit sha 3d5c463acec5a75ab41a1680aedf9bf22c32053b

fix automated test fail

view details

Emrys

commit sha dabd3109e25acf177baa2fd7ed6a68bf4c035ad6

moved code to central include dashboard.js

view details

Emrys

commit sha b3107ed919090ff9cf1434d009181cf83351864c

added unit dropdown to other widget added empty <option> as first

view details

Emrys

commit sha 56f3af8c5295aaf520d197a67ddbfa23ad1c271a

updated dial widget updated feedtime widget updated sun widget updated themometer widget

view details

Matt Galloway

commit sha 013c0de93cb4d15ae131d522d7b27feb863a48cd

Only require read key for listing dashboards in the JSON API

view details

Paul

commit sha 83c2164cec53e8bf91c3092707a81b4c57351d58

Merge pull request #184 from mattjgalloway/list_with_readkey Only require read key for listing dashboards in the JSON API

view details

Trystan Lea

commit sha e7cca124659435d7844b6ed998bcf7f273a1618a

Merge pull request #182 from emrysr/feature/testing-generic-units Feature/testing generic units

view details

TrystanLea

commit sha 9f39f4ebdcdd153dd43bfb84c35c2a63a517f289

fix api access permissions

view details

push time in 7 days

push eventmattjgalloway/emoncms-dashboard

Emrys

commit sha 33d4fd01d362eac43461694f445a4e7a96de85be

renamed english locale folder to en_GB

view details

Emrys

commit sha b39557f52e69c8069bb046ee0f1e546d256c96cc

Merge branch 'master' of github.com:emoncms/dashboard

view details

Emrys

commit sha e6630ead38834a2fe6bcd2e91f0e7e9db475de8d

Merge branch 'master' of github.com:emoncms/dashboard

view details

Glyn Hudson

commit sha 9b03e57143fc586685f844a840dbfd15d4bca9ad

Merge pull request #173 from emoncms/master stable merge 1.3.1

view details

Emrys

commit sha d733ec97587686c3a37a6ccbec2afb98d08ee399

Merge branch 'master' of github.com:emoncms/dashboard

view details

TrystanLea

commit sha 87372ef8ca899ff9cd37aba1babda0caa1aeb3bf

fix button widget

view details

TrystanLea

commit sha ed1db54a06c179466bd2c34698fbb76e35b2568b

fix thresholds widget, check for undefined feed

view details

Emrys

commit sha 5509858eaa0859bb45ada08d688acb26372f7ab1

Merge branch 'master' of github.com:emoncms/dashboard

view details

Emrys

commit sha 337b291324b1c70c460b978c2966fba2ecfae442

loaded common units form Lib created combobox that loads common units added other for custom units

view details

Emrys

commit sha 48065ff36b2f61e0546d41422f855f228f965947

remember 'other' value when switching

view details

Emrys

commit sha 3d5c463acec5a75ab41a1680aedf9bf22c32053b

fix automated test fail

view details

Emrys

commit sha dabd3109e25acf177baa2fd7ed6a68bf4c035ad6

moved code to central include dashboard.js

view details

Emrys

commit sha b3107ed919090ff9cf1434d009181cf83351864c

added unit dropdown to other widget added empty <option> as first

view details

Emrys

commit sha 56f3af8c5295aaf520d197a67ddbfa23ad1c271a

updated dial widget updated feedtime widget updated sun widget updated themometer widget

view details

Matt Galloway

commit sha 013c0de93cb4d15ae131d522d7b27feb863a48cd

Only require read key for listing dashboards in the JSON API

view details

Paul

commit sha 83c2164cec53e8bf91c3092707a81b4c57351d58

Merge pull request #184 from mattjgalloway/list_with_readkey Only require read key for listing dashboards in the JSON API

view details

Trystan Lea

commit sha e7cca124659435d7844b6ed998bcf7f273a1618a

Merge pull request #182 from emrysr/feature/testing-generic-units Feature/testing generic units

view details

TrystanLea

commit sha 9f39f4ebdcdd153dd43bfb84c35c2a63a517f289

fix api access permissions

view details

Glyn Hudson

commit sha 0838e33aaccfe61b34289990f0283bf9ad8e485e

bump verson V1.3.2

view details

Glyn Hudson

commit sha a19acf5cf13a96aee95d82e736b87f9b26edb905

Merge pull request #187 from emoncms/master V1.3.2 Stable Dashboard merge

view details

push time in 7 days

push eventmattjgalloway/emoncms

Emrys

commit sha 2c5005893cd16acbd1754a1e02b65d8f9be4bef7

fixed window resize issue

view details

Emrys

commit sha d052fcde4bf914007aa893e4b9abd3ba4f224f06

exit from convertToPlotlist() when no feeds selected

view details

Emrys

commit sha 2de73b56ef3d53aa9073dc1aa1dd6acaad3499dd

used the same connection error as emoncms

view details

Trystan Lea

commit sha b8d65f5b1402a76ce92e0c92dc44304cf9c280e2

Merge pull request #1173 from emrysr/feature/issue-1112-feed-tag-input moved autocomplete input to own js and css

view details

Trystan Lea

commit sha db3f5bd66cf1054b96a7306d5dee182f0c7dbb7c

Merge pull request #1174 from emrysr/feature/issue-1123-full-height-graph fixed height issue

view details

Trystan Lea

commit sha 6ef6ba388e3b155502873a38d99fc9c2c368e516

Merge pull request #1175 from emrysr/feature/issue-1126-no-feed-selected exit from convertToPlotlist() when no feeds selected

view details

Trystan Lea

commit sha a0a3b95aaf3f690d0b219c8e4252d0cb7fd77d2e

Merge pull request #1172 from emrysr/feature/issue-1056-virtual-feed-distorting-group-totals not testing against virtual feeds (feed.engine==7)

view details

Trystan Lea

commit sha 73a5426fa81acc49f9ffa809ad79e333f35b81ac

Merge pull request #1176 from emrysr/feature/issue-1124-phpmqtt_input-mysql-connection-error used the same connection error as emoncms

view details

Trystan Lea

commit sha d29dd9721b2f7af10b6c33a7c606d2ff0dc4354e

Merge pull request #1169 from borpin/patch-1 Make explicit what the button is copying

view details

TrystanLea

commit sha fc4a4d11ca77e3efc7f7df9ee857cc01f07ebb2a

allow read access to read api end points

view details

TrystanLea

commit sha c206e219be7b4e57d8210dcc1e6bf7a0e89689fb

disable use of virtual feed as source for itself

view details

borpin

commit sha ca832c2a47757df31b97ffac9f39eb59fe38d2db

Update process_settings.php Include a process setting for client_id.

view details

borpin

commit sha bddc3726cd2cea87f82bbd516fd1cf9372e1adaf

Restore setting and add to documentation Following discussions, restored the `User=pi` and `restart=always` settings. Added documentation to provide instructions on how to change the user in a non-disruptive manner. Please add note to release notes.

view details

borpin

commit sha 410d8754cdf84547a096be631130ddfa28aae288

Update mqtt_input.service Noticed that mqtt_input service called `redis.service` in error. Corrected to `redis-server.service`

view details

borpin

commit sha a2ddaacb5debc7c95e0bf5a89b30fccbf82ddb57

Update service-runner.service Update restart comment

view details

Emrys

commit sha 5de2b71dee35693f51aaafa07a77ebc357ad467a

restored missing feedwriter information

view details

Emrys

commit sha 853858efb80adb1519e54fb48617d7ecf578391c

added custom message for feedrunner service

view details

Emrys

commit sha 2774874e41c986ae3043c355777632d23b21e048

checked for rpi-rw script to identify older version

view details

Emrys

commit sha 2365684d7cbbed0f10c158de862f92d358f7b961

showing feed interval status with colour bars

view details

Emrys

commit sha 1afcb7842c7dc31bee21aaf68b0a6a1f7f09146a

added border below accordion header

view details

push time in 7 days

push eventmattjgalloway/emoncms

Emrys

commit sha 9ee7566544f76d1e5f312902585fa5bb14e985d7

moved autocomplete input to own js and css added autocomplete to processlist "new feed"

view details

Emrys

commit sha 656117fc2c89187e620bdca2b10ddd84f9de11e8

fixed height issue

view details

Emrys

commit sha 2c5005893cd16acbd1754a1e02b65d8f9be4bef7

fixed window resize issue

view details

Emrys

commit sha d052fcde4bf914007aa893e4b9abd3ba4f224f06

exit from convertToPlotlist() when no feeds selected

view details

Emrys

commit sha 2de73b56ef3d53aa9073dc1aa1dd6acaad3499dd

used the same connection error as emoncms

view details

Trystan Lea

commit sha b8d65f5b1402a76ce92e0c92dc44304cf9c280e2

Merge pull request #1173 from emrysr/feature/issue-1112-feed-tag-input moved autocomplete input to own js and css

view details

Trystan Lea

commit sha db3f5bd66cf1054b96a7306d5dee182f0c7dbb7c

Merge pull request #1174 from emrysr/feature/issue-1123-full-height-graph fixed height issue

view details

Trystan Lea

commit sha 6ef6ba388e3b155502873a38d99fc9c2c368e516

Merge pull request #1175 from emrysr/feature/issue-1126-no-feed-selected exit from convertToPlotlist() when no feeds selected

view details

Trystan Lea

commit sha a0a3b95aaf3f690d0b219c8e4252d0cb7fd77d2e

Merge pull request #1172 from emrysr/feature/issue-1056-virtual-feed-distorting-group-totals not testing against virtual feeds (feed.engine==7)

view details

Trystan Lea

commit sha 73a5426fa81acc49f9ffa809ad79e333f35b81ac

Merge pull request #1176 from emrysr/feature/issue-1124-phpmqtt_input-mysql-connection-error used the same connection error as emoncms

view details

Trystan Lea

commit sha d29dd9721b2f7af10b6c33a7c606d2ff0dc4354e

Merge pull request #1169 from borpin/patch-1 Make explicit what the button is copying

view details

TrystanLea

commit sha fc4a4d11ca77e3efc7f7df9ee857cc01f07ebb2a

allow read access to read api end points

view details

TrystanLea

commit sha c206e219be7b4e57d8210dcc1e6bf7a0e89689fb

disable use of virtual feed as source for itself

view details

borpin

commit sha ca832c2a47757df31b97ffac9f39eb59fe38d2db

Update process_settings.php Include a process setting for client_id.

view details

borpin

commit sha bddc3726cd2cea87f82bbd516fd1cf9372e1adaf

Restore setting and add to documentation Following discussions, restored the `User=pi` and `restart=always` settings. Added documentation to provide instructions on how to change the user in a non-disruptive manner. Please add note to release notes.

view details

borpin

commit sha 410d8754cdf84547a096be631130ddfa28aae288

Update mqtt_input.service Noticed that mqtt_input service called `redis.service` in error. Corrected to `redis-server.service`

view details

borpin

commit sha a2ddaacb5debc7c95e0bf5a89b30fccbf82ddb57

Update service-runner.service Update restart comment

view details

Emrys

commit sha 5de2b71dee35693f51aaafa07a77ebc357ad467a

restored missing feedwriter information

view details

Emrys

commit sha 853858efb80adb1519e54fb48617d7ecf578391c

added custom message for feedrunner service

view details

Emrys

commit sha 2774874e41c986ae3043c355777632d23b21e048

checked for rpi-rw script to identify older version

view details

push time in 7 days

push eventmattjgalloway/emoncms

Trystan Lea

commit sha 691fd051fa4398876c45128e35136999085478b3

Merge pull request #1179 from emrysr/feature/issue-1129-admin-filesystem-status checked for rpi-rw script to identify older version

view details

Trystan Lea

commit sha a5f843a54d00ac8e051a181f2a4d50745181eba6

Merge pull request #1177 from emrysr/feature/issue-1150-service-statuses Feature/issue 1150 service statuses

view details

Trystan Lea

commit sha 47ae5ee360abf5693ba0e32d6cfa632bf29a75ff

Merge branch 'stable' into master

view details

TrystanLea

commit sha 184d7b3f5838af741680458ada5d4b35a1b11961

check for defined keys in menu

view details

Trystan Lea

commit sha 7ac8d28b55dc6c66ecffc9e4d60bc23b149a2506

Update version.txt

view details

TrystanLea

commit sha fa344f4907d1e5ed0e7ad5a3521f90a7e457300e

use typof to check for undefined

view details

TrystanLea

commit sha f819fe9682231829f67ca8c8eaa42aae263f6714

Merge branch 'master' of https://github.com/emoncms/emoncms

view details

TrystanLea

commit sha b36266d40cb68c8f2f6759779c98859c4f27f116

number of feeds per user in admin user list

view details

trystanlea

commit sha ebdb02933cc843f3300dbe763bec2750574d7a12

fix servicectl and service errors if not present

view details

Gabriele Lauricella

commit sha 4fddcd675b9513d0b48d641ee3c751b5d02bd0b2

Update with new pi models

view details

Emrys

commit sha b631bf4abd41b2ce57db129256d5b10dee204f66

separated locale file loading from feed list view

view details

Emrys

commit sha f848e6a416bb67a7ecddadf5e73c80b420edc483

added callback _locale_loaded()

view details

Emrys

commit sha 6644471635312a1319b1a72b17b62f6bab630484

escaping quotes from translation text

view details

trystanlea

commit sha 5b9bdd210537bef8ac638ebcf04eaffa1e805f9f

fix sidebar resize

view details

Emrys

commit sha fac6d3a2f2aec60481d7d3e0ed0cc86c16c2fa27

Merge branch 'master' of github.com:emoncms/emoncms

view details

Emrys

commit sha 33de5d43fdf209c3464d8b01ed37c26c8f88b1ec

fixed invalid character added error message to be shown

view details

Emrys

commit sha 35202828c15c3acffefad8e97977c2770e9c5dd3

added css rules added js functions to ouput css class names in input list

view details

Trystan Lea

commit sha 75495cc2f433f63b39bd7ccced8d12a464f030cb

Merge pull request #1192 from emrysr/feature/issue-1185-input-list-colour-bars Feature/issue 1185 input list colour bars

view details

Trystan Lea

commit sha afa8bdbc0d17fa5ef02b86479b85a66b5c55b03a

Merge pull request #1191 from emrysr/feature/issue-1188-feed-edit-rejected-characters Feature/issue 1188 feed edit rejected characters

view details

Trystan Lea

commit sha 75097145b75ece7090abd9ab08f8530e65ea3fa2

Merge pull request #1187 from emrysr/feature/locale-loading-in-separate-file Feature/locale loading in separate file

view details

push time in 7 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha f6fb46c494d1d878f744699940e1463f0cb318ab

Add another test that uses the capital return and dividend logic

view details

push time in 14 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 88f9364bd2b458530eaa57ec6592ca758664a44c

Updated readme

view details

push time in 15 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 2eaaa8fdaeec21ac52e5dcf0b2c5b61f3b939459

Add parsing of splits and unsplits

view details

Matt Galloway

commit sha f8a0dc8beb724f8cdfa0ace4c181fb183f0a423c

Move all the matching logic inside MatchingProcessor

view details

Matt Galloway

commit sha e7df1f4f76c19114c962deee280bd96173d99e06

Support splits and unsplits

view details

Matt Galloway

commit sha 596fad4c52598d3a2cae1ac030577c51e7aa1bab

Add more tests around splits/unsplits

view details

push time in 15 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 604c81529f585d0d2c82bec97526749a22202c39

Add parsing of splits and unsplits

view details

push time in 15 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 564fbe69d006a1d94cbf7a1b857fb4581297f80c

Add hashable tests

view details

push time in 15 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 953fff638138d10bef013e8cda2ee9e8accd6832

Add equality tests

view details

push time in 15 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 243dbe220d5b53beac9466a92f9020cbf77a6067

Updated linux tests manifest

view details

push time in 15 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 17bf5840cbf03931c803b321b5fc3c316e491ab2

Allow grouping of transactions

view details

Matt Galloway

commit sha 40307af2b71ebe35888c2c6121aed8e6bbacf9b1

Remove IDs from transactions and asset events

view details

Matt Galloway

commit sha ae07adef54dfd1448e1d741c5727b4ef908cff51

Group same day transactions of same kind

view details

Matt Galloway

commit sha 0dd804c48d0e5bbd4cd1f3a71f1afca5d63231b3

Updated readme

view details

push time in 15 days

push eventmattjgalloway/fpl_get_team_info-userscript

Matt Galloway

commit sha 3b6c4b0a73b3a2a2cd8204f8f3cc47ca5faa568d

Remove duplicate code

view details

Matt Galloway

commit sha 2d434d7b2148cfa9ff52ce8c4f78749bac6aa3c6

Support bench boost for live score

view details

Matt Galloway

commit sha 473e3bc983efa4e213f522759c9ca3726a11999b

Bump version

view details

push time in 15 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha dc3a3d96eb7bb062bb81e1fd62f0a980be60d4a6

Rename SubTransaction to TransactionToMatch

view details

Matt Galloway

commit sha 8498e139e047020cafd7afad4b0c94cb9570fae7

Re-run linux test manifest generation

view details

Matt Galloway

commit sha 4733d1215310d7f1912ca8a46862f3fe92d8a893

Add another test

view details

push time in 16 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha efb4a9887aa301f8b7746b4b9e87deacea04864e

Updated readme

view details

push time in 17 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha ab9e869134b7f4b2fd3346d8b5e06ed1fa01eb53

Updated readme

view details

push time in 20 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha b2bc051560ff6ae5825fe028147a829bbd238669

Only find txt files in the example tests directory

view details

push time in 20 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 3fef5fd1cac9e7c8d1a149e7bef5785143b95e4d

Add test that uses offset for funds

view details

push time in 20 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 93aa596894b5a957aae49b72e495d9019b89c941

Don't show offsets if they're not needed

view details

push time in 20 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha f95b46313a5fc40d0f0f99c04e40721519bfc8b2

Updated readme to add what's supported and what's not supported

view details

push time in 20 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 576743740005b79531b6e21ff5c19c1bc937639b

Updated readme

view details

push time in 21 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 4cfb141987cdb07dd3ebdfb839fab743b65236d3

Show NONE for transactions if there are none

view details

push time in 22 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 220f1678efce83c1cc00d31b972b0dc39c872f9f

Supply CGTCalcCore as a library

view details

push time in 22 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha a856af54fd177e892bb069a4f67db9db70ff8d7f

Updated readme

view details

push time in 22 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha c61a06ef586f13757c5adf5fdcdabf360c3d95fc

Oh fine - force unwrap is ok here

view details

push time in 22 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha ecedde79974f0f50f6c499c942f373cba223f886

Add some more calculator tests

view details

push time in 22 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha aa7e2767b5d6311fffbc33553e1cab13e3853d60

Add some more calculator tests

view details

push time in 22 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha ef57e32fd320e915eef2d09e0e2396cf791747c8

Round values only after collecting all matches for a disposal

view details

push time in 22 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 2ba812fc4348cea77b438fcd29f83647e1361eea

Add Linux tests on Travis

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 409531ea41c3725923d68e70a95ede37fe57cc67

Add all tests on Linux

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 91d2d39267c5f1cbfeb5ab5d85c0fa4f65e02f40

Get some tests running on Linux

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 507f6d8d56bcbd2d29f8f4ea7fc1e19b424dd36c

Make logger work on Linux too

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 3996f2a1a9e6b83a9b65d9aeafa635ce6dd7d9cc

Updated readme

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha c81da0f05e131815ecfa20e21023942a60c3f66f

Updated readme

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha c2baecc636611a872ae74feced1795a6f207e4e9

Updated readme

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha ed769a89896696d874f398bd514289f67ac5202e

Updated readme

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 75da912ae0603c1b80b7b5643db0ef226edd065a

Updated readme

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha a25d154b1bea41b27bc38525d2959f93ddce4bcb

Updated readme

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha abeefcf387a6ac939c13c698a2a3ebff90ee8c21

Tweak output to remove excess newlines

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 99cbb7b77c6b7e59ab09b665e23fcc9bfd24c7fb

Updated readme

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 0970697030fa715ace25c5ae0d2ff967fb93f202

Updated readme

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha b3de03cdcd9bd2a26c84f46b50ea8547b126dd4f

Remove redundant calculation of gain

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 072c534defa6e82de868896879cefdf94dd4d83d

Use logger to print failures

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 3b11d2bc80846b66e0ba0b09510d4a88693dc141

Updated readme

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha bb0ea3d1bda64b0f3c65c866cd2bfbfa4596e751

Remove SampleData and have that just in the tests themselves

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha d573f70b80f05402942572d5c72bbfb599aaeb0c

Add asset events to calculator tests

view details

Matt Galloway

commit sha a475e3764142f4e3472450483ce36e48c8206f11

Add test for invalid input with asset event but no acquisitions

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 9bfb26fe167cbb3bbf93a12dbe2e04a69ef41e7d

Add more tests for DefaultParser

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha e4628cdc4fac4800c16d7e5dce050dc52db5ea38

Make output of transaction list better

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha dd93a62c55a3e9d663c1a85d7c1308f5c7fae805

Remove double ££

view details

Matt Galloway

commit sha e6f3e3c23571646a203b244d44c49ff575b6e2c9

Add test that exercises asset events

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 0bdcd7fa888db3a082cd7111f118eca78548a34c

Split offset when splitting a SubTransaction

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 20bb6326acf4825f486e55b54e824799cf254a20

Refactor how SubTransaction handles prices

view details

Matt Galloway

commit sha 48a4c7e383db95ca70d0db72a55ff52949a1e38f

Add more SubTransaction tests

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 035b0b7776c13ba7dfb12a32113d376d13872a0f

Move asset event processing to a pre-processor stage

view details

Matt Galloway

commit sha 4a2c14c6586fe6af218c688df2b7e49ca5df5c83

Tweak output format

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 00bd4aa8fb975aa9c9fae8f63ef25532925fd5de

Make fileprivate

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 039efebc4ae82d87fdc84185cf8bdc3f41e0f984

Change section 104 adjuster to be specific dividend and capital return types

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha b9bbc46802ba4e5488d9115d9bcac482a1d66aab

Move section 104 adjusters to a new kind of object

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 145357e6c8e61c7663d48d9c88f36382c8807790

Add version

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 9fb5b7bacec5af94a729c60bee449a20a946c875

Reset parser for each test

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha a741ebc99fbf5918b040af79e0c80ae1b1d82c23

Add carry forward of losses

view details

push time in 23 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 17bc655688f493ab70c199b43e4aa54419456e5d

Error if there's a transaction before 6th April 2008 as it's not supported

view details

Matt Galloway

commit sha 41d51a98054cee61e293a3020accb543f15f9cc5

Change output format to have a nice table for the tax year summary

view details

push time in 24 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha e835ddd1b55359db126801bd3e987a6ee19c60f7

Fix rounding when it's a loss

view details

Matt Galloway

commit sha 08b7c90b4a7080fc6c66440df4a91963a42c1bcb

Tweak output to make it a bit more readable

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 875e420f6b3691613c0347e4865705512031b214

Add transactions to the bottom of output

view details

Matt Galloway

commit sha b305eed59821d52c17154d46a62145a25210c53a

Fix splitting of sub-transactions

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 732220e53d655b3b7d3f104d14b007babef01b55

Fix B&B matcher

view details

Matt Galloway

commit sha e4d18f6406d3a5577638af00e45644c6058e803f

Add a test that tests each part of the processor pipeline

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha c2e00f59065eba099527c863e97f57d8cf282c9e

Print logging to stderr

view details

Matt Galloway

commit sha bcdad0a150a7bb785a831af07c8eb5a738b7e9db

Allow redirecting output to a file

view details

Matt Galloway

commit sha 603e3f76cf553400ba12a2d783500dfa9c377b41

Set name for help to be correct as cgtcalc

view details

Matt Galloway

commit sha 6bc8b9ce982be86ba271a41db300e64bcde46f65

Add another test

view details

Matt Galloway

commit sha bdd79dfd8c10c17cf09cfecf42100c7ddb751cf5

Remove stamp duty - bundled into expenses now

view details

Matt Galloway

commit sha 1e79adb4c5cd4015894221547cb58e91aad025eb

Add tests for object descriptions

view details

Matt Galloway

commit sha ac1ba168cbb356d3557ad5e715846e3cdc9b2b5b

Make matching processor a little simpler

view details

Matt Galloway

commit sha 9718a4c5e60944ba22349461352a396104bfe7e1

Add matching processor tests

view details

Matt Galloway

commit sha cdd4a6f18711136c28ed46cee59cadacd12983d1

Add more default parser tests

view details

Matt Galloway

commit sha f48fe0c7042d2a251a21296aa1a3bbcf69ba11a9

Add text presenter tests

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 23e35d97df51f2cad065ee5758c1afd1c6249ea3

Fix problem where section 104 processor is popping when it hasn't consumed acquisitions

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 6db806257394fd8a429c7ebbf41f52ec23d7312b

Stabilise the order of disposals in the output

view details

Matt Galloway

commit sha 32c6d293884c850baf996de2306d813db748de10

Fix test output now that the disposals are ordered

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha ed170b9eb731473b3dcf86fa8a9e4f8badc3fcb3

Allow comments in input files

view details

Matt Galloway

commit sha 315fb4d1072745f0912aa27cc2ae811104c7a9ad

Tweak output format for matches

view details

Matt Galloway

commit sha 7a46ce17c69c17c456ba78ca9ecf0036f47f850b

Add a test that proves an example from HMRC website

view details

Matt Galloway

commit sha beb6f7a7b363dca9989a374743730e08097edb25

Ignore Logger.swift from codecov

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha a45dacbe750de155d9d3f4cae539ebc3991bfd2e

Make codecov.io work

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 190bfc6596bf903940aae5e26881053021bbba3a

Add CI and code coverage badges

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha c8ddffb3f736fea76121df263925a9e1b841d2f7

Add Travis config

view details

Matt Galloway

commit sha 975a8d8073aec460423c5b1ac9c7c8eaa5f7cc51

Add code coverage collection

view details

push time in 25 days

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 0bda40bde12449733a15693992dfee49fbdec09a

Add tests that exercise the E2E flow

view details

push time in 25 days

PublicEvent

push eventmattjgalloway/cgtcalc

Matt Galloway

commit sha 49349a940ac6aed8b6934d15ee43bd9b29d7e443

First rough draft

view details

push time in 25 days

delete branch mattjgalloway/muFunds

delete branch : patch-1

delete time in a month

push eventmattjgalloway/ha-config

Matt Galloway

commit sha 225d087c40f551a681d47af841d5d96919bb921d

Remove Plex

view details

Matt Galloway

commit sha 99a6b5294c9baf412d1b85c8cb91bc12bddbe098

Turn back on MQTT

view details

Matt Galloway

commit sha 8a0868c401fc3b21c0b413bb83fc0943481bca82

Remove old known_devices.yaml file

view details

Matt Galloway

commit sha 8de4de9c8d5394c190fae76b797966bb6f2f800f

New 2nice switches

view details

Matt Galloway

commit sha 7305de194eb389e539f6d22f08e1dd664910f578

Need this back now we're using sonoff switches

view details

Matt Galloway

commit sha 165951f36b0d103bc80678aa0e600744bfcacfb9

Add person integration

view details

Matt Galloway

commit sha b28ec09cdd9b1b5ea61939caee5500ccb6ba5b17

Hide the sync sonoff automation

view details

Matt Galloway

commit sha 66db28fd1134ac28d7d04d68480d6ddf819170de

More updating to make things saner since the switch to the new iOS module

view details

push time in 2 months

PR opened electron-userland/electron-builder

Log the raw version string when AppUpdater fails to parse semver of latest version

When the app updater fails because the version string can't be parsed, we are putting latestVersion into the logs, which we know is null. That's not too helpful, but putting the raw string from updateInfo.version is helpful because you might be able to see what's gone wrong with parsing it.

+2 -2

0 comment

1 changed file

pr created time in 2 months

push eventmattjgalloway/electron-builder

Matt Galloway

commit sha f2cd38e1fb3cb324492b19d64ff126d5c554ec20

Log the raw version string When the app updater fails because the version string can't be parsed, we are putting `latestVersion` into the logs, which we know is `null`. That's not too helpful, but putting the raw string from `updateInfo.version` is helpful because you might be able to see what's gone wrong with parsing it.

view details

push time in 2 months

fork mattjgalloway/electron-builder

A complete solution to package and build a ready for distribution Electron app with “auto update” support out of the box

https://www.electron.build

fork in 2 months

issue commentgoogle/sanitizers

ASan on Windows failure to link when using `std::regex`

This is not the right way of linking a program with ASan.

I’m pretty sure this is the way to link on Windows. There is no “-fsanitize=address” for linking with lld-link.exe.

I have a test binary which compiles and links just fine with ASan and shows an error I introduce. So I’m pretty sure this is how to compile and link.

I’ve realised my second problem in the comment fwiw. It’s because there’s no storage declared for seq. And that’s fine when compiling normally because the compiler uses the constexpr and does all the optimisation so that we don’t need storage. But under ASan it makes sense we emit code that means we need storage for it.

But the first problem with regex still stands. I’m guessing the problem here is similar and maybe Microsoft haven’t provided storage for that variable in its dynamic C++ runtime.

mattjgalloway

comment created time in 2 months

issue commentgoogle/sanitizers

ASan on Windows failure to link when using `std::regex`

And here's another test case of another strange link failure only when using Asan:

struct Foo {
  static constexpr auto seq = std::integer_sequence<int>();
};
void bar() {
  (void)Foo::seq.size();
}
int main(int argc, char** argv) {}

I end up with:

lld-link: error: undefined symbol: public: static struct std::integer_sequence<int> const Foo::seq
>>> referenced by broken_asan.obj:(__unnamed_1)
mattjgalloway

comment created time in 2 months

issue openedgoogle/sanitizers

ASan on Windows failure to link when using `std::regex`

I'm having a real hard time trying to understand why my app is failing to link when compiling everything with -fsanitize=address, so I've made a simple example and I can repro the problem.

I'm on Windows here, using clang-cl in LLVM 9.0.1.

Here's the minimal test case:

> cat broken_asan.cpp
#include <regex>
void foo() {
  std::regex pattern(R"(.*foo.*)");
}
int main(int argc, char** argv) {}

Then I compile and link like this:

> C:\toolchain\LLVM9.0.1\bin\clang-cl.exe /c /MD -Xclang -fsanitize=address .\broken_asan.cpp /Fobroken_asan.obj
> C:\toolchain\LLVM9.0.1\bin\lld-link.exe broken_asan.obj /LIBPATH:C:\tools\toolchains\LLVM9.0.1\lib\clang\9.0.1\lib\windows clang_rt.asan_dynamic-x86_64.lib clang_rt.asan_dynamic_runtime_thunk-x86_64.lib

And I get the following link error:

lld-link: error: undefined symbol: public: static class std::locale::id std::collate<char>::id
>>> referenced by broken_asan.obj:(__unnamed_1)

Some things:

  • If I remove the usage of std::regex then the link error goes away. Which makes sense because the std::locale usage is coming from std::regex.
  • This only happens when I'm using /MD and not /MT. But for my app, I need to use /MD.
  • If I compile without -Xclang -fsanitize=address then it also links just fine.

Can anyone shed any light on this? I'm a bit stumped right now.

created time in 2 months

more