profile
viewpoint
Mathias Bynens mathiasbynens @Google https://mathiasbynens.be/ Web standards fanatic. JavaScript, HTML, CSS, HTTP, performance, security, Bash, Unicode, macOS.

domchristie/turndown 5014

🛏 An HTML to Markdown converter written in JavaScript

kangax/html-minifier 4255

Javascript-based HTML compressor/minifier (with Node.js support)

addyosmani/puppeteer-webperf 1255

Automating Web Performance testing with Puppeteer 🎪

GoogleChromeLabs/jsvu 1066

JavaScript (engine) Version Updater

GoogleChromeLabs/jsbi 600

JSBI is a pure-JavaScript implementation of the official ECMAScript BigInt proposal.

bramus/mixed-content-scan 507

Scan your HTTPS-enabled website for Mixed Content

googlesamples/web-fundamentals 289

Google Web Fundamentals

konklone/shaaaaaaaaaaaaa 206

Check if a website has weak SHA-1 TLS certificates.

gf3/WAT 102

LOLWAT?

GoogleChromeLabs/json-parse-benchmark 79

Benchmark comparing JSON.parse vs. equivalent JavaScript literals across JavaScript engines.

push eventv8/api

V8 API docs updater

commit sha 0ff14fc5b36663dbdabc8aa0e00306950e3be5bf

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 2 days

push eventv8/api

V8 API docs updater

commit sha 4f25e62c4428d0e7b37db183500460e5cf770e22

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 2 days

issue openeduwplse/herbie

Web demo is down

http://herbie.uwplse.org/demo/ currently returns an HTTP 502 status code.

created time in 3 days

push eventv8/api

V8 API docs updater

commit sha 18d5f99f6641e0f36bc23293c26b9fb96dd69ef6

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 3 days

push eventv8/api

V8 API docs updater

commit sha b20cabd2f806fc21001ffd9414519e89e8332285

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 3 days

startedSFTtech/openage

started time in 4 days

startedOpenRCT2/OpenRCT2

started time in 4 days

push eventv8/api

V8 API docs updater

commit sha a9a0b18732c877e7185a3b55ecdaaab7a134acd7

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 4 days

push eventv8/api

V8 API docs updater

commit sha eadf70ca4d8a1ffef243e45dbfdcdc642ae85f38

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 4 days

Pull request review commentGoogleChrome/web.dev

Add manual build trigger and updated scheduled build cron to be hourly.

-name: Continuous integration+name: Deploy on:-  push:-    branches:-      - master+  # Adds a 'Run Workflow' button to the GitHub Actions UI so the team can+  # manually deploy the site.+  workflow_dispatch:+  +  # Automatically build and deploy the site hourly,+  # between the hours of 5am and 5pm

My gut feeling would be to start with hourly deploys Mon-Fri, and then seeing what happens. It should be an extremely rare event that a successful build (needed to trigger a deployment) results in the site being down, so I wouldn't optimize for it unless this actually occurs. Just my $0.02, it's totally your call!

Re: my original suggestion, making the deploy hourly 24 times a day would be more inclusive, timezone-wise.

robdodson

comment created time in 4 days

push eventpuppeteer/puppeteer

Johan Bay

commit sha 8e29b7a38d7192bd52595d2d93ed7b61d90f39c8

chore: rename serializeTree parameter (#6308)

view details

push time in 4 days

delete branch puppeteer/puppeteer

delete branch : rewording

delete time in 4 days

PR merged puppeteer/puppeteer

chore: rewording cla: yes
+3 -3

0 comment

1 changed file

johanbay

pr closed time in 4 days

MemberEvent

Pull request review commentGoogleChrome/web.dev

[Idle Detection article] Add DevTools support

 controller.abort(); console.log('IdleDetector is stopped.'); ``` +### DevTools support++You can emulate idle events in the Chrome DevTools, no need to actually idle around.

Worth mentioning that this is Chrome 86+?

tomayac

comment created time in 5 days

Pull request review commentGoogleChrome/web.dev

[Idle Detection article] Add DevTools support

 and let us know where and how you're using it. ## Acknowledgements  The Idle Detection API was implemented by [Sam Goto](https://twitter.com/samuelgoto).+DevTools support was added by [Maksim Sadym](https://www.linkedin.com/in/sadym/).

@maximgrafin PTAL

tomayac

comment created time in 5 days

Pull request review commenttc39/ecma262

Normative: move __proto__ out of annex b

 <h1>Object.prototype.valueOf ( )</h1>         </emu-alg>         <p>This function is the <dfn>%ObjProto_valueOf%</dfn> intrinsic object.</p>       </emu-clause>++      <emu-clause id="sec-object.prototype.__proto__" normative-optional>+        <h1>Object.prototype.__proto__</h1>+        <p>`Object.prototype.__proto__` is an accessor property with attributes { [[Enumerable]]: *false*, [[Configurable]]: *true* }. The [[Get]] and [[Set]] attributes are defined as follows:</p>++        <emu-clause id="sec-get-object.prototype.__proto__">+          <h1>get Object.prototype.__proto__</h1>+          <p>The value of the [[Get]] attribute is a built-in function that requires no arguments. It performs the following steps when called:</p>+          <emu-alg>+            1. Let _O_ be ? ToObject(*this* value).+            1. Return ? _O_.[[GetPrototypeOf]]().+          </emu-alg>+        </emu-clause>++        <emu-clause id="sec-set-object.prototype.__proto__">+          <h1>set Object.prototype.__proto__</h1>+          <p>The value of the [[Set]] attribute is a built-in function that takes an argument _proto_. It performs the following steps when called:</p>+          <emu-alg>+            1. Let _O_ be ? RequireObjectCoercible(*this* value).+            1. If Type(_proto_) is neither Object nor Null, return *undefined*.+            1. If Type(_O_) is not Object, return *undefined*.+            1. Let _status_ be ? _O_.[[SetPrototypeOf]](_proto_).+            1. If _status_ is *false*, throw a *TypeError* exception.+            1. Return *undefined*.+          </emu-alg>+        </emu-clause>+      </emu-clause>++      <emu-clause id="sec-object.prototype.__defineGetter__">

@ljharb I know the history of __proto__. The point I was making is that there's parts of the JavaScript standard that we now, in hindsight, consider to be mistakes (even outside of Annex B). Whether they were intentionally designed or organically became part of the standard after first becoming a de facto standard doesn't matter. It feels weird to special-case features just because they used to be in Annex B.

devsnek

comment created time in 5 days

created tagGoogleChromeLabs/jsvu

tagv1.11.3

JavaScript (engine) Version Updater

created time in 5 days

push eventGoogleChromeLabs/jsvu

Mathias Bynens

commit sha edff361f53ce79b6affda4fd7ce67a12664f8530

Release v1.11.3

view details

push time in 5 days

push eventGoogleChromeLabs/jsvu

Mathias Bynens

commit sha 4cda2cd78bdb66dc03e5414f7023624fd28eaddf

Support hermes@0.6.0 and up The Hermes team changed the structure of their published tarballs. This patch updates jsvu accordingly. Closes #96.

view details

push time in 5 days

issue closedGoogleChromeLabs/jsvu

hermes@0.6.0 broke jsvu

Looks like the Hermes team changed something about the way they publish new releases, causing jsvu to break:

$ jsvu hermes@0.6.0
📦 jsvu v1.11.2 — the JavaScript engine Version Updater 📦
✔ Read OS from config: mac64
✔ Read engine + version from CLI argument: hermes v0.6.0
✔ Found specific Hermes version: v0.6.0.
✔ URL: https://github.com/facebook/hermes/releases/download/v0.6.0/hermes-cli-darwin-v0.6.0.tar.gz
✔ Download completed.
❯ Extracting…
Installing binary to ~/.jsvu/engines/hermes-0.6.0/hermes-0.6.0…
Installing symlink at ~/.jsvu/hermes-0.6.0 pointing to ~/.jsvu/engines/hermes-0.6.0/hermes-0.6.0…
Installing binary to ~/.jsvu/engines/hermes-0.6.0/hermes-0.6.0-repl…
(node:28368) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, stat '/private/var/folders/zn/5lwc_xx93_34xxmqcc3y2xsc00fj2f/T/b79e840c97640ef031205c9bd8abfc2f/hermes-repl'
    at Object.statSync (fs.js:1009:3)
    at Object.statSync (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/node_modules/graceful-fs/polyfills.js:307:34)
    at getStatsSync (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/node_modules/fs-extra/lib/util/stat.js:58:18)
    at Object.checkPathsSync (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/node_modules/fs-extra/lib/util/stat.js:90:33)
    at Object.moveSync (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/node_modules/fs-extra/lib/move-sync/move-sync.js:14:28)
    at installSingleBinary (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/shared/installer.js:30:6)
    at Installer.installBinary (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/shared/installer.js:75:5)
    at /Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/engines/hermes/extract.js:37:15
(node:28368) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:28368) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

closed time in 5 days

mathiasbynens

issue commentGoogleChromeLabs/jsvu

hermes@0.6.0 broke jsvu

Previous versions of hermes had hermes-repl for the REPL and hermes for the compiler. (https://github.com/facebook/hermes/issues/17#issuecomment-510850808)

Starting with v0.6.0, it looks like the REPL is now called hermes, and the compiler is now hermesc.

mathiasbynens

comment created time in 5 days

issue openedGoogleChromeLabs/jsvu

hermes@0.6.0 broke jsvu

Looks like the Hermes team changed something about the way they publish new releases, causing jsvu to break:

$ jsvu hermes@0.6.0
📦 jsvu v1.11.2 — the JavaScript engine Version Updater 📦
✔ Read OS from config: mac64
✔ Read engine + version from CLI argument: hermes v0.6.0
✔ Found specific Hermes version: v0.6.0.
✔ URL: https://github.com/facebook/hermes/releases/download/v0.6.0/hermes-cli-darwin-v0.6.0.tar.gz
✔ Download completed.
❯ Extracting…
Installing binary to ~/.jsvu/engines/hermes-0.6.0/hermes-0.6.0…
Installing symlink at ~/.jsvu/hermes-0.6.0 pointing to ~/.jsvu/engines/hermes-0.6.0/hermes-0.6.0…
Installing binary to ~/.jsvu/engines/hermes-0.6.0/hermes-0.6.0-repl…
(node:28368) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, stat '/private/var/folders/zn/5lwc_xx93_34xxmqcc3y2xsc00fj2f/T/b79e840c97640ef031205c9bd8abfc2f/hermes-repl'
    at Object.statSync (fs.js:1009:3)
    at Object.statSync (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/node_modules/graceful-fs/polyfills.js:307:34)
    at getStatsSync (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/node_modules/fs-extra/lib/util/stat.js:58:18)
    at Object.checkPathsSync (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/node_modules/fs-extra/lib/util/stat.js:90:33)
    at Object.moveSync (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/node_modules/fs-extra/lib/move-sync/move-sync.js:14:28)
    at installSingleBinary (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/shared/installer.js:30:6)
    at Installer.installBinary (/Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/shared/installer.js:75:5)
    at /Users/mathiasb/.nvm/versions/node/v12.17.0/lib/node_modules/jsvu/engines/hermes/extract.js:37:15
(node:28368) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:28368) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

created time in 5 days

Pull request review commenttc39/ecma262

Normative: move __proto__ out of annex b

 <h1>Object.prototype.valueOf ( )</h1>         </emu-alg>         <p>This function is the <dfn>%ObjProto_valueOf%</dfn> intrinsic object.</p>       </emu-clause>++      <emu-clause id="sec-object.prototype.__proto__" normative-optional>+        <h1>Object.prototype.__proto__</h1>+        <p>`Object.prototype.__proto__` is an accessor property with attributes { [[Enumerable]]: *false*, [[Configurable]]: *true* }. The [[Get]] and [[Set]] attributes are defined as follows:</p>++        <emu-clause id="sec-get-object.prototype.__proto__">+          <h1>get Object.prototype.__proto__</h1>+          <p>The value of the [[Get]] attribute is a built-in function that requires no arguments. It performs the following steps when called:</p>+          <emu-alg>+            1. Let _O_ be ? ToObject(*this* value).+            1. Return ? _O_.[[GetPrototypeOf]]().+          </emu-alg>+        </emu-clause>++        <emu-clause id="sec-set-object.prototype.__proto__">+          <h1>set Object.prototype.__proto__</h1>+          <p>The value of the [[Set]] attribute is a built-in function that takes an argument _proto_. It performs the following steps when called:</p>+          <emu-alg>+            1. Let _O_ be ? RequireObjectCoercible(*this* value).+            1. If Type(_proto_) is neither Object nor Null, return *undefined*.+            1. If Type(_O_) is not Object, return *undefined*.+            1. Let _status_ be ? _O_.[[SetPrototypeOf]](_proto_).+            1. If _status_ is *false*, throw a *TypeError* exception.+            1. Return *undefined*.+          </emu-alg>+        </emu-clause>+      </emu-clause>++      <emu-clause id="sec-object.prototype.__defineGetter__">

How is __proto__ different from, say, with, or Symbol.species?

devsnek

comment created time in 5 days

Pull request review commentGoogleChrome/web.dev

Add manual build trigger and updated scheduled build cron to be hourly.

-name: Continuous integration+name: Deploy on:-  push:-    branches:-      - master+  # Adds a 'Run Workflow' button to the GitHub Actions UI so the team can+  # manually deploy the site.+  workflow_dispatch:+  +  # Automatically build and deploy the site hourly,+  # between the hours of 5am and 5pm

Why only during these hours? web.dev contributors are spread across all kinds of timezones. Let's just deploy once per hour?

robdodson

comment created time in 5 days

Pull request review commenttc39/ecma262

Normative: move __proto__ out of annex b

 <h1>Object.prototype.valueOf ( )</h1>         </emu-alg>         <p>This function is the <dfn>%ObjProto_valueOf%</dfn> intrinsic object.</p>       </emu-clause>++      <emu-clause id="sec-object.prototype.__proto__" normative-optional>+        <h1>Object.prototype.__proto__</h1>+        <p>`Object.prototype.__proto__` is an accessor property with attributes { [[Enumerable]]: *false*, [[Configurable]]: *true* }. The [[Get]] and [[Set]] attributes are defined as follows:</p>++        <emu-clause id="sec-get-object.prototype.__proto__">+          <h1>get Object.prototype.__proto__</h1>+          <p>The value of the [[Get]] attribute is a built-in function that requires no arguments. It performs the following steps when called:</p>+          <emu-alg>+            1. Let _O_ be ? ToObject(*this* value).+            1. Return ? _O_.[[GetPrototypeOf]]().+          </emu-alg>+        </emu-clause>++        <emu-clause id="sec-set-object.prototype.__proto__">+          <h1>set Object.prototype.__proto__</h1>+          <p>The value of the [[Set]] attribute is a built-in function that takes an argument _proto_. It performs the following steps when called:</p>+          <emu-alg>+            1. Let _O_ be ? RequireObjectCoercible(*this* value).+            1. If Type(_proto_) is neither Object nor Null, return *undefined*.+            1. If Type(_O_) is not Object, return *undefined*.+            1. Let _status_ be ? _O_.[[SetPrototypeOf]](_proto_).+            1. If _status_ is *false*, throw a *TypeError* exception.+            1. Return *undefined*.+          </emu-alg>+        </emu-clause>+      </emu-clause>++      <emu-clause id="sec-object.prototype.__defineGetter__">

#1JS

devsnek

comment created time in 5 days

push eventv8/api

V8 API docs updater

commit sha 331dbee00b085862d329dba84c0e1e8d19bc1c83

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 5 days

push eventv8/api

V8 API docs updater

commit sha b04da33eb8689588b5b2ad0b84622ce71c121176

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 5 days

push eventv8/api

V8 API docs updater

commit sha 48a4bc354c96f53b079177b08e3c2abc9d05953e

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 6 days

push eventv8/api

V8 API docs updater

commit sha 06cd1ad76b9dc200dda691d213339e833e86836b

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 6 days

issue commentpuppeteer/puppeteer

Upload Photo Instagram Evaluation failed: TypeError: Failed to fetch

@koresar You're linking to the v2.1.1 docs which is an old version. Please provide a JS test case that shows the breakage on the latest Puppeteer (v5.2.1).

brkrtp

comment created time in 6 days

issue commentpuppeteer/puppeteer

Upload Photo Instagram Evaluation failed: TypeError: Failed to fetch

The screenshot in OP includes data URLs, which Puppeteer no longer uses since Paul's fix.

Those of you who are still experiencing this issue: please post a reduced test case we can use to reproduce the problem. Thanks!

brkrtp

comment created time in 7 days

issue closedpuppeteer/puppeteer

Getting freform text from a div

I'm trying to extract the text from a site that looks like this:

   <div class="u-vr4x">

   "
  <br>
 The U pups came to us full of fleas and ticks. These guys were a mess. They are so sweet now and so soft mouthed. I'm calling 
  them retriever mixes because of their soft mouth. They are very sweet and get along very well with each other. I'm sure that 
  they will make any family a great pet. Going to be about 70 to 75 lbs.<br>
  <br>
  <br>
   "
      </div>

But for the life of me, I can't get querySelector to grab anything. I tried something like this:

const result = await page.evaluate( () => Array.from( document.querySelectorAll('.u-vr4x')) console.log(result);

And it gives me this:

[ {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {}, {} ]

There are 24 occurrences of that class, so they were all found, but it looks like they are empty (which they are not). Anyone know if it is possible to extract the contents of the text inside them?

closed time in 7 days

ballfam

issue commenttc39/proposal-number-fromstring

Compare and contrast with HTML's number-parsing algorithm

Related upstream issue: https://github.com/tc39/ecma262/issues/2119 (Not about parsing specifically, but in the same spirit.)

domenic

comment created time in 7 days

push eventv8/api

V8 API docs updater

commit sha 4e98cd53aabe6c3baf4635c497a1a6c8cdcdefc7

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 7 days

push eventv8/api

V8 API docs updater

commit sha 9c2a948acf105e2cf3d4c2fc14c556dbb86e93c6

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 7 days

push eventv8/api

V8 API docs updater

commit sha 034e0a3f289d65beac04bb5f7a7c2d8a6176ac3e

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 8 days

push eventv8/api

V8 API docs updater

commit sha aa59a8c1dd183991bf78be002dda57b88ba27138

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 8 days

startedLeaVerou/color.js

started time in 9 days

push eventv8/api

V8 API docs updater

commit sha 4155c4f7d5798e210e04e723a71e587322e960ea

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 9 days

push eventv8/api

V8 API docs updater

commit sha 4bc935aeb49d9b218f51d4cdb85c867d3005aa75

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 9 days

push eventv8/api

V8 API docs updater

commit sha dd6d9c50e46485176e159d150e885d2366517c73

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 10 days

push eventv8/api

V8 API docs updater

commit sha 99f6438d72b98c273c031cea842f7d023241c632

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 10 days

push eventv8/api

V8 API docs updater

commit sha 50691e4eb90e177b60c754e718043fef74446350

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 11 days

push eventv8/api

V8 API docs updater

commit sha 92beee2feb7a4c7f1e57252258dfcf382f36b0e2

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 11 days

issue commentv8/v8.dev

Auto-add table-wrapper via custom Markdown rendering

Just to confirm: yes, it must be added to all tables. The wrapper is needed for narrow viewports. Thanks for taking a look!

RReverser

comment created time in 11 days

push eventv8/api

V8 API docs updater

commit sha 7a37f6935c033b12bbbc70c3db73b2da41538bf7

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 12 days

push eventv8/api

V8 API docs updater

commit sha 10e1709f52426866c50caa0fee507fe54f24f041

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 12 days

pull request commentw3c/webdriver-bidi

Define command dispatch and parameter validation

cc @christian-bromann since you were interested in this

bwalderman

comment created time in 12 days

issue commentpuppeteer/puppeteer

Add first level logging capability

I'm in the same boat. Definitely open to this, but it would be easier to discuss if there was a concrete API proposal or a patch.

christian-bromann

comment created time in 12 days

pull request commentpuppeteer/puppeteer

Support configuring the browser binary download path

@lcabral37 Looks like npm run lint is unhappy, could you please take a look?

lcabral37

comment created time in 12 days

pull request commentpuppeteer/puppeteer

Support configuring the browser binary download path

Thanks @lcabral37! I think we can land this soon — I'll just wait for @jschfflr to chime in on the above discussion as well.

lcabral37

comment created time in 13 days

pull request commentpuppeteer/puppeteer

Support configuring the browser binary download path

@lcabral37 Would you be up for rebasing this patch?

lcabral37

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.++## Policy++Terminology that is derogatory, hurtful, or perpetuates discrimination, either directly or indirectly, should be avoided.++## What is in scope for this policy?++Anything that a contributor would read while working on V8, including:++- Names of variables, types, functions, files, build rules, binaries, exported variables, ...+- Test data+- System output and displays+- Documentation (both inside and outside of source files)+- Commit messages++## Principles++- Be respectful: Derogatory language shouldn’t be necessary to describe how things work.+- Respect culturally sensitive language: Some words may carry significant historical or political meanings. Please be mindful of this and use alternatives.++## How do I know if particular terminology is OK or not?++Apply the principles above. If you have any questions, you can reach out to `v8-dev@googlegroups.com`.++## What are examples of terminology to be avoided?++This list is NOT meant to be comprehensive. It contains a few examples that people have run into frequently.++| Term      | Suggested alternatives                                        |

You also need the ::: at the end

surma

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.++## Policy++Terminology that is derogatory, hurtful, or perpetuates discrimination, either directly or indirectly, should be avoided.++## What is in scope for this policy?++Anything that a contributor would read while working on V8, including:++- Names of variables, types, functions, files, build rules, binaries, exported variables, ...+- Test data+- System output and displays+- Documentation (both inside and outside of source files)+- Commit messages++## Principles++- Be respectful: Derogatory language shouldn’t be necessary to describe how things work.+- Respect culturally sensitive language: Some words may carry significant historical or political meanings. Please be mindful of this and use alternatives.++## How do I know if particular terminology is OK or not?++Apply the principles above. If you have any questions, you can reach out to `v8-dev@googlegroups.com`.++## What are examples of terminology to be avoided?++This list is NOT meant to be comprehensive. It contains a few examples that people have run into frequently.++| Term      | Suggested alternatives                                        |

There are a few examples in the repository — just search for :::table-wrapper. It's needed to make the tables look good on narrow viewports. (Ideally we'd get rid of :::table-wrapper and instead auto-add it when converting the Markdown, but no one has done that work yet)

surma

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.++## Policy++Terminology that is derogatory, hurtful, or perpetuates discrimination, either directly or indirectly, should be avoided.++## What is in scope for this policy?++Anything that a contributor would read while working on V8, including:++- Names of variables, types, functions, files, build rules, binaries, exported variables, ...+- Test data+- System output and displays+- Documentation (both inside and outside of source files)+- Commit messages++## Principles++- Be respectful: Derogatory language shouldn’t be necessary to describe how things work.+- Respect culturally sensitive language: Some words may carry significant historical or political meanings. Please be mindful of this and use alternatives.++## How do I know if particular terminology is OK or not?++Apply the principles above. If you have any questions, you can reach out to `v8-dev@googlegroups.com`.++## What are examples of terminology to be avoided?++This list is NOT meant to be comprehensive. It contains a few examples that people have run into frequently.++| Term      | Suggested alternatives                                        |+| --------- | ------------------------------------------------------------- |+| master    | primary, controller, leader, host                             |+| slave     | replica, subordinate, secondary, follower, device, peripheral |+| whitelist | allowlist, exception list, inclusion list                     |+| blacklist | denylist, blocklist, exclusion list                           |+| insane    | unexpected, catastrophic, incoherent                          |+| sane      | expected, appropriate, sensible, valid                        |+| crazy     | unexpected, catastrophic, incoherent                          |+| redline   | priority line, limit, soft limit                              |++## What if I am interfacing with something that violates this policy?++This circumstance has come up a few times, particularly for code implementing specifications. In these circumstances, differing from the language in the specification may interfere with the ability to understand the implementation. For these circumstances, we suggest one of the following, in order of decreasing preference:++1. If using alternate terminology doesn't interfere with understanding, use alternate terminology.+2. Failing that, do not propagate the terminology beyond the layer of code that is performing the interfacing. Where necessary, use alternative terminology at the API boundaries.

It's mostly for consistency — this is the style we use all around v8.dev for numbered lists. (We chose this style because this way it's easy to insert list items later with minimal diffs + without having to worry about renumbering)

surma

comment created time in 13 days

pull request commentpuppeteer/puppeteer

Support configuring the browser binary download path

By changing the meaning of the env var, do you mean the change of the default value? I think in this case the meaning is still the same: your custom download path would be used.

When the var is set, that path is used, sure. The difference we'd get when changing the default is when it's not set — the "meaning" changes in the sense that you now need to use the var in different cases.

Sounds like there's appetite for not putting large binaries in the home folder by default. Thanks for chiming in, everyone! Let's go with this as-is then.

lcabral37

comment created time in 13 days

push eventpuppeteer/puppeteer

Jack Franklin

commit sha 21552f8fe76108267a6f2574747ff06746623ece

feat: page.waitForTimeout (#6268)

view details

push time in 13 days

delete branch puppeteer/puppeteer

delete branch : wait-for-timeout

delete time in 13 days

PR merged puppeteer/puppeteer

feat: page.waitForTimeout cla: yes

This PR adds page.waitForTimeout (and subsequently, frame.waitForTimeout) and deprecates the page.waitFor and frame.waitFor methods.

None of the functionality that waitFor provided is lost; it's now all available via the more explicit waitForX functions. This PR doesn't remove waitFor, all its functionality is still available. I'd suggest we ship this as a minor release, give it a while for users to adjust and then remove waitFor in the next reasonable breaking release.

Fixes #6214.

+296 -3

0 comment

12 changed files

jackfranklin

pr closed time in 13 days

issue closedpuppeteer/puppeteer

Proposal: deprecate `waitFor` and add `waitForTimer`

Puppeteer's API currently has a few waitForX functions:

  • waitForSelector
  • waitForFunction
  • waitForXPath

(And others that are less relevant to this proposal).

We also ship waitFor, which has the following docs:

This method behaves differently with respect to the type of the first parameter:

* if selectorOrFunctionOrTimeout is a string, then the first argument is treated as a selector or xpath, depending on whether or not it starts with '//', and the method is a shortcut for page.waitForSelector or page.waitForXPath
* if selectorOrFunctionOrTimeout is a function, then the first argument is treated as a predicate to wait for and the method is a shortcut for page.waitForFunction().
* if selectorOrFunctionOrTimeout is a number, then the first argument is treated as a timeout in milliseconds and the method returns a promise which resolves after the timeout
* otherwise, an exception is thrown

So if you call waitFor(someFunc), you're just calling waitForFunction. Similarly, waitFor('.foo') calls waitForSelector, and waitFor('//div') calls waitForXPath. The only unique behaviour waitFor provides is calling it with a time: waitFor(1000) does exactly what you expect.

Another downside of this method is that it's harder to type safely with TypeScript (you can do it via overloads, but it's uneccessarily complex, especially when all the standalone waitForX functions are already typed).

I think it's confusing that most of the API for waiting is explicitly named, e.g. waitForSelector, yet the only way to wait for a timeout is to call waitFor.

I'd propose a nicer, more consistent API would:

  1. Add waitForTimeout. This is consistent with the naming of the other wait for methods, which are all named waitForX.
  2. Remove waitFor.

Rather than do this as one breaking change we can do this change in two parts:

  1. Ship a version with waitForTimeout. Deprecate waitFor and log a message when it's used, but maintain its current behaviour.
  2. After a reasonable amount of time, ship a release that removes waitFor. The migration path should be straightforward, users will have to swap waitFor for the correct waitForX method. We'll have a waitForX for every behaviour of the original waitFor, so this won't be more than a renaming of some method calls.

closed time in 13 days

jackfranklin

pull request commentpuppeteer/puppeteer

Support configuring the browser binary download path

I think this can be landed as-is first because it does not block changing the default in the future.

To clarify, my worry is that people will learn about the new env var, and by the time they start to use it, we'll have changed its meaning again. We could avoid this confusion by ensuring the two changes (this + a future patch that changes the default) make it into the same release, but we'd have to decide soonish.

lcabral37

comment created time in 13 days

pull request commentpuppeteer/puppeteer

Support configuring the browser binary download path

Longer-term we'll want to change the default download dir to ~/.puppeteer. The ENV var could then be used to restore the current functionality of download it it a local subdirectory.

I wonder if we should make this change all at once (to reduce confusion), or land this as-is first, and then change the default later. WDYT?

lcabral37

comment created time in 13 days

pull request commentpuppeteer/puppeteer

Support configuring the browser binary download path

@lcabral37 We're planning to work on this soon. Please don't ping issues repeatedly asking for updates. If there is an update, you'll see it here.

lcabral37

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"

nit: we use single quotes elsewhere (both for title and description)

surma

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.++## Policy++Terminology that is derogatory, hurtful, or perpetuates discrimination, either directly or indirectly, should be avoided.++## What is in scope for this policy?++Anything that a contributor would read while working on V8, including:++- Names of variables, types, functions, files, build rules, binaries, exported variables, ...+- Test data+- System output and displays+- Documentation (both inside and outside of source files)+- Commit messages++## Principles++- Be respectful: Derogatory language shouldn’t be necessary to describe how things work.+- Respect culturally sensitive language: Some words may carry significant historical or political meanings. Please be mindful of this and use alternatives.++## How do I know if particular terminology is OK or not?++Apply the principles above. If you have any questions, you can reach out to `v8-dev@googlegroups.com`.++## What are examples of terminology to be avoided?++This list is NOT meant to be comprehensive. It contains a few examples that people have run into frequently.++| Term      | Suggested alternatives                                        |+| --------- | ------------------------------------------------------------- |+| master    | primary, controller, leader, host                             |+| slave     | replica, subordinate, secondary, follower, device, peripheral |+| whitelist | allowlist, exception list, inclusion list                     |+| blacklist | denylist, blocklist, exclusion list                           |+| insane    | unexpected, catastrophic, incoherent                          |+| sane      | expected, appropriate, sensible, valid                        |+| crazy     | unexpected, catastrophic, incoherent                          |+| redline   | priority line, limit, soft limit                              |++## What if I am interfacing with something that violates this policy?++This circumstance has come up a few times, particularly for code implementing specifications. In these circumstances, differing from the language in the specification may interfere with the ability to understand the implementation. For these circumstances, we suggest one of the following, in order of decreasing preference:++1. If using alternate terminology doesn't interfere with understanding, use alternate terminology.+2. Failing that, do not propagate the terminology beyond the layer of code that is performing the interfacing. Where necessary, use alternative terminology at the API boundaries.
1. Failing that, do not propagate the terminology beyond the layer of code that is performing the interfacing. Where necessary, use alternative terminology at the API boundaries.
surma

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.++## Policy++Terminology that is derogatory, hurtful, or perpetuates discrimination, either directly or indirectly, should be avoided.++## What is in scope for this policy?++Anything that a contributor would read while working on V8, including:++- Names of variables, types, functions, files, build rules, binaries, exported variables, ...+- Test data+- System output and displays+- Documentation (both inside and outside of source files)+- Commit messages++## Principles++- Be respectful: Derogatory language shouldn’t be necessary to describe how things work.+- Respect culturally sensitive language: Some words may carry significant historical or political meanings. Please be mindful of this and use alternatives.++## How do I know if particular terminology is OK or not?++Apply the principles above. If you have any questions, you can reach out to `v8-dev@googlegroups.com`.++## What are examples of terminology to be avoided?++This list is NOT meant to be comprehensive. It contains a few examples that people have run into frequently.++| Term      | Suggested alternatives                                        |+| --------- | ------------------------------------------------------------- |+| master    | primary, controller, leader, host                             |+| slave     | replica, subordinate, secondary, follower, device, peripheral |+| whitelist | allowlist, exception list, inclusion list                     |+| blacklist | denylist, blocklist, exclusion list                           |+| insane    | unexpected, catastrophic, incoherent                          |+| sane      | expected, appropriate, sensible, valid                        |+| crazy     | unexpected, catastrophic, incoherent                          |+| redline   | priority line, limit, soft limit                              |++## What if I am interfacing with something that violates this policy?++This circumstance has come up a few times, particularly for code implementing specifications. In these circumstances, differing from the language in the specification may interfere with the ability to understand the implementation. For these circumstances, we suggest one of the following, in order of decreasing preference:++1. If using alternate terminology doesn't interfere with understanding, use alternate terminology.
1. If using alternate terminology doesn’t interfere with understanding, use alternate terminology.
surma

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.++## Policy++Terminology that is derogatory, hurtful, or perpetuates discrimination, either directly or indirectly, should be avoided.++## What is in scope for this policy?++Anything that a contributor would read while working on V8, including:++- Names of variables, types, functions, files, build rules, binaries, exported variables, ...+- Test data+- System output and displays+- Documentation (both inside and outside of source files)+- Commit messages++## Principles++- Be respectful: Derogatory language shouldn’t be necessary to describe how things work.+- Respect culturally sensitive language: Some words may carry significant historical or political meanings. Please be mindful of this and use alternatives.++## How do I know if particular terminology is OK or not?++Apply the principles above. If you have any questions, you can reach out to `v8-dev@googlegroups.com`.++## What are examples of terminology to be avoided?++This list is NOT meant to be comprehensive. It contains a few examples that people have run into frequently.++| Term      | Suggested alternatives                                        |+| --------- | ------------------------------------------------------------- |+| master    | primary, controller, leader, host                             |+| slave     | replica, subordinate, secondary, follower, device, peripheral |+| whitelist | allowlist, exception list, inclusion list                     |+| blacklist | denylist, blocklist, exclusion list                           |+| insane    | unexpected, catastrophic, incoherent                          |+| sane      | expected, appropriate, sensible, valid                        |+| crazy     | unexpected, catastrophic, incoherent                          |+| redline   | priority line, limit, soft limit                              |++## What if I am interfacing with something that violates this policy?

{ #violations }?

surma

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.++## Policy++Terminology that is derogatory, hurtful, or perpetuates discrimination, either directly or indirectly, should be avoided.++## What is in scope for this policy?++Anything that a contributor would read while working on V8, including:++- Names of variables, types, functions, files, build rules, binaries, exported variables, ...+- Test data+- System output and displays+- Documentation (both inside and outside of source files)+- Commit messages++## Principles++- Be respectful: Derogatory language shouldn’t be necessary to describe how things work.+- Respect culturally sensitive language: Some words may carry significant historical or political meanings. Please be mindful of this and use alternatives.++## How do I know if particular terminology is OK or not?++Apply the principles above. If you have any questions, you can reach out to `v8-dev@googlegroups.com`.++## What are examples of terminology to be avoided?++This list is NOT meant to be comprehensive. It contains a few examples that people have run into frequently.++| Term      | Suggested alternatives                                        |

This needs a :::table-wrapper

surma

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.++## Policy++Terminology that is derogatory, hurtful, or perpetuates discrimination, either directly or indirectly, should be avoided.++## What is in scope for this policy?

Maybe append { #scope } here for nice IDs? Same for the other long headings below.

surma

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.
Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.
surma

comment created time in 13 days

Pull request review commentv8/v8.dev

Add page about respectful code

+---+title: "Respectful code"+description: "Inclusivity is central to V8’s culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination."+---++Inclusivity is central to V8's culture, and our values include treating each other with dignity. As such, it’s important that everyone can contribute without facing the harmful effects of bias and discrimination. However, terms in our codebase, UIs, and documentation can perpetuate that discrimination. This document sets forth guidance which aims to address disrespectful terminology in code and documentation.++## Policy++Terminology that is derogatory, hurtful, or perpetuates discrimination, either directly or indirectly, should be avoided.++## What is in scope for this policy?++Anything that a contributor would read while working on V8, including:++- Names of variables, types, functions, files, build rules, binaries, exported variables, ...+- Test data+- System output and displays+- Documentation (both inside and outside of source files)+- Commit messages++## Principles++- Be respectful: Derogatory language shouldn’t be necessary to describe how things work.+- Respect culturally sensitive language: Some words may carry significant historical or political meanings. Please be mindful of this and use alternatives.
- Be respectful: derogatory language shouldn’t be necessary to describe how things work.
- Respect culturally sensitive language: some words may carry significant historical or political meanings. Please be mindful of this and use alternatives.
surma

comment created time in 13 days

push eventmathiasbynens/dotfiles

Mathias Bynens

commit sha 0cd43d175a25c0e13e1e06ab31ccfd9f0169cf73

.gitconfig: Rely on Git v2.28’s `init.defaultBranch`

view details

push time in 13 days

issue closedpuppeteer/puppeteer

Question: Manipulate PDF document properties at generation time

Hello, maybe someone knows if it is possible to manipulate PDF properties at generation time? For example, each PDF file has Security tab (cmd+d in Adobe Reader) in properties that allow to enable/disable Printing, Content copying, etc (please refer to screenshot below). In addition, it would be great to be able to set "Two page view" programatically so whenever user opens generated PDF it already has preselected view for them. I might be missing something, but could not find how to provide those settings to Puppeteer and would be very thankful if someone could help to figure this out. If it is not possible at the moment, advice on where is the best place to start adding this functionality would be also highly appreciated image

closed time in 13 days

maxgram

issue commentpuppeteer/puppeteer

Question: Manipulate PDF document properties at generation time

This is not currently possible with Puppeteer. If you want to go and implement this, you could propose a patch adding options corresponding to these settings to the CDP Page.printToPDF command.

Closing this issue for now since we don't have plans to work on this.

maxgram

comment created time in 13 days

pull request commentGoogleChrome/web.dev

[WebHID article] Replace colon entity with just :

No because it breaks eleventy.

5:34:34 AM: > incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line at line 2, column 42:

FWIW, this is a YAML syntax issue, the fix for which is:

-title: Human interface devices on the web: a few quick examples
+title: 'Human interface devices on the web: a few quick examples'
tomayac

comment created time in 13 days

push eventv8/api

V8 API docs updater

commit sha d660543487e6799ac9700cdb1f6592d21119b87e

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 13 days

push eventv8/api

V8 API docs updater

commit sha 471dbe15a268c1c36b233af07a4cbce926a9337f

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 13 days

push eventpuppeteer/puppeteer

Jaroslav Maslo

commit sha a47b5561556c797483b3fec736eee436a65da95d

docs(api): fix typo in elementHandle.evaluateHandle() (#6276)

view details

push time in 14 days

push eventv8/api

V8 API docs updater

commit sha 5b9d866bbf27bf96e79eef3eb99628e3ab7f9878

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 14 days

push eventv8/api

V8 API docs updater

commit sha 459dc2dd9e1e908b8ff8e77786da920a13046375

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 14 days

push eventtibiamaps/tibia-map-data

mathiasbynens

commit sha 7c8d1580fc2634ad691c0e20c94cd1132e26ad77

Update generated map data @ 1702540574a24e3e8ab26d863d402eb908c4ed52

view details

push time in 15 days

push eventtibiamaps/tibia-map-data

Mathias Bynens

commit sha 1702540574a24e3e8ab26d863d402eb908c4ed52

Import marker changes from client

view details

push time in 15 days

push eventtibiamaps/tibia-map-data

mathiasbynens

commit sha 6fcda63eff119b80eecaadb25c9be5330945c3b2

Update generated map data @ 7fb8d51ceb93789f42505a926443f8aa38e464bb

view details

push time in 15 days

push eventtibiamaps/tibia-map-data

Mathias Bynens

commit sha 7fb8d51ceb93789f42505a926443f8aa38e464bb

Import marker changes from client

view details

push time in 15 days

delete branch mathiasbynens/tc39-notes

delete branch : abbrs-must-be-ids

delete time in 15 days

issue commenttibiamaps/tibia-map-data

Bog God Temple, 3rd level

I don't see an image in your post, unfortunately. I think GitHub does not support file attachments in emails :( You might need to upload the file on the web interface, on the issue you filed, here: https://github.com/tibiamaps/tibia-map-data/issues/98 Thanks!

Maddogs1964

comment created time in 15 days

push eventv8/api

V8 API docs updater

commit sha 385c7ef9b4a2d9d07a2afb70806f867323ec596a

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 16 days

push eventv8/api

V8 API docs updater

commit sha 5e45f0578833121ec9a7d93688026d99ab1d35a8

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 16 days

issue closedmathiasbynens/dotfiles

Idk

closed time in 17 days

XxPandaPawxX

push eventpuppeteer/ispuppeteerfirefoxready

mathiasbynens

commit sha 351c2a1554ce4ae5554da4e87ed8d39e5225d021

Deploying to gh-pages from main @ ee8ffcd74126fd17e8b11e2a6fb663cd7376e6c1 🚀

view details

push time in 17 days

push eventpuppeteer/ispuppeteerfirefoxready

mathiasbynens

commit sha a1db21e91a2f6c141dabe742044eab2c38f71001

Deploying to gh-pages from main @ ee8ffcd74126fd17e8b11e2a6fb663cd7376e6c1 🚀

view details

push time in 17 days

push eventv8/api

V8 API docs updater

commit sha c12c540e5c2e3b80f8a2b3e3444843138ac1f131

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 17 days

push eventv8/api

V8 API docs updater

commit sha 968ffdd4c788cb742a874373525a02aa5b2faf64

Deploying to gh-pages from main @ 58fde0873ac3b1426a80d83b93bde456074bc924 🚀

view details

push time in 17 days

issue commenttibiamaps/tibia-map-data

Bog God Temple, 3rd level

Thanks! Do you have the corresponding Minimap_WaypointCost_33024_32000_5.png file too?

Maddogs1964

comment created time in 17 days

push eventpuppeteer/puppeteer

Christian Bromann

commit sha 8c1a5866c566f14e6b81f8763da2b435e88f0450

fix: handle promise for reading protocol stream of trace (#6270)

view details

push time in 17 days

PR merged puppeteer/puppeteer

fix: handle promise for reading protocol stream of trace cla: yes

If you provide a malformed path property to Tracing.start, e.g.

page.tracing.start({ path: __dirname })

it will cause a UnhandledPromiseRejectionWarning with tracing.stop() never being resolved, e.g. due to:

(node:37510) UnhandledPromiseRejectionWarning: Error: EISDIR: illegal operation on a directory, open '/path/to/dirname'

This is due to the fact that a readProtocolStream rejection is not caught. This patch fixes that.

+18 -2

0 comment

2 changed files

christian-bromann

pr closed time in 17 days

MemberEvent
more