css-modules/postcss-modules 1180
PostCSS plugin to use CSS Modules everywhere
KyleAMathews/superagent-bluebird-promise 190
Add promise support to superagent using Bluebird
JSS Loader for Webpack
A "HTML5" implementation of Stunts
markdalgleish/allthethings.js 7
Let your array iterations read like actual sentences
markdalgleish/bespoke-remote-prototype 6
Prototype presentation for bespoke-remote
markdalgleish/angular-delegator 5
Write smaller, cleaner AngularJS services
Help radiator for remote agile teams. Built using Meteor.
markdalgleish/awesome-design-systems 3
💅🏻 ⚒ A collection of awesome design systems
A collection of awesome React libraries, resources and shiny things.
startedgothinkster/realworld
started time in 19 hours
push eventseek-oss/braid-design-system
commit sha ea981f03df04ccb5c5265f485ee8786e47a642f0
Docs: Add "New" badge to prototyping guide (#813)
push time in 3 days
PR merged seek-oss/braid-design-system
pr closed time in 3 days
push eventseek-oss/braid-design-system
commit sha 1c0046dce91ac1656852e278856d6656193e337c
Widen sidebar
push time in 3 days
push eventseek-oss/braid-design-system
commit sha 0f2d5173f97b69d397215324d329c1040bb41b7f
Add missing word
push time in 3 days
PR opened seek-oss/braid-design-system
pr created time in 4 days
push eventseek-oss/braid-design-system
commit sha 67786fbc342ab6931679359affe3bbbe212a0ee9
Docs: Add initial Playroom prototyping guide (#811)
push time in 4 days
PR merged seek-oss/braid-design-system
pr closed time in 4 days
PR opened seek-oss/braid-design-system
pr created time in 4 days
push eventseek-oss/braid-design-system
commit sha e44b3111df04f408779a489a4c59b2e6b0ed1fdd
Tweak guide
push time in 4 days
Pull request review commentseek-oss/braid-design-system
Add RadioGroup & RadioItem components
import React, { useState } from 'react'; import { ComponentDocs } from '../../../site/src/types'; import { Badge, Radio, Text } from '../';-import { Radio as PlayroomRadio } from '../../playroom/components';+import { TextLink } from '../TextLink/TextLink'; const docs: ComponentDocs = { category: 'Content',- migrationGuide: true,+ migrationGuide: false,+ deprecationWarning: (+ <Text weight="medium">+ This component has been deprecated. Use{' '}+ <TextLink href="/components/RadioGroup">RadioGroup</TextLink> and{' '}+ <TextLink href="/components/RadioItem">RadioItem</TextLink> instead.
This component doesn't have its own page.
comment created time in 6 days
Pull request review commentseek-oss/braid-design-system
Add RadioGroup & RadioItem components
-import React, { forwardRef } from 'react';+import React, { forwardRef, useContext } from 'react';+import assert from 'assert'; import { InlineField, InlineFieldProps, } from '../private/InlineField/InlineField';+import { RadioGroupContext } from '../RadioGroup/RadioGroupContext';+import dedent from 'dedent'; export interface RadioProps extends Omit< InlineFieldProps, 'message' | 'reserveMessageSpace' | 'required' > {} -const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => (- <InlineField- {...props}- type="radio"- message={null}- reserveMessageSpace={false}- required={undefined}- ref={ref}- />-));+const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => {+ const radioListContext = useContext(RadioGroupContext);
Could we rename this to radioGroupContext?
comment created time in 6 days
Pull request review commentseek-oss/braid-design-system
Add RadioGroup & RadioItem components
-import React, { forwardRef } from 'react';+import React, { forwardRef, useContext } from 'react';+import assert from 'assert'; import { InlineField, InlineFieldProps, } from '../private/InlineField/InlineField';+import { RadioGroupContext } from '../RadioGroup/RadioGroupContext';+import dedent from 'dedent'; export interface RadioProps extends Omit< InlineFieldProps, 'message' | 'reserveMessageSpace' | 'required' > {} -const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => (- <InlineField- {...props}- type="radio"- message={null}- reserveMessageSpace={false}- required={undefined}- ref={ref}- />-));+const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => {+ const radioListContext = useContext(RadioGroupContext);++ assert(
😄
comment created time in 6 days
Pull request review commentseek-oss/braid-design-system
Add RadioGroup & RadioItem components
-import React, { forwardRef } from 'react';+import React, { forwardRef, useContext } from 'react';+import assert from 'assert'; import { InlineField, InlineFieldProps, } from '../private/InlineField/InlineField';+import { RadioGroupContext } from '../RadioGroup/RadioGroupContext';+import dedent from 'dedent'; export interface RadioProps extends Omit< InlineFieldProps, 'message' | 'reserveMessageSpace' | 'required' > {} -const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => (- <InlineField- {...props}- type="radio"- message={null}- reserveMessageSpace={false}- required={undefined}- ref={ref}- />-));+const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => {+ const radioListContext = useContext(RadioGroupContext);++ assert(
Ignore me, just realised this only throws when used inside RadioGroup.
comment created time in 6 days
Pull request review commentseek-oss/braid-design-system
Add RadioGroup & RadioItem components
-import React, { forwardRef } from 'react';+import React, { forwardRef, useContext } from 'react';+import assert from 'assert'; import { InlineField, InlineFieldProps, } from '../private/InlineField/InlineField';+import { RadioGroupContext } from '../RadioGroup/RadioGroupContext';+import dedent from 'dedent'; export interface RadioProps extends Omit< InlineFieldProps, 'message' | 'reserveMessageSpace' | 'required' > {} -const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => (- <InlineField- {...props}- type="radio"- message={null}- reserveMessageSpace={false}- required={undefined}- ref={ref}- />-));+const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => {+ const radioListContext = useContext(RadioGroupContext);++ assert(
This should be a console.warn (when not in prod) rather than an assert, otherwise it's a breaking change.
comment created time in 6 days
issue commentseek-oss/playroom
@pascalduez Your approach is definitely simpler, but only recently became possible because the internal component that wraps your JSX used to be a class component, so Hooks were not supported.
comment created time in 9 days
push eventseek-oss/braid-design-system
commit sha 8f18a23771da177093d58fa6c0b959c6a2e86fbc
Version Packages (#808)
push time in 10 days
delete branch seek-oss/braid-design-system
delete branch : changeset-release/master
delete time in 10 days
PR merged seek-oss/braid-design-system
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
[email protected]
Patch Changes
-
Tabs: Only scroll tabs when necessary on large screens (#806)
Previously, when there were enough tabs to require horizontal scrolling, we would always scroll the active tab to the left-hand side of the scroll container (with a slight offset). This was primarily designed as a mobile interaction, and in practice was found to be a bit unexpected on large screens.
Instead, when the tabs are scrollable on large screens, we now only scroll the active tab into view if it's partially off-screen or positioned too close to the edge of the scroll container. This ensures that automatic scrolling only occurs when absolutely necessary.
pr closed time in 10 days
push eventseek-oss/braid-design-system
commit sha a3f8a83d6a5eee5f660bad7bd8ed050ee4b4e0d9
Update dependency sku to v10.8.0 (#805) Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Matt Jones <[email protected]>
commit sha bc2e0bd5a38e8058bcd36368478ad7c1bcee931f
Merge branch 'master' into changeset-release/master
push time in 10 days
Pull request review commentseek-oss/braid-design-system
Update dependency sku to v10.8.0
"scripts": { "test": "SKU_TELEMETRY=false sku test", "start": "SKU_TELEMETRY=false concurrently -n \"docs-site,playroom\" -c \"magenta,greenBright\" \"sku start\" \"OPEN_TAB=false sku playroom\"",- "lint": "SKU_TELEMETRY=false sku lint && yarn lint-absolute-imports",- "lint-absolute-imports": "! grep -R \" from 'lib/\" lib/*",
Let's pour one out for this script 🍺👋😢
comment created time in 10 days
Pull request review commentseek-oss/braid-design-system
Add RadioGroup & RadioItem components
-import React, { forwardRef } from 'react';+import React, { forwardRef, useContext } from 'react';+import assert from 'assert'; import { InlineField, InlineFieldProps, } from '../private/InlineField/InlineField';+import { RadioGroupContext } from '../RadioGroup/RadioGroupContext';+import dedent from 'dedent'; export interface RadioProps extends Omit< InlineFieldProps, 'message' | 'reserveMessageSpace' | 'required' > {} -const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => (- <InlineField- {...props}- type="radio"- message={null}- reserveMessageSpace={false}- required={undefined}- ref={ref}- />-));+const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => {+ const radioListContext = useContext(RadioGroupContext);++ assert(+ radioListContext === null,+ 'The "Radio" component has been deprecated. Use a "RadioItem" instead.',+ );++ if (process.env.NODE_ENV !== 'production') {+ // eslint-disable-next-line no-console+ console.warn(+ dedent`+ The "Radio" component has been deprecated and will be removed in a future version. Use "RadioGroup" with "RadioItem" instead.+ %c+ - <Radio name="count" label="One" value="1" onChange={...} />+ - <Radio name="count" label="Two" value="2" onChange={...} checked />+ - <Radio name="count" label="Three" value="3" onChange={...} />+ %c+ + <RadioGroup name="count" value="2" onChange={...}>
Should name be id here now?
comment created time in 10 days
Pull request review commentseek-oss/braid-design-system
Add RadioGroup & RadioItem components
+---+'braid-design-system': minor+---++---+new:+ - RadioGroup+ - RadioItem+---++**RadioGroup,RadioItem:** Add RadioGroup & RadioItem components++The RadioGroup provides an accessible way to group and control a set of **RadioItem** components. The RadioGroup is responsible for handling the value, tone, message, and disabled state—determining the presentation and selection of the items in the list.++**EXAMPLE USAGE:**+```jsx+<RadioGroup+ id="experience"+ name="experience"
Can drop this now.
comment created time in 10 days
Pull request review commentseek-oss/braid-design-system
Add RadioGroup & RadioItem components
+# RadioGroup Migration Guide++A `RadioItem` must be wrapped inside of a `RadioGroup`. As part of the migration you should be hoisting the controlled state its handling to [RadioGroup.](https://seek-oss.github.io/braid-design-system/components/RadioGroup).
A `RadioItem` must be wrapped inside of a `RadioGroup`. As part of the migration, you should be hoisting the controlled state it's handling to [RadioGroup.](https://seek-oss.github.io/braid-design-system/components/RadioGroup).
comment created time in 10 days
Pull request review commentseek-oss/braid-design-system
Add RadioGroup & RadioItem components
-import React, { forwardRef } from 'react';+import React, { forwardRef, useContext } from 'react';+import assert from 'assert'; import { InlineField, InlineFieldProps, } from '../private/InlineField/InlineField';+import { RadioGroupContext } from '../RadioGroup/RadioGroupContext';+import dedent from 'dedent'; export interface RadioProps extends Omit< InlineFieldProps, 'message' | 'reserveMessageSpace' | 'required' > {} -const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => (- <InlineField- {...props}- type="radio"- message={null}- reserveMessageSpace={false}- required={undefined}- ref={ref}- />-));+const NamedRadio = forwardRef<HTMLInputElement, RadioProps>((props, ref) => {+ const radioListContext = useContext(RadioGroupContext);++ if (process.env.NODE_ENV !== 'production') {+ assert(
This one should be outside of the env check so it runs in Playroom. Also, should be radioGroupContext.
comment created time in 10 days
push eventseek-oss/braid-design-system
commit sha d7fce43be87f023eea84a1c297591c7a060f6763
Tabs: Only scroll tabs when necessary of large screens (#806)
push time in 10 days
delete branch seek-oss/braid-design-system
delete branch : tab-scroll-management
delete time in 10 days
PR merged seek-oss/braid-design-system
See changeset for details.
Also cleaned up some unused options in the smoothScroll logic, removing the delay option and removing support for selector strings.
pr closed time in 10 days
pull request commentseek-oss/braid-design-system
Tabs: Only scroll tabs when necessary of large screens
markdalgleish
comment created time in 10 days
PR opened seek-oss/braid-design-system
See changeset for details.
pr created time in 10 days
create barnchseek-oss/braid-design-system
branch : tab-scroll-management
created branch time in 10 days
push eventseek-oss/braid-design-system
commit sha 5f2493f5761531ae6798895f299c3122a1167cdd
Update dependency playroom to v0.22.3 (#800)
push time in 13 days
delete branch seek-oss/braid-design-system
delete branch : renovate--playroom-0.x
delete time in 13 days
PR merged seek-oss/braid-design-system
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| playroom | resolutions | patch | 0.22.2 -> 0.22.3 |
Release Notes
<details> <summary>seek-oss/playroom</summary>
v0.22.3
Bug Fixes
</details>
Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
This PR has been generated by WhiteSource Renovate. View repository job log here.
pr closed time in 13 days
push eventseek-oss/braid-design-system
commit sha 452756c8eeebdc0cf29b5cff1c987ff752b9b202
Update dependency sku to v10.7.1 (#799)
push time in 13 days
delete branch seek-oss/braid-design-system
delete branch : renovate--sku-10.x
delete time in 13 days
PR merged seek-oss/braid-design-system
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| sku | devDependencies | patch | 10.7.0 -> 10.7.1 |
Release Notes
<details> <summary>seek-oss/sku</summary>
v10.7.1
Patch Changes
</details>
Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
This PR has been generated by WhiteSource Renovate. View repository job log here.
pr closed time in 13 days
pull request commentseek-oss/playroom
fix: Ignore invalid exported components
Thanks for the PR!
comment created time in 13 days
push eventseek-oss/playroom
commit sha 0c69e1cf021f31d4ce237a6f1ac7cf8cecbc4609
fix: Ignore invalid exported components (#140)
push time in 13 days
PR merged seek-oss/playroom
Playroom currently expects that every single export in the components module is a valid React component.
For example, export const NotAComponent = 1 would result in Playroom exposing a broken component called <NotAComponent>.
Another issue pointed in #138 is that an exported value of undefined will crash Playroom. This happens in particular when a TypeScript type is explicitly exported in an export declaration statement such as export { Component, SomeType }.
This can all be resolved by filtering out any value that isn't a function. This isn't perfect, as it will still accept non-React functions and classes, but should at least fix a good portion of bugs experienced by people trying out the tool for the first time.
This fixes #138.
pr closed time in 13 days
issue closedseek-oss/playroom
Exporting a TypeScript interface crashes Playroom
First of all, now that I got it working, Playroom is amazing!
I initially ran into a bit of an issue caused by the way we export our components from our design/components/src/index.js:
export * from './Button';
...
Inside design/components/src/Button/index.tsx, we have:
export { Button, ButtonProps } from './Button';
ButtonProps is a TypeScript interface, and that seems to cause Playroom to crash hard with the following error:
index.js?4ac5:80 Uncaught (in promise) TypeError: Cannot read property 'propTypes' of undefined
at parsePropTypes (index.js?4ac5:80)
at eval (componentsToHints.ts?b76f:26)
at Array.map (<anonymous>)
at _default (componentsToHints.ts?b76f:13)
at _default (Playroom.tsx?34a3:116)
at renderWithHooks (react-dom.development.js?61bb:16260)
at updateFunctionComponent (react-dom.development.js?61bb:18347)
at beginWork$1 (react-dom.development.js?61bb:20176)
at HTMLUnknownElement.callCallback (react-dom.development.js?61bb:336)
at Object.invokeGuardedCallbackDev (react-dom.development.js?61bb:385)
Now that I've figured out the issue, it's an easy fix: make sure that we never export TypeScript types to Playroom. However, it may be better to simply ignore TypeScript type exports, or really anything that isn't a React component?
I'd be happy to try sending out a PR if you'd like me to.
closed time in 13 days
fwouts
push eventseek-oss/braid-design-system
commit sha 07e8625cbe5c53f014a137860cd6624ac1fa0196
Add getState, setState, resetState and showToast to Playroom (#797)
push time in 13 days
PR merged seek-oss/braid-design-system
This adds the showToast function returned from useToast, as well as the following state management functions:
getState: (key: string, defaultValue?: any) => anysetState: (key: string, value: any) => voidsetState: (key: string) => (value: any) => voidresetState: () => voidresetState: (...keys: string[]) => void
I've also tweaked a few Playroom component wrappers and snippets to make them play nicer with external state.
pr closed time in 13 days
push eventseek-oss/braid-design-system
commit sha e19039f57ca7fbf42fc6a062825401eab97416ba
Fix types
push time in 13 days
pull request commentseek-oss/braid-design-system
Add getState, setState, resetState and showToast to Playroom
markdalgleish
comment created time in 17 days
PR opened seek-oss/braid-design-system
This adds the showToast function returned from useToast, as well as the following state management functions:
getState: (key: string, defaultValue?: any) => anysetState: (key: string, value: any) => voidsetState: (key: string) => (value: any) => voidresetState: () => voidresetState: (...keys[]) => void
pr created time in 18 days
pull request commentseek-oss/playroom
fix(Preview): Don't set negative z-index for preview content
Thanks for this PR! I ended up fixing it in a slightly different way, but I still really appreciate this.
comment created time in 18 days
push eventseek-oss/playroom
commit sha 83f51d7ef35e890e7eb0c6deef72ddc7d392ec53
fix: Only nest user content inside FrameComponent in preview mode (#203)
push time in 18 days
PR merged seek-oss/playroom
Addresses https://github.com/seek-oss/playroom/pull/187#issuecomment-700165520
pr closed time in 18 days
PR opened seek-oss/playroom
Addresses https://github.com/seek-oss/playroom/pull/187#issuecomment-700165520
pr created time in 18 days
push eventseek-oss/playroom
commit sha 5a745b2142f1a8ea04b5b80b6e80cf19ba6d6952
fix: Ensure rendered content is interactive in preview mode (#202)
push time in 18 days
PR merged seek-oss/playroom
This PR creates two separate stacking contexts for the rendered content and the splash screen, ensuring that the splash screen is always above the rendered content (even if it contains elements with very high z-indexes), but also ensuring that the rendered content is still interactive.
Closes #198 Fixes #197
pr closed time in 18 days
PR closed seek-oss/playroom
fixes change made in #187
rather than just reporting, this should fix issue #197
simply setting position: relative; on the container of the preview content will prevent child elements within the container to stack above the SplashScreen because they will be stacked relatively to the container (and not it's parent)
pr closed time in 18 days
issue closedseek-oss/playroom
I ran into this issue after upgrading our package, this pr: #187 is the culprit
making the z-index of the container negative puts it behind the <body> element and not clickable, or in case you give the body a background color it will just show a blank page
in this example you can't click the button because of this
closed time in 18 days
riencoertjens
PR opened seek-oss/playroom
This PR creates two separate stacking contexts for the rendered content and the splash screen, ensuring that the splash screen is always above the rendered content (even if it contains elements with very high z-indexes), but also ensuring that the rendered content is still interactive.
Closes #198 Fixes #197
pr created time in 18 days
push eventseek-oss/sku
commit sha d36d55995abccb2e24c638e0b9346282a6982af4
Version Packages (#540)
push time in 18 days
PR merged seek-oss/sku
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
[email protected]
Minor Changes
-
Playroom: Update to v0.22.0, add
playroomScopeoption (#539)You can now use Playroom's new custom scope feature by providing a
playroomScopefile.EXAMPLE USAGE
sku.config.js:
module.exports = { playroomScope: './playroom/useScope.ts', };useScope.ts:
import { useToast } from 'braid-design-system'; export default function useScope() { return { showToast: useToast(), }; }
pr closed time in 18 days
push eventseek-oss/sku
commit sha 2ba5cfc5028b9fc0cd2fbe68b26fc54b2e6605fe
Playroom: Update to v0.22.0, add 'playroomScope' option (#539)
push time in 18 days
push eventseek-oss/braid-design-system
commit sha 06ae22ab90b64a7192427f32498e7009886f0121
Version Packages (#793)
push time in 19 days
delete branch seek-oss/braid-design-system
delete branch : changeset-release/master
delete time in 19 days
PR merged seek-oss/braid-design-system
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
[email protected]
Minor Changes
-
Autosuggest: Add
hideSuggestionsOnSelectionprop (#792)Typically we hide the suggestion list when a selection is made, assuming that the field is now populated with the desired value. However, if the surrounding application clears the text field when a selection is made, this clashes with the user expectation that the field has been reverted back to its initial state with suggestions visible. To cater for this, we now allow you to opt out of this behaviour via the
hideSuggestionsOnSelectionboolean prop.EXAMPLE USAGE
<Autosuggest hideSuggestionsOnSelection={false} {...rest} />
pr closed time in 19 days
push eventseek-oss/braid-design-system
commit sha 73cf49696aab908998c5e9aa865d1173b37f27b1
Add front matter to Autosuggest changeset (#794)
push time in 19 days