profile
viewpoint
Daniele Margutti malcommac Mobile Tech Lead Immobiliare.it Rome, Italy http://www.danielemargutti.com I'm an iOS & macOS developer since 2000. I love to make high quality applications; currently technical leader for mobile at Immobiliare.it

issue commentmalcommac/SwiftRichString

Weird Crash on String.substring(from:length:)

Can you provide a simple test project so I'll try to reproduce it in my test devices. Thanks

robertodias180

comment created time in 2 days

issue commentmalcommac/SwiftRichString

`numberSpacing` attribute is not applied at all

Can you provide a live example to test? Thanks

letko-dmitry

comment created time in 2 days

issue closedmalcommac/SwiftRichString

Font is not preserved by setting it in Style or StyleGroup when cached values are used

Cached attributes preserve the wrong font by reading fontData.attributes which reports wrong settings. Instead it should use the fontData?.font

closed time in 2 days

malcommac

release malcommac/SwiftRichString

3.0.4

released time in 3 days

push eventmalcommac/SwiftRichString

Daniele Margutti

commit sha 645efe1c27e93b693c001c440ba2e9d7b934273c

Merge tag '3.0.3' into develop 3.0.3

view details

daniele margutti

commit sha 5628ad448a42f04a6c02a1f232117ebd52873207

#92 Fixed cachedAttribute's font

view details

daniele margutti

commit sha 356585199064d1a3982379b578662c1ae3fa4f5b

Bump to 3.0.4

view details

daniele margutti

commit sha 20d0df9cb141bf4586bcde8d6ecc8e618718b98f

Bump to 3.0.4

view details

daniele margutti

commit sha d87ed2333a050b78ab2f0d56cd264bab1b784a97

Merge branch 'release/3.0.4'

view details

push time in 3 days

push eventmalcommac/SwiftRichString

daniele margutti

commit sha d87ed2333a050b78ab2f0d56cd264bab1b784a97

Merge branch 'release/3.0.4'

view details

daniele margutti

commit sha d1416bad46cb9fbb0a48fb26a1dbc709820f870d

Merge tag '3.0.4' into develop 3.0.4

view details

push time in 3 days

created tagmalcommac/SwiftRichString

tag3.0.4

Elegant & painless Attributed Strings in Swift

created time in 3 days

push eventmalcommac/SwiftRichString

daniele margutti

commit sha 356585199064d1a3982379b578662c1ae3fa4f5b

Bump to 3.0.4

view details

daniele margutti

commit sha 20d0df9cb141bf4586bcde8d6ecc8e618718b98f

Bump to 3.0.4

view details

push time in 3 days

push eventmalcommac/SwiftRichString

daniele margutti

commit sha 5628ad448a42f04a6c02a1f232117ebd52873207

#92 Fixed cachedAttribute's font

view details

push time in 3 days

issue openedmalcommac/SwiftRichString

Wrong font set in Style

Cached attributes preserve the wrong font by reading fontData.attributes which reports wrong settings. Instead it should use the fontData?.font

created time in 3 days

startedruddfawcett/Notepad

started time in 4 days

startediwasrobbed/Down

started time in 4 days

release malcommac/ScrollStackController

1.0.3

released time in 4 days

created tagmalcommac/ScrollStackController

tag1.0.3

Create complex scrollable layout using UIViewControllers and simplify your code!

created time in 4 days

push eventmalcommac/ScrollStackController

daniele margutti

commit sha 66b279fc93eea0bfd3acd31de92087dfa86f4342

Merge tag '1.0.2' into develop 1.0.2

view details

daniele margutti

commit sha 2f447b2c198cf55fa59394b1b45c618456674deb

#2 Fixed reloadContentFromStackView() called even at first layout

view details

daniele margutti

commit sha b7de9cccaf4b112aeee0abce72e82add71b73f70

#3 Added setRows() method

view details

daniele margutti

commit sha 049fa98d10979a14af3725038122e6911f7ce664

Fixed example

view details

daniele margutti

commit sha b8e3e59f60809bbaf8fa299e7e8b1dca5c10e425

Bump to 1.0.3

view details

daniele margutti

commit sha dc86626b12d2951805b6fd9d811e76baf6688219

Merge branch 'release/1.0.3'

view details

push time in 4 days

push eventmalcommac/ScrollStackController

daniele margutti

commit sha dc86626b12d2951805b6fd9d811e76baf6688219

Merge branch 'release/1.0.3'

view details

daniele margutti

commit sha 4513fb9dab2129b745e0580d2c5b11da304caf69

Merge tag '1.0.3' into develop 1.0.3

view details

push time in 4 days

push eventmalcommac/ScrollStackController

daniele margutti

commit sha b8e3e59f60809bbaf8fa299e7e8b1dca5c10e425

Bump to 1.0.3

view details

push time in 4 days

push eventmalcommac/ScrollStackController

daniele margutti

commit sha 2f447b2c198cf55fa59394b1b45c618456674deb

#2 Fixed reloadContentFromStackView() called even at first layout

view details

daniele margutti

commit sha b7de9cccaf4b112aeee0abce72e82add71b73f70

#3 Added setRows() method

view details

daniele margutti

commit sha 049fa98d10979a14af3725038122e6911f7ce664

Fixed example

view details

push time in 4 days

issue openedmalcommac/ScrollStackController

Add setRows() to setup rows directly by removing the current ones

The following method should be useful to remove and set the new data.

    @discardableResult
    open func setRows(controllers: [UIViewController]) -> [ScrollStackRow] {
        removeAllRows(animated: false)
        return addRows(controllers: controllers)
    }

created time in 4 days

issue openedmalcommac/ScrollStackController

reloadContentFromStackView is called even at first setup

The method reloadContentFromStackView() is called even at the first layout of the data but it should be called only when user call explicit reload of the data into the controller.

created time in 4 days

starteddanielgindi/Charts

started time in 13 days

startedrecruit-mtl/Graphs

started time in 13 days

startediOS-Goodies/iOS-Goodies

started time in 18 days

release malcommac/Owl

1.1.1

released time in 20 days

push eventmalcommac/Owl

Taras Nikulin

commit sha ff1882279ded929d391ed74ef12107b41cac30a8

Default implementation for isContentEqual

view details

Daniele Margutti

commit sha 78fe88292b77ad66b7ef35db692de42facec4ddd

Merge tag '1.1.0' into develop 1.1.0

view details

Zdeněk Topič

commit sha f8bf4bc345f1fd10c1dbd26baeff3a1dba52fae2

Fix SPM to support iOS 10+ only

view details

Zdeněk Topič

commit sha 1caf1878243ed7e6fc99345f35b1f379fd671b86

Fix Package.swift

view details

Ciprian Redinciuc

commit sha 42ccfca94e7d9b06f3fb7bb7c0e1579ca21c98f7

Change CollectionHeaderFooterAdapter, TableSection and TableHeaderFooterAdapter classes from public to open for inherintance purposes

view details

Daniele Margutti

commit sha 4f3d94e20d6eb05436e57475617433e70728dc38

Merge pull request #41 from cyupa/master Change CollectionHeaderFooterAdapter, TableSection and TableHeaderFooterAdapter to open

view details

Daniele Margutti

commit sha ce4d03f5c45997671fe327548a071c9dd6713377

Merge pull request #40 from zdnk/fix-spm-ios Fix SPM iOS

view details

daniele margutti

commit sha 8a3e2457065b0d2bbe0bebd79f63cdd22e0bf959

Merge branch 'differentiable_default_behaviour' of https://github.com/crabman448/Owl into crabman448-differentiable_default_behaviour # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

view details

daniele margutti

commit sha 76e8d10e05ec2e215fe6c8f12c8bf6781baf797c

Merge branch 'crabman448-differentiable_default_behaviour' into develop # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

view details

daniele margutti

commit sha 37a5a2702d6b3c094434236a7ff0eab067a78e55

#38 Fixed crash with didEndDisplayCell both for Collection and Table directors. For these events model cannot be sent because it's not valid anymore (when removed its not part of the data source anymore). So these events are sent to the cell type without the model itself.

view details

daniele margutti

commit sha 1a362e3e2ae3d5e08f2b35e762012105ef824c47

#38 model property of the event (both for collection and cells) is now optional because it may be nil in certain situations (ie. didEndDisplayCell events)

view details

daniele margutti

commit sha 3a4e87d329ad35204ca3fc352a8d4683acc15b05

Added .DSStore to ignored items

view details

daniele margutti

commit sha dc8b5fb72af5b99f483d68602de4368723c26582

Bump to 1.1.1

view details

daniele margutti

commit sha 8fc18828554803e66ad1b33f15f2e7a9b3e01ee1

Merge branch 'release/1.1.1'

view details

push time in 20 days

created tagmalcommac/Owl

tag1.1.1

A declarative type-safe framework for building fast and flexible lists with UITableViews & UICollectionViews

created time in 20 days

push eventmalcommac/Owl

daniele margutti

commit sha 8fc18828554803e66ad1b33f15f2e7a9b3e01ee1

Merge branch 'release/1.1.1'

view details

daniele margutti

commit sha ec1e9afbbed5601e87e0792f1eea1ebdc8bf4958

Merge tag '1.1.1' into develop 1.1.1

view details

push time in 20 days

push eventmalcommac/Owl

daniele margutti

commit sha 3a4e87d329ad35204ca3fc352a8d4683acc15b05

Added .DSStore to ignored items

view details

daniele margutti

commit sha dc8b5fb72af5b99f483d68602de4368723c26582

Bump to 1.1.1

view details

push time in 20 days

issue closedmalcommac/Owl

Crash in didEndDisplaying cell call

Hi! I've just implemented this library into my app (the latest version) and it works great, except for one problem - it crashes during reload operations in the didEndDisplaying cell call.

The crash actually happens inside the let (model, adapter) = context(forItemAt: indexPath) call with the Index out of range error. What happens is that it is trying to access a cell that is no longer in that section.

This happens when I call reload with a new data model... The differences are - one cell gets moved from section 1 to section 2 (and needs to be reloaded), and the now top cell inside section 1 needs to be reloaded as well. Funny thing is that the update actually completes. The crash occurs after the completion handler is called (and I see cells finish moving correctly).

I temporarily solved this issue by adding this inside the didEndDisplaying cell function:

guard indexPath.section < sections.count, indexPath.row < sections[indexPath.section].elements.count else {
    return
}

This solves the problem, although I don't really think that this is the correct solution.

closed time in 20 days

r00li

issue commentmalcommac/Owl

Crash in didEndDisplaying cell call

I've fixed the bug but I need to make the element: Model property of the TableCellAdapter.Event and CollectionCellAdapter.Event optional because in these situations I can't get the model instance for removed items (previously I made an internal cache to keep these items floating around but frankly its a bit overkill and introduces several weak points). Thanks for reporting the issue.

r00li

comment created time in 20 days

push eventmalcommac/Owl

daniele margutti

commit sha 1a362e3e2ae3d5e08f2b35e762012105ef824c47

#38 model property of the event (both for collection and cells) is now optional because it may be nil in certain situations (ie. didEndDisplayCell events)

view details

push time in 20 days

push eventmalcommac/Owl

daniele margutti

commit sha 37a5a2702d6b3c094434236a7ff0eab067a78e55

#38 Fixed crash with didEndDisplayCell both for Collection and Table directors. For these events model cannot be sent because it's not valid anymore (when removed its not part of the data source anymore). So these events are sent to the cell type without the model itself.

view details

push time in 20 days

issue closedmalcommac/Owl

When intstalled with SPM it wont compiled

There are some @available errors that need to be resolved or defined platforms property in Package.swift

closed time in 20 days

zdnk

issue commentmalcommac/Owl

When intstalled with SPM it wont compiled

Fixed in 1.1.1

zdnk

comment created time in 20 days

PR closed malcommac/Owl

Make scroll events public

scrollEvents has an internal access level. Made it public to use. That won't warn user in a demo project, but happened to me, when I tried to use this library as a pod.

+19 -14

1 comment

2 changed files

AgapovOne

pr closed time in 20 days

PR merged malcommac/Owl

Default implementation for isContentEqual enhancement

I think it could be useful

+6 -0

0 comment

1 changed file

crabman448

pr closed time in 20 days

push eventmalcommac/Owl

Taras Nikulin

commit sha ff1882279ded929d391ed74ef12107b41cac30a8

Default implementation for isContentEqual

view details

daniele margutti

commit sha 8a3e2457065b0d2bbe0bebd79f63cdd22e0bf959

Merge branch 'differentiable_default_behaviour' of https://github.com/crabman448/Owl into crabman448-differentiable_default_behaviour # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

view details

daniele margutti

commit sha 76e8d10e05ec2e215fe6c8f12c8bf6781baf797c

Merge branch 'crabman448-differentiable_default_behaviour' into develop # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

view details

push time in 20 days

create barnchmalcommac/Owl

branch : crabman448-differentiable_default_behaviour

created branch time in 20 days

push eventmalcommac/Owl

Zdeněk Topič

commit sha f8bf4bc345f1fd10c1dbd26baeff3a1dba52fae2

Fix SPM to support iOS 10+ only

view details

Zdeněk Topič

commit sha 1caf1878243ed7e6fc99345f35b1f379fd671b86

Fix Package.swift

view details

Daniele Margutti

commit sha ce4d03f5c45997671fe327548a071c9dd6713377

Merge pull request #40 from zdnk/fix-spm-ios Fix SPM iOS

view details

push time in 20 days

PR merged malcommac/Owl

Fix SPM iOS bug

Fixes #39

+1 -0

0 comment

1 changed file

zdnk

pr closed time in 20 days

push eventmalcommac/Owl

Daniele Margutti

commit sha a0215bc2610fa090bcdc27922b19ab986ade61af

Update README.md

view details

Ciprian Redinciuc

commit sha 42ccfca94e7d9b06f3fb7bb7c0e1579ca21c98f7

Change CollectionHeaderFooterAdapter, TableSection and TableHeaderFooterAdapter classes from public to open for inherintance purposes

view details

Daniele Margutti

commit sha 4f3d94e20d6eb05436e57475617433e70728dc38

Merge pull request #41 from cyupa/master Change CollectionHeaderFooterAdapter, TableSection and TableHeaderFooterAdapter to open

view details

push time in 20 days

PR merged malcommac/Owl

Change CollectionHeaderFooterAdapter, TableSection and TableHeaderFooterAdapter to open bug enhancement

Change CollectionHeaderFooterAdapter, TableSection and TableHeaderFooterAdapter classes from public to open for inherintance purposes

+7 -5

0 comment

4 changed files

cyupa

pr closed time in 20 days

push eventmalcommac/SwiftLocation

Daniele Margutti

commit sha 883939c1c88f4cdfe432680348da24472c8ee348

Update README.md

view details

push time in a month

startedZeeZide/SwiftPMCatalog

started time in a month

release malcommac/SwiftLocation

4.2.0

released time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 379c8e8d85fa307832c4fdea1af389f7aa9fbdb5

Fix typo in read me about changed relaxed params in accuracy

view details

daniele margutti

commit sha 69b5750da61226a5a98140d27cdf5ef4d7465f14

Merge branch 'master' into develop

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 379c8e8d85fa307832c4fdea1af389f7aa9fbdb5

Fix typo in read me about changed relaxed params in accuracy

view details

push time in a month

created tagmalcommac/SwiftLocation

tag4.2.0

Efficient and easy to use location tracking / geocoding / autocomplete / iBeacon framework for iOS (CLLocationManager)

created time in a month

issue closedmalcommac/SwiftLocation

OneShot location request is not removed from queue after completing

Hi. I believe there should not be ! in comparison block. Can you confirm?

        for request in queueLocationRequests { // dispatch the error to any request
            let shouldRemove = !(request.subscription == .oneShot) // oneshot location will be removed in this case
            request.stop(reason: ErrorReason.errorReason(from: error), remove: shouldRemove)
        }

closed time in a month

abakhtin

push eventmalcommac/SwiftLocation

Alexey Bakhtin

commit sha afa7831e9fb0bcf424b32ebf6491ebefd81539a5

Add iBeacons monitoring request

view details

Alexey Bakhtin

commit sha ed037186a0eaf64ce8365ff5a94c0905682ba756

Improve exmaple for beacons

view details

Daniele Margutti

commit sha 92f44a08a087def69193b6ae54a69717ebe34967

Merge tag '4.1.0' into develop 4.1.0

view details

Alexey Bakhtin

commit sha 9a85dc3a1d878c9947a53f225c58aa35c2005ff9

Merge commit 'e1eb681a94ba338bc92c4b529369c4318797186f' * commit 'e1eb681a94ba338bc92c4b529369c4318797186f': Added swift-package tools to 5.x Fixed never executed statment Updated podspec Bump to 4.1.0 #248 Added documentation for dataFrequency #248 Added dataFrequency filter inside the LocationRequest object #252 Parsing of the place_id for OpenStreetMap in Place object (place_id) #261 Moved sources to Sources/SwiftLocation subdirectory to be compatible with Swift Package Manager #262 Added rawData property to get the raw JSON parsed from Place when using Google/OS services. Parsed place_id of Google Maps in identifier property. #263 GeocoderRequest.Options init() is now public # Conflicts: # SwiftLocation.xcodeproj/project.pbxproj

view details

Alexey Bakhtin

commit sha 19bd8b1c6aff249c1acf27e4c2779f394b92f1d3

Fix project file missing added file

view details

Alexey Bakhtin

commit sha c6f768215b0e734487b83dbb31eac43b03ad6265

Handle denied fail from CLLocationManager as ErrorReason.denied instead of generic error

view details

Alexey Bakhtin

commit sha 37a3a9e7d939d9380e77c9882a262b561e1295bd

Fix oneshot tracking to be removed after error in comleting

view details

Alexey Bakhtin

commit sha da445b40b33a21caadcd872ad077f82550481195

Add using last location for requests if there is any active continiose request

view details

Phong Le

commit sha 7df172906df6477644fb7194dd510e6fb763e412

Updated the minimum in the package

view details

Phong Le

commit sha 1d980f83d23399e508ba0d475edbfc120d103652

Corrected the minimum

view details

daniele margutti

commit sha 2ef201d3c7063de3082ab30501ff752cf1b33134

#265 Relaxing room and house parameters both for time and accuracy in meters

view details

daniele margutti

commit sha 068565fa4dc9691a72717136b481074773d3e84d

Removed wrong code in app delegate

view details

daniele margutti

commit sha 667f1ac09ac1be1c06e4e5a2838c6a307f7ccfb9

#272 Make init for AutoCompleteRequest.Options public

view details

Daniele Margutti

commit sha 3295770456ace03da5eda662b912409c0bcb775f

Merge pull request #274 from phongleq/master Added minimum version to SPM file

view details

daniele margutti

commit sha 0a7783b5b29aec78482c8feab4cef5305cf7077c

#267 Removed force unwrap in location tracking

view details

daniele margutti

commit sha 1765f99aa5c77da3987090f7702e56a17459b4bf

Merge branch 'develop' of https://github.com/malcommac/SwiftLocation into develop

view details

Daniele Margutti

commit sha b3dd98e0950eb3034a99789e8e12e077e562428e

Merge branch 'develop' into master

view details

Daniele Margutti

commit sha 371b9f0a57acaeae057dd6af6adc5883ee0b22bd

Merge pull request #266 from abakhtin/master Added support for iBeacons tracking

view details

daniele margutti

commit sha fb8b717117f38c4525a61d5d7e61eb280c4f6634

#266 Removed unused code from beacon request

view details

daniele margutti

commit sha ace5caa9932627a91b8acd3d7ee989dc29ace246

#267 Removed unused code from AppDelegate

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 0738a53d828ac3bede72b718af18a915ff1ed27d

Merge branch 'release/4.2.0'

view details

daniele margutti

commit sha eb6cc645501de08dfb1f4d874f04540dd917cc78

Merge tag '4.2.0' into develop 4.2.0

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 3b203f6ab8d9a308ef8918507d1a98538acd257a

Bump to 4.2.0

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 107149485312bcdd8b40dd175eff106329530d3d

#267 Minor changes to example of iBeacon doc

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha a46e15959b45194f136c30ab1cada7550b7e9c2b

#267 Fixed some typos in doc

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha fbb83deac58f713ba2bde56ad361f75f8cc53ce7

#267 Added documentation

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 580264ad315bf94242d1edbe2665bfd2b4a613eb

Added .DSStore in .gitignore

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 0f09bec1b46e346d51c96ea6875af657a5e426e3

#267 Added parametric proximity UUID input field

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 2f148a0398e15b970e1f5eae365b14d8a45c4a90

#267 Removed accuracy parameter for beacon which is not necessary

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha ace5caa9932627a91b8acd3d7ee989dc29ace246

#267 Removed unused code from AppDelegate

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha fb8b717117f38c4525a61d5d7e61eb280c4f6634

#266 Removed unused code from beacon request

view details

push time in a month

push eventmalcommac/SwiftLocation

Alexey Bakhtin

commit sha afa7831e9fb0bcf424b32ebf6491ebefd81539a5

Add iBeacons monitoring request

view details

Alexey Bakhtin

commit sha ed037186a0eaf64ce8365ff5a94c0905682ba756

Improve exmaple for beacons

view details

Alexey Bakhtin

commit sha 9a85dc3a1d878c9947a53f225c58aa35c2005ff9

Merge commit 'e1eb681a94ba338bc92c4b529369c4318797186f' * commit 'e1eb681a94ba338bc92c4b529369c4318797186f': Added swift-package tools to 5.x Fixed never executed statment Updated podspec Bump to 4.1.0 #248 Added documentation for dataFrequency #248 Added dataFrequency filter inside the LocationRequest object #252 Parsing of the place_id for OpenStreetMap in Place object (place_id) #261 Moved sources to Sources/SwiftLocation subdirectory to be compatible with Swift Package Manager #262 Added rawData property to get the raw JSON parsed from Place when using Google/OS services. Parsed place_id of Google Maps in identifier property. #263 GeocoderRequest.Options init() is now public # Conflicts: # SwiftLocation.xcodeproj/project.pbxproj

view details

Alexey Bakhtin

commit sha 19bd8b1c6aff249c1acf27e4c2779f394b92f1d3

Fix project file missing added file

view details

Alexey Bakhtin

commit sha c6f768215b0e734487b83dbb31eac43b03ad6265

Handle denied fail from CLLocationManager as ErrorReason.denied instead of generic error

view details

Alexey Bakhtin

commit sha 37a3a9e7d939d9380e77c9882a262b561e1295bd

Fix oneshot tracking to be removed after error in comleting

view details

Alexey Bakhtin

commit sha da445b40b33a21caadcd872ad077f82550481195

Add using last location for requests if there is any active continiose request

view details

Daniele Margutti

commit sha b3dd98e0950eb3034a99789e8e12e077e562428e

Merge branch 'develop' into master

view details

Daniele Margutti

commit sha 371b9f0a57acaeae057dd6af6adc5883ee0b22bd

Merge pull request #266 from abakhtin/master Added support for iBeacons tracking

view details

push time in a month

PR merged malcommac/SwiftLocation

Added support for iBeacons tracking bug enhancement

Hi,

  1. I added request for beacons tracking, improved example project to test it but not sure if quality of changes is enough for you to approve (a lot of copy paste in example)

  2. I fixed one strange issue for one shot location tracking: if user denied access - api returned generic error reason instead of ErrorReason.denied while application will be restarted.

Please let me know if I can improve this code to be merged.

Best Regards, AB

+914 -62

0 comment

10 changed files

abakhtin

pr closed time in a month

push eventabakhtin/SwiftLocation

Daniele Margutti

commit sha 92f44a08a087def69193b6ae54a69717ebe34967

Merge tag '4.1.0' into develop 4.1.0

view details

Phong Le

commit sha 7df172906df6477644fb7194dd510e6fb763e412

Updated the minimum in the package

view details

Phong Le

commit sha 1d980f83d23399e508ba0d475edbfc120d103652

Corrected the minimum

view details

daniele margutti

commit sha 2ef201d3c7063de3082ab30501ff752cf1b33134

#265 Relaxing room and house parameters both for time and accuracy in meters

view details

daniele margutti

commit sha 068565fa4dc9691a72717136b481074773d3e84d

Removed wrong code in app delegate

view details

daniele margutti

commit sha 667f1ac09ac1be1c06e4e5a2838c6a307f7ccfb9

#272 Make init for AutoCompleteRequest.Options public

view details

Daniele Margutti

commit sha 3295770456ace03da5eda662b912409c0bcb775f

Merge pull request #274 from phongleq/master Added minimum version to SPM file

view details

daniele margutti

commit sha 0a7783b5b29aec78482c8feab4cef5305cf7077c

#267 Removed force unwrap in location tracking

view details

daniele margutti

commit sha 1765f99aa5c77da3987090f7702e56a17459b4bf

Merge branch 'develop' of https://github.com/malcommac/SwiftLocation into develop

view details

Daniele Margutti

commit sha b3dd98e0950eb3034a99789e8e12e077e562428e

Merge branch 'develop' into master

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 0a7783b5b29aec78482c8feab4cef5305cf7077c

#267 Removed force unwrap in location tracking

view details

daniele margutti

commit sha 1765f99aa5c77da3987090f7702e56a17459b4bf

Merge branch 'develop' of https://github.com/malcommac/SwiftLocation into develop

view details

push time in a month

issue commentmalcommac/SwiftLocation

blue pill visible

According to Apple doc: When-in-use authorized apps will continue showing the Blue Bar as before. No other service will turn on the Blue Bar. When an app which makes use of any other location service receives an occasional update (for example Significant Location Change), the location arrow on the status bar will momentarily blink solid, but the Blue Bar will not appear.​

digitxo

comment created time in a month

issue commentmalcommac/SwiftLocation

OneShot location request is not removed from queue after completing

I've tried to replicate your issue:

r1 = LocationManager.shared.locateFromGPS(.oneShot, accuracy: .room) { data in
  print("New data: \(data)")
}
        
DispatchQueue.main.asyncAfter(deadline: .now() + 5) {
  print("stop \(LocationManager.shared.queueLocationRequests.count)") // 1 request, r1
  self.r1?.stop()
  print("Now \(LocationManager.shared.queueLocationRequests.count) requests") // 0 request
}

Request is removed successfully failure(SwiftLocation.LocationManager.ErrorReason.cancelled)

abakhtin

comment created time in a month

issue commentmalcommac/SwiftLocation

Remove Blue Bar when app is in background.

It's managed by the system. After iOS 11 update that blue bar is showing when app is running on the background. What you can do is, track user location when app is in the foreground. Check this.

arqambutt

comment created time in a month

issue closedmalcommac/SwiftLocation

SPM: XCode 11 only available in iOS 9 errors

I am using SwiftLocation in my app via the swift package manager.

image

I have XCode 11/Swift 5 with the deployment target set to 13.2

image

When I build I am getting multiple "only available in iOS 9+" errors

image

I have no idea why these errors are occurring because the minimum deployment target should be greater than iOS 9. This may not be an issue with SwiftLocation itself, but I wasn't sure where else to ask/look. Any help or advice on fixing this would be greatly appreciated.

closed time in a month

coffee-cup

issue commentmalcommac/SwiftLocation

SPM: XCode 11 only available in iOS 9 errors

Merged for 4.2.0 Thank you @phongleq

coffee-cup

comment created time in a month

push eventmalcommac/SwiftLocation

Phong Le

commit sha 7df172906df6477644fb7194dd510e6fb763e412

Updated the minimum in the package

view details

Phong Le

commit sha 1d980f83d23399e508ba0d475edbfc120d103652

Corrected the minimum

view details

Daniele Margutti

commit sha 3295770456ace03da5eda662b912409c0bcb775f

Merge pull request #274 from phongleq/master Added minimum version to SPM file

view details

push time in a month

PR merged malcommac/SwiftLocation

Added minimum version to SPM file bug

This should fix the minimum requirements error that pops up when adding the library through swift package manager.

Please add tag after merging.

+10 -0

0 comment

2 changed files

phongleq

pr closed time in a month

issue closedmalcommac/SwiftLocation

Relaxing the accuracy level (both for horizontal accuracy and received interval) for room and house

If I call

LocationManager.shared.locateFromGPS(.continous, accuracy: .block, activity: .otherNavigation) { result in
  ...
}

multiple times at different times, and I start location tracking on each handler, only the first receives updates. The 2nd start receiving updates only if the first one is stopped.

For this to happen, I delayed the 2nd call to locateFromGPS by 10 seconds (using DispatchQueue.main.asyncAfter())

If I replace .continous with .oneShot it works fine instead.

Is it supposed to work this way, or is it a bug?

closed time in a month

jeden

issue closedmalcommac/SwiftLocation

How can I create AutoCompleteRequest.Options instance if it does not have a public initialiser?

I'm trying to use LocationManager.shared.autocomplete function with .apple(AutoCompleteRequest.Options?) as a service. I want to provide a region option. But when I try to create this class, I get the error:

'AutoCompleteRequest.Options' initializer is inaccessible due to 'internal' protection level

I assume a workaround would be to create an AutoCompleteRequest.GoogleOptions and use it for .apple service.

closed time in a month

qizh

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 667f1ac09ac1be1c06e4e5a2838c6a307f7ccfb9

#272 Make init for AutoCompleteRequest.Options public

view details

push time in a month

issue closedmalcommac/SwiftLocation

LocationManager.shared.locateFromGPS never return success/failure completion

Similar to this bug: https://github.com/malcommac/SwiftLocation/issues/265

but when I call LocationManager.shared.locateFromGPS(.continous, accuracy: .house, activity: .fitness) I sometimes never get the success failure callback.

Might be an issue in 4.1.0

closed time in a month

eminisrafil

issue commentmalcommac/SwiftLocation

LocationManager.shared.locateFromGPS never return success/failure completion

See the #265 i'll close it.

eminisrafil

comment created time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 068565fa4dc9691a72717136b481074773d3e84d

Removed wrong code in app delegate

view details

push time in a month

push eventmalcommac/SwiftLocation

daniele margutti

commit sha 2ef201d3c7063de3082ab30501ff752cf1b33134

#265 Relaxing room and house parameters both for time and accuracy in meters

view details

push time in a month

issue commentmalcommac/SwiftLocation

First handler only receiving location updates when using `locateFromGPS` in `continous` mode

I tried to reproduce the issue but it seems to works fine:

   r1 = LocationManager.shared.locateFromGPS(.continous, accuracy: .block, activity: .otherNavigation) { result in
            print("#1 -> \(result)")
        }
        
        DispatchQueue.main.asyncAfter(deadline: .now() + 5) {
            self.r2 = LocationManager.shared.locateFromGPS(.continous, accuracy: .city, activity: .otherNavigation) { result in
                print("#2 -> \(result)")
            }
        }
        
        DispatchQueue.main.asyncAfter(deadline: .now() + 60) {
            self.r1?.stop()
            debugPrint("-----------------------------------> STOP FIRST")
        }

I can receive both r1 and r2 requests. I think the accuracy level house and room are to strict to be satisfied easily from the GPS receiver in normal conditions.

I've relaxed these parameters to the following levels:

for meters

public var value: CLLocationAccuracy {
            switch self {
            case .any:
                return CLLocationAccuracyAccuracyAny
            case .city:
                return 5000
            case .neighborhood:
                return 1000
            case .block:
                return 100
            case .house:
                return 60 // from 15 mt
            case .room:
                return 25 // from 5 mt
            case .custom(let value):
                return value
            }
        }

and interval:

  public var interval: TimeInterval {
            switch self {
            case .city:
                return 600.0
            case .neighborhood:
                return 300.0
            case .block:
                return 60.0
            case .house:
                return 40.0 // from 15secs
            case .room:
                return 20.0 // from 5secs
            default:
                return TimeInterval.greatestFiniteMagnitude
            }
        }

Since the next update.

jeden

comment created time in a month

issue commentmalcommac/SwiftRichString

Link Foreground color not changing.

Did you close it because it works?

sureshmopidevi

comment created time in a month

push eventmalcommac/CircularScroller

daniele margutti

commit sha 81ccf5c1c27026abe916f8e3106fdea3927469a7

Added shields for code

view details

push time in a month

push eventmalcommac/CircularScroller

daniele margutti

commit sha 494e09fea02d3eaa0b48ddf9fa8145ae6c0443f9

Working on readme

view details

push time in a month

push eventmalcommac/CircularScroller

daniele margutti

commit sha 55a3b74f345dafc9126141b508f7740e4ae88930

Project refactoring to support SwiftPM

view details

push time in a month

push eventmalcommac/DMCircularScrollView

Daniele Margutti

commit sha 2a3ce9caa7466946b009da102056ef7dbf675a66

Update README.md

view details

push time in a month

push eventmalcommac/CircularScroller

daniele margutti

commit sha 6453711ce81ce8d2a7bee68ee2b92a7044ea90f7

First stable release

view details

push time in a month

release malcommac/ScrollStackController

1.0.2

released time in a month

issue closedmalcommac/ScrollStackController

layoutSubviews() is called multiple times with no needs

ScrollStackRow class call layoutIfNeeded() multiple times even if value of the separatorAxis property is not changed.

   internal var separatorAxis: NSLayoutConstraint.Axis = .horizontal {
        didSet {
            didUpdateSeparatorViewContraintsIfNeeded()
            didUpdateSeparatorAxis()
            didUpdateSeparatorInsets()
            layoutIfNeeded()
        }
    }

closed time in a month

malcommac

created tagmalcommac/ScrollStackController

tag1.0.2

Create complex scrollable layout using UIViewControllers and simplify your code!

created time in a month

push eventmalcommac/ScrollStackController

Daniele Margutti

commit sha b98e5c8520b00444da3fb85ac6330c0dcedca7f3

Merge tag '1.0.1' into develop 1.0.1

view details

daniele margutti

commit sha 8e9b5662cdd12c0ba700717aa72704e6b4a47b50

Merge branch 'master' into develop

view details

daniele margutti

commit sha 877d09db24a15caf93b3470335d1ebbd3b98bb22

Bump to 1.0.2

view details

daniele margutti

commit sha 9ff8ba1a88138e9494eeba6169495f9ce1845aca

Merge branch 'release/1.0.2'

view details

push time in a month

push eventmalcommac/ScrollStackController

daniele margutti

commit sha 9ff8ba1a88138e9494eeba6169495f9ce1845aca

Merge branch 'release/1.0.2'

view details

daniele margutti

commit sha 66b279fc93eea0bfd3acd31de92087dfa86f4342

Merge tag '1.0.2' into develop 1.0.2

view details

push time in a month

push eventmalcommac/ScrollStackController

daniele margutti

commit sha 877d09db24a15caf93b3470335d1ebbd3b98bb22

Bump to 1.0.2

view details

push time in a month

push eventmalcommac/ScrollStackController

daniele margutti

commit sha 14564ba0b326582ba2480ee7c8b112841779f4a2

#1 Avoid layoutIfNeeded call for separatorAxis property on ScrollStackRow

view details

daniele margutti

commit sha 8e9b5662cdd12c0ba700717aa72704e6b4a47b50

Merge branch 'master' into develop

view details

push time in a month

push eventmalcommac/ScrollStackController

daniele margutti

commit sha 14564ba0b326582ba2480ee7c8b112841779f4a2

#1 Avoid layoutIfNeeded call for separatorAxis property on ScrollStackRow

view details

push time in a month

issue openedmalcommac/ScrollStackController

layoutSubviews() is called multiple times with no needs

ScrollStackRow class call layoutIfNeeded() multiple times even if value of the separatorAxis property is not changed.

   internal var separatorAxis: NSLayoutConstraint.Axis = .horizontal {
        didSet {
            didUpdateSeparatorViewContraintsIfNeeded()
            didUpdateSeparatorAxis()
            didUpdateSeparatorInsets()
            layoutIfNeeded()
        }
    }

created time in a month

startedrhazdon/hugo-theme-hello-friend-ng

started time in a month

issue commentmac-cain13/R.swift

Disable generation for certain groups of resources

thank you it works perfectly.

Did you also know how can I use R.swift with a pod library?

Let me explain; our app is composed by several frameworks linked as local pods. One of them is the *UI framework and contains several xcassets and fonts. I should run the script on that pod / podspec and produced R.generated must be linked into the pods source. Is this a scenario supported by R.swift?

thanks.

malcommac

comment created time in a month

issue openedmac-cain13/R.swift

Disable certain groups of resources

Is possible to avoid generation of certain group of files? I'm interested only in images and fonts but I don't know how to disable other file types. Thanks

created time in a month

startedalbertodebortoli/JustLog

started time in 2 months

startedalbertodebortoli/Stateful

started time in 2 months

more