mal ( Mal Graty )

ZeroDivisionError in CDD when setting mesh on a Placeholder

This was encountered while trying to reproduce something that turns out to be an invalid use-case, but might impact another case that is valid.

define config.gl2 = True

label main_menu:
    $ _confirm_quit = False
    return

label start:
    scene
    if True:
        show bad
    else:
        show good
    pause
    return

init python:
    class GoodExample(renpy.display.core.Displayable):
        def render(self, width, height, st, at):
            rv = renpy.render(Placeholder('girl'), width, height, st, at)
            return rv

    class BadExample(renpy.display.core.Displayable):
        def render(self, width, height, st, at):
            rv = renpy.render(Placeholder('girl'), width, height, st, at)
            rv.mesh = True
            return rv

image good = GoodExample()
image bad = BadExample()

</details> <details><summary>Stack trace</summary>

Full traceback:
  File "game/script.rpy", line 13, in script
    pause
  File ".../renpy-nightly-2020-10-14-c8f1f20b5-sdk/renpy/ast.py", line 1955, in execute
    self.call("execute")
  File ".../renpy-nightly-2020-10-14-c8f1f20b5-sdk/renpy/ast.py", line 1943, in call
    return renpy.statements.call(method, parsed, *args, **kwargs)
  File ".../renpy-nightly-2020-10-14-c8f1f20b5-sdk/renpy/statements.py", line 278, in call
    return method(parsed, *args, **kwargs)
  File "renpy/common/000statements.rpy", line 439, in execute_pause
    renpy.pause()
  File ".../renpy-nightly-2020-10-14-c8f1f20b5-sdk/renpy/exports.py", line 1489, in pause
    rv = renpy.ui.interact(mouse='pause', type='pause', roll_forward=roll_forward)
  File ".../renpy-nightly-2020-10-14-c8f1f20b5-sdk/renpy/ui.py", line 298, in interact
    rv = renpy.game.interface.interact(roll_forward=roll_forward, **kwargs)
  File ".../renpy-nightly-2020-10-14-c8f1f20b5-sdk/renpy/display/core.py", line 2885, in interact
    repeat, rv = self.interact_core(preloads=preloads, trans_pause=trans_pause, **kwargs)
  File ".../renpy-nightly-2020-10-14-c8f1f20b5-sdk/renpy/display/core.py", line 3384, in interact_core
    self.draw_screen(root_widget, fullscreen_video, (not fullscreen_video) or video_frame_drawn)
  File ".../renpy-nightly-2020-10-14-c8f1f20b5-sdk/renpy/display/core.py", line 2308, in draw_screen
    renpy.display.draw.draw_screen(surftree)
  File "gl2draw.pyx", line 806, in renpy.gl2.gl2draw.GL2Draw.draw_screen
  File "gl2draw.pyx", line 863, in renpy.gl2.gl2draw.GL2Draw.load_all_textures
  File "gl2draw.pyx", line 863, in renpy.gl2.gl2draw.GL2Draw.load_all_textures
  File "gl2draw.pyx", line 863, in renpy.gl2.gl2draw.GL2Draw.load_all_textures
  File "gl2draw.pyx", line 863, in renpy.gl2.gl2draw.GL2Draw.load_all_textures
  File "gl2draw.pyx", line 863, in renpy.gl2.gl2draw.GL2Draw.load_all_textures
  File "gl2draw.pyx", line 876, in renpy.gl2.gl2draw.GL2Draw.load_all_textures
  File "gl2draw.pyx", line 906, in renpy.gl2.gl2draw.GL2Draw.render_to_texture
  File "gl2texture.pyx", line 200, in renpy.gl2.gl2texture.TextureLoader.render_to_texture
  File "gl2texture.pyx", line 317, in renpy.gl2.gl2texture.GLTexture.from_render
  File "matrix.pyx", line 384, in renpy.display.matrix.Matrix.ctexture_projection
  File "matrix_functions.pxi", line 101, in renpy.display.matrix.texture_projection_matrix
ZeroDivisionError: float division

</details>

Test cases used renpy-nightly-2020-10-14-c8f1f20b5-sdk.

created time in 9 days

issue commentrenpy/renpy

CDD meshes in image buttons

Thanks, Tom! 🎉

mal

comment created time in 9 days

issue openedrenpy/renpy

CDD meshes in image buttons

I'm not sure if this is a bug, an error on my part or simple an unsupported use case.

The synopsis is that the game sometimes throws an exception when using a CDD which is using a tex1 and mesh = True in an transformative image button.

The test case below the fold sets up a Render with two squares, the second a quarter the size of the first. It then applies the renpy.dissolve shader (this is purely for the test case because it uses tex1 - the internals of the shader don't matter.) It then displays this on a screen, once via add and once as the child of an image button which brightens on mouseover.

For some reason when using mesh = True the if the mouse touches the button outside the bounds of the smaller square an exception is thrown. The correct and expected behaviour can be observed by explicitly creating the Mesh object, rather than using True.

Notes:

That the two square textures are different sizes should pose no issue since they are sampled in the range of 0-1, and indeed this is exactly what happens when the Mesh2 object is provided.
When using focus_mask True with textures derived from images, the highlight appears to activate when the mouse passes over opaque pixels in the secondary (smaller) texture without it having been scaled by the shader.

define config.gl2 = True

label main_menu:
    $ _confirm_quit = False
    return

label start:
    scene
    show screen example()
    "This is the same CDD."
    "The one on the left has just been added to a screen. This is fine."
    "The one on the right is an image button."
    "It has a highlight effect on mouse over."
    "While the mouse stays in the upper left quarter, things appear fine."
    "Moving the mouse to other parts of the shape throw."
    "The \"good\" area is determined by the pixel size of tex1."
    "This only occurs when using Render.mesh = True."
    "Using Render.mesh = Mesh2 does not encounter this issue. See test-case."
    "Fin."
    return

init python:
    class Example(renpy.display.core.Displayable):
        def __init__(self, **properties):
            super(Example, self).__init__(**properties)
            self.child = Solid('f00', xysize=(200, 200))
            self.other = Solid('0f0', xysize=(100, 100))

        def render(self, width, height, st, at):
            child = renpy.render(self.child, width, height, st, at)
            rv = renpy.Render(child.width, child.height)
            rv.blit(child, (0, 0))

            other = renpy.render(self.other, width, height, st, at)
            rv.blit(other, (0, 0), focus=False, main=False)

            # THIS WORKS
            rv.mesh = renpy.gl2.gl2mesh2.Mesh2.texture_rectangle(
                0, 0, child.width, child.height,
                0, 0, 1, 1)

            # THIS DOES NOT - COMMENT OUT FOR WORKING VERSION
            rv.mesh = True

            # Arbitrary shader that requires tex1
            rv.add_shader("renpy.dissolve")
            rv.add_uniform("u_renpy_dissolve", .5)

            return rv

        def visit(self):
            return [self.child, self.other]

image foo = Example(pos=(-10, -10))

define bright = BrightnessMatrix(.1)

transform highlight:
    on idle:
        matrixcolor None
    on hover:
        matrixcolor bright

screen example():
    add 'foo':
        align .25, .5

    imagebutton:
        align .75, .5
        at highlight
        focus_mask True
        idle 'foo'
        action Return()

</details>

Test cases used renpy-nightly-2020-10-12-03b0d8a2e-sdk but was seeing this back in September too, have only just had a chance to investigate and write up.

created time in 11 days

push eventidio/hubot-idio

Mal Graty

commit sha d4042b87f3b08e9b38b6b444b11e2ba969879e4d

Bump and apply dev tag at spin-time

Describe the Enhancement

Describe the Need

Current Alternative

Can We Help You Implement This?