profile
viewpoint

jedrichards/rsyncwrapper 113

An async wrapper to the rsync command line utility for Node.js

m-allanson/gatsby-plugin-module-local-ident-name 2

Adds support for specifying CSS Modules classnames in Gatsby's development mode

m-allanson/dotfiles 1

My dotfiles for macOS

m-allanson/brewpi-setup 0

My notes on setting up a BrewPi

m-allanson/chrome_guardian_mobile 0

Chrome Extension to redirect www.guardian.co.uk urls to m.guardian.co.uk

startedmoufette-tools/moufette

started time in 15 hours

delete branch stylelint/stylelint-demo

delete branch : dependabot/npm_and_yarn/elliptic-6.5.3

delete time in 6 days

push eventstylelint/stylelint-demo

dependabot-preview[bot]

commit sha 5f20e9615f091a8b73732c75cd93aa5f6b471b57

[Security] Bump elliptic from 6.5.2 to 6.5.3 (#225) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. **This update includes a security fix.** - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 6 days

PR merged stylelint/stylelint-demo

[Security] Bump elliptic from 6.5.2 to 6.5.3 pr: dependencies security

Bumps elliptic from 6.5.2 to 6.5.3. This update includes a security fix. <details> <summary>Vulnerabilities fixed</summary> <p><em>Sourced from <a href="https://github.com/advisories/GHSA-vh7m-p724-62c2">The GitHub Security Advisory Database</a>.</em></p> <blockquote> <p><strong>Signature Malleabillity in elliptic</strong> The Elliptic package before version 6.5.3 for Node.js allows ECDSA signature malleability via variations in encoding, leading '\0' bytes, or integer overflows. This could conceivably have a security-relevant impact if an application relied on a single canonical signature.</p> <p>Affected versions: < 6.5.3</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/indutny/elliptic/commit/8647803dc3d90506aa03021737f7b061ba959ae1"><code>8647803</code></a> 6.5.3</li> <li><a href="https://github.com/indutny/elliptic/commit/856fe4d99fe7b6200556e6400b3bf585b1721bec"><code>856fe4d</code></a> signature: prevent malleability and overflows</li> <li>See full diff in <a href="https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+6 -6

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 6 days

delete branch madebycomrades/madebycomrades.github.io

delete branch : mike/update-bio

delete time in 6 days

push eventmadebycomrades/madebycomrades.github.io

m-allanson

commit sha 0b99f752838e618d82871184ed65d5b245fbc38d

Update bio text

view details

m-allanson

commit sha 8b1bb55562915f984f54a8ae14700ce57635279b

Use a photo that's only two years old

view details

Mike Allanson

commit sha 17bbbe85a6dc8a873523b40a7e084156a1300f0c

Merge pull request #54 from madebycomrades/mike/update-bio Update bio

view details

push time in 6 days

create barnchmadebycomrades/madebycomrades.github.io

branch : mike/update-bio

created branch time in 6 days

push eventstylelint/stylelint

Masafumi Koba

commit sha 909063d307b22b35d28faf48a965cdbf08150bb6

Replace 3rd-party type definitions (#4857) * Replace 3rd-party type definitions This change replaces 3rd-party type definitions under the `types/` directory with the following `@types/*` npm packages. - [@types/balanced-match](https://www.npmjs.com/package/@types/balanced-match) - [@types/imurmurhash](https://www.npmjs.com/package/@types/imurmurhash) - [@types/postcss-safe-parser](https://www.npmjs.com/package/@types/postcss-safe-parser) - [@types/style-search](https://www.npmjs.com/package/@types/style-search) - [@types/svg-tags](https://www.npmjs.com/package/@types/svg-tags) - [@types/write-file-atomic](https://www.npmjs.com/package/@types/write-file-atomic) Note that this change does **not** replace all type definitions under `types/`. We should address the remaining types via other pull requests. Related to #4399 * Replace with `@types/file-entry-cache`

view details

m-allanson

commit sha 32a9a8b623663c7f86b61a55e0150326f0e970df

eslint was not happy

view details

dependabot-preview[bot]

commit sha 5a942941920b3aa99a81f5ac6385bf5b0bd492ca

Bump lodash from 4.17.15 to 4.17.19 (#4864) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Masafumi Koba

commit sha cecacb9d4fe3b5bae5f264efa6e60c414a0f4946

Remove `postcss-reporter` package (#4858) * Remove `postcss-reporter` package This change removes the `postcss-reporter` package and reduces the dependencies. As you see the changed `package-lock.json`, this package depends on: - `chalk` - `lodash` - `log-symbols` - `postcss` See also https://github.com/stylelint/stylelint/issues/2454#issuecomment-622604821 We've used only the tiny utility function `getLocation()` in the package. This function just returns an object with the `line` and `column` property in our project, so I think we can replace it with a simple code. https://github.com/postcss/postcss-reporter/blob/f01a601ea2cd41d626e561969d66a765b3afcb2d/lib/util.js#L4-L13 * Fix test name: `stringFormatter` -> `verboseFormatter`

view details

dependabot-preview[bot]

commit sha c935d0ac6538e7e4999b17b68a18ef0fe71851f5

Bump @types/lodash from 4.14.155 to 4.14.157 (#4869) Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.155 to 4.14.157. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Matt Wang

commit sha cba8dcfa4ff3a5733016c34007cb64a19d863662

Fix false negatives for where, is, nth-child and nth-last-child in selector-max-* (except selector-max-type) (#4842) * updates keywordSets * replaces functionality of isLogicalCombination with isContextFunctionalPseudoClass note: possible logic error in selector-max-type, will investigate further * adds a check for nonstandard syntax type selectors to selector-max-type * Apply suggestions from code review minor documentation fixes! Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com> Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

view details

Mike Allanson

commit sha ac0519d65847c719dc04f53c584ec7f82f3720d2

Update CHANGELOG.md

view details

m-allanson

commit sha 56ff536581a43042b54e351911469f49ba665450

Merge branch 'master' into browser-bundle * master: Update CHANGELOG.md Fix false negatives for where, is, nth-child and nth-last-child in selector-max-* (except selector-max-type) (#4842) Bump @types/lodash from 4.14.155 to 4.14.157 (#4869) Remove `postcss-reporter` package (#4858) Bump lodash from 4.17.15 to 4.17.19 (#4864) Replace 3rd-party type definitions (#4857)

view details

push time in 12 days

PR opened stylelint/stylelint

Add missing newline to CLI error output

<!-- Each pull request must be associated with an open issue unless it's a documentation fix. If a corresponding issue does not exist, please create one so we can discuss the change first. -->

<!-- Please answer the following. We close pull requests that don't. -->

Which issue, if any, is this issue related to?

Closes #4862

Is there anything in the PR that needs further explanation?

No, it's self-explanatory

+1 -1

0 comment

1 changed file

pr created time in 13 days

push eventstylelint/stylelint

m-allanson

commit sha 444662b6c67a8ca5b8b393200ef87138b2daa64a

Add missing newline

view details

push time in 13 days

create barnchstylelint/stylelint

branch : cli-newlines

created branch time in 13 days

issue commentstylelint/stylelint

CLI errors do not have trailing newlines

The files should use either console or process.x.write functions consistently. I don't have a strong opinion on which approach is best.

However, some of the messages already contain ending newlines (e.g. checkInvalidCLIOptions() returns a string with ending newlines). So in this case the simplest change is to manually add newlines. I think that should be good enough for now.

getsnoopy

comment created time in 13 days

startedvlang/v

started time in 13 days

Pull request review commentstylelint/stylelint

Autofix for *-no-vendor rules

 testRule({ 		{ 			code: '@media (device-pixel-ratio: 2) {}', 		},+		{+			code: '@media (min-device-pixel-ratio: 2) {}',+		}, 	],  	reject: [ 		{ 			code: '@media (-webkit-min-device-pixel-ratio: 1) {}',+			fixed: '@media (min-device-pixel-ratio: 1) {}', 			message: messages.rejected, 			line: 1, 			column: 9, 		}, 		{ 			code: '@media (-wEbKiT-mIn-DeViCe-PiXeL-rAtIo: 1) {}',+			fixed: '@media (mIn-DeViCe-PiXeL-rAtIo: 1) {}', 			message: messages.rejected, 			line: 1, 			column: 9, 		}, 		{ 			code: '@media (-WEBKIT-MIN-DEVICE-PIXEL-RATIO: 1) {}',+			fixed: '@media (MIN-DEVICE-PIXEL-RATIO: 1) {}', 			message: messages.rejected, 			line: 1, 			column: 9, 		}, 		{ 			code: '@media\n\t(min--moz-device-pixel-ratio: 1) {}',+			fixed: '@media\n\t(min-device-pixel-ratio: 1) {}', 			message: messages.rejected, 			line: 2,-			column: 3,+			column: 6,

What has caused the column to change?

yepninja

comment created time in 13 days

push eventshirotech/stylelint

m-allanson

commit sha 4f1f67ccf92e0ded1c511e9ee310864f97304643

Fix test Test should have a unit, as it should check that the unit-ed zero is ignored.

view details

push time in 13 days

pull request commentstylelint/stylelint

Fix false negatives for where, is, nth-child and nth-last-child in selector-max-* (except selector-max-type)

Updated changelog:

  • Fixed: false negatives for where, is, nth-child and nth-last-child in selector-max-* rules (except selector-max-type) (#4842).
malsf21

comment created time in 13 days

push eventstylelint/stylelint

Mike Allanson

commit sha ac0519d65847c719dc04f53c584ec7f82f3720d2

Update CHANGELOG.md

view details

push time in 13 days

PR merged stylelint/stylelint

Fix false negatives for where, is, nth-child and nth-last-child in selector-max-* (except selector-max-type)

<!-- Each pull request must be associated with an open issue unless it's a documentation fix. If a corresponding issue does not exist, please create one so we can discuss the change first. -->

Hey,

This is a PR to address a concern brought up in #4836. As suggested, I

  1. Pulled is, not, matches and has out of this set and into a new logicalCombinationsPseudoClasses set.
  2. Added where to this set.
  3. Pulled nth-child and nth-last-child out of this set and into a new aNPlusBOfSNotationPseudoClasses set (note the extra OfS).
  4. Renamed isLogicalCombination to isContextFunctionalPseudoClass, and replace the switch with requiring the two new sets and checking for a match.

In addition, I also

  1. Updated the set union pseudoClasses to contain our new keyword sets
  2. Changed the tests for isContextFunctionalPseudoClass from the ones in isLogicalCombination
  3. Updated isStandardSyntaxTypeSelector to also check for aNPlusBOfSNotationPseudoClasses, as it previously relied on nth-child and nth-last-child being in aNPlusBNotationPseudoClasses
  4. Added a check for !isStandardSyntaxTypeSelector in selector-max-type

~In general, it seems like everything works as intended; however, I noticed that we now fail the tests for selector-max-type, and in particular those involving nth-child and nth-last-child - I think it might be incorrectly recognizing n or tokens involving n as a type selector, but I'm not entirely sure. It also might be that we would want to preserve the original behaviour of isLogicalCombination in this case. I've spent a few days wiggling things around, but I think my unfamiliarity with the implementation of selector-max-type is hindering me. Would love to get feedback on this!~

~Until then, I'm marking this PR as a draft.~

<!-- Please answer the following. We close pull requests that don't. -->

Which issue, if any, is this issue related to?

Closes #4836.

Is there anything in the PR that needs further explanation?

Don't think so!

+101 -85

6 comments

12 changed files

malsf21

pr closed time in 13 days

push eventstylelint/stylelint

Matt Wang

commit sha cba8dcfa4ff3a5733016c34007cb64a19d863662

Fix false negatives for where, is, nth-child and nth-last-child in selector-max-* (except selector-max-type) (#4842) * updates keywordSets * replaces functionality of isLogicalCombination with isContextFunctionalPseudoClass note: possible logic error in selector-max-type, will investigate further * adds a check for nonstandard syntax type selectors to selector-max-type * Apply suggestions from code review minor documentation fixes! Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com> Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

view details

push time in 13 days

issue closedstylelint/stylelint

Fix false negatives for where, is, nth-child and nth-last-child in selector-max-*

<!-- Please answer the following. We close issues that don't. -->

Clearly describe the bug

As discussed in issue #4619, it seems like the isLogicalCombination utility doesn't cover all the available functional pseudo-classes that provide evaluation contexts; in particular, as this demo indicates, it fails to properly peek inside of:

  • :where()
  • :is()
  • :nth-child()
  • :nth-last-child()

Which are all examples of functional pseudo-classes mentioned in the CSS W3C draft linked above. These all adversely impact the selector-max-id rule, among other possible rules that use the utility as well; for selector-max-id, it creates a false negative if an id selector is within these pseudo-classes.

In addition, peeking at the W3Schools page for pseudo-classes also lists :lang(), :nth-of-type(), and :nth-last-of-type() as possible options which are currently unsupported by the util, however they fall out of the direct use case with selector-max-id.

Which rule, if any, is the bug related to?

Issue with util/isLogicalCombination; directly related to selector-max-id.

What code is needed to reproduce the bug?

As indicated in the demo,

e.g.

a:where(#foo) {}
a:is(em, #foo) {}
a:nth-child(even of #foo) {}
a:nth-last-child(even of #foo) {}

What stylelint configuration is needed to reproduce the bug?

As indicated in the demo,

e.g.

{
  "rules": {
   "selector-max-id": 0
  }
}

Which version of stylelint are you using?

Latest (13.6.1)

How are you running stylelint: CLI, PostCSS plugin, Node.js API?

Indifferent.

Does the bug relate to non-standard syntax (e.g. SCSS, Less etc.)?

No.

What did you expect to happen?

Warnings to be flagged on each use of #foo.

What actually happened (e.g. what warnings or errors did you get)?

No warnings were flagged.

<!-- Before posting, please check that the bug hasn't already been:

  • fixed in the next release (https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md)
  • discussed previously (https://github.com/stylelint/stylelint/search)

You can help us fix the bug more quickly by:

  1. Figuring out what needs doing and proposing it.
  2. Writing the code and submitting a PR once the bug is confirmed. -->

As @jeddy3 mentions in #4619, the solution would involve editing the following switch-case:

https://github.com/stylelint/stylelint/blob/58aab8def87fdceec4bbc4e87591892def144025/lib/utils/isLogicalCombination.js#L9-L22

If this is a good assessment of the issue, I'd be more than happy to quickly update the library and resulting tests. Let me know if I'm either missing any pseudo-classes or proposing an inefficient solution!

closed time in 13 days

malsf21

issue commentstylelint/stylelint

Release 13.7.0

Perhaps we should revert to a deprecate and remove approach, even if that means everyone will need to update and publish new configs to avoid the deprecation warnings.

I think this is probably the neatest approach in the long run.

jeddy3

comment created time in 13 days

pull request commentstylelint/stylelint

Fix false positives for trailing combinator in selector-combinator-space-after

I may close this PR and re-open it with new changes.

That's often the quickest way to fix these sorts of things 😅.

I think it's because I cloned into my fork's master

Feel free to clone stylelint/stylelint and create branches straight from this repo instead of your fork. Though I sometimes prefer working from a forked repo too.

Give me a moment to test things out!

Absolutely, no rush.

malsf21

comment created time in 13 days

pull request commentstylelint/stylelint

Fix TypeError for custom properties fallback in length-zero-no-unit

I've updated this and added a couple of tests. It should be ok for review now.

@shirotech the ignore: ["custom-properties"] option will ignore constructs like:

a { --x: 0px; }

It doesn't handle var functions like:

font: var(--foo, normal normal 400 16px/0 cursive);

I'd recommend opening a separate issue to talk about the custom-properties option.

shirotech

comment created time in 13 days

Pull request review commentstylelint/stylelint

Fix TypeError for custom properties fallback in length-zero-no-unit

 function rule(actual, secondary, context) { 			const ignorableIndexes = new Array(stringValue.length).fill(false); 			const parsedValue = valueParser(stringValue); -			parsedValue.walk((node, nodeIndex) => {+			parsedValue.walk((node, nodeIndex, nodes) => { 				if (decl.prop.toLowerCase() === 'font' && node.type === 'div' && node.value === '/') {-					const lineHeightNode = parsedValue.nodes[nodeIndex + 1];+					const lineHeightNode = nodes[nodeIndex + 1];

When descending into functions, the nodes array will be scoped to the current function args. This is the array that nodeIndex refers to. See the postcss-value-parser docs for details.

e.g., to parse the value font: var(--foo, normal normal 400 16px/0 cursive);, the value parser will run two loops.

The outer loop operates on the following nodes (equivalent to parsedValue.nodes):

[
      { type: 'word', sourceIndex: 0, value: 'font' },
      { type: 'div', sourceIndex: 4, value: ':', before: '', after: ' ' },
      {
        type: 'function',
        sourceIndex: 6,
        value: 'var',
        before: '',
        after: '',
        nodes: [
          [Object], [Object],
          [Object], [Object],
          [Object], [Object],
          [Object], [Object],
          [Object], [Object],
          [Object], [Object],
          [Object]
        ]
      }

The inner loop (equivalent to parsedValue.nodes[2].nodes) runs on the following values:

[
      { type: 'word', sourceIndex: 10, value: '--foo' },
      { type: 'div', sourceIndex: 15, value: ',', before: '', after: ' ' },
      { type: 'word', sourceIndex: 17, value: 'normal' },
      { type: 'space', sourceIndex: 23, value: ' ' },
      { type: 'word', sourceIndex: 24, value: 'normal' },
      { type: 'space', sourceIndex: 30, value: ' ' },
      { type: 'word', sourceIndex: 31, value: '400' },
      { type: 'space', sourceIndex: 34, value: ' ' },
      { type: 'word', sourceIndex: 35, value: '16px' },
      { type: 'div', sourceIndex: 39, value: '/', before: '', after: '' },
      { type: 'word', sourceIndex: 40, value: '0' },
      { type: 'space', sourceIndex: 41, value: ' ' },
      { type: 'word', sourceIndex: 42, value: 'cursive' }
    ]

Using nodes here means we can pick the right node with nodes[nodeIndex+1].

shirotech

comment created time in 13 days

push eventshirotech/stylelint

m-allanson

commit sha e7e3583f3bf13c60f869f3b7f3b6877c6d4092a7

Fix lineheight detection within function args

view details

push time in 13 days

delete branch stylelint/stylelint

delete branch : patch-1

delete time in 13 days

create barnchstylelint/stylelint

branch : patch-1

created branch time in 13 days

pull request commentstylelint/stylelint

Fix false positives for trailing combinator in selector-combinator-space-after

@malsf21 it looks like something has gone wonky with the PR, it's showing 131 changed files. Most of them are changes that have already been merged.

I'm guessing it's caused by the way GitHub doesn't track changes on the target branch after the PR is opened. There are some suggested fixes here: https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch

malsf21

comment created time in 14 days

push eventstylelint/stylelint

dependabot-preview[bot]

commit sha c935d0ac6538e7e4999b17b68a18ef0fe71851f5

Bump @types/lodash from 4.14.155 to 4.14.157 (#4869) Bumps [@types/lodash](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/lodash) from 4.14.155 to 4.14.157. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

push time in 14 days

delete branch stylelint/stylelint

delete branch : dependabot/npm_and_yarn/types/lodash-4.14.157

delete time in 14 days

PR merged stylelint/stylelint

Bump @types/lodash from 4.14.155 to 4.14.157 pr: dependencies

Bumps @types/lodash from 4.14.155 to 4.14.157. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/lodash">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+4 -4

0 comment

2 changed files

dependabot-preview[bot]

pr closed time in 14 days

delete branch stylelint/stylelint-demo

delete branch : dependabot/npm_and_yarn/lodash-4.17.19

delete time in 18 days

push eventstylelint/stylelint-demo

dependabot[bot]

commit sha 83693ef1bfe5caeb74f40a83330bc4f2eed7287d

Bump lodash from 4.17.15 to 4.17.19 (#224) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 18 days

PR merged stylelint/stylelint-demo

Bump lodash from 4.17.15 to 4.17.19 pr: dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 18 days

push eventstylelint/stylelint

Masafumi Koba

commit sha cecacb9d4fe3b5bae5f264efa6e60c414a0f4946

Remove `postcss-reporter` package (#4858) * Remove `postcss-reporter` package This change removes the `postcss-reporter` package and reduces the dependencies. As you see the changed `package-lock.json`, this package depends on: - `chalk` - `lodash` - `log-symbols` - `postcss` See also https://github.com/stylelint/stylelint/issues/2454#issuecomment-622604821 We've used only the tiny utility function `getLocation()` in the package. This function just returns an object with the `line` and `column` property in our project, so I think we can replace it with a simple code. https://github.com/postcss/postcss-reporter/blob/f01a601ea2cd41d626e561969d66a765b3afcb2d/lib/util.js#L4-L13 * Fix test name: `stringFormatter` -> `verboseFormatter`

view details

push time in 19 days

PR merged stylelint/stylelint

Remove `postcss-reporter` package

<!-- Each pull request must be associated with an open issue unless it's a documentation fix. If a corresponding issue does not exist, please create one so we can discuss the change first. -->

<!-- Please answer the following. We close pull requests that don't. -->

Which issue, if any, is this issue related to?

Related to #2454

Is there anything in the PR that needs further explanation?

This change removes the postcss-reporter package and reduces the dependencies. As you see the changed package-lock.json, this package depends on:

  • chalk
  • lodash
  • log-symbols
  • postcss

See also https://github.com/stylelint/stylelint/issues/2454#issuecomment-622604821

We've used only the tiny utility function getLocation() in the package. This function just returns an object with the line and column property in our project, so I think we can replace it with a simple code.

https://github.com/postcss/postcss-reporter/blob/f01a601ea2cd41d626e561969d66a765b3afcb2d/lib/util.js#L4-L13

+4 -41

1 comment

5 changed files

ybiquitous

pr closed time in 19 days

issue commentstylelint/stylelint

Fix no files matching the pattern error square brackets and dash

@reumia I think the first workaround should handle this? It's also one of the success cases that you originally described.

e.g. with the following directory structure:

.
└── pages/
    ├── [channelName]/
    │   ├── styles.scss
    │   └── util.scss
    └── foo/
        ├── styles.scss
        └── util.scss

This should lint all four files:

stylelint "./pages/**/*.scss"

I'm not so familiar with lint-staged, but it looks like there are some similar workarounds on this thread: https://github.com/okonet/lint-staged/issues/676

reumia

comment created time in 19 days

Pull request review commentstylelint/stylelint

Fix some path / glob problems

+'use strict';++/* eslint-disable node/no-extraneous-require */++const describe = require('@jest/globals').describe;+const expect = require('@jest/globals').expect;+const it = require('@jest/globals').it;++/* eslint-enable */++const path = require('path');+const replaceBackslashes = require('../testUtils/replaceBackslashes');+const standalone = require('../standalone');++const fixturesPath = replaceBackslashes(path.join(__dirname, 'fixtures', 'globs'));++// Tests for https://github.com/stylelint/stylelint/issues/4521++describe('standalone globbing', () => {+	describe('paths with special characters', () => {+		// ref https://github.com/micromatch/micromatch#matching-features+		const fixtureDirs = [+			`[digit]/not-digits`,+			`with spaces`,+			`extglob!(s)`,+			`got!negate/negate`,+			// `extglob+(s)`, // Note: +'s cause errors. Ignoring until it becomes a problem

Ah, I should have made a note of it. The + seemed to be escaped differently for this case, causing the expected match to fail.

I can't remember the specific details, but I think I tracked it down to somewhere in one of globby's dependencies. I thought I'd read an issue that described it, but now I can't find it 🤷

It seemed like enough of an edge-case that we can skip it for now, and investigate later if it becomes a problem.

m-allanson

comment created time in 19 days

PR closed stylelint/stylelint

Fix no files matching the pattern error square brackets and dash

<!-- Each pull request must be associated with an open issue unless it's a documentation fix. If a corresponding issue does not exist, please create one so we can discuss the change first. -->

<!-- Please answer the following. We close pull requests that don't. -->

Which issue, if any, is this issue related to?

  • #4855
  • https://github.com/sindresorhus/globby/issues/81

Is there anything in the PR that needs further explanation?

The related issue has already been opened on repository of globby, but it's been passed few years since the issue was opened. So everybody is solving themselves as I do with this PR.

It would be better if I could change globby to some other packages like fast-glob or node-glub but I couldn't because I worried that i can't handle whole side-effects of that change.

I just focused the issue that i've met. Any suggestions will be appreciated.

+12 -0

1 comment

1 changed file

reumia

pr closed time in 19 days

pull request commentstylelint/stylelint

Fix no files matching the pattern error square brackets and dash

Thanks for opening this @reumia. Unfortunately this change will break stylelint for people that want to use [ or ] as part of a glob pattern.

It's a tricky problem, and I don't think it's possible to automatically fix this for every usecase. Therefore I'm going to close this PR for now.

I've written up some workarounds that may help for your case. Thanks again for reporting the issue and opening a PR :+1:

reumia

comment created time in 19 days

push eventstylelint/stylelint

m-allanson

commit sha d206c6d02aacab391da3c93b115004c3963fdad9

Avoid invalid characters in fixture directories (for Windows). Reference: https://gist.github.com/doctaphred/d01d05291546186941e1b7ddc02034d3

view details

push time in 19 days

pull request commentstylelint/stylelint

Fix some path / glob problems

Some of the fixture paths are invalid on Windows. Will update.

m-allanson

comment created time in 19 days

issue commentstylelint/stylelint

Fix no files matching the pattern error square brackets and dash

You can use https://github.com/mrmlnc/fast-glob#escapepathpattern to avoid this problem, before passing it to globby, but it can be small breaking change

This is what happens in #4867 (code link), but it won't fix for patterns like this:

/packages/mobile/pages/[channelName]/**/*.scss

As it will escape the whole path:

/packages/mobile/pages/\[channelName\]/\*\*/\*.scss

reumia

comment created time in 20 days

issue commentstylelint/stylelint

Fix no files matching the pattern error square brackets and dash

Hey @reumia, thanks for reporting this issue. Could you create a small example that reproduces the problem?

As I couldn't get one of your success cases to work.

For me, these are the failure cases:

  • stylelint "./packages/mobile/pages/[channelName]/**/*.scss"
  • stylelint "./packages/mobile/pages/[channelName]/shopping-stories/*.scss"
  • stylelint ./packages/mobile/pages/[channelName]/shopping-stories/*.scss

These all fail for the same reason. They're globs mixed with directory paths that contain special characters. These special characters are valid globbing characters and valid directory names. There's no simple way for stylelint to know which part of the string is a path, and which part is a glob.

In your examples the *.scss part is a glob and the [channelName] part is a literal path. This causes problems because [ and ] are valid glob characters.

There are a few ways you can work around this:

  • Glob a directory path that has no special characters e.g. ./packages/mobile/pages/**/*.scss.
  • Use exact file paths. These can contain any special character e.g. ./packages/mobile/pages/[channelName]/sub-dir/my-styles.scss (note this won't work until #4867 is merged).
  • Use stylelint's globbyOptions option to set the cwd, and then use a shorter glob. You can see an example here.
  • Manually escape the special characters in the path e.g. ./packages/mobile/pages/\\[channelName\\]/**/*.scss (example).
reumia

comment created time in 20 days

Pull request review commentstylelint/stylelint

Fix some path / glob problems

     "cosmiconfig": "^6.0.0",     "debug": "^4.1.1",     "execall": "^2.0.0",+    "fast-glob": "^3.2.4",

Oh interesting! That could be a good follow-up PR.

It would need to be a breaking change, I think. As globbyOptions is a config option for stylelint. globby has a couple of options that aren't supported in fast-glob. Though I'd guess few people are using any of the globby-only option..

m-allanson

comment created time in 20 days

Pull request review commentstylelint/stylelint

Fix some path / glob problems

     "cosmiconfig": "^6.0.0",     "debug": "^4.1.1",     "execall": "^2.0.0",+    "fast-glob": "^3.2.4",

This is already a dependency of globby, so it's not really a new dependency here.

m-allanson

comment created time in 20 days

PR opened stylelint/stylelint

Fix some path / glob problems

<!-- Each pull request must be associated with an open issue unless it's a documentation fix. If a corresponding issue does not exist, please create one so we can discuss the change first. -->

<!-- Please answer the following. We close pull requests that don't. -->

Which issue, if any, is this issue related to?

#4521

Also:

  • #4193
  • #4211
  • #4388
  • #3272
  • #4855

It's an alternate take on this PR: https://github.com/stylelint/stylelint/pull/4863

Is there anything in the PR that needs further explanation?

The main behaviour change is:

  • if an input path contains globbing characters, it will be checked to see if it exactly matches an existing file.
  • if yes, the input path will be escaped so it gets treated as an exact path, instead of a glob.

This is broadly the approach used in ESLint, mentioned in https://github.com/stylelint/stylelint/issues/4388#issuecomment-547409590. It closes #4193.

This PR adds passing tests for most of the other problems reported in the above issues. I wasn't able to replicate some of the reported issues. They might be platform-specific, or may have been fixed in dependencies.

This doesn't fix https://github.com/stylelint/stylelint/issues/4855, but I'll add a comment on that issue instead.

+218 -0

0 comment

12 changed files

pr created time in 20 days

create barnchstylelint/stylelint

branch : path-globs

created branch time in 20 days

fork m-allanson/glob-parent

Extract the non-magic parent path from a glob string.

fork in 20 days

push eventstylelint/stylelint

dependabot-preview[bot]

commit sha e931e55322e8a4a353aae92d60719998ef6363b4

Bump autoprefixer from 9.8.0 to 9.8.2 (#4838) Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 9.8.0 to 9.8.2. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/9.8.0...9.8.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Lior Kummer

commit sha a8042e7192cad993081cf982901948dbd5004048

Add ignoreComments[] to comment-empty-line-before (#4841)

view details

dependabot-preview[bot]

commit sha 2ad2a249142b0001afb2f01a0f5bcb7841db822d

Bump typescript from 3.9.5 to 3.9.6 (#4853) Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.9.5 to 3.9.6. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Mike Allanson

commit sha 03a0cea2882ba214706860b6dc0760ed767d1b05

Add syntax object acceptance to customSyntax option (#4839)

view details

Richard Hallows

commit sha ba4701c630cdb8fde225bb1fa5796ddb1bf829ef

Update CHANGELOG.md

view details

Kevin Dew

commit sha 6c48085fb78f15e9bf3b8515e8cba11e543c850e

Add *-allowed-list/*-disallowed-list/*-required-list names for *-whitelist/*-blacklist/*-requirelist rules (#4845)

view details

Richard Hallows

commit sha 968248d2cebe76fd36eec76705aea8fa3230e9c3

Update CHANGELOG.md

view details

Glen

commit sha 055ebea508a6d1085dee844bcee25f44416b28ee

Add support for descriptions in stylelint command comments (#4848)

view details

Richard Hallows

commit sha 7808b0e07d5fec178e2d10629d96814f35733865

Update CHANGELOG.md

view details

Richard Hallows

commit sha b1187b654466bb15c2e42625de652ec86afd02c6

Create codeql analysis workflow (#4850)

view details

m-allanson

commit sha 6d9ff235e589272c7dd50397ac9c2d07c2bb2b42

Merge branch 'master' into browser-bundle # By Richard Hallows (4) and others # Via GitHub * master: Create codeql analysis workflow (#4850) Update CHANGELOG.md Add support for descriptions in stylelint command comments (#4848) Update CHANGELOG.md Add *-allowed-list/*-disallowed-list/*-required-list names for *-whitelist/*-blacklist/*-requirelist rules (#4845) Update CHANGELOG.md Add syntax object acceptance to customSyntax option (#4839) Bump typescript from 3.9.5 to 3.9.6 (#4853) Add ignoreComments[] to comment-empty-line-before (#4841) Bump autoprefixer from 9.8.0 to 9.8.2 (#4838)

view details

push time in a month

push eventm-allanson/dotfiles

m-allanson

commit sha 4feb0d474aeff5e6153ed7b0e955a74421bdfa86

Add alias for code

view details

push time in a month

push eventstylelint/stylelint

Richard Hallows

commit sha b1187b654466bb15c2e42625de652ec86afd02c6

Create codeql analysis workflow (#4850)

view details

push time in a month

delete branch stylelint/stylelint

delete branch : jeddy3-patch-1

delete time in a month

PR merged stylelint/stylelint

Create codeql analysis workflow

<!-- Each pull request must be associated with an open issue unless it's a documentation fix. If a corresponding issue does not exist, please create one so we can discuss the change first. -->

<!-- Please answer the following. We close pull requests that don't. -->

Which issue, if any, is this issue related to?

None.

Is there anything in the PR that needs further explanation?

We were recently accepted into the code scanning beta. This pull request adds the related workflow.

+92 -28

0 comment

3 changed files

jeddy3

pr closed time in a month

startedbrillout/parcel-ssr

started time in a month

PR opened parcel-bundler/parcel

Fix typo

<!--- Thanks for filing a pull request 😄 ! Before you submit, please read the following:

Search open/closed issues before submitting since someone might have pushed the same thing before! -->

↪️ Pull Request

Fixes a typo

✔️ PR Todo

  • [ ] ~Added/updated unit tests for this change~
  • [ ] ~Filled out test instructions (In case there aren't any unit tests)~
  • [ ] ~Included links to related issues/PRs~
+1 -1

0 comment

1 changed file

pr created time in a month

push eventm-allanson/parcel

Mike Allanson

commit sha c476ab38cb46d8988b2796d359b73238ed2f857c

Fix typo

view details

push time in a month

push eventstylelint/stylelint

m-allanson

commit sha 642bd3201277a42e9cf8cd705a663795d92b32bd

A bit more tidying

view details

push time in a month

push eventstylelint/stylelint

m-allanson

commit sha 8a74537dd1887b6989a38999715a17f854e61605

Use Parcel API instead of the CLI This means no config is needed in `package.json`

view details

m-allanson

commit sha 2ad2b5e154b084eb364f7804cb51a159ff75c348

Add some comments and log out build stats for each bundle

view details

push time in a month

PublicEvent

push eventm-allanson/parcelish

m-allanson

commit sha 1733230e06f901aab63f94bb0609185d70333998

Bump entries and target to the top

view details

push time in a month

push eventm-allanson/parcelish

m-allanson

commit sha 2cc8e83ae6b9703be744ba7d22be385928a9c753

More consistent naming

view details

push time in a month

startedjiahaog/nativefier

started time in a month

push eventstylelint/stylelint

Lior Kummer

commit sha a8042e7192cad993081cf982901948dbd5004048

Add ignoreComments[] to comment-empty-line-before (#4841)

view details

push time in a month

issue closedstylelint/stylelint

Add ignoreComments: [] to comment-empty-line-before

What is the problem you're trying to solve?

I use PurgeCSS and its special comment to whitelist some rules from it. https://purgecss.com/whitelisting.html#in-the-css-directly

I've got an unwanted error when I use comment-empty-line-before:

/* purgecss start ignore */
.special-rule {
    color: red;
}
/* purgecss end ignore */
/* ↑ Expected empty line before comment   comment-empty-line-before */

Rule used here:

{
    "comment-empty-line-before": ["always", {
        "except": ["first-nested"],
        "ignore": ["after-comment", "stylelint-commands"]
    }]
}

What solution would you like to see?

ignorePattern option that specify regex matching comments to be ignored.

Example:

{
    "comment-empty-line-before": ["always", {
        "except": ["first-nested"],
        "ignore": ["after-comment", "stylelint-commands"],
        "ignorePattern": "^\\s*purgecss"
    }]
}

closed time in a month

dobogo

PR merged stylelint/stylelint

Add ignoreComments[] to comment-empty-line-before

Which issue, if any, is this issue related to?

Closes #4814.

Is there anything in the PR that needs further explanation?

It is pretty self explanatory, I mostly followed instructions from the issue.

+69 -0

2 comments

4 changed files

LKummer

pr closed time in a month

startedonivim/oni2

started time in a month

push eventstylelint/stylelint

m-allanson

commit sha 20516376be388aebb9042e9da64d77ce0710602a

Reverse unnecessary whitespace change

view details

push time in a month

PR opened stylelint/stylelint

Accept syntax object in `customSyntax` option

This overloads the customSyntax option to also accept a syntax object. The option also maintains its previous behaviour of accepting a string. This should be a fully backwards compatible change.

The signature of this option has changed from string to string | { parse: Function }. This follows the convention of the formatter option, which has similar behaviour.

Which issue, if any, is this issue related to?

https://github.com/stylelint/stylelint/issues/3935.

Is there anything in the PR that needs further explanation?

This is based on a section of https://github.com/stylelint/stylelint/pull/4796. This is the only part of that PR that changes existing functionality.

The change itself is fairly straightforward, but it's probably worth detailing some of the why.

Why?

This API will be used to load non-standard CSS syntaxes (scss, less, css-in-js etc) when running in the browser.

What is a syntax?

A syntax is typically an object containing two functions, parse and stringify. Stylelint uses a syntax to transform your CSS-like code into a structure that can be linted, and then back again.

Why do you need a custom syntax?

stylelint ships with syntaxes for linting the various flavours of CSS-like code that people use. These syntaxes won't be included in the default browser bundle as they are quite large - several MB for all of stylelint's included syntaxes.

What's wrong with using a string, anyway?

The customSyntax option uses Node.JS's require function to load the syntax. It turns a string like my-excellent-syntax into a 'live' JS module. require is not available in the browser.

Allowing the customSyntax option to accept a syntax object means the host environment (whether a browser, Node.JS or something else) can deal with how to load the syntax, and then pass the object in for stylelint to use.

+77 -20

0 comment

6 changed files

pr created time in a month

create barnchstylelint/stylelint

branch : custom-syntax-object

created branch time in a month

push eventstylelint/stylelint

Matt Wang

commit sha 16871985d9badd02965e33176a07342e0efd61d9

Add ignoreContextFunctionalPseudoClasses to selector-max-id (#4835) Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

view details

Mike Allanson

commit sha 32abe3b8ce7655397f12281f636371bb67020b81

Update CHANGELOG.md

view details

Mike Allanson

commit sha 56a01089aece4608263be8013250c16a6236a82c

A small refactor (#4837)

view details

m-allanson

commit sha e652b3e1ca96237b04420a730882ca065c92a896

Fix changelog formatting

view details

m-allanson

commit sha 48ccd71e4b9c8b1fd06ff06112c5f38c3c6a10fb

Merge branch 'master' into browser-bundle # By Mike Allanson (2) and others * master: Fix changelog formatting A small refactor (#4837) Update CHANGELOG.md Add ignoreContextFunctionalPseudoClasses to selector-max-id (#4835)

view details

push time in a month

push eventstylelint/stylelint

m-allanson

commit sha e652b3e1ca96237b04420a730882ca065c92a896

Fix changelog formatting

view details

push time in a month

delete branch stylelint/stylelint

delete branch : issue-3935/refactor-smaller-funcs

delete time in a month

push eventstylelint/stylelint

Mike Allanson

commit sha 56a01089aece4608263be8013250c16a6236a82c

A small refactor (#4837)

view details

push time in a month

PR merged stylelint/stylelint

A small refactor

Another refactor. This moves a couple of chunks of functionality out to separate functions. It's not particularly essential, but (imo) makes it easier to understand what's happening in each file.

This should be the last bit of refactoring from PR #4796. The remaining follow-on PRs should result in new (or changed) functionality instead of rearranging internals.

Which issue, if any, is this issue related to?

Related to issue #3935

Is there anything in the PR that needs further explanation?

This change is a small part of the changes in PR #4796

+69 -39

0 comment

3 changed files

m-allanson

pr closed time in a month

pull request commentstylelint/stylelint

Add ignoreContextFunctionalPseudoClasses to selector-max-id

Updated changelog:

  • Added: ignoreContextFunctionalPseudoClasses to selector-max-id (#4835)
malsf21

comment created time in a month

push eventstylelint/stylelint

Mike Allanson

commit sha 32abe3b8ce7655397f12281f636371bb67020b81

Update CHANGELOG.md

view details

push time in a month

push eventstylelint/stylelint

Matt Wang

commit sha 16871985d9badd02965e33176a07342e0efd61d9

Add ignoreContextFunctionalPseudoClasses to selector-max-id (#4835) Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>

view details

push time in a month

PR merged stylelint/stylelint

Add ignoreContextFunctionalPseudoClasses to selector-max-id

Hi there,

This PR implements an option requested in #4619, the verbose ignoreContextFunctionalPseudoClasses to selector-max-id. In addition to modifying the rule, it also introduces a set of simple test cases (only testing on :not, :has, and :matches currently), and adds documentation to explain the usage of the rule.

<!-- Each pull request must be associated with an open issue unless it's a documentation fix. If a corresponding issue does not exist, please create one so we can discuss the change first. -->

<!-- Please answer the following. We close pull requests that don't. -->

Which issue, if any, is this issue related to?

Closes #4619.

Is there anything in the PR that needs further explanation?

As mentioned in the issue discussion, it looks like stylelint/lib/utils/isLogicalCombination.js needs to be updated to support more pseudo-classes, such as :is and :where (and possibly :nth-child); will follow up on this!

+88 -10

4 comments

3 changed files

malsf21

pr closed time in a month

issue closedstylelint/stylelint

Add ignoreContextFunctionalPseudoClasses: [] to selector-max-id

<!-- Please answer the following. We close issues that don't. -->

I have multiple instances of a :not() CSS pseudo class selector with an ID as a parameter, causing errors in the console. Multiple instances once the SCSS is processed to CSS.

Which rule, if any, is the bug related to?

e.g. selector-max-id

What code is needed to reproduce the bug?

.comment-form {
	width: 100%;

	input:not(#wp-comment-cookies-consent):not(.button) {
		clear: both;
		transition: $transition-border;
		width: 100%;

		&:focus,
		&:active {
			border: 1px solid $color-border-comment-focus;
		}
        }
}

Which version of stylelint are you using?

13.1.0

Does the bug relate to non-standard syntax (e.g. SCSS, Less etc.)?

Yes, it's related to SCSS nested properties.

What did you expect to happen?

No warnings to be flagged.

What actually happened (e.g. what warnings or errors did you get)?

The following warnings were flagged:

 59:12  ×  Expected "#wp-comment-cookies-consent" to have no more than 0 ID selectors   selector-max-id
 65:3   ×  Expected "#wp-comment-cookies-consent" to have no more than 0 ID selectors   selector-max-id
 65:3   ×  Expected "#wp-comment-cookies-consent" to have no more than 0 ID selectors   selector-max-id

closed time in a month

superfein

pull request commentstylelint/stylelint

Bump autoprefixer from 9.8.0 to 9.8.2

Note that this update drops support for older versions of Node.js 13:

Remove Node.js 13.0-13.7 from supported engines, because of buggy ESM support.

I think this should be fine as the 13 line reached end of life status at the beginning of June.

dependabot-preview[bot]

comment created time in a month

issue commentstylelint/stylelint

Replace some of lodash functions with native ones

This might be a useful reference for anyone who'd like to work on the remaining items https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore

XhmikosR

comment created time in a month

startedJustinBeckwith/npmtrace

started time in a month

Pull request review commentstylelint/stylelint

A small refactor

 declare module 'stylelint' {  	export type FormatterIdentifier = 'compact' | 'json' | 'string' | 'unix' | 'verbose' | Formatter; +	export type CustomSyntax = string;

This type will be extended later to be string | Syntax

m-allanson

comment created time in a month

Pull request review commentstylelint/stylelint

A small refactor

 module.exports = function (stylelint, options = {}) { 			let syntax = null;  			if (stylelint._options.customSyntax) {-				try {-					// TODO TYPES determine which type has customSyntax-					const customSyntax = /** @type {any} */ require(stylelint._options.customSyntax);

This is now using the type @typedef {import('postcss').Syntax} Syntax

m-allanson

comment created time in a month

PR opened stylelint/stylelint

A small refactor

Another refactor. This moves a couple of chunks of functionality out to separate functions. It's not particularly essential, but (imo) makes it easier to understand what's happening in each file.

This should be the last bit of refactoring from PR #4796. The remaining follow-on PRs should result in new (or changed) functionality instead of rearranging internals.

Which issue, if any, is this issue related to?

Related to issue #3935

Is there anything in the PR that needs further explanation?

This change is a small part of the changes in PR #4796

+69 -39

0 comment

3 changed files

pr created time in a month

create barnchstylelint/stylelint

branch : issue-3935/refactor-smaller-funcs

created branch time in a month

push eventstylelint/stylelint

m-allanson

commit sha f3754290b5c7407f6c12756f6eafc0bdf1e8025a

Delete temp test files

view details

push time in 2 months

push eventstylelint/stylelint

dependabot-preview[bot]

commit sha 547ea7f4daf25e7dd4728a7e6ce14c3c839d77a8

Bump np from 6.2.3 to 6.2.4 (#4830) Bumps [np](https://github.com/sindresorhus/np) from 6.2.3 to 6.2.4. - [Release notes](https://github.com/sindresorhus/np/releases) - [Commits](https://github.com/sindresorhus/np/compare/v6.2.3...v6.2.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Rúnar Berg Baugsson Sigríðarson

commit sha 1404260c99c1b80fb764196f7b38b1263319c4ed

Fix false positives for idents within ::part pseudo-elements in selector-type-no-unknown (#4828)

view details

Richard Hallows

commit sha cbc91fc5c834c7977408355ea885c04032e31af6

Update CHANGELOG.md

view details

jeddy3

commit sha 9843b8429142aa7981e66799963674e302c9822d

Update deps

view details

jeddy3

commit sha bc65a1c8164d237250848e4fe6feb400455aa90e

Prepare 13.6.1

view details

jeddy3

commit sha 2b418150a7c1762a76bd941a0577d9cc6f145784

Scope eslint disable

view details

jeddy3

commit sha 58aab8def87fdceec4bbc4e87591892def144025

13.6.1

view details

m-allanson

commit sha c8dd0a9a9f61f47ab85dc65fa9e070c4ba894e41

Update parcel 2 from alpha to beta version

view details

Mike Allanson

commit sha e110b4c32f36cdef3e07aca3e97c097ee5f53adf

Create new 'prepareReturnValue' module (#4832) In a future PR this module will be required by the new `browser.js` module. This change has been extracted from: https://github.com/stylelint/stylelint/pull/4796

view details

m-allanson

commit sha 30cc66f1e1f84909dc962253b08cbf48cd1e2e75

Merge branch 'master' into browser-bundle # By jeddy3 (4) and others # Via GitHub * master: Create new 'prepareReturnValue' module (#4832) 13.6.1 Scope eslint disable Prepare 13.6.1 Update deps Update CHANGELOG.md Fix false positives for idents within ::part pseudo-elements in selector-type-no-unknown (#4828) Bump np from 6.2.3 to 6.2.4 (#4830)

view details

push time in 2 months

push eventstylelint/stylelint

Mike Allanson

commit sha e110b4c32f36cdef3e07aca3e97c097ee5f53adf

Create new 'prepareReturnValue' module (#4832) In a future PR this module will be required by the new `browser.js` module. This change has been extracted from: https://github.com/stylelint/stylelint/pull/4796

view details

push time in 2 months

delete branch stylelint/stylelint

delete branch : issue-3935/refactor-prepare-return-value

delete time in 2 months

PR merged stylelint/stylelint

Create new 'prepareReturnValue' module

In a future PR this module will be required by the new browser.js module. This change has been extracted from: https://github.com/stylelint/stylelint/pull/4796.

<!-- Each pull request must be associated with an open issue unless it's a documentation fix. If a corresponding issue does not exist, please create one so we can discuss the change first. -->

<!-- Please answer the following. We close pull requests that don't. -->

Which issue, if any, is this issue related to?

Related to issue #3935

Is there anything in the PR that needs further explanation?

This change is a small part of the changes in PR #4796

+65 -49

1 comment

2 changed files

m-allanson

pr closed time in 2 months

pull request commentstylelint/stylelint

Create new 'prepareReturnValue' module

Thanks for all the reviews :)

m-allanson

comment created time in 2 months

pull request commentstylelint/stylelint

Add ignoreContextFunctionalPseudoClasses to selector-max-id

I restarted the tests and they're all 👍 this time. Must have been a temporary gremlin.

malsf21

comment created time in 2 months

push eventm-allanson/dotfiles

m-allanson

commit sha 54925b48b713c37a7c0efa81b717272a30c27e1e

Set absolute path to gitignore

view details

push time in 2 months

push eventm-allanson/dotfiles

m-allanson

commit sha a7c02c9f08761fb49ace9822d99f40c8e762d8fc

Add 'n' to requirements

view details

push time in 2 months

push eventm-allanson/dotfiles

m-allanson

commit sha f35620234c7439ef127a609898b557002a1e6486

Shorter command for the cps alias

view details

m-allanson

commit sha 066a459589fe7edaf440b915ef735fca17bcd00b

Drop nvm

view details

m-allanson

commit sha 4832c11fb55ab4ab5ec1fdb37e3d0710b8f74c54

Use 'n' (replaces nvm) N seems faster, and I find it easier to remember how to use it

view details

m-allanson

commit sha ab707ff0eea94a751ce30be713c947a4e9b5c674

Use vercel/serve over caddy Serve seems more appropriate for running short-lived local dev servers. Neater output and more things are configured as I'd expect.

view details

m-allanson

commit sha eb6fd5409315530e8c196b18360cfba514e18fc4

Aliases for Sublime Merge

view details

m-allanson

commit sha 03d5edb04c6d94405c95a1e4b4a7dbeb7373a5da

Add note

view details

m-allanson

commit sha 3c600e2547a64b2cd4cc63cbda099ed469026775

Add 'git newbs' alias to list branches by latest commit date

view details

push time in 2 months

PR opened stylelint/stylelint

Create new 'prepareReturnValue' module

In a future PR this module will be required by the new browser.js module. This change has been extracted from: https://github.com/stylelint/stylelint/pull/4796.

<!-- Each pull request must be associated with an open issue unless it's a documentation fix. If a corresponding issue does not exist, please create one so we can discuss the change first. -->

<!-- Please answer the following. We close pull requests that don't. -->

Which issue, if any, is this issue related to?

Related to issue #3935

Is there anything in the PR that needs further explanation?

This change is a small part of the changes in PR #4796

+65 -49

0 comment

2 changed files

pr created time in 2 months

more