profile
viewpoint

ljedrz/lambda_calculus 21

A simple, zero-dependency implementation of the untyped lambda calculus in Safe Rust

ljedrz/blc 1

Binary lambda calculus

ljedrz/rust-misc 1

Generic stuff written in Rust

ljedrz/chalk 0

A PROLOG-ish interpreter written in Rust, intended eventually for use in the compiler

ljedrz/compiler-builtins 0

Porting `compiler-rt` intrinsics to Rust

ljedrz/datafrog 0

A lightweight Datalog engine in Rust

ljedrz/ena 0

An implementation of union-find / congruence-closure in Rust. Extracted from rustc for independent experimentation.

ljedrz/minesweeper 0

A simple CLI minesweeper in Rust

ljedrz/polonius 0

Defines the Rust borrow checker.

startedzyedidia/micro

started time in 10 days

delete branch ljedrz/rust-1

delete branch : unused_stuff

delete time in 13 days

pull request commentrust-lang/rust

traits: preallocate 2 Vecs of known initial size

Aww yiss, thanks for letting me know :smile:

ljedrz

comment created time in 14 days

pull request commentrust-lang/rust

Remove a few unused objects

Done.

ljedrz

comment created time in 14 days

push eventljedrz/rust-1

ljedrz

commit sha d8544ce2484553f6397d8986b582181a2e761360

remove some unused objects

view details

push time in 14 days

pull request commentrust-lang/rust

Remove a few unused objects

Thanks for the feedback, I'll update the PR shortly.

ljedrz

comment created time in 14 days

delete branch ljedrz/rust-1

delete branch : traits_tweak_vecs

delete time in 14 days

startedoreboot/oreboot

started time in 14 days

pull request commentrust-lang/rust

Remove a few unused objects

Sooo I guess I'll remove that bit again shortly ^^.

ljedrz

comment created time in 14 days

push eventljedrz/rust-1

ljedrz

commit sha f1b9892e1e3b787a4745ea1e10b5679975b82b3f

remove some unused objects

view details

push time in 15 days

pull request commentquininer/rust-hacl-star

update rand to 0.7, bump crate version to 0.2

That's good enough for me, thanks!

ljedrz

comment created time in 15 days

PR opened rust-lang/rust

Remove a few unused objects

As far as I can tell, these won't be missed:

  • infer::region_constraints::ConstraintInfo
  • driver::DefaultCallbacks
  • hir::intravisit::ParDeepVisitor
+1 -26

0 comment

3 changed files

pr created time in 15 days

create barnchljedrz/rust-1

branch : unused_stuff

created branch time in 15 days

delete branch ljedrz/rust-hacl-star

delete branch : update_rand

delete time in 15 days

push eventljedrz/rust-hacl-star

ljedrz

commit sha 030917cd5db72f6a57542b512dd05764cb4a5204

update rand to 0.7, bump crate version to 0.2

view details

push time in 15 days

create barnchljedrz/rust-hacl-star

branch : update_rand

created branch time in 15 days

fork ljedrz/rust-hacl-star

HACL*, a formally verified cryptographic library for Rust (binding to hacl-c).

fork in 15 days

PR opened rust-lang/rust

traits: preallocate 2 Vecs of known initial size

The 2 preallocations are pretty obvious; both vectors will be as big as or larger than the collections they are created from.

In WfPredicates::normalize the change from a functional style improves readability and should be perf-friendly, too.

+5 -4

0 comment

2 changed files

pr created time in 16 days

push eventljedrz/rust-1

ljedrz

commit sha b8893df8d344c11880c4aada639727fbfc195792

preallocate 2 Vecs in traits; tweak WfPredicates::normalize

view details

push time in 16 days

create barnchljedrz/rust-1

branch : traits_tweak_vecs

created branch time in 16 days

create barnchljedrz/rust-1

branch : collapse_intravisit_methods

created branch time in 21 days

push eventljedrz/rust-1

ljedrz

commit sha e8b72f44b0064d0e591f078f6b7f2cf3aa28f540

move item reference comment

view details

push time in 21 days

delete branch ljedrz/rust-1

delete branch : remove_trait_impl_id_structs

delete time in 21 days

PR closed rust-lang/rust

Replace HIR's ItemId structs with aliases S-waiting-on-author

I'm not 100% sure this is a valid approach (and if not, then perhaps all 3 could be merged into a single ItemId), but it passes the tests locally.

It appears that we can "downgrade" HIR's ImplItemId, ItemId and TraitItemId to just aliases of HirId which is a cleanup on its own and opens up further cleanup opportunities.

r? @varkor

+72 -140

7 comments

24 changed files

ljedrz

pr closed time in 21 days

pull request commentrust-lang/rust

Replace HIR's ItemId structs with aliases

Closing in favor of https://github.com/rust-lang/rust/pull/68858.

ljedrz

comment created time in 21 days

PR opened rust-lang/rust

Merge item id stable hashing functions

Supersedes https://github.com/rust-lang/rust/pull/67999 splitting out the pure cleanup bits, i.e. merging hash_item_id, hash_impl_item_id and hash_trait_item_id into a common hash_reference_to_item.

r? @michaelwoerister

+5 -26

0 comment

2 changed files

pr created time in 21 days

push eventljedrz/rust-1

ljedrz

commit sha 28b0ed020a36e94fe233e2a0ef950fd888b16256

merge item id stable hashing functions

view details

push time in 21 days

create barnchljedrz/rust-1

branch : collapse_stable_hash_foos

created branch time in 21 days

Pull request review commentrust-lang/rust

Replace HIR's ItemId structs with aliases

 impl<'ctx> rustc_hir::HashStableContext for StableHashingContext<'ctx> {         }     } -    // The following implementations of HashStable for `ItemId`, `TraitItemId`, and-    // `ImplItemId` deserve special attention. Normally we do not hash `NodeId`s within-    // the HIR, since they just signify a HIR nodes own path. But `ItemId` et al-    // are used when another item in the HIR is *referenced* and we certainly-    // want to pick up on a reference changing its target, so we hash the NodeIds-    // in "DefPath Mode".

Any suggestion on the name? Would ItemId be fine?

ljedrz

comment created time in 22 days

pull request commentrust-lang/rust

Replace HIR's ItemId structs with aliases

@JohnCSimon I'm still waiting for further instructions from the compiler team; see varkor's comment.

ljedrz

comment created time in a month

Pull request review commentrust-lang/rust

Replace HIR's ItemId structs with aliases

 impl<'ctx> rustc_hir::HashStableContext for StableHashingContext<'ctx> {         }     } -    // The following implementations of HashStable for `ItemId`, `TraitItemId`, and-    // `ImplItemId` deserve special attention. Normally we do not hash `NodeId`s within-    // the HIR, since they just signify a HIR nodes own path. But `ItemId` et al-    // are used when another item in the HIR is *referenced* and we certainly-    // want to pick up on a reference changing its target, so we hash the NodeIds-    // in "DefPath Mode".

Seeing that comment I thought about how much the NodeIds have become deprecated after the lowering and wondered if we could get away with it. If there's a reason we should stick to this solution, though, we can probably still merge all these 3 types into 1, because their impls are identical.

ljedrz

comment created time in 2 months

PR opened rust-lang/rust

Replace HIR's ItemId structs with aliases

I'm not 100% sure this is a valid approach, but it passes the tests locally (and if not, then perhaps all 3 could be merged into a single ItemId).

It appears that we can "downgrade" HIR's ImplItemId, ItemId and TraitItemId to just aliases of HirId which is a cleanup on its own and opens up further cleanup opportunities.

r? @varkor

+72 -140

0 comment

24 changed files

pr created time in 2 months

push eventljedrz/rust-1

Josh Stone

commit sha 81a6709cf9f6e83b6dd2311f4dcd9e1ef1fba284

Simplify Clone for Box<[T]> The bespoke `BoxBuilder` was basically a very simple `Vec`. Instead, let's clone to a real `Vec`, with all of its specialization for the task, then convert back to `Box<[T]>`.

view details

Pietro Albini

commit sha 67cc06806ddd9e4af485be4e45957c1a148fd405

ci: remove 32-bit apple targets

view details

Pietro Albini

commit sha d9278f7ff65b3a4798348d2fc68278b25eaae864

ci: make publish_toolstate.sh generic over the CI provider

view details

Pietro Albini

commit sha ae9ca096126cc626fcb503c84e6937478b9161c1

ci: fix wrong variable name in shared.sh's ciCommandAddPath

view details

Pietro Albini

commit sha 846d386b4d84faa6c5f373d0f608e859239465e8

ci: install binutils in msys2

view details

Pietro Albini

commit sha 39ddbeb87470071113d03fa7dfc34164180c76d6

ci: fix wrong sysroot in macos 10.15 onwards In their infinite wisdom, Apple decided that (starting from macOS 10.15 onwards) /usr/include is not the location we should all search in for our beloved C headers. Instead, we should look inside the extremely intuitive and easily guessable new path: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include Because why not.

view details

Eric Huss

commit sha a30ee84f33cc141dadcfb77c02f5f52280ba3c7a

Update cargo

view details

bors

commit sha ee84c30aee06a004b8d8f8d24000351e9d1cb4bf

Auto merge of #67961 - ehuss:update-cargo, r=alexcrichton Update cargo 9 commits in 86134e7666a088682f20b76278c3ee096a315218..6e1ca924a67dd1ac89c33f294ef26b5c43b89168 2019-12-23 16:08:07 +0000 to 2020-01-06 19:11:37 +0000 - Fix dynamic linking for Windows UWP MSVC targets (rust-lang/cargo#7758) - Fix CARGO_TARGET_triple_LINKER environment variable. (rust-lang/cargo#7763) - Remove metadata dep_kinds duplicates. (rust-lang/cargo#7756) - Check for a source defined multiple times. (rust-lang/cargo#7751) - Fix typo. (rust-lang/cargo#7735) - Fix config env vars that are prefix of another with underscore. (rust-lang/cargo#7748) - Add test for `cargo pkgid` (rust-lang/cargo#7741) - Add a note to the error message for using --feature / --no-default-features in a virtual workspace (rust-lang/cargo#7742) - Fix debug message. (rust-lang/cargo#7749)

view details

Ralf Jung

commit sha 0f094a4f4d2fa7c9e9e86153a4e9ffa5517abf42

update miri

view details

bors

commit sha 637793a1999f46d10c9567f302ca211385702224

Auto merge of #67924 - RalfJung:miri, r=RalfJung update miri Fixes https://github.com/rust-lang/rust/issues/67860 r? @ghost

view details

bors

commit sha 56446fef49d73212f63ea7aa0680d5d602f19b9a

Auto merge of #67732 - pietroalbini:fewer-apples, r=alexcrichton ci: remove 32-bit Apple targets This PR drops the `i686-apple` and `dist-i686-apple` CI builders, as well as removing the `armv7-apple-ios`, `armv7s-apple-ios` and `i386-apple-ios` targets from the `x86_64-apple` CI builder. The change was approved in [RFC 2837](https://github.com/rust-lang/rfcs/pull/2837), and it should land in Rust 1.42 stable (so this cycle). r? @alexcrichton

view details

Camille GILLOT

commit sha 47256b8b7c78f188defaed8f5491ce01812622b1

Remove private methods from TyCtxt impl block: rustc::infer::error_reporting.

view details

Camille GILLOT

commit sha 811adb5ddc539e0084c9311f14004daec0e34d0f

Remove private methods from TyCtxt impl block: rustc::middle::stability.

view details

Camille GILLOT

commit sha c1afe6a9c9f8339134513857dd26dccb20df88d2

Remove private methods from TyCtxt impl block: rustc::trait::object_safety.

view details

Camille GILLOT

commit sha 0d9f4fb270ce09c12d04c5a913c9e89c59c713fd

Remove trivial function.

view details

Camille GILLOT

commit sha 640cae257b5c3cbc4b4588e1112b604da1f4c341

Remove private methods from TyCtxt impl block: rustc::ty::outlives.

view details

Camille GILLOT

commit sha 7118e33bfd3313c850b0656fb9d4a655fb450410

Remove private methods from TyCtxt impl block: rustc::ty::print::pretty.

view details

Camille GILLOT

commit sha d53bf7a67657fc585e13d14cf5023b5ebdf81021

Make rustc::infer::error_reporting::{note_and_explain_free_region, note_and_explain_region} free functions.

view details

Camille GILLOT

commit sha 0b1521e6d3ed756f3b2024291edbe0c9e74cb08c

Make rustc::traits::error_reporting::{recursive_type_with_infinite_size_error, report_object_safety_error} free functions.

view details

Camille GILLOT

commit sha 7770bce1788169e15186412b0eb035adb5c8eb4b

Make rustc::traits::object_safety::{astconv_object_safety_violations,is_vtable_safe_method,object_safety_violations} free functions.

view details

push time in 2 months

push eventljedrz/rust-1

ljedrz

commit sha 29914595fb7e499fda8e5d7f968c0219e24972c8

Revert "HIR: replace BodyId struct with an alias" This reverts commit 7b777e1056d8dd583db68e2a34232e5b7b28f9d8.

view details

ljedrz

commit sha 9b9c3856da2058836439a75b2c2ceb408c258475

HIR: remove obsolete stable hash functions

view details

push time in 2 months

push eventljedrz/rust-1

ljedrz

commit sha 7b777e1056d8dd583db68e2a34232e5b7b28f9d8

HIR: replace BodyId struct with an alias

view details

push time in 2 months

create barnchljedrz/rust-1

branch : remove_trait_impl_id_structs

created branch time in 2 months

issue commentrust-lang/rust

Meta issue for FIXMEs that reference closed issues

Actually it appears that many of those have already been removed; we could use another pass of that script.

oli-obk

comment created time in 2 months

PR closed rust-lang/rust

Cleanup after #19596 S-waiting-on-review

Cc https://github.com/rust-lang/rust/issues/44366

+27 -50

2 comments

2 changed files

ljedrz

pr closed time in 2 months

pull request commentrust-lang/rust

Cleanup after #19596

Oof, it seems that it's not fixed yet after all.

ljedrz

comment created time in 2 months

PR opened rust-lang/rust

Cleanup after #19596

Cc https://github.com/rust-lang/rust/issues/44366

+27 -50

0 comment

2 changed files

pr created time in 2 months

create barnchljedrz/rust-1

branch : cleanup_19596

created branch time in 2 months

issue commentrust-lang/rust

Separate the Def::{Local,Upvar} cases from hir::ExprKind::Path.

I would like to work on this, but I'd need some guidance; ExprKind has a Path variant, but that one contains QPath that's either Resolved or TypeRelative. Have the names changed, does this relationship with Def::{Local, Upvar} go deeper or am I missing something?

In other words, if anyone could drop me a "change A to B and fix the fallout" hint, I could give it a shot.

eddyb

comment created time in 2 months

issue commentrust-lang/rust

Cleanup: Refactor `librustc_typeck/check/op.rs`

I'd like to take a stab at this.

Centril

comment created time in 2 months

PR closed rust-lang/rust

HIR: introduce a HirId to DefId map in Definitions S-waiting-on-review

Split out from https://github.com/rust-lang/rust/pull/62975.

Introduce a HirId to DefIndex map in map::Definitions; this introduces a little bit of extra complexity, but could result in a performance win. I'd do a perf run to check if it's worth it.

+53 -7

32 comments

4 changed files

ljedrz

pr closed time in 4 months

pull request commentrust-lang/rust

HIR: introduce a HirId to DefId map in Definitions

I'm ok with this 👍.

ljedrz

comment created time in 4 months

pull request commentrust-lang/rust

HIR: introduce a HirId to DefId map in Definitions

@nikomatsakis I don't mind at all ^^.

Nah, they don't exist - at least none that I know of. I'm just continuing the ancient NodeId bashing crusade (AKA the HirIdification initiative), so that we can ditch NodeIds in favor of HirIds after the AST > HIR lowering (for uniformity and incremental gains).

I don't mind how it is done; the concept outlined by @eddyb is a bit foreign to me, but I wouldn't mind doing it that way with a little bit of mentoring.

ljedrz

comment created time in 5 months

pull request commentrust-lang/rust

HIR: introduce a HirId to DefId map in Definitions

@nikomatsakis I rebased and expanded on the previous comments.

ljedrz

comment created time in 5 months

push eventljedrz/rust-1

varkor

commit sha b73e32c795ec438a4b2e1901abc4e2a281e1a18a

Add `bool::then` and `bool::then_with`

view details

Alexander Regueiro

commit sha c1d29ee3c754c63fc6c8c3a522b7a71a5a19616a

Aggregation of cosmetic changes made during work on REPL PRs: librustc

view details

Alexander Regueiro

commit sha fd48ca20d366cff016cb0f9cfd8e98c44a91da10

Apply suggestions from code review Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>

view details

Alexander Regueiro

commit sha 49d2fd1725510fd3bf6f2937e178b1aa055ddb02

Aggregation of cosmetic changes made during work on REPL PRs: libsyntax

view details

Alexander Regueiro

commit sha 553a56dd98cee2e42fe8de0e3ad02a41a4a0eb13

Apply suggestions from code review

view details

Samuel Holland

commit sha 2bcabf67378cc4bceb3d66c72f88c95fc97cb4a1

compiletest: Match suffixed environments This fixes a case where an `ignore-musl` test was not ignored on `armv7-unknown-linux-musleabihf` because the environment did not exactly match. Only enforce that the environment starts with the argument to `ignore-`.

view details

varkor

commit sha 0f0e1c1691422132a40e5f534ff579004a79ef9c

Move `libcore/bool/mod.rs` to `libcore/bool.rs`

view details

Aleksi Juvani

commit sha 6dc763eed59295d0907a2780d66d4adf6f41a644

Fix nits

view details

varkor

commit sha 7b3f72906ffea5a8aec9e3d109d8e012f771a672

Add tracking issue

view details

Mazdak Farrokhzad

commit sha 8bee18baa341cb315bc2b86f3f9a375f8ce01739

Rollup merge of #64023 - tmandry:libstd-fuchsia-fixes, r=cramertj libstd fuchsia fixes This fixes two bugs in libstd on Fuchsia: - `zx_time_t` was changed to an `i64`, but this never made it into libstd - When spawning processes where any of the stdio were null, libstd attempts to open `/dev/null`, which doesn't exist on Fuchsia r? @cramertj

view details

Mazdak Farrokhzad

commit sha 3c4a58622128887778c6fd7c35de66f3fa463708

Rollup merge of #64098 - Mark-Simulacrum:always-warn, r=alexcrichton Ensure edition lints and internal lints are enabled with deny-warnings=false Previously we only passed the deny command line flags if deny-warnings was enabled, but now we either pass -W... or -D... for each of the flags as appropriate. This is also a breaking change to x.py as it changes `--warnings=allow` to `--warnings=warn` which is what that flag actually did; we don't have an allow warnings mode.

view details

Mazdak Farrokhzad

commit sha 89a69fd76d275ddd2c81fdbae02a966d24658aaa

Rollup merge of #64139 - Mark-Simulacrum:strip-legacy-proc-macro, r=petrochenkov Migrate internal diagnostic registration to macro_rules Review is best done commit-by-commit. Fixes #64132.

view details

Mazdak Farrokhzad

commit sha c5306724a3a707d67215f37b7f254b89483f4aee

Rollup merge of #64226 - alexreg:rush-pr-3, r=centril Aggregation of cosmetic changes made during work on REPL PRs: libsyntax Factored out from hacking on rustc for work on the REPL. r? @Centril

view details

Mazdak Farrokhzad

commit sha c70b768df4c625025120e6c3052f4f201a5f899b

Rollup merge of #64227 - alexreg:rush-pr-4, r=centril Aggregation of cosmetic changes made during work on REPL PRs: librustc Factored out from hacking on rustc for work on the REPL. r? @Centril

view details

Mazdak Farrokhzad

commit sha 448b38f0bf14c020efba5f93839b0144e83e69ab

Rollup merge of #64235 - mati865:env_logger, r=alexcrichton Upgrade env_logger to 0.6

view details

Mazdak Farrokhzad

commit sha 635c3bcc3cd9fcd80380572de0efb905224a8fa0

Rollup merge of #64258 - smaeul:patch/arm-tests, r=Mark-Simulacrum compiletest: Match suffixed environments This fixes a case where an `ignore-musl` test was not ignored on `armv7-unknown-linux-musleabihf` because the environment did not exactly match. Only enforce that the environment starts with the argument to `ignore-`.

view details

bors

commit sha 43a5ff4222e1f217ac14331afd59f82ec4204d12

Auto merge of #64264 - Centril:rollup-w1khzun, r=Centril Rollup of 7 pull requests Successful merges: - #64023 (libstd fuchsia fixes) - #64098 (Ensure edition lints and internal lints are enabled with deny-warnings=false) - #64139 (Migrate internal diagnostic registration to macro_rules) - #64226 (Aggregation of cosmetic changes made during work on REPL PRs: libsyntax) - #64227 (Aggregation of cosmetic changes made during work on REPL PRs: librustc) - #64235 (Upgrade env_logger to 0.6) - #64258 (compiletest: Match suffixed environments) Failed merges: r? @ghost

view details

Vadim Petrochenkov

commit sha 7dc3839b50d1ddb623aef0fbe76e982af460a18a

resolve: Mark more erroneous imports as used

view details

Vadim Petrochenkov

commit sha f7434aef26bc413469fc0dfeadecabf75e18bd38

Support "soft" feature-gating using a lint Use it for feature-gating `#[bench]`

view details

Eric Huss

commit sha fb387088e2e327e4060290edc92a90d49669b04c

rustdoc: fix diagnostic with mixed code block styles

view details

push time in 5 months

delete branch ljedrz/rust-1

delete branch : kill_off_hir_to_node_id

delete time in 5 months

pull request commentrust-lang/rust

HIR: introduce a HirId to DefId map in Definitions

This is a necessary step for the deprecation of NodeIds after HIR lowering (that is nearly complete), though - otherwise we still need to rely on definitions::opt_def_index,opt_local_def_id. Do you have any suggestions on how to do it in a more elegant manner?

ljedrz

comment created time in 5 months

pull request commentrust-lang/rust

[WIP] Switch rustc allocator to mimalloc

@bors try

gnzlbg

comment created time in 5 months

pull request commentrust-lang/rust

[WIP] Switch rustc allocator to mimalloc

@bors try

gnzlbg

comment created time in 5 months

more