profile
viewpoint

apple/swift 51825

The Swift Programming Language

apple/swift-evolution 11154

This maintains proposals for changes and user-visible enhancements to the Swift Programming Language.

apple/swift-package-manager 7753

The Package Manager for the Swift Programming Language

llvm/llvm-project 4808

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. Note: the repository does not accept github pull requests at this moment. Please submit your patches at http://reviews.llvm.org.

apple/swift-corelibs-foundation 3888

The Foundation Project, providing core utilities, internationalization, and OS independence

apple/swift-corelibs-libdispatch 1817

The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware

apple/swift-corelibs-xctest 822

The XCTest Project, A Swift core library for providing unit test support

apple/swift-llbuild 771

A low-level build system, used by Xcode and the Swift Package Manager

push eventllvm/llvm-project

Chris Lattner

commit sha 919dcc7f6858cf0d9a7442673acafdf495e46c7a

[SourceMgr] Tidy up the SourceMgr header file to include less stuff. Summary: Specifically make some simple refactorings to get PointerUnion.h and Twine.h out of the public includes. While here, trim out a lot of transitive includes as well. Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D78870

view details

push time in a month

push eventllvm/llvm-project

Chris Lattner

commit sha 969e7edd88ceb4791eb1cac22828290f0ae30b3d

[SourceMgr/MLIR diagnostics] Introduce a new method to speed things up Summary: This introduces a new SourceMgr::FindLocForLineAndColumn method that uses the OffsetCache in SourceMgr::SrcBuffer to do do a constant time lookup for the line number (once the cache is populated). Use this method in MLIR's SourceMgrDiagnosticHandler::convertLocToSMLoc, replacing the O(n) scanning logic. This resolves a long standing TODO in MLIR, and makes one of my usecases go dramatically faster (which is currently producing many diagnostics in a 40MB SourceBuffer). NFC, this is just a performance speedup and cleanup. Reviewers: rriddle!, ftynse! Subscribers: hiraditya, mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, Kayjukh, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D78868

view details

push time in a month

push eventllvm/llvm-project

Chris Lattner

commit sha 953a814aae4997e50e73e8d3e6eb699d6b732bbc

Remove the llvm/Support/StringPool.h file and related support now that it has no clients. A plain old StringSet<> is a better replacement. Subscribers: mgorny, hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D78336

view details

push time in a month

push eventllvm/llvm-project

Chris Lattner

commit sha 39c9c12b76da27bd52ca1b82c3d39d9c9b59ad0f

[clang-tools-extra] reimplement PreprocessorTracker in terms of StringSet. Summary: PreprocessorTracker is the last user of the old StringPool class, which isn't super loved and isn't a great improvement over a plan StringSet. Once this goes in we can remove StringPool entirely. This is as discussed on cfe-dev. Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D78273

view details

push time in a month

push eventllvm/llvm-project

Chris Lattner

commit sha 1beffb92d17c8ba54a6c4b3d4e96867403717a3f

Fix the MLIR integer attribute parser to be correct in the face of large integer attributes, it was previously artificially limited to 64 bits. Reviewers: rriddle! Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D78065

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha 359541ed4fd4a3affeb8fe109f3771a40e069bc1

Remove the Identifier::is() method, it is now equivalent to operator==. NFC. Summary: Depends on D78042. Reviewers: rriddle! Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D78043

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha 74e6a5b2a3b0e1992fb38c986b18f1aa7ca6fabd

Eliminate all uses of Identifier::is() in the source tree, this doesn't remove the definition of it (yet). NFC. Reviewers: mravishankar, antiagainst, herhut, rriddle! Subscribers: jholewinski, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, csigg, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, bader, grosul1, frgossen, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D78042

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha d63036c0efd2faf164cbf06328277539fad5cd74

Reimplement mlir::Identifier to be a wrapper around 'StringMapEntry*' instead of a wrapper around a 'const char*'. This makes it so strref() can be computed without calling strlen, which is more efficient and less error-prone. While here... Summary: ..., reimplement DenseMapInfo<mlir::Identifier>::getHashValue in terms of mlir::hash_value(Identifier). Both of these improvements were suggested by River, thanks! Reviewers: rriddle! Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D77999

view details

push time in 2 months

CommitCommentEvent

push eventllvm/llvm-project

Chris Lattner

commit sha 89c8ffd54221cfe2d0b5e391974143d08f047ae0

NFC: Clean up the implementation of StringPool a bit, and remove dependence on some "implicitly MallocAllocator" based methods on StringMapEntry. This allows reducing the #includes in StringMapEntry.h. Summary: StringPool has many caveats and isn't used in the monorepo. I will propose removing it as a patch separate from this refactoring patch. Reviewers: rriddle Subscribers: hiraditya, dexonsmith, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D77976

view details

Chris Lattner

commit sha 4d9f5f135fad9eafa78ded8589af99a593415102

clang format one more line.

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha 617b08ff9bef7b17957781682f78155351b0d2e9

Refactor StringMap.h, splitting StringMapEntry out to its own header. Summary: StringMapEntry.h can have lower dependencies, than StringMap.h, which is useful for public headers that want to expose inline methods on StringMapEntry<> but don't need to expose all of StringMap.h. One example of this is mlir's Identifier.h, another example is the existing LLVM StringPool.h. StringPool also could use a cleanup, I'll deal with that in a follow-on patch. Reviewers: rriddle Subscribers: hiraditya, dexonsmith, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D77963

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha d985b0bf5c8f74c174d47a56809fbb094221322c

A few cosmetic cleanups to StringMap/StringSet.h, including fixing the indentation of the StringSet.h file and its file comment header, and significantly reduce redundant #includes that are already pulled in transitively. NFC. This is in preparation for a more interesting patch I'll post to phab.

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha aef4ec00f996b6b7e5174443ca7db465eb0fae52

Change the identifier table in MLIRContext to use StringSet instead of StringMap<char>, saving a byte due to the StringMapEntry specialization for a value of NoneType. NFC.

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha ed87d9d6434fa3a7dc6f53f1fc5da30994e125fc

Change the implementation of mlir::hash_value(Identifier) to be consistent with DenseMapInfo<mlir::Identifier>::getHashValue. NFC. Adjust a few variable names to follow MLIR convention while here NFC.

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha 0031c7f7dab5489934fc97c783fedbd49a377323

Implement some micro-optimizations for Identifier. NFC Summary: Identifier doesn't maintain a length, so every time strref() is called, it does a strlen. In the case of comparisons, this isn't necessary: there is no need to scan a string to get its length, then rescan it to do the comparison. Just done one comparison. This also moves some assertions in Identifier::get as another microoptimization for 'assertions enabled' modes. Reviewers: rriddle! Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D77958

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha 1c0efa8b54787f9a6994fae1be3377a7c5dc9491

tweak formatting of input to match the output as suggested by River, NFC.

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha ab64fd39d252ec8ddeee7fa73e2534f4b7c079bc

Allow single-bit integer types to have signs. A signed one bit integer is either 0 or -1. Reviewers: rriddle! Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, grosul1, frgossen, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D77832

view details

push time in 2 months

issue commentSwiftCommunityPodcast/podcast

💡 Topic: Swift for Good

Awesome, looking forward to it. Thank you!

BasThomas

comment created time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha 4a219bf7ff6fbe5cbd3b0c2120c8fe471e3f60fa

Fix a bug in the .mlir lexer, where a \0 character in a file is treated as a colon (due to an accidental fall through) instead of whitespace. Summary: While here, simplify the lexer a bit by eliminating the unneeded 'operator' classification of certain sigils, they can just be treated as 'punctuation'. Reviewers: rriddle! Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D76647

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha 42d8f48ccfcd48a1dba76a14a86d45eec27ca649

Fix a warning building on my machine, NFC. warning: unused function 'compilePtxToCubinForTesting' Summary: Also eliminate the redunant anon namespace around the already static function. Reviewers: herhut Subscribers: hiraditya, steven_wu, dexonsmith, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, csigg, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, Joonsoo, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D76627

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha 596da62d21ede197dd95eca5146d2ddf0497275c

Add support for custom op parser/printer hooks to know about result names. Summary: This allows the custom parser/printer hooks to do interesting things with the SSA names. This patch: - Adds a new 'getResultName' method to OpAsmParser that allows a parser implementation to get information about its result names, along with a getNumResults() method that allows op parser impls to know how many results are expected. - Adds a OpAsmPrinter::printOperand overload that takes an explicit stream. - Adds a test.string_attr_pretty_name operation that uses these hooks to do fancy things with the result name. Reviewers: rriddle! Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D76205

view details

push time in 2 months

push eventllvm/llvm-project

Chris Lattner

commit sha 89ecd8c149e482cca814d56113e141457fa90677

Teach the MLIR AsmPrinter to correctly escape asm names that use invalid characters. Reviewers: rriddle! Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75919

view details

Chris Lattner

commit sha e0a93cea56ebfb98c4f3f4b073e6e382868fc34b

incorporate feedback from River.

view details

push time in 3 months

issue commentllvm/mlir-www

Survey paper

Yeah, I agree it would be nice to have a repository of MLIR related talks/papers separate from LLVM. Either a tagging system or a different page would be great. The llvm.org/pubs page is not exactly up to date either :)

bhack

comment created time in 3 months

issue commentllvm/mlir-www

Survey paper

It is great to see MLIR mentioned in this paper! I think it would make sense to add this to something like llvm.org/pubs, which is for papers that mention LLVM related technologies.

bhack

comment created time in 3 months

push eventllvm/llvm-project

Chris Lattner

commit sha c2b2472ca8c3abf272bdf24b5ce633f4bd27fbba

Fix a warning about an unreachable default in a switch statement. Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D75663

view details

push time in 3 months

more