koenpunt ( Koen Punt )

commit sha 3f55677548deadf1f3fd003d11f32f0ef0f62f03

clang-format 11.0.0 add libcxxabi dependency

Attribute issues from enterprise builds with build_type "enterprise" instead of "test"

push time in 4 hours

issue commentgetsentry/sentry-cocoa

I already set environment to production, but the app is released both as enterprise deployment and the App Store, so it would be nice to have the sdk determine that automatically.

@philipphofmann I'll try and see if that works for us.

koenpunt

comment created time in 11 days

create barnchkoenpunt/homebrew-core

branch : update-clang-format

created branch time in 11 days

push eventkoenpunt/homebrew-core

commit sha 494626005d21a9e101ad61c440cb32d421f99d01

add libcxxabi dependency

push time in 11 days

push eventkoenpunt/homebrew-core

commit sha a893dbd671f2cc851e2c89baff453878ed8b3b54

clang-format 11.0.0

branch : bump-clang-format-11.0.0

push time in 11 days

create barnchkoenpunt/homebrew-core

created branch time in 11 days

PR opened Homebrew/homebrew-core

clang-format 11.0.0

Created with brew bump-formula-pr.

resource blocks may require updates.

+2 -2

1 commit in koenpunt/homebrew-core/tree/bump-clang-format-11.0.0 Homebrew/homebrew-core/tree/master

0 comment

2 changed files

pr created time in 11 days

pull request commentgetsentry/sentry-cocoa

Oh I get it, it tried to commit formatting changes. Now ran clang-format locally and updated the PR.

koenpunt

comment created time in 12 days

push eventkoenpunt/sentry-cocoa

commit sha 64461fc16072569a899cecc0c66f49ddf8df4914

`sentry_sanitize` error user info Without sanitizing the user info, `NSURLError`s would cause the sdk and context to be stripped from the event, because the user info of that error contains NSURL object.

commit sha 4ddf2a7158ef08bf1b26e16729db2eefb67e8e58

add CHANGELOG entry

commit sha 3afeedfe6525c90fa711b65010de9a170b856359

add test for error user info sanitization

push time in 12 days

pull request commentgetsentry/sentry-cocoa

The build is failing due to the branch name(?):

  Error: Error: error: pathspec 'patch-1' did not match any file(s) known to git

koenpunt

comment created time in 12 days

pull request commentgetsentry/sentry-cocoa

@philipphofmann I used an URL instead, because that's what was causing the issue for me. Should be good to go!

koenpunt

comment created time in 12 days

push eventkoenpunt/sentry-cocoa

commit sha 606d9a776954cd070bed5fc7df25e53fc70ef217

add test for error user info sanitization

push time in 12 days

push eventkoenpunt/sentry-cocoa

commit sha fd07177b41a6aa9579ce1baa9e0a836e05da1a2c

add test for error user info serialization

push time in 12 days

push eventkoenpunt/sentry-cocoa

Jenn Mueng

commit sha ca3e1052869a93b3b90521889ef09cc456e8f4ed

feat: Expose captureEnvelope on the client (#784)

commit sha 9f61acd851ad4fde9e853fbd7293c5cd9d7a01bd

fix: Using wrong SDK name (#782) The SentryNSURLRequest was using "sentry-cocoa" for the SDK name instead of "sentry.cocoa". This is fixed now.

commit sha 9b9cd1504a7f4234b002cb1edcf9be62170ff1db

meta: Changelog for 6.0.2 (#785)

commit sha 60d8b8fb1fd764144f824e2c195edfa69eac043c

fix: iOS 13.4 Runtime Crash (#786) On iOS 13.4, Apple changed Objective-C runtime code (objc4-781). The structure class_rw_t ro pointer has changed. This fix originates from https://github.com/kstenerud/KSCrash/pull/380.

commit sha 747e9185f3056efdbaa07d44b4ab88bde999083a

release: 6.0.2

commit sha 9ffec423e52d56a1f1f9bdb5289c2bd281223f3d

Merge release/6.0.2 into master

commit sha f9c6ad7bc7337af803dc730bdc5e7b8dfb2a78c7

fix: Making SentrySdkInfo Public (#788) SentrySdkInfo was in the Umbrella header, but not in the public folder. Validate Podspec is now changed so, we can catch such errors in the future.

commit sha 7e24b694937a15d1c62fe56ded4b714440d62e81

meta: Changelog for 6.0.3 (#789)

commit sha 673448c085ab63cc993d481fa5c263ed7f75a088

release: 6.0.3

commit sha 17426c6341fc20d48c76de631debe82793b04f77

Merge release/6.0.3 into master

commit sha eef5560b274f17668ae09f78a41696d84e2fb7a7

fix: Xcode 12 warnings for Cocoapods (#791) When running pod lib lint the following warning was generated: double-quoted include in framework header, expected angle-bracketed instead. Override CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER for Cocoapods with no solves this issue.

commit sha 3293c69b1cc0c08ff8efeb81a6da05eab283b0f5

test: Set macOSX deployment to 10.10 (#787) When running the tests on macOSX the compiler displayed a warning, that the target was built for newer macOS version (10.10) than being linked (10.9). Set macOSX deployment target to 10.10 instead of 10.9 for tests fixes this warning.

commit sha 070169fe8a60effcd2b4438e58a2cd25b2b47b12

ci: Run validate libs on master branch (#790) Rename build.yml to validate-libs.yml, move validate podspec from lint.yml to validate-libs.yml and run validate-libs.yml also on master.

commit sha 7c1f1d0111f2dba4fcd51ca559ed73204a45ed68

ci: Run unit tests with Github Actions (#773)

commit sha 20a4b713a7bd03c77d198f7b77c1c11c9e9df311

`sentry_sanitize` error user info Without sanitizing the user info, `NSURLError`s would cause the sdk and context to be stripped from the event, because the user info of that error contains NSURL object.

commit sha 0be1031e92955fc2632dd77d53205f07e8356221

add import of category for `sentry_sanitize`

commit sha 940721df713b14cf1953eef6d9f2b73ed2a2e6b2

add CHANGELOG entry

push time in 12 days

pull request commentgetsentry/sentry-cocoa

Attribute issues from enterprise builds with build_type "enterprise" instead of "test"

@philipphofmann thanks, I'll try that!

koenpunt

comment created time in 12 days

issue openedgetsentry/sentry-cocoa

Platform:

[x] iOS
[ ] tvOS
[ ] MacOS
[ ] watchOS

Swift:

[ ] Yes -> If yes, which version?
[x] No

sentry-cocoa installed with:

[x] CocoaPods
[ ] Carthage
[ ] Manually

Version of sentry-cocoa: 6.0.0

Currently apps signed and distributed as enterprise apps, are attributed with build_type "test". I'm not completely sure if there's a good way for determining this, but I believe enterprise apps include the embedded.mobileprovision file in the bundle, so maybe that can be used to determine the app is an enterprise build?

created time in 14 days

pull request commentgetsentry/sentry-cocoa

Could you please add some tests to validate this?

As I mentioned in the description; I'm not really sure where I should add a test.

koenpunt

comment created time in 18 days

push eventkoenpunt/sentry-cocoa

commit sha f42a32e9147929c333b6fb144e5f8d8f286f807f

add CHANGELOG entry

push time in 18 days

PR opened getsentry/sentry-cocoa

Reviewers

Patch 1

:scroll: Description

This PR add sanatizing to the error's user info dictionary.

:bulb: Motivation and Context

Certain errors would cause the event to drop the sdk and context properties, because the error's user info contained values that couldn't be serialized as JSON.

:green_heart: How did you test it?

Changed the library in my project locally, and saw the error being reported in Sentry without the "A value set to the context or sdk is not serializable. Dropping context and sdk." breadcrumb, and with the context and sdk properties present.

I'm not sure where I should introduce a test for it. Preferably I would like to add a test that handles an error with problematic user info, and fails without my changes. But since the formatting of the event happens in SentryClient (covered by SentryClientTests), and the serialization in SentrySerialization (covered by SentrySerializationTests), there currently is no way to do that.

:pencil: Checklist

[x] I reviewed the submitted code
[ ] I added tests to verify the changes
[ ] I updated the CHANGELOG
[x] I updated the docs if needed
[x] No breaking changes

:crystal_ball: Next steps

+2 -1

2 commit in koenpunt/sentry-cocoa/tree/patch-1 getsentry/sentry-cocoa/tree/master

0 comment

1 changed file

pr created time in 18 days

push eventkoenpunt/sentry-cocoa

commit sha 3e313512329829ae6a391adc59d9754d62bcc2d2

add import of category for `sentry_sanitize`

push time in 19 days

push eventkoenpunt/sentry-cocoa

commit sha e9e8f6168aa9892a9e9eb027bd27a0e6418625f3

`sentry_sanitize` error user info Without sanitizing the user info, `NSURLError`s would cause the sdk and context to be stripped from the event, because the user info of that error contains NSURL object.

https://sentry.io/for/cocoa/

push time in 19 days

fork koenpunt/sentry-cocoa

The official Sentry SDK for iOS, tvOS, macOS, watchOS

getsentry/sentry-cocoa koenpunt/sentry-cocoa

fork in 19 days

issue commentdannyvankooten/AltoRouter

CURL in Altorouter function calls twice

What do you mean with "add a CURL call"?

TechOverflow

comment created time in a month

delete branch koenpunt/bitmovin-player-ios-samples

delete branch : cocoapods-cdn

delete time in a month

pull request commentfacebook/react-native

[Settings] Correctly update settings after key removal

Ping ✨

koenpunt

comment created time in a month

pull request commentdesktop/desktop

Support disabling repository indicators

Would be great if there's a similar setting added for the background fetcher! (https://github.com/desktop/desktop/issues/1128)

niik

comment created time in a month

startedstrongloop/strong-soap

started time in a month

fork koenpunt/xcode-wakatime

Xcode plugin for automatic time tracking and metrics generated from your programming activity.

https://wakatime.com/xcode

wakatime/xcode-wakatime koenpunt/xcode-wakatime

fork in a month

issue commenthooklift/gowsdl

soup request generated request body without any prefix name space in tags

I have the same issue. Is there a way to get the prefixes?

robatipoor

comment created time in a month

startedhooklift/gowsdl

started time in a month

PR opened getsentry/sentry-docs

fix formatting for swift package manager instructions

+1 -2

1 commit in koenpunt/sentry-docs/tree/patch-1 getsentry/sentry-docs/tree/master

0 comment

1 changed file

pr created time in a month

push eventkoenpunt/sentry-docs

commit sha 1bb43a12e7dfbd60c03d14a37bce403813576668

fix formatting for swift package manager instructions

Breadcrumbs for a native crash have log statements logged as error

push time in a month

fork koenpunt/sentry-docs

The new place for the sentry documentation (and tools to build it)

https://docs.sentry.io

getsentry/sentry-docs koenpunt/sentry-docs

fork in a month

starteddempseyatgithub/BuildSettingExtractor

started time in 2 months

startedsmallmuou/ios-icon-generator

started time in 2 months

issue openedgetsentry/sentry-react-native

OS:

[ ] Windows
[x] macOS
[ ] Linux

Platform:

[x] iOS
[ ] Android

SDK:

[x] @sentry/react-native (>= 1.0.0)
[ ] react-native-sentry (<= 0.43.2)

SDK version: 5.2.2 (RNSentry 1.7.2)

react-native version: 0.62.2

Are you using Expo?

[ ] Yes
[x] No

I have following issue:

Breadcrumbs for a native crash have log statements logged as error

I've tracked this down to RNSentry.addBreadcrumb being called with a level of "log", but that's not a case handled there, so it defaults to kSentryLevelError.

I've searched in this repo for the string "log", but wasn't able to find anything, so it think it originates from one of the Sentry JS modules.

created time in 2 months

PR opened getsentry/sentry-react-native

Reviewers

add missing breaks to log level switch

:loudspeaker: Type of change

[x] Bugfix
[ ] New feature
[ ] Enhancement
[ ] Refactoring

:scroll: Description

Setting the log level didn't work, because the switch would always fall through to kSentryLogLevelNone.

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

[x] I reviewed submitted code
[ ] I added tests to verify changes
[x] All tests passing
[x] No breaking changes

:crystal_ball: Next steps

+3 -0

1 commit in koenpunt/sentry-react-native/tree/patch-1 getsentry/sentry-react-native/tree/master

0 comment

1 changed file

pr created time in 2 months

push eventkoenpunt/sentry-react-native

commit sha b2b868bb013d932daf32eb177d654fa574139178

add missing breaks to log level switch

Option to disable auto-fetching (background fetching) in Desktop

push time in 2 months

fork koenpunt/sentry-react-native

Official Sentry SDK for react-native

https://sentry.io

getsentry/sentry-react-native koenpunt/sentry-react-native

fork in 2 months

issue commentdesktop/desktop

Another issue I'm experiencing with auto fetching; when I reset a commit locally, but that commit was pushed before, GitHub desktop can pull that same commit again, and alter the state of my local copy, which is undesired. I don't really get how this issue has been open for so long. Would a PR that adds a checkbox to the settings for disabling auto fetching be accepted?

cheshire137

comment created time in 2 months

fork koenpunt/desktop

Simple collaboration from your desktop

https://desktop.github.com

desktop/desktop koenpunt/desktop

fork in 2 months

PR opened minvws/nl-covid19-notification-app-ios

Remove duplicate line from README

+1 -3

1 commit in koenpunt/nl-covid19-notification-app-ios/tree/patch-1 minvws/nl-covid19-notification-app-ios/tree/master

0 comment

1 changed file

pr created time in 2 months

push eventkoenpunt/nl-covid19-notification-app-ios

commit sha 990d666c6fae610feb48c6f753150dc1fd785de7

Remove duplicate line from README